[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968658#comment-15968658
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/1282


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968657#comment-15968657
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1282#discussion_r111531779
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
 return true;
 }
 
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --

@rhtyd Missed that change. Closing PR now.


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968333#comment-15968333
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user Slair1 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1282#discussion_r111500346
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
 return true;
 }
 
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --

@rhtyd , you're right, this change has since already been merged by PR 
#977.  


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958439#comment-15958439
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@anshul1886 I've left a comment, the code to check and remove snapshot on 
allocated state is already in that method?


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958436#comment-15958436
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1282#discussion_r110092478
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
 return true;
 }
 
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --

@anshul1886 the code to check and remove snapshot when they are stuck in 
Allocated state is already in line 223 above, in the same method. Why this 
redundancy, is this a synchronization issue?


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958437#comment-15958437
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1282#discussion_r110092518
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
 return true;
 }
 
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --

See 
https://github.com/apache/cloudstack/pull/1282/files#diff-2b08c10a0eea4bef15bece6ff38ed1f9R223


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958381#comment-15958381
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@swill @rhtyd can you review?


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903316#comment-15903316
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 446
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902729#comment-15902729
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@swill Added the return true statement. @rhtyd Snapshot in Allocated state 
means nothing is done for that snapshot so only deletion from DB is needed.


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859784#comment-15859784
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@Slair1 Its missing required reviews and tests.(We have a huge backlog. any 
help in code review/test run is welcome). please refer to 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859771#comment-15859771
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user Slair1 commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@anshul1886 any idea why this hasn't been merged yet?  are there 
concerns/issues?


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304699#comment-15304699
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-43971
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 67
 Hypervisor xenserver
 NetworkType Advanced
 Passed=68
 Failed=4
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_vpc_vpn.py

 * ContextSuite context=TestRVPCSite2SiteVpn>:setup Failed

 * ContextSuite context=TestVpcRemoteAccessVpn>:setup Failing since 2 runs

 * ContextSuite context=TestVpcSite2SiteVpn>:setup Failing since 2 runs

* test_vm_life_cycle.py

 * test_10_attachAndDetach_iso Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266481#comment-15266481
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-216219596
  
@anshul1886 rebase against latest master, thanks

Do you think a cleanup action of some sort be performed, as this will only 
delete the snapshot in database


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262310#comment-15262310
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-215460320
  
@anshul1886 I see in some other places in that file when 
`snapshotDao.remove(snapshotId);` is called there is a `return true` right 
after it.  Can you help me understand why we would or would not do that in this 
case?  Thanks...


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261906#comment-15261906
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-215375588
  
@koushik-das All hypervisor uses XenServerSnapshotStrategy so it should be 
applicable on all hypervisors.


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261740#comment-15261740
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-215350146
  
@anshul1886 The fix is only for XS snapshots. What about other HVs?


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258389#comment-15258389
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user Slair1 commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-214804222
  
Thanks!  I had the same issue, retention settings for snapshots were 
failing because it couldn't delete two snapshots that were stuck in "allocated' 
state.


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214506#comment-15214506
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-202495572
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 140
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_volumes.TestCreateVolume

 * test_02_attach_volume Failing since 2 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069441#comment-15069441
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1282

CLOUDSTACK-9200: Fixed failed to delete snapshot if snapshot is stuck in 
Allocated state without any job associated with it

https://issues.apache.org/jira/browse/CLOUDSTACK-9200

This issue is hard to reproduce but if occurs then it may lead to account 
resources cleanup failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9200

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1282


commit 1fb9b64321dbdbdd42e0cc560c65d45cd08af6c2
Author: Anshul Gangwar 
Date:   2015-12-09T08:33:29Z

CLOUDSTACK-9200: Fixed failed to delete snapshot if snapshot is stuck in 
Allocated state without any job associated with it




> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069676#comment-15069676
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-166910265
  
How do you know if there are no jobs associated with it?


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9200) Account Resources fail to get cleaned up if a snapshot is in Allocated State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070580#comment-15070580
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9200:


Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-167040721
  
@pdube Snapshot can be in Allocated state for a split second only in normal 
scenarios. If it is in Allocated state for more than that time, then it simply 
means we are either restarting or have to restart the management server. Now if 
that's the case then it should have been cleaned up by storage cleanup thread 
during management server start if it has job associated with it. But that is 
not happening so it is falling in this scenario.


> Account Resources fail to get cleaned up if a snapshot is in Allocated State
> 
>
> Key: CLOUDSTACK-9200
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9200
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>
> If a snapshot ( Volume ) is in Allocated state (snapshots table), and if we 
> delete the account associated with that account, it is removed from UI but 
> the account resources (snapshots and virtual machines) are not cleaned up 
> because of the failure to delete the snapshot which is in Allocated state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)