[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286523#comment-15286523 ] Sanjeev N commented on CLOUDSTACK-9380: --- Most of the tests in Regression test suite are failing because of this issue and we are not able to validate the functionalities by running regression. Can somebody please pick this and fix as early as possible? > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.s
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286528#comment-15286528 ] Wei Zhou commented on CLOUDSTACK-9380: -- I will pick it up [~sanjeevn] > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) > at > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577) > at > org.eclipse.jetty.
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286542#comment-15286542 ] ASF GitHub Bot commented on CLOUDSTACK-9380: GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1550 CLOUDSTACK-9380: fix NPE in listDomains API for a mistake The issue happens if volumeTotal is NULL in database. This is caused by commit c25d4fdea2671160deee53ad25f45fab5dc408cb for CLOUDSTACK-7847. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/cloudstack CLOUDSTACK-9380-listDomains-NPE Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1550.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1550 commit 59edbb53378b700c21a6dd722cd92a7286450644 Author: Wei Zhou Date: 2016-05-17T12:45:50Z CLOUDSTACK-9380: fix NPE in listDomains API for a mistake > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.clo
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286939#comment-15286939 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-219772135 Based on code review, LGTM. > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.server.handler.ScopedHandler.handl
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287009#comment-15287009 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-219783461 LGTM > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) >
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287042#comment-15287042 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-219789882 I will run CI against this one to fast track it. Thx... > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.server.handler.
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289066#comment-15289066 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-220046965 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 0 Errors: 4 Duration: 8h 18m 52s ``` **Summary of the problem(s):** ``` ERROR: Test redundant router internals -- Traceback (most recent call last): File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 335, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false zoneid=self.zone.id File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create return Network(apiclient.createNetwork(cmd).__dict__) File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork response = self.connection.marvinRequest(command, response_type=response, method=method) File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest raise e CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 530, errorText:Failed to implement persistent guest network -- Additional details in: /tmp/MarvinLogs/test_network_KRAWPO/results.txt ``` ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download elif 'Downloaded' in template.status: TypeError: argument of type 'NoneType' is not iterable -- Additional details in: /tmp/MarvinLogs/test_network_KRAWPO/results.txt ``` ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 293, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download elif 'Downloaded' in template.status: TypeError: argument of type 'NoneType' is not iterable -- Additional details in: /tmp/MarvinLogs/test_network_KRAWPO/results.txt ``` ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297631#comment-15297631 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-221160504 ### CI RESULTS ``` Tests Run: 78 Skipped: 0 Failed: 0 Errors: 4 Duration: 7h 14m 41s ``` **Summary of the problem(s):** ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 296, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download elif 'Downloaded' in template.status: TypeError: argument of type 'NoneType' is not iterable -- Additional details in: /tmp/MarvinLogs/test_network_19G4TV/results.txt ``` ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download elif 'Downloaded' in template.status: TypeError: argument of type 'NoneType' is not iterable -- Additional details in: /tmp/MarvinLogs/test_network_19G4TV/results.txt ``` ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 293, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download elif 'Downloaded' in template.status: TypeError: argument of type 'NoneType' is not iterable -- Additional details in: /tmp/MarvinLogs/test_network_19G4TV/results.txt ``` ``` ERROR: test suite for -- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run return func() File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass cls.template.download(cls.apiclient) File "/usr/lib/python2.7/si
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297633#comment-15297633 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-221160650 This is a clean CI run. The failures are not related to this PR. > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.server
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301406#comment-15301406 ] ASF subversion and git services commented on CLOUDSTACK-9380: - Commit 550aabb3082e2df4787ada8904f67b086213db09 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=550aabb ] Merge pull request #1550 from ustcweizhou/CLOUDSTACK-9380-listDomains-NPE CLOUDSTACK-9380: fix NPE in listDomains API for a mistakeThe issue happens if volumeTotal is NULL in database. This is caused by commit 0407fb334f3a79f570217f35636b47076b06d500 for CLOUDSTACK-7847. * pr/1550: CLOUDSTACK-9380: fix NPE in listDomains API for a mistake Signed-off-by: Will Stevens > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.clou
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301409#comment-15301409 ] ASF subversion and git services commented on CLOUDSTACK-9380: - Commit 550aabb3082e2df4787ada8904f67b086213db09 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=550aabb ] Merge pull request #1550 from ustcweizhou/CLOUDSTACK-9380-listDomains-NPE CLOUDSTACK-9380: fix NPE in listDomains API for a mistakeThe issue happens if volumeTotal is NULL in database. This is caused by commit 0407fb334f3a79f570217f35636b47076b06d500 for CLOUDSTACK-7847. * pr/1550: CLOUDSTACK-9380: fix NPE in listDomains API for a mistake Signed-off-by: Will Stevens > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.clou
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301407#comment-15301407 ] ASF subversion and git services commented on CLOUDSTACK-9380: - Commit 550aabb3082e2df4787ada8904f67b086213db09 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=550aabb ] Merge pull request #1550 from ustcweizhou/CLOUDSTACK-9380-listDomains-NPE CLOUDSTACK-9380: fix NPE in listDomains API for a mistakeThe issue happens if volumeTotal is NULL in database. This is caused by commit 0407fb334f3a79f570217f35636b47076b06d500 for CLOUDSTACK-7847. * pr/1550: CLOUDSTACK-9380: fix NPE in listDomains API for a mistake Signed-off-by: Will Stevens > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.clou
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301426#comment-15301426 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1550 > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587) > at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) > at > org.eclipse.jetty.security.S
[jira] [Commented] (CLOUDSTACK-9380) listDomains API returns NPE if there is a failure in deleting domains
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301609#comment-15301609 ] ASF GitHub Bot commented on CLOUDSTACK-9380: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-221788191 I ran bunch of tests(related to network functionality) from the regression test suite(test/integration/component) on this PR branch and I don't see any test failures because of list domains issue which I mentioned in the bug CLOUDSTACK-9380. LGTM !! > listDomains API returns NPE if there is a failure in deleting domains > - > > Key: CLOUDSTACK-9380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0 > Environment: Latest build from master >Reporter: Sanjeev N >Priority: Critical > Fix For: 4.9.0 > > Attachments: cloud.sql, vmops.log > > > listDomains API returns NPE if there is a failure in deleting domains > Steps to Reproduce: > > 1.Create few domains under root domain and create one or two accounts in each > domain > 2.Create few vms, volumes, snapshots with those accounts. > 3.Now delete the domains and for one of the domains simulate the domain > deletion failure > 4.Try to list the domains using listDomains api without any domain id paramter > Result: > == > listDomains API returns error code 530 and in the management server log we > see following NPE: > 2016-05-16 08:53:09,273 ERROR [c.c.a.ApiServer] > (qtp237306958-12297:ctx-8f28bbf4 ctx-fdb614d0 ctx-6466fb85) (logid:d17482a8) > unhandled exception executing api command: [Ljava.lang.String;@652d471e > java.lang.NullPointerException > at > com.cloud.api.query.dao.DomainJoinDaoImpl.setResourceLimits(DomainJoinDaoImpl.java:113) > at > com.cloud.api.query.dao.DomainJoinDaoImpl.newDomainResponse(DomainJoinDaoImpl.java:76) > at sun.reflect.GeneratedMethodAccessor351.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) > at > com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) > at > org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) > at > org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) > at com.sun.proxy.$Proxy272.newDomainResponse(Unknown Source) > at com.cloud.api.ApiDBUtils.newDomainResponse(ApiDBUtils.java:1834) > at > com.cloud.api.query.ViewResponseHelper.createDomainResponse(ViewResponseHelper.java:354) > at > com.cloud.api.query.QueryManagerImpl.searchForDomains(QueryManagerImpl.java:1880) > at > org.apache.cloudstack.api.command.admin.domain.ListDomainsCmd.execute(ListDomainsCmd.java:87) > at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) > at com.cloud.api.ApiServer.queueCommand(ApiServer.java:705) > at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529) > at > com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299) > at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) > at > org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) > at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) > at com.cloud.api.ApiServlet.doGet(ApiServlet.java:88) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServ