[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589647#comment-15589647
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@mlsorensen We can indeed do that, but the good thing for now is that the 
RNG is disabled by default.

You also need a very ancient libvirt for it not to support RNG and that 
will get less and less over time.


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589200#comment-15589200
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user mlsorensen commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
I realize I'm late to the party on this, but I'd like to suggest that we 
change from the agent.properties "vm.rng.enable=true" to simply using the 
libvirt version detection like we do for other things, and perhaps allow a 
"vm.rng.disable". It really seems like this is a useful setting and should 
probably be default wherever possible.


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572461#comment-15572461
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@rhtyd my point is that, even if its run on KVM, this functionality wont be 
covered with existing tests. I agree to your point. It was just that I had xen 
tests available and another run on KVM would take huge amount of effort from my 
side and at the end wont test the new functionality.

Thanks for the email. will go through.

I went through the commits on #1692. It has two bug fixes(CLOUDSTACK-9515, 
CLOUDSTACK-9533) and some test fixes. I dont see why its a blocker for commits 
to master. (probably the mail has some context. will go through)



> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572430#comment-15572430
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@karuturi I think it beats the purpose of smoke tests if we don't run them 
against the hypervisor(s) the PR/change is most likely related to. Without 
valid test results it is hard to validate a change/PR, the guideline was to 
have two LGTMs and at least one test result/run though I agree any committer 
should be able to merge a PR. This is the email thread you're looking for:
http://markmail.org/message/xp7ckhxhip2rbnr7

For the past two weeks several of us are trying to fix tests/issues and get 
most of the smoke tests pass on all three major hypervisors. You may follow 
that effort on PR #1692 and #1703 that uses Trillian 
(https://github.com/shapeblue/Trillian).


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572381#comment-15572381
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
1. the current set of integration tests doesnt test the new functionality 
added in this PR. Its merely a check to see nothing else is broken.
2. when did we freeze? I skimmed through the mails didnt see anything about 
master frozen. I do not see any blocker defects for 4.10.0.0. The latest 
understanding I have is anybody can merge with required code LGTMs and a BVT 
run.
3. Which smoke tests are broken? Is it you environment issue you are 
talking about? If not, are these new or did we release 4.9.0 with these broken 
tests/features?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571899#comment-15571899
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@karuturi am I missing the test results on this PR for the enhancements?  
All I see are tests against XenServer which have no bearing on this change.   
Why was this PR merged without a full run against KVM and while we are frozen 
to fix the smoke test suite? 


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571520#comment-15571520
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1572


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571518#comment-15571518
 ] 

ASF subversion and git services commented on CLOUDSTACK-9395:
-

Commit c9e14c9f0885e8d8360f74997773aad16e9c8b19 in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9e14c9 ]

Merge pull request #1572 from wido/virtio-rng

CLOUDSTACK-9395: Add Virtio RNG device to Instances when configuredBy adding a 
Random Number Generator device to Instances we can prevent
entropy starvation inside guest.

The default source is /dev/random on the host, but this can be configured
to another source when present, for example a hardware RNG.

When enabled it will add the following to the Instance's XML definition:

  
/dev/random
  

If the Instance has the proper support, which most modern distributions have,
it will have a /dev/hwrng device which it can use for gathering entropy.

* pr/1572:
  CLOUDSTACK-9395: Add Virtio RNG device to Instances when configured

Signed-off-by: Rajani Karuturi 


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571519#comment-15571519
 ] 

ASF subversion and git services commented on CLOUDSTACK-9395:
-

Commit c9e14c9f0885e8d8360f74997773aad16e9c8b19 in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c9e14c9 ]

Merge pull request #1572 from wido/virtio-rng

CLOUDSTACK-9395: Add Virtio RNG device to Instances when configuredBy adding a 
Random Number Generator device to Instances we can prevent
entropy starvation inside guest.

The default source is /dev/random on the host, but this can be configured
to another source when present, for example a hardware RNG.

When enabled it will add the following to the Instance's XML definition:

  
/dev/random
  

If the Instance has the proper support, which most modern distributions have,
it will have a /dev/hwrng device which it can use for gathering entropy.

* pr/1572:
  CLOUDSTACK-9395: Add Virtio RNG device to Instances when configured

Signed-off-by: Rajani Karuturi 


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571517#comment-15571517
 ] 

ASF subversion and git services commented on CLOUDSTACK-9395:
-

Commit 0beb41b6e7d5177a64ac12d86d31c0766dc58d03 in cloudstack's branch 
refs/heads/master from [~widodh]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0beb41b ]

CLOUDSTACK-9395: Add Virtio RNG device to Instances when configured

By adding a Random Number Generator device to Instances we can prevent
entropy starvation inside guest.

The default source is /dev/random on the host, but this can be configured
to another source when present, for example a hardware RNG.

When enabled it will add the following to the Instance's XML definition:

  

/dev/random
  

If the Instance has the proper support, which most modern distributions have,
it will have a /dev/hwrng device which it can use for gathering entropy.

More information: https://libvirt.org/formatdomain.html#elementsRng


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571514#comment-15571514
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
code LGTM
  from @ustcweizhou and there are test runs
I am merging this now.


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469713#comment-15469713
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
Can I get a review on this one so it can be merged?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372502#comment-15372502
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
No LGTM on this one yet. Are we good @ustcweizhou and @remibergsma ?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339468#comment-15339468
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 203
 Hypervisor xenserver
 NetworkType Advanced
 Passed=71
 Failed=2
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_vpc_vpn.py

 * ContextSuite context=TestRVPCSite2SiteVpn>:setup Failing since 23 runs

* test_volumes.py

 * test_06_download_detached_volume Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320174#comment-15320174
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
Did you get a chance to take a look @remibergsma ?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316799#comment-15316799
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
Thanks @wido will have a look


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316303#comment-15316303
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
Ok, thanks @ustcweizhou . Could you take a technical look and see if you 
LGTM?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316290#comment-15316290
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@wido  thanks. it sound fine to me.


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316285#comment-15316285
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@remibergsma: Could you check again? You can now set the rate with period 
and bytes to prevent exhaustion.


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315587#comment-15315587
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1572
  
@wido Thanks for the feature, I like it! Although I'm a bit worried that 
many VMs could potentially exhaust the hypervisor's `/dev/random`? How do you 
handle that?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307360#comment-15307360
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1572#issuecomment-222612848
  
@ustcweizhou: You need at least libvirt 1.0.3. Ubuntu 14.04 contains 
Libvirt 1.2.2, so with that hypervisor you are fine.


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307348#comment-15307348
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1572#issuecomment-222611860
  
@wido what is the minimum of qemu/libvirt version this require? maybe 
better to add some version check ?


> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9395) Add VirtIO Random Number Geneator to KVM Instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306903#comment-15306903
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9395:


GitHub user wido opened a pull request:

https://github.com/apache/cloudstack/pull/1572

CLOUDSTACK-9395: Add Virtio RNG device to Instances when configured

By adding a Random Number Generator device to Instances we can prevent
entropy starvation inside guest.

The default source is /dev/random on the host, but this can be configured
to another source when present, for example a hardware RNG.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack virtio-rng

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1572


commit 2c4e683b8db9ee77ac54607b0ada501cdc7024a7
Author: Wido den Hollander 
Date:   2016-05-30T14:56:19Z

CLOUDSTACK-9395: Add Virtio RNG device to Instances when configured

By adding a Random Number Generator device to Instances we can prevent
entropy starvation inside guest.

The default source is /dev/random on the host, but this can be configured
to another source when present, for example a hardware RNG.




> Add VirtIO Random Number Geneator to KVM Instances
> --
>
> Key: CLOUDSTACK-9395
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9395
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>  Labels: kvm, libvirt, virtio
> Fix For: Future
>
>
> Add a VirtIO Random Number Generator (RNG) to all Instances to prevent 
> entropy starvation in guests.
> More information:
> - https://libvirt.org/formatdomain.html
> - https://fedoraproject.org/wiki/Features/Virtio_RNG
> In the end this make sure the Entropy performance in Instances is better



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)