[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[syed ahmed (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387719#comment-15387719
 ] 

syed ahmed commented on CLOUDSTACK-9423:


Closed via  https://github.com/apache/cloudstack/pull/1598

> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[Patrick D. (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387705#comment-15387705
 ] 

Patrick D. commented on CLOUDSTACK-9423:


[~sahmed] Is the issue resolved? If so, could you update this ticket please?

> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360792#comment-15360792
 ] 

ASF subversion and git services commented on CLOUDSTACK-9423:
-

Commit 1f9bf93948b37f3132f55ea6ce7041cae57696da in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1f9bf93 ]

Merge pull request #1598 from syed/vhd-compressed-size

[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDsWith object 
store like Swift as secondary storage, if a compressed VHD is uploaded as a 
template, the `VHDProcessor` incorrectly calculates the virutal size leading to 
the template being useless. This fix tries to guess the virtual size by 
partially decompressing it and falls back to a sensible default which is the 
size of the file.

Before the fix: template.properties on Swift
```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=2894447637315205059
```
After the fix

```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=3145728000
```

Look at the `virutalsize` in both cases

* pr/1598:
  [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs

Signed-off-by: Will Stevens 


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360791#comment-15360791
 ] 

ASF subversion and git services commented on CLOUDSTACK-9423:
-

Commit b0247b53f99ff97fd05d4d8528115ed6e7d497c0 in cloudstack's branch 
refs/heads/master from [~syed1]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b0247b5 ]

[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360793#comment-15360793
 ] 

ASF subversion and git services commented on CLOUDSTACK-9423:
-

Commit 1f9bf93948b37f3132f55ea6ce7041cae57696da in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1f9bf93 ]

Merge pull request #1598 from syed/vhd-compressed-size

[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDsWith object 
store like Swift as secondary storage, if a compressed VHD is uploaded as a 
template, the `VHDProcessor` incorrectly calculates the virutal size leading to 
the template being useless. This fix tries to guess the virtual size by 
partially decompressing it and falls back to a sensible default which is the 
size of the file.

Before the fix: template.properties on Swift
```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=2894447637315205059
```
After the fix

```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=3145728000
```

Look at the `virutalsize` in both cases

* pr/1598:
  [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs

Signed-off-by: Will Stevens 


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360794#comment-15360794
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1598


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357551#comment-15357551
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1598


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357552#comment-15357552
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


GitHub user syed reopened a pull request:

https://github.com/apache/cloudstack/pull/1598

[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs

With object store like Swift as secondary storage, if a compressed VHD is 
uploaded as a template, the `VHDProcessor` incorrectly calculates the virutal 
size leading to the template being useless. This fix tries to guess the virtual 
size by partially decompressing it and falls back to a sensible default which 
is the size of the file. 

Before the fix: template.properties on Swift
```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=2894447637315205059
```
After the fix

```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=3145728000
```

Look at the `virutalsize` in both cases

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack vhd-compressed-size

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1598






> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357529#comment-15357529
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1598


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357530#comment-15357530
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


GitHub user syed reopened a pull request:

https://github.com/apache/cloudstack/pull/1598

[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs

With object store like Swift as secondary storage, if a compressed VHD is 
uploaded as a template, the `VHDProcessor` incorrectly calculates the virutal 
size leading to the template being useless. This fix tries to guess the virtual 
size by partially decompressing it and falls back to a sensible default which 
is the size of the file. 

Before the fix: template.properties on Swift
```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=2894447637315205059
```
After the fix

```
uniquename=routing-1
filename=routing-1.vhd
size=263417314
virtualsize=3145728000
```

Look at the `virutalsize` in both cases

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/syed/cloudstack vhd-compressed-size

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1598


commit b0247b53f99ff97fd05d4d8528115ed6e7d497c0
Author: Syed 
Date:   2016-06-27T20:11:14Z

[CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs




> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355476#comment-15355476
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
@swill if you can merge this before you cut the release, it would be 
awesome. 


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353263#comment-15353263
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
Good enough.  Thanks...  :)


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353232#comment-15353232
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
@swill. I've fixed the whitespaces and rebased everything. Should be good 
now. 




> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353213#comment-15353213
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1598#discussion_r68779423
  
--- Diff: core/src/com/cloud/storage/template/VhdProcessor.java ---
@@ -91,27 +97,58 @@ public long getVirtualSize(File file) throws 
IOException {
 return file.length();
 }
 
-protected long getTemplateVirtualSize(File file) throws IOException {
+protected long getTemplateVirtualSize(File file) throws 
IOException {
 byte[] currentSize = new byte[8];
+byte[] cookie = new byte[8];
 byte[] creatorApp = new byte[4];
 
-try (FileInputStream strm = new FileInputStream(file)) {
-long skipped = strm.skip(file.length() - vhdFooterSize + 
vhdFooterCreatorAppOffset);
+
+BufferedInputStream fileStream = new BufferedInputStream(new 
FileInputStream(file));
+InputStream strm = fileStream;
+
+boolean isCompressed = checkCompressed(file.getAbsolutePath());
+
+if ( isCompressed ) {
+try {
+strm = new 
CompressorStreamFactory().createCompressorInputStream(fileStream);
+} catch (CompressorException e) {
+s_logger.info("error opening compressed VHD file " + 
file.getName());
+return file.length();
+}
+}
+
+try {
+
--- End diff --

Can you remove the unneeded line break here since I already have another 
change for you to make.  :)  Thx...


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353219#comment-15353219
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
@syed, can you do a once through and clean up some of the white space 
issues in this diff.  I have highlighted a couple.  The method indent is the 
most important, but there are a few other cases where the white space can be 
cleaned up as well.  Thx...


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353209#comment-15353209
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1598#discussion_r68779079
  
--- Diff: core/src/com/cloud/storage/template/VhdProcessor.java ---
@@ -91,27 +97,58 @@ public long getVirtualSize(File file) throws 
IOException {
 return file.length();
 }
 
-protected long getTemplateVirtualSize(File file) throws IOException {
+protected long getTemplateVirtualSize(File file) throws 
IOException {
--- End diff --

Can you fix the method indentation here.  This should not be indented that 
extra tab.


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353154#comment-15353154
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
This is coming back clean.  Since it fixes issues in 4.9, I think it should 
be merged...


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353149#comment-15353149
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 07m 10s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600/runinfo.txt)

**`/tmp/MarvinLogs/test_network_HRWEBW:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_network_HRWEBW/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_network_HRWEBW/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_network_HRWEBW/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_Z3TJCB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_vpc_routers_Z3TJCB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_vpc_routers_Z3TJCB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_vpc_routers_Z3TJCB/runinfo.txt)


Uploads will be available until `2016-08-28 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352167#comment-15352167
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
Thank you. I have CI running and I should have results later tonight. 


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352166#comment-15352166
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
Yes @swill I've tested this on my local setup.

On Mon, Jun 27, 2016 at 5:16 PM, Will Stevens 
wrote:

> @syed  my understanding is that you have tested
> this fix with swift in our lab. That is correct?
>
> I will get CI run against it to make sure this does not break anything
> outside swift.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351833#comment-15351833
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
@syed my understanding is that you have tested this fix with swift in our 
lab.  That is correct?

I will get CI run against it to make sure this does not break anything 
outside swift.


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)