[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695149#comment-15695149 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1635 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695147#comment-15695147 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/4.8 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695146#comment-15695146 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/4.8 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695150#comment-15695150 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/4.8 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695142#comment-15695142 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 53fd4a7997034478f422f6b996644ca9a0ea7919 in cloudstack's branch refs/heads/4.8 from [~nathanejohnson] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53fd4a7 ] CLOUDSTACK-9451 Honor the forced parameter to stop virtual machine api call. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695141#comment-15695141 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/4.9 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695138#comment-15695138 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/4.9 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695139#comment-15695139 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/4.9 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695136#comment-15695136 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 53fd4a7997034478f422f6b996644ca9a0ea7919 in cloudstack's branch refs/heads/4.9 from [~nathanejohnson] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53fd4a7 ] CLOUDSTACK-9451 Honor the forced parameter to stop virtual machine api call. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695120#comment-15695120 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695119#comment-15695119 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695121#comment-15695121 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 5811d33658fe1651e43dcca67c35c712f9ba4107 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811d33 ] Merge pull request #1635 from myENA/feature/honor_force_stop_vm CLOUDSTACK-9451https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. * pr/1635: CLOUDSTACK-9451 Signed-off-by: Rohit Yadav > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695116#comment-15695116 ] ASF subversion and git services commented on CLOUDSTACK-9451: - Commit 53fd4a7997034478f422f6b996644ca9a0ea7919 in cloudstack's branch refs/heads/master from [~nathanejohnson] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53fd4a7 ] CLOUDSTACK-9451 Honor the forced parameter to stop virtual machine api call. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695084#comment-15695084 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 Test LGTM, the two failures are intermittent and env related. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693978#comment-15693978 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Trillian test result (tid-427) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28223 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1635-t427-kvm-centos7.zip Test completed. 41 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 225.67 | test_vpc_redundant.py test_10_attachAndDetach_iso | `Failure` | 684.22 | test_vm_life_cycle.py test_01_vpc_site2site_vpn | Success | 161.39 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 67.19 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 264.00 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 271.42 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 572.64 | test_vpc_router_nics.py test_04_rvpc_network_garbage_collector_nics | Success | 1344.16 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 576.07 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 753.98 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1333.54 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 15.85 | test_volumes.py test_08_resize_volume | Success | 15.67 | test_volumes.py test_07_resize_fail | Success | 20.57 | test_volumes.py test_06_download_detached_volume | Success | 15.49 | test_volumes.py test_05_detach_volume | Success | 100.30 | test_volumes.py test_04_delete_attached_volume | Success | 10.42 | test_volumes.py test_03_download_attached_volume | Success | 15.48 | test_volumes.py test_02_attach_volume | Success | 73.83 | test_volumes.py test_01_create_volume | Success | 734.50 | test_volumes.py test_deploy_vm_multiple | Success | 285.29 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.04 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.27 | test_vm_life_cycle.py test_08_migrate_vm | Success | 41.36 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.22 | test_vm_life_cycle.py test_06_destroy_vm | Success | 126.11 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.36 | test_vm_life_cycle.py test_02_start_vm | Success | 10.25 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.47 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 61.25 | test_templates.py test_08_list_system_templates | Success | 0.04 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.08 | test_templates.py test_04_extract_template | Success | 5.25 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.20 | test_templates.py test_01_create_template | Success | 40.62 | test_templates.py test_10_destroy_cpvm | Success | 161.95 | test_ssvm.py test_09_destroy_ssvm | Success | 163.64 | test_ssvm.py test_08_reboot_cpvm | Success | 101.75 | test_ssvm.py test_07_reboot_ssvm | Success | 133.77 | test_ssvm.py test_06_stop_cpvm | Success | 132.21 | test_ssvm.py test_05_stop_ssvm | Success | 133.95 | test_ssvm.py test_04_cpvm_internals | Success | 1.27 | test_ssvm.py test_03_ssvm_internals | Success | 3.65 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.20 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.26 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.40 | test_snapshots.py test_04_change_offering_small | Success | 205.01 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.18 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_09_reboot_router | Success | 40.52 | test_routers.py test_08_start_router | Success | 35.43 | test_routers.py test_07_stop_router | Success | 10.20 | test_routers.py test_06_router_advanced | Success | 0.07 | test_routers.py test_05_router_basic | Success | 0.05 | test_routers.py test_04_restart_network_wo_cleanup | Success | 5.73 | test_routers.py test_03_rest
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692746#comment-15692746 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692744#comment-15692744 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 Checked centos6 failed due to an intermittent unit test failure, we can ignore that for now. @blueorangutan test > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692725#comment-15692725 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-248 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692528#comment-15692528 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692523#comment-15692523 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @blueorangutan package > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681608#comment-15681608 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd @jburwell I believe the last commit should have addressed his concerns. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681540#comment-15681540 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-203 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680722#comment-15680722 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680724#comment-15680724 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson can you reply to @jburwell 's comments > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680721#comment-15680721 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @blueorangutan package > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594442#comment-15594442 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-78 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594119#comment-15594119 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594098#comment-15594098 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1635 @blueorangutan package > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471758#comment-15471758 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1635 I did find one marvin test that does pass forced flag. Here are the results. https://gist.github.com/nathanejohnson/c4d1ffb8b61b19a8105dcb5326794b15 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458762#comment-15458762 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1635 @jburwell sorry I've been silent, I've been on vacation for a bit and I will be juggling plans this weekend as well. I plan to update this PR soon, and as far as a Marvin test I am not aware of any current tests that would cover this. I haven't forgotten about this but it might be a few days yet before I can dig in fully. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457123#comment-15457123 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson I want to get this bug fix into 4.8.2.0. In order to make it, we need to complete the following: * [] Resolve the question about the name of the method (``stop`` vs ``forcedStop``) * [] Amend the commit message to summarize the change and explain the reason/motivation for it * [] Code review LGTM * [] Test LGTM @rhtyd or I will provide the code review LGTM once we resolve the naming question. Do you have someone who can run the test? Also, is this change something we can check via a Marvin test case? > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457116#comment-15457116 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1635#discussion_r77279256 --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java --- @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan plan, E boolean stop(String caller) throws ResourceUnavailableException, CloudException; /** + * Stop the virtual machine, optionally force + * + */ +boolean stop(String caller, boolean forced) throws ResourceUnavailableException, CloudException; --- End diff -- @rhtyd since this PR adds new methods, let's not carry it forward. The implementation of ``forceStop`` would end up passing ``true`` for the ``forced`` flag down the stack, but at least we are not expanding an anti-pattern. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445210#comment-15445210 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1635#discussion_r76569173 --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java --- @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan plan, E boolean stop(String caller) throws ResourceUnavailableException, CloudException; /** + * Stop the virtual machine, optionally force + * + */ +boolean stop(String caller, boolean forced) throws ResourceUnavailableException, CloudException; --- End diff -- @jburwell the `forced` flag has always existed, the `stopVirtualMachine` API accepts this and the query layer too has a method with this signature (https://github.com/apache/cloudstack/pull/1635/files#diff-0a1cd9df984252594918eec5acfed08cR3850) but it does not honour or pass this flag to the layers below, so effectively stopVM API with/without the `forced` flag has the same effect. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444715#comment-15444715 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1635#discussion_r76550534 --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java --- @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan plan, E boolean stop(String caller) throws ResourceUnavailableException, CloudException; /** + * Stop the virtual machine, optionally force + * + */ +boolean stop(String caller, boolean forced) throws ResourceUnavailableException, CloudException; --- End diff -- @nathanejohnson I wasn't thinking to change any of the existing code. I am just interested in avoiding incurring any more flag argument technical debt. In terms of testing, this change is not hypervisor specific. Therefore, a test case that utilizes the simulator might be a more fruitful path. @rhtyd may have some thoughts as to how you could accomplish it. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444618#comment-15444618 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user nathanejohnson commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1635#discussion_r76547668 --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java --- @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan plan, E boolean stop(String caller) throws ResourceUnavailableException, CloudException; /** + * Stop the virtual machine, optionally force + * + */ +boolean stop(String caller, boolean forced) throws ResourceUnavailableException, CloudException; --- End diff -- For better or worse, I was just trying to follow the lead of the actual method that does the work in question, namely advanceStop, and some of the methods called from advanceStop. I have no issue changing the name to have force in it and skip the bool flag (lest Fowler think I'm a bad programmer), but I am not thinking that I'd like to change the signature of advanceStop or any other the other methods that eventually get called in the chain where there is a bool flag in it. I think the much bigger issue with this bit of code is that the refactor that lead to this issue in the first place abstracted the call to advanceStop under so many layers that it made it really hard to notice that functionality was reduced in the first place, to the point where the author nor anyone reviewing caught it. If I was to place serious energy into refactoring, I'd probably start with undoing a lot of that abstraction, but that would require me being familiar with a lot more of the codebase than I currently am. Also, more immediately, I want to come up with a good test for this, but so far haven't been able to come up with something reliable / reproducible under kvm. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1582#comment-1582 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1635#discussion_r76544594 --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java --- @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan plan, E boolean stop(String caller) throws ResourceUnavailableException, CloudException; /** + * Stop the virtual machine, optionally force + * + */ +boolean stop(String caller, boolean forced) throws ResourceUnavailableException, CloudException; --- End diff -- [Flag arguments](http://martinfowler.com/bliki/FlagArgument.html) are a nasty code smell/anti-pattern. Please consider changing method to something more descriptive with a flag argument such as ``forceStop(String caller)``. The contrasting version of the method already exists on the interface so it would be a compatible change. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435261#comment-15435261 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 I'll let him comment on this, but If I recall, it had more to do with implementation of force stopping with KVM rather than the lack of the parameter being passing into the VM Manager. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435230#comment-15435230 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1635 All hypervisors are affected by this, since the parameter is just not passed into the VM Manager. That means its effects don't work at all anywhere. :) I will try to review it to tomorrow. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435217#comment-15435217 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 @ProjectMoon Jeff, could you help review this, as I believe you were the first to point it out on the list. From talking to Nathan, it sounds like we're not sure KVM is actually affected by this bug. He was in the process of doing some digging. Regardless of that, it probably affects other hypervisors. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432141#comment-15432141 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson please amend your commit message to explain the change(s) made and their motivation? > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431801#comment-15431801 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1635 Job ID-95 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427928#comment-15427928 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1635 LGTM > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417368#comment-15417368 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 References: https://github.com/apache/cloudstack/pull/1632 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417165#comment-15417165 ] ASF GitHub Bot commented on CLOUDSTACK-9451: GitHub user nathanejohnson opened a pull request: https://github.com/apache/cloudstack/pull/1635 CLOUDSTACK-9451 https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/myENA/cloudstack feature/honor_force_stop_vm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1635.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1635 commit d5471b94e7617565836c1460007cbf6afa4c12ec Author: Nathan Johnson Date: 2016-08-11T12:52:05Z CLOUDSTACK-9451 https://issues.apache.org/jira/browse/CLOUDSTACK-9451 Re-doing against 4.8 since this is a bug, not a feature. > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417143#comment-15417143 ] ASF GitHub Bot commented on CLOUDSTACK-9451: Github user nathanejohnson closed the pull request at: https://github.com/apache/cloudstack/pull/1632 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9451) stopVirtualMachine ignores forced parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414076#comment-15414076 ] ASF GitHub Bot commented on CLOUDSTACK-9451: GitHub user nathanejohnson opened a pull request: https://github.com/apache/cloudstack/pull/1632 Honor the forced parameter for stopVirtualMachine api call CLOUDSTACK-9451 https://issues.apache.org/jira/browse/CLOUDSTACK-9451 You can merge this pull request into a Git repository by running: $ git pull https://github.com/myENA/cloudstack feature/honor_force_stop_vm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1632.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1632 commit 8e8b511388df62eef9a5488677a57417c32d67db Author: Nathan Johnson Date: 2016-08-09T19:16:00Z Honor the forced parameter for stopVirtualMachine api call CLOUDSTACK-9451 > stopVirtualMachine ignores forced parameter > --- > > Key: CLOUDSTACK-9451 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9451 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Affects Versions: 4.8.0, 4.9.0 >Reporter: Nathan Johnson >Priority: Minor > > As reported by Jeff Hair from the mailing list: > Hi, > I'm looking at the documentation and then the code for stopVirtualMachine. > The forced parameter is passed down into the VM manager, where it seems to > be ignored. This means that cleanupEvenIfFailed during VM stop will always > be false, despite what the API command says. Going back to commit a4f4c986 > in 2013, we can see that the forced parameter was used. During subsequent > refactoring, this seems to have vanished. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
