[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-08-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109570#comment-16109570
 ] 

ASF subversion and git services commented on CLOUDSTACK-9684:
-

Commit 6977cb38411efc72ddf81c6d6bf41bbbca06b852 in cloudstack's branch 
refs/heads/master from [~sateeshc]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6977cb3 ]

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=
While listing datacenters associated with a zone, only zone Id validation is 
required.
There is no need to have additional checks like zone is a legacy zone or not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi 
(cherry picked from commit 0ef1c17541808641983e7c109db31e5cecc0ef44)
Signed-off-by: Rohit Yadav 


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.1.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-08-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109536#comment-16109536
 ] 

ASF subversion and git services commented on CLOUDSTACK-9684:
-

Commit 6977cb38411efc72ddf81c6d6bf41bbbca06b852 in cloudstack's branch 
refs/heads/4.10 from [~sateeshc]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6977cb3 ]

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=
While listing datacenters associated with a zone, only zone Id validation is 
required.
There is no need to have additional checks like zone is a legacy zone or not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi 
(cherry picked from commit 0ef1c17541808641983e7c109db31e5cecc0ef44)
Signed-off-by: Rohit Yadav 


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.1.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-08-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109498#comment-16109498
 ] 

ASF subversion and git services commented on CLOUDSTACK-9684:
-

Commit 6977cb38411efc72ddf81c6d6bf41bbbca06b852 in cloudstack's branch 
refs/heads/4.9 from [~sateeshc]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6977cb3 ]

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=
While listing datacenters associated with a zone, only zone Id validation is 
required.
There is no need to have additional checks like zone is a legacy zone or not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi 
(cherry picked from commit 0ef1c17541808641983e7c109db31e5cecc0ef44)
Signed-off-by: Rohit Yadav 


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.1.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-06-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038626#comment-16038626
 ] 

ASF subversion and git services commented on CLOUDSTACK-9684:
-

Commit 0ef1c17541808641983e7c109db31e5cecc0ef44 in cloudstack's branch 
refs/heads/master from [~sateeshc]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=0ef1c17 ]

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=
While listing datacenters associated with a zone, only zone Id validation is 
required.
There is no need to have additional checks like zone is a legacy zone or not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi 


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891969#comment-15891969
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@karuturi Checked the tests errors, they seem to be unrelated to this PR 
code fix.


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891926#comment-15891926
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user sateesh-chodapuneedi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1841#discussion_r103883712
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -1180,10 +1180,7 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 
 private void validateZone(Long zoneId) throws 
InvalidParameterValueException {
--- End diff --

No, this method is being used in other part of code. This method does more 
than zone existence check.


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879548#comment-15879548
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@sateesh-chodapuneedi can you take a look at the test failures as well?


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875549#comment-15875549
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
Trillian test result (tid-861)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43746 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1841-t861-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 788.65 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 70.86 | 
test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 75.94 | 
test_snapshots.py
ContextSuite context=TestSnapshotRootDisk>:teardown | `Error` | 101.23 | 
test_snapshots.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 817.80 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 848.20 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 332.24 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 182.45 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 549.91 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 335.12 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 666.47 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 581.68 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1529.06 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 669.18 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 614.34 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1300.01 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.84 | test_volumes.py
test_06_download_detached_volume | Success | 45.47 | test_volumes.py
test_05_detach_volume | Success | 100.27 | test_volumes.py
test_04_delete_attached_volume | Success | 10.20 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 49.27 | test_volumes.py
test_01_create_volume | Success | 505.66 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 496.97 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 222.17 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 136.18 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.64 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 252.74 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 55.97 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.13 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.14 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.29 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.14 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 191.32 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 10.18 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.19 | test_templates.py
test_01_create_template | Success | 91.26 | test_templates.py
test_10_destroy_cpvm | Success | 211.82 | test_ssvm.py
test_09_destroy_ssvm | Success | 233.76 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.64 | test_ssvm.py
test_07_reboot_ssvm | Success | 188.58 | test_ssvm.py
test_06_stop_cpvm | Success | 171.95 | test_ssvm.py
test_05_stop_ssvm | Success | 

[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874990#comment-15874990
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@blueorangutan test centos7 vmware-60u2


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874993#comment-15874993
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has 
been kicked to run smoke tests


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874640#comment-15874640
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-512


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874495#comment-15874495
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874493#comment-15874493
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@blueorangutan package


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-02-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874489#comment-15874489
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@borisstoyanov Can you please run trillian tests for this PR?
This already has enough code LGTMs, and needs tests for merge.


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-01-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797632#comment-15797632
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@karuturi I understand these words: "help", "hello", "thanks", "package", 
"test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-65sp1', 'xenserver-62sp1', 'vmware-60u2', 'vmware-55u3', 
'vmware-51u1', 'vmware-50u1']
Additional tests: list of comma separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py, 
component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 
'murali-reddy', 'abhinandanprateek', 'PaulAngus', 'borisstoyanov']


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-01-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797634#comment-15797634
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@blueorangutan test centos7 vmware-60u2


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2017-01-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797627#comment-15797627
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
@blueorangutan help


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2016-12-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787333#comment-15787333
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
Thanks @sureshanaparti 


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2016-12-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787326#comment-15787326
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
LGTM


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2016-12-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787005#comment-15787005
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1841
  
Code changes LGTM


> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-9684) Invalid zone id error while listing vmware zone

2016-12-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764398#comment-15764398
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9684:


GitHub user sateesh-chodapuneedi opened a pull request:

https://github.com/apache/cloudstack/pull/1841

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone

Issue
=
While listing datacenters associated with a zone, only zone Id validation 
is required.
There is no need to have additional checks like zone is a legacy zone or 
not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sateesh-chodapuneedi/cloudstack 
pr-cloudstack-9684

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1841


commit 870c2f59b476276475d2c8c711f2aa116ab70a45
Author: Sateesh Chodapuneedi 
Date:   2016-12-20T02:15:26Z

CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=
While listing datacenters associated with a zone, only zone Id validation 
is required.
There is no need to have additional checks like zone is a legacy zone or 
not.

Fix
===
Removed unnecessary checks over zone ID and just checking if zone with 
specified ID exists or not.

Signed-off-by: Sateesh Chodapuneedi 




> Invalid zone id error while listing vmware zone
> ---
>
> Key: CLOUDSTACK-9684
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9684
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0.1
>Reporter: Sateesh Chodapuneedi
>Assignee: Sateesh Chodapuneedi
> Fix For: 4.10.0.0
>
>
> When we select a VMware zone in the UI, listvmwaredcs API gets called.
> But if the zone is a legacy zone then upon clicking the zone in ACS UI, it 
> throws error 'Invalid zone id' as pop-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)