[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109487#comment-16109487
 ] 

ASF subversion and git services commented on CLOUDSTACK-9701:
-

Commit 8240bc4aa228324e8113795f9fc7bf8f31ec0668 in cloudstack's branch 
refs/heads/4.9 from [~sudhansu]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8240bc4 ]

CLOUDSTACK-9701: When host is disabled/removed,
capacity_type for local storage in op_host_capacity
is still enabled

(cherry picked from commit e06e3b7cd41787efc4e0f3cbf2d5a3040b4f15c9)
Signed-off-by: Rohit Yadav 


> When host is disabled/removed, capacity_state for local storage in 
> op_host_capacity is still enabled
> 
>
> Key: CLOUDSTACK-9701
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9701
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.9.0
>Reporter: Sudhansu Sahu
>Assignee: Sudhansu Sahu
>
> Setup: Advanced zone with local storage enabled
> Description
> =
> When a host is disabled or removed, local storage related capacity data for 
> the corresponding local storage of the host is still in enabled state.
> This may not directly impact deploy VM functionality (for example) but it 
> does show incorrect capacity calculations.
> Steps
> =
> 1. Enable local storage for zone
> 2. Disable host or remove host (after adding it to maintenance mode)
> 3. Check op_host_capacity (capacity_state=9)
> In either of the cases, the local storage related capacity is still enabled 
> for the host.
> {noformat}
> mysql> select id, name, uuid, status,resource_state, type, removed from host 
> where type = 'Routing';
> +++--+++-+-+
> | id | name   | uuid | status | 
> resource_state | type| removed |
> +++--+++-+-+
> |  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
> Disabled   | Routing | NULL|
> |  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
> Enabled| Routing | NULL|
> +++--+++-+-+
> 2 rows in set (0.00 sec)
> mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
> capacity_type, capacity_state from op_host_capacity where capacity_type=9;
> +-+---+---++---++
> | host_id | used_capacity | reserved_capacity | total_capacity | 
> capacity_type | capacity_state |
> +-+---+---++---++
> |   3 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> |   4 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> +-+---+---++---++
> 2 rows in set (0.00 sec)
> mysql> select id, name, removed, pool_type, capacity_bytes from storage_pool 
> where id in (3,4);
> ++--+-+---++
> | id | name | removed | pool_type | 
> capacity_bytes |
> ++--+-+---++
> |  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
> 491505319936 |
> |  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
> 491505319936 |
> ++--+-+---++
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038600#comment-16038600
 ] 

ASF subversion and git services commented on CLOUDSTACK-9701:
-

Commit d962cc1b60c674ff94e4d5b9ade41f727b06cc7a in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=d962cc1 ]

Merge pull request #1869 from sudhansu7/CLOUDSTACK-9701

CLOUDSTACK-9701: Local storage capacity is not handled properly

> When host is disabled/removed, capacity_state for local storage in 
> op_host_capacity is still enabled
> 
>
> Key: CLOUDSTACK-9701
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9701
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.9.0
>Reporter: Sudhansu Sahu
>Assignee: Sudhansu Sahu
>
> Setup: Advanced zone with local storage enabled
> Description
> =
> When a host is disabled or removed, local storage related capacity data for 
> the corresponding local storage of the host is still in enabled state.
> This may not directly impact deploy VM functionality (for example) but it 
> does show incorrect capacity calculations.
> Steps
> =
> 1. Enable local storage for zone
> 2. Disable host or remove host (after adding it to maintenance mode)
> 3. Check op_host_capacity (capacity_state=9)
> In either of the cases, the local storage related capacity is still enabled 
> for the host.
> {noformat}
> mysql> select id, name, uuid, status,resource_state, type, removed from host 
> where type = 'Routing';
> +++--+++-+-+
> | id | name   | uuid | status | 
> resource_state | type| removed |
> +++--+++-+-+
> |  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
> Disabled   | Routing | NULL|
> |  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
> Enabled| Routing | NULL|
> +++--+++-+-+
> 2 rows in set (0.00 sec)
> mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
> capacity_type, capacity_state from op_host_capacity where capacity_type=9;
> +-+---+---++---++
> | host_id | used_capacity | reserved_capacity | total_capacity | 
> capacity_type | capacity_state |
> +-+---+---++---++
> |   3 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> |   4 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> +-+---+---++---++
> 2 rows in set (0.00 sec)
> mysql> select id, name, removed, pool_type, capacity_bytes from storage_pool 
> where id in (3,4);
> ++--+-+---++
> | id | name | removed | pool_type | 
> capacity_bytes |
> ++--+-+---++
> |  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
> 491505319936 |
> |  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
> 491505319936 |
> ++--+-+---++
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038599#comment-16038599
 ] 

ASF subversion and git services commented on CLOUDSTACK-9701:
-

Commit d962cc1b60c674ff94e4d5b9ade41f727b06cc7a in cloudstack's branch 
refs/heads/master from [~rajanik]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=d962cc1 ]

Merge pull request #1869 from sudhansu7/CLOUDSTACK-9701

CLOUDSTACK-9701: Local storage capacity is not handled properly

> When host is disabled/removed, capacity_state for local storage in 
> op_host_capacity is still enabled
> 
>
> Key: CLOUDSTACK-9701
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9701
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.9.0
>Reporter: Sudhansu Sahu
>Assignee: Sudhansu Sahu
>
> Setup: Advanced zone with local storage enabled
> Description
> =
> When a host is disabled or removed, local storage related capacity data for 
> the corresponding local storage of the host is still in enabled state.
> This may not directly impact deploy VM functionality (for example) but it 
> does show incorrect capacity calculations.
> Steps
> =
> 1. Enable local storage for zone
> 2. Disable host or remove host (after adding it to maintenance mode)
> 3. Check op_host_capacity (capacity_state=9)
> In either of the cases, the local storage related capacity is still enabled 
> for the host.
> {noformat}
> mysql> select id, name, uuid, status,resource_state, type, removed from host 
> where type = 'Routing';
> +++--+++-+-+
> | id | name   | uuid | status | 
> resource_state | type| removed |
> +++--+++-+-+
> |  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
> Disabled   | Routing | NULL|
> |  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
> Enabled| Routing | NULL|
> +++--+++-+-+
> 2 rows in set (0.00 sec)
> mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
> capacity_type, capacity_state from op_host_capacity where capacity_type=9;
> +-+---+---++---++
> | host_id | used_capacity | reserved_capacity | total_capacity | 
> capacity_type | capacity_state |
> +-+---+---++---++
> |   3 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> |   4 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> +-+---+---++---++
> 2 rows in set (0.00 sec)
> mysql> select id, name, removed, pool_type, capacity_bytes from storage_pool 
> where id in (3,4);
> ++--+-+---++
> | id | name | removed | pool_type | 
> capacity_bytes |
> ++--+-+---++
> |  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
> 491505319936 |
> |  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
> 491505319936 |
> ++--+-+---++
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038597#comment-16038597
 ] 

ASF subversion and git services commented on CLOUDSTACK-9701:
-

Commit e06e3b7cd41787efc4e0f3cbf2d5a3040b4f15c9 in cloudstack's branch 
refs/heads/master from [~sudhansu]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=e06e3b7 ]

CLOUDSTACK-9701: When host is disabled/removed,
capacity_type for local storage in op_host_capacity
is still enabled


> When host is disabled/removed, capacity_state for local storage in 
> op_host_capacity is still enabled
> 
>
> Key: CLOUDSTACK-9701
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9701
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.9.0
>Reporter: Sudhansu Sahu
>Assignee: Sudhansu Sahu
>
> Setup: Advanced zone with local storage enabled
> Description
> =
> When a host is disabled or removed, local storage related capacity data for 
> the corresponding local storage of the host is still in enabled state.
> This may not directly impact deploy VM functionality (for example) but it 
> does show incorrect capacity calculations.
> Steps
> =
> 1. Enable local storage for zone
> 2. Disable host or remove host (after adding it to maintenance mode)
> 3. Check op_host_capacity (capacity_state=9)
> In either of the cases, the local storage related capacity is still enabled 
> for the host.
> {noformat}
> mysql> select id, name, uuid, status,resource_state, type, removed from host 
> where type = 'Routing';
> +++--+++-+-+
> | id | name   | uuid | status | 
> resource_state | type| removed |
> +++--+++-+-+
> |  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
> Disabled   | Routing | NULL|
> |  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
> Enabled| Routing | NULL|
> +++--+++-+-+
> 2 rows in set (0.00 sec)
> mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
> capacity_type, capacity_state from op_host_capacity where capacity_type=9;
> +-+---+---++---++
> | host_id | used_capacity | reserved_capacity | total_capacity | 
> capacity_type | capacity_state |
> +-+---+---++---++
> |   3 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> |   4 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> +-+---+---++---++
> 2 rows in set (0.00 sec)
> mysql> select id, name, removed, pool_type, capacity_bytes from storage_pool 
> where id in (3,4);
> ++--+-+---++
> | id | name | removed | pool_type | 
> capacity_bytes |
> ++--+-+---++
> |  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
> 491505319936 |
> |  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
> 491505319936 |
> ++--+-+---++
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951259#comment-15951259
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9701:


Github user mrunalinikankariya commented on the issue:

https://github.com/apache/cloudstack/pull/1869
  
Test LGTM, tested using marvin test script



> When host is disabled/removed, capacity_state for local storage in 
> op_host_capacity is still enabled
> 
>
> Key: CLOUDSTACK-9701
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9701
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.9.0
>Reporter: Sudhansu Sahu
>Assignee: Sudhansu Sahu
>
> Setup: Advanced zone with local storage enabled
> Description
> =
> When a host is disabled or removed, local storage related capacity data for 
> the corresponding local storage of the host is still in enabled state.
> This may not directly impact deploy VM functionality (for example) but it 
> does show incorrect capacity calculations.
> Steps
> =
> 1. Enable local storage for zone
> 2. Disable host or remove host (after adding it to maintenance mode)
> 3. Check op_host_capacity (capacity_state=9)
> In either of the cases, the local storage related capacity is still enabled 
> for the host.
> {noformat}
> mysql> select id, name, uuid, status,resource_state, type, removed from host 
> where type = 'Routing';
> +++--+++-+-+
> | id | name   | uuid | status | 
> resource_state | type| removed |
> +++--+++-+-+
> |  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
> Disabled   | Routing | NULL|
> |  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
> Enabled| Routing | NULL|
> +++--+++-+-+
> 2 rows in set (0.00 sec)
> mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
> capacity_type, capacity_state from op_host_capacity where capacity_type=9;
> +-+---+---++---++
> | host_id | used_capacity | reserved_capacity | total_capacity | 
> capacity_type | capacity_state |
> +-+---+---++---++
> |   3 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> |   4 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> +-+---+---++---++
> 2 rows in set (0.00 sec)
> mysql> select id, name, removed, pool_type, capacity_bytes from storage_pool 
> where id in (3,4);
> ++--+-+---++
> | id | name | removed | pool_type | 
> capacity_bytes |
> ++--+-+---++
> |  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
> 491505319936 |
> |  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
> 491505319936 |
> ++--+-+---++
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885145#comment-15885145
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9701:


Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1869
  
LGTM on the code changes.


> When host is disabled/removed, capacity_state for local storage in 
> op_host_capacity is still enabled
> 
>
> Key: CLOUDSTACK-9701
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9701
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Affects Versions: 4.9.0
>Reporter: Sudhansu Sahu
>Assignee: Sudhansu Sahu
>
> Setup: Advanced zone with local storage enabled
> Description
> =
> When a host is disabled or removed, local storage related capacity data for 
> the corresponding local storage of the host is still in enabled state.
> This may not directly impact deploy VM functionality (for example) but it 
> does show incorrect capacity calculations.
> Steps
> =
> 1. Enable local storage for zone
> 2. Disable host or remove host (after adding it to maintenance mode)
> 3. Check op_host_capacity (capacity_state=9)
> In either of the cases, the local storage related capacity is still enabled 
> for the host.
> {noformat}
> mysql> select id, name, uuid, status,resource_state, type, removed from host 
> where type = 'Routing';
> +++--+++-+-+
> | id | name   | uuid | status | 
> resource_state | type| removed |
> +++--+++-+-+
> |  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
> Disabled   | Routing | NULL|
> |  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
> Enabled| Routing | NULL|
> +++--+++-+-+
> 2 rows in set (0.00 sec)
> mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
> capacity_type, capacity_state from op_host_capacity where capacity_type=9;
> +-+---+---++---++
> | host_id | used_capacity | reserved_capacity | total_capacity | 
> capacity_type | capacity_state |
> +-+---+---++---++
> |   3 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> |   4 |   4194304 | 0 |   491505319936 | 
> 9 | Enabled|
> +-+---+---++---++
> 2 rows in set (0.00 sec)
> mysql> select id, name, removed, pool_type, capacity_bytes from storage_pool 
> where id in (3,4);
> ++--+-+---++
> | id | name | removed | pool_type | 
> capacity_bytes |
> ++--+-+---++
> |  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
> 491505319936 |
> |  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
> 491505319936 |
> ++--+-+---++
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9701) When host is disabled/removed, capacity_state for local storage in op_host_capacity is still enabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778160#comment-15778160
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9701:


GitHub user sudhansu7 opened a pull request:

https://github.com/apache/cloudstack/pull/1869

CLOUDSTACK-9701: When host is disabled/removed, capacity_type for loc…

…al storage in op_host_capacity is still enabled

Description
=
When a host is disabled or removed, local storage related capacity data for 
the corresponding local storage of the host is still in enabled state.
This may not directly impact deploy VM functionality (for example) but it 
does show incorrect capacity calculations.

Steps
=

1. Enable local storage for zone
2. Disable host or remove host (after adding it to maintenance mode)
3. Check op_host_capacity (capacity_state=9)

In either of the cases, the local storage related capacity is still enabled 
for the host.


```
mysql> select id, name, uuid, status,resource_state, type, removed from 
host where type = 'Routing';

+++--+++-+-+
| id | name   | uuid | status | 
resource_state | type| removed |

+++--+++-+-+
|  1 | xenserver-nvjxksqs | 16a922d0-7b4c-4c84-baad-5bd91542181c | Up | 
Disabled   | Routing | NULL|
|  4 | xenserver-hnkwhblp | 0e0f161a-7cf5-4e44-8bcc-a25ba7d798e5 | Up | 
Enabled| Routing | NULL|

+++--+++-+-+
2 rows in set (0.00 sec)

mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
capacity_type, capacity_state from op_host_capacity where capacity_type=9;

+-+---+---++---++
| host_id | used_capacity | reserved_capacity | total_capacity | 
capacity_type | capacity_state |

+-+---+---++---++
|   3 |   4194304 | 0 |   491505319936 |
 9 | Enabled|
|   4 |   4194304 | 0 |   491505319936 |
 9 | Enabled|

+-+---+---++---++
2 rows in set (0.00 sec)

mysql> select id, name, removed, pool_type, capacity_bytes from 
storage_pool where id in (3,4);

++--+-+---++
| id | name | removed | pool_type | 
capacity_bytes |

++--+-+---++
|  3 | xenserver-nvjxksqs Local Storage | NULL| LVM   |   
491505319936 |
|  4 | xenserver-hnkwhblp Local Storage | NULL| LVM   |   
491505319936 |

++--+-+---++

mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
capacity_type, capacity_state from op_host_capacity where capacity_type in 
(0,1,3,9);

+-+---+---++---++
| host_id | used_capacity | reserved_capacity | total_capacity | 
capacity_type | capacity_state |

+-+---+---++---++
|   1 |1342177280 | 0 |15721585024 |
 0 | Disabled   |
|   1 |  1000 | 0 |  12400 |
 1 | Disabled   |
|   1 |  11995288 | 0 | 11804569632768 |
 3 | Enabled|
|   4 |2013265920 | 0 |15721585024 |
 0 | Enabled|
|   4 |  2600 | 0 |  12400 |
 1 | Enabled|
|   2 | 0 | 0 | 11804569632768 |
 3 | Enabled|
|   3 |   4194304 | 0 |   491505319936 |
 9 | Disabled   |
|   4 |   4194304 | 0 |   491505319936 |
 9 | Enabled|

+-+---+---++---++
8 rows in set (0.00 sec)


```

After fix:
```
mysql> select host_id, used_capacity, reserved_capacity, total_capacity, 
capacity_type, capacity_state from op_host_capacity where capacity_type