[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134923#comment-16134923 ] ASF subversion and git services commented on CLOUDSTACK-9717: - Commit 0c6cf69eeec940345a6ee01b7d03a184e3c31398 in cloudstack's branch refs/heads/master from sureshanaparti [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=0c6cf69 ] CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. (#1878) Fix: When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.1.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922743#comment-15922743 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @rafaelweingartner Thanks for reviewing, will work on the changes suggested. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907604#comment-15907604
]
ASF GitHub Bot commented on CLOUDSTACK-9717:
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105677642
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2072,6 +2121,17 @@ protected StartAnswer execute(StartCommand cmd) {
}
/**
+ * Update boot args with the new nic mac addresses.
+ */
+protected String replaceNicsMacSequenceInBootArgs(String
oldMacSequence, String newMacSequence, VirtualMachineTO vmSpec) {
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs) &&
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+return bootArgs.replace(oldMacSequence, newMacSequence);
+}
+return "";
--- End diff --
Is this case possible? `bootArgs` not empty and `oldMacSequence` or
`newMacSequence` empty
If so, would not it be better to return at line 2131 the variable
`bootArgs`?
> [VMware] RVRs have mismatching MAC addresses for extra public NICs
> --
>
> Key: CLOUDSTACK-9717
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't
> seem to be completely fixed.
> ISSUE
> ==
> If there are two public networks on two VLANs, and a pair redundant VRs
> acquire IPs from both, the associated NICs on the redundant VRs will have
> mismatching MAC addresses.
> The example below shows the eth2 NICs for the first public network
> (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as
> expected, but the eth3 NICs for the second one (210.140.160.0/21) have
> mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5).
> *r-43584-VM (Master)*
> 6: eth2: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> *r-43585-VM (Backup)*
> 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> CloudStack should ensure that the NICs for all public networks have matching
> MACs.
> REPRO STEPS
> ==
> 1) Set up redundant VR.
> 2) Set up multiple public networks on different VLANs.
> 3) Acquire IPs in the RVR network until the VRs get IPs in the different
> public networks.
> 4) Confirm the mismatching MAC addresses.
> EXPECTED BEHAVIOR
> ==
> Redundant VRs have matching MACs for all public networks.
> ACTUAL BEHAVIOR
> ==
> Redundant VRs have matching MACs only for the first public network.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907603#comment-15907603
]
ASF GitHub Bot commented on CLOUDSTACK-9717:
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105678507
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1928,6 +1929,54 @@ protected StartAnswer execute(StartCommand cmd) {
VirtualDevice nic;
int nicMask = 0;
int nicCount = 0;
+
+if (vmSpec.getType() == VirtualMachine.Type.DomainRouter) {
+int extraPublicNics = mgr.getRouterExtraPublicNics();
+if (extraPublicNics > 0 &&
vmSpec.getDetails().containsKey("PeerRouterInstanceName")) {
+//Set identical MAC address for RvR on extra public
interfaces
+String peerRouterInstanceName =
vmSpec.getDetails().get("PeerRouterInstanceName");
+
+VirtualMachineMO peerVmMo =
hyperHost.findVmOnHyperHost(peerRouterInstanceName);
+if (peerVmMo == null) {
+peerVmMo =
hyperHost.findVmOnPeerHyperHost(peerRouterInstanceName);
+}
+
+if (peerVmMo != null) {
+StringBuffer sbOldMacSequence = new StringBuffer();
+for (NicTO oldNicTo : sortNicsByDeviceId(nics)) {
+
sbOldMacSequence.append(oldNicTo.getMac()).append("|");
+}
+if (!sbOldMacSequence.toString().isEmpty()) {
+
sbOldMacSequence.deleteCharAt(sbOldMacSequence.length() - 1); //Remove extra
'|' char appended at the end
+}
+
+for (int nicIndex = nics.length - extraPublicNics;
nicIndex < nics.length; nicIndex++) {
+VirtualDevice nicDevice =
peerVmMo.getNicDeviceByIndex(nics[nicIndex].getDeviceId());
+if (nicDevice != null) {
+String mac =
((VirtualEthernetCard)nicDevice).getMacAddress();
+if (mac != null) {
+s_logger.info("Use same MAC as
previous RvR, the MAC is " + mac + " for extra NIC with device id: " +
nics[nicIndex].getDeviceId());
+nics[nicIndex].setMac(mac);
+}
+}
+}
+
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs)) {
+StringBuffer sbNewMacSequence = new
StringBuffer();
--- End diff --
This method is still quite big.
What about extracting lines 1966-1971 to a method? These lines are used to
generate/create the `sbNewMacSequence`. Then we could have a documentation
describing its workings and test cases.
> [VMware] RVRs have mismatching MAC addresses for extra public NICs
> --
>
> Key: CLOUDSTACK-9717
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't
> seem to be completely fixed.
> ISSUE
> ==
> If there are two public networks on two VLANs, and a pair redundant VRs
> acquire IPs from both, the associated NICs on the redundant VRs will have
> mismatching MAC addresses.
> The example below shows the eth2 NICs for the first public network
> (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as
> expected, but the eth3 NICs for the second one (210.140.160.0/21) have
> mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5).
> *r-43584-VM (Master)*
> 6: eth2: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907606#comment-15907606
]
ASF GitHub Bot commented on CLOUDSTACK-9717:
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105679910
--- Diff:
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
---
@@ -216,6 +216,20 @@ public void testScaleVMF1() throws Exception {
}
@Test
+public void testReplaceNicsMacSequenceInBootArgs() throws Exception {
--- End diff --
Do you need this `throws Exception` here?
It does not seem o be required by any of the method calls you have here.
> [VMware] RVRs have mismatching MAC addresses for extra public NICs
> --
>
> Key: CLOUDSTACK-9717
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't
> seem to be completely fixed.
> ISSUE
> ==
> If there are two public networks on two VLANs, and a pair redundant VRs
> acquire IPs from both, the associated NICs on the redundant VRs will have
> mismatching MAC addresses.
> The example below shows the eth2 NICs for the first public network
> (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as
> expected, but the eth3 NICs for the second one (210.140.160.0/21) have
> mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5).
> *r-43584-VM (Master)*
> 6: eth2: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> *r-43585-VM (Backup)*
> 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> CloudStack should ensure that the NICs for all public networks have matching
> MACs.
> REPRO STEPS
> ==
> 1) Set up redundant VR.
> 2) Set up multiple public networks on different VLANs.
> 3) Acquire IPs in the RVR network until the VRs get IPs in the different
> public networks.
> 4) Confirm the mismatching MAC addresses.
> EXPECTED BEHAVIOR
> ==
> Redundant VRs have matching MACs for all public networks.
> ACTUAL BEHAVIOR
> ==
> Redundant VRs have matching MACs only for the first public network.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907605#comment-15907605
]
ASF GitHub Bot commented on CLOUDSTACK-9717:
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105676576
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId) {
List results = customSearch(sc, null);
return results.get(0);
}
+
+@Override
+public Long getPeerRouterId(String publicMacAddress, final long
routerId) {
+final SearchCriteria sc = PeerRouterSearch.create();
+sc.setParameters("instanceId", routerId);
+sc.setParameters("macAddress", publicMacAddress);
+sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
+NicVO nicVo = findOneBy(sc);
+if (nicVo != null) {
+return (new Long(nicVo.getInstanceId()));
--- End diff --
Let the auto-boxing and auto-unboxing do this for you.
When you do this manually the pool of String/numbers of java will not be
used.
You just need to return `nicVo.getInstanceId()`
> [VMware] RVRs have mismatching MAC addresses for extra public NICs
> --
>
> Key: CLOUDSTACK-9717
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't
> seem to be completely fixed.
> ISSUE
> ==
> If there are two public networks on two VLANs, and a pair redundant VRs
> acquire IPs from both, the associated NICs on the redundant VRs will have
> mismatching MAC addresses.
> The example below shows the eth2 NICs for the first public network
> (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as
> expected, but the eth3 NICs for the second one (210.140.160.0/21) have
> mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5).
> *r-43584-VM (Master)*
> 6: eth2: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> *r-43585-VM (Backup)*
> 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> CloudStack should ensure that the NICs for all public networks have matching
> MACs.
> REPRO STEPS
> ==
> 1) Set up redundant VR.
> 2) Set up multiple public networks on different VLANs.
> 3) Acquire IPs in the RVR network until the VRs get IPs in the different
> public networks.
> 4) Confirm the mismatching MAC addresses.
> EXPECTED BEHAVIOR
> ==
> Redundant VRs have matching MACs for all public networks.
> ACTUAL BEHAVIOR
> ==
> Redundant VRs have matching MACs only for the first public network.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906744#comment-15906744
]
ASF GitHub Bot commented on CLOUDSTACK-9717:
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105573097
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2071,6 +2120,14 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
+private void replaceNicsMacSequenceInBootArgs(String oldMacSequence,
String newMacSequence, VirtualMachineTO vmSpec) {
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs) &&
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+//Update boot args with the new nic mac addresses
--- End diff --
@rafaelweingartner Moved the comment to the method documentation part.
Testcase added.
> [VMware] RVRs have mismatching MAC addresses for extra public NICs
> --
>
> Key: CLOUDSTACK-9717
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't
> seem to be completely fixed.
> ISSUE
> ==
> If there are two public networks on two VLANs, and a pair redundant VRs
> acquire IPs from both, the associated NICs on the redundant VRs will have
> mismatching MAC addresses.
> The example below shows the eth2 NICs for the first public network
> (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as
> expected, but the eth3 NICs for the second one (210.140.160.0/21) have
> mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5).
> *r-43584-VM (Master)*
> 6: eth2: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> *r-43585-VM (Backup)*
> 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> CloudStack should ensure that the NICs for all public networks have matching
> MACs.
> REPRO STEPS
> ==
> 1) Set up redundant VR.
> 2) Set up multiple public networks on different VLANs.
> 3) Acquire IPs in the RVR network until the VRs get IPs in the different
> public networks.
> 4) Confirm the mismatching MAC addresses.
> EXPECTED BEHAVIOR
> ==
> Redundant VRs have matching MACs for all public networks.
> ACTUAL BEHAVIOR
> ==
> Redundant VRs have matching MACs only for the first public network.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906716#comment-15906716 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @PaulAngus What was the error shown for duplicate MAC in vCenter. Can you post the log snippet with the error. These changes were tested in vCenter 5.5 and 6.0, didn't observe any issues in vCenter. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904625#comment-15904625 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti I see in vCenter any deployment of an RVR with a duplicate MAC, failing with a vCenter error regarding a duplicate MAC. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880596#comment-15880596 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti Thanks for the info! > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876852#comment-15876852 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @remibergsma Same MAC for RVR has been re-introducted as part of [CLOUDSTACK-985](https://issues.apache.org/jira/browse/CLOUDSTACK-985). It confirms that peer NICs of RVRs should have same MAC addresses. Only default public NIC was configured with same MAC. For VMware, there exists additional public NICs which were not configured with same MAC addresses. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876415#comment-15876415 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti why do the mac addresses need to be the same on both routers? We're also executing arpings to update our neighbours. Networking wise there is no need for them to be the same. I've seen it on other parts of the code as well and I really wonder why we do this. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876408#comment-15876408 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 Trillian test result (tid-873) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33766 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1878-t873-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 46 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 362.57 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 334.37 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | test_snapshots.py test_01_vpc_site2site_vpn | Success | 159.36 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 65.83 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 239.78 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 274.04 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 531.49 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 509.60 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1410.18 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 536.46 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 747.15 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 151.49 | test_volumes.py test_08_resize_volume | Success | 156.71 | test_volumes.py test_07_resize_fail | Success | 156.11 | test_volumes.py test_06_download_detached_volume | Success | 155.99 | test_volumes.py test_05_detach_volume | Success | 150.63 | test_volumes.py test_04_delete_attached_volume | Success | 150.93 | test_volumes.py test_03_download_attached_volume | Success | 156.02 | test_volumes.py test_02_attach_volume | Success | 95.59 | test_volumes.py test_01_create_volume | Success | 711.06 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 95.70 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 158.66 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 267.19 | test_vm_life_cycle.py test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.64 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.11 | test_vm_life_cycle.py test_08_migrate_vm | Success | 40.67 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.06 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.92 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.20 | test_vm_life_cycle.py test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.26 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 60.49 | test_templates.py test_08_list_system_templates | Success | 0.02 | test_templates.py test_07_list_public_templates | Success | 0.02 | test_templates.py test_05_template_permissions | Success | 0.04 | test_templates.py test_04_extract_template | Success | 5.14 | test_templates.py test_03_delete_template | Success | 5.08 | test_templates.py test_02_edit_template | Success | 90.16 | test_templates.py test_01_create_template | Success | 30.29 | test_templates.py test_10_destroy_cpvm | Success | 131.42 | test_ssvm.py test_09_destroy_ssvm | Success | 168.49 | test_ssvm.py test_08_reboot_cpvm | Success | 131.51 | test_ssvm.py test_07_reboot_ssvm | Success | 133.41 | test_ssvm.py test_06_stop_cpvm | Success | 131.56 | test_ssvm.py test_05_stop_ssvm | Success | 133.54 | test_ssvm.py test_04_cpvm_internals | Success | 1.14 | test_ssvm.py test_03_ssvm_internals | Success | 3.29 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.08 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py test_01_snapshot_root_disk | Success | 10.94 | test_snapshots.py test_04_change_offering_small | Success | 239.55 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876126#comment-15876126
]
ASF GitHub Bot commented on CLOUDSTACK-9717:
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r102226833
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2071,6 +2120,14 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
+private void replaceNicsMacSequenceInBootArgs(String oldMacSequence,
String newMacSequence, VirtualMachineTO vmSpec) {
+String bootArgs = vmSpec.getBootArgs();
+if (!StringUtils.isEmpty(bootArgs) &&
!StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
+//Update boot args with the new nic mac addresses
--- End diff --
What about moving this comment to the method documentation?
Also, how do you feel about test cases? The method is pretty simple and it
will not be hard to write some unit test for it.
> [VMware] RVRs have mismatching MAC addresses for extra public NICs
> --
>
> Key: CLOUDSTACK-9717
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.0.0
>
>
> [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't
> seem to be completely fixed.
> ISSUE
> ==
> If there are two public networks on two VLANs, and a pair redundant VRs
> acquire IPs from both, the associated NICs on the redundant VRs will have
> mismatching MAC addresses.
> The example below shows the eth2 NICs for the first public network
> (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as
> expected, but the eth3 NICs for the second one (210.140.160.0/21) have
> mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5).
> *r-43584-VM (Master)*
> 6: eth2: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc mq state UNKNOWN
> qlen 1000
> link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> *r-43585-VM (Backup)*
> 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff
> inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2
> inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2
> 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000
> link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff
> inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3
> inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3
> CloudStack should ensure that the NICs for all public networks have matching
> MACs.
> REPRO STEPS
> ==
> 1) Set up redundant VR.
> 2) Set up multiple public networks on different VLANs.
> 3) Acquire IPs in the RVR network until the VRs get IPs in the different
> public networks.
> 4) Confirm the mismatching MAC addresses.
> EXPECTED BEHAVIOR
> ==
> Redundant VRs have matching MACs for all public networks.
> ACTUAL BEHAVIOR
> ==
> Redundant VRs have matching MACs only for the first public network.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875605#comment-15875605 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875603#comment-15875603 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1878 @blueorangutan test > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875597#comment-15875597 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-519 > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875517#comment-15875517 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1878 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875516#comment-15875516 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1878 @blueorangutan package > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875157#comment-15875157 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @borisstoyanov Can you please run trillian tests for this PR? > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875136#comment-15875136 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @rafaelweingartner Updated the changes. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875086#comment-15875086 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1878 @rafaelweingartner Sure. I'll move these lines to a method and push the changes. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864529#comment-15864529 ] ASF GitHub Bot commented on CLOUDSTACK-9717: Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1878 Hi @sureshanaparti Would you mind extracting the code at lines 1967-1972 to a specific method? Then, it allows you to write test cases for the newly created method and proper documentation of the method behaviors? > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9717) [VMware] RVRs have mismatching MAC addresses for extra public NICs
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785194#comment-15785194 ] ASF GitHub Bot commented on CLOUDSTACK-9717: GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1878 CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. Problem: [VMware] RVRs have mismatching MAC addresses for extra public NICs. Root Cause: MAC addresses for extra public NICs were assigned randomly for the routers. Network Orchestrator is unaware of the extra NICs info of the peer router as they are not persisted in the cloud database and so peer router MAC addresses info is not at all considered in case of RVR when assigning MAC addresses for extra public NICs. Solution: When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9717 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1878.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1878 commit 3da9416ecfea0e8177b3985dec7dce686dc8c9c9 Author: Suresh Kumar Anaparti Date: 2016-12-29T11:54:42Z CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. Fix: When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router. > [VMware] RVRs have mismatching MAC addresses for extra public NICs > -- > > Key: CLOUDSTACK-9717 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9717 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Controller, VMware >Reporter: Suresh Kumar Anaparti >Assignee: Suresh Kumar Anaparti > Fix For: 4.10.0.0 > > > [CLOUDSTACK-985|https://issues.apache.org/jira/browse/CLOUDSTACK-985] doesn't > seem to be completely fixed. > ISSUE > == > If there are two public networks on two VLANs, and a pair redundant VRs > acquire IPs from both, the associated NICs on the redundant VRs will have > mismatching MAC addresses. > The example below shows the eth2 NICs for the first public network > (210.140.168.0/21) have matching MAC addresses (06:c4:b6:00:03:df) as > expected, but the eth3 NICs for the second one (210.140.160.0/21) have > mismatching MACs (02:00:50:e1:6c:cd versus 02:00:5a:e6:6c:d5). > *r-43584-VM (Master)* > 6: eth2: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc mq state UNKNOWN > qlen 1000 > link/ether 02:00:50:e1:6c:cd brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > *r-43585-VM (Backup)* > 6: eth2: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 06:c4:b6:00:03:df brd ff:ff:ff:ff:ff:ff > inet 210.140.168.42/21 brd 210.140.175.255 scope global eth2 > inet 210.140.168.20/21 brd 210.140.175.255 scope global secondary eth2 > 8: eth3: mtu 1500 qdisc noop state DOWN qlen 1000 > link/ether 02:00:5a:e6:6c:d5 brd ff:ff:ff:ff:ff:ff > inet 210.140.162.124/21 brd 210.140.167.255 scope global eth3 > inet 210.140.163.36/21 brd 210.140.167.255 scope global secondary eth3 > CloudStack should ensure that the NICs for all public networks have matching > MACs. > REPRO STEPS > == > 1) Set up redundant VR. > 2) Set up multiple public networks on different VLANs. > 3) Acquire IPs in the RVR network until the VRs get IPs in the different > public networks. > 4) Confirm the mismatching MAC addresses. > EXPECTED BEHAVIOR > == > Redundant VRs have matching MACs for all public networks. > ACTUAL BEHAVIOR > == > Redundant VRs have matching MACs only for the first public network. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
