[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287478#comment-16287478 ] ASF subversion and git services commented on CLOUDSTACK-9736: - Commit 895aee37f7da33034c66e209b404f135f49d6279 in cloudstack's branch refs/heads/master from [~milamber] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=895aee3 ] CLOUDSTACK-9736: Incoherent validation and error message when you change the vm.password.length configuration parameter (#2358) Default value introduce in schema-430to440.sql are 6 for the length CLOUDSTACK-10111 have already the error message. > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287477#comment-16287477 ] ASF GitHub Bot commented on CLOUDSTACK-9736: rhtyd closed pull request #2358: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/2358 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/server/src/com/cloud/server/ManagementServerImpl.java b/server/src/com/cloud/server/ManagementServerImpl.java index da987ca1330..872a5020786 100644 --- a/server/src/com/cloud/server/ManagementServerImpl.java +++ b/server/src/com/cloud/server/ManagementServerImpl.java @@ -689,7 +689,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServer, Configurable { public static final Logger s_logger = Logger.getLogger(ManagementServerImpl.class.getName()); -static final ConfigKey vmPasswordLength = new ConfigKey("Advanced", Integer.class, "vm.password.length", "10", +static final ConfigKey vmPasswordLength = new ConfigKey("Advanced", Integer.class, "vm.password.length", "6", "Specifies the length of a randomly generated password", false); @Inject public AccountManager _accountMgr; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287476#comment-16287476 ] ASF GitHub Bot commented on CLOUDSTACK-9736: rhtyd commented on issue #2358: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/2358#issuecomment-351026055 LGTM merging, the one job has been kicked again that failed due to timeout issues. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287269#comment-16287269 ] ASF GitHub Bot commented on CLOUDSTACK-9736: rhtyd commented on issue #2358: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/2358#issuecomment-350980966 LGTM. This is a simple change in default config, I'll merge as soon as Travis is green. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287263#comment-16287263 ] ASF GitHub Bot commented on CLOUDSTACK-9736: milamberspace commented on issue #1902: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/1902#issuecomment-350979616 Close. Replace by #2358 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287264#comment-16287264 ] ASF GitHub Bot commented on CLOUDSTACK-9736: milamberspace closed pull request #1902: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/1902 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index 10136c6bf32..847f1330caf 100644 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -797,8 +797,8 @@ private String validateConfigurationValue(final String name, String value, final throw new InvalidParameterValueException("Please enter a positive value for the configuration parameter:" + name); } //TODO - better validation for all password pamameters -if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { -throw new InvalidParameterValueException("Please enter a value greater than 6 for the configuration parameter:" + name); +if ("vm.password.length".equalsIgnoreCase(name) && val < 6) { +throw new InvalidParameterValueException("Please enter a value greater or equal than 6 for the configuration parameter:" + name); } if ("remote.access.vpn.psk.length".equalsIgnoreCase(name)) { if (val < 8) { diff --git a/server/src/com/cloud/server/ManagementServerImpl.java b/server/src/com/cloud/server/ManagementServerImpl.java index b6a263705fa..04ee1f2e4d1 100644 --- a/server/src/com/cloud/server/ManagementServerImpl.java +++ b/server/src/com/cloud/server/ManagementServerImpl.java @@ -684,7 +684,7 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServer, Configurable { public static final Logger s_logger = Logger.getLogger(ManagementServerImpl.class.getName()); -static final ConfigKey vmPasswordLength = new ConfigKey("Advanced", Integer.class, "vm.password.length", "10", +static final ConfigKey vmPasswordLength = new ConfigKey("Advanced", Integer.class, "vm.password.length", "6", "Specifies the length of a randomly generated password", false); @Inject public AccountManager _accountMgr; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287262#comment-16287262 ] ASF GitHub Bot commented on CLOUDSTACK-9736: milamberspace opened a new pull request #2358: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/2358 …ge the vm.password.length configuration parameter Default value introduce in schema-430to440.sql are 6 for the length CLOUDSTACK-10111 have already the error message This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286236#comment-16286236 ] ASF GitHub Bot commented on CLOUDSTACK-9736: rhtyd commented on issue #1902: CLOUDSTACK-9736 Incoherent validation and error message when you chan… URL: https://github.com/apache/cloudstack/pull/1902#issuecomment-350784850 @milamberspace can you rebase and fix conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.1.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822754#comment-15822754 ] Milamber commented on CLOUDSTACK-9736: -- Sorry I forgot to mention that the error message occurred with cloudmonkey when I run this command: update configuration name="vm.password.length" value="8" > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.0.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822684#comment-15822684 ] Sachin commented on CLOUDSTACK-9736: I tried to change the vm.password.length parameter to 8 the output was "Please restart your management server(s) for your new settings to take effect." Can you please tell me how did you get the error?? > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.0.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818179#comment-15818179 ] ASF GitHub Bot commented on CLOUDSTACK-9736: GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1902 CLOUDSTACK-9736 Incoherent validation and error message when you chan… …ge the vm.password.length configuration parameter Default value introduce in schema-430to440.sql are 6 for the length Probably needs to be merge with LTS branch (4.9) and other since 4.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack PasswordLengthFix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1902.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1902 commit 9d3d3b4c24500986b3286baf4a3b2bb1d4f32611 Author: Milamber Date: 2017-01-11T12:29:09Z CLOUDSTACK-9736 Incoherent validation and error message when you change the vm.password.length configuration parameter Default value introduce in schema-430to440.sql are 6 for the length > Incoherent validation and error message when you change the > vm.password.length configuration parameter > -- > > Key: CLOUDSTACK-9736 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0 >Reporter: Milamber >Assignee: Milamber >Priority: Minor > Fix For: 4.10.0.0 > > > When you try to change the value of vm.password.length parameters, if the > value is < 10 the error message says: > "Please enter a value greater than 6 for the configuration parameter" > In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java > the validation use 10 as length and the message says 6 for length: > if ("vm.password.length".equalsIgnoreCase(name) && val < 10) { > throw new InvalidParameterValueException("Please enter a > value greater than 6 for the configuration parameter:" + name); -- This message was sent by Atlassian JIRA (v6.3.4#6332)