[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038730#comment-16038730 ] ASF subversion and git services commented on CLOUDSTACK-9740: - Commit 9fd0965087a2189de70d8bbfd812e40ff2f75ccc in cloudstack's branch refs/heads/master from [~rajanik] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=9fd0965 ] Merge pull request #2126 from Accelerite/CLOUDSTACK-9740 CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038727#comment-16038727 ] ASF subversion and git services commented on CLOUDSTACK-9740: - Commit 9fd0965087a2189de70d8bbfd812e40ff2f75ccc in cloudstack's branch refs/heads/master from [~rajanik] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=9fd0965 ] Merge pull request #2126 from Accelerite/CLOUDSTACK-9740 CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038724#comment-16038724 ] ASF subversion and git services commented on CLOUDSTACK-9740: - Commit 5eed75120bfb961d8b86102184416cd9be8da764 in cloudstack's branch refs/heads/master from [~niteshsarda] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=5eed751 ] CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028727#comment-16028727 ] Nitesh Sarda commented on CLOUDSTACK-9740: -- Hello, Raised a new PR for this issue. Following are the details : https://github.com/apache/cloudstack/pull/2126 > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869825#comment-15869825 ] ASF GitHub Bot commented on CLOUDSTACK-9740: Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1909 @niteshsarda I see a problem here. The listNics command can be used to list both primary and secondary ips. In case if we pass nicid parameter with it, i feel we should use keywork to filter secondary nics. If only virtualmachineid is given, we should use it to filter primary IPs. > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869539#comment-15869539 ] ASF GitHub Bot commented on CLOUDSTACK-9740: Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1909 @niteshsarda in my opinion, what we should change is the search processing, not the process on creating nic response. to be clear, in server/src/com/cloud/network/NetworkServiceImpl.java ``` public List listNics(ListNicsCmd cmd) ``` > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869500#comment-15869500 ] ASF GitHub Bot commented on CLOUDSTACK-9740: Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1909 ![screenshot after applying fix](https://cloud.githubusercontent.com/assets/25146827/23013185/9e11507e-f44f-11e6-8921-acc0c3eb35c4.PNG) ![screenshot before applying fix](https://cloud.githubusercontent.com/assets/25146827/23013197/a8838aa4-f44f-11e6-98c3-50f1d0bec8c1.PNG) > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825876#comment-15825876 ] rashmidixit commented on CLOUDSTACK-9740: - GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1909 CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to ⦠Search for secondary IP of NIC that is attached to an instance is not working. If instance has more than one secondary IP assigned and administrator attempts to search that list, all IPs are displayed instead of being filtered by the search string. in web UI: CCP dashboard -> Instances -> -> NICs -> âView Secondary IPsâ -> Search for a IP, but the search returns all the IPs in the list You can merge this pull request into a Git repository by running: $ git pull https://github.com/niteshsarda/cloudstack CS-9740 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1909.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1909 commit 4b335fec047350d65031ef636d4c9b70b3a7ba98 Author: Nitesh Sarda Date: 2017-01-17T11:05:54Z CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9740) Search for secondary IP of NIC that is attached to an instance is not working
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825872#comment-15825872 ] ASF GitHub Bot commented on CLOUDSTACK-9740: GitHub user niteshsarda opened a pull request: https://github.com/apache/cloudstack/pull/1909 CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to … Search for secondary IP of NIC that is attached to an instance is not working. If instance has more than one secondary IP assigned and administrator attempts to search that list, all IPs are displayed instead of being filtered by the search string. in web UI: CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” -> Search for a IP, but the search returns all the IPs in the list You can merge this pull request into a Git repository by running: $ git pull https://github.com/niteshsarda/cloudstack CS-9740 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1909.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1909 commit 4b335fec047350d65031ef636d4c9b70b3a7ba98 Author: Nitesh Sarda Date: 2017-01-17T11:05:54Z CLOUDSTACK-9740 : Search for secondary IP of NIC that is attached to an instance is not working > Search for secondary IP of NIC that is attached to an instance is not working > - > > Key: CLOUDSTACK-9740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, Management Server >Reporter: Nitesh Sarda > > If instance has more than one secondary IP assigned and administrator > attempts to search that list, all IPs are displayed instead of being filtered > by the search string. > in web UI: > CCP dashboard -> Instances -> -> NICs -> ”View Secondary IPs” > -> Search for a IP, but the search returns all the IPs in the list -- This message was sent by Atlassian JIRA (v6.3.4#6332)