[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960479#comment-15960479 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2032 LGTM, checked the source $ grep -r 4.9.3.0 no hits > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960336#comment-15960336 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2032 Thanks @karuturi I usually rebuild CloudStack when forward merging PRs to ensure they don't break the forward-branches > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960334#comment-15960334 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi thanks for fixing it > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960299#comment-15960299 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 50ffbe905a5026c69a86fc41ec2d6758a81f48dc in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=50ffbe9 ] Merge pull request #2032 from Accelerite/master-fix-after-1944 CLOUDSTACK-9783: corrected the version number in metrics pommaster is broken after fwd-merging metrics PR #1944 from 4.9 This is due to the incorrect parent version number in the metrics pom. Corrected the same to reflect master version number. * pr/2032: CLOUDSTACK-9783: corrected the version number in metrics pom Signed-off-by: Rajani Karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960295#comment-15960295 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 50ffbe905a5026c69a86fc41ec2d6758a81f48dc in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=50ffbe9 ] Merge pull request #2032 from Accelerite/master-fix-after-1944 CLOUDSTACK-9783: corrected the version number in metrics pommaster is broken after fwd-merging metrics PR #1944 from 4.9 This is due to the incorrect parent version number in the metrics pom. Corrected the same to reflect master version number. * pr/2032: CLOUDSTACK-9783: corrected the version number in metrics pom Signed-off-by: Rajani Karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960294#comment-15960294 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2032 > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960293#comment-15960293 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit e1c76dcc235fd350f87725adaf359619331db278 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e1c76dc ] CLOUDSTACK-9783: corrected the version number in metrics pom master is broken after fwd-merging metrics PR #1944 from 4.9 This is due to the incorrect parent version number in the metrics pom. Corrected the same to reflect master version number. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960290#comment-15960290 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/2032 LGTM. Build is broken due to this. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960257#comment-15960257 ] ASF GitHub Bot commented on CLOUDSTACK-9783: GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/2032 CLOUDSTACK-9783: corrected the version number in metrics pom master is broken after fwd-merging metrics PR #1944 from 4.9 This is due to the incorrect parent version number in the metrics pom. Corrected the same to reflect master version number. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack master-fix-after-1944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2032.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2032 commit e1c76dcc235fd350f87725adaf359619331db278 Author: Rajani Karuturi Date: 2017-04-07T04:22:27Z CLOUDSTACK-9783: corrected the version number in metrics pom master is broken after fwd-merging metrics PR #1944 from 4.9 This is due to the incorrect parent version number in the metrics pom. Corrected the same to reflect master version number. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960250#comment-15960250 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1944 master is broken after the merge. Pom version changes > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958431#comment-15958431 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @nvazquez @karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958404#comment-15958404 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 6548839417013f58d9ed05a6550c74a057039134 in cloudstack's branch refs/heads/4.9 from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6548839 ] Merge pull request #1944 from shapeblue/4.9-metrics-enhancement CLOUDSTACK-9783: Improve metrics view performanceThis improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit Marvin test results: === TestName: test_list_clusters_metrics | Status : SUCCESS === === TestName: test_list_hosts_metrics | Status : SUCCESS === === TestName: test_list_infrastructure_metrics | Status : SUCCESS === === TestName: test_list_pstorage_metrics | Status : SUCCESS === === TestName: test_list_vms_metrics | Status : SUCCESS === === TestName: test_list_volumes_metrics | Status : SUCCESS === === TestName: test_list_zones_metrics | Status : SUCCESS === * pr/1944: CLOUDSTACK-9783: Improve metrics view performance Signed-off-by: Rajani Karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958399#comment-15958399 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 6548839417013f58d9ed05a6550c74a057039134 in cloudstack's branch refs/heads/4.9 from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6548839 ] Merge pull request #1944 from shapeblue/4.9-metrics-enhancement CLOUDSTACK-9783: Improve metrics view performanceThis improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit Marvin test results: === TestName: test_list_clusters_metrics | Status : SUCCESS === === TestName: test_list_hosts_metrics | Status : SUCCESS === === TestName: test_list_infrastructure_metrics | Status : SUCCESS === === TestName: test_list_pstorage_metrics | Status : SUCCESS === === TestName: test_list_vms_metrics | Status : SUCCESS === === TestName: test_list_volumes_metrics | Status : SUCCESS === === TestName: test_list_zones_metrics | Status : SUCCESS === * pr/1944: CLOUDSTACK-9783: Improve metrics view performance Signed-off-by: Rajani Karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958397#comment-15958397 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 402253504e9520104caf9fbc1317042f2fd89474 in cloudstack's branch refs/heads/4.9 from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4022535 ] CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by reimplementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Signed-off-by: Rohit Yadav > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958389#comment-15958389 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 5c0979fff5fba6cca07998ef76e01897d1218747 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c0979f ] Merge release branch 4.9 to master * 4.9: CLOUDSTACK-9783: Improve metrics view performance > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958385#comment-15958385 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 6548839417013f58d9ed05a6550c74a057039134 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6548839 ] Merge pull request #1944 from shapeblue/4.9-metrics-enhancement CLOUDSTACK-9783: Improve metrics view performanceThis improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit Marvin test results: === TestName: test_list_clusters_metrics | Status : SUCCESS === === TestName: test_list_hosts_metrics | Status : SUCCESS === === TestName: test_list_infrastructure_metrics | Status : SUCCESS === === TestName: test_list_pstorage_metrics | Status : SUCCESS === === TestName: test_list_vms_metrics | Status : SUCCESS === === TestName: test_list_volumes_metrics | Status : SUCCESS === === TestName: test_list_zones_metrics | Status : SUCCESS === * pr/1944: CLOUDSTACK-9783: Improve metrics view performance Signed-off-by: Rajani Karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958380#comment-15958380 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 6548839417013f58d9ed05a6550c74a057039134 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6548839 ] Merge pull request #1944 from shapeblue/4.9-metrics-enhancement CLOUDSTACK-9783: Improve metrics view performanceThis improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit Marvin test results: === TestName: test_list_clusters_metrics | Status : SUCCESS === === TestName: test_list_hosts_metrics | Status : SUCCESS === === TestName: test_list_infrastructure_metrics | Status : SUCCESS === === TestName: test_list_pstorage_metrics | Status : SUCCESS === === TestName: test_list_vms_metrics | Status : SUCCESS === === TestName: test_list_volumes_metrics | Status : SUCCESS === === TestName: test_list_zones_metrics | Status : SUCCESS === * pr/1944: CLOUDSTACK-9783: Improve metrics view performance Signed-off-by: Rajani Karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958376#comment-15958376 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1944 > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958375#comment-15958375 ] ASF subversion and git services commented on CLOUDSTACK-9783: - Commit 402253504e9520104caf9fbc1317042f2fd89474 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4022535 ] CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by reimplementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Signed-off-by: Rohit Yadav > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958374#comment-15958374 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1944 merging now > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955877#comment-15955877 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1944 Please ommit my last comment, we were using commons-beanutils version 1.8.3 instead of 1.9.2 LGTM [root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//DVIXST/results.txt test_list_clusters_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_clusters_metrics | Status : SUCCESS === ok test_list_hosts_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_hosts_metrics | Status : SUCCESS === ok test_list_infrastructure_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_infrastructure_metrics | Status : SUCCESS === ok test_list_pstorage_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_pstorage_metrics | Status : SUCCESS === ok test_list_vms_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_vms_metrics | Status : SUCCESS === ok test_list_volumes_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_volumes_metrics | Status : SUCCESS === ok test_list_zones_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_zones_metrics | Status : SUCCESS === ok -- Ran 7 tests in 142.134s OK > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951364#comment-15951364 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1944 Hi @rhtyd, thanks for this great improvement! Along with @serg38 we've been testing in our env and got some failures on `listHostsMetrics` and `listVolumeMetrics`: test_list_clusters_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_clusters_metrics | Status : SUCCESS === ok test_list_hosts_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_hosts_metrics | Status : EXCEPTION === ERROR test_list_infrastructure_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_infrastructure_metrics | Status : SUCCESS === ok test_list_pstorage_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_pstorage_metrics | Status : SUCCESS === ok test_list_vms_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_vms_metrics | Status : SUCCESS === ok test_list_volumes_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_volumes_metrics | Status : EXCEPTION === ERROR test_list_zones_metrics (test_metrics_api.TestMetrics) ... === TestName: test_list_zones_metrics | Status : SUCCESS === ok [root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//1A23HU/failed_plus_exceptions.txt 2017-03-31 10:21:19,514 - CRITICAL - EXCEPTION: test_list_hosts_metrics: ['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n testMethod()\n', ' File "/home/t_vazqnadmin/cloudstack/test/integration/smoke/test_metrics_api.py", line 77, in test_list_hosts_metrics\nhost_metric = self.apiclient.listHostsMetrics(cmd)[0]\n', ' File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 3094, in listHostsMetrics\nresponse = self.connection.marvinRequest(command, response_type=response, method=method)\n', ' File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest\nraise e\n', "CloudstackAPIException: Execute cmd: listhostsmetrics failed, due to: errorCode: 530, errorText:No value specified for 'Date'\n"] 2017-03-31 10:23:50,276 - CRITICAL - EXCEPTION: test_list_volumes_metrics: ['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n testMethod()\n', ' File "/home/t_vazqnadmin/cloudstack/test/integration/smoke/test_metrics_api.py", line 172, in test_list_volumes_metrics\nlvm = self.apiclient.listVolumesMetrics(cmd)[0]\n', ' File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 954, in listVolumesMetrics\nresponse = self.connection.marvinRequest(command, response_type=response, method=method)\n', ' File "/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest\nraise e\n', "CloudstackAPIException: Execute cmd: listvolumesmetrics failed, due to: errorCode: 530, errorText:No value specified for 'Date'\n"] Exception is thrown by `BeanUtils.copyProperties`, log on management server: 2017-03-31 10:28:33,257 ERROR [cloud.api.ApiServer] (catalina-exec-15:ctx-7fb0b31e ctx-6ded5acb) unhandled exception executing api command: [Ljava.lang.String;@63f1496d org.apache.commons.beanutils.ConversionException: No value specified for 'Date' at org.apache.commons.beanutils.converters.AbstractConverter.handleMissing(AbstractConverter.java:310) at org.apache.commons.beanutils.converters.AbstractConverter.convert(AbstractConverter.java:136) at org.apache.commons.beanutils.converters.ConverterFacade.convert(ConverterFacade.java:60) at org.apache.commons.beanutils.BeanUtilsBean.convert(BeanUtilsBean.java:1078) at org.apache.commons.beanutils.BeanUtilsBean.copyProperty(BeanUtilsBean.java:437) at org.apache.commons.beanutils.BeanUtilsBean.copyProperties(BeanUtilsBean.java:286) at org.apache.commons.beanutils.BeanUtils.copyProperties(BeanUtils.java:137) at org.apache.cloudstack.metrics.MetricsServiceImpl.listHostMetrics(MetricsServiceImpl.java:244) at org.apache.cloudstack.api.ListHostsMetricsCmd.execute(ListHostsMetricsCmd.java:48) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:709) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:533) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:299)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942204#comment-15942204 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi this is merge-able and much needed enhancement to improve UI performance for large environments > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925746#comment-15925746 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi ping? can this be merged as well, this greatly improves the UI performance for the existing metrics view feature as well as improves the load time of the infrastructure tab @abhinandanprateek @DaanHoogland - would you like to review this as well, thanks. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889539#comment-15889539 ] ASF GitHub Bot commented on CLOUDSTACK-9783: GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit Marvin test results: === TestName: test_list_clusters_metrics | Status : SUCCESS === === TestName: test_list_hosts_metrics | Status : SUCCESS === === TestName: test_list_infrastructure_metrics | Status : SUCCESS === === TestName: test_list_pstorage_metrics | Status : SUCCESS === === TestName: test_list_vms_metrics | Status : SUCCESS === === TestName: test_list_volumes_metrics | Status : SUCCESS === === TestName: test_list_zones_metrics | Status : SUCCESS === You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.9-metrics-enhancement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1944 commit 402253504e9520104caf9fbc1317042f2fd89474 Author: Rohit Yadav Date: 2017-02-16T08:15:15Z CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by reimplementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Signed-off-by: Rohit Yadav > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889538#comment-15889538 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1944 > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887400#comment-15887400 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit @karuturi this is ready for merge, as soon as Travis passes. Thanks. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887349#comment-15887349 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd I guess this is fine for now. Thanks! > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887336#comment-15887336 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rashmidixit the current UI does not support support pluggability of components within UI like the backend does. We can have a separate tab but not the implementation that the current metrics view UI has i.e. embedded across resource views. It's a general purpose feature that works for all deployments/environments and I think most users would want to keep it so we never implemented a way to disable it. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887338#comment-15887338 ] ASF GitHub Bot commented on CLOUDSTACK-9783: GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit Marvin test results: === TestName: test_list_clusters_metrics | Status : SUCCESS === === TestName: test_list_hosts_metrics | Status : SUCCESS === === TestName: test_list_infrastructure_metrics | Status : SUCCESS === === TestName: test_list_pstorage_metrics | Status : SUCCESS === === TestName: test_list_vms_metrics | Status : SUCCESS === === TestName: test_list_volumes_metrics | Status : SUCCESS === === TestName: test_list_zones_metrics | Status : SUCCESS === You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.9-metrics-enhancement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1944 commit 3881d249d07f16bde77c20450c5f39425a135e42 Author: Rohit Yadav Date: 2017-02-16T08:15:15Z CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by reimplementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Signed-off-by: Rohit Yadav > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887337#comment-15887337 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1944 > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885615#comment-15885615 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd On the contrary, I think you adding metrics as pluggable API is a good idea. However, to seriously make the feature pluggable the UI component should also load based on a plugin based flag. For example (I am not sure if the current design makes this possible), the plugin should return a flag in the listCapabilities API which tells the UI that metrics is enabled. If this flag is present, the metrics button should appear, else not. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885599#comment-15885599 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @borisstoyanov can you see the failure in Travis with test_list_infrastructure_metrics test case? Thanks @rashmidixit you're right I added this as a plugin to keep it separate from the core APIs. If this is a major concern, I can move these APIs to server/api modules. From the UI, to remove this service they can modify the core metrics widget to do no-operation (in ui/scripts/ui-custom/metricsView.js) and the rendered button can be modified to be hidden, alternatively metricsView section can be removed across the resources (zones, cluster, host, vms, volumes and storage pool). > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885235#comment-15885235
]
ASF GitHub Bot commented on CLOUDSTACK-9783:
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1944#discussion_r103143033
--- Diff: plugins/metrics/pom.xml ---
@@ -0,0 +1,55 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+ cloud-plugin-metrics
+ Apache CloudStack Plugin - Metrics
+
+org.apache.cloudstack
+cloudstack-plugins
+4.9.3.0-SNAPSHOT
+../pom.xml
+
+
+
+ org.apache.cloudstack
+ cloud-api
+ ${project.version}
+
+
+ org.apache.cloudstack
+ cloud-utils
+ ${project.version}
+
+
+
+
--- End diff --
Would be nice to follow maven standards on new modules. Since you cannot
inherit from `cloud-maven-standard` you have to put all those lines:
```
${basedir}/src/main/java
${basedir}/src/main/scripts
${basedir}/src/test/java
${basedir}/target/classes
${basedir}/target/test-classes
${basedir}/src/main/resources
${basedir}/src/test/resources
...
```
> Improve metrics view performance
>
>
> Key: CLOUDSTACK-9783
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: Future, 4.10.0.0, 4.9.3.0
>
>
> Metrics view is a pure frontend feature, where several API calls are made to
> generate the metrics view tabular data. In very large environments, rendering
> of these tables can take a lot of time, especially when there is high
> latency. The improvement task is to reimplement this feature by moving the
> logic to backend so metrics calculations happen at the backend and final
> result can be served by a single API request.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885205#comment-15885205 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit awaiting your review > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880100#comment-15880100 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd Will be trying this out today - will post my comments. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879162#comment-15879162 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1944 seen it work in practice: LGTM > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877870#comment-15877870 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Requesting for review - @abhinandanprateek @DaanHoogland @rashmidixit @karuturi @koushik-das > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871687#comment-15871687 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @borisstoyanov test results LGTM. /cc @karuturi > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871272#comment-15871272 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1944 I've created a Trillian env out of the PR and run the test and it has passed: ``` test_list_vms_metrics (tests.smoke.test_metrics_api.TestMetrics) ... === TestName: test_list_vms_metrics | Status : SUCCESS === ok ``` > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870350#comment-15870350 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1944 Just triggered Trillian env to check the test failure. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870291#comment-15870291 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1944 Trillian test result (tid-833) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28094 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1944-t833-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Test completed. 47 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 355.57 | test_privategw_acl.py test_list_vms_metrics | `Error` | 10.34 | test_metrics_api.py test_01_vpc_site2site_vpn | Success | 160.37 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 71.41 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 307.09 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 313.58 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 534.07 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 521.52 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1301.55 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 560.88 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 760.16 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1282.47 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.78 | test_volumes.py test_08_resize_volume | Success | 156.38 | test_volumes.py test_07_resize_fail | Success | 161.46 | test_volumes.py test_06_download_detached_volume | Success | 156.28 | test_volumes.py test_05_detach_volume | Success | 155.78 | test_volumes.py test_04_delete_attached_volume | Success | 151.10 | test_volumes.py test_03_download_attached_volume | Success | 156.46 | test_volumes.py test_02_attach_volume | Success | 94.97 | test_volumes.py test_01_create_volume | Success | 711.44 | test_volumes.py test_deploy_vm_multiple | Success | 253.11 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.68 | test_vm_life_cycle.py test_09_expunge_vm | Success | 185.31 | test_vm_life_cycle.py test_08_migrate_vm | Success | 40.88 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.76 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.85 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 50.49 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.08 | test_templates.py test_04_extract_template | Success | 5.15 | test_templates.py test_03_delete_template | Success | 5.10 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 60.53 | test_templates.py test_10_destroy_cpvm | Success | 161.59 | test_ssvm.py test_09_destroy_ssvm | Success | 163.58 | test_ssvm.py test_08_reboot_cpvm | Success | 131.59 | test_ssvm.py test_07_reboot_ssvm | Success | 133.52 | test_ssvm.py test_06_stop_cpvm | Success | 131.79 | test_ssvm.py test_05_stop_ssvm | Success | 133.81 | test_ssvm.py test_04_cpvm_internals | Success | 1.21 | test_ssvm.py test_03_ssvm_internals | Success | 3.35 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.03 | test_snapshots.py test_04_change_offering_small | Success | 234.65 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py test_01_create_service_offering | Success | 0.10 | test_service_offerings.py test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_09_reboot_router | Success | 35.28 | test_routers.py test_08_start_router | Suc
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870243#comment-15870243 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks for testing/reviewing @borisstoyanov > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869588#comment-15869588 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869587#comment-15869587 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @blueorangutan test > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869570#comment-15869570 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1944 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-492 > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869543#comment-15869543 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869540#comment-15869540 ] ASF GitHub Bot commented on CLOUDSTACK-9783: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @blueorangutan package > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9783) Improve metrics view performance
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869533#comment-15869533 ] ASF GitHub Bot commented on CLOUDSTACK-9783: GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance that re-implement the frontend logic at backend: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Pinging for review - @abhinandanprateek @DaanHoogland @borisstoyanov @karuturi @rashmidixit You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.9-metrics-enhancement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1944 commit 3aba6ad6c095c066ab0334c8a48565741b2913fe Author: Rohit Yadav Date: 2017-02-16T08:15:15Z CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by reimplementing the logic at the backend and data served via APIs. In large environments, the older implementation would make several API calls that increases both network and database load. List of APIs introduced for improving the performance: listClustersMetrics listHostsMetrics listInfrastructure listStoragePoolsMetrics listVMsMetrics listVolumesMetrics listZonesMetrics Signed-off-by: Rohit Yadav > Improve metrics view performance > > > Key: CLOUDSTACK-9783 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9783 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0, 4.9.3.0 > > > Metrics view is a pure frontend feature, where several API calls are made to > generate the metrics view tabular data. In very large environments, rendering > of these tables can take a lot of time, especially when there is high > latency. The improvement task is to reimplement this feature by moving the > logic to backend so metrics calculations happen at the backend and final > result can be served by a single API request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
