[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111854#comment-16111854
 ] 

ASF subversion and git services commented on CLOUDSTACK-9840:
-

Commit 43ae8e3503bc746f412e34e3fe6488e00def4ed0 in cloudstack's branch 
refs/heads/master from [~olemasle]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=43ae8e3 ]

CLOUDSTACK-9840: Fix datetime format of snapshots events (#2008)

Include the timezone in datetime format of snapshot events, to be consistent
with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was
updated the same day to add the timezone (commit bf967eb622f) except for
Snapshots.

> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956784#comment-15956784
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@olivierlemasle I think this PR needs at least 2 LGTMs and as agreed Rajani 
is taking care of mergin PRs. 


> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956731#comment-15956731
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user olivierlemasle commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
The Travis tests have finally succeeded.
@borisstoyanov Any chance merging this pull request?


> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954297#comment-15954297
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user olivierlemasle closed the pull request at:

https://github.com/apache/cloudstack/pull/2008


> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954298#comment-15954298
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


GitHub user olivierlemasle reopened a pull request:

https://github.com/apache/cloudstack/pull/2008

[CLOUDSTACK-9840] Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be 
consistent with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was 
updated the same day to add the timezone (commit bf967eb622f) except for 
Snapshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Amysta/cloudstack eventDateTimeTz

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2008


commit b37ca77636feb22327d1b819657c6fd3913696fe
Author: Olivier Lemasle 
Date:   2017-03-15T15:29:44Z

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be consistent
with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was
updated the same day to add the timezone (commit bf967eb622f) except for
Snapshots.




> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933211#comment-15933211
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
Trillian test result (tid-961)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27589 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2008-t961-kvm-centos7.zip
Intermitten failure detected: 
/marvin/tests/smoke/test_outofbandmanagement.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 305.43 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 155.01 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.15 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 230.65 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 281.79 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 493.39 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 510.93 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1404.00 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 529.02 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 728.24 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1280.56 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.46 | test_volumes.py
test_08_resize_volume | Success | 156.37 | test_volumes.py
test_07_resize_fail | Success | 161.44 | test_volumes.py
test_06_download_detached_volume | Success | 151.40 | test_volumes.py
test_05_detach_volume | Success | 150.75 | test_volumes.py
test_04_delete_attached_volume | Success | 151.23 | test_volumes.py
test_03_download_attached_volume | Success | 156.30 | test_volumes.py
test_02_attach_volume | Success | 89.17 | test_volumes.py
test_01_create_volume | Success | 620.73 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.69 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.72 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 242.50 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.53 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.15 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.83 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 126.14 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.38 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 75.64 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 25.33 | test_templates.py
test_10_destroy_cpvm | Success | 131.32 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.62 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.37 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.05 | test_ssvm.py
test_06_stop_cpvm | Success | 101.43 | test_ssvm.py
test_05_stop_ssvm | Success | 133.21 | test_ssvm.py
test_04_cpvm_internals | Success | 0.97 | test_ssvm.py
test_03_ssvm_internals | Success | 2.87 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.12 | test_snapshots.py
test_04_change_offering_small | Success | 204.46 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932448#comment-15932448
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932447#comment-15932447
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
thanks @olivierlemasle that look ok, marvin tests seem to fail, will rerun 
then now.
@blueorangutan test


> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CLOUDSTACK-9840) Datetime format of snapshot events is inconsistent with other events

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932418#comment-15932418
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9840:


Github user olivierlemasle commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@borisstoyanov Thanks, I've renamed the pull request. Do you want me to 
rename to commit as well?

Additionally, the travis checks hit a timeout; I've closed and opened again 
this pull request twice to trigger a new build, with no success.


> Datetime format of snapshot events is inconsistent with other events
> 
>
> Key: CLOUDSTACK-9840
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9840
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: eventbus
>Affects Versions: 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2, 
> 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 
> 4.9.2.0, 4.9.1.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>Reporter: Olivier Lemasle
>Assignee: Olivier Lemasle
>
> The timezone is not included in datetime format of snapshot events, whereas 
> it is included for other events.
> "eventDateTime" was added by [~chipchilders] in commit 14ee684 and was 
> updated the same day to add the timezone (commit bf967eb) except for 
> Snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)