[jira] Commented: (SCXML-108) Add
[ https://issues.apache.org/jira/browse/SCXML-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711830#action_12711830 ] Rahul Akolkar commented on SCXML-108: - Ingmar - Before I dig deeper into any of this, could you fill out an Individual Contributor License Agreement (ICLA) for this? That is here (the fax number is on the form itself, you can mail it in too if you want): http://www.apache.org/licenses/icla.txt Its a one-time thing (so you won't need to do it for any more patches you submit across the ASF), and is needed for contributions such as this one which may contain new source files, for provenance and pedigree reasons. Once its sent out (and recorded - I can track that), we can move this ticket forward. Let us know if you have questions about that. > Add
[jira] Updated: (JEXL-55) JEXL 2.0 redux, attempting to restart the effort to release 2.0
[ https://issues.apache.org/jira/browse/JEXL-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-55: -- Attachment: jexl-redux.zip This is *not* a patch file but a zip containing all the java files (src + test). > JEXL 2.0 redux, attempting to restart the effort to release 2.0 > --- > > Key: JEXL-55 > URL: https://issues.apache.org/jira/browse/JEXL-55 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Henri Biestro > Fix For: 2.0 > > Attachments: jexl-redux.zip > > > JEXL 2.0 redux > This is an attempt at restarting the JEXL 2.0 release effort based on the 2.0 > trunk. > There was a lot of effort & good ideas already in the 2.0 branch and JEXL is > just too convenient (imho) to be left in this state. > The patch keeps the 2.0 structure, most notably using the visitor pattern to > implement the interpreter. > This allows to modify the grammar much more easily since the javacc generated > code does not need to be modified. > This patch incorporates a few fixes & enhancements: > - Bean & ant-ish like assignment; allows expressions like "foo.bar.quux = > 'some value'" > If 'foo' is resolved as an object from the JexlContext, and 'foo' can access > a 'bar' (either as > a map access or a bean property) that itself allows to set a 'quux', that > 'quux' will be set with > the value. > The 'ant-ish' like properties can only be set if no bean can be accessed > during the evaluation. > That is, in our case, if 'foo' & 'foo.bar' can *not* be solved as beans from > the JexlContext, > the property 'foo.bar.quux' will be added to the JexlContext. This is to > avoid ambiguities > that could stem from having both a 'foo.quux' ant property and a 'foo' in the > JexlContext. > - Ternary operator (+ GNU C extension '?:'); allows expressions like > "foo?'true-or-not-null':'false-or-null' > and 'foo?:"foo-is-null" > The ternary operator is what you expect; the "?:" syntax allows the second > operand to be omitted, and the first operand is implicitly used as the second. > The expression 'x?:z' is equivalent to 'x?x:z' > - Exception handling revisited; silent (aka 1.1 mode) or not > The 1.1 code was silent in almost all cases when an exception occurs and > usually returns 'null' in that case. > The new code also allows to set the engine in a non lenient mode where all > exceptions & errors will be reported, > wrapped in a o.a.c.jexl.JexlException. This runtime exception carries which > node (in the tree) is the point of origin, allowing > to better diagnose why the error (the cause) occurs. > - ScriptFactory, ExpressionFactory refactored > A JexlEngine class is used as the non-static version instance; this should > allow easier customization. > The pre/post resolvers have been removed from expressions since it is now > much easier to just derive > from Interpreter to implement something specific. > - java 5 based > The JEXL-54 patch has been folded in; besides light performance improvement, > it makes the code more > readable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (JEXL-55) JEXL 2.0 redux, attempting to restart the effort to release 2.0
JEXL 2.0 redux, attempting to restart the effort to release 2.0 --- Key: JEXL-55 URL: https://issues.apache.org/jira/browse/JEXL-55 Project: Commons JEXL Issue Type: Improvement Affects Versions: 2.0 Reporter: Henri Biestro Fix For: 2.0 JEXL 2.0 redux This is an attempt at restarting the JEXL 2.0 release effort based on the 2.0 trunk. There was a lot of effort & good ideas already in the 2.0 branch and JEXL is just too convenient (imho) to be left in this state. The patch keeps the 2.0 structure, most notably using the visitor pattern to implement the interpreter. This allows to modify the grammar much more easily since the javacc generated code does not need to be modified. This patch incorporates a few fixes & enhancements: - Bean & ant-ish like assignment; allows expressions like "foo.bar.quux = 'some value'" If 'foo' is resolved as an object from the JexlContext, and 'foo' can access a 'bar' (either as a map access or a bean property) that itself allows to set a 'quux', that 'quux' will be set with the value. The 'ant-ish' like properties can only be set if no bean can be accessed during the evaluation. That is, in our case, if 'foo' & 'foo.bar' can *not* be solved as beans from the JexlContext, the property 'foo.bar.quux' will be added to the JexlContext. This is to avoid ambiguities that could stem from having both a 'foo.quux' ant property and a 'foo' in the JexlContext. - Ternary operator (+ GNU C extension '?:'); allows expressions like "foo?'true-or-not-null':'false-or-null' and 'foo?:"foo-is-null" The ternary operator is what you expect; the "?:" syntax allows the second operand to be omitted, and the first operand is implicitly used as the second. The expression 'x?:z' is equivalent to 'x?x:z' - Exception handling revisited; silent (aka 1.1 mode) or not The 1.1 code was silent in almost all cases when an exception occurs and usually returns 'null' in that case. The new code also allows to set the engine in a non lenient mode where all exceptions & errors will be reported, wrapped in a o.a.c.jexl.JexlException. This runtime exception carries which node (in the tree) is the point of origin, allowing to better diagnose why the error (the cause) occurs. - ScriptFactory, ExpressionFactory refactored A JexlEngine class is used as the non-static version instance; this should allow easier customization. The pre/post resolvers have been removed from expressions since it is now much easier to just derive from Interpreter to implement something specific. - java 5 based The JEXL-54 patch has been folded in; besides light performance improvement, it makes the code more readable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-72) Move acknowledgements from NOTICE to README
[ https://issues.apache.org/jira/browse/COMPRESS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711556#action_12711556 ] Jukka Zitting commented on COMPRESS-72: --- Do we have trails for the BZip2 and CPIO contributions? > Move acknowledgements from NOTICE to README > --- > > Key: COMPRESS-72 > URL: https://issues.apache.org/jira/browse/COMPRESS-72 > Project: Commons Compress > Issue Type: Improvement >Reporter: Jukka Zitting >Priority: Minor > > The NOTICE.txt file in commons-compress contains the following entries: > Original BZip2 classes contributed by Keiron Liddle > , Aftex Software to the Apache Ant project > Original Tar classes from contributors of the Apache Ant project > Original Zip classes from contributors of the Apache Ant project > Original CPIO classes contributed by Markus Kuss and the jRPM project > (jrpm.sourceforge.net) > It's good that we acknowledge contributions, but having those entries in the > NOTICE file is not appropriate unless the licensing of the original > contributions explicitly required such attribution notices. > I suggest that we move these entries to a README.txt file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMPRESS-72) Move acknowledgements from NOTICE to README
[
https://issues.apache.org/jira/browse/COMPRESS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting updated COMPRESS-72:
--
Description:
The NOTICE.txt file in commons-compress contains the following entries:
{noformat}
Original BZip2 classes contributed by Keiron Liddle
, Aftex Software to the Apache Ant project
Original Tar classes from contributors of the Apache Ant project
Original Zip classes from contributors of the Apache Ant project
Original CPIO classes contributed by Markus Kuss and the jRPM project
(jrpm.sourceforge.net)
{noformat}
It's good that we acknowledge contributions, but having those entries in the
NOTICE file is not appropriate unless the licensing of the original
contributions explicitly required such attribution notices.
I suggest that we move these entries to a README.txt file.
was:
The NOTICE.txt file in commons-compress contains the following entries:
Original BZip2 classes contributed by Keiron Liddle
, Aftex Software to the Apache Ant project
Original Tar classes from contributors of the Apache Ant project
Original Zip classes from contributors of the Apache Ant project
Original CPIO classes contributed by Markus Kuss and the jRPM project
(jrpm.sourceforge.net)
It's good that we acknowledge contributions, but having those entries in the
NOTICE file is not appropriate unless the licensing of the original
contributions explicitly required such attribution notices.
I suggest that we move these entries to a README.txt file.
> Move acknowledgements from NOTICE to README
> ---
>
> Key: COMPRESS-72
> URL: https://issues.apache.org/jira/browse/COMPRESS-72
> Project: Commons Compress
> Issue Type: Improvement
>Reporter: Jukka Zitting
>Priority: Minor
>
> The NOTICE.txt file in commons-compress contains the following entries:
> {noformat}
> Original BZip2 classes contributed by Keiron Liddle
> , Aftex Software to the Apache Ant project
> Original Tar classes from contributors of the Apache Ant project
> Original Zip classes from contributors of the Apache Ant project
> Original CPIO classes contributed by Markus Kuss and the jRPM project
> (jrpm.sourceforge.net)
> {noformat}
> It's good that we acknowledge contributions, but having those entries in the
> NOTICE file is not appropriate unless the licensing of the original
> contributions explicitly required such attribution notices.
> I suggest that we move these entries to a README.txt file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-72) Move acknowledgements from NOTICE to README
[ https://issues.apache.org/jira/browse/COMPRESS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711551#action_12711551 ] Sebb commented on COMPRESS-72: -- +1 to moving the Ant mentions. -1 to moving the others until the requirements are known. > Move acknowledgements from NOTICE to README > --- > > Key: COMPRESS-72 > URL: https://issues.apache.org/jira/browse/COMPRESS-72 > Project: Commons Compress > Issue Type: Improvement >Reporter: Jukka Zitting >Priority: Minor > > The NOTICE.txt file in commons-compress contains the following entries: > Original BZip2 classes contributed by Keiron Liddle > , Aftex Software to the Apache Ant project > Original Tar classes from contributors of the Apache Ant project > Original Zip classes from contributors of the Apache Ant project > Original CPIO classes contributed by Markus Kuss and the jRPM project > (jrpm.sourceforge.net) > It's good that we acknowledge contributions, but having those entries in the > NOTICE file is not appropriate unless the licensing of the original > contributions explicitly required such attribution notices. > I suggest that we move these entries to a README.txt file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (COMPRESS-72) Move acknowledgements from NOTICE to README
Move acknowledgements from NOTICE to README --- Key: COMPRESS-72 URL: https://issues.apache.org/jira/browse/COMPRESS-72 Project: Commons Compress Issue Type: Improvement Reporter: Jukka Zitting Priority: Minor The NOTICE.txt file in commons-compress contains the following entries: Original BZip2 classes contributed by Keiron Liddle , Aftex Software to the Apache Ant project Original Tar classes from contributors of the Apache Ant project Original Zip classes from contributors of the Apache Ant project Original CPIO classes contributed by Markus Kuss and the jRPM project (jrpm.sourceforge.net) It's good that we acknowledge contributions, but having those entries in the NOTICE file is not appropriate unless the licensing of the original contributions explicitly required such attribution notices. I suggest that we move these entries to a README.txt file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
