[jira] Resolved: (LANG-204) [lang] org.apache.commons.lang.Entities multithreaded init.
[ https://issues.apache.org/jira/browse/LANG-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-204. -- Resolution: Fixed Fix Version/s: (was: 2.x) 2.5 > [lang] org.apache.commons.lang.Entities multithreaded init. > --- > > Key: LANG-204 > URL: https://issues.apache.org/jira/browse/LANG-204 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 2.1 > Environment: Operating System: other > Platform: Other >Reporter: Gary Gregory >Priority: Minor > Fix For: 2.5 > > > -Original Message- > From: Gaulin, David: #CIPO - OPIC [mailto:gaulin.da...@ic.gc.ca] > Sent: Wednesday, April 26, 2006 5:09 AM > To: commons-...@jakarta.apache.org > Subject: [lang] org.apache.commons.lang.Entities > Hello, > Not sure if it is the right mailling list but here we go anyway. > I am currently using the Entities.java class (well I am using the > StringEscapeUtils.java which uses that class). Works really good, saved me a > lot of time. My thanks to the people who wrote it. > I have encountered a little problems with it taught. Nothing major but I just > taugth I would share since it migth be of interest to you. > I have an heavily multithreaded process that runs on a really under powered > server. All those threads access the StringEscapeUtils.escapeXml() methods > pretty much at the same time. What happens is that by the time the Second or > Third Thread calls the StringEscapeUtils.escapeXml() the static initialization > in the Entities.java class has not completed yet. That block in particular. > static { > XML = new Entities(); > XML.addEntities(BASIC_ARRAY); > XML.addEntities(APOS_ARRAY); > } > I don't get a NullPointer so it seems that XML = new Entities() is actually > being executed before the other Thread starts but the > XML.addEntities(BASIC_ARRAY) on the other hand is not executed before the > other > thread starts. So when the second or third thread calls the > StringEscapeUtils.escapeXml() it doesn't escape the BASIC_ARRAY or APOS_ARRAY > entities. To fix it, in my code, I just make sure to call > StringEscapeUtils.escapeXml() before I start any threads and it solve the > problems but if anyone is ever to re-work the class this might be something to > look at. > Just to share. > Thank > David -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LANG-525) Apply patches from 3.0 to 2.5 if a 2.5 release happens
[ https://issues.apache.org/jira/browse/LANG-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-525. -- Resolution: Fixed > Apply patches from 3.0 to 2.5 if a 2.5 release happens > -- > > Key: LANG-525 > URL: https://issues.apache.org/jira/browse/LANG-525 > Project: Commons Lang > Issue Type: Task > Components: General >Reporter: Henri Yandell > Fix For: 2.x > > > List issues whose fixes would be desirable on a 2.x branch if we were to have > one. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-76) [lang] EnumUtils.getEnum() doesn't work well in 1.5
[ https://issues.apache.org/jira/browse/LANG-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835922#action_12835922 ] Niall Pemberton commented on LANG-76: - I added a test case for this: http://svn.apache.org/viewvc?rev=911954&view=rev And I tried testing using Sun's JDK 1.5.0_01 and 1.5.0_22 on a Windows XP machine and I cannot reproduce it. Can anyone see whats wrong with my test case - or provide one that can reproduce the error? > [lang] EnumUtils.getEnum() doesn't work well in 1.5 > --- > > Key: LANG-76 > URL: https://issues.apache.org/jira/browse/LANG-76 > Project: Commons Lang > Issue Type: Bug > Components: lang.enums.* >Affects Versions: 2.1 > Environment: Operating System: other > Platform: Other >Reporter: Igor Laberov > Fix For: 2.x > > > Hi, > I encountered with problem using EnumUtils.getEnum() in 1.5. It appears that > my > Enum class should be accessed first so constructor will be called. In 1.4 it > was > enough to have myClass.class, so all static members were initialized. In 1.5 > it > doesn't work. > I noticed that static members are not initialized anymore while acessing to > class definition. See the code > public class Test { > public static final class TT{ > public static final TT one = new TT(); > private TT(){ > System.out.println("Called TT" ); > } > } > > public static void main(String[] args) { > Class cl = TT.class; >// System.out.println( TT.one); > // System.out.println(TT.class.isAssignableFrom(String.class)); > } > } > In 1.4 constructor of TT is called, while in 1.5 is not. > Actually, according to the spec > (http://java.sun.com/docs/books/jls/second_edition/html/execution.doc.html#57946), > this is right behavior of Java. > Unfortunately, I didn't succeded to think about good solution.. > P.s. I know that in 1.5 we have enum built-in, but it is not the same, and we > try to move to 1.5 without too much changes -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (CHAIN-6) [chain] CopyCommand does not work unless setValue is called
[ https://issues.apache.org/jira/browse/CHAIN-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated CHAIN-6: Comment: was deleted (was: [buy cheap tramadol on|http://thoughtmesh.net/meshes.php?group=33] [buy tramadol online|http://thoughtmesh.net/meshes.php?group=34] [buy tramadol cod|http://thoughtmesh.net/meshes.php?group=35] [cheap tramadol|http://thoughtmesh.net/meshes.php?group=36] [cheapest tramadol on line|http://thoughtmesh.net/meshes.php?group=37] [cod accepted orders for tramadol|http://thoughtmesh.net/meshes.php?group=38] [tramadol prescription from discount pharmacy|http://thoughtmesh.net/meshes.php?group=39] [best price on tramadol 50 and 100 mg|http://thoughtmesh.net/meshes.php?group=40] [ingredients in tramadol|http://thoughtmesh.net/meshes.php?group=41] [online prescriptions tramadoltramadol online|http://thoughtmesh.net/meshes.php?group=42] [tramadol price|http://thoughtmesh.net/meshes.php?group=43] [side effects tramadol|http://thoughtmesh.net/meshes.php?group=44] [tramadol hcl 50 mg|http://thoughtmesh.net/meshes.php?group=45] [tramadol hydrochloride capsules 50mg|http://thoughtmesh.net/meshes.php?group=46] [tramadol 180|http://thoughtmesh.net/meshes.php?group=47] [addiction to tramadol|http://thoughtmesh.net/meshes.php?group=48] [is tramadol a narcotic|http://thoughtmesh.net/meshes.php?group=49] [canine tramadol dosage|http://thoughtmesh.net/meshes.php?group=50] [cheap tramadol fedex overnight|http://thoughtmesh.net/meshes.php?group=51] [tramadol prescription drug|http://thoughtmesh.net/meshes.php?group=52] [side effects of tramadol hydrochloride|http://thoughtmesh.net/meshes.php?group=53] [tramadol sales|http://thoughtmesh.net/meshes.php?group=54] [is tramadol hcl a narcotic|http://thoughtmesh.net/meshes.php?group=55] [tramadol hydrochloride 100mg|http://thoughtmesh.net/meshes.php?group=56] [tramadol sale us no prescription required|http://thoughtmesh.net/meshes.php?group=57] [tramadol medication|http://thoughtmesh.net/meshes.php?group=58] [what is tramadol|http://thoughtmesh.net/meshes.php?group=59] [tramadol 100 mg|http://thoughtmesh.net/meshes.php?group=60] [tramadol no prescription fedex|http://thoughtmesh.net/meshes.php?group=61] [buy cheap tramadol on|http://thoughtmesh.net/meshes.php?group=62] [cheapest tramadol available online|http://thoughtmesh.net/meshes.php?group=63] [order tramadol cod|http://thoughtmesh.net/meshes.php?group=64] [buy tramadol cheap medication inurl|http://thoughtmesh.net/meshes.php?group=65] [overnight tramadol|http://thoughtmesh.net/meshes.php?group=66] [can i take tramadol pain pills if theyre a year old|http://thoughtmesh.net/meshes.php?group=67] [tramadol pharmacy|http://thoughtmesh.net/meshes.php?group=68] [tramadol pill|http://thoughtmesh.net/meshes.php?group=69] [tramadol pills|http://thoughtmesh.net/meshes.php?group=70] [tramadol prescription|http://thoughtmesh.net/meshes.php?group=71] [tramadol hydrochloride|http://thoughtmesh.net/meshes.php?group=72] [best price tramadol|http://thoughtmesh.net/meshes.php?group=73] [tramadol sale us no prescription required|http://thoughtmesh.net/meshes.php?group=74] [tramadol side effects|http://thoughtmesh.net/meshes.php?group=75] [tramadol buy online|http://thoughtmesh.net/meshes.php?group=76] [buy tultram online cheap|http://thoughtmesh.net/meshes.php?group=77] [what are the withdrawal symptoms of tramadol|http://thoughtmesh.net/meshes.php?group=78] [tramadol hcl|http://thoughtmesh.net/meshes.php?group=79] [ingredients in tramadol|http://thoughtmesh.net/meshes.php?group=80] [tramadol drug|http://thoughtmesh.net/meshes.php?group=81] ) > [chain] CopyCommand does not work unless setValue is called > --- > > Key: CHAIN-6 > URL: https://issues.apache.org/jira/browse/CHAIN-6 > Project: Commons Chain > Issue Type: Bug > Environment: Operating System: All > Platform: All >Reporter: William Slough > Fix For: 1.1 > > Attachments: CopyCommand.patch > > > CopyCommand appears to only work if the setValue method is run. The > documentation says "... a context attribute stored under the fromKey (if any), > to the toKey". If only the fromKey and toKey are set, the toKey and its > stored > value are deleted from the Context regardless of fromKey's value. This should > only happen if the fromKey value is null. > In the execute method of CopyCommand, it appears that > if (value == null) { > context.get(getFromKey()); > } > should read > if (value == null) { > value = context.get(getFromKey()); > } > then the rest of the code should function as expected: > if (value != null) { > context.put(getToKey(), value); > } else { > context.remove(getToKey()); > } > return (false); -- This message is automatically generated b
[jira] Commented: (COMPRESS-80) wrong checksum for maven artifacts in repository
[ https://issues.apache.org/jira/browse/COMPRESS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835834#action_12835834 ] Aaron Kaplan commented on COMPRESS-80: -- The checksum for commons-compress-1.0.jar is ok, but those of commons-compress-1.0-sources.jar and commons-compress-1.0-javadoc.jar are still wrong. > wrong checksum for maven artifacts in repository > > > Key: COMPRESS-80 > URL: https://issues.apache.org/jira/browse/COMPRESS-80 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.0 >Reporter: Daan de Wit > Fix For: 1.0 > > > The central repository contains wrong checksums for the compress-1.0 > artifacts. This will cause many company repositories to ignore these > artifacts. The following is logged when doing for examle mvn dependency:tree > on tika trunk: > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '325980a09dbbd0c108ece8e7733b462b00e6f2a8'; remote > = 'commons-compress-1.0.pom:' - RETRYING > Downloading: > http://repo1.maven.org/maven2/org/apache/commons/commons-compress/1.0/commons-compress-1.0.pom > 7K downloaded > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '325980a09dbbd0c108ece8e7733b462b00e6f2a8'; remote > = 'commons-compress-1.0.pom:' - IGNORING > [INFO] snapshot org.apache.tika:tika-core:0.4-SNAPSHOT: checking for updates > from libs-snapshots > Downloading: http://[company > repo]/libs-releases/org/apache/commons/commons-compress/1.0/commons-compress-1.0.jar > Downloading: http://[company > repo]/ext-releases/org/apache/commons/commons-compress/1.0/commons-compress-1.0.jar > Downloading: > http://repo1.maven.org/maven2/org/apache/commons/commons-compress/1.0/commons-compress-1.0.jar > 140K downloaded > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '995ae384a0b1e2c66269e6bc5198db8561fb45a2'; remote > = 'commons-compress-1.0.jar:' - RETRYING > Downloading: > http://repo1.maven.org/maven2/org/apache/commons/commons-compress/1.0/commons-compress-1.0.jar > 140K downloaded > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '995ae384a0b1e2c66269e6bc5198db8561fb45a2'; remote > = 'commons-compress-1.0.jar:' - IGNORING -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (CHAIN-6) [chain] CopyCommand does not work unless setValue is called
[ https://issues.apache.org/jira/browse/CHAIN-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835833#action_12835833 ] Razan Abbass commented on CHAIN-6: -- [buy cheap tramadol on|http://thoughtmesh.net/meshes.php?group=33] [buy tramadol online|http://thoughtmesh.net/meshes.php?group=34] [buy tramadol cod|http://thoughtmesh.net/meshes.php?group=35] [cheap tramadol|http://thoughtmesh.net/meshes.php?group=36] [cheapest tramadol on line|http://thoughtmesh.net/meshes.php?group=37] [cod accepted orders for tramadol|http://thoughtmesh.net/meshes.php?group=38] [tramadol prescription from discount pharmacy|http://thoughtmesh.net/meshes.php?group=39] [best price on tramadol 50 and 100 mg|http://thoughtmesh.net/meshes.php?group=40] [ingredients in tramadol|http://thoughtmesh.net/meshes.php?group=41] [online prescriptions tramadoltramadol online|http://thoughtmesh.net/meshes.php?group=42] [tramadol price|http://thoughtmesh.net/meshes.php?group=43] [side effects tramadol|http://thoughtmesh.net/meshes.php?group=44] [tramadol hcl 50 mg|http://thoughtmesh.net/meshes.php?group=45] [tramadol hydrochloride capsules 50mg|http://thoughtmesh.net/meshes.php?group=46] [tramadol 180|http://thoughtmesh.net/meshes.php?group=47] [addiction to tramadol|http://thoughtmesh.net/meshes.php?group=48] [is tramadol a narcotic|http://thoughtmesh.net/meshes.php?group=49] [canine tramadol dosage|http://thoughtmesh.net/meshes.php?group=50] [cheap tramadol fedex overnight|http://thoughtmesh.net/meshes.php?group=51] [tramadol prescription drug|http://thoughtmesh.net/meshes.php?group=52] [side effects of tramadol hydrochloride|http://thoughtmesh.net/meshes.php?group=53] [tramadol sales|http://thoughtmesh.net/meshes.php?group=54] [is tramadol hcl a narcotic|http://thoughtmesh.net/meshes.php?group=55] [tramadol hydrochloride 100mg|http://thoughtmesh.net/meshes.php?group=56] [tramadol sale us no prescription required|http://thoughtmesh.net/meshes.php?group=57] [tramadol medication|http://thoughtmesh.net/meshes.php?group=58] [what is tramadol|http://thoughtmesh.net/meshes.php?group=59] [tramadol 100 mg|http://thoughtmesh.net/meshes.php?group=60] [tramadol no prescription fedex|http://thoughtmesh.net/meshes.php?group=61] [buy cheap tramadol on|http://thoughtmesh.net/meshes.php?group=62] [cheapest tramadol available online|http://thoughtmesh.net/meshes.php?group=63] [order tramadol cod|http://thoughtmesh.net/meshes.php?group=64] [buy tramadol cheap medication inurl|http://thoughtmesh.net/meshes.php?group=65] [overnight tramadol|http://thoughtmesh.net/meshes.php?group=66] [can i take tramadol pain pills if theyre a year old|http://thoughtmesh.net/meshes.php?group=67] [tramadol pharmacy|http://thoughtmesh.net/meshes.php?group=68] [tramadol pill|http://thoughtmesh.net/meshes.php?group=69] [tramadol pills|http://thoughtmesh.net/meshes.php?group=70] [tramadol prescription|http://thoughtmesh.net/meshes.php?group=71] [tramadol hydrochloride|http://thoughtmesh.net/meshes.php?group=72] [best price tramadol|http://thoughtmesh.net/meshes.php?group=73] [tramadol sale us no prescription required|http://thoughtmesh.net/meshes.php?group=74] [tramadol side effects|http://thoughtmesh.net/meshes.php?group=75] [tramadol buy online|http://thoughtmesh.net/meshes.php?group=76] [buy tultram online cheap|http://thoughtmesh.net/meshes.php?group=77] [what are the withdrawal symptoms of tramadol|http://thoughtmesh.net/meshes.php?group=78] [tramadol hcl|http://thoughtmesh.net/meshes.php?group=79] [ingredients in tramadol|http://thoughtmesh.net/meshes.php?group=80] [tramadol drug|http://thoughtmesh.net/meshes.php?group=81] > [chain] CopyCommand does not work unless setValue is called > --- > > Key: CHAIN-6 > URL: https://issues.apache.org/jira/browse/CHAIN-6 > Project: Commons Chain > Issue Type: Bug > Environment: Operating System: All > Platform: All >Reporter: William Slough > Fix For: 1.1 > > Attachments: CopyCommand.patch > > > CopyCommand appears to only work if the setValue method is run. The > documentation says "... a context attribute stored under the fromKey (if any), > to the toKey". If only the fromKey and toKey are set, the toKey and its > stored > value are deleted from the Context regardless of fromKey's value. This should > only happen if the fromKey value is null. > In the execute method of CopyCommand, it appears that > if (value == null) { > context.get(getFromKey()); > } > should read > if (value == null) { > value = context.get(getFromKey()); > } > then the rest of the code should function as expected: > if (value != null) { > context.put(getToKey(), value); > } else { > context.remove(getToKey()); > } > return (false); -- This message is automati
[jira] Commented: (COMPRESS-93) Support for alternative ZIP compression methods
[ https://issues.apache.org/jira/browse/COMPRESS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835726#action_12835726 ] Jukka Zitting commented on COMPRESS-93: --- Brilliant, thanks! > Support for alternative ZIP compression methods > --- > > Key: COMPRESS-93 > URL: https://issues.apache.org/jira/browse/COMPRESS-93 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jukka Zitting > > As reported in TIKA-346, a ZIP file that uses a compression method other than > STORED (0) or DEFLATED (8) will cause an IllegalArgumentException ("invalid > compression method") to be thrown. > It would be great if commons-compress supported alternative compression > methods or at least degraded more gracefully when encountering them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-93) Support for alternative ZIP compression methods
[ https://issues.apache.org/jira/browse/COMPRESS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835724#action_12835724 ] Stefan Bodewig commented on COMPRESS-93: svn revision 911795 > Support for alternative ZIP compression methods > --- > > Key: COMPRESS-93 > URL: https://issues.apache.org/jira/browse/COMPRESS-93 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jukka Zitting > > As reported in TIKA-346, a ZIP file that uses a compression method other than > STORED (0) or DEFLATED (8) will cause an IllegalArgumentException ("invalid > compression method") to be thrown. > It would be great if commons-compress supported alternative compression > methods or at least degraded more gracefully when encountering them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-93) Support for alternative ZIP compression methods
[ https://issues.apache.org/jira/browse/COMPRESS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835720#action_12835720 ] Stefan Bodewig commented on COMPRESS-93: Sounds good, will be done in a minute (or five 8-) > Support for alternative ZIP compression methods > --- > > Key: COMPRESS-93 > URL: https://issues.apache.org/jira/browse/COMPRESS-93 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jukka Zitting > > As reported in TIKA-346, a ZIP file that uses a compression method other than > STORED (0) or DEFLATED (8) will cause an IllegalArgumentException ("invalid > compression method") to be thrown. > It would be great if commons-compress supported alternative compression > methods or at least degraded more gracefully when encountering them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (COMPRESS-89) Better support for encrypted ZIP files
[ https://issues.apache.org/jira/browse/COMPRESS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated COMPRESS-89: -- Attachment: ArchiveInputStream-canRead.patch How about making this more general and moving the canRead method up to the ArchiveInputStream base class? See the attached ArchiveInputStream-canRead.patch for an example. This would allow Tika to avoid casting the ArchiveInputStream instances it uses down to ZipArchiveInputStream, and would potentially enable other archive formats to expose similar information as we now do with zip. > Better support for encrypted ZIP files > -- > > Key: COMPRESS-89 > URL: https://issues.apache.org/jira/browse/COMPRESS-89 > Project: Commons Compress > Issue Type: Improvement >Affects Versions: 1.0, 1.1 >Reporter: Antoni Mylka >Assignee: Stefan Bodewig > Fix For: 1.1 > > Attachments: apache-maven-2.2.1-encrypted-passhello.zip, > ArchiveInputStream-canRead.patch, commons-compress-encrypted.patch > > > Currently when the ZipArchiveInputStream or ZipFile encounters an encrypted > zip it bails out with cryptic exceptions like: 'invalid block type'. I would > like to have two things: > 1. an 'encrypted' flag in the ZipArchiveEntry class. It would be taken from > the first bit of the 'general purpose flag' > 2. more descriptive error messages, both in ZipFile and ZipArchiveInputStream > It might be useful in case someone wants to implement proper support for > encrypted zips, with methods to supply passwords/encryption keys and proper > encryption/decryption algorithms. > For the time being I just need to know if a file is encrypted or not. > I will post a patch with a proposal of a solution in near future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-93) Support for alternative ZIP compression methods
[ https://issues.apache.org/jira/browse/COMPRESS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835708#action_12835708 ] Jukka Zitting commented on COMPRESS-93: --- I'll only update Tika once we have a new release of Commons Compress, so it's OK to adjust the implementation. The canRead() method is also good (I like how it also covers encryption), and I can easily adjust the TIKA-346 patch to use it instead. I guess it would be good to remove the isSupportedCompressionMethod() method now to avoid polluting the public API with multiple methods for pretty much the same purpose. > Support for alternative ZIP compression methods > --- > > Key: COMPRESS-93 > URL: https://issues.apache.org/jira/browse/COMPRESS-93 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jukka Zitting > > As reported in TIKA-346, a ZIP file that uses a compression method other than > STORED (0) or DEFLATED (8) will cause an IllegalArgumentException ("invalid > compression method") to be thrown. > It would be great if commons-compress supported alternative compression > methods or at least degraded more gracefully when encountering them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-93) Support for alternative ZIP compression methods
[ https://issues.apache.org/jira/browse/COMPRESS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835697#action_12835697 ] Stefan Bodewig commented on COMPRESS-93: As a side effect COMPRESS-89 the stream and ZipFile classes now have canRead/Write methods that not only look at the compression algorithm but also reject encrypted entries. WRT "alternative compression methods" - at least BZIP2 should be doable but I don't know how to create an archive that uses it (so I can test an implementation). LZMA compression would be interesting on its own anyway. > Support for alternative ZIP compression methods > --- > > Key: COMPRESS-93 > URL: https://issues.apache.org/jira/browse/COMPRESS-93 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jukka Zitting > > As reported in TIKA-346, a ZIP file that uses a compression method other than > STORED (0) or DEFLATED (8) will cause an IllegalArgumentException ("invalid > compression method") to be thrown. > It would be great if commons-compress supported alternative compression > methods or at least degraded more gracefully when encountering them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (COMPRESS-89) Better support for encrypted ZIP files
[ https://issues.apache.org/jira/browse/COMPRESS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-89. Resolution: Fixed I didn't use your patch directly but similar ideas ins svn revision 911781. Thanks! > Better support for encrypted ZIP files > -- > > Key: COMPRESS-89 > URL: https://issues.apache.org/jira/browse/COMPRESS-89 > Project: Commons Compress > Issue Type: Improvement >Affects Versions: 1.0, 1.1 >Reporter: Antoni Mylka >Assignee: Stefan Bodewig > Fix For: 1.1 > > Attachments: apache-maven-2.2.1-encrypted-passhello.zip, > commons-compress-encrypted.patch > > > Currently when the ZipArchiveInputStream or ZipFile encounters an encrypted > zip it bails out with cryptic exceptions like: 'invalid block type'. I would > like to have two things: > 1. an 'encrypted' flag in the ZipArchiveEntry class. It would be taken from > the first bit of the 'general purpose flag' > 2. more descriptive error messages, both in ZipFile and ZipArchiveInputStream > It might be useful in case someone wants to implement proper support for > encrypted zips, with methods to supply passwords/encryption keys and proper > encryption/decryption algorithms. > For the time being I just need to know if a file is encrypted or not. > I will post a patch with a proposal of a solution in near future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COMPRESS-93) Support for alternative ZIP compression methods
[ https://issues.apache.org/jira/browse/COMPRESS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835632#action_12835632 ] Stefan Bodewig commented on COMPRESS-93: Jukka, I'd rather move the isSupportedCompressionMethod method to the streams and ZipFile since it is really their job to read/write the data. Since I don't know whether you've already made any adjustments in Tika I don't want to go ahead and change it right away. > Support for alternative ZIP compression methods > --- > > Key: COMPRESS-93 > URL: https://issues.apache.org/jira/browse/COMPRESS-93 > Project: Commons Compress > Issue Type: New Feature >Reporter: Jukka Zitting > > As reported in TIKA-346, a ZIP file that uses a compression method other than > STORED (0) or DEFLATED (8) will cause an IllegalArgumentException ("invalid > compression method") to be thrown. > It would be great if commons-compress supported alternative compression > methods or at least degraded more gracefully when encountering them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.