[jira] [Commented] (DBCP-353) When DB Restarts(Bounce) the number ESTABLISHED DB connections exceeds its maximum configured limit.
[ https://issues.apache.org/jira/browse/DBCP-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009555#comment-13009555 ] Radhika Zawar commented on DBCP-353: Hi, Can you please let me know the solution to this issue. Thanks. > When DB Restarts(Bounce) the number ESTABLISHED DB connections exceeds its > maximum configured limit. > > > Key: DBCP-353 > URL: https://issues.apache.org/jira/browse/DBCP-353 > Project: Commons Dbcp > Issue Type: Bug >Reporter: Radhika Zawar > > We have set Max connections configuration to 100. There was heavy load on > application. When we restarted DB in between, number of connections exceeds > from 100 to 200,250... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-376) setListHiddenFiles doesn't work for HFS file system running under zos
[ https://issues.apache.org/jira/browse/NET-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009541#comment-13009541 ] Sebb commented on NET-376: -- MSLD and MLST have now been added. However, testing shows that support is not universal, and even where they are supported, the "facts" (i.e. size, perms etc) vary a lot, and rarely return as much information as a LIST listing. Rather disappointing, but I suppose support will improve. > setListHiddenFiles doesn't work for HFS file system running under zos > - > > Key: NET-376 > URL: https://issues.apache.org/jira/browse/NET-376 > Project: Commons Net > Issue Type: Bug > Components: FTP >Affects Versions: 2.2 > Environment: IBM z/OS running HFS >Reporter: Colin Stone > > The implementation for setListHiddenFiles is essentially the use of a '-a' > parameter appended to the LIST command. This retrieves the data in a > different format to without the parameter and the parse engine used by > initiateListParsing fails to read the lines returned. > I suggest the parameter should have been '-al' for this scenario -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-346) FTP should support reporting NATed external IP address
[
https://issues.apache.org/jira/browse/NET-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009538#comment-13009538
]
Sebb commented on NET-346:
--
What happens if you use
{code}
ftp.setActiveExternalIPAddress("X.X.X.X");
{code}
Does that not work?
> FTP should support reporting NATed external IP address
> --
>
> Key: NET-346
> URL: https://issues.apache.org/jira/browse/NET-346
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
>Affects Versions: 2.2
>Reporter: Kevin Samuel
> Attachments: FTPClient.java
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When trying to do an active FTP transfer as client from behind a firewall
> with NAT, setActiveExternalIPAddress is not sufficient, as you can only
> report the internal IP of the client (e.g. 192.168.1.2 vs 72.14.X.X)
> FTPClient should support an additional function to set the REPORTABLE
> external active IP Address
> I created and successfully tested a fix for this:
> ADD PRIVATE MEMBER:
> private InetAddress __reportActiveExternalHost;
> IN __initDefaults():
> __reportActiveExternalHost = null;
> ADD PUBLIC FUNCTIONS:
> private InetAddress getReportHostAddress()
> {
> if (__reportActiveExternalHost != null)
> {
> return __reportActiveExternalHost ;
> }
> else if (__activeExternalHost != null)
> {
> return __activeExternalHost;
> }
> else
> {
> // default local address
> return getLocalAddress();
> }
> }
> public void setReportActiveExternalIPAddress(String ipAddress) throws
> UnknownHostException
> {
> this.__reportActiveExternalHost = InetAddress.getByName(ipAddress);
> }
> IN _openDataConnection_:
> if (isInet6Address)
> {
> if
> (!FTPReply.isPositiveCompletion(eprt(getReportHostAddress(),
> server.getLocalPort(
> {
> server.close();
> return null;
> }
> }
> else
> {
> if
> (!FTPReply.isPositiveCompletion(port(getReportHostAddress(),
> server.getLocalPort(
> {
> server.close();
> return null;
> }
> }
> will also attach changed file
> sorry I am not familiar with the correct way to submit patches, although I
> tried to model this on #NET-285 as much as possible
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-249) FtpClient hangs 20 minutes in FTPClient.completePendingCommand from retrieveFile or listFiles
[
https://issues.apache.org/jira/browse/NET-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated NET-249:
-
Description:
I have a Ftp Client with several connections in multi-thread that connects to a
remote Ftp Server to list files and download new ones.
After 3 minutes of runtime, I get a 20-minute timeout for all running Ftp
connections.
Here are the logs for 1 thread :
{noformat}
20090114 142216 (Command Sent Message): PASV
20090114 142216 (Reply Received Message): 227 Entering Passive Mode
(10,250,10,116,224,172)
20090114 142216 (Command Sent Message): LIST /Dir1/Dir2/Dir3
20090114 142216 (Reply Received Message): 150 Opening BINARY mode data
connection for /bin/ls.
20090114 142216 (Reply Received Message): 226 Transfer complete.
20090114 142216 (Command Sent Message): PASV
20090114 142216 (Reply Received Message): 227 Entering Passive Mode
(10,250,10,116,138,240)
20090114 142216 (Command Sent Message): RETR /Dir1/Dir2/Dir3/File1
20090114 142216 (Reply Received Message): 150 Opening BINARY mode data
connection for /Dir1/Dir2/Dir3/File1 (12364 bytes).
*** 20 minutes without any message ***
20090114 144216 (Reply Received Message): 426 Data connection: Interrupted
system call.
20090114 144216 (Command Sent Message): PASV
20090114 144216 (Reply Received Message): 227 Entering Passive Mode
(10,250,10,116,109,169)
20090114 144216 (Command Sent Message): RETR /Dir1/Dir2/Dir3/File1
20090114 144216 (Reply Received Message): 150 Opening BINARY mode data
connection for /Dir1/Dir2/Dir3/File2 (12387 bytes).
20090114 144216 (Reply Received Message): 226 Transfer complete.
{noformat}
Here are the logs for another thread :
{noformat}
20090114 142216 (Command Sent Message): PASV
20090114 142216 (Reply Received Message): 227 Entering Passive Mode
(10,250,10,116,174,233)
20090114 142216 (Command Sent Message): RETR /DirA/DirB/DirC/FileA
20090114 142216 (Reply Received Message): 150 Opening BINARY mode data
connection for /DirA/DirB/DirC/FileA (14209 bytes).
20090114 142216 (Reply Received Message): 226 Transfer complete.
20090114 142216 (Command Sent Message): PASV
20090114 142216 (Reply Received Message): 227 Entering Passive Mode
(10,250,10,116,202,81)
20090114 142216 (Command Sent Message): LIST /DirA/DirB/DirD
20090114 142216 (Reply Received Message): 150 Opening BINARY mode data
connection for /bin/ls.
*** 20 minutes without any message ***
20090114 144216 (Reply Received Message): 426 Data connection: Interrupted
system call.
20090114 144216 (Command Sent Message): PASV
20090114 144216 (Reply Received Message): 227 Entering Passive Mode
(10,250,10,116,11,16)
20090114 144216 (Command Sent Message): RETR /DirA/DirB/DirD/FileB
20090114 144216 (Reply Received Message): 150 Opening BINARY mode data
connection for /DirA/DirB/DirD/FileB (14145 bytes).
{noformat}
So it happens during LIST or during RETR command.
The issue is always reproducible when connecting to this Ftp server.
What is the meaning of the error message "426 Data connection: Interrupted
system call." ?
Here are the stack-traces where the FtpClient is blocked during 20 minutes.
For 1st connection :
{noformat}
Stack 30 - Wed Jan 14 14:40:00 CET 2009
"FTPMediationTask" prio=3 tid=0x00aac800 nid=0x156 runnable
[0x6877e000..0x6877fb70]
java.lang.Thread.State: RUNNABLE
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:129)
at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:264)
at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:306)
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:158)
- locked <0x8fc23880> (a java.io.InputStreamReader)
at java.io.InputStreamReader.read(InputStreamReader.java:167)
at java.io.BufferedReader.fill(BufferedReader.java:136)
at java.io.BufferedReader.readLine(BufferedReader.java:299)
- locked <0x8fc23880> (a java.io.InputStreamReader)
at java.io.BufferedReader.readLine(BufferedReader.java:362)
at org.apache.commons.net.ftp.FTP.__getReply(FTP.java:294)
at org.apache.commons.net.ftp.FTP.getReply(FTP.java:619)
at
org.apache.commons.net.ftp.FTPClient.completePendingCommand(FTPClient.java:1244)
at
org.apache.commons.net.ftp.FTPClient.initiateListParsing(FTPClient.java:2309)
at
org.apache.commons.net.ftp.FTPClient.initiateListParsing(FTPClient.java:2269)
at org.apache.commons.net.ftp.FTPClient.listFiles(FTPClient.java:2046)
[...]
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
at java.lang.Thread.run(Thread.java:619)
{noformat}
And for the second connection :
{noformat}
Stack 27 - Wed Jan 14 14:37:00 CET 2009
"FTPMediationTask" prio=3 tid=0x0140b800 nid=0xe7 runnable
[0x6967e000..0x
[jira] [Commented] (POOL-179) GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
[
https://issues.apache.org/jira/browse/POOL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009490#comment-13009490
]
Phil Steitz commented on POOL-179:
--
The current code in the 2.0 branch contains this same bug. I will port the fix
to the 2.0 code for the time being (we have talked about replacing the core
implementation in 2.0).
> GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
> -
>
> Key: POOL-179
> URL: https://issues.apache.org/jira/browse/POOL-179
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 1.5.5
> Environment: mac osx 10.5.8 jdk 1.6.0_22
>Reporter: Axel Großmann
> Fix For: 1.5.6
>
> Attachments: FileDiff154-155.jpg
>
>
> I just updated from commpons-pool 1.5.4 to 1.5.5 and suddenly some of my
> tests crash with threads hanging.
> After some inspection is appears that GenericObjectPool.borrowObject() no
> longer handles InterruptedException correctly. I made a file diff and found
> that there has been a modification in that area that contains the bug. See
> attached image.
> I have created a patched version absed on 1.5.4 source which works correctly
> in my use case. The important part is:
> {code:java}
> catch (final InterruptedException e)
> {
>synchronized (this)
>{
> if (latch.getPair() == null)
> {
> _allocationQueue.remove(latch);
> }
> else
> {
> _numInternalProcessing--;
> _numActive++;
> _allocationQueue.remove(latch);
> returnObject(latch.getPair().value);
> }
>}
>Thread.currentThread().interrupt();
>throw e;
> }
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-333) would you provide a class used for imap protocol?
[ https://issues.apache.org/jira/browse/NET-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009444#comment-13009444 ] Sebb commented on NET-333: -- IMAPReply could probably also be converted to enum. It would be very helpful to have an example of how to use the API (cf POP3Mail and SMTPMail). > would you provide a class used for imap protocol? > - > > Key: NET-333 > URL: https://issues.apache.org/jira/browse/NET-333 > Project: Commons Net > Issue Type: Improvement >Reporter: iceviewer > Attachments: IMAP.zip > > > would you provide a class used for imap protocol? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-333) would you provide a class used for imap protocol?
[ https://issues.apache.org/jira/browse/NET-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009412#comment-13009412 ] Sebb commented on NET-333: -- Had a quick look at the code, looks generally good. Is there any reason why IMAPCommand is not an enum, other than consistency with FTPCommand? Enums would be safer, and it's easy to change now. Also, there seems now to be a lot of common code in the various SocketClient sub-classes, maybe there is scope for re-organising. This would be best held as a discussion on the Commons Developer list - are you subscribed to that? > would you provide a class used for imap protocol? > - > > Key: NET-333 > URL: https://issues.apache.org/jira/browse/NET-333 > Project: Commons Net > Issue Type: Improvement >Reporter: iceviewer > Attachments: IMAP.zip > > > would you provide a class used for imap protocol? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-385) FTP does not apply timeout to initial responses
[ https://issues.apache.org/jira/browse/NET-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-385. -- Resolution: Fixed > FTP does not apply timeout to initial responses > --- > > Key: NET-385 > URL: https://issues.apache.org/jira/browse/NET-385 > Project: Commons Net > Issue Type: Improvement >Reporter: Sebb > > As part of _connectAction()_, the FTP classes read from the control channel. > However, this is done before the connect() returns, and so the caller has no > chance to set a timeout. > Since the reply is effectively part of the connection, it makes sense to use > the connectTimeout (if set) to protect the initial getReply() calls. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (NET-385) FTP does not apply timeout to initial responses
FTP does not apply timeout to initial responses --- Key: NET-385 URL: https://issues.apache.org/jira/browse/NET-385 Project: Commons Net Issue Type: Improvement Reporter: Sebb As part of _connectAction()_, the FTP classes read from the control channel. However, this is done before the connect() returns, and so the caller has no chance to set a timeout. Since the reply is effectively part of the connection, it makes sense to use the connectTimeout (if set) to protect the initial getReply() calls. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-181) Make BaseObjectPool isClosed public
[ https://issues.apache.org/jira/browse/POOL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009371#comment-13009371 ] Simone Tripodi commented on POOL-181: - +1 > Make BaseObjectPool isClosed public > --- > > Key: POOL-181 > URL: https://issues.apache.org/jira/browse/POOL-181 > Project: Commons Pool > Issue Type: Wish >Affects Versions: 1.5.5 >Reporter: Gary D. Gregory > Fix For: 1.5.6, 2.0 > > > Please make BaseObjectPool isClosed public -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-179) GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
[
https://issues.apache.org/jira/browse/POOL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009370#comment-13009370
]
Simone Tripodi commented on POOL-179:
-
no objections from my side. does this issue affects the 2.0 too?
> GenericObjectPool.borrowObject() incorrectly swallos InterruptedException
> -
>
> Key: POOL-179
> URL: https://issues.apache.org/jira/browse/POOL-179
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 1.5.5
> Environment: mac osx 10.5.8 jdk 1.6.0_22
>Reporter: Axel Großmann
> Fix For: 1.5.6
>
> Attachments: FileDiff154-155.jpg
>
>
> I just updated from commpons-pool 1.5.4 to 1.5.5 and suddenly some of my
> tests crash with threads hanging.
> After some inspection is appears that GenericObjectPool.borrowObject() no
> longer handles InterruptedException correctly. I made a file diff and found
> that there has been a modification in that area that contains the bug. See
> attached image.
> I have created a patched version absed on 1.5.4 source which works correctly
> in my use case. The important part is:
> {code:java}
> catch (final InterruptedException e)
> {
>synchronized (this)
>{
> if (latch.getPair() == null)
> {
> _allocationQueue.remove(latch);
> }
> else
> {
> _numInternalProcessing--;
> _numActive++;
> _allocationQueue.remove(latch);
> returnObject(latch.getPair().value);
> }
>}
>Thread.currentThread().interrupt();
>throw e;
> }
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-291) enterLocalPassiveMode is set back to Active on connect
[
https://issues.apache.org/jira/browse/NET-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009346#comment-13009346
]
Sebb commented on NET-291:
--
Out of curiosity, I just tried the following with NET 1.0.0 and with NET 1.4.1:
{code}
FTPClient c = new FTPClient();
System.out.println("mode "+c.getDataConnectionMode());
c.enterLocalPassiveMode();
System.out.println("mode "+c.getDataConnectionMode());
c.connect(...);
System.out.println("mode "+c.getDataConnectionMode());
{code}
Output:
{noformat}
mode 0
mode 2
mode 0
{noformat}
AFAICT, this shows that the behaviour has always been this way (unless one of
the intervening releases was different, but that seems very unlikely)
> enterLocalPassiveMode is set back to Active on connect
> --
>
> Key: NET-291
> URL: https://issues.apache.org/jira/browse/NET-291
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 2.0
>Reporter: Kevin Brown
>
> enterLocalPassiveMode (exhibit A) docs claim that mode will be set to
> PASSIVE_LOCAL_DATA_CONNECTION_MODE "some other method such as"
> enterLocalActiveMode is called (exhibit B). However, active mode is being
> entered after connect is called. This behavior can be easily observed by
> modifying FtpExample by moving ftp.enterLocalPassiveMode() to before
> ftp.connect(server).
> Perhaps either the code or docs could be updated to remedy this. Versions
> prior to 2.0 behaved as documented.
>
> exhibit A:
>/***
> * Set the current data connection mode to
> * PASSIVE_LOCAL_DATA_CONNECTION_MODE . Use this
> * method only for data transfers between the client and server.
> * This method causes a PASV command to be issued to the server
> * before the opening of every data connection, telling the server to
> * open a data port to which the client will connect to conduct
> * data transfers. The FTPClient will stay in
> * PASSIVE_LOCAL_DATA_CONNECTION_MODE until the
> * mode is changed by calling some other method such as
> * {@link #enterLocalActiveMode enterLocalActiveMode() }
> ***/
> public void enterLocalPassiveMode()
> {
> __dataConnectionMode = PASSIVE_LOCAL_DATA_CONNECTION_MODE;
> // These will be set when just before a data connection is opened
> // in _openDataConnection_()
> __passiveHost = null;
> __passivePort = -1;
> }
> exhibit B
> @Override
> protected void _connectAction_() throws IOException
> {
> super._connectAction_();
> __initDefaults();
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-384) KeyManagerUtils - the KeyManager is not efficient
[
https://issues.apache.org/jira/browse/NET-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved NET-384.
--
Resolution: Fixed
> KeyManagerUtils - the KeyManager is not efficient
> -
>
> Key: NET-384
> URL: https://issues.apache.org/jira/browse/NET-384
> Project: Commons Net
> Issue Type: Improvement
>Reporter: Sebb
>
> The clientKey manager performs some of the work that could be done as part of
> creating the key store.
> Since the manager is potentially called many times, it would be better to
> move the setup processing to the creation of the keystore.
> This requires creating a sub-class of KeyStore, which might as well be a
> private class created by createClientKeyManager()
> The calling sequence would then be:
> {code}
> KeyManager km = KeyManagerUtils.createClientKeyManager(
> "JKS", "/path/to/privatekeystore.jks", "storepassword",
> "privatekeyalias", "keypassword");
> FTPSClient cl = new FTPSClient();
> cl.setKeyManager(km);
> {code}
> For JKS stores with a single entry and keypassword == storepassword this
> would simplify to:
> {code}
> KeyManager km =
> KeyManagerUtils.createClientKeyManager("/path/to/privatekeystore.jks",
> "storepassword");
> FTPSClient cl = new FTPSClient();
> cl.setKeyManager(km);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-326) A KeyManager is required when the protection level is set to 'P' with FTPSClient on active mode
[
https://issues.apache.org/jira/browse/NET-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009199#comment-13009199
]
Sebb commented on NET-326:
--
It does look as if getClientAliases() and chooseClientAlias() can return a
dummy value (at least with the Sun JVM when tested against Apache FTPServer)
but obviously a matching key and certificate chain need to be provided by the
KeyManager.
For some servers, a specific key may be needed, so I think the alis could prove
useful.
> A KeyManager is required when the protection level is set to 'P' with
> FTPSClient on active mode
> ---
>
> Key: NET-326
> URL: https://issues.apache.org/jira/browse/NET-326
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 2.0
> Environment: Windows XP profesional service pack 2, Java Java
> 1.6.0_12-b04
>Reporter: Terence Dudouit
> Attachments: SSLContextsFactory.java
>
>
> Using a simple FTPS client that list a directory, when execPROT("P") is set
> and the active mode is on, the following exception is thrown :
> javax.net.ssl.SSLException: No available certificate or key corresponds to
> the SSL cipher suites which are enabled.
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.checkEnabledSuites(SSLServerSocketImpl.java:303)
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.accept(SSLServerSocketImpl.java:253)
> at
> org.apache.commons.net.ftp.FTPClient._openDataConnection_(FTPClient.java:489)
> at
> org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:494)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1950)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1996)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.testFTPS(FTPGet.java:379)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.main(FTPGet.java:401)
> This doesn't occur on passive mode.
> The only way to make it work is to set a keyManager although there is no need
> for a client authentication.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-326) A KeyManager is required when the protection level is set to 'P' with FTPSClient on active mode
[
https://issues.apache.org/jira/browse/NET-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009160#comment-13009160
]
Bogdan Drozdowski commented on NET-326:
---
Yes, that's precisely what I meant. Thank you!
About the multiple keys: I assumed that only a keystore is required and the
certificate is chosen basing on things like the Common Name field. I could be
wrong, of course.
> A KeyManager is required when the protection level is set to 'P' with
> FTPSClient on active mode
> ---
>
> Key: NET-326
> URL: https://issues.apache.org/jira/browse/NET-326
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 2.0
> Environment: Windows XP profesional service pack 2, Java Java
> 1.6.0_12-b04
>Reporter: Terence Dudouit
> Attachments: SSLContextsFactory.java
>
>
> Using a simple FTPS client that list a directory, when execPROT("P") is set
> and the active mode is on, the following exception is thrown :
> javax.net.ssl.SSLException: No available certificate or key corresponds to
> the SSL cipher suites which are enabled.
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.checkEnabledSuites(SSLServerSocketImpl.java:303)
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.accept(SSLServerSocketImpl.java:253)
> at
> org.apache.commons.net.ftp.FTPClient._openDataConnection_(FTPClient.java:489)
> at
> org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:494)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1950)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1996)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.testFTPS(FTPGet.java:379)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.main(FTPGet.java:401)
> This doesn't occur on passive mode.
> The only way to make it work is to set a keyManager although there is no need
> for a client authentication.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-333) would you provide a class used for imap protocol?
[ https://issues.apache.org/jira/browse/NET-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bogdan Drozdowski updated NET-333: -- Attachment: IMAP.zip Basic functionalicty included: connecting, authentication, SSL/TLS. All commands supported, no reply parsing (except for the return code - OK, ERROR, ...), some enums for easier use. The Authenticating client constructors delegate to IMAPS constructors, this may be unneeded. When entering secure mode, not only the socket and the corresponding input/output streams are replaced, but also the bufferred reader+writer. This wasn't done in SMTPSClient and POP3SClient (and they seemd to work), but was done in FTPSClient and IMAPSClient doesn't seem to work without this. Which way is correct (I'd guess that FTP)? > would you provide a class used for imap protocol? > - > > Key: NET-333 > URL: https://issues.apache.org/jira/browse/NET-333 > Project: Commons Net > Issue Type: Improvement >Reporter: iceviewer > Attachments: IMAP.zip > > > would you provide a class used for imap protocol? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (NET-384) KeyManagerUtils - the KeyManager is not efficient
KeyManagerUtils - the KeyManager is not efficient
-
Key: NET-384
URL: https://issues.apache.org/jira/browse/NET-384
Project: Commons Net
Issue Type: Improvement
Reporter: Sebb
The clientKey manager performs some of the work that could be done as part of
creating the key store.
Since the manager is potentially called many times, it would be better to move
the setup processing to the creation of the keystore.
This requires creating a sub-class of KeyStore, which might as well be a
private class created by createClientKeyManager()
The calling sequence would then be:
{code}
KeyManager km = KeyManagerUtils.createClientKeyManager(
"JKS", "/path/to/privatekeystore.jks", "storepassword", "privatekeyalias",
"keypassword");
FTPSClient cl = new FTPSClient();
cl.setKeyManager(km);
{code}
For JKS stores with a single entry and keypassword == storepassword this would
simplify to:
{code}
KeyManager km =
KeyManagerUtils.createClientKeyManager("/path/to/privatekeystore.jks",
"storepassword");
FTPSClient cl = new FTPSClient();
cl.setKeyManager(km);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-383) KeyManagerUtils - allow alias to be omitted when there is only one private key in the store
[ https://issues.apache.org/jira/browse/NET-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-383. -- Resolution: Fixed > KeyManagerUtils - allow alias to be omitted when there is only one private > key in the store > --- > > Key: NET-383 > URL: https://issues.apache.org/jira/browse/NET-383 > Project: Commons Net > Issue Type: Improvement >Reporter: Sebb > > If the keystore only contains a single private key, then it would be > convenient to be able to omit the alias (or provide null). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (NET-383) KeyManagerUtils - allow alias to be omitted when there is only one key.
KeyManagerUtils - allow alias to be omitted when there is only one key. --- Key: NET-383 URL: https://issues.apache.org/jira/browse/NET-383 Project: Commons Net Issue Type: Improvement Reporter: Sebb If the keystore only contains a single private key, then it would be convenient to be able to omit the alias (or provide null). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-383) KeyManagerUtils - allow alias to be omitted when there is only one private key in the store
[ https://issues.apache.org/jira/browse/NET-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated NET-383: - Summary: KeyManagerUtils - allow alias to be omitted when there is only one private key in the store (was: KeyManagerUtils - allow alias to be omitted when there is only one key.) > KeyManagerUtils - allow alias to be omitted when there is only one private > key in the store > --- > > Key: NET-383 > URL: https://issues.apache.org/jira/browse/NET-383 > Project: Commons Net > Issue Type: Improvement >Reporter: Sebb > > If the keystore only contains a single private key, then it would be > convenient to be able to omit the alias (or provide null). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-326) A KeyManager is required when the protection level is set to 'P' with FTPSClient on active mode
[
https://issues.apache.org/jira/browse/NET-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009121#comment-13009121
]
Sebb commented on NET-326:
--
I added the alias in case the keystore contained multiple keys.
Having said that, perhaps it would be nice if the code allowed the alias to be
omitted if there is only a single entry in the jar. I'll create a JIRA for that.
I assume you mean the comment: "is not available in the environment.".
Yes, I can remove that.
> A KeyManager is required when the protection level is set to 'P' with
> FTPSClient on active mode
> ---
>
> Key: NET-326
> URL: https://issues.apache.org/jira/browse/NET-326
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 2.0
> Environment: Windows XP profesional service pack 2, Java Java
> 1.6.0_12-b04
>Reporter: Terence Dudouit
> Attachments: SSLContextsFactory.java
>
>
> Using a simple FTPS client that list a directory, when execPROT("P") is set
> and the active mode is on, the following exception is thrown :
> javax.net.ssl.SSLException: No available certificate or key corresponds to
> the SSL cipher suites which are enabled.
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.checkEnabledSuites(SSLServerSocketImpl.java:303)
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.accept(SSLServerSocketImpl.java:253)
> at
> org.apache.commons.net.ftp.FTPClient._openDataConnection_(FTPClient.java:489)
> at
> org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:494)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1950)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1996)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.testFTPS(FTPGet.java:379)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.main(FTPGet.java:401)
> This doesn't occur on passive mode.
> The only way to make it work is to set a keyManager although there is no need
> for a client authentication.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-326) A KeyManager is required when the protection level is set to 'P' with FTPSClient on active mode
[
https://issues.apache.org/jira/browse/NET-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009119#comment-13009119
]
Bogdan Drozdowski commented on NET-326:
---
Good job. A simple class with a simple API. Different from mine, because it
requires an alias of the certificate to be provided (mine didn't require), but
simpler, which is good.
One more thing I've noticed recently: the "S" clients' (SMTPS, POP3S, FTPS)
constructors have an unnecessary line in their javadoc, a leftover after
removing the exception description. Could you fix that?
> A KeyManager is required when the protection level is set to 'P' with
> FTPSClient on active mode
> ---
>
> Key: NET-326
> URL: https://issues.apache.org/jira/browse/NET-326
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 2.0
> Environment: Windows XP profesional service pack 2, Java Java
> 1.6.0_12-b04
>Reporter: Terence Dudouit
> Attachments: SSLContextsFactory.java
>
>
> Using a simple FTPS client that list a directory, when execPROT("P") is set
> and the active mode is on, the following exception is thrown :
> javax.net.ssl.SSLException: No available certificate or key corresponds to
> the SSL cipher suites which are enabled.
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.checkEnabledSuites(SSLServerSocketImpl.java:303)
> at
> com.sun.net.ssl.internal.ssl.SSLServerSocketImpl.accept(SSLServerSocketImpl.java:253)
> at
> org.apache.commons.net.ftp.FTPClient._openDataConnection_(FTPClient.java:489)
> at
> org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:494)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1950)
> at org.apache.commons.net.ftp.FTPClient.listNames(FTPClient.java:1996)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.testFTPS(FTPGet.java:379)
> at
> fr.enovacom.eai.actions.dynamiques.protocole.ftp.FTPGet.main(FTPGet.java:401)
> This doesn't occur on passive mode.
> The only way to make it work is to set a keyManager although there is no need
> for a client authentication.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-437) Kolmogorov Smirnov Distribution
[
https://issues.apache.org/jira/browse/MATH-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikkel Meyer Andersen resolved MATH-437.
Resolution: Fixed
Fixed in revision 1083716. Impl-class now mentions {@link
KolmogorovSmirnovDistribution}, if that was what you meant, Phil? Power
functionality from MATH-435 now used and the private methods removed. Note that
- as before - the tests are made using
src/test/R/KolmogorovSmirnovDistributionTestCases.R.
> Kolmogorov Smirnov Distribution
> ---
>
> Key: MATH-437
> URL: https://issues.apache.org/jira/browse/MATH-437
> Project: Commons Math
> Issue Type: New Feature
>Reporter: Mikkel Meyer Andersen
>Assignee: Mikkel Meyer Andersen
>Priority: Minor
> Fix For: 3.0
>
> Attachments: MATH437-with-test-take-1
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Kolmogorov-Smirnov test (see [1]) is used to test if one sample against a
> known probability density functions or if two samples are from the same
> distribution. To evaluate the test statistic, the Kolmogorov-Smirnov
> distribution is used. Quite good asymptotics exist for the one-sided test,
> but it's more difficult for the two-sided test.
> [1]: http://en.wikipedia.org/wiki/Kolmogorov%E2%80%93Smirnov_test
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-435) Efficient matrix power
[ https://issues.apache.org/jira/browse/MATH-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikkel Meyer Andersen resolved MATH-435. Resolution: Fixed Fixed for FieldMatrix in revision 1083713. > Efficient matrix power > -- > > Key: MATH-435 > URL: https://issues.apache.org/jira/browse/MATH-435 > Project: Commons Math > Issue Type: Improvement >Reporter: Mikkel Meyer Andersen >Assignee: Mikkel Meyer Andersen > Fix For: 3.0 > > Attachments: MATH435-patch1 > > Original Estimate: 4m > Remaining Estimate: 4m > > For symmetric matrices A it is easy to find A^n also for large n by making an > eigenvalue/-vector decomposition. > In general, if the structure of the matrix is not know and the n'th power is > needed, A*A*...*A is way too inefficient. By using a binary representation > and powers of 2, powers can be found far faster similar to finding 5^14 as > 5^14 = 5^8 * 5^4 = ((5^2)^2)^2 * (5^2)^2 = x3 * x2 where x1 = 5^2, x2 = x1^2, > and x3 = x2^2, thus saving a lot of computations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-435) Efficient matrix power
[ https://issues.apache.org/jira/browse/MATH-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009058#comment-13009058 ] Mikkel Meyer Andersen commented on MATH-435: Two post-fixes: 1083704 for removing @Override for consistency and 1083706 for missing @Test annotation on test case. > Efficient matrix power > -- > > Key: MATH-435 > URL: https://issues.apache.org/jira/browse/MATH-435 > Project: Commons Math > Issue Type: Improvement >Reporter: Mikkel Meyer Andersen >Assignee: Mikkel Meyer Andersen > Fix For: 3.0 > > Attachments: MATH435-patch1 > > Original Estimate: 4m > Remaining Estimate: 4m > > For symmetric matrices A it is easy to find A^n also for large n by making an > eigenvalue/-vector decomposition. > In general, if the structure of the matrix is not know and the n'th power is > needed, A*A*...*A is way too inefficient. By using a binary representation > and powers of 2, powers can be found far faster similar to finding 5^14 as > 5^14 = 5^8 * 5^4 = ((5^2)^2)^2 * (5^2)^2 = x3 * x2 where x1 = 5^2, x2 = x1^2, > and x3 = x2^2, thus saving a lot of computations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MATH-435) Efficient matrix power
[ https://issues.apache.org/jira/browse/MATH-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikkel Meyer Andersen reopened MATH-435: FieldMatrix also has to have the (duplicate) power functionality. > Efficient matrix power > -- > > Key: MATH-435 > URL: https://issues.apache.org/jira/browse/MATH-435 > Project: Commons Math > Issue Type: Improvement >Reporter: Mikkel Meyer Andersen >Assignee: Mikkel Meyer Andersen > Fix For: 3.0 > > Attachments: MATH435-patch1 > > Original Estimate: 4m > Remaining Estimate: 4m > > For symmetric matrices A it is easy to find A^n also for large n by making an > eigenvalue/-vector decomposition. > In general, if the structure of the matrix is not know and the n'th power is > needed, A*A*...*A is way too inefficient. By using a binary representation > and powers of 2, powers can be found far faster similar to finding 5^14 as > 5^14 = 5^8 * 5^4 = ((5^2)^2)^2 * (5^2)^2 = x3 * x2 where x1 = 5^2, x2 = x1^2, > and x3 = x2^2, thus saving a lot of computations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-435) Efficient matrix power
[ https://issues.apache.org/jira/browse/MATH-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikkel Meyer Andersen resolved MATH-435. Resolution: Fixed Fixed in revision 1083698. > Efficient matrix power > -- > > Key: MATH-435 > URL: https://issues.apache.org/jira/browse/MATH-435 > Project: Commons Math > Issue Type: Improvement >Reporter: Mikkel Meyer Andersen >Assignee: Mikkel Meyer Andersen > Fix For: 3.0 > > Attachments: MATH435-patch1 > > Original Estimate: 4m > Remaining Estimate: 4m > > For symmetric matrices A it is easy to find A^n also for large n by making an > eigenvalue/-vector decomposition. > In general, if the structure of the matrix is not know and the n'th power is > needed, A*A*...*A is way too inefficient. By using a binary representation > and powers of 2, powers can be found far faster similar to finding 5^14 as > 5^14 = 5^8 * 5^4 = ((5^2)^2)^2 * (5^2)^2 = x3 * x2 where x1 = 5^2, x2 = x1^2, > and x3 = x2^2, thus saving a lot of computations. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
