[jira] [Commented] (JXPATH-152) Concurrent access on hashmap of JXPathIntrospector
[ https://issues.apache.org/jira/browse/JXPATH-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257293#comment-13257293 ] Naozumi Taromaru commented on JXPATH-152: - correction method 3: (JDK1.3 compatible. but contrary to usage.) Sorry, it has problem. ArrayIndexOutOfBoundsException may occur. The problem did not occur in the case of Sun(Oracle) JDK5. result of get method: * return null * return value object But, the problem occured in the case of Sun(Oracle) JDK6. result of get method: * return null * return value object * throw ArrayIndexOutOfBoundsException Concurrent access on hashmap of JXPathIntrospector -- Key: JXPATH-152 URL: https://issues.apache.org/jira/browse/JXPATH-152 Project: Commons JXPath Issue Type: Bug Affects Versions: 1.3 Environment: Java5, Windows/AIX Reporter: pleutre Assignee: Matt Benson Priority: Minor Fix For: 1.4 Original Estimate: 24h Remaining Estimate: 24h JXPathIntrospector.registerDynamicClass method can be called in static part of classes. If two classes A B try to registerDynamicClass in the same time a concurrent access exception can append on hashmap of JXPathIntrospector. Replace hashmap by concurrent hashmap or synchronized access to these hashmaps. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (NET-459) FTPClient.storeFile never returns in active mode if data channel cannot be established
FTPClient.storeFile never returns in active mode if data channel cannot be established -- Key: NET-459 URL: https://issues.apache.org/jira/browse/NET-459 Project: Commons Net Issue Type: Bug Components: FTP Affects Versions: 3.1, 3.0.1 Reporter: Jaroslav Chmurny FTPClient.storeFile(String, InputStream) method is used to upload a file to the FTP server. Before the upload, active mode is chosen via the FTPClient.enterLocalActiveMode() method. However, the FTP server is not able to establish the data channel to the FTP client (for instance because of firewall). The storeFile method blocks and never returns. When I capture the network traffic with Wireshark, I see that there are two responses to the STOR command: the first one indicates that the data channel is going to be established, the second one indicates that the FTP server cannot establish the data channel. However, the storeFile method remains blocked forever, even if I play around with the various timeouts (setSoTimeout, setDefaultTimeout, setControlKeepAliveTimeout, setControlKeepAliveReplyTimeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CHAIN-68) SNAPSHOT tomcat plugin breaks the build
SNAPSHOT tomcat plugin breaks the build
---
Key: CHAIN-68
URL: https://issues.apache.org/jira/browse/CHAIN-68
Project: Commons Chain
Issue Type: Bug
Affects Versions: 2.0
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Priority: Critical
the {{apps/cookbook-examples/pom.xml}} contains the {{tomcat7-maven-plugin}}
configured to version {{2.0-SNAPSHOT}} breaks the build on Continuum - see dev@
ML.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CHAIN-68) SNAPSHOT tomcat plugin breaks the build
[
https://issues.apache.org/jira/browse/CHAIN-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated CHAIN-68:
Attachment: tomcat_runnder.diff
I contacted privately Elijah and he kindly addressed the issue, sending me the
attached patch
SNAPSHOT tomcat plugin breaks the build
---
Key: CHAIN-68
URL: https://issues.apache.org/jira/browse/CHAIN-68
Project: Commons Chain
Issue Type: Bug
Affects Versions: 2.0
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Priority: Critical
Attachments: tomcat_runnder.diff
the {{apps/cookbook-examples/pom.xml}} contains the {{tomcat7-maven-plugin}}
configured to version {{2.0-SNAPSHOT}} breaks the build on Continuum - see
dev@ ML.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CHAIN-68) SNAPSHOT tomcat plugin breaks the build
[
https://issues.apache.org/jira/browse/CHAIN-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved CHAIN-68.
-
Resolution: Fixed
Fix Version/s: 2.0
fixed at [r1328084|http://svn.apache.org/viewvc?rev=1328084view=rev]
SNAPSHOT tomcat plugin breaks the build
---
Key: CHAIN-68
URL: https://issues.apache.org/jira/browse/CHAIN-68
Project: Commons Chain
Issue Type: Bug
Affects Versions: 2.0
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Priority: Critical
Fix For: 2.0
Attachments: tomcat_runnder.diff
the {{apps/cookbook-examples/pom.xml}} contains the {{tomcat7-maven-plugin}}
configured to version {{2.0-SNAPSHOT}} breaks the build on Continuum - see
dev@ ML.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-410) If using getInputStream(long position) on SftpFileObject the file is read into memory
[
https://issues.apache.org/jira/browse/VFS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257812#comment-13257812
]
Martin Stockhammer commented on VFS-410:
Here is a patch that uses the new method. I added a version check for JSch to
be sure the method is allowed.
{code}
Index: src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
===
--- src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
(revision 1327822)
+++ src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
(working copy)
@@ -42,6 +42,7 @@
import com.jcraft.jsch.ChannelSftp;
import com.jcraft.jsch.ChannelSftp.LsEntry;
+import com.jcraft.jsch.JSch;
import com.jcraft.jsch.SftpATTRS;
import com.jcraft.jsch.SftpException;
@@ -53,7 +54,25 @@
public class SftpFileObject extends AbstractFileObject
{
private static final long MOD_TIME_FACTOR = 1000L;
+public static boolean useInputStream = false;
+// Checking for JSch version. Versions = 0.1.46 use the InputStream from
+// the SftpChannel.
+static {
+try {
+String[] versions = JSch.class.getDeclaredField(VERSION)
+.get(null).toString().split(\\.);
+if (versions.length == 3) {
+int[] vers = { Integer.parseInt(versions[0]),
+Integer.parseInt(versions[1]),
+Integer.parseInt(versions[2]) };
+useInputStream = vers[0] 0 || vers[1] 1
+|| (vers[1] == 1 vers[2] = 46);
+}
+} catch (Exception e) {
+System.err.println(Retrieval of JSch version failed);
+}
+}
private final SftpFileSystem fileSystem;
private SftpATTRS attrs;
private final String relPath;
@@ -447,32 +466,39 @@
/**
* Creates an input stream to read the file content from.
+ * The input stream is starting at the given position in the file.
*/
InputStream getInputStream(long filePointer) throws IOException
{
final ChannelSftp channel = fileSystem.getChannel();
-try
-{
-// hmmm - using the in memory method is s much faster ...
-// TODO - Don't read the entire file into memory. Use the
-// stream-based methods on ChannelSftp once they work properly
final
-// no stream based method with resume???
-ByteArrayOutputStream outstr = new ByteArrayOutputStream();
-try
-{
-channel.get(getName().getPathDecoded(), outstr, null,
-ChannelSftp.RESUME, filePointer);
-}
-catch (SftpException e)
-{
+if (useInputStream) {
+// Using InputStream directly from the channel.
+// Its much faster than the memory method.
+try {
+InputStream is = channel.get(getName().getPathDecoded(), null,
+filePointer);
+return new SftpInputStream(channel, is);
+} catch (SftpException e) {
+fileSystem.putChannel(channel);
throw new FileSystemException(e);
+}
+
+} else {
+try {
+// Reading completely into the memory.
+ByteArrayOutputStream outstr = new ByteArrayOutputStream();
+try {
+channel.get(getName().getPathDecoded(), outstr, null,
+ChannelSftp.RESUME, filePointer);
+} catch (SftpException e) {
+throw new FileSystemException(e);
+}
+outstr.close();
+return new ByteArrayInputStream(outstr.toByteArray());
+
+} finally {
+fileSystem.putChannel(channel);
}
-outstr.close();
-return new ByteArrayInputStream(outstr.toByteArray());
-}
-finally
-{
-fileSystem.putChannel(channel);
}
}
{code}
If using getInputStream(long position) on SftpFileObject the file is read
into memory
-
Key: VFS-410
URL: https://issues.apache.org/jira/browse/VFS-410
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Reporter: Martin Stockhammer
Fix For: 2.1
The method {{getInputStream(long filePointer)}} in {{SftpFileObject.java}}
reads the complete file into memory to create the input stream.
Newer versions of JSch provide a method
{{channel.get(file, monitor, filePointer);}}
that is much faster.
--
This message is automatically generated by JIRA.
If you think it
[jira] [Commented] (VFS-395) VFS2 should declare maven-scm-* dependencies as optional in pom
[ https://issues.apache.org/jira/browse/VFS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257940#comment-13257940 ] Karsten Sperling commented on VFS-395: -- If additional wagon / SCM provider dependencies are necessary, they can be defined on the plugin element for the release plugin. Having them as project dependencies is extremely broken. VFS2 should declare maven-scm-* dependencies as optional in pom --- Key: VFS-395 URL: https://issues.apache.org/jira/browse/VFS-395 Project: Commons VFS Issue Type: Bug Affects Versions: 2.0 Reporter: Xavier Dury VFS2 includes weird dependencies: maven-scm-api, maven-scm-provider-svnexe. See http://commons.apache.org/vfs/commons-vfs2/dependencies.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VFS-410) If using getInputStream(long position) on SftpFileObject the file is read into memory
[
https://issues.apache.org/jira/browse/VFS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257970#comment-13257970
]
Gary D. Gregory commented on VFS-410:
-
Hi Martin,
In order to use a patch, it must be attached to this issue as a patch file and
granted the Apache license.
I would not bother with the version check, the POM already specifies 0.1.46 and
I am testing a build with 0.1.47 as we speak...
Thank you,
Gary
If using getInputStream(long position) on SftpFileObject the file is read
into memory
-
Key: VFS-410
URL: https://issues.apache.org/jira/browse/VFS-410
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Reporter: Martin Stockhammer
Fix For: 2.1
The method {{getInputStream(long filePointer)}} in {{SftpFileObject.java}}
reads the complete file into memory to create the input stream.
Newer versions of JSch provide a method
{{channel.get(file, monitor, filePointer);}}
that is much faster.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (VFS-411) [SFTP] Update Jsch to version 0.1.47
[SFTP] Update Jsch to version 0.1.47 Key: VFS-411 URL: https://issues.apache.org/jira/browse/VFS-411 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.1 [SFTP] Update Jsch to version 0.1.47 from 0.1.46. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-411) [SFTP] Update Jsch to version 0.1.47 from 0.1.46.
[ https://issues.apache.org/jira/browse/VFS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated VFS-411: Summary: [SFTP] Update Jsch to version 0.1.47 from 0.1.46. (was: [SFTP] Update Jsch to version 0.1.47) [SFTP] Update Jsch to version 0.1.47 from 0.1.46. - Key: VFS-411 URL: https://issues.apache.org/jira/browse/VFS-411 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.1 [SFTP] Update Jsch to version 0.1.47 from 0.1.46. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANSELAN-73) JpegImageMetada fails if exif is null
[ https://issues.apache.org/jira/browse/SANSELAN-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Kapoor updated SANSELAN-73: -- Priority: Minor (was: Major) JpegImageMetada fails if exif is null -- Key: SANSELAN-73 URL: https://issues.apache.org/jira/browse/SANSELAN-73 Project: Commons Sanselan Issue Type: Bug Reporter: Piyush Kapoor Priority: Minor Original Estimate: 1m Remaining Estimate: 1m if exif field is null in jpegimagemetadata.java fails with Np . Added the null check. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SANSELAN-73) JpegImageMetada fails if exif is null
JpegImageMetada fails if exif is null -- Key: SANSELAN-73 URL: https://issues.apache.org/jira/browse/SANSELAN-73 Project: Commons Sanselan Issue Type: Bug Reporter: Piyush Kapoor if exif field is null in jpegimagemetadata.java fails with Np . Added the null check. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SANSELAN-74) Tiffreader fails if rows per strip and imageheight both are absent
[ https://issues.apache.org/jira/browse/SANSELAN-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piyush Kapoor updated SANSELAN-74: -- Description: If rowsperstrip is not present in Tiff files , we take imageHeight value as rows per strip value. Currently if imageheight is not present then Np occurs , Added some checks to safely run the process . was: If rowsperstrip is not present in Tiff files , we take imageHeigth value as rows per strip value. Currently is imageheight is not present then Np occurs , Added some checks to safely run the process . Summary: Tiffreader fails if rows per strip and imageheight both are absent (was: Tiffreader fails if rows per strip and imageheight bothe are absent ) Tiffreader fails if rows per strip and imageheight both are absent --- Key: SANSELAN-74 URL: https://issues.apache.org/jira/browse/SANSELAN-74 Project: Commons Sanselan Issue Type: Bug Reporter: Piyush Kapoor Priority: Minor If rowsperstrip is not present in Tiff files , we take imageHeight value as rows per strip value. Currently if imageheight is not present then Np occurs , Added some checks to safely run the process . -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SANSELAN-74) Tiffreader fails if rows per strip and imageheight bothe are absent
Tiffreader fails if rows per strip and imageheight bothe are absent Key: SANSELAN-74 URL: https://issues.apache.org/jira/browse/SANSELAN-74 Project: Commons Sanselan Issue Type: Bug Reporter: Piyush Kapoor Priority: Minor If rowsperstrip is not present in Tiff files , we take imageHeigth value as rows per strip value. Currently is imageheight is not present then Np occurs , Added some checks to safely run the process . -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
