[jira] [Issue Comment Edited] (JEXL-126) Decimal numbers literals should be 'double' by default (instead of 'float')
[ https://issues.apache.org/jira/browse/JEXL-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266052#comment-13266052 ] Henri Biestro edited comment on JEXL-126 at 5/1/12 8:37 PM: Fixed in 2.1.2 through commit Revision: 1332806 jexl2/pom.xml jexl2/src/main/java/org/apache/commons/jexl2/Interpreter.java jexl2/src/main/java/org/apache/commons/jexl2/JexlArithmetic.java jexl2/src/main/java/org/apache/commons/jexl2/JexlEngine.java jexl2/src/main/java/org/apache/commons/jexl2/JexlException.java jexl2/src/main/java/org/apache/commons/jexl2/ObjectContext.java jexl2/src/main/java/org/apache/commons/jexl2/UnifiedJEXL.java >> jexl2/src/main/java/org/apache/commons/jexl2/parser/ASTNumberLiteral.java >> jexl2/src/test/java/org/apache/commons/jexl2/ArithmeticTest.java jexl2/src/test/java/org/apache/commons/jexl2/ArrayLiteralTest.java jexl2/src/test/java/org/apache/commons/jexl2/ExceptionTest.java jexl2/src/test/java/org/apache/commons/jexl2/IssuesTest.java Revision: 1332806 Grace, you can generate your diff between jexl2/src/main/java/org/apache/commons/jexl2/parser/ASTNumberLiteral.java in your version and the trunk. was (Author: henrib): Fixed in 2.1.2 through commit Revision: 1332806 jexl2/pom.xml jexl2/src/main/java/org/apache/commons/jexl2/Interpreter.java jexl2/src/main/java/org/apache/commons/jexl2/JexlArithmetic.java jexl2/src/main/java/org/apache/commons/jexl2/JexlEngine.java jexl2/src/main/java/org/apache/commons/jexl2/JexlException.java jexl2/src/main/java/org/apache/commons/jexl2/ObjectContext.java jexl2/src/main/java/org/apache/commons/jexl2/UnifiedJEXL.java >> jexl2/src/main/java/org/apache/commons/jexl2/parser/ASTNumberLiteral.java >> jexl2/src/test/java/org/apache/commons/jexl2/ArithmeticTest.java jexl2/src/test/java/org/apache/commons/jexl2/ArrayLiteralTest.java jexl2/src/test/java/org/apache/commons/jexl2/ExceptionTest.java jexl2/src/test/java/org/apache/commons/jexl2/IssuesTest.java Revision: 1332806 > Decimal numbers literals should be 'double' by default (instead of 'float') > --- > > Key: JEXL-126 > URL: https://issues.apache.org/jira/browse/JEXL-126 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Henri Biestro >Assignee: Henri Biestro >Priority: Minor > Fix For: 2.1.2, 3.0 > > > Since Jexl 1.x, decimal number literals are 'float'; it would be more natural > (pun unintended) to create 'double' instead since they are used more often > (reduce 'surprise' effects). > Note that since 2.1, numbers literals notations allow typing; '123f' is a > float literal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JEXL-126) Decimal numbers literals should be 'double' by default (instead of 'float')
[ https://issues.apache.org/jira/browse/JEXL-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-126: --- Fix Version/s: 2.1.2 Fixed in 2.1.2 through commit Revision: 1332806 jexl2/pom.xml jexl2/src/main/java/org/apache/commons/jexl2/Interpreter.java jexl2/src/main/java/org/apache/commons/jexl2/JexlArithmetic.java jexl2/src/main/java/org/apache/commons/jexl2/JexlEngine.java jexl2/src/main/java/org/apache/commons/jexl2/JexlException.java jexl2/src/main/java/org/apache/commons/jexl2/ObjectContext.java jexl2/src/main/java/org/apache/commons/jexl2/UnifiedJEXL.java >> jexl2/src/main/java/org/apache/commons/jexl2/parser/ASTNumberLiteral.java >> jexl2/src/test/java/org/apache/commons/jexl2/ArithmeticTest.java jexl2/src/test/java/org/apache/commons/jexl2/ArrayLiteralTest.java jexl2/src/test/java/org/apache/commons/jexl2/ExceptionTest.java jexl2/src/test/java/org/apache/commons/jexl2/IssuesTest.java Revision: 1332806 > Decimal numbers literals should be 'double' by default (instead of 'float') > --- > > Key: JEXL-126 > URL: https://issues.apache.org/jira/browse/JEXL-126 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Henri Biestro >Assignee: Henri Biestro >Priority: Minor > Fix For: 2.1.2, 3.0 > > > Since Jexl 1.x, decimal number literals are 'float'; it would be more natural > (pun unintended) to create 'double' instead since they are used more often > (reduce 'surprise' effects). > Note that since 2.1, numbers literals notations allow typing; '123f' is a > float literal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JEXL-131) UnifiedJexl (2.1.x) / Jxlt (3.0) parsing may fail with NPE
[ https://issues.apache.org/jira/browse/JEXL-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-131. Resolution: Fixed Fixed in part of commit revision 1332806: jexl2/pom.xml jexl2/src/main/java/org/apache/commons/jexl2/Interpreter.java jexl2/src/main/java/org/apache/commons/jexl2/JexlArithmetic.java jexl2/src/main/java/org/apache/commons/jexl2/JexlEngine.java jexl2/src/main/java/org/apache/commons/jexl2/JexlException.java jexl2/src/main/java/org/apache/commons/jexl2/ObjectContext.java >> jexl2/src/main/java/org/apache/commons/jexl2/UnifiedJEXL.java >> jexl2/src/main/java/org/apache/commons/jexl2/parser/ASTNumberLiteral.java jexl2/src/test/java/org/apache/commons/jexl2/ArithmeticTest.java jexl2/src/test/java/org/apache/commons/jexl2/ArrayLiteralTest.java jexl2/src/test/java/org/apache/commons/jexl2/ExceptionTest.java jexl2/src/test/java/org/apache/commons/jexl2/IssuesTest.java > UnifiedJexl (2.1.x) / Jxlt (3.0) parsing may fail with NPE > > > Key: JEXL-131 > URL: https://issues.apache.org/jira/browse/JEXL-131 > Project: Commons JEXL > Issue Type: Bug >Affects Versions: 2.1 >Reporter: Henri Biestro >Assignee: Henri Biestro > Fix For: 2.1.2, 3.0 > > > From Clay Bruce email: > the offending code is the method startsWith which can be found at line 1345 > in UnifiedJEXL.java. > Problem is that sequence is not tested to see if the index is available > before trying to access it. > A source with lines starting with leading spaces will trigger the bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-781) SimplexSolver gives bad results
[ https://issues.apache.org/jira/browse/MATH-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265941#comment-13265941 ] Thomas Neidhart commented on MATH-781: -- in MATH-434, floating-point comparisons have been changed to use either an: * epsilon for any comparisons related to algorithm convergence * ulp for any other comparisons Now, when dropping the objective function of the first phase, the comparison is done using ulp which is wrong imho as it is basically a convergence check. When changing this back to an epsilon check like before, the test runs through as expected. > SimplexSolver gives bad results > --- > > Key: MATH-781 > URL: https://issues.apache.org/jira/browse/MATH-781 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.0 > Environment: Windows 7 (64), jdk1.7.0_03 >Reporter: Scheiber Ernő > Attachments: LinearProgCM.java, LinearProgCM2.java > > > Methode SimplexSolver.optimeze(...) gives bad results with commons-math3-3.0 > in a simple test problem. It works well in commons-math-2.2. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-315) CollectionUtils.removeAll calls the wrong ListUtils method
[ https://issues.apache.org/jira/browse/COLLECTIONS-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265752#comment-13265752 ] Baris Acar commented on COLLECTIONS-315: Is there any plan for when this will be released? The latest version, 3.2.1, still contains this bug. > CollectionUtils.removeAll calls the wrong ListUtils method > -- > > Key: COLLECTIONS-315 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-315 > Project: Commons Collections > Issue Type: Bug > Components: Core >Affects Versions: 3.2 >Reporter: Christopher > > Using version 3.2.1 as downloaded from maven's public repository. > CollectionUtils.removeAll should call ListUtils.removeAll instead of > ListUtils.retainAll. > Currently > {{public static Collection removeAll(Collection collection, Collection > remove) { > return ListUtils.retainAll(collection, remove); > }}} > Suggested > {{public static Collection removeAll(Collection collection, Collection > remove) { > return ListUtils.*removeAll*(collection, remove); > }}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira