[jira] [Updated] (CSV-58) Escape handling needs rethinking
[ https://issues.apache.org/jira/browse/CSV-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anirudha Khanna updated CSV-58: --- Attachment: commons-csv.diff Patch consisting of changes to expand escape handling in CSV Parser > Escape handling needs rethinking > > > Key: CSV-58 > URL: https://issues.apache.org/jira/browse/CSV-58 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Reporter: Sebb > Fix For: 1.0 > > Attachments: commons-csv.diff > > > The current escape parsing converts to plain if the > is not one of the special characters to be escaped. > This can affect unicode escapes if the character is backslash. > One way round this is to specifically check for == 'u', but it seems > wrong to only do this for 'u'. > Another solution would be to leave as is unless the is one > of the special characters. > There are several possible ways to treat unrecognised escapes: > - treat it as if the escape char had not been present (current behaviour) > - leave the escape char as is > - throw an exception -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CSV-58) Escape handling needs rethinking
[ https://issues.apache.org/jira/browse/CSV-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401180#comment-13401180 ] Anirudha Khanna commented on CSV-58: I came across a concrete use case for rethinking the escape handling in Commons CSV. MySQL out format represents NULL as \N. This is a special character that should be retained as is. In this regard, I have made an attempt to modify the escape handling in the Commons CSV parser. I have not made corresponding changes to CSV writer and will submit a patch in that regards soon to. Looking forward to thoughts. > Escape handling needs rethinking > > > Key: CSV-58 > URL: https://issues.apache.org/jira/browse/CSV-58 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Reporter: Sebb > Fix For: 1.0 > > > The current escape parsing converts to plain if the > is not one of the special characters to be escaped. > This can affect unicode escapes if the character is backslash. > One way round this is to specifically check for == 'u', but it seems > wrong to only do this for 'u'. > Another solution would be to leave as is unless the is one > of the special characters. > There are several possible ways to treat unrecognised escapes: > - treat it as if the escape char had not been present (current behaviour) > - leave the escape char as is > - throw an exception -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-231) Not return the base interface on decorate
[ https://issues.apache.org/jira/browse/COLLECTIONS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400952#comment-13400952 ] Hudson commented on COLLECTIONS-231: Integrated in commons-collections #45 (See [https://builds.apache.org/job/commons-collections/45/]) [COLLECTIONS-231] apply signature change to factory method. (Revision 1353169) [COLLECTIONS-231] apply signature change to factory method. (Revision 1353166) [COLLECTIONS-231] apply signature change to factory method. (Revision 1353165) Result = SUCCESS tn : http://svn.apache.org/viewvc/?view=rev&rev=1353169 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/MapBackedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/PredicatedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/PredicatedSortedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/SynchronizedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/SynchronizedSortedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/TransformedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/TransformedSortedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/UnmodifiableSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/UnmodifiableSortedSet.java tn : http://svn.apache.org/viewvc/?view=rev&rev=1353166 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/FixedSizeList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/GrowthList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/LazyList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/PredicatedList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/SynchronizedList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/TransformedList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/UnmodifiableList.java tn : http://svn.apache.org/viewvc/?view=rev&rev=1353165 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/PredicatedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java > Not return the base interface on decorate > - > > Key: COLLECTIONS-231 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-231 > Project: Commons Collections > Issue Type: Improvement > Components: Map >Affects Versions: 3.2 >Reporter: Torsten Curdt > Fix For: 4.0-beta-1 > > > At the moment I don't see a reason why the static "decorate" method does not > return ListOrderedMap but just the base interface OrderedMap. > I want to decorate a Map to be a ListOrderedMap but due to the fact that the > constructor is not visible and decorate only returns the base interface > OrderedMap an unnecessary cast is required. > ListOrderedMap map = (ListOrderedMap)ListOrderedMap.decorate(new MyMap()); > As the decorate method is static and not part of any interface it should be > fine to return the real type instead of the base. Otherwise I'd suggest to > make the constructor visible. From the API POV It is not really > understandable why this > ListOrderedMap map = new ListOrderedMap(); > is fine and creates a HashMap under the hood while this > ListOrderedMap map = new ListOrderedMap(new MyMap())); > is not ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-324) Fields transformer and decorated in comparators.TransformingComparator could be made final
[ https://issues.apache.org/jira/browse/COLLECTIONS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400951#comment-13400951 ] Hudson commented on COLLECTIONS-324: Integrated in commons-collections #45 (See [https://builds.apache.org/job/commons-collections/45/]) [COLLECTIONS-324] Made protected fields final to improve thread-safety. Thanks to sebb for the report. (Revision 1353172) Result = SUCCESS tn : http://svn.apache.org/viewvc/?view=rev&rev=1353172 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java > Fields transformer and decorated in comparators.TransformingComparator could > be made final > -- > > Key: COLLECTIONS-324 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-324 > Project: Commons Collections > Issue Type: Improvement > Components: Comparator >Reporter: Sebb > Fix For: 4.0 > > > Fields transformer and decorated in comparators.TransformingComparator could > be made final to improve thread-safety. > This will break subclasses that write to the fields, but would such code make > any sense? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-324) Fields transformer and decorated in comparators.TransformingComparator could be made final
[ https://issues.apache.org/jira/browse/COLLECTIONS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400921#comment-13400921 ] Hudson commented on COLLECTIONS-324: Integrated in commons-collections #44 (See [https://builds.apache.org/job/commons-collections/44/]) [COLLECTIONS-324] Made protected fields final to improve thread-safety. Thanks to sebb for the report. (Revision 1353172) Result = FAILURE tn : http://svn.apache.org/viewvc/?view=rev&rev=1353172 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java > Fields transformer and decorated in comparators.TransformingComparator could > be made final > -- > > Key: COLLECTIONS-324 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-324 > Project: Commons Collections > Issue Type: Improvement > Components: Comparator >Reporter: Sebb > Fix For: 4.0 > > > Fields transformer and decorated in comparators.TransformingComparator could > be made final to improve thread-safety. > This will break subclasses that write to the fields, but would such code make > any sense? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-231) Not return the base interface on decorate
[ https://issues.apache.org/jira/browse/COLLECTIONS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400922#comment-13400922 ] Hudson commented on COLLECTIONS-231: Integrated in commons-collections #44 (See [https://builds.apache.org/job/commons-collections/44/]) [COLLECTIONS-231] apply signature change to factory method. (Revision 1353169) [COLLECTIONS-231] apply signature change to factory method. (Revision 1353166) [COLLECTIONS-231] apply signature change to factory method. (Revision 1353165) Result = FAILURE tn : http://svn.apache.org/viewvc/?view=rev&rev=1353169 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/MapBackedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/PredicatedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/PredicatedSortedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/SynchronizedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/SynchronizedSortedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/TransformedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/TransformedSortedSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/UnmodifiableSet.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/UnmodifiableSortedSet.java tn : http://svn.apache.org/viewvc/?view=rev&rev=1353166 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/FixedSizeList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/GrowthList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/LazyList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/PredicatedList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/SynchronizedList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/TransformedList.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/UnmodifiableList.java tn : http://svn.apache.org/viewvc/?view=rev&rev=1353165 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/PredicatedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java > Not return the base interface on decorate > - > > Key: COLLECTIONS-231 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-231 > Project: Commons Collections > Issue Type: Improvement > Components: Map >Affects Versions: 3.2 >Reporter: Torsten Curdt > Fix For: 4.0-beta-1 > > > At the moment I don't see a reason why the static "decorate" method does not > return ListOrderedMap but just the base interface OrderedMap. > I want to decorate a Map to be a ListOrderedMap but due to the fact that the > constructor is not visible and decorate only returns the base interface > OrderedMap an unnecessary cast is required. > ListOrderedMap map = (ListOrderedMap)ListOrderedMap.decorate(new MyMap()); > As the decorate method is static and not part of any interface it should be > fine to return the real type instead of the base. Otherwise I'd suggest to > make the constructor visible. From the API POV It is not really > understandable why this > ListOrderedMap map = new ListOrderedMap(); > is fine and creates a HashMap under the hood while this > ListOrderedMap map = new ListOrderedMap(new MyMap())); > is not ok. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SANDBOX-424) [BeanUtils2] Add files necessary to create site
[ https://issues.apache.org/jira/browse/SANDBOX-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SANDBOX-424. Resolution: Fixed Assignee: Simone Tripodi patch applied and reviewed - I did a cleanup on your patch and replaced pages automatically generated by plugins. I'll update the site tomorrow from the office, where I have a faster upload connection. > [BeanUtils2] Add files necessary to create site > --- > > Key: SANDBOX-424 > URL: https://issues.apache.org/jira/browse/SANDBOX-424 > Project: Commons Sandbox > Issue Type: Improvement > Components: BeanUtils2 >Affects Versions: Nightly Builds >Reporter: Benedikt Ritter >Assignee: Simone Tripodi > Fix For: Nightly Builds > > Attachments: SANDBOX-424.patch > > > In order to create a subpage at commons.apache.org the required xDoc files > have to be added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IMAGING-81) Add more Javadoc to main package
[ https://issues.apache.org/jira/browse/IMAGING-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Lucas updated IMAGING-81: -- Attachment: Lucas_Javadoc_25_June_2012.patch The following adds Javadoc to Imaging and ImageParser, with at least class-level descriptions for all the main classes. I've also scrubbed up some of the existing Javadoc in Imaging.java (which still referred to Sanselan) and added package.html documentation to some of the packages. I hope that this documentation will make it easier for developers to work the the Imaging library. > Add more Javadoc to main package > > > Key: IMAGING-81 > URL: https://issues.apache.org/jira/browse/IMAGING-81 > Project: Apache Commons Imaging > Issue Type: Improvement > Components: Documentation >Reporter: Gary Lucas >Assignee: Luc Maisonobe >Priority: Minor > Attachments: Lucas_Javadoc_25_June_2012.patch > > > The current version of the Apache Commons Imaging has minimal Javadoc. While > the task of completely supplying Javadoc for the package would easily require > multiple man-months of effort, it would be useful to add information to at > least the top-level package and main classes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (IMAGING-81) Add more Javadoc to main package
Gary Lucas created IMAGING-81: - Summary: Add more Javadoc to main package Key: IMAGING-81 URL: https://issues.apache.org/jira/browse/IMAGING-81 Project: Apache Commons Imaging Issue Type: Improvement Components: Documentation Reporter: Gary Lucas Assignee: Luc Maisonobe Priority: Minor The current version of the Apache Commons Imaging has minimal Javadoc. While the task of completely supplying Javadoc for the package would easily require multiple man-months of effort, it would be useful to add information to at least the top-level package and main classes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SANDBOX-424) [BeanUtils2] Add files necessary to create site
[
https://issues.apache.org/jira/browse/SANDBOX-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400360#comment-13400360
]
Simone Tripodi commented on SANDBOX-424:
{quote}
for some reason the downloads page does not work. What am I missing here?
{quote}
Don't worry about Download page - Sanodbox components cannot be released until
promotion to Proper - Download page will be generated via a mvn plugin, that
problem will be postponed.
{quote}
Since BeanUtils at the moment doesn't have its own jira project, the issue
tracking subpage only references the SANDBOX project
{quote}
fine!
I'll have a look at your patch as soon as I'll get a cycle, maybe during
lunchtime!
> [BeanUtils2] Add files necessary to create site
> ---
>
> Key: SANDBOX-424
> URL: https://issues.apache.org/jira/browse/SANDBOX-424
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
>Affects Versions: Nightly Builds
>Reporter: Benedikt Ritter
> Fix For: Nightly Builds
>
> Attachments: SANDBOX-424.patch
>
>
> In order to create a subpage at commons.apache.org the required xDoc files
> have to be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
