[jira] [Commented] (MATH-1108) SimplexSolver returns TooManyIterationsException

2014-03-05 Thread Buharov Alexander (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920637#comment-13920637
 ] 

Buharov Alexander commented on MATH-1108:
-

Hi Thomas,
thank you  for your answer.

I really got solution, after changing criteria ( for case | s * v | <= 1e-6 ).  
I can't set lower bounds as 0. Because this example is only one situation ( in 
common case: bounds for different variables are differed).

But now I can calculate solution (though need around 10 minutes). It already is 
good.
There are solvers which can calculate my problem faster, but I sought just java 
- lib. Thank you for help!

> SimplexSolver returns TooManyIterationsException
> 
>
> Key: MATH-1108
> URL: https://issues.apache.org/jira/browse/MATH-1108
> Project: Commons Math
>  Issue Type: Bug
>Affects Versions: 3.2, 3.1.1
>Reporter: Buharov Alexander
> Attachments: Problem.zip
>
>
> We have vector v and matrix s (from file S.txt)
> v - vector ( size: 1*649 )
> s - matrix ( size: 554*649 )
> We want solve linear problem:
>  * max (v[31])
>  * Bounds:
>  *  s*v = 0
>  *  -1 <= v[i] <= 1 for i=0,..., 648 
> We changed  MaxIter parameter (from 100 to 1e+6). And we changed epsilon ( 
> set default value and 1e-3).  But solver always throws 
> TooManyIterationsException (and work very slow).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1108) SimplexSolver returns TooManyIterationsException

2014-03-05 Thread Thomas Neidhart (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920658#comment-13920658
 ] 

Thomas Neidhart commented on MATH-1108:
---

The problem with your original problem definition is that all the right hand 
sides for the non-bounds constraints are 0.
This means that the min ratio test as implemented in our solver (and which is 
the standard one) will have troubles finding the best way to improve the 
solution as all are equally likely. The result is a very slow convergence.

Other solvers might handle this special case better, and we should also aim to 
improve here. Could you tell me with which solvers you tried your problem and 
got better results?

> SimplexSolver returns TooManyIterationsException
> 
>
> Key: MATH-1108
> URL: https://issues.apache.org/jira/browse/MATH-1108
> Project: Commons Math
>  Issue Type: Bug
>Affects Versions: 3.2, 3.1.1
>Reporter: Buharov Alexander
> Attachments: Problem.zip
>
>
> We have vector v and matrix s (from file S.txt)
> v - vector ( size: 1*649 )
> s - matrix ( size: 554*649 )
> We want solve linear problem:
>  * max (v[31])
>  * Bounds:
>  *  s*v = 0
>  *  -1 <= v[i] <= 1 for i=0,..., 648 
> We changed  MaxIter parameter (from 100 to 1e+6). And we changed epsilon ( 
> set default value and 1e-3).  But solver always throws 
> TooManyIterationsException (and work very slow).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1108) SimplexSolver returns TooManyIterationsException

2014-03-05 Thread Thomas Neidhart (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920680#comment-13920680
 ] 

Thomas Neidhart commented on MATH-1108:
---

btw. on my computer it runs in ~ 20s, but I used the latest trunk version 
(3.3-SNAPSHOT) which has several performance improvements.

> SimplexSolver returns TooManyIterationsException
> 
>
> Key: MATH-1108
> URL: https://issues.apache.org/jira/browse/MATH-1108
> Project: Commons Math
>  Issue Type: Bug
>Affects Versions: 3.2, 3.1.1
>Reporter: Buharov Alexander
> Attachments: Problem.zip
>
>
> We have vector v and matrix s (from file S.txt)
> v - vector ( size: 1*649 )
> s - matrix ( size: 554*649 )
> We want solve linear problem:
>  * max (v[31])
>  * Bounds:
>  *  s*v = 0
>  *  -1 <= v[i] <= 1 for i=0,..., 648 
> We changed  MaxIter parameter (from 100 to 1e+6). And we changed epsilon ( 
> set default value and 1e-3).  But solver always throws 
> TooManyIterationsException (and work very slow).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1108) SimplexSolver returns TooManyIterationsException

2014-03-05 Thread Buharov Alexander (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920708#comment-13920708
 ] 

Buharov Alexander commented on MATH-1108:
-

This problem is related with systems biology. This models are saved in 
SBML-format. And there are special Matlab TOOLBOX (COBRA) for solving this 
problem (http://opencobra.sourceforge.net/openCOBRA/Welcome.html).

If you want to test this toolbox. I attached file AdipocyteModel.xml with model 
(this model have same non-bounds constraints and object function like previous 
example). You can instal COBRA toolbox and make next calculation in Matlab:

model = readCbModel('AdipocyteModel.xml');% read model
changeCobraSolver('glpk');% choose 
solver
FBAsolution = optimizeCbModel(model,'max');   % solve

As I understand this solver use modification of simplex method (But I could be 
wrong). Calculation time is around 1s. 

> SimplexSolver returns TooManyIterationsException
> 
>
> Key: MATH-1108
> URL: https://issues.apache.org/jira/browse/MATH-1108
> Project: Commons Math
>  Issue Type: Bug
>Affects Versions: 3.2, 3.1.1
>Reporter: Buharov Alexander
> Attachments: AdipocyteModel.xml, Problem.zip
>
>
> We have vector v and matrix s (from file S.txt)
> v - vector ( size: 1*649 )
> s - matrix ( size: 554*649 )
> We want solve linear problem:
>  * max (v[31])
>  * Bounds:
>  *  s*v = 0
>  *  -1 <= v[i] <= 1 for i=0,..., 648 
> We changed  MaxIter parameter (from 100 to 1e+6). And we changed epsilon ( 
> set default value and 1e-3).  But solver always throws 
> TooManyIterationsException (and work very slow).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (MATH-1108) SimplexSolver returns TooManyIterationsException

2014-03-05 Thread Buharov Alexander (JIRA)

 [ 
https://issues.apache.org/jira/browse/MATH-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Buharov Alexander updated MATH-1108:


Attachment: AdipocyteModel.xml

> SimplexSolver returns TooManyIterationsException
> 
>
> Key: MATH-1108
> URL: https://issues.apache.org/jira/browse/MATH-1108
> Project: Commons Math
>  Issue Type: Bug
>Affects Versions: 3.2, 3.1.1
>Reporter: Buharov Alexander
> Attachments: AdipocyteModel.xml, Problem.zip
>
>
> We have vector v and matrix s (from file S.txt)
> v - vector ( size: 1*649 )
> s - matrix ( size: 554*649 )
> We want solve linear problem:
>  * max (v[31])
>  * Bounds:
>  *  s*v = 0
>  *  -1 <= v[i] <= 1 for i=0,..., 648 
> We changed  MaxIter parameter (from 100 to 1e+6). And we changed epsilon ( 
> set default value and 1e-3).  But solver always throws 
> TooManyIterationsException (and work very slow).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-279) Tailer erroneously considers file as new

2014-03-05 Thread Robert Olofsson (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920732#comment-13920732
 ] 

Robert Olofsson commented on IO-279:


I stumbled across this issue while tailing a file on a remote server via Samba.

The clock on the server was running a few seconds ahead of my local machine 
which caused the file to be seen as newer even though it wasn't.

I solved this by simply replacing the line:

last = System.currentTimeMillis();

With:

last = file.lastModified();

That way it doesn't matter if the clocks are not in perfect sync.

> Tailer erroneously considers file as new
> 
>
> Key: IO-279
> URL: https://issues.apache.org/jira/browse/IO-279
> Project: Commons IO
>  Issue Type: Bug
>Affects Versions: 2.0.1, 2.4
>Reporter: Sergio Bossa
> Attachments: IO-279.patch, disable_resetting.patch, fix-tailer.patch, 
> modify-test-fixed.patch, modify-test.patch
>
>
> Tailer sometimes erroneously considers the tailed file as new, forcing a 
> repositioning at the start of the file: I'm still unable to reproduce this in 
> a test case, because it only happens to me with huge log files during Apache 
> Tomcat startup.
> This is the piece of code causing the problem:
> {code}
> // See if the file needs to be read again
> if (length > position) {
> // The file has more content than it did last time
> last = System.currentTimeMillis();
> position = readLines(reader);
> } else if (FileUtils.isFileNewer(file, last)) {
> /* This can happen if the file is truncated or overwritten
> * with the exact same length of information. In cases like
> * this, the file position needs to be reset
> */
> position = 0;
> reader.seek(position); // cannot be null here
> // Now we can read new lines
> last = System.currentTimeMillis();
> position = readLines(reader);
> }
> {code}
> What probably happens is that the new file content is about to be written on 
> disk, the date is already updated but content is still not flushed, so actual 
> length is untouched and there you go.
> In other words, I think there should be some better method to verify the 
> condition above, rather than relying only on dates: keeping and comparing the 
> hash code of the latest line may be a solution, but may hurt performances ... 
> other ideas?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2014-03-05 Thread Robert Olofsson (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920736#comment-13920736
 ] 

Robert Olofsson commented on IO-269:


I came across this issue and noticed an inefficiency in the code of the run 
method.

With the reOpen flag set a new RandomAccessFile is always created at the end of 
the main while loop in the run method:

if (getRun() && reOpen) {
reader = new RandomAccessFile(file, RAF_MODE);
reader.seek(position);
}

This is unnecessary and contributes to unnecessary file locking on Windows.

If the reOpen flag is set a new RandomAccessFile should only be created when 
the length of the file or the last modification date indicate that the file 
needs to be read. 


> Tailer locks file from deletion/rename on Windows
> -
>
> Key: IO-269
> URL: https://issues.apache.org/jira/browse/IO-269
> Project: Commons IO
>  Issue Type: Bug
>Reporter: Sebb
> Fix For: 2.4
>
> Attachments: IO-269-v2.patch, IO-269-v3.patch, IO-269.patch, 
> ReOpen.java
>
>
> The Tailer code works on Windows, except that it locks the file against 
> deletion or rename.
> The test code fails to detect this, because it fails to check if the file 
> deletion succeeds.
> This seems to be a Windows OS issue.
> A possible solution might be to keep closing and re-opening the file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (POOL-250) wish to Commons Pool 2 works with Android environment

2014-03-05 Thread Mark Thomas (JIRA)

 [ 
https://issues.apache.org/jira/browse/POOL-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved POOL-250.
--

Resolution: Won't Fix

As per my previous comment. A stub implementation of JMX for Android 
deployments is going to be the cleanest way to fix this.

> wish to Commons Pool 2 works with Android environment
> -
>
> Key: POOL-250
> URL: https://issues.apache.org/jira/browse/POOL-250
> Project: Commons Pool
>  Issue Type: Wish
>Affects Versions: 2.1
> Environment: Android
>Reporter: Jungtaek Lim
>
> This issue starts at https://github.com/xetorthio/jedis/issues/538.
> Jedis - Java Redis Client - seems to stop working with Android at that time 
> Jedis changes Common Pool version from 1.6 to 2.0.
> I found Commons Pool 2 uses jmx, which Android cannot support.
> I believe it makes error with class loading, so disabling jmx cannot resolve 
> this issue.
> {code}
> public BaseGenericObjectPool(BaseObjectPoolConfig config,
> String jmxNameBase, String jmxNamePrefix) {
> if (config.getJmxEnabled()) {
> this.oname = jmxRegister(jmxNameBase, jmxNamePrefix);
> } else {
> this.oname = null;
> }
> ...
> {code}
> {code}
> private ObjectName jmxRegister(String jmxNameBase, String jmxNamePrefix) {
> ObjectName objectName = null;
> MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
> int i = 1;
> ...
> {code}
> Please double check Commons Pool 2 is not working with Android.
> And if it's not working, I wish you to make Commons Pool 2 jmx usage 
> selectable.
> ps. error message follows
> {code}
> W  VFY: unable to find class referenced in signature 
> (Ljavax/management/ObjectName;)
> I  Could not find method 
> java.lang.management.ManagementFactory.getPlatformMBeanServer, referenced 
> from method org.apache.commons.pool2.impl.BaseGenericObjectPool.jmxRegister
> W  VFY: unable to resolve static method 22260: 
> Ljava/lang/management/ManagementFactory;.getPlatformMBeanServer 
> ()Ljavax/management/MBeanServer;
> D  VFY: replacing opcode 0x71 at 0x0001
> W  VFY: unable to find class referenced in signature 
> (Ljavax/management/ObjectName;)
> I  Could not find method 
> java.lang.management.ManagementFactory.getPlatformMBeanServer, referenced 
> from method org.apache.commons.pool2.impl.BaseGenericObjectPool.jmxUnregister
> W  VFY: unable to resolve static method 22260: 
> Ljava/lang/management/ManagementFactory;.getPlatformMBeanServer 
> ()Ljavax/management/MBeanServer;
> D  VFY: replacing opcode 0x71 at 0x0004
> D  GC_FOR_ALLOC freed 396K, 5% free 9382K/9808K, paused 29ms, total 29ms
> W  VFY: unable to resolve exception class 3559 
> (Ljavax/management/MBeanRegistrationException;)
> W  VFY: unable to find exception handler at addr 0xe
> W  VFY:  rejected 
> Lorg/apache/commons/pool2/impl/BaseGenericObjectPool;.jmxUnregister ()V
> W  VFY:  rejecting opcode 0x0d at 0x000e
> W  VFY:  rejected 
> Lorg/apache/commons/pool2/impl/BaseGenericObjectPool;.jmxUnregister ()V
> W  Verifier rejected class 
> Lorg/apache/commons/pool2/impl/BaseGenericObjectPool;
> DJDWP invocation returning with exceptObj=0x41f58880 
> (Ljava/lang/ClassNotFoundException;)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (DBCP-361) BasicManagedDataSource optional transaction enlistment

2014-03-05 Thread Mark Thomas (JIRA)

 [ 
https://issues.apache.org/jira/browse/DBCP-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved DBCP-361.
--

Resolution: Won't Fix

Happy to re-open this if someone wants to provide a patch.

> BasicManagedDataSource optional transaction enlistment
> --
>
> Key: DBCP-361
> URL: https://issues.apache.org/jira/browse/DBCP-361
> Project: Commons Dbcp
>  Issue Type: New Feature
>Reporter: Aaron Hamid
>
> It would be nice to not automatically enlist connections in a transaction.  I 
> have found automatic enlistment can be problematic when using another 
> transaction API such as Spring's declarative transactions 
> (JtaTransactionManager).  It appears Spring may create a second, wrapping 
> transaction.  With Oracle this leads to: ORA-02089: COMMIT is not allowed in 
> a subordinate session.
> E.g. see Bitronix setAutomaticEnlistingEnabled 
> http://btm.codehaus.org/api/1.3.3/bitronix/tm/resource/common/ResourceBean.html#setAutomaticEnlistingEnabled(boolean)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (DBCP-168) [dbcp] add/enhance toString() Method to DelegatingCallableStatement for sql debugging

2014-03-05 Thread Mark Thomas (JIRA)

 [ 
https://issues.apache.org/jira/browse/DBCP-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved DBCP-168.
--

Resolution: Won't Fix

Happy to re-open this if someone wants to provide a patch.

> [dbcp] add/enhance toString() Method to DelegatingCallableStatement for sql 
> debugging
> -
>
> Key: DBCP-168
> URL: https://issues.apache.org/jira/browse/DBCP-168
> Project: Commons Dbcp
>  Issue Type: Improvement
> Environment: Operating System: All
> Platform: PC
>Reporter: Ralf Hauser
>Priority: Minor
>
> one of the beauties of mysql connector-J is that a stmt.toString() not just
> produces the object reference string but also the sql-statement that will be
> executed on the RDBMS server. (Thanks Mark Matthews!)
> Recently, I went through the excercise of porting a larger jdbc code-base from
> mysql to oracle. There may be many reasons to do this, but error handling in
> ojdbc14.jar is not one of it  :(   {the usual laziness of programmers when
> throwing an error: not saying which of the parameters caused it, not citing
> offending values, string positions of invalid characters, ... - it would cost
> them a few minutes to do better and save the developers using their jar days 
> if
> not weeks!}
> Therefore the RFE:
> Not only directly pass on all values in DelegatingCallableStatement and
> DelegatingPreparedStatement to the delegate, but in the set*() methods gather
> enough information to be able to do something along the lines of
> com.mysql.jdbc.PreparedStatement.asSql()
> Sure one might say that this causes unneccessary overhead for production
> environments - o.k. perhaps there needs to be a configuration flag to set
> whether dbcp shall do this or operate as is.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (DBCP-389) Provide a configurable implementation of OSGi 4.2 DataSourceFactory

2014-03-05 Thread Mark Thomas (JIRA)

 [ 
https://issues.apache.org/jira/browse/DBCP-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved DBCP-389.
--

Resolution: Won't Fix

Happy to re-open this if someone wants to provide a patch.

> Provide a configurable implementation of OSGi 4.2 DataSourceFactory
> ---
>
> Key: DBCP-389
> URL: https://issues.apache.org/jira/browse/DBCP-389
> Project: Commons Dbcp
>  Issue Type: Improvement
>Affects Versions: 1.4
> Environment: Any OSGi 4.2 environment like Felix.
>Reporter: Matt Bishop
>
> Using JDBC Drivers in OSGi has been made more understandable in R4.2 with the 
> addition of the DataSourceFactory service interface. It makes it pretty easy 
> to consume JDBC datasources in OSGi.
> However, no one implements this interface in a driver-agnostic manner. DBCP 
> is well-positioned to provide a configurable DataSourceFactory that could 
> provide the DataSource variants to services.
> More information can be found here: 
> http://www.osgi.org/javadoc/r4v42/org/osgi/service/jdbc/DataSourceFactory.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (DBCP-393) DBCP to support database connection failover

2014-03-05 Thread Mark Thomas (JIRA)

 [ 
https://issues.apache.org/jira/browse/DBCP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved DBCP-393.
--

Resolution: Won't Fix

Happy to re-open this if someone wants to provide a patch.

> DBCP to support database connection failover
> 
>
> Key: DBCP-393
> URL: https://issues.apache.org/jira/browse/DBCP-393
> Project: Commons Dbcp
>  Issue Type: Improvement
>Affects Versions: 1.4
>Reporter: Campbell
>Priority: Critical
>
> Hello. Would it be possible for the DriverManagerConnectionFactory to accept 
> a list or alternative database connection URL. With a possible maxRetry 
> parameter, the suggestion is this improvement would allow for automatic fail 
> over to a secondary database when a connection exception occurs.
> Let me know if this is a good candidate or if you have made thought of this 
> already as it is standard behaviour in other managed datasources. Many thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1105) Least squares statistical data editing

2014-03-05 Thread Gilles (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920851#comment-13920851
 ] 

Gilles commented on MATH-1105:
--

bq. We now have two least squares impls [...]

Arguably, this has been the case for a long time, as witnessed by the 
"AbstractLeastSquaresOptimizer" deprecated implementations (two versions: 
"o.a.c.m.optimization.general" and "o.a.c.m.optim.nonlinear.vector.jacobian").

Enhancing a "[least-squares] problem" through wrapping was the ultimate goal of 
this major refactoring. This is a very illustrative example of the power of the 
approach proposed by Evan.

bq. The stats side of it (residual analysis, ANOVA, etc.) belongs more 
naturally in stats.regression.

Do you mean that the decision-making (i.e. how to handle the "bad" data) should 
be coded there?
IIUC, then an enhanced "LeastSquareProblem" could still be generated that would 
take something like a "BadDataHandler" as an argument.

bq. First patch provides the capability.

Regarding the first patch, is it necessary to introduce a new method 
"getAcceptedObservations()"? It would be nicer to consider that the wrapper 
transparently modifies the problem (by changing the weights of some 
observations, or removing them altogether) so that, viewed from the outside, it 
would be like a fresh problem was built in the first place (with the modified 
observations).
For example, one would be able to tell that some observations were deleted by 
taking the difference between calls to "getObservationSize()" on the original 
instance and on the wrapped instance.
Does that make sense?


> Least squares statistical data editing
> --
>
> Key: MATH-1105
> URL: https://issues.apache.org/jira/browse/MATH-1105
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Evan Ward
> Attachments: 0001-Add-statistical-editing-capability.patch, 
> 0002-Integrate-data-editing-with-the-LS-framework.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (IO-427) New TrailerInputStream class

2014-03-05 Thread Duncan Jones (JIRA)
Duncan Jones created IO-427:
---

 Summary: New TrailerInputStream class
 Key: IO-427
 URL: https://issues.apache.org/jira/browse/IO-427
 Project: Commons IO
  Issue Type: New Feature
  Components: Streams/Writers
Reporter: Duncan Jones
Priority: Minor
 Fix For: 2.5


A new input stream for reading data with fixed length trailers/suffixes. This 
was briefly discussed on the ML: http://markmail.org/thread/mh4elj7a53mdus2h.

Since I don't often write input streams and haven't contributed to this project 
before, I offer this up for review to see if it's a welcome addition.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (IO-427) New TrailerInputStream class

2014-03-05 Thread Duncan Jones (JIRA)

 [ 
https://issues.apache.org/jira/browse/IO-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duncan Jones updated IO-427:


Attachment: TrailerInputStreamTest.java
TrailerInputStream.java

> New TrailerInputStream class
> 
>
> Key: IO-427
> URL: https://issues.apache.org/jira/browse/IO-427
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Reporter: Duncan Jones
>Priority: Minor
>  Labels: patch
> Fix For: 2.5
>
> Attachments: TrailerInputStream.java, TrailerInputStreamTest.java
>
>
> A new input stream for reading data with fixed length trailers/suffixes. This 
> was briefly discussed on the ML: http://markmail.org/thread/mh4elj7a53mdus2h.
> Since I don't often write input streams and haven't contributed to this 
> project before, I offer this up for review to see if it's a welcome addition.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1105) Least squares statistical data editing

2014-03-05 Thread Evan Ward (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920880#comment-13920880
 ] 

Evan Ward commented on MATH-1105:
-

{quote}
bq. First patch provides the capability.
Regarding the first patch, is it necessary to introduce a new method 
"getAcceptedObservations()"? It would be nicer to consider that the wrapper 
transparently modifies the problem (by changing the weights of some 
observations, or removing them altogether) so that, viewed from the outside, it 
would be like a fresh problem was built in the first place (with the modified 
observations).
For example, one would be able to tell that some observations were deleted by 
taking the difference between calls to "getObservationSize()" on the original 
instance and on the wrapped instance.
Does that make sense?
{quote}

Getting the number of accepted or rejected observations is the part I am a 
little unsure of. The second patch adds  "getAcceptedObservations()" to the 
Evaluation interface so that data editing is a simple wrapper.

Since the number of accepted observations can change from one Evaluation to the 
next, I couldn't just use LSP.getObservationSize(). Since the current 
optimizers aren't set up to support a changing observation size, I didn't want 
to change the dimension of the residuals or the Jacobian either. 

That left zeroing out the bad data and adding a method to Evaluation to get the 
number of accepted/rejected observations. We could rename 
Evaluation.getAcceptedObservations() to Evaluation.getObservationSize() if that 
makes it clearer that it returns the length of the residual vector when there 
is no data editing and the number of accepted observations when there is data 
editing.  E.g.

{code:java}
LeastSquaresProblem lsp = ...;
Optimum optimum = optimizer.optimize(lsp);
double acceptedRatio = optimum.getAcceptedObservations() / 
lsp.getObservationSize();
{code}

Does this answer your question? I'm not sure if I understood correctly.

> Least squares statistical data editing
> --
>
> Key: MATH-1105
> URL: https://issues.apache.org/jira/browse/MATH-1105
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Evan Ward
> Attachments: 0001-Add-statistical-editing-capability.patch, 
> 0002-Integrate-data-editing-with-the-LS-framework.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920904#comment-13920904
 ] 

Sebb commented on IO-269:
-

bq. This is unnecessary and contributes to unnecessary file locking on Windows.

On the contrary, it is an essential part of unlocking the file on Windows when 
possible.
The full code is as follows:

{code}
if (reOpen) {
IOUtils.closeQuietly(reader);
}
Thread.sleep(delayMillis);
if (getRun() && reOpen) {
reader = new RandomAccessFile(file, RAF_MODE);
reader.seek(position);
}
{code}

Notice that the file is closed - and therefore unlocked - during the sleep if 
reOpen is true.
If reOpen is false, the file remains locked by Windows for the duration of the 
Tailer thread.

> Tailer locks file from deletion/rename on Windows
> -
>
> Key: IO-269
> URL: https://issues.apache.org/jira/browse/IO-269
> Project: Commons IO
>  Issue Type: Bug
>Reporter: Sebb
> Fix For: 2.4
>
> Attachments: IO-269-v2.patch, IO-269-v3.patch, IO-269.patch, 
> ReOpen.java
>
>
> The Tailer code works on Windows, except that it locks the file against 
> deletion or rename.
> The test code fails to detect this, because it fails to check if the file 
> deletion succeeds.
> This seems to be a Windows OS issue.
> A possible solution might be to keep closing and re-opening the file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1105) Least squares statistical data editing

2014-03-05 Thread Gilles (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920923#comment-13920923
 ] 

Gilles commented on MATH-1105:
--

bq. Since the number of accepted observations can change from one Evaluation to 
the next, I couldn't just use LSP.getObservationSize(). Since the current 
optimizers aren't set up to support a changing observation size, I didn't want 
to change the dimension of the residuals or the Jacobian either. 

That's a key design issue.
Does it makes sense for the "LeastSquaresProblem" instance to change the number 
of observations? According to the feature discussed here, it seems that the 
answer could be yes. If so, the optimizer cannot assume that the number of 
observations is constant.
On the other hand, if we consider that changing an optimizer code to allow for 
a changing number of observations is not standard practice, that should be 
explicitly reflected in the handling of bad data, i.e. no observation can be 
removed, only its weight can be altered.
Then, "getAcceptedObservations()" is not enough to convey the transformation 
which the handler applied on bad data; only the weights differences (between 
the original and the wrapper instances) will provide the full story. Hence, it 
seems that adding this method complexifies the API without a clear benefit.


> Least squares statistical data editing
> --
>
> Key: MATH-1105
> URL: https://issues.apache.org/jira/browse/MATH-1105
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Evan Ward
> Attachments: 0001-Add-statistical-editing-capability.patch, 
> 0002-Integrate-data-editing-with-the-LS-framework.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-427) New TrailerInputStream class

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920934#comment-13920934
 ] 

Sebb commented on IO-427:
-

There's a lot of array copying going on.
It would be more efficicient to use a fixed ring buffer to hold the trailer.

> New TrailerInputStream class
> 
>
> Key: IO-427
> URL: https://issues.apache.org/jira/browse/IO-427
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Reporter: Duncan Jones
>Priority: Minor
>  Labels: patch
> Fix For: 2.5
>
> Attachments: TrailerInputStream.java, TrailerInputStreamTest.java
>
>
> A new input stream for reading data with fixed length trailers/suffixes. This 
> was briefly discussed on the ML: http://markmail.org/thread/mh4elj7a53mdus2h.
> Since I don't often write input streams and haven't contributed to this 
> project before, I offer this up for review to see if it's a welcome addition.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2014-03-05 Thread Robert Olofsson (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920933#comment-13920933
 ] 

Robert Olofsson commented on IO-269:


Yes the file is closed when while loop sleeps, however what I'm trying to point 
out is that the file is always opened during each iteration of the loop even 
when it's not necessary.

There is no need to open the file unless changes to it's length or last 
modified date are detected.

I've created a modified version of Tailer for small desktop app called 
SwingTail (http://unlogic.se/projects/swingtail) the incorporates these changes 
among others. However I've done so many other changes that I couldn't generate 
a clean diff. But the source is available here:

svn://svn.unlogic.se/swingtail/trunk/src/se/unlogic/swingtail/Tailer.java

Essentially I simply removed the open statement from the end of the loop and 
added three separate open statements higher up the loop that only open the file 
when a change is actually detected.


> Tailer locks file from deletion/rename on Windows
> -
>
> Key: IO-269
> URL: https://issues.apache.org/jira/browse/IO-269
> Project: Commons IO
>  Issue Type: Bug
>Reporter: Sebb
> Fix For: 2.4
>
> Attachments: IO-269-v2.patch, IO-269-v3.patch, IO-269.patch, 
> ReOpen.java
>
>
> The Tailer code works on Windows, except that it locks the file against 
> deletion or rename.
> The test code fails to detect this, because it fails to check if the file 
> deletion succeeds.
> This seems to be a Windows OS issue.
> A possible solution might be to keep closing and re-opening the file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920973#comment-13920973
 ] 

Sebb commented on IO-269:
-

I see now.

In that case, I think a new JIRA issue is required.
The original issue was fixed so is complete.
Your proposal is to improve the locking behaviour, so should be filed as an 
enhancement please.

> Tailer locks file from deletion/rename on Windows
> -
>
> Key: IO-269
> URL: https://issues.apache.org/jira/browse/IO-269
> Project: Commons IO
>  Issue Type: Bug
>Reporter: Sebb
> Fix For: 2.4
>
> Attachments: IO-269-v2.patch, IO-269-v3.patch, IO-269.patch, 
> ReOpen.java
>
>
> The Tailer code works on Windows, except that it locks the file against 
> deletion or rename.
> The test code fails to detect this, because it fails to check if the file 
> deletion succeeds.
> This seems to be a Windows OS issue.
> A possible solution might be to keep closing and re-opening the file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (IO-279) Tailer erroneously considers file as new

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/IO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920981#comment-13920981
 ] 

Sebb commented on IO-279:
-

bq. last = file.lastModified();

That change has already been made in trunk and will be in 2.5

> Tailer erroneously considers file as new
> 
>
> Key: IO-279
> URL: https://issues.apache.org/jira/browse/IO-279
> Project: Commons IO
>  Issue Type: Bug
>Affects Versions: 2.0.1, 2.4
>Reporter: Sergio Bossa
> Attachments: IO-279.patch, disable_resetting.patch, fix-tailer.patch, 
> modify-test-fixed.patch, modify-test.patch
>
>
> Tailer sometimes erroneously considers the tailed file as new, forcing a 
> repositioning at the start of the file: I'm still unable to reproduce this in 
> a test case, because it only happens to me with huge log files during Apache 
> Tomcat startup.
> This is the piece of code causing the problem:
> {code}
> // See if the file needs to be read again
> if (length > position) {
> // The file has more content than it did last time
> last = System.currentTimeMillis();
> position = readLines(reader);
> } else if (FileUtils.isFileNewer(file, last)) {
> /* This can happen if the file is truncated or overwritten
> * with the exact same length of information. In cases like
> * this, the file position needs to be reset
> */
> position = 0;
> reader.seek(position); // cannot be null here
> // Now we can read new lines
> last = System.currentTimeMillis();
> position = readLines(reader);
> }
> {code}
> What probably happens is that the new file content is about to be written on 
> disk, the date is already updated but content is still not flushed, so actual 
> length is untouched and there you go.
> In other words, I think there should be some better method to verify the 
> condition above, rather than relying only on dates: keeping and comparing the 
> hash code of the latest line may be a solution, but may hurt performances ... 
> other ideas?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (NET-516) parser problem occurs if the filename contains one or more characters of which the second byte of Shift-JIS code is 0x85

2014-03-05 Thread Sebb (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb updated NET-516:
-

Fix Version/s: (was: 2.0)

> parser problem occurs if the filename contains one or more characters of 
> which the second byte of Shift-JIS code is 0x85
> 
>
> Key: NET-516
> URL: https://issues.apache.org/jira/browse/NET-516
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.0
> Environment: windows
>Reporter: Asha K S
> Attachments: FTPSample.java, FTPTestSample.java, IIS FTP Files.zip, 
> listfilesStreamBytes.txt, notworking.png, working.png
>
>
> Problem occurs if the filename contains one or more characters of which the 
> second byte of Shift-JIS code is 0x85, on a windows Japanese machine when 
> listing file names from IIS FTP server.
> This was working fine in commons-net-1.4.0.jar . 
> [This relates to the NTFTPEntryParser]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1105) Least squares statistical data editing

2014-03-05 Thread Phil Steitz (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921040#comment-13921040
 ] 

Phil Steitz commented on MATH-1105:
---

Any way I can talk you guys into not trying to use JIRA as a discussion forum?  
That is what the ML is for.

> Least squares statistical data editing
> --
>
> Key: MATH-1105
> URL: https://issues.apache.org/jira/browse/MATH-1105
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Evan Ward
> Attachments: 0001-Add-statistical-editing-capability.patch, 
> 0002-Integrate-data-editing-with-the-LS-framework.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (NET-516) parser problem occurs if the filename contains one or more characters of which the second byte of Shift-JIS code is 0x85

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921046#comment-13921046
 ] 

Sebb commented on NET-516:
--

Fixed for the NT code

URL: http://svn.apache.org/r1574571
Log:
NET-516 parser problem occurs if the filename contains one or more characters 
of which the second byte of Shift-JIS code is 0x85
Fix NT parser

Modified:
commons/proper/net/trunk/src/changes/changes.xml

commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java

commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryP

> parser problem occurs if the filename contains one or more characters of 
> which the second byte of Shift-JIS code is 0x85
> 
>
> Key: NET-516
> URL: https://issues.apache.org/jira/browse/NET-516
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.0
> Environment: windows
>Reporter: Asha K S
> Attachments: FTPSample.java, FTPTestSample.java, IIS FTP Files.zip, 
> listfilesStreamBytes.txt, notworking.png, working.png
>
>
> Problem occurs if the filename contains one or more characters of which the 
> second byte of Shift-JIS code is 0x85, on a windows Japanese machine when 
> listing file names from IIS FTP server.
> This was working fine in commons-net-1.4.0.jar . 
> [This relates to the NTFTPEntryParser]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (NET-516) parser problem occurs if the filename contains one or more characters of which the second byte of Shift-JIS code is 0x85

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921046#comment-13921046
 ] 

Sebb edited comment on NET-516 at 3/5/14 5:01 PM:
--

Fixed for the NT code

URL: http://svn.apache.org/r1574571
Log:
NET-516 parser problem occurs if the filename contains one or more characters 
of which the second byte of Shift-JIS code is 0x85
Fix NT parser

Modified:
commons/proper/net/trunk/src/changes/changes.xml

commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
   
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryParserTest.java


was (Author: s...@apache.org):
Fixed for the NT code

URL: http://svn.apache.org/r1574571
Log:
NET-516 parser problem occurs if the filename contains one or more characters 
of which the second byte of Shift-JIS code is 0x85
Fix NT parser

Modified:
commons/proper/net/trunk/src/changes/changes.xml

commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java

commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/NTFTPEntryP

> parser problem occurs if the filename contains one or more characters of 
> which the second byte of Shift-JIS code is 0x85
> 
>
> Key: NET-516
> URL: https://issues.apache.org/jira/browse/NET-516
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.0
> Environment: windows
>Reporter: Asha K S
> Attachments: FTPSample.java, FTPTestSample.java, IIS FTP Files.zip, 
> listfilesStreamBytes.txt, notworking.png, working.png
>
>
> Problem occurs if the filename contains one or more characters of which the 
> second byte of Shift-JIS code is 0x85, on a windows Japanese machine when 
> listing file names from IIS FTP server.
> This was working fine in commons-net-1.4.0.jar . 
> [This relates to the NTFTPEntryParser]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (NET-516) parser problem occurs if the filename contains one or more characters of which the second byte of Shift-JIS code is 0x85

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921069#comment-13921069
 ] 

Sebb commented on NET-516:
--

The current snapshot release includes the changes if you want to try that.

> parser problem occurs if the filename contains one or more characters of 
> which the second byte of Shift-JIS code is 0x85
> 
>
> Key: NET-516
> URL: https://issues.apache.org/jira/browse/NET-516
> Project: Commons Net
>  Issue Type: Bug
>  Components: FTP
>Affects Versions: 2.0
> Environment: windows
>Reporter: Asha K S
> Attachments: FTPSample.java, FTPTestSample.java, IIS FTP Files.zip, 
> listfilesStreamBytes.txt, notworking.png, working.png
>
>
> Problem occurs if the filename contains one or more characters of which the 
> second byte of Shift-JIS code is 0x85, on a windows Japanese machine when 
> listing file names from IIS FTP server.
> This was working fine in commons-net-1.4.0.jar . 
> [This relates to the NTFTPEntryParser]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread jason mathews (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jason mathews updated NET-527:
--

Fix Version/s: 3.4

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Fix For: 3.4
>
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTPClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread jason mathews (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jason mathews updated NET-527:
--

Description: 
I've implemented a minimal NTP server that doesn't actually adjust the time but 
responds to NTP datagram requests with info filled out using the current clock 
time to be be used for debugging and testing. At minimum it can be used as a 
test harness to test the NTP client implementations such as the NtpClient 
class. Added appropriate junit test.

The SimpleNTPServer can run from any local port to prevent from interfering 
with the actual NTP service on port 123.

The SimpleNTPServer class complements the existing NtpClient class.

Implementation and test provided in attached patch file.

  was:
I've implemented a minimal NTP server that doesn't actually adjust the time but 
responds to NTP datagram requests with info filled out using the current clock 
time to be be used for debugging and testing. At minimum it can be used as a 
test harness to test the NTPClient class. Added appropriate junit test.

The SimpleNTPServer can run from any local port to prevent from interfering 
with the actual NTP service on port 123.

The SimpleNTPServer class complements the existing NtpClient class.

Implementation and test provided in attached patch file.


> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Fix For: 3.4
>
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread Sebb (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb updated NET-527:
-

Fix Version/s: (was: 3.4)

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921139#comment-13921139
 ] 

Sebb commented on NET-527:
--

There have been lots of changes to this issue. 
Have you finished making changes yet?

By the way, we use the Fix issue to document which release has got the code in 
it, so please leave it blank.

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread jason mathews (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921188#comment-13921188
 ] 

jason mathews commented on NET-527:
---

All changes are finished.

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread jason mathews (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921188#comment-13921188
 ] 

jason mathews edited comment on NET-527 at 3/5/14 6:44 PM:
---

All changes are finished and patch is ready to use.


was (Author: docjason):
All changes are finished.

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread jason mathews (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921188#comment-13921188
 ] 

jason mathews edited comment on NET-527 at 3/5/14 6:45 PM:
---

Didn't see any comments on the original submission so when ahead and kept 
making minor tweaks and cleanup, added comments, etc.

All changes are finished and patch is ready to use.


was (Author: docjason):
All changes are finished and patch is ready to use.

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921247#comment-13921247
 ] 

Sebb commented on NET-527:
--

Code looks OK generally.
However @author tags are discouraged; we use credits in the changes history 
and/or pom.xml instead.
Is it OK for me to remove the one in the test class?

Also, I'm not sure the NTP server belongs in the main code. I think it would be 
better in the test code tree.

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (VFS-515) AbstractFileObject.getURL() returns flaky URL object

2014-03-05 Thread Shon Vella (JIRA)
Shon Vella created VFS-515:
--

 Summary: AbstractFileObject.getURL() returns flaky URL object
 Key: VFS-515
 URL: https://issues.apache.org/jira/browse/VFS-515
 Project: Commons VFS
  Issue Type: Bug
Affects Versions: 2.0, 2.1
 Environment: OSX 10.9.2
java version "1.7.0_45"
Java(TM) SE Runtime Environment (build 1.7.0_45-b18)
Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode)
Reporter: Shon Vella


URL returned is created with constructor that expects host as a separate 
parameter from path and passes in empty string for host. As a result subsequent 
calls to url.getHost() returns an empty string rather than the host encoded in 
the path.

Test Code

FileSystemManager fsManager = VFS.getManager();
FileObject f = fsManager.resolveFile("ftp://localhost/etc/hosts";);
URL url = f.getURL();
String host = url.getHost();
assertEquals("localhost", host);




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1105) Least squares statistical data editing

2014-03-05 Thread Gilles (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921296#comment-13921296
 ] 

Gilles commented on MATH-1105:
--

Thanks for the reminder. ;)
I'm stating a point here to avoid having someone commit anything of the sort 
before it being agreed on the ML. How about that?


> Least squares statistical data editing
> --
>
> Key: MATH-1105
> URL: https://issues.apache.org/jira/browse/MATH-1105
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Evan Ward
> Attachments: 0001-Add-statistical-editing-capability.patch, 
> 0002-Integrate-data-editing-with-the-LS-framework.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread jason mathews (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921304#comment-13921304
 ] 

jason mathews commented on NET-527:
---

Go ahead remove @author tag.
Okay to move main class to package org.apache.commons.net.ntp in test tree.

If anyone needs it they can add test jar to their classpath.

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (MATH-1105) Least squares statistical data editing

2014-03-05 Thread Phil Steitz (JIRA)

[ 
https://issues.apache.org/jira/browse/MATH-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921338#comment-13921338
 ] 

Phil Steitz commented on MATH-1105:
---

I think the discussion is good.  It is just easier to have it on the ML.  This 
is partly just personal preference - I use a thread-aware mail client and it is 
easier to actually talk to each other when threading and quoting happen 
automatically.

> Least squares statistical data editing
> --
>
> Key: MATH-1105
> URL: https://issues.apache.org/jira/browse/MATH-1105
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Evan Ward
> Attachments: 0001-Add-statistical-editing-capability.patch, 
> 0002-Integrate-data-editing-with-the-LS-framework.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (NET-527) Add SimpleNTPServer as example and for testing

2014-03-05 Thread Sebb (JIRA)

 [ 
https://issues.apache.org/jira/browse/NET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved NET-527.
--

   Resolution: Fixed
Fix Version/s: 3.4

Thanks very much!

I'd overlooked that the server  was under the examples package rather than in 
the main code; I think it's fine there so I left it alone.

URL: http://svn.apache.org/r1574646
Log:
NET-527 Add SimpleNTPServer as example and for testing

Added:
commons/proper/net/trunk/src/main/java/examples/ntp/SimpleNTPServer.java   
(with props)

commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java
   (with props)
Modified:
commons/proper/net/trunk/src/changes/changes.xml

> Add SimpleNTPServer as example and for testing
> --
>
> Key: NET-527
> URL: https://issues.apache.org/jira/browse/NET-527
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.3
>Reporter: jason mathews
>  Labels: ntp
> Fix For: 3.4
>
> Attachments: ntpServer.patch.txt
>
>
> I've implemented a minimal NTP server that doesn't actually adjust the time 
> but responds to NTP datagram requests with info filled out using the current 
> clock time to be be used for debugging and testing. At minimum it can be used 
> as a test harness to test the NTP client implementations such as the 
> NtpClient class. Added appropriate junit test.
> The SimpleNTPServer can run from any local port to prevent from interfering 
> with the actual NTP service on port 123.
> The SimpleNTPServer class complements the existing NtpClient class.
> Implementation and test provided in attached patch file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)