[GitHub] commons-lang issue #249: Checkstyle for long literals
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/249 [](https://coveralls.io/builds/10437561) Coverage decreased (-0.007%) to 94.529% when pulling **380744a3ff0f8db9ea52260da90fbef825798407 on mureinik:long-checkstyle** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #250: LANG-1300: Convert CharSequence to String for int-m...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/250 [](https://coveralls.io/builds/10437855) Coverage decreased (-0.08%) to 94.455% when pulling **cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils
[
https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896133#comment-15896133
]
ASF GitHub Bot commented on LANG-1300:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/250
[](https://coveralls.io/builds/10437855)
Coverage decreased (-0.08%) to 94.455% when pulling
**cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into
**6597c196521af500feef7a02610727eafa7ec1dc on apache:master**.
> Clarify or improve behaviour of int-based methods in StringUtils
>
>
> Key: LANG-1300
> URL: https://issues.apache.org/jira/browse/LANG-1300
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.5
>Reporter: Duncan Jones
>Priority: Minor
> Fix For: Discussion
>
>
> The following methods use an {{int}} to represent a search character:
> {code:java}
> boolean contains(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar, final int startPos)
> int lastIndexOf(final CharSequence seq, final int searchChar)
> int lastIndexOf(final CharSequence seq, final int searchChar, final int
> startPos)
> {code}
> When I see an {{int}} representing a character, I tend to assume the method
> can handle supplementary characters. However, the current behaviour of these
> methods depends upon whether the {{CharSequence}} is a {{String}} or not.
> {code:java}
> StringBuilder builder = new StringBuilder();
> builder.appendCodePoint(0x2070E);
> System.out.println(StringUtils.lastIndexOf(builder, 0x2070E)); // -1
> System.out.println(StringUtils.lastIndexOf(builder.toString(), 0x2070E)); // 0
> {code}
> The Javadoc for these methods are ambiguous on this point, stating:
> {quote}
> This method uses {{String.lastIndexOf(int)}} if possible.
> {quote}
> I think we should consider updating the {{CharSequenceUtils}} methods used by
> this class to convert all {{CharSequence}} parameters to strings, enabling
> full code point support. The docs could be updated to make this crystal clear.
> There is a question of whether this breaks backwards compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] commons-lang issue #250: LANG-1300: Convert CharSequence to String for int-m...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/250 [](https://coveralls.io/builds/10437975) Coverage decreased (-0.05%) to 94.484% when pulling **cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #250: LANG-1300: Convert CharSequence to String for int-m...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/250 [](https://coveralls.io/builds/10437975) Coverage decreased (-0.05%) to 94.484% when pulling **cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils
[
https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896147#comment-15896147
]
ASF GitHub Bot commented on LANG-1300:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/250
[](https://coveralls.io/builds/10437975)
Coverage decreased (-0.05%) to 94.484% when pulling
**cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into
**6597c196521af500feef7a02610727eafa7ec1dc on apache:master**.
> Clarify or improve behaviour of int-based methods in StringUtils
>
>
> Key: LANG-1300
> URL: https://issues.apache.org/jira/browse/LANG-1300
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.5
>Reporter: Duncan Jones
>Priority: Minor
> Fix For: Discussion
>
>
> The following methods use an {{int}} to represent a search character:
> {code:java}
> boolean contains(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar, final int startPos)
> int lastIndexOf(final CharSequence seq, final int searchChar)
> int lastIndexOf(final CharSequence seq, final int searchChar, final int
> startPos)
> {code}
> When I see an {{int}} representing a character, I tend to assume the method
> can handle supplementary characters. However, the current behaviour of these
> methods depends upon whether the {{CharSequence}} is a {{String}} or not.
> {code:java}
> StringBuilder builder = new StringBuilder();
> builder.appendCodePoint(0x2070E);
> System.out.println(StringUtils.lastIndexOf(builder, 0x2070E)); // -1
> System.out.println(StringUtils.lastIndexOf(builder.toString(), 0x2070E)); // 0
> {code}
> The Javadoc for these methods are ambiguous on this point, stating:
> {quote}
> This method uses {{String.lastIndexOf(int)}} if possible.
> {quote}
> I think we should consider updating the {{CharSequenceUtils}} methods used by
> this class to convert all {{CharSequence}} parameters to strings, enabling
> full code point support. The docs could be updated to make this crystal clear.
> There is a question of whether this breaks backwards compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils
[
https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896146#comment-15896146
]
ASF GitHub Bot commented on LANG-1300:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/250
[](https://coveralls.io/builds/10437975)
Coverage decreased (-0.05%) to 94.484% when pulling
**cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into
**6597c196521af500feef7a02610727eafa7ec1dc on apache:master**.
> Clarify or improve behaviour of int-based methods in StringUtils
>
>
> Key: LANG-1300
> URL: https://issues.apache.org/jira/browse/LANG-1300
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.5
>Reporter: Duncan Jones
>Priority: Minor
> Fix For: Discussion
>
>
> The following methods use an {{int}} to represent a search character:
> {code:java}
> boolean contains(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar, final int startPos)
> int lastIndexOf(final CharSequence seq, final int searchChar)
> int lastIndexOf(final CharSequence seq, final int searchChar, final int
> startPos)
> {code}
> When I see an {{int}} representing a character, I tend to assume the method
> can handle supplementary characters. However, the current behaviour of these
> methods depends upon whether the {{CharSequence}} is a {{String}} or not.
> {code:java}
> StringBuilder builder = new StringBuilder();
> builder.appendCodePoint(0x2070E);
> System.out.println(StringUtils.lastIndexOf(builder, 0x2070E)); // -1
> System.out.println(StringUtils.lastIndexOf(builder.toString(), 0x2070E)); // 0
> {code}
> The Javadoc for these methods are ambiguous on this point, stating:
> {quote}
> This method uses {{String.lastIndexOf(int)}} if possible.
> {quote}
> I think we should consider updating the {{CharSequenceUtils}} methods used by
> this class to convert all {{CharSequence}} parameters to strings, enabling
> full code point support. The docs could be updated to make this crystal clear.
> There is a question of whether this breaks backwards compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] commons-lang issue #251: Lang1300: Change CharSequenceUtils to support suppl...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/251 [](https://coveralls.io/builds/10438021) Coverage increased (+0.01%) to 94.548% when pulling **721a6e59f7e4f5c0f3196d3eb0e81cab5e41d065 on MarkDacek:Lang1300CharSequenceUtilsChange** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #251: Lang1300: Change CharSequenceUtils to support suppl...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/251 [](https://coveralls.io/builds/10438071) Coverage increased (+0.01%) to 94.548% when pulling **721a6e59f7e4f5c0f3196d3eb0e81cab5e41d065 on MarkDacek:Lang1300CharSequenceUtilsChange** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #249: Checkstyle for long literals
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/249 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (LANG-1314) javadoc creation broken with Java 8
Allon Mureinik created LANG-1314:
Summary: javadoc creation broken with Java 8
Key: LANG-1314
URL: https://issues.apache.org/jira/browse/LANG-1314
Project: Commons Lang
Issue Type: Bug
Components: General
Environment: amureini@mureinik ~ $ mvn -version
Apache Maven 3.3.9 (NON-CANONICAL_2016-07-01T11:53:38Z_mockbuild;
2016-07-01T14:53:38+03:00)
Maven home: /usr/share/maven
Java version: 1.8.0_121, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.12-200.fc25.x86_64", arch: "amd64", family:
"unix"
Reporter: Allon Mureinik
Priority: Minor
Java 8's javadoc seems to be stricter than the Java 7 one. With the current
HEAD (commit e5ed4ff), mvn javadoc:javadoc passes with Java 7, but fails on the
same machine with Java 8 (environment described above) with the following
errors:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:javadoc (default-cli) on
project commons-lang3: An error has occurred in JavaDocs report generation:
[ERROR] Exit code: 1 -
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/ArrayUtils.java:8421:
warning: no @param for
[ERROR] public static T[] insert(final int index, final T[] array, final
T... values) {
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:370:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:370:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:403:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:403:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:436:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:436:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:1946:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:1946:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:7092:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:7092:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:7241:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[ERROR]
/home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:7241:
error: unexpected end tag:
[ERROR] * Whitespace is defined by {@link Character#isWhitespace(char)}.
[ERROR] ^
[GitHub] commons-lang pull request #252: [LANG-1314] Fix javadoc creation on with Jav...
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/252
[LANG-1314] Fix javadoc creation on with Java 8
Java 8's javadoc seems to be stricter than Java 7's, and the current head
current fails to generate javadoc (`mvn javadoc:javadoc`) with Java 8.
This PR contains a series of fixes to the various classes' javadoc which
are required for Java 8 (but would also improve the javadoc generated with
earlier java versions) and then adds the `javadoc:javadoc` target to Travis CI
so we can guarantee it won't break again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang javadoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
commit 972d29447d115224674154e0150d51bf9ccf6524
Author: Allon Mureinik
Date: 2017-03-05T09:50:34Z
Add @param for in ArrayUtils#insert
commit e4147a700f6c49b954a6f91dc8f2f1499777e92c
Author: Allon Mureinik
Date: 2017-03-05T09:53:33Z
Fix StirngUtils tags in javadoc
The paragraph
Whitespace is defined by {@link Character#isWhitespace(char)}.
appears in several places in the javadoc (presumably, copy-pasted from
the original one to the others). This is obviously a mistake, as a
paragraph should start with , not with .
This patch fixes all the occurrences of this paragraph to the proper
form:
Whitespace is defined by {@link Character#isWhitespace(char)}.
commit 54eff5e8a55f591c1ae3fe31fd04dce663bbe4e1
Author: Allon Mureinik
Date: 2017-03-05T09:56:05Z
Remove tag from Computable's javadoc
The standard javadoc doclet does not allow self closing tags (such as
). This patch removes such a tag from Computable's javadoc, as it's
redundant anyway, as it's only used to create spaces between two
existing paragraphs.
commit 632431f9433ce228407218dabef7b00fa8464ef4
Author: Allon Mureinik
Date: 2017-03-05T16:03:01Z
Add javadoc creation to Travis CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (LANG-1314) javadoc creation broken with Java 8
[
https://issues.apache.org/jira/browse/LANG-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896374#comment-15896374
]
ASF GitHub Bot commented on LANG-1314:
--
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/252
[LANG-1314] Fix javadoc creation on with Java 8
Java 8's javadoc seems to be stricter than Java 7's, and the current head
current fails to generate javadoc (`mvn javadoc:javadoc`) with Java 8.
This PR contains a series of fixes to the various classes' javadoc which
are required for Java 8 (but would also improve the javadoc generated with
earlier java versions) and then adds the `javadoc:javadoc` target to Travis CI
so we can guarantee it won't break again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang javadoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
commit 972d29447d115224674154e0150d51bf9ccf6524
Author: Allon Mureinik
Date: 2017-03-05T09:50:34Z
Add @param for in ArrayUtils#insert
commit e4147a700f6c49b954a6f91dc8f2f1499777e92c
Author: Allon Mureinik
Date: 2017-03-05T09:53:33Z
Fix StirngUtils tags in javadoc
The paragraph
Whitespace is defined by {@link Character#isWhitespace(char)}.
appears in several places in the javadoc (presumably, copy-pasted from
the original one to the others). This is obviously a mistake, as a
paragraph should start with , not with .
This patch fixes all the occurrences of this paragraph to the proper
form:
Whitespace is defined by {@link Character#isWhitespace(char)}.
commit 54eff5e8a55f591c1ae3fe31fd04dce663bbe4e1
Author: Allon Mureinik
Date: 2017-03-05T09:56:05Z
Remove tag from Computable's javadoc
The standard javadoc doclet does not allow self closing tags (such as
). This patch removes such a tag from Computable's javadoc, as it's
redundant anyway, as it's only used to create spaces between two
existing paragraphs.
commit 632431f9433ce228407218dabef7b00fa8464ef4
Author: Allon Mureinik
Date: 2017-03-05T16:03:01Z
Add javadoc creation to Travis CI
> javadoc creation broken with Java 8
> ---
>
> Key: LANG-1314
> URL: https://issues.apache.org/jira/browse/LANG-1314
> Project: Commons Lang
> Issue Type: Bug
> Components: General
> Environment: amureini@mureinik ~ $ mvn -version
> Apache Maven 3.3.9 (NON-CANONICAL_2016-07-01T11:53:38Z_mockbuild;
> 2016-07-01T14:53:38+03:00)
> Maven home: /usr/share/maven
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.12-200.fc25.x86_64", arch: "amd64", family:
> "unix"
>Reporter: Allon Mureinik
>Priority: Minor
>
> Java 8's javadoc seems to be stricter than the Java 7 one. With the current
> HEAD (commit e5ed4ff), mvn javadoc:javadoc passes with Java 7, but fails on
> the same machine with Java 8 (environment described above) with the following
> errors:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:javadoc (default-cli) on
> project commons-lang3: An error has occurred in JavaDocs report generation:
> [ERROR] Exit code: 1 -
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/ArrayUtils.java:8421:
> warning: no @param for
> [ERROR] public static T[] insert(final int index, final T[] array, final
> T... values) {
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang
[GitHub] commons-lang issue #252: [LANG-1314] Fix javadoc creation on with Java 8
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/252 [](https://coveralls.io/builds/10440062) Coverage decreased (-0.007%) to 94.529% when pulling **632431f9433ce228407218dabef7b00fa8464ef4 on mureinik:javadoc** into **e5ed4ffe5df9bd5fe796e95acf0b35f4c858e1a2 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LANG-1314) javadoc creation broken with Java 8
[
https://issues.apache.org/jira/browse/LANG-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896375#comment-15896375
]
ASF GitHub Bot commented on LANG-1314:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/252
[](https://coveralls.io/builds/10440062)
Coverage decreased (-0.007%) to 94.529% when pulling
**632431f9433ce228407218dabef7b00fa8464ef4 on mureinik:javadoc** into
**e5ed4ffe5df9bd5fe796e95acf0b35f4c858e1a2 on apache:master**.
> javadoc creation broken with Java 8
> ---
>
> Key: LANG-1314
> URL: https://issues.apache.org/jira/browse/LANG-1314
> Project: Commons Lang
> Issue Type: Bug
> Components: General
> Environment: amureini@mureinik ~ $ mvn -version
> Apache Maven 3.3.9 (NON-CANONICAL_2016-07-01T11:53:38Z_mockbuild;
> 2016-07-01T14:53:38+03:00)
> Maven home: /usr/share/maven
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.12-200.fc25.x86_64", arch: "amd64", family:
> "unix"
>Reporter: Allon Mureinik
>Priority: Minor
>
> Java 8's javadoc seems to be stricter than the Java 7 one. With the current
> HEAD (commit e5ed4ff), mvn javadoc:javadoc passes with Java 7, but fails on
> the same machine with Java 8 (environment described above) with the following
> errors:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:javadoc (default-cli) on
> project commons-lang3: An error has occurred in JavaDocs report generation:
> [ERROR] Exit code: 1 -
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/ArrayUtils.java:8421:
> warning: no @param for
> [ERROR] public static T[] insert(final int index, final T[] array, final
> T... values) {
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:370:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:370:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:403:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:403:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:436:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:436:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:1946:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:1946:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/mai
[GitHub] commons-lang issue #252: [LANG-1314] Fix javadoc creation on with Java 8
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/252 [](https://coveralls.io/builds/10440200) Coverage decreased (-0.007%) to 94.529% when pulling **ac5584040440fc426dea4bf046ccd80973066df8 on mureinik:javadoc** into **e5ed4ffe5df9bd5fe796e95acf0b35f4c858e1a2 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LANG-1314) javadoc creation broken with Java 8
[
https://issues.apache.org/jira/browse/LANG-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896389#comment-15896389
]
ASF GitHub Bot commented on LANG-1314:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/252
[](https://coveralls.io/builds/10440200)
Coverage decreased (-0.007%) to 94.529% when pulling
**ac5584040440fc426dea4bf046ccd80973066df8 on mureinik:javadoc** into
**e5ed4ffe5df9bd5fe796e95acf0b35f4c858e1a2 on apache:master**.
> javadoc creation broken with Java 8
> ---
>
> Key: LANG-1314
> URL: https://issues.apache.org/jira/browse/LANG-1314
> Project: Commons Lang
> Issue Type: Bug
> Components: General
> Environment: amureini@mureinik ~ $ mvn -version
> Apache Maven 3.3.9 (NON-CANONICAL_2016-07-01T11:53:38Z_mockbuild;
> 2016-07-01T14:53:38+03:00)
> Maven home: /usr/share/maven
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.12-200.fc25.x86_64", arch: "amd64", family:
> "unix"
>Reporter: Allon Mureinik
>Priority: Minor
>
> Java 8's javadoc seems to be stricter than the Java 7 one. With the current
> HEAD (commit e5ed4ff), mvn javadoc:javadoc passes with Java 7, but fails on
> the same machine with Java 8 (environment described above) with the following
> errors:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:javadoc (default-cli) on
> project commons-lang3: An error has occurred in JavaDocs report generation:
> [ERROR] Exit code: 1 -
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/ArrayUtils.java:8421:
> warning: no @param for
> [ERROR] public static T[] insert(final int index, final T[] array, final
> T... values) {
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:316:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:347:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:370:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:370:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:403:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:403:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:436:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:436:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:1946:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/main/java/org/apache/commons/lang3/StringUtils.java:1946:
> error: unexpected end tag:
> [ERROR] * Whitespace is defined by {@link
> Character#isWhitespace(char)}.
> [ERROR] ^
> [ERROR]
> /home/amureini/src/git/commons-lang/src/mai
[GitHub] commons-lang issue #251: LANG-1300: Change CharSequenceUtils to support supp...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/251 [](https://coveralls.io/builds/10444575) Coverage increased (+0.01%) to 94.548% when pulling **c7c424fb9c3a39b6ea036242e44cdca324f7d104 on MarkDacek:Lang1300CharSequenceUtilsChange** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (LANG-1300) Clarify or improve behaviour of int-based methods in StringUtils
[
https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896654#comment-15896654
]
ASF GitHub Bot commented on LANG-1300:
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/251
[](https://coveralls.io/builds/10444575)
Coverage increased (+0.01%) to 94.548% when pulling
**c7c424fb9c3a39b6ea036242e44cdca324f7d104 on
MarkDacek:Lang1300CharSequenceUtilsChange** into
**6597c196521af500feef7a02610727eafa7ec1dc on apache:master**.
> Clarify or improve behaviour of int-based methods in StringUtils
>
>
> Key: LANG-1300
> URL: https://issues.apache.org/jira/browse/LANG-1300
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Affects Versions: 3.5
>Reporter: Duncan Jones
>Priority: Minor
> Fix For: Discussion
>
>
> The following methods use an {{int}} to represent a search character:
> {code:java}
> boolean contains(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar, final int startPos)
> int lastIndexOf(final CharSequence seq, final int searchChar)
> int lastIndexOf(final CharSequence seq, final int searchChar, final int
> startPos)
> {code}
> When I see an {{int}} representing a character, I tend to assume the method
> can handle supplementary characters. However, the current behaviour of these
> methods depends upon whether the {{CharSequence}} is a {{String}} or not.
> {code:java}
> StringBuilder builder = new StringBuilder();
> builder.appendCodePoint(0x2070E);
> System.out.println(StringUtils.lastIndexOf(builder, 0x2070E)); // -1
> System.out.println(StringUtils.lastIndexOf(builder.toString(), 0x2070E)); // 0
> {code}
> The Javadoc for these methods are ambiguous on this point, stating:
> {quote}
> This method uses {{String.lastIndexOf(int)}} if possible.
> {quote}
> I think we should consider updating the {{CharSequenceUtils}} methods used by
> this class to convert all {{CharSequence}} parameters to strings, enabling
> full code point support. The docs could be updated to make this crystal clear.
> There is a question of whether this breaks backwards compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
