[jira] [Commented] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
[
https://issues.apache.org/jira/browse/COLLECTIONS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190806#comment-16190806
]
Bruno P. Kinoshita commented on COLLECTIONS-660:
Fixed in 9d4f2ba886b003980f2c37a4de7a3e6c3c701820, and changes.xml entry in
1d21a49c27d9eab8d02785a783fcfba387a3e8e1
> Uncomment test in AbstractMapTest regarding LRUMap equals
> -
>
> Key: COLLECTIONS-660
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.1
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.2
>
>
> AbstractMapTest has a [commented
> out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
> line, with a comment as follows:
> {quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
> causing concurrent modification exceptions.{quote}
> While working on another test failing on Windows, I believe I've found the
> why for that comment, and how to fix it. Just need to finish debugging
> another part, and find a good Internet connection to push the fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
[
https://issues.apache.org/jira/browse/COLLECTIONS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190799#comment-16190799
]
Bruno P. Kinoshita commented on COLLECTIONS-660:
Due to the order of the arguments of the assertEquals, we were calling
TreeMap#equals, which would create a normal iterator instead of calling
mapIterator().
> Uncomment test in AbstractMapTest regarding LRUMap equals
> -
>
> Key: COLLECTIONS-660
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.1
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.2
>
>
> AbstractMapTest has a [commented
> out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
> line, with a comment as follows:
> {quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
> causing concurrent modification exceptions.{quote}
> While working on another test failing on Windows, I believe I've found the
> why for that comment, and how to fix it. Just need to finish debugging
> another part, and find a good Internet connection to push the fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
[
https://issues.apache.org/jira/browse/COLLECTIONS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190799#comment-16190799
]
Bruno P. Kinoshita edited comment on COLLECTIONS-660 at 10/4/17 4:40 AM:
-
Due to the order of the arguments of the assertEquals, we were calling
TreeMap#equals, which would create a normal iterator instead of calling
mapIterator().
This would change the modCount in the parent, resulting finally in the
concurrent modification exception.
was (Author: kinow):
Due to the order of the arguments of the assertEquals, we were calling
TreeMap#equals, which would create a normal iterator instead of calling
mapIterator().
> Uncomment test in AbstractMapTest regarding LRUMap equals
> -
>
> Key: COLLECTIONS-660
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.1
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.2
>
>
> AbstractMapTest has a [commented
> out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
> line, with a comment as follows:
> {quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
> causing concurrent modification exceptions.{quote}
> While working on another test failing on Windows, I believe I've found the
> why for that comment, and how to fix it. Just need to finish debugging
> another part, and find a good Internet connection to push the fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
[
https://issues.apache.org/jira/browse/COLLECTIONS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved COLLECTIONS-660.
Resolution: Fixed
> Uncomment test in AbstractMapTest regarding LRUMap equals
> -
>
> Key: COLLECTIONS-660
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.1
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.2
>
>
> AbstractMapTest has a [commented
> out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
> line, with a comment as follows:
> {quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
> causing concurrent modification exceptions.{quote}
> While working on another test failing on Windows, I believe I've found the
> why for that comment, and how to fix it. Just need to finish debugging
> another part, and find a good Internet connection to push the fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RNG-37) Ziggurat algorithm
[ https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190708#comment-16190708 ] OlgaK commented on RNG-37: -- Hi [~erans], I've made the changes as you requested. Regarding the performance, I've added a test into your tests suite, just that, I'm not an inventor of the algorithm, so rely on words of the authors. > Ziggurat algorithm > -- > > Key: RNG-37 > URL: https://issues.apache.org/jira/browse/RNG-37 > Project: Commons RNG > Issue Type: Wish >Reporter: Gilles >Priority: Minor > > Fast algorithm for sampling a Gaussian distribution: > https://en.wikipedia.org/wiki/Ziggurat_algorithm -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (COLLECTIONS-661) Intermittent test failures in Windows for HashSetValuedHashMap
[
https://issues.apache.org/jira/browse/COLLECTIONS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190118#comment-16190118
]
Gary Gregory commented on COLLECTIONS-661:
--
Could this be related to this note in {{Object.hashCode(Object)}}:
{code:java}
* It is not required that if two objects are unequal
* according to the {@link java.lang.Object#equals(java.lang.Object)}
* method, then calling the {@code hashCode} method on each of the
* two objects must produce distinct integer results. However, the
* programmer should be aware that producing distinct integer results
* for unequal objects may improve the performance of hash tables.
{code}
> Intermittent test failures in Windows for HashSetValuedHashMap
> --
>
> Key: COLLECTIONS-661
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-661
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.1
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
> Fix For: 4.2
>
>
> The collection HashSetValuedHashMap was added in 4.1. On Windows, test
> failures are not so common on JVM 8. But on Linux they are harder to happen
> (but still do [1], [2]).
> When using Windows and JVM 8, running tests on Eclipse, or Maven fail. But
> debugging on Windows with Eclipse sometimes work. Indicating it may be due to
> a concurrency issue, where debugging adds some extra time hiding the real
> issue.
> I have a few ideas of where/why it could be happening, but am without a
> Windows box for a few days as I'm travelling. I'm reading the codebase in the
> meantime, but if anybody feels like working on it, feel free to chime in and
> suggest a fix/patch.
> [1] https://travis-ci.org/apache/commons-collections/jobs/282169803
> [2] http://markmail.org/thread/exwm7ggjtxzbtlkd
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (BCEL-294) Incorrect comment in StackMap.java
[
https://issues.apache.org/jira/browse/BCEL-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter resolved BCEL-294.
--
Resolution: Fixed
Assignee: Benedikt Ritter
Fix Version/s: 6.2
{code}
~/w/a/c/commons-bcel > svn ci -m "BCEL-294: Incorrect comment in StackMap.java.
Thanks to Mark Roberts"
Sendingsrc/changes/changes.xml
Sendingsrc/main/java/org/apache/bcel/classfile/StackMap.java
Transmitting file data ..done
Committing transaction...
Committed revision 1811017.
{code}
Thank you!
> Incorrect comment in StackMap.java
> --
>
> Key: BCEL-294
> URL: https://issues.apache.org/jira/browse/BCEL-294
> Project: Commons BCEL
> Issue Type: Improvement
> Components: Main
>Reporter: Mark Roberts
>Assignee: Benedikt Ritter
>Priority: Trivial
> Fix For: 6.2
>
>
> line number 79, comment for Dump method; should say "stack map" not "line
> number"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LANG-1034) Add support for recursive comparison to EqualsBuilder#reflectionEquals
[
https://issues.apache.org/jira/browse/LANG-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189837#comment-16189837
]
ASF GitHub Bot commented on LANG-1034:
--
Github user douddle commented on the issue:
https://github.com/apache/commons-lang/pull/202
I start to use your feature and I discover a bug.
String are now compared with internal data (hash and char[]). But sometimes
hash value is not initialized, this is probably a cache for the hashcode. So
the comparison fails even if the char[] content is the same.
> Add support for recursive comparison to EqualsBuilder#reflectionEquals
> --
>
> Key: LANG-1034
> URL: https://issues.apache.org/jira/browse/LANG-1034
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
>Reporter: Duncan Jones
>Assignee: Pascal Schumacher
> Fix For: 3.6
>
> Attachments: LANG-1034.1.patch
>
>
> The current implementation of {{EqualsBuilder.reflectionEquals()}} uses
> object equality to test reference fields found in the class. It may be
> helpful to offer a method that recursively builds {{.equals()}} methods for
> each field and uses that to perform the comparison.
> This functionality could be further extended by accepting a list of classes
> to include/exclude. Classes that are excluded would use the normal object
> equality.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Github user douddle commented on the issue: https://github.com/apache/commons-lang/pull/202 I start to use your feature and I discover a bug. String are now compared with internal data (hash and char[]). But sometimes hash value is not initialized, this is probably a cache for the hashcode. So the comparison fails even if the char[] content is the same. ---
[jira] [Commented] (RNG-37) Ziggurat algorithm
[
https://issues.apache.org/jira/browse/RNG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189554#comment-16189554
]
Gilles commented on RNG-37:
---
Hi Olga.
I've just quickly read through the proposed code; here are a few remarks:
* Please add a link (web page, paper, code) to the reference(s) which you used
for the implementation.
* Please follow the coding style (e.g. "space" around operators). Running "mvn
site" should produce a clean "CheckStyle" report.
* Magic numbers should be avoided; use a "static final" instance field instead.
* Constants should be declared "final".
* Reuse already computed values (cf. lines 56, 65, 71 and lines 102, 103, ...)
* Javadoc must be provided for all method and fields ("private" also).
Did you check the performance?
Thanks a lot for your interest in, and contribution to, the "Commons RNG"
project!
> Ziggurat algorithm
> --
>
> Key: RNG-37
> URL: https://issues.apache.org/jira/browse/RNG-37
> Project: Commons RNG
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
>
> Fast algorithm for sampling a Gaussian distribution:
> https://en.wikipedia.org/wiki/Ziggurat_algorithm
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (COLLECTIONS-661) Intermittent test failures in Windows for HashSetValuedHashMap
Bruno P. Kinoshita created COLLECTIONS-661: -- Summary: Intermittent test failures in Windows for HashSetValuedHashMap Key: COLLECTIONS-661 URL: https://issues.apache.org/jira/browse/COLLECTIONS-661 Project: Commons Collections Issue Type: Bug Components: Map Affects Versions: 4.1 Reporter: Bruno P. Kinoshita Assignee: Bruno P. Kinoshita Fix For: 4.2 The collection HashSetValuedHashMap was added in 4.1. On Windows, test failures are not so common on JVM 8. But on Linux they are harder to happen (but still do [1], [2]). When using Windows and JVM 8, running tests on Eclipse, or Maven fail. But debugging on Windows with Eclipse sometimes work. Indicating it may be due to a concurrency issue, where debugging adds some extra time hiding the real issue. I have a few ideas of where/why it could be happening, but am without a Windows box for a few days as I'm travelling. I'm reading the codebase in the meantime, but if anybody feels like working on it, feel free to chime in and suggest a fix/patch. [1] https://travis-ci.org/apache/commons-collections/jobs/282169803 [2] http://markmail.org/thread/exwm7ggjtxzbtlkd -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
[
https://issues.apache.org/jira/browse/COLLECTIONS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated COLLECTIONS-660:
---
Description:
AbstractMapTest has a [commented
out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
line, with a comment as follows:
{quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
causing concurrent modification exceptions.{quote}
While working on another test failing on Windows, I believe I've found the why
for that comment, and how to fix it. Just need to finish debugging another
part, and find a good Internet connection to push the fix.
was:
AbstractMapTest has a [commented
out](https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959)
line, with a comment as follows:
{quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
causing concurrent modification exceptions.{quote}
While working on another test failing on Windows, I believe I've found the why
for that comment, and how to fix it. Just need to finish debugging another
part, and find a good Internet connection to push the fix.
> Uncomment test in AbstractMapTest regarding LRUMap equals
> -
>
> Key: COLLECTIONS-660
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.1
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.2
>
>
> AbstractMapTest has a [commented
> out|https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959]
> line, with a comment as follows:
> {quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
> causing concurrent modification exceptions.{quote}
> While working on another test failing on Windows, I believe I've found the
> why for that comment, and how to fix it. Just need to finish debugging
> another part, and find a good Internet connection to push the fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (COLLECTIONS-660) Uncomment test in AbstractMapTest regarding LRUMap equals
Bruno P. Kinoshita created COLLECTIONS-660:
--
Summary: Uncomment test in AbstractMapTest regarding LRUMap equals
Key: COLLECTIONS-660
URL: https://issues.apache.org/jira/browse/COLLECTIONS-660
Project: Commons Collections
Issue Type: Bug
Components: Map
Affects Versions: 4.1
Reporter: Bruno P. Kinoshita
Assignee: Bruno P. Kinoshita
Priority: Minor
Fix For: 4.2
AbstractMapTest has a [commented
out](https://github.com/apache/commons-collections/blob/c8bdf60d1d0be609094e14054be0b9af0fb05521/src/test/java/org/apache/commons/collections4/map/AbstractMapTest.java#L1959)
line, with a comment as follows:
{quote}his fails for LRUMap because confirmed.equals() somehow modifies map,
causing concurrent modification exceptions.{quote}
While working on another test failing on Windows, I believe I've found the why
for that comment, and how to fix it. Just need to finish debugging another
part, and find a good Internet connection to push the fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
