[jira] [Commented] (IMAGING-218) PNG package code bloated
[ https://issues.apache.org/jira/browse/IMAGING-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704273#comment-16704273 ] ASF GitHub Bot commented on IMAGING-218: Github user SukantPal commented on the issue: https://github.com/apache/commons-imaging/pull/38 This is the ASF JIRA issue related to this improvement: https://issues.apache.org/jira/projects/IMAGING/issues/IMAGING-218?filter=allopenissues=priority+DESC%2C+updated+DESC. > PNG package code bloated > > > Key: IMAGING-218 > URL: https://issues.apache.org/jira/browse/IMAGING-218 > Project: Commons Imaging > Issue Type: Bug > Components: Format: PNG >Affects Versions: 1.x >Reporter: Shukant Kumar Pal >Priority: Major > Fix For: 1.x > > > The PNG component is really really bloated, and code is written for the same > thing twice sometimes. For example, the formats.png package uses the > `PngWriter` class which internally replicates the features that should > actually be contained within formats.png.chunk Chunk classes (like > PngWriter.ImageHeader which is just a PNG chunk representation, and can be > eliminated by modified Chunk and PngChunkIhdr). > The file format classes can be modified to reduce the code size significantly > and make it much more clear. I'll clean up the PNG code, but want the > interest of the project members. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IMAGING-218) PNG package code bloated
[ https://issues.apache.org/jira/browse/IMAGING-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704272#comment-16704272 ] Shukant Kumar Pal commented on IMAGING-218: --- I have done a pull request, check it out - [https://github.com/apache/commons-imaging/pull/38.] If you like it, I will fully clean the PNG component. I have created the ChunkLoader (formats.png.chunk.ChunkLoader) to offload the chunk loading process from PngImageParser. Also, I have removed PngWriter.ImageHeader and made PngChunkIhdr mutable. This allows creating a PngChunkIhdr with all the required fields, instead of creating the duplicate ImageHeader while creating a PNG image file. > PNG package code bloated > > > Key: IMAGING-218 > URL: https://issues.apache.org/jira/browse/IMAGING-218 > Project: Commons Imaging > Issue Type: Bug > Components: Format: PNG >Affects Versions: 1.x >Reporter: Shukant Kumar Pal >Priority: Major > Fix For: 1.x > > > The PNG component is really really bloated, and code is written for the same > thing twice sometimes. For example, the formats.png package uses the > `PngWriter` class which internally replicates the features that should > actually be contained within formats.png.chunk Chunk classes (like > PngWriter.ImageHeader which is just a PNG chunk representation, and can be > eliminated by modified Chunk and PngChunkIhdr). > The file format classes can be modified to reduce the code size significantly > and make it much more clear. I'll clean up the PNG code, but want the > interest of the project members. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704072#comment-16704072 ] Steve Bosman commented on NUMBERS-76: - Sorry about that, hopefully all fixed now. > Make "Quaternion" a ValJO > - > > Key: NUMBERS-76 > URL: https://issues.apache.org/jira/browse/NUMBERS-76 > Project: Commons Numbers > Issue Type: Sub-task > Components: quaternion >Reporter: Gilles >Priority: Major > Labels: API > Fix For: 1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RNG-65) Clirr reports errors
[
https://issues.apache.org/jira/browse/RNG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles resolved RNG-65.
---
Resolution: Cannot Reproduce
Fix Version/s: (was: 1.2)
Problem was due to a stale cache.
Under the "~/.m2" directory, deleting all "commons-rng"-related files fixed the
issue.
> Clirr reports errors
>
>
> Key: RNG-65
> URL: https://issues.apache.org/jira/browse/RNG-65
> Project: Commons RNG
> Issue Type: Task
> Components: sampling
>Reporter: Gilles
>Priority: Blocker
> Labels: compatibility
>
> Errors are reported although I don't think those classes were changed since
> v1.1 was released.
> * Error Removed org.apache.commons.rng.sampling.distribution.LogNormalSampler
> from the list of superclasses
> org.apache.commons.rng.sampling.distribution.BoxMullerLogNormalSampler
> -> LogNormalSampler was never a base class
> * Error Removed org.apache.commons.rng.sampling.distribution.SamplerBase from
> the list of superclasses
> org.apache.commons.rng.sampling.distribution.BoxMullerNormalizedGaussianSampler
> -> class still extends {{SamplerBase}}
> * Error Removed org.apache.commons.rng.sampling.distribution.SamplerBase from
> the list of superclasses
> org.apache.commons.rng.sampling.distribution.MarsagliaNormalizedGaussianSampler
> -> class still extends {{SamplerBase}}
> * Error Removed org.apache.commons.rng.sampling.distribution.SamplerBase from
> the list of superclasses
> org.apache.commons.rng.sampling.distribution.ZigguratNormalizedGaussianSampler
> -> class still extends {{SamplerBase}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (VFS-398) FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name
[
https://issues.apache.org/jira/browse/VFS-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Otto Fowler updated VFS-398:
Assignee: Otto Fowler
> FtpFileObject.getChildren() fails when a folder contains a file with a colon
> in the name
>
>
> Key: VFS-398
> URL: https://issues.apache.org/jira/browse/VFS-398
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: Connecting via FTP to a host running SunOS 5.10
>Reporter: Mark Leonard
>Assignee: Otto Fowler
>Priority: Blocker
>
> In line 767 of DefaultFileSystemManager.java the UriParser's extractScheme()
> method is called:
> String scheme = UriParser.extractScheme(buffer.toString());
> This code was added in revision 780730
> http://svn.apache.org/viewvc?view=revision=780730
> It is not clear to me why this change was made.
> For the FTP provider, buffer contains a plain file name (i.e. without a path
> and definitely not in URI form)
> A colon is a valid character for a file name.
> However a colon will be interpreted as a URI scheme name.
> This causes an exception when the resolved path is checked using
> AbstractFileName.checkName()
> Sample code:
> FileObject fo =
> VFS.getManager().resolveFile("ftp://user:pass@host/some/path/some.file;);
> fo.getParent().getChildren();
> If /some/path/ contains a child such as PREFIX:SUFFIX then an exception is
> thrown:
> Exception in thread "main" org.apache.commons.vfs2.FileSystemException:
> Invalid descendent file name "PREFIX:SUFFIX".
> at
> org.apache.commons.vfs2.impl.DefaultFileSystemManager.resolveName(DefaultFileSystemManager.java:791)
> at
> org.apache.commons.vfs2.provider.AbstractFileObject.getChildren(AbstractFileObject.java:710)
> at
> org.apache.commons.vfs2.provider.ftp.FtpFileObject.getChildren(FtpFileObject.java:420)
> Therefore calling code is unable to list the children of the specified folder.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IO-592) Modified FileUtilsDirectoryContainsTestCase File
[ https://issues.apache.org/jira/browse/IO-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703295#comment-16703295 ] ASF GitHub Bot commented on IO-592: --- GitHub user rerewww opened a pull request: https://github.com/apache/commons-io/pull/71 [IO-592] Modified FileUtilsDirectoryContainsTestCase File - Add directory is null test case in FileUtilsDirectoryContainsTestCase - The exception case has modified with meaningful verification please review thanks:) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rerewww/commons-io IO-592-directoryContains Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-io/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 545644c3e69c9d39d83f84b108f6007717c18bb6 Author: rerewww Date: 2018-11-29T14:49:20Z IO-592: Modified FileUtilsDirectoryContainsTestCase File - Add directory is null test case in FileUtilsDirectoryContainsTestCase - The exception case has modified with meaningful verification > Modified FileUtilsDirectoryContainsTestCase File > > > Key: IO-592 > URL: https://issues.apache.org/jira/browse/IO-592 > Project: Commons IO > Issue Type: Task > Components: Utilities >Reporter: sangwoo son >Priority: Minor > Fix For: 2.7 > > > * no test code for when directory is null in directoryContains method > * I think the validation phase of the test case that generates the exception > is not correct > send > I'll send pull request > please review > thanks :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (IO-592) Modified FileUtilsDirectoryContainsTestCase File
[ https://issues.apache.org/jira/browse/IO-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sangwoo son updated IO-592: --- Description: * no test code for when directory is null in directoryContains method * I think the validation phase of the test case that generates the exception is not correct send I'll send pull request please review thanks :) was: * no test code for when directory is null in directory method * I think the validation phase of the test case that generates the exception is not correct send I'll send pull request please review thanks :) > Modified FileUtilsDirectoryContainsTestCase File > > > Key: IO-592 > URL: https://issues.apache.org/jira/browse/IO-592 > Project: Commons IO > Issue Type: Task > Components: Utilities >Reporter: sangwoo son >Priority: Minor > Fix For: 2.7 > > > * no test code for when directory is null in directoryContains method > * I think the validation phase of the test case that generates the exception > is not correct > send > I'll send pull request > please review > thanks :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (IO-592) Modified FileUtilsDirectoryContainsTestCase File
[ https://issues.apache.org/jira/browse/IO-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sangwoo son updated IO-592: --- Description: * no test code for when directory is null in directory method * I think the validation phase of the test case that generates the exception is not correct send I'll send pull request please review thanks :) was: * no test code for when directory is null in directory method * I think the validation phase of the test case that generates the exception is not correct please review thanks :) > Modified FileUtilsDirectoryContainsTestCase File > > > Key: IO-592 > URL: https://issues.apache.org/jira/browse/IO-592 > Project: Commons IO > Issue Type: Task > Components: Utilities >Reporter: sangwoo son >Priority: Minor > Fix For: 2.7 > > > * no test code for when directory is null in directory method > * I think the validation phase of the test case that generates the exception > is not correct > send > I'll send pull request > please review > thanks :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IO-592) Modified FileUtilsDirectoryContainsTestCase File
sangwoo son created IO-592: -- Summary: Modified FileUtilsDirectoryContainsTestCase File Key: IO-592 URL: https://issues.apache.org/jira/browse/IO-592 Project: Commons IO Issue Type: Task Components: Utilities Reporter: sangwoo son Fix For: 2.7 * no test code for when directory is null in directory method * I think the validation phase of the test case that generates the exception is not correct please review thanks :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO
[
https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703131#comment-16703131
]
Gilles commented on NUMBERS-76:
---
Thanks a lot for your contribution.
However, CheckStyle reports several errors, which should be fixed before
committing the PR.
All reports are generated when building the site with this command:
{noformat}
$ mvn site site:stage
{noformat}
Then the site is in the top-level {{target/staging}} directory.
> Make "Quaternion" a ValJO
> -
>
> Key: NUMBERS-76
> URL: https://issues.apache.org/jira/browse/NUMBERS-76
> Project: Commons Numbers
> Issue Type: Sub-task
> Components: quaternion
>Reporter: Gilles
>Priority: Major
> Labels: API
> Fix For: 1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702874#comment-16702874 ] ASF GitHub Bot commented on NUMBERS-76: --- Github user coveralls commented on the issue: https://github.com/apache/commons-numbers/pull/17 [](https://coveralls.io/builds/20354285) Coverage decreased (-0.2%) to 78.642% when pulling **2f33d38d6ec5513ebbad44ffad237ebbc1ae9199 on stevebosman:master** into **447ced4cc9f53ed3dbf02588599c9797aabb1ea7 on apache:master**. > Make "Quaternion" a ValJO > - > > Key: NUMBERS-76 > URL: https://issues.apache.org/jira/browse/NUMBERS-76 > Project: Commons Numbers > Issue Type: Sub-task > Components: quaternion >Reporter: Gilles >Priority: Major > Labels: API > Fix For: 1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702873#comment-16702873 ] ASF GitHub Bot commented on NUMBERS-76: --- Github user coveralls commented on the issue: https://github.com/apache/commons-numbers/pull/17 [](https://coveralls.io/builds/20354285) Coverage decreased (-0.2%) to 78.642% when pulling **2f33d38d6ec5513ebbad44ffad237ebbc1ae9199 on stevebosman:master** into **447ced4cc9f53ed3dbf02588599c9797aabb1ea7 on apache:master**. > Make "Quaternion" a ValJO > - > > Key: NUMBERS-76 > URL: https://issues.apache.org/jira/browse/NUMBERS-76 > Project: Commons Numbers > Issue Type: Sub-task > Components: quaternion >Reporter: Gilles >Priority: Major > Labels: API > Fix For: 1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-76) Make "Quaternion" a ValJO
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702862#comment-16702862 ] ASF GitHub Bot commented on NUMBERS-76: --- GitHub user stevebosman opened a pull request: https://github.com/apache/commons-numbers/pull/17 NUMBERS-76 Make "Quaternion" a ValJO I've done the following * changed the constructors to private and added equivalent of methods. * added a parse method * altered equals so that (like Complex) it uses Double.equals - gets round an edge case where Quaternions with the equivalence of -0 and 0 discovered while adding tests for hashCode * added a divide by scalar method * added a norm2 (square of norm) method * added some additional unit tests so it should now have 100% coverage I have also emailed an ICLA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevebosman/commons-numbers master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-numbers/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 9c6f77801265abe079b4054c3c90d55e956ee7cd Author: Steve Bosman Date: 2018-11-28T23:15:01Z NUMBERS-76 Make "Quaternion" a VALJO commit 2f33d38d6ec5513ebbad44ffad237ebbc1ae9199 Author: Steve Bosman Date: 2018-11-28T23:23:57Z NUMBERS-76 Make "Quaternion" a VALJO - correct Javadoc > Make "Quaternion" a ValJO > - > > Key: NUMBERS-76 > URL: https://issues.apache.org/jira/browse/NUMBERS-76 > Project: Commons Numbers > Issue Type: Sub-task > Components: quaternion >Reporter: Gilles >Priority: Major > Labels: API > Fix For: 1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
