[jira] [Commented] (GEOMETRY-32) BSPTree Updates
[
https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769027#comment-16769027
]
Sven Rathgeber commented on GEOMETRY-32:
added pull request for adding isLeaf() and applying it.
> BSPTree Updates
> ---
>
> Key: GEOMETRY-32
> URL: https://issues.apache.org/jira/browse/GEOMETRY-32
> Project: Apache Commons Geometry
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following updates should be made to the BSPTree class:
> - add an {{isLeaf()}} method to replace all of the {{node.getCut() == null}}
> expressions
> - add unit tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEOMETRY-32) BSPTree Updates
[
https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEOMETRY-32:
---
Labels: pull-request-available (was: )
> BSPTree Updates
> ---
>
> Key: GEOMETRY-32
> URL: https://issues.apache.org/jira/browse/GEOMETRY-32
> Project: Apache Commons Geometry
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Labels: pull-request-available
>
> The following updates should be made to the BSPTree class:
> - add an {{isLeaf()}} method to replace all of the {{node.getCut() == null}}
> expressions
> - add unit tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] coveralls edited a comment on issue #406: DurationUtils - methods for rounding duration
coveralls edited a comment on issue #406: DurationUtils - methods for rounding duration URL: https://github.com/apache/commons-lang/pull/406#issuecomment-463850202 [](https://coveralls.io/builds/21655308) Coverage decreased (-0.03%) to 95.105% when pulling **1d0ed0a1a9703b003e9a6a3be2d32e75c7e3052b on asciborek:LANG_1407_duration_utils** into **75768ba2724e2bb1d9a7a450f882be7d9f806a57 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #406: DurationUtils - methods for rounding duration
coveralls commented on issue #406: DurationUtils - methods for rounding duration URL: https://github.com/apache/commons-lang/pull/406#issuecomment-463850202 [](https://coveralls.io/builds/21653546) Coverage decreased (-0.02%) to 95.119% when pulling **2cbfaf5ce9ce33d3908f7de937e030cbfad05af9 on asciborek:LANG_1407_duration_utils** into **75768ba2724e2bb1d9a7a450f882be7d9f806a57 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (NUMBERS-94) PlaneAngle normalize fails for very small numbers.
[
https://issues.apache.org/jira/browse/NUMBERS-94?focusedWorklogId=198954=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-198954
]
ASF GitHub Bot logged work on NUMBERS-94:
-
Author: ASF GitHub Bot
Created on: 14/Feb/19 21:36
Start Date: 14/Feb/19 21:36
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #30: NUMBERS-94:
PlaneAngle.normalize() fix for small numbers
URL: https://github.com/apache/commons-numbers/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 198954)
Time Spent: 0.5h (was: 20m)
> PlaneAngle normalize fails for very small numbers.
> --
>
> Key: NUMBERS-94
> URL: https://issues.apache.org/jira/browse/NUMBERS-94
> Project: Commons Numbers
> Issue Type: Bug
>Reporter: Matt Juntunen
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When the {{PlaneAngle.normalize()}} method is called to normalize between 0
> and 1 turns and is passed a very small number compared to the 1, then the
> method returns a number exactly equal to the angle upper bound. This breaks
> the API contract since the return value must be strictly less than the upper
> bound. Ex:
> {code:java}
> PlaneAngle angle = PlaneAngle.ofTurns(-1e-18);
> double normalized = angle.normalize(PlaneAngle.PI).toTurns();
> // normalized is equal to 1 but it should be 0 since 1 - 1e-18 = 1, which is
> equivalent to 0 in turns
> {code}
> Pull request: https://github.com/apache/commons-numbers/pull/30
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NET-642) using execPROT on FTPSClients with Proxy Settings removes Proxy Settings
[
https://issues.apache.org/jira/browse/NET-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768364#comment-16768364
]
Andreas Bisiach commented on NET-642:
-
I have the exact same issue using HTTP Proxy. The failing combination is HTTP
proxy + Local Passive Mode + execPROT = P
FTPSClient ftps;
Proxy proxy = *new* Proxy(Type.*_HTTP_*, *new* InetSocketAddress("",
));
ftps.setProxy(proxy);
ftps.execPROT("P");
ftps.enterLocalPassiveMode();
I could not make the mentioned work around work (adding explicit
System._setProperty_("socksProxyPort", "");
System._setProperty_("socksProxyHost" ,"");
Any suggested workaround?
> using execPROT on FTPSClients with Proxy Settings removes Proxy Settings
>
>
> Key: NET-642
> URL: https://issues.apache.org/jira/browse/NET-642
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 3.6
> Environment: Java 1.8.0_112
> Linux 64bit
>Reporter: Johannes Frank
>Priority: Critical
>
> In Reference to https://issues.apache.org/jira/browse/NET-578
> I'm trying to establish an FTPS Connection via a HTTP Proxy. The Control
> Connection is properly established, however the Moment I do execPROT the
> Proxy settings are resetted by call to setSocketFactory(new
> FTPSSocketFactory(context)); in FTPSClient.java:534.
> This causes FTPSClients with a call to execPROT to actually ignore the proxy
> settings and attempt to contact the FTPS Server directly for data connections.
> Since we are required to use PROT P this is currently blocking our feature
> for FTPS Connections via HTTP proxy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEOMETRY-43) Check unit test - line intersecting cube (line lies on a plane)
[ https://issues.apache.org/jira/browse/GEOMETRY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768161#comment-16768161 ] Sven Rathgeber commented on GEOMETRY-43: I added a pull request : [https://github.com/apache/commons-geometry/pull/28] getOffset should definitely not return -1 :) I would favour an Optional.empty, instead of an exception, since the behaviour is not really exceptional. It just makes no sense. It would also be more stream friendly. > Check unit test - line intersecting cube (line lies on a plane) > --- > > Key: GEOMETRY-43 > URL: https://issues.apache.org/jira/browse/GEOMETRY-43 > Project: Apache Commons Geometry > Issue Type: Task > Components: Euclidean 3D >Reporter: Sven Rathgeber >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Intersecting a cube with a Line (which lies on a plane) results in one > intersection only. > > Please check the pull request: > https://github.com/apache/commons-geometry/pull/23 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768091#comment-16768091
]
Benedikt Ritter commented on CLI-254:
-
[~elserj] I currently don't have time to fix this. Do you want to provide a
fix? Pushing a new CLI release has been on my list for ages...
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEOMETRY-43) Check unit test - line intersecting cube (line lies on a plane)
[
https://issues.apache.org/jira/browse/GEOMETRY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768058#comment-16768058
]
Gilles commented on GEOMETRY-43:
{{getOffset}} should throw an exception if the precondition test fails.
> Check unit test - line intersecting cube (line lies on a plane)
> ---
>
> Key: GEOMETRY-43
> URL: https://issues.apache.org/jira/browse/GEOMETRY-43
> Project: Apache Commons Geometry
> Issue Type: Task
> Components: Euclidean 3D
>Reporter: Sven Rathgeber
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Intersecting a cube with a Line (which lies on a plane) results in one
> intersection only.
>
> Please check the pull request:
> https://github.com/apache/commons-geometry/pull/23
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEOMETRY-43) Check unit test - line intersecting cube (line lies on a plane)
[
https://issues.apache.org/jira/browse/GEOMETRY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768036#comment-16768036
]
Sven Rathgeber commented on GEOMETRY-43:
[~mattjuntunen], thanks for working on this.
It works fine, for what I currently need. I find it a little counter-intuitive
to say a line lies on a plane and does not intersect.
I experimented with some helper methods to check this case more comfortably and
make it more explicit.
What do you think ?
{code:java}
// class Plane
/** Check, if the line is parallel to the instance.
* @param line line to check.
* @return true if the line is parallel to the instance, false otherwise.
*/
public boolean isParallel(Line line) {
final Vector3D direction = line.getDirection();
final double dot = w.dot(direction);
if (precision.eqZero(dot)) {
return true;
}
return false;
}
/** Returns the distance of the given line to the plane instance.
* Returns -1.0, if the line is not parallel to the plane instance
* @param line to calculate the distance to the plane instance
* @return the distance or -1.0, if the line is not parallel to the plane
instance.
*/
public double getOffset(Line line) {
if (!isParallel(line))
{
return -1.0;
}
return getOffset(line.getOrigin());
}
/**
* Checks if the line lies on the plane.
* @param line the line to check.
* @return true, if the line lies on the plane. That is: it is parallel to
the plane
* and the offset to the plane is 0.0
*/
public boolean isOnPlane(Line line) {
return precision.eqZero(getOffset(line));
}
{code}
> Check unit test - line intersecting cube (line lies on a plane)
> ---
>
> Key: GEOMETRY-43
> URL: https://issues.apache.org/jira/browse/GEOMETRY-43
> Project: Apache Commons Geometry
> Issue Type: Task
> Components: Euclidean 3D
>Reporter: Sven Rathgeber
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Intersecting a cube with a Line (which lies on a plane) results in one
> intersection only.
>
> Please check the pull request:
> https://github.com/apache/commons-geometry/pull/23
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
