[jira] [Comment Edited] (RNG-85) Middle Square Weyl Sequence generator
[ https://issues.apache.org/jira/browse/RNG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806367#comment-16806367 ] Lam Gia Thuan edited comment on RNG-85 at 4/1/19 3:57 AM: -- Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to you, for example, to review and get feedback first before officially submitting. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task? Thank you so much for your time and consideration. I hope now is not too late to ask. Happy Coding. was (Author: duckladydinh): Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to you, for example, to review and get feedback first before officially submitting. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task? Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. > Middle Square Weyl Sequence generator > - > > Key: RNG-85 > URL: https://issues.apache.org/jira/browse/RNG-85 > Project: Commons RNG > Issue Type: Sub-task > Components: core >Reporter: Gilles >Priority: Minor > Labels: gsoc2019 > > https://en.wikipedia.org/wiki/Middle_square_method#Middle_Square_Weyl_Sequence_PRNG -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (RNG-85) Middle Square Weyl Sequence generator
[ https://issues.apache.org/jira/browse/RNG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806367#comment-16806367 ] Lam Gia Thuan edited comment on RNG-85 at 4/1/19 3:56 AM: -- Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to you, for example, to review and get feedback first before officially submitting. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task? Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. was (Author: duckladydinh): Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to you, for example, to review and get feedback first before officially submitting. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task. Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. > Middle Square Weyl Sequence generator > - > > Key: RNG-85 > URL: https://issues.apache.org/jira/browse/RNG-85 > Project: Commons RNG > Issue Type: Sub-task > Components: core >Reporter: Gilles >Priority: Minor > Labels: gsoc2019 > > https://en.wikipedia.org/wiki/Middle_square_method#Middle_Square_Weyl_Sequence_PRNG -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (RNG-85) Middle Square Weyl Sequence generator
[ https://issues.apache.org/jira/browse/RNG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806367#comment-16806367 ] Lam Gia Thuan edited comment on RNG-85 at 4/1/19 3:54 AM: -- Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to you, for example, to review and get feedback first before officially submitting. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task. Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. was (Author: duckladydinh): Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to someone, like you, for example, to review and get feedback first before officially sending. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task. Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. > Middle Square Weyl Sequence generator > - > > Key: RNG-85 > URL: https://issues.apache.org/jira/browse/RNG-85 > Project: Commons RNG > Issue Type: Sub-task > Components: core >Reporter: Gilles >Priority: Minor > Labels: gsoc2019 > > https://en.wikipedia.org/wiki/Middle_square_method#Middle_Square_Weyl_Sequence_PRNG -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (RNG-85) Middle Square Weyl Sequence generator
[ https://issues.apache.org/jira/browse/RNG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806367#comment-16806367 ] Lam Gia Thuan edited comment on RNG-85 at 4/1/19 3:53 AM: -- Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the tast will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to someone, like you, for example, to review and get feedback first before officially sending. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task. Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. was (Author: duckladydinh): Dear Mr. [~erans], I am late into this but I would appreciate it if you can help me understand more about the scope of this project. I wonder if I apply for this, then the test will be to implement only this generator (it would be really short for 3 months, I guess) or it will also include all that are mentioned in RNG-32? In addition, I am new for GSoC also, so if I write a proposal, is it okay if I can send it to someone, like you, for example, to review and get feedback first before officially sending. Last, but not least, I am an university student with both Java/C++ and algorithmic background. To participate in this task, must I maybe complete some tests from you, the reporter, first? If not, is there anyway for me to assure that I have the required skills to complete this task. Thank you so much for your time and consideration. I hope now is not too late to ask Happy Coding. > Middle Square Weyl Sequence generator > - > > Key: RNG-85 > URL: https://issues.apache.org/jira/browse/RNG-85 > Project: Commons RNG > Issue Type: Sub-task > Components: core >Reporter: Gilles >Priority: Minor > Labels: gsoc2019 > > https://en.wikipedia.org/wiki/Middle_square_method#Middle_Square_Weyl_Sequence_PRNG -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (VFS-497) Port file filters from Apache Commons IO to VFS
[ https://issues.apache.org/jira/browse/VFS-497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated VFS-497: - Description: Apache Commons IO has a similar file filter concept as VFS and provides ~20 filter implementations. VFS misses such implementations. Therefore I ported the IO filters, created & updated unit tests and now I want to contribute that code to VFS. The code is currently available on GitHub: [https://github.com/fuinorg/commons-vfs2-filters] New filters are: * org.apache.commons.vfs2.filter.AgeFileFilter * org.apache.commons.vfs2.filter.AndFileFilter * org.apache.commons.vfs2.filter.CanReadFileFilter * org.apache.commons.vfs2.filter.CanWriteFileFilter * org.apache.commons.vfs2.filter.ConditionalFileFilter * org.apache.commons.vfs2.filter.DirectoryFileFilter * org.apache.commons.vfs2.filter.EmptyFileFilter * org.apache.commons.vfs2.filter.FalseFileFilter * org.apache.commons.vfs2.filter.FileFileFilter * org.apache.commons.vfs2.filter.HiddenFileFilter * org.apache.commons.vfs2.filter.NameFileFilter * org.apache.commons.vfs2.filter.NotFileFilter * org.apache.commons.vfs2.filter.OrFileFilter * org.apache.commons.vfs2.filter.PrefixFileFilter * org.apache.commons.vfs2.filter.RegexFileFilter * org.apache.commons.vfs2.filter.SizeFileFilter * org.apache.commons.vfs2.filter.SizeRangeFileFilter * org.apache.commons.vfs2.filter.SuffixFileFilter * org.apache.commons.vfs2.filter.TrueFileFilter * org.apache.commons.vfs2.filter.WildcardFileFilter was: Apache Commons IO has a similar file filter concept as VFS and provides ~20 filter implementations. VFS misses such implementations. Therefore I ported the IO filters, created & updated unit tests and now I want to contribute that code to VFS. The code is currently available on GitHub: https://github.com/fuinorg/commons-vfs2-filters > Port file filters from Apache Commons IO to VFS > --- > > Key: VFS-497 > URL: https://issues.apache.org/jira/browse/VFS-497 > Project: Commons VFS > Issue Type: Improvement >Reporter: Michael Schnell >Priority: Major > Labels: patch > Fix For: 2.4 > > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > Apache Commons IO has a similar file filter concept as VFS and provides ~20 > filter implementations. VFS misses such implementations. > Therefore I ported the IO filters, created & updated unit tests and now I > want to contribute that code to VFS. > The code is currently available on GitHub: > [https://github.com/fuinorg/commons-vfs2-filters] > > New filters are: > * org.apache.commons.vfs2.filter.AgeFileFilter > * org.apache.commons.vfs2.filter.AndFileFilter > * org.apache.commons.vfs2.filter.CanReadFileFilter > * org.apache.commons.vfs2.filter.CanWriteFileFilter > * org.apache.commons.vfs2.filter.ConditionalFileFilter > * org.apache.commons.vfs2.filter.DirectoryFileFilter > * org.apache.commons.vfs2.filter.EmptyFileFilter > * org.apache.commons.vfs2.filter.FalseFileFilter > * org.apache.commons.vfs2.filter.FileFileFilter > * org.apache.commons.vfs2.filter.HiddenFileFilter > * org.apache.commons.vfs2.filter.NameFileFilter > * org.apache.commons.vfs2.filter.NotFileFilter > * org.apache.commons.vfs2.filter.OrFileFilter > * org.apache.commons.vfs2.filter.PrefixFileFilter > * org.apache.commons.vfs2.filter.RegexFileFilter > * org.apache.commons.vfs2.filter.SizeFileFilter > * org.apache.commons.vfs2.filter.SizeRangeFileFilter > * org.apache.commons.vfs2.filter.SuffixFileFilter > * org.apache.commons.vfs2.filter.TrueFileFilter > * org.apache.commons.vfs2.filter.WildcardFileFilter -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (STATISTICS-7) Stream-based Java statistical processing
[ https://issues.apache.org/jira/browse/STATISTICS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806296#comment-16806296 ] Gilles commented on STATISTICS-7: - [~Salman], In your proposal, you mention * T-distribution * MathArrays * Precision Some have been moved to ["Commons Numbers"|http://commons.apache.org/proper/commons-numbers/] or ["Commons Statistics"|http://commons.apache.org/proper/commons-statistics/modules.html]. > Stream-based Java statistical processing > > > Key: STATISTICS-7 > URL: https://issues.apache.org/jira/browse/STATISTICS-7 > Project: Apache Commons Statistics > Issue Type: New Feature >Reporter: Eric Barnhill >Priority: Major > Labels: GSoC2019, gsoc2019, statistics, streams > > The new component aims to be a library of commons statistics functions > synchronized with the latest developments in the Java language, in particular > Java's functional programming syntax. > The library will make commonly used statistical functions available to an end > user through a simple grammar comparable to commons-math-statistics or > scikit-learn, while under the hood will implement Java's mapping, streaming, > and other producer and consumer functions to ensure the statistical methods > run optimally in new Java implementations. > Developers working on the project will have the opportunity to demonstrate > Java programming, functional programming, algorithm design, and data science > skills and receive authorship on a commons project that is likely to be > widely used. > The ideal contributor will also be able to help with important architectural > decision making. The old source of these libraries, commons-math, grew too > large, hierarchically complex and interdependent for the commons mission. The > developers on this project need to make architectural choices that will > enable the statiscal code to be lightweight and reusable, with a minimum of > outside dependencies while avoiding redundancy. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-70) Userguide and reports
[
https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806291#comment-16806291
]
Gilles commented on NUMBERS-70:
---
bq. Is there any specific format of proposal ?
https://community.apache.org/gsoc.html
bq. patch is \[...\] summary of primary numbers and the code for its
implementation.
There seems to be some misunderstanding about what you are supposed to achieve.
Documentation is meant to illustrate existing functionality, not presenting
alternative implementations.
Moreover, ensuring that a code snippet works does not mean that you have to
include a {{main}} method.
> Userguide and reports
> -
>
> Key: NUMBERS-70
> URL: https://issues.apache.org/jira/browse/NUMBERS-70
> Project: Commons Numbers
> Issue Type: Wish
>Reporter: Gilles
>Priority: Minor
> Labels: benchmark, documentation, gsoc2019
> Fix For: 1.0
>
> Attachments: 0001-Primes-xdoc-is-added.patch
>
>
> Review contents of the component towards providing an up-to-date userguide
> and write benchmarking code for generating performance reports
> ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IMAGING-223) Update from Java 7 to Java 8
[ https://issues.apache.org/jira/browse/IMAGING-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806284#comment-16806284 ] Bruno P. Kinoshita commented on IMAGING-223: Thanks! And thanks for the improvements following this change as well! Code looking better already. > Update from Java 7 to Java 8 > > > Key: IMAGING-223 > URL: https://issues.apache.org/jira/browse/IMAGING-223 > Project: Commons Imaging > Issue Type: Improvement >Reporter: Gary Gregory >Priority: Major > Fix For: 1.0-alpha > > > Update from Java 7 to Java 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-vfs] garydgregory commented on issue #49: SFTP HTTP and SOCKS proxy authentication
garydgregory commented on issue #49: SFTP HTTP and SOCKS proxy authentication URL: https://github.com/apache/commons-vfs/pull/49#issuecomment-478390908 Because snapshots are not official releases. Snapshots are here: https://repository.apache.org/snapshots/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Deleted] (TEXT-159) Delete of server
[ https://issues.apache.org/jira/browse/TEXT-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory deleted TEXT-159: -- > Delete of server > > > Key: TEXT-159 > URL: https://issues.apache.org/jira/browse/TEXT-159 > Project: Commons Text > Issue Type: Bug >Reporter: S. Poortman >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IO-603) Maven dependency version
[ https://issues.apache.org/jira/browse/IO-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806280#comment-16806280 ] Gary Gregory commented on IO-603: - Snapshots are here: https://repository.apache.org/snapshots/ > Maven dependency version > > > Key: IO-603 > URL: https://issues.apache.org/jira/browse/IO-603 > Project: Commons IO > Issue Type: Bug >Reporter: Ewa Śliwińska >Priority: Minor > > On ["Dependency > information"|http://commons.apache.org/proper/commons-io/dependency-info.html] > Maven version is *2.7-SNAPSHOT*, but I have troubles downloading this > version, also in [Maven > repository|https://mvnrepository.com/artifact/commons-io/commons-io] it seems > the last version is 2.6. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (STATISTICS-7) Stream-based Java statistical processing
[ https://issues.apache.org/jira/browse/STATISTICS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806252#comment-16806252 ] Eric Barnhill commented on STATISTICS-7: I can confirm I see two draft proposals in. Will give them a look this week. > Stream-based Java statistical processing > > > Key: STATISTICS-7 > URL: https://issues.apache.org/jira/browse/STATISTICS-7 > Project: Apache Commons Statistics > Issue Type: New Feature >Reporter: Eric Barnhill >Priority: Major > Labels: GSoC2019, gsoc2019, statistics, streams > > The new component aims to be a library of commons statistics functions > synchronized with the latest developments in the Java language, in particular > Java's functional programming syntax. > The library will make commonly used statistical functions available to an end > user through a simple grammar comparable to commons-math-statistics or > scikit-learn, while under the hood will implement Java's mapping, streaming, > and other producer and consumer functions to ensure the statistical methods > run optimally in new Java implementations. > Developers working on the project will have the opportunity to demonstrate > Java programming, functional programming, algorithm design, and data science > skills and receive authorship on a commons project that is likely to be > widely used. > The ideal contributor will also be able to help with important architectural > decision making. The old source of these libraries, commons-math, grew too > large, hierarchically complex and interdependent for the commons mission. The > developers on this project need to make architectural choices that will > enable the statiscal code to be lightweight and reusable, with a minimum of > outside dependencies while avoiding redundancy. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-70) Userguide and reports
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806231#comment-16806231 ] Abhishek Chaudhary commented on NUMBERS-70: --- Should I start writing a proposal ? Is there any specific format of proposal ? > Userguide and reports > - > > Key: NUMBERS-70 > URL: https://issues.apache.org/jira/browse/NUMBERS-70 > Project: Commons Numbers > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Labels: benchmark, documentation, gsoc2019 > Fix For: 1.0 > > Attachments: 0001-Primes-xdoc-is-added.patch > > > Review contents of the component towards providing an up-to-date userguide > and write benchmarking code for generating performance reports > ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NUMBERS-70) Userguide and reports
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806229#comment-16806229 ] Abhishek Chaudhary commented on NUMBERS-70: --- [^0001-Primes-xdoc-is-added.patch] This patch is about common-numbers-primes usage. About summary of primary numbers and the code for its implementation. > Userguide and reports > - > > Key: NUMBERS-70 > URL: https://issues.apache.org/jira/browse/NUMBERS-70 > Project: Commons Numbers > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Labels: benchmark, documentation, gsoc2019 > Fix For: 1.0 > > Attachments: 0001-Primes-xdoc-is-added.patch > > > Review contents of the component towards providing an up-to-date userguide > and write benchmarking code for generating performance reports > ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NUMBERS-70) Userguide and reports
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Chaudhary updated NUMBERS-70: -- Attachment: 0001-Primes-xdoc-is-added.patch > Userguide and reports > - > > Key: NUMBERS-70 > URL: https://issues.apache.org/jira/browse/NUMBERS-70 > Project: Commons Numbers > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Labels: benchmark, documentation, gsoc2019 > Fix For: 1.0 > > Attachments: 0001-Primes-xdoc-is-added.patch > > > Review contents of the component towards providing an up-to-date userguide > and write benchmarking code for generating performance reports > ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (NUMBERS-70) Userguide and reports
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Chaudhary updated NUMBERS-70: -- Comment: was deleted (was: From 951f43545c7f318f72b566675367b6c212177a30 Mon Sep 17 00:00:00 2001 From: Abhishekism9450 Date: Sat, 30 Mar 2019 16:48:39 +0530 Subject: [PATCH] common numbers prime xdoc is added. --- .../src/site/xdoc/index.xml | 41 +++ 1 file changed, 41 insertions(+) create mode 100644 commons-numbers-primes/src/site/xdoc/index.xml diff --git a/commons-numbers-primes/src/site/xdoc/index.xml b/commons-numbers-primes/src/site/xdoc/index.xml new file mode 100644 index 000..685aa19 --- /dev/null +++ b/commons-numbers-primes/src/site/xdoc/index.xml @@ -0,0 +1,41 @@ + + + + + + + +Commons Numbers Primes + + + + + + + Commons Numbers provides utilities such as complex numbers and fractions. + + + + The "prime" module contains utilities related to the "prime" numbers.These numbers + are only divisible by itself. + + + + + + -- 2.17.1) > Userguide and reports > - > > Key: NUMBERS-70 > URL: https://issues.apache.org/jira/browse/NUMBERS-70 > Project: Commons Numbers > Issue Type: Wish >Reporter: Gilles >Priority: Minor > Labels: benchmark, documentation, gsoc2019 > Fix For: 1.0 > > > Review contents of the component towards providing an up-to-date userguide > and write benchmarking code for generating performance reports > ([JMH|http://openjdk.java.net/projects/code-tools/jmh/]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-geometry] svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
URL: https://github.com/apache/commons-geometry/pull/31#discussion_r270674434
##
File path:
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
##
@@ -16,174 +16,193 @@
*/
package org.apache.commons.geometry.euclidean.threed;
+import java.util.Objects;
+
import org.apache.commons.geometry.core.exception.IllegalNormException;
import org.apache.commons.geometry.core.partitioning.Embedding;
import org.apache.commons.geometry.core.partitioning.Hyperplane;
import org.apache.commons.geometry.core.precision.DoublePrecisionContext;
-import org.apache.commons.geometry.euclidean.internal.Vectors;
import org.apache.commons.geometry.euclidean.oned.Vector1D;
import
org.apache.commons.geometry.euclidean.threed.rotation.QuaternionRotation;
import org.apache.commons.geometry.euclidean.twod.PolygonsSet;
import org.apache.commons.geometry.euclidean.twod.Vector2D;
-/** The class represent planes in a three dimensional space.
+/**
+ * The class represents a plane in a three dimensional space.
*/
-public class Plane implements Hyperplane, Embedding {
-
-/** Offset of the origin with respect to the plane. */
-private double originOffset;
+public final class Plane implements Hyperplane, Embedding {
-/** Origin of the plane frame. */
-private Vector3D origin;
+/** First normalized vector of the plane frame (in plane). */
+private final Vector3D u;
-/** First vector of the plane frame (in plane). */
-private Vector3D u;
+/** Second normalized vector of the plane frame (in plane). */
+private final Vector3D v;
-/** Second vector of the plane frame (in plane). */
-private Vector3D v;
+/** Normalized plane normal. */
+private final Vector3D w;
-/** Third vector of the plane frame (plane normal). */
-private Vector3D w;
+/** Offset of the origin with respect to the plane. */
+private final double originOffset;
+/** orthogonal projection of the 3D-space origin in the plane. */
+private final Vector3D projectedOrigin;
+
/** Precision context used to compare floating point numbers. */
private final DoublePrecisionContext precision;
-/** Build a plane normal to a given direction and containing the origin.
- * @param normal normal direction to the plane
+/**
+ * Constructor to build a new plane with the given values.
+ * Made private to prevent inheritance.
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
+ * @param w unit normal vector
+ * @param projectedOrigin orthogonal projection of the 3D-space origin in
the plane.
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @throws IllegalArgumentException if the provided vectors are coplanar
or not normalized
*/
-public Plane(final Vector3D normal, final DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
+private Plane(Vector3D u, Vector3D v, Vector3D w, Vector3D
projectedOrigin, double originOffset,
+DoublePrecisionContext precision) {
+this.u = u;
+this.v = v;
+this.w = w;
+
+if (!areVectorsNormalized(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must be
normalized.");
+}
+if (Vector3D.areCoplanar(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must not be
coplanar.");
+}
+this.projectedOrigin = projectedOrigin;
+this.originOffset = originOffset;
this.precision = precision;
-originOffset = 0;
-setFrame();
}
-
-/** Build a plane from a point and a normal.
- * @param p point belonging to the plane
- * @param normal normal direction to the plane
+
+/**
+ * Build a plane from a point and two (on plane) vectors.
+ * @param p the provided point (on plane)
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @return a new plane
+ * @throws IllegalNormException if the norm of the given values is zero,
NaN, or infinite.
+ * @throws IllegalArgumentException if the provided vectors are collinear
*/
-public Plane(final Vector3D p, final Vector3D normal, final
DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
-this.precision = precision;
-this.originOffset = -p.dot(w);
-setFrame();
+public static Plane fromPointAndPlaneVectors (Vector3D p, final Vector3D
u, final
[GitHub] [commons-geometry] svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
URL: https://github.com/apache/commons-geometry/pull/31#discussion_r270674425
##
File path:
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
##
@@ -16,174 +16,193 @@
*/
package org.apache.commons.geometry.euclidean.threed;
+import java.util.Objects;
+
import org.apache.commons.geometry.core.exception.IllegalNormException;
import org.apache.commons.geometry.core.partitioning.Embedding;
import org.apache.commons.geometry.core.partitioning.Hyperplane;
import org.apache.commons.geometry.core.precision.DoublePrecisionContext;
-import org.apache.commons.geometry.euclidean.internal.Vectors;
import org.apache.commons.geometry.euclidean.oned.Vector1D;
import
org.apache.commons.geometry.euclidean.threed.rotation.QuaternionRotation;
import org.apache.commons.geometry.euclidean.twod.PolygonsSet;
import org.apache.commons.geometry.euclidean.twod.Vector2D;
-/** The class represent planes in a three dimensional space.
+/**
+ * The class represents a plane in a three dimensional space.
*/
-public class Plane implements Hyperplane, Embedding {
-
-/** Offset of the origin with respect to the plane. */
-private double originOffset;
+public final class Plane implements Hyperplane, Embedding {
-/** Origin of the plane frame. */
-private Vector3D origin;
+/** First normalized vector of the plane frame (in plane). */
+private final Vector3D u;
-/** First vector of the plane frame (in plane). */
-private Vector3D u;
+/** Second normalized vector of the plane frame (in plane). */
+private final Vector3D v;
-/** Second vector of the plane frame (in plane). */
-private Vector3D v;
+/** Normalized plane normal. */
+private final Vector3D w;
-/** Third vector of the plane frame (plane normal). */
-private Vector3D w;
+/** Offset of the origin with respect to the plane. */
+private final double originOffset;
+/** orthogonal projection of the 3D-space origin in the plane. */
+private final Vector3D projectedOrigin;
+
/** Precision context used to compare floating point numbers. */
private final DoublePrecisionContext precision;
-/** Build a plane normal to a given direction and containing the origin.
- * @param normal normal direction to the plane
+/**
+ * Constructor to build a new plane with the given values.
+ * Made private to prevent inheritance.
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
+ * @param w unit normal vector
+ * @param projectedOrigin orthogonal projection of the 3D-space origin in
the plane.
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @throws IllegalArgumentException if the provided vectors are coplanar
or not normalized
*/
-public Plane(final Vector3D normal, final DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
+private Plane(Vector3D u, Vector3D v, Vector3D w, Vector3D
projectedOrigin, double originOffset,
+DoublePrecisionContext precision) {
+this.u = u;
+this.v = v;
+this.w = w;
+
+if (!areVectorsNormalized(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must be
normalized.");
+}
+if (Vector3D.areCoplanar(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must not be
coplanar.");
+}
+this.projectedOrigin = projectedOrigin;
+this.originOffset = originOffset;
this.precision = precision;
-originOffset = 0;
-setFrame();
}
-
-/** Build a plane from a point and a normal.
- * @param p point belonging to the plane
- * @param normal normal direction to the plane
+
+/**
+ * Build a plane from a point and two (on plane) vectors.
+ * @param p the provided point (on plane)
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @return a new plane
+ * @throws IllegalNormException if the norm of the given values is zero,
NaN, or infinite.
+ * @throws IllegalArgumentException if the provided vectors are collinear
*/
-public Plane(final Vector3D p, final Vector3D normal, final
DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
-this.precision = precision;
-this.originOffset = -p.dot(w);
-setFrame();
+public static Plane fromPointAndPlaneVectors (Vector3D p, final Vector3D
u, final
[GitHub] [commons-geometry] svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
URL: https://github.com/apache/commons-geometry/pull/31#discussion_r270674418
##
File path:
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
##
@@ -16,174 +16,193 @@
*/
package org.apache.commons.geometry.euclidean.threed;
+import java.util.Objects;
+
import org.apache.commons.geometry.core.exception.IllegalNormException;
import org.apache.commons.geometry.core.partitioning.Embedding;
import org.apache.commons.geometry.core.partitioning.Hyperplane;
import org.apache.commons.geometry.core.precision.DoublePrecisionContext;
-import org.apache.commons.geometry.euclidean.internal.Vectors;
import org.apache.commons.geometry.euclidean.oned.Vector1D;
import
org.apache.commons.geometry.euclidean.threed.rotation.QuaternionRotation;
import org.apache.commons.geometry.euclidean.twod.PolygonsSet;
import org.apache.commons.geometry.euclidean.twod.Vector2D;
-/** The class represent planes in a three dimensional space.
+/**
+ * The class represents a plane in a three dimensional space.
*/
-public class Plane implements Hyperplane, Embedding {
-
-/** Offset of the origin with respect to the plane. */
-private double originOffset;
+public final class Plane implements Hyperplane, Embedding {
-/** Origin of the plane frame. */
-private Vector3D origin;
+/** First normalized vector of the plane frame (in plane). */
+private final Vector3D u;
-/** First vector of the plane frame (in plane). */
-private Vector3D u;
+/** Second normalized vector of the plane frame (in plane). */
+private final Vector3D v;
-/** Second vector of the plane frame (in plane). */
-private Vector3D v;
+/** Normalized plane normal. */
+private final Vector3D w;
-/** Third vector of the plane frame (plane normal). */
-private Vector3D w;
+/** Offset of the origin with respect to the plane. */
+private final double originOffset;
+/** orthogonal projection of the 3D-space origin in the plane. */
+private final Vector3D projectedOrigin;
+
/** Precision context used to compare floating point numbers. */
private final DoublePrecisionContext precision;
-/** Build a plane normal to a given direction and containing the origin.
- * @param normal normal direction to the plane
+/**
+ * Constructor to build a new plane with the given values.
+ * Made private to prevent inheritance.
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
+ * @param w unit normal vector
+ * @param projectedOrigin orthogonal projection of the 3D-space origin in
the plane.
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @throws IllegalArgumentException if the provided vectors are coplanar
or not normalized
*/
-public Plane(final Vector3D normal, final DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
+private Plane(Vector3D u, Vector3D v, Vector3D w, Vector3D
projectedOrigin, double originOffset,
+DoublePrecisionContext precision) {
+this.u = u;
+this.v = v;
+this.w = w;
+
+if (!areVectorsNormalized(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must be
normalized.");
+}
+if (Vector3D.areCoplanar(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must not be
coplanar.");
+}
+this.projectedOrigin = projectedOrigin;
+this.originOffset = originOffset;
this.precision = precision;
-originOffset = 0;
-setFrame();
}
-
-/** Build a plane from a point and a normal.
- * @param p point belonging to the plane
- * @param normal normal direction to the plane
+
+/**
+ * Build a plane from a point and two (on plane) vectors.
+ * @param p the provided point (on plane)
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @return a new plane
+ * @throws IllegalNormException if the norm of the given values is zero,
NaN, or infinite.
+ * @throws IllegalArgumentException if the provided vectors are collinear
*/
-public Plane(final Vector3D p, final Vector3D normal, final
DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
-this.precision = precision;
-this.originOffset = -p.dot(w);
-setFrame();
+public static Plane fromPointAndPlaneVectors (Vector3D p, final Vector3D
u, final
[GitHub] [commons-geometry] svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
svenrathgeber commented on a change in pull request #31: Geometry 29 2 sven
URL: https://github.com/apache/commons-geometry/pull/31#discussion_r270674411
##
File path:
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
##
@@ -16,174 +16,193 @@
*/
package org.apache.commons.geometry.euclidean.threed;
+import java.util.Objects;
+
import org.apache.commons.geometry.core.exception.IllegalNormException;
import org.apache.commons.geometry.core.partitioning.Embedding;
import org.apache.commons.geometry.core.partitioning.Hyperplane;
import org.apache.commons.geometry.core.precision.DoublePrecisionContext;
-import org.apache.commons.geometry.euclidean.internal.Vectors;
import org.apache.commons.geometry.euclidean.oned.Vector1D;
import
org.apache.commons.geometry.euclidean.threed.rotation.QuaternionRotation;
import org.apache.commons.geometry.euclidean.twod.PolygonsSet;
import org.apache.commons.geometry.euclidean.twod.Vector2D;
-/** The class represent planes in a three dimensional space.
+/**
+ * The class represents a plane in a three dimensional space.
*/
-public class Plane implements Hyperplane, Embedding {
-
-/** Offset of the origin with respect to the plane. */
-private double originOffset;
+public final class Plane implements Hyperplane, Embedding {
-/** Origin of the plane frame. */
-private Vector3D origin;
+/** First normalized vector of the plane frame (in plane). */
+private final Vector3D u;
-/** First vector of the plane frame (in plane). */
-private Vector3D u;
+/** Second normalized vector of the plane frame (in plane). */
+private final Vector3D v;
-/** Second vector of the plane frame (in plane). */
-private Vector3D v;
+/** Normalized plane normal. */
+private final Vector3D w;
-/** Third vector of the plane frame (plane normal). */
-private Vector3D w;
+/** Offset of the origin with respect to the plane. */
+private final double originOffset;
+/** orthogonal projection of the 3D-space origin in the plane. */
+private final Vector3D projectedOrigin;
+
/** Precision context used to compare floating point numbers. */
private final DoublePrecisionContext precision;
-/** Build a plane normal to a given direction and containing the origin.
- * @param normal normal direction to the plane
+/**
+ * Constructor to build a new plane with the given values.
+ * Made private to prevent inheritance.
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
+ * @param w unit normal vector
+ * @param projectedOrigin orthogonal projection of the 3D-space origin in
the plane.
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @throws IllegalArgumentException if the provided vectors are coplanar
or not normalized
*/
-public Plane(final Vector3D normal, final DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
+private Plane(Vector3D u, Vector3D v, Vector3D w, Vector3D
projectedOrigin, double originOffset,
+DoublePrecisionContext precision) {
+this.u = u;
+this.v = v;
+this.w = w;
+
+if (!areVectorsNormalized(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must be
normalized.");
+}
+if (Vector3D.areCoplanar(u, v, w, precision))
+{
+throw new IllegalArgumentException("Provided vectors must not be
coplanar.");
+}
+this.projectedOrigin = projectedOrigin;
+this.originOffset = originOffset;
this.precision = precision;
-originOffset = 0;
-setFrame();
}
-
-/** Build a plane from a point and a normal.
- * @param p point belonging to the plane
- * @param normal normal direction to the plane
+
+/**
+ * Build a plane from a point and two (on plane) vectors.
+ * @param p the provided point (on plane)
+ * @param u u vector (on plane)
+ * @param v v vector (on plane)
* @param precision precision context used to compare floating point values
- * @exception IllegalArgumentException if the normal norm is too small
+ * @return a new plane
+ * @throws IllegalNormException if the norm of the given values is zero,
NaN, or infinite.
+ * @throws IllegalArgumentException if the provided vectors are collinear
*/
-public Plane(final Vector3D p, final Vector3D normal, final
DoublePrecisionContext precision)
-throws IllegalArgumentException {
-setNormal(normal);
-this.precision = precision;
-this.originOffset = -p.dot(w);
-setFrame();
+public static Plane fromPointAndPlaneVectors (Vector3D p, final Vector3D
u, final
[jira] [Created] (VFS-697) More efficient comparison in FileExtensionSelector #44
Gary Gregory created VFS-697: Summary: More efficient comparison in FileExtensionSelector #44 Key: VFS-697 URL: https://issues.apache.org/jira/browse/VFS-697 Project: Commons VFS Issue Type: Improvement Reporter: Gary Gregory More efficient comparison in FileExtensionSelector #44. https://github.com/apache/commons-vfs/pull/44 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-vfs] garydgregory merged pull request #44: More efficient comparison in FileExtensionSelector
garydgregory merged pull request #44: More efficient comparison in FileExtensionSelector URL: https://github.com/apache/commons-vfs/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #44: More efficient comparison in FileExtensionSelector
garydgregory commented on a change in pull request #44: More efficient
comparison in FileExtensionSelector
URL: https://github.com/apache/commons-vfs/pull/44#discussion_r270672262
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/FileExtensionSelector.java
##
@@ -57,9 +61,7 @@ public FileExtensionSelector(final Collection
extensions) {
* @param extensions The extensions to be included by this selector.
*/
public FileExtensionSelector(final String... extensions) {
-if (extensions != null) {
-this.extensions.addAll(Arrays.asList(extensions));
-}
+this(Arrays.asList(extensions));
Review comment:
+1 to reusing the ctor.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #44: More efficient comparison in FileExtensionSelector
garydgregory commented on a change in pull request #44: More efficient
comparison in FileExtensionSelector
URL: https://github.com/apache/commons-vfs/pull/44#discussion_r270672247
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/FileExtensionSelector.java
##
@@ -47,7 +47,11 @@
*/
public FileExtensionSelector(final Collection extensions) {
if (extensions != null) {
-this.extensions.addAll(extensions);
+for (String ext : extensions) {
+if (ext != null) {
Review comment:
+1 to the null check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #44: More efficient comparison in FileExtensionSelector
garydgregory commented on a change in pull request #44: More efficient
comparison in FileExtensionSelector
URL: https://github.com/apache/commons-vfs/pull/44#discussion_r270672315
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/FileExtensionSelector.java
##
@@ -70,15 +72,7 @@ public FileExtensionSelector(final String... extensions) {
*/
@Override
public boolean includeFile(final FileSelectInfo fileInfo) throws Exception
{
-if (this.extensions == null) {
-return false;
-}
-for (final String extension : this.extensions) {
-if
(fileInfo.getFile().getName().getExtension().equalsIgnoreCase(extension)) {
-return true;
-}
-}
-return false;
+return
this.extensions.contains(fileInfo.getFile().getName().getExtension().toLowerCase());
Review comment:
I'm not sure that's quite right. Unit tests would help check that case is
handled properly. Note that not all file systems are case-insenstive. OTOH, if
that is an issue with this code, it was already there! ;-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (VFS-497) Port file filters from Apache Commons IO to VFS
[ https://issues.apache.org/jira/browse/VFS-497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved VFS-497. -- Resolution: Fixed Fix Version/s: 2.4 Thank you [~michael-schnell]! Merged with some changes to git master. > Port file filters from Apache Commons IO to VFS > --- > > Key: VFS-497 > URL: https://issues.apache.org/jira/browse/VFS-497 > Project: Commons VFS > Issue Type: Improvement >Reporter: Michael Schnell >Priority: Major > Labels: patch > Fix For: 2.4 > > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > Apache Commons IO has a similar file filter concept as VFS and provides ~20 > filter implementations. VFS misses such implementations. > Therefore I ported the IO filters, created & updated unit tests and now I > want to contribute that code to VFS. > The code is currently available on GitHub: > https://github.com/fuinorg/commons-vfs2-filters -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (VFS-497) Port file filters from Apache Commons IO to VFS
[ https://issues.apache.org/jira/browse/VFS-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806176#comment-16806176 ] Gary Gregory edited comment on VFS-497 at 3/31/19 3:40 PM: --- Thank you [~michael-schnell]! Merged with some changes to git master. Please verify and close. was (Author: garydgregory): Thank you [~michael-schnell]! Merged with some changes to git master. > Port file filters from Apache Commons IO to VFS > --- > > Key: VFS-497 > URL: https://issues.apache.org/jira/browse/VFS-497 > Project: Commons VFS > Issue Type: Improvement >Reporter: Michael Schnell >Priority: Major > Labels: patch > Fix For: 2.4 > > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > Apache Commons IO has a similar file filter concept as VFS and provides ~20 > filter implementations. VFS misses such implementations. > Therefore I ported the IO filters, created & updated unit tests and now I > want to contribute that code to VFS. > The code is currently available on GitHub: > https://github.com/fuinorg/commons-vfs2-filters -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (VFS-497) Port file filters from Apache Commons IO to VFS
[ https://issues.apache.org/jira/browse/VFS-497?focusedWorklogId=221005=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221005 ] ASF GitHub Bot logged work on VFS-497: -- Author: ASF GitHub Bot Created on: 31/Mar/19 15:39 Start Date: 31/Mar/19 15:39 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #9: [VFS-497] Ported filters from Commons IO URL: https://github.com/apache/commons-vfs/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221005) Time Spent: 10m Remaining Estimate: 50m (was: 1h) > Port file filters from Apache Commons IO to VFS > --- > > Key: VFS-497 > URL: https://issues.apache.org/jira/browse/VFS-497 > Project: Commons VFS > Issue Type: Improvement >Reporter: Michael Schnell >Priority: Major > Labels: patch > Original Estimate: 1h > Time Spent: 10m > Remaining Estimate: 50m > > Apache Commons IO has a similar file filter concept as VFS and provides ~20 > filter implementations. VFS misses such implementations. > Therefore I ported the IO filters, created & updated unit tests and now I > want to contribute that code to VFS. > The code is currently available on GitHub: > https://github.com/fuinorg/commons-vfs2-filters -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-vfs] garydgregory commented on issue #9: [VFS-497] Ported filters from Commons IO
garydgregory commented on issue #9: [VFS-497] Ported filters from Commons IO URL: https://github.com/apache/commons-vfs/pull/9#issuecomment-478352407 Merged with some changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory closed pull request #9: [VFS-497] Ported filters from Commons IO
garydgregory closed pull request #9: [VFS-497] Ported filters from Commons IO URL: https://github.com/apache/commons-vfs/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #8: [VFS-467] Improved the comparison of file names
garydgregory commented on issue #8: [VFS-467] Improved the comparison of file names URL: https://github.com/apache/commons-vfs/pull/8#issuecomment-478345383 @coder-hugo May you please rebase to solve conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (JEXL-295) Add unary plus operator
[ https://issues.apache.org/jira/browse/JEXL-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806163#comment-16806163 ] Dmitri Blinov commented on JEXL-295: I'm terribly sorry but, with regard to the current implementation, is the `positivize` a correct term to use for unary plus operator? One might think that `positivize` is indended to make something positive, which in our case is not. Should we instead call it `promote` ? > Add unary plus operator > --- > > Key: JEXL-295 > URL: https://issues.apache.org/jira/browse/JEXL-295 > Project: Commons JEXL > Issue Type: New Feature >Affects Versions: 3.1 >Reporter: Henri Biestro >Assignee: Henri Biestro >Priority: Major > Fix For: 3.2 > > > WHAT > Introduce a new operator, the unary plus as in '+4' or '+b' expressions. JEXL > arithmetic already allows using a unary minus operator (the negate operation) > so there is logic in having the counterpart. > The proposed default behaviour would be to: > - call the 'Math.abs(...)' method for numbers > - return true for boolean > - could uppercase strings ? (should '-' lowercase strings ??) > HOW > - Follow the unary minus syntax and construct in the .jjt / ASTUnaryPlus / > ParserVisitor > - Implement Interpreter, Debugger > - Implement abs in JexlArithmetic -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (IMAGING-223) Update from Java 7 to Java 8
[ https://issues.apache.org/jira/browse/IMAGING-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved IMAGING-223. -- Resolution: Fixed Fix Version/s: 1.0-alpha In git master. > Update from Java 7 to Java 8 > > > Key: IMAGING-223 > URL: https://issues.apache.org/jira/browse/IMAGING-223 > Project: Commons Imaging > Issue Type: Improvement >Reporter: Gary Gregory >Priority: Major > Fix For: 1.0-alpha > > > Update from Java 7 to Java 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IMAGING-223) Update from Java 7 to Java 8
Gary Gregory created IMAGING-223: Summary: Update from Java 7 to Java 8 Key: IMAGING-223 URL: https://issues.apache.org/jira/browse/IMAGING-223 Project: Commons Imaging Issue Type: Improvement Reporter: Gary Gregory Update from Java 7 to Java 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (STATISTICS-7) Stream-based Java statistical processing
[
https://issues.apache.org/jira/browse/STATISTICS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806156#comment-16806156
]
Gilles commented on STATISTICS-7:
-
I don't see any link.
{quote}Where else can I share it?
{quote}
Through "Google Docs", but the "portal" should be fine too, provided we know
where to look. ;)
> Stream-based Java statistical processing
>
>
> Key: STATISTICS-7
> URL: https://issues.apache.org/jira/browse/STATISTICS-7
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Eric Barnhill
>Priority: Major
> Labels: GSoC2019, gsoc2019, statistics, streams
>
> The new component aims to be a library of commons statistics functions
> synchronized with the latest developments in the Java language, in particular
> Java's functional programming syntax.
> The library will make commonly used statistical functions available to an end
> user through a simple grammar comparable to commons-math-statistics or
> scikit-learn, while under the hood will implement Java's mapping, streaming,
> and other producer and consumer functions to ensure the statistical methods
> run optimally in new Java implementations.
> Developers working on the project will have the opportunity to demonstrate
> Java programming, functional programming, algorithm design, and data science
> skills and receive authorship on a commons project that is likely to be
> widely used.
> The ideal contributor will also be able to help with important architectural
> decision making. The old source of these libraries, commons-math, grew too
> large, hierarchically complex and interdependent for the commons mission. The
> developers on this project need to make architectural choices that will
> enable the statiscal code to be lightweight and reusable, with a minimum of
> outside dependencies while avoiding redundancy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (STATISTICS-7) Stream-based Java statistical processing
[ https://issues.apache.org/jira/browse/STATISTICS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806148#comment-16806148 ] Virendra Singh commented on STATISTICS-7: - On GSoC portal. Following is written there: h2. Draft Shared "The Apache Software Foundation may respond with comments to help you improve your draft proposal, if there is enough time before the deadline. You may also contact the organization to request feedback." Where else can I share it? > Stream-based Java statistical processing > > > Key: STATISTICS-7 > URL: https://issues.apache.org/jira/browse/STATISTICS-7 > Project: Apache Commons Statistics > Issue Type: New Feature >Reporter: Eric Barnhill >Priority: Major > Labels: GSoC2019, gsoc2019, statistics, streams > > The new component aims to be a library of commons statistics functions > synchronized with the latest developments in the Java language, in particular > Java's functional programming syntax. > The library will make commonly used statistical functions available to an end > user through a simple grammar comparable to commons-math-statistics or > scikit-learn, while under the hood will implement Java's mapping, streaming, > and other producer and consumer functions to ensure the statistical methods > run optimally in new Java implementations. > Developers working on the project will have the opportunity to demonstrate > Java programming, functional programming, algorithm design, and data science > skills and receive authorship on a commons project that is likely to be > widely used. > The ideal contributor will also be able to help with important architectural > decision making. The old source of these libraries, commons-math, grew too > large, hierarchically complex and interdependent for the commons mission. The > developers on this project need to make architectural choices that will > enable the statiscal code to be lightweight and reusable, with a minimum of > outside dependencies while avoiding redundancy. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
