[jira] [Resolved] (MATH-1475) KS test throw MathInternalError: illegal state
[
https://issues.apache.org/jira/browse/MATH-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chao Xue resolved MATH-1475.
Resolution: Fixed
Fix Version/s: 4.0
> KS test throw MathInternalError: illegal state
> --
>
> Key: MATH-1475
> URL: https://issues.apache.org/jira/browse/MATH-1475
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: Windows 10 (Professional)
> JDK 8
>Reporter: Chao Xue
>Priority: Critical
> Fix For: 4.0
>
> Attachments: Figure_1.png
>
>
> {code:java}
> public class CC {
> public static void main(String []args) throws Exception{
> double[]x=new double[]{0.12350159883499146, -0.2601194679737091,
> -1.322849988937378, 0.379696249961853, 0.3987586498260498,
> -0.06924121081829071, -0.13951236009597778, 0.3213207423686981,
> 0.7949811816215515, -0.15811105072498322, 0.19912190735340118,
> -0.46363770961761475, -0.20019817352294922, 0.3062838613986969,
> -0.3872813880443573, 0.10733723640441895, 0.10910066962242126,
> 0.625770092010498, 0.2824835777282715, 0.3107619881629944,
> 0.1432388722896576, -0.08056988567113876, -0.5816712379455566,
> -0.09488576650619507, -0.2154506891965866, 0.2509046196937561,
> -0.06600788980722427, -0.01133995596319437, -0.22642627358436584,
> -0.12150175869464874, -0.21109570562839508, -0.17732949554920197,
> -0.2769380807876587, -0.3607368767261505, -0.07842907309532166,
> -0.2518743574619293, 0.035517483949661255, -0.6556509137153625,
> -0.360045850276947, -0.09371964633464813, -0.7284095883369446,
> -0.22719840705394745, -1.5540679693222046, -0.008972732350230217,
> -0.09106933325529099, -0.6465389132499695, 0.036245591938495636,
> 0.657580554485321, 0.32453101873397827, 0.6105462908744812,
> 0.25256943702697754, -0.194427490234375, 0.6238796710968018,
> 0.52035855, -0.2708645761013031, 0.07761227339506149,
> 0.5315862894058228, 0.44320303201675415, 0.6283767819404602,
> 0.2618369162082672, 0.47253096103668213, 0.3889777660369873,
> 0.6856100559234619, 0.3007083833217621, 0.4963226914405823,
> 0.08229698985815048, 0.6170856952667236, 0.7501978874206543,
> 0.5744063258171082, 0.5233180522918701, 0.32654184103012085,
> 0.3014495372772217, 0.4082445800304413, -0.1075737327337265,
> -0.018864337354898453, 0.34642550349235535, 0.6414541602134705,
> 0.16678297519683838, 0.46028634905815125, 0.4151197075843811,
> 0.14407725632190704, 0.41751566529273987, -0.054958608001470566,
> 0.4995657801628113, 0.4485369324684143, 0.5600396990776062,
> 0.4098612368106842, 0.2748555839061737, 0.2562614381313324,
> 0.4324824810028076};
> double[]y=new double[]{2.6881366763426717, 2.685469965655465,
> 2.261888917462379, -2.1933598759641226, -2.4279488152810145,
> -3.159389495849609, -2.3150004548153444, 2.468029206047388,
> 2.9442494682288953, 2.653360013462529, -2.1189940659194835,
> -2.121635289903703, -2.103092459792032, -2.737034221468073,
> -2.203389332350286, 2.1985949039005512, -2.5021604073154737,
> 2.2732754920764533, -2.3867025598454346, 2.135919387338413,
> 2.338120776050672, 2.2579794509726874, 2.083329059799027, -2.209733724709957,
> 2.297192240399189, -2.201703830825843, -3.460208691996806, 2.428839296615834,
> -3.2944259224581574, 2.0654875493620883, -2.743948930837782,
> -2.2240674680805212, -3.646366778182357, -2.12513198437294,
> 2.979166188824589, -2.6275491570089033, -2.3818176136461338,
> 2.882096356968376, -2.2147229261558334, -3.159389495849609,
> 2.312428759406432, 2.3313864098846477, -2.72802504046371,
> -2.4216068225364245, 3.0119599306499123, 2.5753099009496783,
> -2.9200121783556843, -2.519352725437922, -4.133932580227538,
> -2.30496316762808, 2.5381353678521363, 2.4818233632136697,
> 2.5277451177925685, -2.166465445816232, -2.1193897819471563,
> -2.109654332722425, 3.260211545834851, -3.9527673876059013,
> -2.199885089466947, 2.152573429747697, -3.1593894958496094,
> 2.5479522823226795, 3.342810742466116, -2.8197184957304007,
> -2.3407900299253765, -2.3303967152728537, 2.1760131201015565,
> 2.143930552944634, 2.6231754409, 2.9126278362420575, -2.121169134387265,
> -2.2980208408109095, -2.285400411434817, -2.0742764640932903,
> 2.304178664095016, -2.2893825538911634, -3.7714771984158806,
> -2.7153698816026886, 2.8995011276220226, -2.158787087333056,
> -2.1045987952052547, 2.8478762016468147, -2.694578565956955,
> -2.696014432856399, -2.3190122657403496, -2.48225194403028,
> 3.3393947563371764, 2.7775468034263517, -3.396526561479875,
> -2.699967947404961};
> KolmogorovSmirnovTest kst=new KolmogorovSmirnovTest();
> double p=kst.kolmogorovSmirnovTest(x, y);
> System.out.println(p);
> }
> }
> {code}
> Results:
> run:
> Exception in thread "main"
> org.apache.commons.math3.exception.MathInternalError: illegal state: internal
>
[jira] [Comment Edited] (MATH-1475) KS test throw MathInternalError: illegal state
[
https://issues.apache.org/jira/browse/MATH-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811393#comment-16811393
]
Chao Xue edited comment on MATH-1475 at 4/6/19 2:00 AM:
I used the snaphot in [github|[https://github.com/jcastro-inf/commons-math4]].
The problem was solved when I used the snaphot you provide. Thank you!
was (Author: xuech):
I used the snaphot in
[github|[https://github.com/jcastro-inf/commons-math4|https://github.com/jcastro-inf/commons-math4].]].
> KS test throw MathInternalError: illegal state
> --
>
> Key: MATH-1475
> URL: https://issues.apache.org/jira/browse/MATH-1475
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: Windows 10 (Professional)
> JDK 8
>Reporter: Chao Xue
>Priority: Critical
> Attachments: Figure_1.png
>
>
> {code:java}
> public class CC {
> public static void main(String []args) throws Exception{
> double[]x=new double[]{0.12350159883499146, -0.2601194679737091,
> -1.322849988937378, 0.379696249961853, 0.3987586498260498,
> -0.06924121081829071, -0.13951236009597778, 0.3213207423686981,
> 0.7949811816215515, -0.15811105072498322, 0.19912190735340118,
> -0.46363770961761475, -0.20019817352294922, 0.3062838613986969,
> -0.3872813880443573, 0.10733723640441895, 0.10910066962242126,
> 0.625770092010498, 0.2824835777282715, 0.3107619881629944,
> 0.1432388722896576, -0.08056988567113876, -0.5816712379455566,
> -0.09488576650619507, -0.2154506891965866, 0.2509046196937561,
> -0.06600788980722427, -0.01133995596319437, -0.22642627358436584,
> -0.12150175869464874, -0.21109570562839508, -0.17732949554920197,
> -0.2769380807876587, -0.3607368767261505, -0.07842907309532166,
> -0.2518743574619293, 0.035517483949661255, -0.6556509137153625,
> -0.360045850276947, -0.09371964633464813, -0.7284095883369446,
> -0.22719840705394745, -1.5540679693222046, -0.008972732350230217,
> -0.09106933325529099, -0.6465389132499695, 0.036245591938495636,
> 0.657580554485321, 0.32453101873397827, 0.6105462908744812,
> 0.25256943702697754, -0.194427490234375, 0.6238796710968018,
> 0.52035855, -0.2708645761013031, 0.07761227339506149,
> 0.5315862894058228, 0.44320303201675415, 0.6283767819404602,
> 0.2618369162082672, 0.47253096103668213, 0.3889777660369873,
> 0.6856100559234619, 0.3007083833217621, 0.4963226914405823,
> 0.08229698985815048, 0.6170856952667236, 0.7501978874206543,
> 0.5744063258171082, 0.5233180522918701, 0.32654184103012085,
> 0.3014495372772217, 0.4082445800304413, -0.1075737327337265,
> -0.018864337354898453, 0.34642550349235535, 0.6414541602134705,
> 0.16678297519683838, 0.46028634905815125, 0.4151197075843811,
> 0.14407725632190704, 0.41751566529273987, -0.054958608001470566,
> 0.4995657801628113, 0.4485369324684143, 0.5600396990776062,
> 0.4098612368106842, 0.2748555839061737, 0.2562614381313324,
> 0.4324824810028076};
> double[]y=new double[]{2.6881366763426717, 2.685469965655465,
> 2.261888917462379, -2.1933598759641226, -2.4279488152810145,
> -3.159389495849609, -2.3150004548153444, 2.468029206047388,
> 2.9442494682288953, 2.653360013462529, -2.1189940659194835,
> -2.121635289903703, -2.103092459792032, -2.737034221468073,
> -2.203389332350286, 2.1985949039005512, -2.5021604073154737,
> 2.2732754920764533, -2.3867025598454346, 2.135919387338413,
> 2.338120776050672, 2.2579794509726874, 2.083329059799027, -2.209733724709957,
> 2.297192240399189, -2.201703830825843, -3.460208691996806, 2.428839296615834,
> -3.2944259224581574, 2.0654875493620883, -2.743948930837782,
> -2.2240674680805212, -3.646366778182357, -2.12513198437294,
> 2.979166188824589, -2.6275491570089033, -2.3818176136461338,
> 2.882096356968376, -2.2147229261558334, -3.159389495849609,
> 2.312428759406432, 2.3313864098846477, -2.72802504046371,
> -2.4216068225364245, 3.0119599306499123, 2.5753099009496783,
> -2.9200121783556843, -2.519352725437922, -4.133932580227538,
> -2.30496316762808, 2.5381353678521363, 2.4818233632136697,
> 2.5277451177925685, -2.166465445816232, -2.1193897819471563,
> -2.109654332722425, 3.260211545834851, -3.9527673876059013,
> -2.199885089466947, 2.152573429747697, -3.1593894958496094,
> 2.5479522823226795, 3.342810742466116, -2.8197184957304007,
> -2.3407900299253765, -2.3303967152728537, 2.1760131201015565,
> 2.143930552944634, 2.6231754409, 2.9126278362420575, -2.121169134387265,
> -2.2980208408109095, -2.285400411434817, -2.0742764640932903,
> 2.304178664095016, -2.2893825538911634, -3.7714771984158806,
> -2.7153698816026886, 2.8995011276220226, -2.158787087333056,
> -2.1045987952052547, 2.8478762016468147, -2.694578565956955,
> -2.696014432856399, -2.3190122657403496, -2.48225194403028,
> 3.3393947563371764, 2.7775468034263517,
[jira] [Commented] (MATH-1475) KS test throw MathInternalError: illegal state
[
https://issues.apache.org/jira/browse/MATH-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811393#comment-16811393
]
Chao Xue commented on MATH-1475:
I used the snaphot in
[github|[https://github.com/jcastro-inf/commons-math4|https://github.com/jcastro-inf/commons-math4].]].
> KS test throw MathInternalError: illegal state
> --
>
> Key: MATH-1475
> URL: https://issues.apache.org/jira/browse/MATH-1475
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: Windows 10 (Professional)
> JDK 8
>Reporter: Chao Xue
>Priority: Critical
> Attachments: Figure_1.png
>
>
> {code:java}
> public class CC {
> public static void main(String []args) throws Exception{
> double[]x=new double[]{0.12350159883499146, -0.2601194679737091,
> -1.322849988937378, 0.379696249961853, 0.3987586498260498,
> -0.06924121081829071, -0.13951236009597778, 0.3213207423686981,
> 0.7949811816215515, -0.15811105072498322, 0.19912190735340118,
> -0.46363770961761475, -0.20019817352294922, 0.3062838613986969,
> -0.3872813880443573, 0.10733723640441895, 0.10910066962242126,
> 0.625770092010498, 0.2824835777282715, 0.3107619881629944,
> 0.1432388722896576, -0.08056988567113876, -0.5816712379455566,
> -0.09488576650619507, -0.2154506891965866, 0.2509046196937561,
> -0.06600788980722427, -0.01133995596319437, -0.22642627358436584,
> -0.12150175869464874, -0.21109570562839508, -0.17732949554920197,
> -0.2769380807876587, -0.3607368767261505, -0.07842907309532166,
> -0.2518743574619293, 0.035517483949661255, -0.6556509137153625,
> -0.360045850276947, -0.09371964633464813, -0.7284095883369446,
> -0.22719840705394745, -1.5540679693222046, -0.008972732350230217,
> -0.09106933325529099, -0.6465389132499695, 0.036245591938495636,
> 0.657580554485321, 0.32453101873397827, 0.6105462908744812,
> 0.25256943702697754, -0.194427490234375, 0.6238796710968018,
> 0.52035855, -0.2708645761013031, 0.07761227339506149,
> 0.5315862894058228, 0.44320303201675415, 0.6283767819404602,
> 0.2618369162082672, 0.47253096103668213, 0.3889777660369873,
> 0.6856100559234619, 0.3007083833217621, 0.4963226914405823,
> 0.08229698985815048, 0.6170856952667236, 0.7501978874206543,
> 0.5744063258171082, 0.5233180522918701, 0.32654184103012085,
> 0.3014495372772217, 0.4082445800304413, -0.1075737327337265,
> -0.018864337354898453, 0.34642550349235535, 0.6414541602134705,
> 0.16678297519683838, 0.46028634905815125, 0.4151197075843811,
> 0.14407725632190704, 0.41751566529273987, -0.054958608001470566,
> 0.4995657801628113, 0.4485369324684143, 0.5600396990776062,
> 0.4098612368106842, 0.2748555839061737, 0.2562614381313324,
> 0.4324824810028076};
> double[]y=new double[]{2.6881366763426717, 2.685469965655465,
> 2.261888917462379, -2.1933598759641226, -2.4279488152810145,
> -3.159389495849609, -2.3150004548153444, 2.468029206047388,
> 2.9442494682288953, 2.653360013462529, -2.1189940659194835,
> -2.121635289903703, -2.103092459792032, -2.737034221468073,
> -2.203389332350286, 2.1985949039005512, -2.5021604073154737,
> 2.2732754920764533, -2.3867025598454346, 2.135919387338413,
> 2.338120776050672, 2.2579794509726874, 2.083329059799027, -2.209733724709957,
> 2.297192240399189, -2.201703830825843, -3.460208691996806, 2.428839296615834,
> -3.2944259224581574, 2.0654875493620883, -2.743948930837782,
> -2.2240674680805212, -3.646366778182357, -2.12513198437294,
> 2.979166188824589, -2.6275491570089033, -2.3818176136461338,
> 2.882096356968376, -2.2147229261558334, -3.159389495849609,
> 2.312428759406432, 2.3313864098846477, -2.72802504046371,
> -2.4216068225364245, 3.0119599306499123, 2.5753099009496783,
> -2.9200121783556843, -2.519352725437922, -4.133932580227538,
> -2.30496316762808, 2.5381353678521363, 2.4818233632136697,
> 2.5277451177925685, -2.166465445816232, -2.1193897819471563,
> -2.109654332722425, 3.260211545834851, -3.9527673876059013,
> -2.199885089466947, 2.152573429747697, -3.1593894958496094,
> 2.5479522823226795, 3.342810742466116, -2.8197184957304007,
> -2.3407900299253765, -2.3303967152728537, 2.1760131201015565,
> 2.143930552944634, 2.6231754409, 2.9126278362420575, -2.121169134387265,
> -2.2980208408109095, -2.285400411434817, -2.0742764640932903,
> 2.304178664095016, -2.2893825538911634, -3.7714771984158806,
> -2.7153698816026886, 2.8995011276220226, -2.158787087333056,
> -2.1045987952052547, 2.8478762016468147, -2.694578565956955,
> -2.696014432856399, -2.3190122657403496, -2.48225194403028,
> 3.3393947563371764, 2.7775468034263517, -3.396526561479875,
> -2.699967947404961};
> KolmogorovSmirnovTest kst=new KolmogorovSmirnovTest();
> double p=kst.kolmogorovSmirnovTest(x, y);
> System.out.println(p);
> }
> }
> {code}
> Results:
> run:
> Exception in thread
[jira] [Commented] (GEOMETRY-29) Plane API cleanup
[
https://issues.apache.org/jira/browse/GEOMETRY-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811330#comment-16811330
]
Gilles commented on GEOMETRY-29:
{quote}what do you think?
{quote}
I'd assume that if you wonder, it is better, at this point, to say "no" to both.
It's of course good to leave a note (code comment) and revisit later.
> Plane API cleanup
> -
>
> Key: GEOMETRY-29
> URL: https://issues.apache.org/jira/browse/GEOMETRY-29
> Project: Apache Commons Geometry
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Labels: pull-request-available
>
> The following changes should be made to the
> {{o.a.c.g.euclidean.threed.Plane}} class:
> * make the class immutable
> * use well-named factory methods instead of constructor overloads
> * provide a factory method to create a plane with user-supplied {{u}} and
> {{v}} axes. The current implementation allows the normal to be provided but
> chooses its own planar axes (see {{setFrame}}).
> * add {{equals}}, {{hashCode}}, and {{toString}} methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (STATISTICS-7) Stream-based Java statistical processing
[ https://issues.apache.org/jira/browse/STATISTICS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811219#comment-16811219 ] Udit Arora commented on STATISTICS-7: - Sir Gilles I have made some changes, and am open to all feedback you give. Please let me know what to improve. Thanks. > Stream-based Java statistical processing > > > Key: STATISTICS-7 > URL: https://issues.apache.org/jira/browse/STATISTICS-7 > Project: Apache Commons Statistics > Issue Type: New Feature >Reporter: Eric Barnhill >Priority: Major > Labels: GSoC2019, gsoc2019, statistics, streams > > The new component aims to be a library of commons statistics functions > synchronized with the latest developments in the Java language, in particular > Java's functional programming syntax. > The library will make commonly used statistical functions available to an end > user through a simple grammar comparable to commons-math-statistics or > scikit-learn, while under the hood will implement Java's mapping, streaming, > and other producer and consumer functions to ensure the statistical methods > run optimally in new Java implementations. > Developers working on the project will have the opportunity to demonstrate > Java programming, functional programming, algorithm design, and data science > skills and receive authorship on a commons project that is likely to be > widely used. > The ideal contributor will also be able to help with important architectural > decision making. The old source of these libraries, commons-math, grew too > large, hierarchically complex and interdependent for the commons mission. The > developers on this project need to make architectural choices that will > enable the statiscal code to be lightweight and reusable, with a minimum of > outside dependencies while avoiding redundancy. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (IO-605) Add class CanExecuteFileFilter
[
https://issues.apache.org/jira/browse/IO-605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory closed IO-605.
---
Resolution: Fixed
Fix Version/s: 2.7
In git master.
> Add class CanExecuteFileFilter
> --
>
> Key: IO-605
> URL: https://issues.apache.org/jira/browse/IO-605
> Project: Commons IO
> Issue Type: Improvement
> Components: Filters
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 2.7
>
>
> Add class {{CanExecuteFileFilter}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IO-605) Add class CanExecuteFileFilter
Gary Gregory created IO-605:
---
Summary: Add class CanExecuteFileFilter
Key: IO-605
URL: https://issues.apache.org/jira/browse/IO-605
Project: Commons IO
Issue Type: Improvement
Components: Filters
Reporter: Gary Gregory
Assignee: Gary Gregory
Add class {{CanExecuteFileFilter}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter resolved LANG-1443. --- Resolution: Fixed Fixed in 6e797a40a7fb7d0e5abf555c0d179dd3937bdecb > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223688=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223688 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 16:33 Start Date: 05/Apr/19 16:33 Worklog Time Spent: 10m Work Description: britter commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223688) Time Spent: 1.5h (was: 1h 20m) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] britter merged pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
britter merged pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223686 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 16:31 Start Date: 05/Apr/19 16:31 Worklog Time Spent: 10m Work Description: coveralls commented on issue #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#issuecomment-480340056 [](https://coveralls.io/builds/22629915) Coverage increased (+0.002%) to 95.409% when pulling **2836ee0c3cf06c67be20b56ed5d062bb0b209e53 on britter:bene/LANG-1443** into **3e37b25ebcc33134bd5d9476c00c5ed48477b0cf on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223686) Time Spent: 1h 20m (was: 1h 10m) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] coveralls commented on issue #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
coveralls commented on issue #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#issuecomment-480340056 [](https://coveralls.io/builds/22629915) Coverage increased (+0.002%) to 95.409% when pulling **2836ee0c3cf06c67be20b56ed5d062bb0b209e53 on britter:bene/LANG-1443** into **3e37b25ebcc33134bd5d9476c00c5ed48477b0cf on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FILEUPLOAD-297) Default maximum sizes for requests and files
Artem Smotrakov created FILEUPLOAD-297: -- Summary: Default maximum sizes for requests and files Key: FILEUPLOAD-297 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-297 Project: Commons FileUpload Issue Type: Improvement Reporter: Artem Smotrakov Attachments: default_upload_size_limits_v1.patch Currently FileUpload allows setting the maximum allowed size of a complete request and the maximum allowed size of a file to be uploaded. However the library doesn't set any default limitations. Introducing default values may be a little defense-in-depth measure to reduce a risk of (D)DoS attacks for applications which forgot to set such limits. Here is how other libraries/servers set such default values: # nginx sets the maximum allowed size of the client request body to 1MB ## [http://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size] # By default, the IIS 7 upload limit is 30MB ## [https://docs.microsoft.com/en-us/windows/desktop/bits/upload-limits] # PHP sets max size of post data allowed to 8MB. PHP also sets the maximum size of an uploaded file to 2MB ## [https://www.php.net/manual/en/ini.core.php#ini.post-max-size] ## [https://www.php.net/manual/en/ini.core.php#ini.upload-max-filesize] # Spring Boot specifies the maximum size permitted for uploaded files. The default is 1MB. It also specifies the maximum size allowed for multipart/form-data requests. The default is 10MB. ## [https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/autoconfigure/web/servlet/MultipartProperties.html] As you can see, default values look pretty different. I am attaching a patch which sets the maximum file size to 2MB and the maximum size of a request to 10MB. Adding such limits by default introduces a risk that some applications may break, so maybe the numbers should be higher. Please let me know if such an update is okay, and I'll create a pull request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FILEUPLOAD-297) Default maximum sizes for requests and files
[ https://issues.apache.org/jira/browse/FILEUPLOAD-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Smotrakov updated FILEUPLOAD-297: --- Attachment: default_upload_size_limits_v1.patch > Default maximum sizes for requests and files > > > Key: FILEUPLOAD-297 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-297 > Project: Commons FileUpload > Issue Type: Improvement >Reporter: Artem Smotrakov >Priority: Major > Attachments: default_upload_size_limits_v1.patch > > > Currently FileUpload allows setting the maximum allowed size of a complete > request and the maximum allowed size of a file to be uploaded. However the > library doesn't set any default limitations. Introducing default values may > be a little defense-in-depth measure to reduce a risk of (D)DoS attacks for > applications which forgot to set such limits. > Here is how other libraries/servers set such default values: > # nginx sets the maximum allowed size of the client request body to 1MB > ## > [http://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size] > # By default, the IIS 7 upload limit is 30MB > ## [https://docs.microsoft.com/en-us/windows/desktop/bits/upload-limits] > # PHP sets max size of post data allowed to 8MB. PHP also sets the maximum > size of an uploaded file to 2MB > ## [https://www.php.net/manual/en/ini.core.php#ini.post-max-size] > ## [https://www.php.net/manual/en/ini.core.php#ini.upload-max-filesize] > # Spring Boot specifies the maximum size permitted for uploaded files. The > default is 1MB. It also specifies the maximum size allowed for > multipart/form-data requests. The default is 10MB. > ## > [https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/autoconfigure/web/servlet/MultipartProperties.html] > As you can see, default values look pretty different. I am attaching a patch > which sets the maximum file size to 2MB and the maximum size of a request to > 10MB. Adding such limits by default introduces a risk that some applications > may break, so maybe the numbers should be higher. Please let me know if such > an update is okay, and I'll create a pull request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] britter commented on issue #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
britter commented on issue #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#issuecomment-480334341 Fixed the Checkstyle problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223679=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223679 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 16:13 Start Date: 05/Apr/19 16:13 Worklog Time Spent: 10m Work Description: britter commented on issue #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#issuecomment-480334341 Fixed the Checkstyle problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223679) Time Spent: 1h 10m (was: 1h) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (IO-604) FileUtils.doCopyFile(File, File, boolean) can throw ClosedByInterruptException
[
https://issues.apache.org/jira/browse/IO-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory closed IO-604.
---
Resolution: Fixed
Fix Version/s: 2.7
In git master.
> FileUtils.doCopyFile(File, File, boolean) can throw ClosedByInterruptException
> --
>
> Key: IO-604
> URL: https://issues.apache.org/jira/browse/IO-604
> Project: Commons IO
> Issue Type: Bug
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 2.7
>
>
> The method {{FileUtils.doCopyFile(File, File, boolean)}} can throw
> {{ClosedByInterruptException}} apparently randomly:
> {noformat}
> Thread [main] (Suspended (entry into method in
> ClosedByInterruptException))
> owns: Object (id=405)
> owns: AbstractComponentSubManager$3 (id=406)
> owns: RunnableLock (id=407)
> ClosedByInterruptException.() line: 51
> FileChannelImpl(AbstractInterruptibleChannel).end(boolean)
> line: 202
> FileChannelImpl.size() line: 315
> FileUtils.doCopyFile(File, File, boolean) line: 1145
>
> FileUtils.copyFile(File, File, boolean) line: 1088
> FileUtils.copyFile(File, File) line: 1040
> ... Stack frames from my app...
> {noformat}
> I want o try to workaround this by updating {{doCopyFile}} to use Java 7's
> {{Files.copy(Path,Path,CopyOptions)}} API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IO-604) FileUtils.doCopyFile(File, File, boolean) can throw ClosedByInterruptException
[
https://issues.apache.org/jira/browse/IO-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory updated IO-604:
Description:
The method {{FileUtils.doCopyFile(File, File, boolean)}} can throw
{{ClosedByInterruptException}} apparently randomly:
{noformat}
Thread [main] (Suspended (entry into method in
ClosedByInterruptException))
owns: Object (id=405)
owns: AbstractComponentSubManager$3 (id=406)
owns: RunnableLock (id=407)
ClosedByInterruptException.() line: 51
FileChannelImpl(AbstractInterruptibleChannel).end(boolean)
line: 202
FileChannelImpl.size() line: 315
FileUtils.doCopyFile(File, File, boolean) line: 1145
FileUtils.copyFile(File, File, boolean) line: 1088
FileUtils.copyFile(File, File) line: 1040
... Stack frames from my app...
{noformat}
I want to workaround this by updating {{doCopyFile}} to use Java 7's
{{Files.copy(Path,Path,CopyOptions)}} API.
was:
The method {{FileUtils.doCopyFile(File, File, boolean)}} can throw
{{ClosedByInterruptException}} apparently randomly:
{noformat}
Thread [main] (Suspended (entry into method in
ClosedByInterruptException))
owns: Object (id=405)
owns: AbstractComponentSubManager$3 (id=406)
owns: RunnableLock (id=407)
ClosedByInterruptException.() line: 51
FileChannelImpl(AbstractInterruptibleChannel).end(boolean)
line: 202
FileChannelImpl.size() line: 315
FileUtils.doCopyFile(File, File, boolean) line: 1145
FileUtils.copyFile(File, File, boolean) line: 1088
FileUtils.copyFile(File, File) line: 1040
... Stack frames from my app...
{noformat}
I want o try to workaround this by updating {{doCopyFile}} to use Java 7's
{{Files.copy(Path,Path,CopyOptions)}} API.
> FileUtils.doCopyFile(File, File, boolean) can throw ClosedByInterruptException
> --
>
> Key: IO-604
> URL: https://issues.apache.org/jira/browse/IO-604
> Project: Commons IO
> Issue Type: Bug
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 2.7
>
>
> The method {{FileUtils.doCopyFile(File, File, boolean)}} can throw
> {{ClosedByInterruptException}} apparently randomly:
> {noformat}
> Thread [main] (Suspended (entry into method in
> ClosedByInterruptException))
> owns: Object (id=405)
> owns: AbstractComponentSubManager$3 (id=406)
> owns: RunnableLock (id=407)
> ClosedByInterruptException.() line: 51
> FileChannelImpl(AbstractInterruptibleChannel).end(boolean)
> line: 202
> FileChannelImpl.size() line: 315
> FileUtils.doCopyFile(File, File, boolean) line: 1145
>
> FileUtils.copyFile(File, File, boolean) line: 1088
> FileUtils.copyFile(File, File) line: 1040
> ... Stack frames from my app...
> {noformat}
> I want to workaround this by updating {{doCopyFile}} to use Java 7's
> {{Files.copy(Path,Path,CopyOptions)}} API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IO-604) FileUtils.doCopyFile(File, File, boolean) can throw ClosedByInterruptException
Gary Gregory created IO-604:
---
Summary: FileUtils.doCopyFile(File, File, boolean) can throw
ClosedByInterruptException
Key: IO-604
URL: https://issues.apache.org/jira/browse/IO-604
Project: Commons IO
Issue Type: Bug
Reporter: Gary Gregory
Assignee: Gary Gregory
The method {{FileUtils.doCopyFile(File, File, boolean)}} can throw
{{ClosedByInterruptException}} apparently randomly:
{noformat}
Thread [main] (Suspended (entry into method in
ClosedByInterruptException))
owns: Object (id=405)
owns: AbstractComponentSubManager$3 (id=406)
owns: RunnableLock (id=407)
ClosedByInterruptException.() line: 51
FileChannelImpl(AbstractInterruptibleChannel).end(boolean)
line: 202
FileChannelImpl.size() line: 315
FileUtils.doCopyFile(File, File, boolean) line: 1145
FileUtils.copyFile(File, File, boolean) line: 1088
FileUtils.copyFile(File, File) line: 1040
... Stack frames from my app...
{noformat}
I want o try to workaround this by updating {{doCopyFile}} to use Java 7's
{{Files.copy(Path,Path,CopyOptions)}} API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (IO-386) FileUtils.doCopyFile uses different methods to check the file sizes
[
https://issues.apache.org/jira/browse/IO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810876#comment-16810876
]
Gary Gregory edited comment on IO-386 at 4/5/19 2:37 PM:
-
Won't this become moot if we call {{Files.copy(Path,Path,CopyOptions)}} within
this API?
was (Author: garydgregory):
This will become moot if we call {{Files.copy(Path,Path,CopyOptions)}} within
this API.
> FileUtils.doCopyFile uses different methods to check the file sizes
> ---
>
> Key: IO-386
> URL: https://issues.apache.org/jira/browse/IO-386
> Project: Commons IO
> Issue Type: Bug
>Reporter: Sebb
>Priority: Minor
>
> FileUtils.doCopyFile uses FileChannel.size() to measure the input file length
> at the start, and File.length() to compare the lengths at the end.
> This is inconsistent.
> If there is a good reason for this it should be documented, otherwise it
> should probably use the same method for all the checks.
> [Note: is FileChannel.size() accurate if the file has not been flushed?]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (IO-386) FileUtils.doCopyFile uses different methods to check the file sizes
[
https://issues.apache.org/jira/browse/IO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810876#comment-16810876
]
Gary Gregory edited comment on IO-386 at 4/5/19 2:22 PM:
-
This will become moot if we call {{Files.copy(Path,Path,CopyOptions)}} within
this API.
was (Author: garydgregory):
This will become moot when we update to Java 8 where we can call
{{Files.copy(Path,Path,CopyOptions)}} within this API.
> FileUtils.doCopyFile uses different methods to check the file sizes
> ---
>
> Key: IO-386
> URL: https://issues.apache.org/jira/browse/IO-386
> Project: Commons IO
> Issue Type: Bug
>Reporter: Sebb
>Priority: Minor
>
> FileUtils.doCopyFile uses FileChannel.size() to measure the input file length
> at the start, and File.length() to compare the lengths at the end.
> This is inconsistent.
> If there is a good reason for this it should be documented, otherwise it
> should probably use the same method for all the checks.
> [Note: is FileChannel.size() accurate if the file has not been flushed?]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IO-386) FileUtils.doCopyFile uses different methods to check the file sizes
[
https://issues.apache.org/jira/browse/IO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810876#comment-16810876
]
Gary Gregory commented on IO-386:
-
This will become moot when we update to Java 8 where we can call
{{Files.copy(Path,Path,CopyOptions)}} within this API.
> FileUtils.doCopyFile uses different methods to check the file sizes
> ---
>
> Key: IO-386
> URL: https://issues.apache.org/jira/browse/IO-386
> Project: Commons IO
> Issue Type: Bug
>Reporter: Sebb
>Priority: Minor
>
> FileUtils.doCopyFile uses FileChannel.size() to measure the input file length
> at the start, and File.length() to compare the lengths at the end.
> This is inconsistent.
> If there is a good reason for this it should be documented, otherwise it
> should probably use the same method for all the checks.
> [Note: is FileChannel.size() accurate if the file has not been flushed?]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1475) KS test throw MathInternalError: illegal state
[
https://issues.apache.org/jira/browse/MATH-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810847#comment-16810847
]
Gilles commented on MATH-1475:
--
Which snaphot did you use?
In any case, please retry either with the latest snapshot from the [CI
system|https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-math4/4.0-SNAPSHOT/]
or with a JAR compiled from the latest version of the [source
code|https://gitbox.apache.org/repos/asf?p=commons-math.git].
On my machine, running (JDK 8), your case passed (I copied it as a unit test).
> KS test throw MathInternalError: illegal state
> --
>
> Key: MATH-1475
> URL: https://issues.apache.org/jira/browse/MATH-1475
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: Windows 10 (Professional)
> JDK 8
>Reporter: Chao Xue
>Priority: Critical
> Attachments: Figure_1.png
>
>
> {code:java}
> public class CC {
> public static void main(String []args) throws Exception{
> double[]x=new double[]{0.12350159883499146, -0.2601194679737091,
> -1.322849988937378, 0.379696249961853, 0.3987586498260498,
> -0.06924121081829071, -0.13951236009597778, 0.3213207423686981,
> 0.7949811816215515, -0.15811105072498322, 0.19912190735340118,
> -0.46363770961761475, -0.20019817352294922, 0.3062838613986969,
> -0.3872813880443573, 0.10733723640441895, 0.10910066962242126,
> 0.625770092010498, 0.2824835777282715, 0.3107619881629944,
> 0.1432388722896576, -0.08056988567113876, -0.5816712379455566,
> -0.09488576650619507, -0.2154506891965866, 0.2509046196937561,
> -0.06600788980722427, -0.01133995596319437, -0.22642627358436584,
> -0.12150175869464874, -0.21109570562839508, -0.17732949554920197,
> -0.2769380807876587, -0.3607368767261505, -0.07842907309532166,
> -0.2518743574619293, 0.035517483949661255, -0.6556509137153625,
> -0.360045850276947, -0.09371964633464813, -0.7284095883369446,
> -0.22719840705394745, -1.5540679693222046, -0.008972732350230217,
> -0.09106933325529099, -0.6465389132499695, 0.036245591938495636,
> 0.657580554485321, 0.32453101873397827, 0.6105462908744812,
> 0.25256943702697754, -0.194427490234375, 0.6238796710968018,
> 0.52035855, -0.2708645761013031, 0.07761227339506149,
> 0.5315862894058228, 0.44320303201675415, 0.6283767819404602,
> 0.2618369162082672, 0.47253096103668213, 0.3889777660369873,
> 0.6856100559234619, 0.3007083833217621, 0.4963226914405823,
> 0.08229698985815048, 0.6170856952667236, 0.7501978874206543,
> 0.5744063258171082, 0.5233180522918701, 0.32654184103012085,
> 0.3014495372772217, 0.4082445800304413, -0.1075737327337265,
> -0.018864337354898453, 0.34642550349235535, 0.6414541602134705,
> 0.16678297519683838, 0.46028634905815125, 0.4151197075843811,
> 0.14407725632190704, 0.41751566529273987, -0.054958608001470566,
> 0.4995657801628113, 0.4485369324684143, 0.5600396990776062,
> 0.4098612368106842, 0.2748555839061737, 0.2562614381313324,
> 0.4324824810028076};
> double[]y=new double[]{2.6881366763426717, 2.685469965655465,
> 2.261888917462379, -2.1933598759641226, -2.4279488152810145,
> -3.159389495849609, -2.3150004548153444, 2.468029206047388,
> 2.9442494682288953, 2.653360013462529, -2.1189940659194835,
> -2.121635289903703, -2.103092459792032, -2.737034221468073,
> -2.203389332350286, 2.1985949039005512, -2.5021604073154737,
> 2.2732754920764533, -2.3867025598454346, 2.135919387338413,
> 2.338120776050672, 2.2579794509726874, 2.083329059799027, -2.209733724709957,
> 2.297192240399189, -2.201703830825843, -3.460208691996806, 2.428839296615834,
> -3.2944259224581574, 2.0654875493620883, -2.743948930837782,
> -2.2240674680805212, -3.646366778182357, -2.12513198437294,
> 2.979166188824589, -2.6275491570089033, -2.3818176136461338,
> 2.882096356968376, -2.2147229261558334, -3.159389495849609,
> 2.312428759406432, 2.3313864098846477, -2.72802504046371,
> -2.4216068225364245, 3.0119599306499123, 2.5753099009496783,
> -2.9200121783556843, -2.519352725437922, -4.133932580227538,
> -2.30496316762808, 2.5381353678521363, 2.4818233632136697,
> 2.5277451177925685, -2.166465445816232, -2.1193897819471563,
> -2.109654332722425, 3.260211545834851, -3.9527673876059013,
> -2.199885089466947, 2.152573429747697, -3.1593894958496094,
> 2.5479522823226795, 3.342810742466116, -2.8197184957304007,
> -2.3407900299253765, -2.3303967152728537, 2.1760131201015565,
> 2.143930552944634, 2.6231754409, 2.9126278362420575, -2.121169134387265,
> -2.2980208408109095, -2.285400411434817, -2.0742764640932903,
> 2.304178664095016, -2.2893825538911634, -3.7714771984158806,
> -2.7153698816026886, 2.8995011276220226, -2.158787087333056,
> -2.1045987952052547, 2.8478762016468147, -2.694578565956955,
> -2.696014432856399, -2.3190122657403496,
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223549=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223549 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 11:42 Start Date: 05/Apr/19 11:42 Worklog Time Spent: 10m Work Description: britter commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272550718 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: Damn you, IntelliJ! Will fix that later today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223549) Time Spent: 1h (was: 50m) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 1h > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] britter commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
britter commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272550718 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: Damn you, IntelliJ! Will fix that later today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223531=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223531 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 10:58 Start Date: 05/Apr/19 10:58 Worklog Time Spent: 10m Work Description: chtompki commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: IntelliJ does that by default at greater than 5 import statements. It rewrites them with the * It drives me crazy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223531) Time Spent: 50m (was: 40m) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 50m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] chtompki commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
chtompki commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: IntelliJ does that by default at greater than 5 import statements. It rewrites them with the * It drives me crazy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223530=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223530 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 10:57 Start Date: 05/Apr/19 10:57 Worklog Time Spent: 10m Work Description: chtompki commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: IntelliJ does that by default at greater than 5 import statements. It rewrites them with the * This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223530) Time Spent: 40m (was: 0.5h) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 40m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] chtompki commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
chtompki commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272538761 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: IntelliJ does that by default at greater than 5 import statements. It rewrites them with the * This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223528=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223528 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 10:36 Start Date: 05/Apr/19 10:36 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272532497 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: Right, we need specific imports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223528) Time Spent: 0.5h (was: 20m) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] garydgregory commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
garydgregory commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272532497 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: Right, we need specific imports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MATH-1475) KS test throw MathInternalError: illegal state
[
https://issues.apache.org/jira/browse/MATH-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810534#comment-16810534
]
Chao Xue commented on MATH-1475:
It fails too when I used the development version (4.0-SNAPSHOT) with the same
Exception.
> KS test throw MathInternalError: illegal state
> --
>
> Key: MATH-1475
> URL: https://issues.apache.org/jira/browse/MATH-1475
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: Windows 10 (Professional)
> JDK 8
>Reporter: Chao Xue
>Priority: Critical
> Attachments: Figure_1.png
>
>
> {code:java}
> public class CC {
> public static void main(String []args) throws Exception{
> double[]x=new double[]{0.12350159883499146, -0.2601194679737091,
> -1.322849988937378, 0.379696249961853, 0.3987586498260498,
> -0.06924121081829071, -0.13951236009597778, 0.3213207423686981,
> 0.7949811816215515, -0.15811105072498322, 0.19912190735340118,
> -0.46363770961761475, -0.20019817352294922, 0.3062838613986969,
> -0.3872813880443573, 0.10733723640441895, 0.10910066962242126,
> 0.625770092010498, 0.2824835777282715, 0.3107619881629944,
> 0.1432388722896576, -0.08056988567113876, -0.5816712379455566,
> -0.09488576650619507, -0.2154506891965866, 0.2509046196937561,
> -0.06600788980722427, -0.01133995596319437, -0.22642627358436584,
> -0.12150175869464874, -0.21109570562839508, -0.17732949554920197,
> -0.2769380807876587, -0.3607368767261505, -0.07842907309532166,
> -0.2518743574619293, 0.035517483949661255, -0.6556509137153625,
> -0.360045850276947, -0.09371964633464813, -0.7284095883369446,
> -0.22719840705394745, -1.5540679693222046, -0.008972732350230217,
> -0.09106933325529099, -0.6465389132499695, 0.036245591938495636,
> 0.657580554485321, 0.32453101873397827, 0.6105462908744812,
> 0.25256943702697754, -0.194427490234375, 0.6238796710968018,
> 0.52035855, -0.2708645761013031, 0.07761227339506149,
> 0.5315862894058228, 0.44320303201675415, 0.6283767819404602,
> 0.2618369162082672, 0.47253096103668213, 0.3889777660369873,
> 0.6856100559234619, 0.3007083833217621, 0.4963226914405823,
> 0.08229698985815048, 0.6170856952667236, 0.7501978874206543,
> 0.5744063258171082, 0.5233180522918701, 0.32654184103012085,
> 0.3014495372772217, 0.4082445800304413, -0.1075737327337265,
> -0.018864337354898453, 0.34642550349235535, 0.6414541602134705,
> 0.16678297519683838, 0.46028634905815125, 0.4151197075843811,
> 0.14407725632190704, 0.41751566529273987, -0.054958608001470566,
> 0.4995657801628113, 0.4485369324684143, 0.5600396990776062,
> 0.4098612368106842, 0.2748555839061737, 0.2562614381313324,
> 0.4324824810028076};
> double[]y=new double[]{2.6881366763426717, 2.685469965655465,
> 2.261888917462379, -2.1933598759641226, -2.4279488152810145,
> -3.159389495849609, -2.3150004548153444, 2.468029206047388,
> 2.9442494682288953, 2.653360013462529, -2.1189940659194835,
> -2.121635289903703, -2.103092459792032, -2.737034221468073,
> -2.203389332350286, 2.1985949039005512, -2.5021604073154737,
> 2.2732754920764533, -2.3867025598454346, 2.135919387338413,
> 2.338120776050672, 2.2579794509726874, 2.083329059799027, -2.209733724709957,
> 2.297192240399189, -2.201703830825843, -3.460208691996806, 2.428839296615834,
> -3.2944259224581574, 2.0654875493620883, -2.743948930837782,
> -2.2240674680805212, -3.646366778182357, -2.12513198437294,
> 2.979166188824589, -2.6275491570089033, -2.3818176136461338,
> 2.882096356968376, -2.2147229261558334, -3.159389495849609,
> 2.312428759406432, 2.3313864098846477, -2.72802504046371,
> -2.4216068225364245, 3.0119599306499123, 2.5753099009496783,
> -2.9200121783556843, -2.519352725437922, -4.133932580227538,
> -2.30496316762808, 2.5381353678521363, 2.4818233632136697,
> 2.5277451177925685, -2.166465445816232, -2.1193897819471563,
> -2.109654332722425, 3.260211545834851, -3.9527673876059013,
> -2.199885089466947, 2.152573429747697, -3.1593894958496094,
> 2.5479522823226795, 3.342810742466116, -2.8197184957304007,
> -2.3407900299253765, -2.3303967152728537, 2.1760131201015565,
> 2.143930552944634, 2.6231754409, 2.9126278362420575, -2.121169134387265,
> -2.2980208408109095, -2.285400411434817, -2.0742764640932903,
> 2.304178664095016, -2.2893825538911634, -3.7714771984158806,
> -2.7153698816026886, 2.8995011276220226, -2.158787087333056,
> -2.1045987952052547, 2.8478762016468147, -2.694578565956955,
> -2.696014432856399, -2.3190122657403496, -2.48225194403028,
> 3.3393947563371764, 2.7775468034263517, -3.396526561479875,
> -2.699967947404961};
> KolmogorovSmirnovTest kst=new KolmogorovSmirnovTest();
> double p=kst.kolmogorovSmirnovTest(x, y);
> System.out.println(p);
> }
> }
> {code}
> Results:
> run:
> Exception in thread "main"
>
[jira] [Commented] (MATH-1475) KS test throw MathInternalError: illegal state
[
https://issues.apache.org/jira/browse/MATH-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810533#comment-16810533
]
Chao Xue commented on MATH-1475:
It fails too when I used the development version (4.0-SNAPSHOT) with the same
Exception.
> KS test throw MathInternalError: illegal state
> --
>
> Key: MATH-1475
> URL: https://issues.apache.org/jira/browse/MATH-1475
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: Windows 10 (Professional)
> JDK 8
>Reporter: Chao Xue
>Priority: Critical
> Attachments: Figure_1.png
>
>
> {code:java}
> public class CC {
> public static void main(String []args) throws Exception{
> double[]x=new double[]{0.12350159883499146, -0.2601194679737091,
> -1.322849988937378, 0.379696249961853, 0.3987586498260498,
> -0.06924121081829071, -0.13951236009597778, 0.3213207423686981,
> 0.7949811816215515, -0.15811105072498322, 0.19912190735340118,
> -0.46363770961761475, -0.20019817352294922, 0.3062838613986969,
> -0.3872813880443573, 0.10733723640441895, 0.10910066962242126,
> 0.625770092010498, 0.2824835777282715, 0.3107619881629944,
> 0.1432388722896576, -0.08056988567113876, -0.5816712379455566,
> -0.09488576650619507, -0.2154506891965866, 0.2509046196937561,
> -0.06600788980722427, -0.01133995596319437, -0.22642627358436584,
> -0.12150175869464874, -0.21109570562839508, -0.17732949554920197,
> -0.2769380807876587, -0.3607368767261505, -0.07842907309532166,
> -0.2518743574619293, 0.035517483949661255, -0.6556509137153625,
> -0.360045850276947, -0.09371964633464813, -0.7284095883369446,
> -0.22719840705394745, -1.5540679693222046, -0.008972732350230217,
> -0.09106933325529099, -0.6465389132499695, 0.036245591938495636,
> 0.657580554485321, 0.32453101873397827, 0.6105462908744812,
> 0.25256943702697754, -0.194427490234375, 0.6238796710968018,
> 0.52035855, -0.2708645761013031, 0.07761227339506149,
> 0.5315862894058228, 0.44320303201675415, 0.6283767819404602,
> 0.2618369162082672, 0.47253096103668213, 0.3889777660369873,
> 0.6856100559234619, 0.3007083833217621, 0.4963226914405823,
> 0.08229698985815048, 0.6170856952667236, 0.7501978874206543,
> 0.5744063258171082, 0.5233180522918701, 0.32654184103012085,
> 0.3014495372772217, 0.4082445800304413, -0.1075737327337265,
> -0.018864337354898453, 0.34642550349235535, 0.6414541602134705,
> 0.16678297519683838, 0.46028634905815125, 0.4151197075843811,
> 0.14407725632190704, 0.41751566529273987, -0.054958608001470566,
> 0.4995657801628113, 0.4485369324684143, 0.5600396990776062,
> 0.4098612368106842, 0.2748555839061737, 0.2562614381313324,
> 0.4324824810028076};
> double[]y=new double[]{2.6881366763426717, 2.685469965655465,
> 2.261888917462379, -2.1933598759641226, -2.4279488152810145,
> -3.159389495849609, -2.3150004548153444, 2.468029206047388,
> 2.9442494682288953, 2.653360013462529, -2.1189940659194835,
> -2.121635289903703, -2.103092459792032, -2.737034221468073,
> -2.203389332350286, 2.1985949039005512, -2.5021604073154737,
> 2.2732754920764533, -2.3867025598454346, 2.135919387338413,
> 2.338120776050672, 2.2579794509726874, 2.083329059799027, -2.209733724709957,
> 2.297192240399189, -2.201703830825843, -3.460208691996806, 2.428839296615834,
> -3.2944259224581574, 2.0654875493620883, -2.743948930837782,
> -2.2240674680805212, -3.646366778182357, -2.12513198437294,
> 2.979166188824589, -2.6275491570089033, -2.3818176136461338,
> 2.882096356968376, -2.2147229261558334, -3.159389495849609,
> 2.312428759406432, 2.3313864098846477, -2.72802504046371,
> -2.4216068225364245, 3.0119599306499123, 2.5753099009496783,
> -2.9200121783556843, -2.519352725437922, -4.133932580227538,
> -2.30496316762808, 2.5381353678521363, 2.4818233632136697,
> 2.5277451177925685, -2.166465445816232, -2.1193897819471563,
> -2.109654332722425, 3.260211545834851, -3.9527673876059013,
> -2.199885089466947, 2.152573429747697, -3.1593894958496094,
> 2.5479522823226795, 3.342810742466116, -2.8197184957304007,
> -2.3407900299253765, -2.3303967152728537, 2.1760131201015565,
> 2.143930552944634, 2.6231754409, 2.9126278362420575, -2.121169134387265,
> -2.2980208408109095, -2.285400411434817, -2.0742764640932903,
> 2.304178664095016, -2.2893825538911634, -3.7714771984158806,
> -2.7153698816026886, 2.8995011276220226, -2.158787087333056,
> -2.1045987952052547, 2.8478762016468147, -2.694578565956955,
> -2.696014432856399, -2.3190122657403496, -2.48225194403028,
> 3.3393947563371764, 2.7775468034263517, -3.396526561479875,
> -2.699967947404961};
> KolmogorovSmirnovTest kst=new KolmogorovSmirnovTest();
> double p=kst.kolmogorovSmirnovTest(x, y);
> System.out.println(p);
> }
> }
> {code}
> Results:
> run:
> Exception in thread "main"
>
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223463 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 06:27 Start Date: 05/Apr/19 06:27 Worklog Time Spent: 10m Work Description: kinow commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272457198 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: Checkstyle ain't happy with this .* import I think. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223463) Time Spent: 20m (was: 10m) > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 20m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] kinow commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
kinow commented on a change in pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415#discussion_r272457198 ## File path: src/test/java/org/apache/commons/lang3/JavaVersionTest.java ## @@ -20,23 +20,10 @@ import org.junit.jupiter.api.Test; -import static org.apache.commons.lang3.JavaVersion.JAVA_RECENT; +import static org.apache.commons.lang3.JavaVersion.*; Review comment: Checkstyle ain't happy with this .* import I think. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1443: -- External issue URL: https://github.com/apache/commons-lang/pull/415 External issue ID: 415 > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 10m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
[ https://issues.apache.org/jira/browse/LANG-1443?focusedWorklogId=223461=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223461 ] ASF GitHub Bot logged work on LANG-1443: Author: ASF GitHub Bot Created on: 05/Apr/19 06:10 Start Date: 05/Apr/19 06:10 Worklog Time Spent: 10m Work Description: britter commented on pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223461) Time Spent: 10m Remaining Estimate: 0h > Add more SystemUtils.IS_JAVA_XX variants > > > Key: LANG-1443 > URL: https://issues.apache.org/jira/browse/LANG-1443 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > Time Spent: 10m > Remaining Estimate: 0h > > We should add variants for SystemUtils.IS_JAVA_XX at least up until the next > EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [commons-lang] britter opened a new pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants
britter opened a new pull request #415: LANG-1443: Add more SystemUtils.IS_JAVA_XX variants URL: https://github.com/apache/commons-lang/pull/415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (LANG-1443) Add more SystemUtils.IS_JAVA_XX variants
Benedikt Ritter created LANG-1443: - Summary: Add more SystemUtils.IS_JAVA_XX variants Key: LANG-1443 URL: https://issues.apache.org/jira/browse/LANG-1443 Project: Commons Lang Issue Type: Improvement Components: lang.* Reporter: Benedikt Ritter Assignee: Benedikt Ritter Fix For: 3.9 We should add variants for SystemUtils.IS_JAVA_XX at least up until the next EA release which at the time of this writing it Java 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
