[GitHub] [commons-csv] ranjithrp commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings
ranjithrp commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings URL: https://github.com/apache/commons-csv/pull/46#issuecomment-506601977 > @ranjithrp > I would prefer to see a unit test that that compares your example input with an actual parsed row where each column value is asserted for its correctness. > Thank you, > Gary @garydgregory i have tried to do the same in src/test/java/org/apache/commons/csv/LexerTest.java. In one of the test case, i have set the boolean to true and shown how it is able to retrieve each token and have asserted the values also. In another test case, i have set the boolean to false and shown how the parser throws an exception while parsing a token with quotes within. Please let me know if you are looking for anything specific apart from this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] coveralls commented on issue #54: RNG-108: Update the SeedFactory to improve performance
coveralls commented on issue #54: RNG-108: Update the SeedFactory to improve performance URL: https://github.com/apache/commons-rng/pull/54#issuecomment-506571979 [](https://coveralls.io/builds/24257080) Coverage increased (+0.08%) to 99.025% when pulling **2779def49146a78426030a092a55e7e48a40c482 on aherbert:improvement-RNG-108** into **d8c46305620ae3033d4da1c64f427dc66926 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] aherbert opened a new pull request #54: RNG-108: Update the SeedFactory to improve performance
aherbert opened a new pull request #54: RNG-108: Update the SeedFactory to improve performance URL: https://github.com/apache/commons-rng/pull/54 - Use XorShift1024SPhi - Use a ReentrantLock for synchronization - Output arrays using blocks of numbers per synchronisation event This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] boris-petrov commented on issue #30: VFS-614 MonitorInputStream should not close the stream in "read"
boris-petrov commented on issue #30: VFS-614 MonitorInputStream should not close the stream in "read" URL: https://github.com/apache/commons-vfs/pull/30#issuecomment-506507895 @garydgregory - thank you very much! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly
[
https://issues.apache.org/jira/browse/NUMBERS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874441#comment-16874441
]
Heinrich Bohne commented on NUMBERS-119:
I've merged the master branch into PR #56. For some reason, this made the false
reports by Coveralls about uncovered lines in {{ArithmeticUtils}} go away. Now,
according to the report, the only line previously covered but now uncovered is
the line in {{reduce()}} that becomes unreachable after this change because the
numerator and denominator are now _always_ reduced to lowest terms, meaning
that line cannot possibly be covered by unit tests. But deleting the line would
be illegal unless the contract of the class were changed as well, because the
class' contract doesn't require the numerator and denominator to be reduced to
lowest terms, and changing the class' contract in this way seems to be outside
the scope of this ticket.
> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact
> that, when the biased exponent of a {{double}} value is {{0}} and the
> mantissa is not {{0}} (i.e. when the value represents a subnormal number),
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which
> is not very memory-efficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-csv] garydgregory commented on issue #43: CSVFormat#valiadte() does not account for allowDuplicateHeaderNames
garydgregory commented on issue #43: CSVFormat#valiadte() does not account for allowDuplicateHeaderNames URL: https://github.com/apache/commons-csv/pull/43#issuecomment-506452347 If you mean 1.7 ;-) then probably "within a few weeks" unless someone else gets to it before I do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-text] garydgregory commented on issue #115: Fix length change omission for StringSubstitutor cyclic detection
garydgregory commented on issue #115: Fix length change omission for StringSubstitutor cyclic detection URL: https://github.com/apache/commons-text/pull/115#issuecomment-506451825 I would like feedback from the community on whether or not this should be merged. A failing test would make this a no-brainer of course but I understand this might not be possible here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-vfs] garydgregory commented on issue #30: VFS-614 MonitorInputStream should not close the stream in "read"
garydgregory commented on issue #30: VFS-614 MonitorInputStream should not close the stream in "read" URL: https://github.com/apache/commons-vfs/pull/30#issuecomment-506451211 @boris-petrov : I merged #66 and pushed a snapshot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly
[
https://issues.apache.org/jira/browse/NUMBERS-119?focusedWorklogId=268689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268689
]
ASF GitHub Bot logged work on NUMBERS-119:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 17:51
Start Date: 27/Jun/19 17:51
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #56: NUMBERS-119: Correct
bug in BigFraction(double) constructor
URL: https://github.com/apache/commons-numbers/pull/56#issuecomment-504617374
[](https://coveralls.io/builds/24249469)
Coverage decreased (-0.03%) to 94.169% when pulling
**80a5e265eb8e5413e9f63f102a4dc814b07216b1 on Schamschi:NUMBERS-119** into
**b3890a0e5568f554cafff270b19c99dd932a4346 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268689)
Time Spent: 1h 10m (was: 1h)
> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact
> that, when the biased exponent of a {{double}} value is {{0}} and the
> mantissa is not {{0}} (i.e. when the value represents a subnormal number),
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which
> is not very memory-efficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] coveralls edited a comment on issue #56: NUMBERS-119: Correct bug in BigFraction(double) constructor
coveralls edited a comment on issue #56: NUMBERS-119: Correct bug in BigFraction(double) constructor URL: https://github.com/apache/commons-numbers/pull/56#issuecomment-504617374 [](https://coveralls.io/builds/24249469) Coverage decreased (-0.03%) to 94.169% when pulling **80a5e265eb8e5413e9f63f102a4dc814b07216b1 on Schamschi:NUMBERS-119** into **b3890a0e5568f554cafff270b19c99dd932a4346 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NUMBERS-122) Helper assertion methods in BigFractionTest not strict enough
[
https://issues.apache.org/jira/browse/NUMBERS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heinrich Bohne resolved NUMBERS-122.
Resolution: Fixed
Fix Version/s: 1.0
> Helper assertion methods in BigFractionTest not strict enough
> -
>
> Key: NUMBERS-122
> URL: https://issues.apache.org/jira/browse/NUMBERS-122
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Fix For: 1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The helper methods {{assertFraction(int, int, BigFraction)}} and
> {{assertFraction(long, long, BigFraction)}} don't check whether the numerator
> and denominator of the {{BigFraction}} are equivalent to the first two
> arguments. Rather, they check whether the numerator and denominator
> _truncated to an {{int}} or {{long}}_ are equal to the first two arguments.
> This is unsatisfactory and also probably not in the spirit of the creator of
> these methods.
> Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
> because an {{int}} can be cast to a {{long}} without loss of precision, so
> {{assertFraction(long, long, BigFraction)}} is sufficient to handle both
> {{int}} and {{long}} arguments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heinrich Bohne resolved NUMBERS-121.
Resolution: Fixed
Fix Version/s: 1.0
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Fix For: 1.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (VFS-719) Add methods to get the contents of file objects as strings
[ https://issues.apache.org/jira/browse/VFS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed VFS-719. Resolution: Fixed In git master. > Add methods to get the contents of file objects as strings > -- > > Key: VFS-719 > URL: https://issues.apache.org/jira/browse/VFS-719 > Project: Commons VFS > Issue Type: New Feature >Reporter: Gary Gregory >Assignee: Gary Gregory >Priority: Major > Fix For: 2.4 > > > Add methods to get the contents of file objects as strings as I keep on > coding the same patterns in different projects: > - org.apache.commons.vfs2.FileContent.getString(Charset) > - org.apache.commons.vfs2.FileContent.getString(String) > - org.apache.commons.vfs2.util.FileObjectUtils.getContentAsString(FileObject, > Charset) > - org.apache.commons.vfs2.util.FileObjectUtils.getContentAsString(FileObject, > String) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (VFS-720) Implement Closeable for RandomAccessContent #66
[
https://issues.apache.org/jira/browse/VFS-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory closed VFS-720.
Resolution: Fixed
in git master.
> Implement Closeable for RandomAccessContent #66
> ---
>
> Key: VFS-720
> URL: https://issues.apache.org/jira/browse/VFS-720
> Project: Commons VFS
> Issue Type: New Feature
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 2.4
>
>
> Implement {{Closeable}} for {{RandomAccessContent}} #66
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (VFS-720) Implement Closeable for RandomAccessContent #66
Gary Gregory created VFS-720:
Summary: Implement Closeable for RandomAccessContent #66
Key: VFS-720
URL: https://issues.apache.org/jira/browse/VFS-720
Project: Commons VFS
Issue Type: New Feature
Reporter: Gary Gregory
Assignee: Gary Gregory
Fix For: 2.4
Implement {{Closeable}} for {{RandomAccessContent}} #66
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-vfs] garydgregory merged pull request #66: Implement Closeable for RandomAccessContent
garydgregory merged pull request #66: Implement Closeable for RandomAccessContent URL: https://github.com/apache/commons-vfs/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (VFS-719) Add methods to get the contents of file objects as strings
Gary Gregory created VFS-719: Summary: Add methods to get the contents of file objects as strings Key: VFS-719 URL: https://issues.apache.org/jira/browse/VFS-719 Project: Commons VFS Issue Type: New Feature Reporter: Gary Gregory Assignee: Gary Gregory Fix For: 2.4 Add methods to get the contents of file objects as strings as I keep on coding the same patterns in different projects: - org.apache.commons.vfs2.FileContent.getString(Charset) - org.apache.commons.vfs2.FileContent.getString(String) - org.apache.commons.vfs2.util.FileObjectUtils.getContentAsString(FileObject, Charset) - org.apache.commons.vfs2.util.FileObjectUtils.getContentAsString(FileObject, String) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?focusedWorklogId=268580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268580
]
ASF GitHub Bot logged work on NUMBERS-121:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 14:52
Start Date: 27/Jun/19 14:52
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #58: NUMBERS-121:
Replace usages of deprecated HTML tag with MathJax
URL: https://github.com/apache/commons-numbers/pull/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268580)
Time Spent: 1h 40m (was: 1.5h)
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (NUMBERS-122) Helper assertion methods in BigFractionTest not strict enough
[
https://issues.apache.org/jira/browse/NUMBERS-122?focusedWorklogId=268581&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268581
]
ASF GitHub Bot logged work on NUMBERS-122:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 14:52
Start Date: 27/Jun/19 14:52
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #59: NUMBERS-122: Make
assertFraction(long, long, BigFraction) compare the…
URL: https://github.com/apache/commons-numbers/pull/59
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268581)
Time Spent: 0.5h (was: 20m)
> Helper assertion methods in BigFractionTest not strict enough
> -
>
> Key: NUMBERS-122
> URL: https://issues.apache.org/jira/browse/NUMBERS-122
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The helper methods {{assertFraction(int, int, BigFraction)}} and
> {{assertFraction(long, long, BigFraction)}} don't check whether the numerator
> and denominator of the {{BigFraction}} are equivalent to the first two
> arguments. Rather, they check whether the numerator and denominator
> _truncated to an {{int}} or {{long}}_ are equal to the first two arguments.
> This is unsatisfactory and also probably not in the spirit of the creator of
> these methods.
> Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
> because an {{int}} can be cast to a {{long}} without loss of precision, so
> {{assertFraction(long, long, BigFraction)}} is sufficient to handle both
> {{int}} and {{long}} arguments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] asfgit merged pull request #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax
asfgit merged pull request #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax URL: https://github.com/apache/commons-numbers/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-numbers] asfgit closed pull request #59: NUMBERS-122: Make assertFraction(long, long, BigFraction) compare the…
asfgit closed pull request #59: NUMBERS-122: Make assertFraction(long, long, BigFraction) compare the… URL: https://github.com/apache/commons-numbers/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (COLLECTIONS-722) IteratorUtils.chainedIterator() Performance Degrades
[ https://issues.apache.org/jira/browse/COLLECTIONS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] E P updated COLLECTIONS-722: Description: IteratorUtils.chainedIterator() performance degrades when chaining iterators with chained iterators. The slowdown appears to be exponential, based upon the number of chains created. The attached test shows the issue. As a reference, the same test below works as expected using Google's Guava Iterator.concat() functionality. It is possible I am misusing the API, but the javadoc did not indicate as much. was: IteratorUtils.chainedIterator() performance degrades when chaining iterators with chained iterators. The slowdown appears to be exponential, based upon the number of chains created. The attached test shows the issue. > IteratorUtils.chainedIterator() Performance Degrades > > > Key: COLLECTIONS-722 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-722 > Project: Commons Collections > Issue Type: Bug >Affects Versions: 4.1 >Reporter: E P >Priority: Major > Attachments: IteratorUtilsTest.java > > > IteratorUtils.chainedIterator() performance degrades when chaining iterators > with chained iterators. The slowdown appears to be exponential, based upon > the number of chains created. The attached test shows the issue. > As a reference, the same test below works as expected using Google's Guava > Iterator.concat() functionality. It is possible I am misusing the API, but > the javadoc did not indicate as much. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (COLLECTIONS-722) IteratorUtils.chainedIterator() Performance Degrades
E P created COLLECTIONS-722: --- Summary: IteratorUtils.chainedIterator() Performance Degrades Key: COLLECTIONS-722 URL: https://issues.apache.org/jira/browse/COLLECTIONS-722 Project: Commons Collections Issue Type: Bug Affects Versions: 4.1 Reporter: E P Attachments: IteratorUtilsTest.java IteratorUtils.chainedIterator() performance degrades when chaining iterators with chained iterators. The slowdown appears to be exponential, based upon the number of chains created. The attached test shows the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (NUMBERS-122) Helper assertion methods in BigFractionTest not strict enough
[
https://issues.apache.org/jira/browse/NUMBERS-122?focusedWorklogId=268513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268513
]
ASF GitHub Bot logged work on NUMBERS-122:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 12:59
Start Date: 27/Jun/19 12:59
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #59: NUMBERS-122: Make
assertFraction(long, long, BigFraction) compare the…
URL: https://github.com/apache/commons-numbers/pull/59#issuecomment-506335427
[](https://coveralls.io/builds/24243192)
Coverage remained the same at 94.196% when pulling
**3697cffeeb966556bd9a815dd75ec07ffd0fa159 on Schamschi:NUMBERS-122** into
**860adcdb865842f673ba5010ebcbfd501abcff8b on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268513)
Time Spent: 20m (was: 10m)
> Helper assertion methods in BigFractionTest not strict enough
> -
>
> Key: NUMBERS-122
> URL: https://issues.apache.org/jira/browse/NUMBERS-122
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The helper methods {{assertFraction(int, int, BigFraction)}} and
> {{assertFraction(long, long, BigFraction)}} don't check whether the numerator
> and denominator of the {{BigFraction}} are equivalent to the first two
> arguments. Rather, they check whether the numerator and denominator
> _truncated to an {{int}} or {{long}}_ are equal to the first two arguments.
> This is unsatisfactory and also probably not in the spirit of the creator of
> these methods.
> Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
> because an {{int}} can be cast to a {{long}} without loss of precision, so
> {{assertFraction(long, long, BigFraction)}} is sufficient to handle both
> {{int}} and {{long}} arguments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] coveralls commented on issue #59: NUMBERS-122: Make assertFraction(long, long, BigFraction) compare the…
coveralls commented on issue #59: NUMBERS-122: Make assertFraction(long, long, BigFraction) compare the… URL: https://github.com/apache/commons-numbers/pull/59#issuecomment-506335427 [](https://coveralls.io/builds/24243192) Coverage remained the same at 94.196% when pulling **3697cffeeb966556bd9a815dd75ec07ffd0fa159 on Schamschi:NUMBERS-122** into **860adcdb865842f673ba5010ebcbfd501abcff8b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?focusedWorklogId=268487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268487
]
ASF GitHub Bot logged work on NUMBERS-121:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 12:11
Start Date: 27/Jun/19 12:11
Worklog Time Spent: 10m
Work Description: Schamschi commented on pull request #58: NUMBERS-121:
Replace usages of deprecated HTML tag with MathJax
URL: https://github.com/apache/commons-numbers/pull/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268487)
Time Spent: 1.5h (was: 1h 20m)
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] Schamschi commented on issue #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax
Schamschi commented on issue #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax URL: https://github.com/apache/commons-numbers/pull/58#issuecomment-506319887 @aherbert Yeah, you're right, my closing of this pull request was a bit rash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?focusedWorklogId=268486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268486
]
ASF GitHub Bot logged work on NUMBERS-121:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 12:11
Start Date: 27/Jun/19 12:11
Worklog Time Spent: 10m
Work Description: Schamschi commented on issue #58: NUMBERS-121: Replace
usages of deprecated HTML tag with MathJax
URL: https://github.com/apache/commons-numbers/pull/58#issuecomment-506319887
@aherbert Yeah, you're right, my closing of this pull request was a bit rash.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268486)
Time Spent: 1h 20m (was: 1h 10m)
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] Schamschi opened a new pull request #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax
Schamschi opened a new pull request #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax URL: https://github.com/apache/commons-numbers/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-numbers] aherbert commented on issue #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax
aherbert commented on issue #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax URL: https://github.com/apache/commons-numbers/pull/58#issuecomment-506315396 No reason to close this. The deprecated `` tag should be replaced with something. At least then the Javadoc will build. The MathJax can always be reverted to HTML tags later if required. Without this PR the build is broken. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?focusedWorklogId=268473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268473
]
ASF GitHub Bot logged work on NUMBERS-121:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 11:55
Start Date: 27/Jun/19 11:55
Worklog Time Spent: 10m
Work Description: aherbert commented on issue #58: NUMBERS-121: Replace
usages of deprecated HTML tag with MathJax
URL: https://github.com/apache/commons-numbers/pull/58#issuecomment-506315396
No reason to close this. The deprecated `` tag should be replaced with
something. At least then the Javadoc will build. The MathJax can always be
reverted to HTML tags later if required. Without this PR the build is
broken.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268473)
Time Spent: 1h 10m (was: 1h)
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (NUMBERS-122) Helper assertion methods in BigFractionTest not strict enough
[
https://issues.apache.org/jira/browse/NUMBERS-122?focusedWorklogId=268465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268465
]
ASF GitHub Bot logged work on NUMBERS-122:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 11:48
Start Date: 27/Jun/19 11:48
Worklog Time Spent: 10m
Work Description: Schamschi commented on pull request #59: NUMBERS-122:
Make assertFraction(long, long, BigFraction) compare the…
URL: https://github.com/apache/commons-numbers/pull/59
… full numerator and denominator
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268465)
Time Spent: 10m
Remaining Estimate: 0h
> Helper assertion methods in BigFractionTest not strict enough
> -
>
> Key: NUMBERS-122
> URL: https://issues.apache.org/jira/browse/NUMBERS-122
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The helper methods {{assertFraction(int, int, BigFraction)}} and
> {{assertFraction(long, long, BigFraction)}} don't check whether the numerator
> and denominator of the {{BigFraction}} are equivalent to the first two
> arguments. Rather, they check whether the numerator and denominator
> _truncated to an {{int}} or {{long}}_ are equal to the first two arguments.
> This is unsatisfactory and also probably not in the spirit of the creator of
> these methods.
> Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
> because an {{int}} can be cast to a {{long}} without loss of precision, so
> {{assertFraction(long, long, BigFraction)}} is sufficient to handle both
> {{int}} and {{long}} arguments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] Schamschi opened a new pull request #59: NUMBERS-122: Make assertFraction(long, long, BigFraction) compare the…
Schamschi opened a new pull request #59: NUMBERS-122: Make assertFraction(long, long, BigFraction) compare the… URL: https://github.com/apache/commons-numbers/pull/59 … full numerator and denominator This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NUMBERS-122) Helper assertion methods in BigFractionTest not strict enough
[
https://issues.apache.org/jira/browse/NUMBERS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Heinrich Bohne updated NUMBERS-122:
---
Description:
The helper methods {{assertFraction(int, int, BigFraction)}} and
{{assertFraction(long, long, BigFraction)}} don't check whether the numerator
and denominator of the {{BigFraction}} are equivalent to the first two
arguments. Rather, they check whether the numerator and denominator _truncated
to an {{int}} or {{long}}_ are equal to the first two arguments. This is
unsatisfactory and also probably not in the spirit of the creator of these
methods.
Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
because an {{int}} can be cast to a {{long}} without loss of precision, so
{{assertFraction(long, long, BigFraction)}} is sufficient to handle both
{{int}} and {{long}} arguments.
was:The helper methods {{assertFraction(int, int, BigFraction)}} and
{{assertFraction(long, long, BigFraction)}} don't check whether the numerator
and denominator of the {{BigFraction}} are equivalent to the first two
arguments. Rather, they check whether the numerator and denominator _truncated
to an {{int}} or {{long}}_ are equal to the first two arguments. This is
unsatisfactory and also probably not in the spirit of the creator of these
methods.
> Helper assertion methods in BigFractionTest not strict enough
> -
>
> Key: NUMBERS-122
> URL: https://issues.apache.org/jira/browse/NUMBERS-122
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>
> The helper methods {{assertFraction(int, int, BigFraction)}} and
> {{assertFraction(long, long, BigFraction)}} don't check whether the numerator
> and denominator of the {{BigFraction}} are equivalent to the first two
> arguments. Rather, they check whether the numerator and denominator
> _truncated to an {{int}} or {{long}}_ are equal to the first two arguments.
> This is unsatisfactory and also probably not in the spirit of the creator of
> these methods.
> Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
> because an {{int}} can be cast to a {{long}} without loss of precision, so
> {{assertFraction(long, long, BigFraction)}} is sufficient to handle both
> {{int}} and {{long}} arguments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (NUMBERS-122) Helper assertion methods in BigFractionTest not strict enough
Heinrich Bohne created NUMBERS-122:
--
Summary: Helper assertion methods in BigFractionTest not strict
enough
Key: NUMBERS-122
URL: https://issues.apache.org/jira/browse/NUMBERS-122
Project: Commons Numbers
Issue Type: Bug
Components: fraction
Affects Versions: 1.0
Reporter: Heinrich Bohne
The helper methods {{assertFraction(int, int, BigFraction)}} and
{{assertFraction(long, long, BigFraction)}} don't check whether the numerator
and denominator of the {{BigFraction}} are equivalent to the first two
arguments. Rather, they check whether the numerator and denominator _truncated
to an {{int}} or {{long}}_ are equal to the first two arguments. This is
unsatisfactory and also probably not in the spirit of the creator of these
methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-numbers] Schamschi closed pull request #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax
Schamschi closed pull request #58: NUMBERS-121: Replace usages of deprecated HTML tag with MathJax URL: https://github.com/apache/commons-numbers/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?focusedWorklogId=268433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268433
]
ASF GitHub Bot logged work on NUMBERS-121:
--
Author: ASF GitHub Bot
Created on: 27/Jun/19 10:50
Start Date: 27/Jun/19 10:50
Worklog Time Spent: 10m
Work Description: Schamschi commented on pull request #58: NUMBERS-121:
Replace usages of deprecated HTML tag with MathJax
URL: https://github.com/apache/commons-numbers/pull/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 268433)
Time Spent: 1h (was: 50m)
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873998#comment-16873998
]
Heinrich Bohne commented on NUMBERS-121:
{quote}You can run the jacoco plugin to get the report:
mvn test jacoco:report{quote}
Excellent, thanks.
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-imaging] kinow commented on issue #49: Add support for EXIF 2.32
kinow commented on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-506285856 @GITNE I think we are good with breaking changes before the final 1.0 release (see mailing archive: https://markmail.org/thread/dszscnnjpy5shu5f). Feel free to complete the PR with any other changes you may find useful. Just let us know once it's ready for review 👍 And thanks for your contribution! Bruno This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873965#comment-16873965
]
Alex D Herbert commented on NUMBERS-121:
You can run the jacoco plugin to get the report:
mvn test jacoco:report
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [commons-imaging] GITNE commented on issue #49: Add support for EXIF 2.32
GITNE commented on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-506266458 > On backward compatibility, thanks a lot for taking that into consideration. That's an important point. > […] > I'm writing to that thread about this PR, to confirm whether we are keeping BC or not. If not, it would be great if you would be willing to complete the work for fully compliance with the standard. After thinking about it a bit longer, I have realized that this PR already does break backwards compatibility in a specific situation. Namely, if an application relies on a deprecated `TagInfo` object to be in the `ExifTagConstants.ALL_EXIF_TAGS` list. For example, `ExifTagConstants.ALL_EXIF_TAGS.contains(ExifTagConstants.EXIF_TAG_EXIF_IMAGE_WIDTH)` will return `false` instead of `true` for them. So, if you would simply drop in a `commons-imaging.jar` with this patch applied on an existing application which expects the `ExifTagConstants.EXIF_TAG_EXIF_IMAGE_WIDTH` to be in `ExifTagConstants.ALL_EXIF_TAGS` then things will break. However, I believe this to be an exceptionally rare case, if ever implemented in this way. If anything `ExifTagConstants.ALL_EXIF_TAGS` has been probably used in iterators by applications, so these would still transparently iterate over the new and fixed `TagInfo` objects anyway. But they will misbehave if they check on a deprecated `TagInfo` object while iterating, yet they will not crash. We can work around `ExifTagConstants.ALL_EXIF_TAGS.contains()` to return `true` on deprecated `TagInfo` objects, however we cannot fix the iterators because we do not know which `TagInfo` objects the caller expects. Hence, there is practically no way around breaking backwards compatibility. Nevertheless, it would be a good thing anyway since IMHO it is better for dependencies/libraries to be correct than backward compatible. Consequently, in that situation fixing the data types of those primitive static members can be done too. Furthermore, `ExifTagConstants.ALL_EXIF_TAGS` should have probably been a `Set` in the first place because there is really no order among EXIF tags. If anything then the current `List` should be reordered by tag ids because there is no apparent order in the source code. So, either the lack of order should be reflected in the type or the ordered type should have elements in proper order. But this might be rather something for another PR or commit because both approaches will break backwards compatibility. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NUMBERS-121) Deprecated HTML tag in BigFraction
[
https://issues.apache.org/jira/browse/NUMBERS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873944#comment-16873944
]
Heinrich Bohne commented on NUMBERS-121:
So is PR #58 not in order? I would be in favor of getting rid of these obsolete
html tags, because having to manually fix this in my local copy just to check
coverage by running {{mvn clean site site:stage}} is getting tiresome. Or is
there a way to check coverage without running the javadoc plugin?
> Deprecated HTML tag in BigFraction
> --
>
> Key: NUMBERS-121
> URL: https://issues.apache.org/jira/browse/NUMBERS-121
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The deprecated HTML tag {{}} occurs multiple times in the Javadoc of the
> class {{BigFraction}}, which causes the execution of the Maven Javadoc Plugin
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
