[GitHub] [commons-imaging] gwlucastrig commented on issue #72: IMAGING-251 support for TIFF floating-point formats
gwlucastrig commented on issue #72: IMAGING-251 support for TIFF floating-point formats URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-613800839 The 14 April commit (e390778) concludes the preliminary work of enabling Commons Imaging to read images from TIFF files that are based on floating-point data. I am now shifting to implementing new functionality to extract floating-point raster data from the TIFF. I will be adding new blocks of code to the data-reader classes and the TiffImageParser, but do not plan on any further modifications to the existing code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (IMAGING-251) Support TIFF standard floating point data
[ https://issues.apache.org/jira/browse/IMAGING-251?focusedWorklogId=422507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422507 ] ASF GitHub Bot logged work on IMAGING-251: -- Author: ASF GitHub Bot Created on: 15/Apr/20 03:52 Start Date: 15/Apr/20 03:52 Worklog Time Spent: 10m Work Description: gwlucastrig commented on issue #72: IMAGING-251 support for TIFF floating-point formats URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-613800839 The 14 April commit (e390778) concludes the preliminary work of enabling Commons Imaging to read images from TIFF files that are based on floating-point data. I am now shifting to implementing new functionality to extract floating-point raster data from the TIFF. I will be adding new blocks of code to the data-reader classes and the TiffImageParser, but do not plan on any further modifications to the existing code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 422507) Time Spent: 4h 20m (was: 4h 10m) > Support TIFF standard floating point data > - > > Key: IMAGING-251 > URL: https://issues.apache.org/jira/browse/IMAGING-251 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.x >Reporter: Gary Lucas >Priority: Major > Fix For: 1.x > > Attachments: Imaging252_USGS_n38w077.jpg > > Time Spent: 4h 20m > Remaining Estimate: 0h > > Commons Imaging does not support the floating-point format included in the > TIFF specification. There are prominent data sources that issue products in > this format. The ability to support this information would open up new > application areas for Commons Imaging. > TIFF is often used as a mechanism for distributing data from geophysical > applications in the form of GeoTIFF files. Some of this is not imagery, but > data. For example, the US Geological Survey is currently releasing > high-resolution elevation data grids for the 3DEP program under the name > Cloud-Optimized GeoTIFF (COG). It is a substantial data set with significant > potential commercial and academic applications. > To access this data means modifying the TIFF DataReaderStrips and > DataReaderTile classes to recognize floating point data (which is typically > indicated using TIFF tag #339, SampleFormat). Also, returning the data in the > form of a BufferedImage makes no sense at all, so the API on the > TiffImageParser and supporting classes would need additional methods to > return arrays of floats. The good news here is that that requirement would > mean adding new methods to the classes rather than making significant changes > to existing classes. So the probability of unintended consequences or new > bugs in existing code would be minimized. > Specification details for floating-point are given in the main TIFF-6 > documentations and Adobe Photoshop TIFF Technical Note 3. > > I am willing to volunteer to make these changes provided that there is > interest and a high probability that my contributions would be evaluated and, > if suitable, integrated into the Commons Imaging code base. > Thank you for your attention in this matter. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] coveralls edited a comment on issue #72: IMAGING-251 support for TIFF floating-point formats
coveralls edited a comment on issue #72: IMAGING-251 support for TIFF floating-point formats URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-610094475 [](https://coveralls.io/builds/30082603) Coverage increased (+0.5%) to 75.604% when pulling **e390878403c4f71c0672e92fb3a2dfd3f31e1fc6 on gwlucastrig:master** into **1397ca92cd3268b434ad8a18529ee3544bbcf3c5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (IMAGING-251) Support TIFF standard floating point data
[ https://issues.apache.org/jira/browse/IMAGING-251?focusedWorklogId=422499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422499 ] ASF GitHub Bot logged work on IMAGING-251: -- Author: ASF GitHub Bot Created on: 15/Apr/20 03:13 Start Date: 15/Apr/20 03:13 Worklog Time Spent: 10m Work Description: coveralls commented on issue #72: IMAGING-251 support for TIFF floating-point formats URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-610094475 [](https://coveralls.io/builds/30082603) Coverage increased (+0.5%) to 75.604% when pulling **e390878403c4f71c0672e92fb3a2dfd3f31e1fc6 on gwlucastrig:master** into **1397ca92cd3268b434ad8a18529ee3544bbcf3c5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 422499) Time Spent: 4h 10m (was: 4h) > Support TIFF standard floating point data > - > > Key: IMAGING-251 > URL: https://issues.apache.org/jira/browse/IMAGING-251 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.x >Reporter: Gary Lucas >Priority: Major > Fix For: 1.x > > Attachments: Imaging252_USGS_n38w077.jpg > > Time Spent: 4h 10m > Remaining Estimate: 0h > > Commons Imaging does not support the floating-point format included in the > TIFF specification. There are prominent data sources that issue products in > this format. The ability to support this information would open up new > application areas for Commons Imaging. > TIFF is often used as a mechanism for distributing data from geophysical > applications in the form of GeoTIFF files. Some of this is not imagery, but > data. For example, the US Geological Survey is currently releasing > high-resolution elevation data grids for the 3DEP program under the name > Cloud-Optimized GeoTIFF (COG). It is a substantial data set with significant > potential commercial and academic applications. > To access this data means modifying the TIFF DataReaderStrips and > DataReaderTile classes to recognize floating point data (which is typically > indicated using TIFF tag #339, SampleFormat). Also, returning the data in the > form of a BufferedImage makes no sense at all, so the API on the > TiffImageParser and supporting classes would need additional methods to > return arrays of floats. The good news here is that that requirement would > mean adding new methods to the classes rather than making significant changes > to existing classes. So the probability of unintended consequences or new > bugs in existing code would be minimized. > Specification details for floating-point are given in the main TIFF-6 > documentations and Adobe Photoshop TIFF Technical Note 3. > > I am willing to volunteer to make these changes provided that there is > interest and a high probability that my contributions would be evaluated and, > if suitable, integrated into the Commons Imaging code base. > Thank you for your attention in this matter. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?focusedWorklogId=422318&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422318
]
ASF GitHub Bot logged work on BCEL-336:
---
Author: ASF GitHub Bot
Created on: 14/Apr/20 21:02
Start Date: 14/Apr/20 21:02
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #43: Test case for
BCEL-336
URL: https://github.com/apache/commons-bcel/pull/43
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 422318)
Time Spent: 20m (was: 10m)
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] suztomo closed pull request #43: Test case for BCEL-336
suztomo closed pull request #43: Test case for BCEL-336 URL: https://github.com/apache/commons-bcel/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083605#comment-17083605
]
Tomo Suzuki commented on BCEL-336:
--
The master passed my test case. Thank you for quick turnaround.
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083603#comment-17083603
]
Tomo Suzuki commented on BCEL-336:
--
{{org.apache.bcel.classfile.ClassFormatException}} looks more specific.
{code:java}
/**
* Thrown when the BCEL attempts to read a class file and determines
* that the file is malformed or otherwise cannot be interpreted as a
* class file.
*
*/
public class ClassFormatException extends RuntimeException {
...
{code}
IllegalStateException also sounds good for me.
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] garydgregory commented on issue #43: Test case for BCEL-336
garydgregory commented on issue #43: Test case for BCEL-336 URL: https://github.com/apache/commons-bcel/pull/43#issuecomment-613665107 @suztomo Please see git master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083562#comment-17083562
]
Gary D. Gregory edited comment on BCEL-336 at 4/14/20, 7:43 PM:
[~suztomo]
How about throwing an {{IllegalStateException}} instead? Please see git master.
[~markro] Any thoughts?
Gary
was (Author: garydgregory):
[~suztomo]
How about throwing an {{IllegalStateException}} instead?
Gary
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083562#comment-17083562
]
Gary D. Gregory commented on BCEL-336:
--
[~suztomo]
How about throwing an {{IllegalStateException}} instead?
Gary
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083561#comment-17083561
]
Gary D. Gregory commented on BCEL-336:
--
Mercifully, Eclipse does not blow up:
{noformat}
// Compiled from MailDateFormat.java (version 1.6 : 50.0, super bit)
public class javax.mail.internet.MailDateFormat extends
java.text.SimpleDateFormat {
// Field descriptor #4 J
private static final long serialVersionUID = -8148227605210628779L;
// Field descriptor #9 Z
static boolean debug;
// Field descriptor #11 Ljava/util/TimeZone;
private static java.util.TimeZone tz;
// Field descriptor #13 Ljava/util/Calendar;
private static java.util.Calendar cal;
// Method descriptor #15 ()V
public MailDateFormat();
// Method descriptor #17
(Ljava/util/Date;Ljava/lang/StringBuffer;Ljava/text/FieldPosition;)Ljava/lang/StringBuffer;
public java.lang.StringBuffer format(java.util.Date arg0,
java.lang.StringBuffer arg1, java.text.FieldPosition arg2);
// Method descriptor #19
(Ljava/lang/String;Ljava/text/ParsePosition;)Ljava/util/Date;
public java.util.Date parse(java.lang.String arg0, java.text.ParsePosition
arg1);
// Method descriptor #21 ([CLjava/text/ParsePosition;Z)Ljava/util/Date;
private static java.util.Date parseDate(char[] arg0, java.text.ParsePosition
arg1, boolean arg2);
// Method descriptor #23 (IIIZ)Ljava/util/Date;
private static synchronized java.util.Date ourUTC(int arg0, int arg1, int
arg2, int arg3, int arg4, int arg5, int arg6, boolean arg7);
// Method descriptor #25 (Ljava/util/Calendar;)V
public void setCalendar(java.util.Calendar arg0);
// Method descriptor #27 (Ljava/text/NumberFormat;)V
public void setNumberFormat(java.text.NumberFormat arg0);
// Method descriptor #15 ()V
static {};
}
{noformat}
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] garydgregory commented on issue #43: Test case for BCEL-336
garydgregory commented on issue #43: Test case for BCEL-336 URL: https://github.com/apache/commons-bcel/pull/43#issuecomment-613642429 https://issues.apache.org/jira/browse/BCEL-336# This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-bcel] garydgregory edited a comment on issue #43: Test case for BCEL-336
garydgregory edited a comment on issue #43: Test case for BCEL-336 URL: https://github.com/apache/commons-bcel/pull/43#issuecomment-613642429 https://issues.apache.org/jira/browse/BCEL-336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (LANG-1481) Add StringUtils.split() methods with String[] input.
[
https://issues.apache.org/jira/browse/LANG-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083529#comment-17083529
]
Amar Prakash Pandey commented on LANG-1481:
---
Hi [~ratish1992] in this case:
{code:java}
StringUtils.split(["a.b",null], '.') = ["a", "b"]{code}
> Add StringUtils.split() methods with String[] input.
>
>
> Key: LANG-1481
> URL: https://issues.apache.org/jira/browse/LANG-1481
> Project: Commons Lang
> Issue Type: New Feature
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
>
> We already have {{StringUtils.split(String,*)`}}, but I want to work with
> many inputs, so add {{StringUtils.split()}} methods with {{String[]}} inputs:
> {code:java}
> /**
> * Splits the provided text array into an array, separator specified.
> * This is an alternative to using StringTokenizer.
> *
> * The separator is not included in the returned String array.
> * Adjacent separators are treated as one separator.
> * For more control over the split use the StrTokenizer class.
> *
> * A {@code null} input String returns {@code null}.
> *
> *
> * StringUtils.split([null], *) = null
> * StringUtils.split([""], *)= []
> * StringUtils.split(["", ""], *) = []
> * StringUtils.split(["a.b.c"], '.') = ["a", "b", "c"]
> * StringUtils.split(["a.b"],["c"], '.') = ["a", "b", "c"]
> * StringUtils.split(["a"],["b"],["c"], '.') = ["a", "b", "c"]
> * StringUtils.split(["a..b.c"], '.')= ["a", "b", "c"]
> * StringUtils.split(["a:b:c"], '.') = ["a:b:c"]
> * StringUtils.split(["a b c"], ' ') = ["a", "b", "c"]
> *
> *
> * @param strArray the String[] to parse, may be null
> * @param separatorChar the character used as the delimiter
> * @return an array of parsed Strings, {@code null} if null String input
> * @since 3.10
> */
> {code}
> Looking for feedback...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (LANG-1481) Add StringUtils.split() methods with String[] input.
[
https://issues.apache.org/jira/browse/LANG-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083529#comment-17083529
]
Amar Prakash Pandey edited comment on LANG-1481 at 4/14/20, 6:48 PM:
-
Hi [~ratish1992] in this case the output will be:
{code:java}
StringUtils.split(["a.b",null], '.') = ["a", "b"]{code}
was (Author: amarlearning):
Hi [~ratish1992] in this case:
{code:java}
StringUtils.split(["a.b",null], '.') = ["a", "b"]{code}
> Add StringUtils.split() methods with String[] input.
>
>
> Key: LANG-1481
> URL: https://issues.apache.org/jira/browse/LANG-1481
> Project: Commons Lang
> Issue Type: New Feature
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
>
> We already have {{StringUtils.split(String,*)`}}, but I want to work with
> many inputs, so add {{StringUtils.split()}} methods with {{String[]}} inputs:
> {code:java}
> /**
> * Splits the provided text array into an array, separator specified.
> * This is an alternative to using StringTokenizer.
> *
> * The separator is not included in the returned String array.
> * Adjacent separators are treated as one separator.
> * For more control over the split use the StrTokenizer class.
> *
> * A {@code null} input String returns {@code null}.
> *
> *
> * StringUtils.split([null], *) = null
> * StringUtils.split([""], *)= []
> * StringUtils.split(["", ""], *) = []
> * StringUtils.split(["a.b.c"], '.') = ["a", "b", "c"]
> * StringUtils.split(["a.b"],["c"], '.') = ["a", "b", "c"]
> * StringUtils.split(["a"],["b"],["c"], '.') = ["a", "b", "c"]
> * StringUtils.split(["a..b.c"], '.')= ["a", "b", "c"]
> * StringUtils.split(["a:b:c"], '.') = ["a:b:c"]
> * StringUtils.split(["a b c"], ' ') = ["a", "b", "c"]
> *
> *
> * @param strArray the String[] to parse, may be null
> * @param separatorChar the character used as the delimiter
> * @return an array of parsed Strings, {@code null} if null String input
> * @since 3.10
> */
> {code}
> Looking for feedback...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083483#comment-17083483
]
Tomo Suzuki commented on BCEL-336:
--
Created https://github.com/apache/commons-bcel/pull/43
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?focusedWorklogId=422206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422206
]
ASF GitHub Bot logged work on BCEL-336:
---
Author: ASF GitHub Bot
Created on: 14/Apr/20 18:09
Start Date: 14/Apr/20 18:09
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #43: Test case for
BCEL-336
URL: https://github.com/apache/commons-bcel/pull/43
I created a test case for BCEL-336 as per [Gary's
comment](https://issues.apache.org/jira/browse/BCEL-336?focusedCommentId=17083466&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17083466).
This PR does not have a fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 422206)
Remaining Estimate: 0h
Time Spent: 10m
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] suztomo opened a new pull request #43: Test case for BCEL-336
suztomo opened a new pull request #43: Test case for BCEL-336 URL: https://github.com/apache/commons-bcel/pull/43 I created a test case for BCEL-336 as per [Gary's comment](https://issues.apache.org/jira/browse/BCEL-336?focusedCommentId=17083466&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17083466). This PR does not have a fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083474#comment-17083474
]
Tomo Suzuki commented on BCEL-336:
--
Yes, I'll create a PR.
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083466#comment-17083466
]
Gary D. Gregory edited comment on BCEL-336 at 4/14/20, 5:51 PM:
What version of Apache Commons BCEL are you using?
May you please please provide a test case we can run. You can include the
following in the POM to bring in the jar:
{noformat}
diff --git a/pom.xml b/pom.xml
index 5941c970..8f53e109 100644
--- a/pom.xml
+++ b/pom.xml
@@ -498,6 +498,13 @@
3.10
test
+^M
+ ^M
+ javax^M
+ javaee-api^M
+ 6.0^M
+ test^M
+^M
{noformat}
A PR on GitHub would be best.
was (Author: garydgregory):
What version of Apache Commons BCEL are you using?
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083470#comment-17083470
]
Tomo Suzuki commented on BCEL-336:
--
I use 6.4.1:
{noformat}
org.apache.bcel
bcel
6.4.1
{noformat}
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
[
https://issues.apache.org/jira/browse/BCEL-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083466#comment-17083466
]
Gary D. Gregory commented on BCEL-336:
--
What version of Apache Commons BCEL are you using?
> MethodGen throws NullPointerException upon Invalid Class File Missing
> Constructor Body
> --
>
> Key: BCEL-336
> URL: https://issues.apache.org/jira/browse/BCEL-336
> Project: Commons BCEL
> Issue Type: Task
>Reporter: Tomo Suzuki
>Priority: Major
> Attachments: Screen Shot 2020-04-14 at 10.43.31.png
>
>
> MethodGen throws NullPointerException upon invalid class file missing
> constructor body. Should it throw more appropriate exception?
> {{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not
> have valid constructor body. When I tried to create MethodGen instance for
> the class, BCEL's MethodGen constructor throws NullPointerException:
> {code:java}
> JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
> ClassGen classGen = new ClassGen(sourceJavaClass);
> for (Method method : sourceJavaClass.getMethods()) {
> MethodGen methodGen = new MethodGen(method, sourceClassName,
> classGen.getConstantPool());
> ...
> {code}
> NullPointerException is thrown
> [https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
> The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
> {{m.getCode()}} returning null.
> Given the class file is malformed (screenshot below), it's understandable for
> BCEL to throw an exception. Is there more appropriate exception (rather than
> NullPointerException)?
> !Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (BCEL-336) MethodGen throws NullPointerException upon Invalid Class File Missing Constructor Body
Tomo Suzuki created BCEL-336:
Summary: MethodGen throws NullPointerException upon Invalid Class
File Missing Constructor Body
Key: BCEL-336
URL: https://issues.apache.org/jira/browse/BCEL-336
Project: Commons BCEL
Issue Type: Task
Reporter: Tomo Suzuki
Attachments: Screen Shot 2020-04-14 at 10.43.31.png
MethodGen throws NullPointerException upon invalid class file missing
constructor body. Should it throw more appropriate exception?
{{javax:javaee-api:6.0}}'s {{javax.mail.internet.MailDateFormat}} does not have
valid constructor body. When I tried to create MethodGen instance for the
class, BCEL's MethodGen constructor throws NullPointerException:
{code:java}
JavaClass sourceJavaClass = loadJavaClass(sourceClassName);
ClassGen classGen = new ClassGen(sourceJavaClass);
for (Method method : sourceJavaClass.getMethods()) {
MethodGen methodGen = new MethodGen(method, sourceClassName,
classGen.getConstantPool());
...
{code}
NullPointerException is thrown
[https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1352#issuecomment-613467921]
The exception comes from {{new InstructionList(m.getCode().getCode()}}, where
{{m.getCode()}} returning null.
Given the class file is malformed (screenshot below), it's understandable for
BCEL to throw an exception. Is there more appropriate exception (rather than
NullPointerException)?
!Screen Shot 2020-04-14 at 10.43.31.png|width=857,height=504!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (IMAGING-256) ArrayIndexOutOfBounds exception in JpegXmpRewriter.updateXmpXml()
David Ekholm created IMAGING-256: Summary: ArrayIndexOutOfBounds exception in JpegXmpRewriter.updateXmpXml() Key: IMAGING-256 URL: https://issues.apache.org/jira/browse/IMAGING-256 Project: Commons Imaging Issue Type: Bug Components: imaging.common.* Affects Versions: 1.0-alpha1 Reporter: David Ekholm Fix For: 0.94-incubator Attachments: Overhead_16_reduced.jpg Got the attached image passed to me. It triggers the following exception: java.lang.IndexOutOfBoundsException: Range [65535, 65535 + 65535) out of bounds for length 77353 at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromIndexSize(Preconditions.java:82) at java.base/jdk.internal.util.Preconditions.checkFromIndexSize(Preconditions.java:343) at java.base/java.util.Objects.checkFromIndexSize(Objects.java:425) at java.base/java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:129) at org.apache.commons.imaging.formats.jpeg.xmp.JpegXmpRewriter.writeXmpSegment(JpegXmpRewriter.java:200) at org.apache.commons.imaging.formats.jpeg.xmp.JpegXmpRewriter.updateXmpXml(JpegXmpRewriter.java:184) at org.apache.commons.imaging.formats.jpeg.xmp.JpegXmpRewriter.updateXmpXml(JpegXmpRewriter.java:124) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] hangpark closed pull request #63: (doc) Fix throw desc for sampling funcs
hangpark closed pull request #63: (doc) Fix throw desc for sampling funcs URL: https://github.com/apache/commons-math/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (VALIDATOR-458) commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the latest one
[ https://issues.apache.org/jira/browse/VALIDATOR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083182#comment-17083182 ] Lonzak commented on VALIDATOR-458: -- I got the feeling this project is dead. Does anyone have any information when this and other bugs might be fixed? > commons-beanutils version 1.9.2 is having vulnerabilities upgrade it to the > latest one > -- > > Key: VALIDATOR-458 > URL: https://issues.apache.org/jira/browse/VALIDATOR-458 > Project: Commons Validator > Issue Type: Bug >Reporter: Shubhankar Singh >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VALIDATOR-368) Allow angle brackets in email-address validation
[ https://issues.apache.org/jira/browse/VALIDATOR-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083160#comment-17083160 ] Lonzak commented on VALIDATOR-368: -- We just experienced this issue, searched and found this bug. Why hasn't this been addressed? Is it possible to release a 1.6.1? Thanks > Allow angle brackets in email-address validation > > > Key: VALIDATOR-368 > URL: https://issues.apache.org/jira/browse/VALIDATOR-368 > Project: Commons Validator > Issue Type: Improvement > Components: Routines >Affects Versions: 1.4.1 Release >Reporter: Tobias Fink >Priority: Minor > > Email-addresses like "Leo Notenboom " are > validated as invalid by org.apache.commons.validator.routines.EmailValidator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCS-183) JCache CDI integration is slow
[ https://issues.apache.org/jira/browse/JCS-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Vandahl updated JCS-183: --- Fix Version/s: (was: jcs-2.3) > JCache CDI integration is slow > -- > > Key: JCS-183 > URL: https://issues.apache.org/jira/browse/JCS-183 > Project: Commons JCS > Issue Type: Bug >Reporter: Romain Manni-Bucau >Assignee: Romain Manni-Bucau >Priority: Major > Fix For: jcs-2.2.1 > > > JCache CDI integration uses too much reflection to be performant at runtime, > this task is about reducing it as much as possible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (COMPRESS-509) The ambiguous behavior of the TarArchiveEntry.getName() method
[ https://issues.apache.org/jira/browse/COMPRESS-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082974#comment-17082974 ] Peter Lee commented on COMPRESS-509: Looks like we have added a '/' for a directory if its name is not ended with '/' - and this will only work for POSIX. And this will not happen if it's a OLD GNU or XSTAR tar. Basing on the comment in code, the adding of '/' for directory in POSIX looks like a fix for _SunOS tar -E._ Note that currently we are not adding '/' for a GNU long name entry - no matter it's POSIX, OLDGNU or XSTAR. Seems we have 2 options : # Just adding a '/' for a GNU long name entry if it's a directory(when the name is not ended with '/'). This seems to cause another similiar problem like this issue : for OLD GNU or XSTAR entries, the name of directories will not automatically add a '/' - on the other hand the '/' will be automatically if the entry is a GNU long name entry. # Adding a '/' for a GNU long name entry and the OLD GNU (maybe including XSTART?) entry. This will make OLD GNU entry and GNU long name entry work consistently. I prefer the second one. WDYT?[~bodewig] > The ambiguous behavior of the TarArchiveEntry.getName() method > -- > > Key: COMPRESS-509 > URL: https://issues.apache.org/jira/browse/COMPRESS-509 > Project: Commons Compress > Issue Type: Bug > Components: Archivers >Affects Versions: 1.18, 1.20 >Reporter: Petr Vasak >Assignee: Peter Lee >Priority: Minor > Attachments: Main.java > > > Scenario: To tar an empty directory and then to untar it. When the name is > longer than 100 characters, no ending slash appears. > Example: see attachment > Part of the output: > .. > dir/aa/ > dir/aaa/ > dir/ > dir/a > .. -- This message was sent by Atlassian Jira (v8.3.4#803005)
