[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=441129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441129 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 04/Jun/20 06:32 Start Date: 04/Jun/20 06:32 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638632471 too late, I've already merged this one :-) It is very much possible javac has become better in the fifteen years or so since the code has been written. A while ago I started https://github.com/bodewig/commons-compress-benchmarks as a limited JMH based setup to see how things changed over time. It might be a starting point - or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441129) Time Spent: 1h (was: 50m) > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig commented on pull request #106: [COMPRESS-535] maybe we can add a break here
bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638632471 too late, I've already merged this one :-) It is very much possible javac has become better in the fifteen years or so since the code has been written. A while ago I started https://github.com/bodewig/commons-compress-benchmarks as a limited JMH based setup to see how things changed over time. It might be a starting point - or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125371#comment-17125371 ] Uwe Schindler edited comment on IO-671 at 6/3/20, 10:53 PM: [Fobiddenapis 3.0.1|https://github.com/policeman-tools/forbidden-apis/wiki/Changes#version-301-released-2020-06-03] was released to workaround the move of method to superclass. was (Author: thetaphi): [Fobiddenapis 3.0.1|https://github.com/policeman-tools/forbidden-apis/wiki/Changes#version-301-released-2020-06-03] was released o workaround the move of method to superclass. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125371#comment-17125371 ] Uwe Schindler commented on IO-671: -- [Fobiddenapis 3.0.1|https://github.com/policeman-tools/forbidden-apis/wiki/Changes#version-301-released-2020-06-03] was released o workaround the move of method to superclass. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1551) EqualsBuilder with Lambdas
Bruce Brouwer created LANG-1551:
---
Summary: EqualsBuilder with Lambdas
Key: LANG-1551
URL: https://issues.apache.org/jira/browse/LANG-1551
Project: Commons Lang
Issue Type: Improvement
Components: lang.builder.*
Affects Versions: 3.9
Reporter: Bruce Brouwer
Has it been considered to use lambdas to make it easier to write equals
methods?
{code:java}
public boolean equals(final Object obj) {
return new EqualsBuilder(this, obj)
.append(it -> it.field)
.appendSuper(super.equals(obj)
.isEquals();
}{code}
I know this is incompatible with the current {{EqualsBuilder}} so maybe a new
class, or something like this would work instead:
{code:java}
public boolean equals(final Object obj) {
return EqualsBuilder.with(this, obj) // with returns a generic type similar to
EqualsBuilder
.append(it -> it.field)
.appendSuper(super.equals(obj)
.isEquals();
}{code}
It helps eliminate all the boilerplate code of checking object types and could
even skip calling the lambdas if it already knew it was not equal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (LANG-1544) MethodUtils.invokeMethod NullPointerException in case of null in args list
[
https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125265#comment-17125265
]
Peter Nagy commented on LANG-1544:
--
Hi Robert,
Sorry, I am new here. I am afraid I have no rights to assign you this issue. I
do not know either how to submit a fix, otherwise I would have been done it. I
can only hope that somebody who is in charge will pick up this issue and extend
the code with this tiny yet important modification.
Best regards, Peter
> MethodUtils.invokeMethod NullPointerException in case of null in args list
> --
>
> Key: LANG-1544
> URL: https://issues.apache.org/jira/browse/LANG-1544
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.10
>Reporter: Peter Nagy
>Priority: Critical
>
> MethodUtils:774
>
> if (classArray[offset].equals(toClassArray[offset])) {
> continue;
> } else if (ClassUtils.isAssignable(classArray[offset], toClassArray[offset],
> true)
>
> cause NPE if classArray[offset] is null. Can you please extend the if
> condition with a null check, like this?
>
> if (classArray[offset] != null &&
> classArray[offset].equals(toClassArray[offset]))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (JCS-205) commons-jcs3-core-3.0-20200526.132410-4-sources.jar lacks META-INF/services/org.apache.commons.jcs3.log.LogFactory
Simon Legner created JCS-205:
Summary: commons-jcs3-core-3.0-20200526.132410-4-sources.jar lacks
META-INF/services/org.apache.commons.jcs3.log.LogFactory
Key: JCS-205
URL: https://issues.apache.org/jira/browse/JCS-205
Project: Commons JCS
Issue Type: Bug
Affects Versions: jcs-3.0
Reporter: Simon Legner
The source JAR
https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-jcs3-core/3.0-SNAPSHOT/commons-jcs3-core-3.0-20200526.132410-4-sources.jar
lacks the services file
{{META-INF/services/org.apache.commons.jcs3.log.LogFactory}}. Instead, the file
{{/home/jenkins/jenkins-slave/workspace/commons-jcs/commons-jcs-core/target/classes/META-INF/services/org.apache.commons.jcs3.log.LogFactory}}
is present.
JOSM bug: https://josm.openstreetmap.de/ticket/19335
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCS-204) Release JCS 3.0
[
https://issues.apache.org/jira/browse/JCS-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125261#comment-17125261
]
Simon Legner commented on JCS-204:
--
We've managed to complete the migration to {{package org.apache.commons.jcs3}}
tracked in https://josm.openstreetmap.de/ticket/19208. Updating JOSM core was
easy. Reaching out to 7 plugin maintainers and getting the affected plugins
updated, took more effort.
> Release JCS 3.0
> ---
>
> Key: JCS-204
> URL: https://issues.apache.org/jira/browse/JCS-204
> Project: Commons JCS
> Issue Type: Task
>Reporter: Simon Legner
>Assignee: Thomas Vandahl
>Priority: Major
> Labels: release
>
> Many improvements have been made since the last 2.2.1 release in 2017:
> https://github.com/apache/commons-jcs/compare/commons-jcs-2.2.1...master
> [JOSM|https://josm.openstreetmap.de/] always has been using the latest SVN
> version of JCS without any known problems. We would like to switch to Apache
> Ivy for dependency management and thus require a published release.
> Can you craft a new 2.3 release of JCS? Are there any blockers?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (LANG-1544) MethodUtils.invokeMethod NullPointerException in case of null in args list
[
https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125222#comment-17125222
]
Robert Konior commented on LANG-1544:
-
Nice, but can you assign this task? :)
> MethodUtils.invokeMethod NullPointerException in case of null in args list
> --
>
> Key: LANG-1544
> URL: https://issues.apache.org/jira/browse/LANG-1544
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.10
>Reporter: Peter Nagy
>Priority: Critical
>
> MethodUtils:774
>
> if (classArray[offset].equals(toClassArray[offset])) {
> continue;
> } else if (ClassUtils.isAssignable(classArray[offset], toClassArray[offset],
> true)
>
> cause NPE if classArray[offset] is null. Can you please extend the if
> condition with a null check, like this?
>
> if (classArray[offset] != null &&
> classArray[offset].equals(toClassArray[offset]))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125163#comment-17125163 ] Uwe Schindler commented on IO-671: -- I can confirm, no new methods using default charsets were added, so the forbidden signatures list in forbiddenapis will stay same (only the new abstract class was added). Good job! > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125159#comment-17125159 ] Uwe Schindler commented on IO-671: -- BTW, thanks for the API difference html page, helps to find more candicates for forbiddenapis. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125158#comment-17125158 ] Uwe Schindler commented on IO-671: -- As said before, looks like a false positive. Should we close the issue. My only complaint (now it's too late) that I found out by this, that actually commons-io 2.7 introduces a new class with a method deprecated from the beginning. But that was done already and there's no way back, so all fine to close this. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SANDBOX-509) Convert commons-graph Multi Module Maven Project
[ https://issues.apache.org/jira/browse/SANDBOX-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amey Jadiye updated SANDBOX-509: Issue Type: Improvement (was: Bug) > Convert commons-graph Multi Module Maven Project > > > Key: SANDBOX-509 > URL: https://issues.apache.org/jira/browse/SANDBOX-509 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph >Reporter: Amey Jadiye >Priority: Major > > In order to make a further push towards making commons-graph graduate to > proper it's important to make graph multi-module maven project. > based on the common functionality of classes we have to categorize them and > make modules. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SANDBOX-509) Convert commons-graph Multi Module Maven Project
Amey Jadiye created SANDBOX-509: --- Summary: Convert commons-graph Multi Module Maven Project Key: SANDBOX-509 URL: https://issues.apache.org/jira/browse/SANDBOX-509 Project: Commons Sandbox Issue Type: Bug Components: Graph Reporter: Amey Jadiye In order to make a further push towards making commons-graph graduate to proper it's important to make graph multi-module maven project. based on the common functionality of classes we have to categorize them and make modules. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125137#comment-17125137 ] Gary D. Gregory commented on IO-671: Binary compatibility is fine, see [https://commons.apache.org/proper/commons-io/japicmp.html] > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[
https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125031#comment-17125031
]
Uwe Schindler commented on IO-671:
--
Nevertheless, I think that adding the deprecated method to the new superclass
was not the best idea. It should have been left in the old subclass and just
implemented there calling {{super.toString(Charset.getDefault())}}.
> Version 2.7 is binary incompatible
> --
>
> Key: IO-671
> URL: https://issues.apache.org/jira/browse/IO-671
> Project: Commons IO
> Issue Type: Bug
>Affects Versions: 2.7
>Reporter: Quentin Caillard
>Priority: Major
>
> The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has
> been removed.
>
> See https://github.com/policeman-tools/forbidden-apis/issues/168
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125024#comment-17125024 ] Uwe Schindler commented on IO-671: -- Hi, I figured out: This is not a real binary incompatibility. The method disappeared from the ByteArrayOutputStream class, but it was added to AbstractByteArrayOutputStream. It looks like the signatures parser in forbiddenapis does not like that. I have to investigate. So I think this can be closed. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125005#comment-17125005 ] Quentin Caillard commented on IO-671: - Yes. But in the email : Compatibility with 2.6: Binary compatible: Yes. Source compatible: Yes. Semantic compatible: Yes. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125005#comment-17125005 ] Quentin Caillard edited comment on IO-671 at 6/3/20, 2:33 PM: -- Yes. But in the announcement by email : Compatibility with 2.6: Binary compatible: Yes. Source compatible: Yes. Semantic compatible: Yes. was (Author: dichotomia): Yes. But in the email : Compatibility with 2.6: Binary compatible: Yes. Source compatible: Yes. Semantic compatible: Yes. > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-671) Version 2.7 is binary incompatible
[ https://issues.apache.org/jira/browse/IO-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125000#comment-17125000 ] Uwe Schindler commented on IO-671: -- As far as I see, this method was already deprecated in 2.5, but was removed wthout any mention in the release notes. The method is really unneeded, as it's character-set unsafe (this is why forbiddenapis complains about it). > Version 2.7 is binary incompatible > -- > > Key: IO-671 > URL: https://issues.apache.org/jira/browse/IO-671 > Project: Commons IO > Issue Type: Bug >Affects Versions: 2.7 >Reporter: Quentin Caillard >Priority: Major > > The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has > been removed. > > See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IO-671) Version 2.7 is binary incompatible
Quentin Caillard created IO-671: --- Summary: Version 2.7 is binary incompatible Key: IO-671 URL: https://issues.apache.org/jira/browse/IO-671 Project: Commons IO Issue Type: Bug Affects Versions: 2.7 Reporter: Quentin Caillard The method org.apache.commons.io.output.ByteArrayOutputStream#toString() has been removed. See https://github.com/policeman-tools/forbidden-apis/issues/168 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=440764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440764 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 03/Jun/20 13:02 Start Date: 03/Jun/20 13:02 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638181991 >In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be. OK, I will find some time to do the test. I will also try build a data structure for this question, and test performance for it too. And, maybe we should not merge this pr until the test result comes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440764) Time Spent: 50m (was: 40m) > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] XenoAmess commented on pull request #106: [COMPRESS-535] maybe we can add a break here
XenoAmess commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638181991 >In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be. OK, I will find some time to do the test. I will also try build a data structure for this question, and test performance for it too. And, maybe we should not merge this pr until the test result comes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-536) maybe we can make it static
[ https://issues.apache.org/jira/browse/COMPRESS-536?focusedWorklogId=440745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440745 ] ASF GitHub Bot logged work on COMPRESS-536: --- Author: ASF GitHub Bot Created on: 03/Jun/20 12:23 Start Date: 03/Jun/20 12:23 Worklog Time Spent: 10m Work Description: bodewig merged pull request #107: URL: https://github.com/apache/commons-compress/pull/107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440745) Time Spent: 0.5h (was: 20m) > maybe we can make it static > --- > > Key: COMPRESS-536 > URL: https://issues.apache.org/jira/browse/COMPRESS-536 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/107] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (COMPRESS-536) maybe we can make it static
[ https://issues.apache.org/jira/browse/COMPRESS-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-536. - Fix Version/s: 1.21 Resolution: Fixed > maybe we can make it static > --- > > Key: COMPRESS-536 > URL: https://issues.apache.org/jira/browse/COMPRESS-536 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/107] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-536) maybe we can make it static
[ https://issues.apache.org/jira/browse/COMPRESS-536?focusedWorklogId=440744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440744 ] ASF GitHub Bot logged work on COMPRESS-536: --- Author: ASF GitHub Bot Created on: 03/Jun/20 12:23 Start Date: 03/Jun/20 12:23 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #107: URL: https://github.com/apache/commons-compress/pull/107#issuecomment-638161932 thanks @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440744) Time Spent: 20m (was: 10m) > maybe we can make it static > --- > > Key: COMPRESS-536 > URL: https://issues.apache.org/jira/browse/COMPRESS-536 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/107] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig merged pull request #107: [COMPRESS-536] maybe we can make it static
bodewig merged pull request #107: URL: https://github.com/apache/commons-compress/pull/107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] bodewig commented on pull request #107: [COMPRESS-536] maybe we can make it static
bodewig commented on pull request #107: URL: https://github.com/apache/commons-compress/pull/107#issuecomment-638161932 thanks @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=440741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440741 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 03/Jun/20 12:20 Start Date: 03/Jun/20 12:20 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638160654 oh, and thank you, of course This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440741) Time Spent: 0.5h (was: 20m) > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-535. - Fix Version/s: 1.21 Resolution: Fixed > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=440742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440742 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 03/Jun/20 12:20 Start Date: 03/Jun/20 12:20 Worklog Time Spent: 10m Work Description: bodewig merged pull request #106: URL: https://github.com/apache/commons-compress/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440742) Time Spent: 40m (was: 0.5h) > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig commented on pull request #106: [COMPRESS-535] maybe we can add a break here
bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638160654 oh, and thank you, of course This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] bodewig merged pull request #106: [COMPRESS-535] maybe we can add a break here
bodewig merged pull request #106: URL: https://github.com/apache/commons-compress/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=440735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440735 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 03/Jun/20 12:16 Start Date: 03/Jun/20 12:16 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638158417 @XenoAmess you don't need to create a JIRA ticket for every PR. I appreciate JIRA for bigger changes, but for a single break, I'm not sure. Oh, and please add a bit more context to the PR's titles :-) The bzip2 code has been hand optimized with an unrolled loop years ago. It is quite possible this is no longer necessary and the JIT has become smart enough to do things "right". In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be. For many of our users speed is more important than elegance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440735) Time Spent: 20m (was: 10m) > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig commented on pull request #106: [COMPRESS-535] maybe we can add a break here
bodewig commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638158417 @XenoAmess you don't need to create a JIRA ticket for every PR. I appreciate JIRA for bigger changes, but for a single break, I'm not sure. Oh, and please add a bit more context to the PR's titles :-) The bzip2 code has been hand optimized with an unrolled loop years ago. It is quite possible this is no longer necessary and the JIT has become smart enough to do things "right". In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be. For many of our users speed is more important than elegance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #107: [COMPRESS-536] maybe we can make it static
coveralls commented on pull request #107: URL: https://github.com/apache/commons-compress/pull/107#issuecomment-638145188 [](https://coveralls.io/builds/31209867) Coverage remained the same at 87.289% when pulling **a1e0be725078e679776e6d56e20f810c9a7c8a4e on XenoAmess:should_we_make_it_static** into **f333bc647c860375cc4eda10b2c3c8d4d57f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-536) maybe we can make it static
[ https://issues.apache.org/jira/browse/COMPRESS-536?focusedWorklogId=440721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440721 ] ASF GitHub Bot logged work on COMPRESS-536: --- Author: ASF GitHub Bot Created on: 03/Jun/20 11:47 Start Date: 03/Jun/20 11:47 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #107: URL: https://github.com/apache/commons-compress/pull/107#issuecomment-638145188 [](https://coveralls.io/builds/31209867) Coverage remained the same at 87.289% when pulling **a1e0be725078e679776e6d56e20f810c9a7c8a4e on XenoAmess:should_we_make_it_static** into **f333bc647c860375cc4eda10b2c3c8d4d57f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440721) Remaining Estimate: 0h Time Spent: 10m > maybe we can make it static > --- > > Key: COMPRESS-536 > URL: https://issues.apache.org/jira/browse/COMPRESS-536 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/107] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (COMPRESS-536) maybe we can make it static
JIN XU created COMPRESS-536: --- Summary: maybe we can make it static Key: COMPRESS-536 URL: https://issues.apache.org/jira/browse/COMPRESS-536 Project: Commons Compress Issue Type: Improvement Reporter: JIN XU [https://github.com/apache/commons-compress/pull/107] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] XenoAmess opened a new pull request #107: maybe we can make it static
XenoAmess opened a new pull request #107: URL: https://github.com/apache/commons-compress/pull/107 Hi. I think maybe we can make it static. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #106: [COMPRESS-535] maybe we can add a break here
coveralls commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638139331 [](https://coveralls.io/builds/31209625) Coverage increased (+0.04%) to 87.325% when pulling **204faf58f69386d1b6f8d0410dcf2667d6d08051 on XenoAmess:should_we_add_break_here** into **f333bc647c860375cc4eda10b2c3c8d4d57f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-535) maybe we can add a break here
[ https://issues.apache.org/jira/browse/COMPRESS-535?focusedWorklogId=440715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440715 ] ASF GitHub Bot logged work on COMPRESS-535: --- Author: ASF GitHub Bot Created on: 03/Jun/20 11:34 Start Date: 03/Jun/20 11:34 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #106: URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638139331 [](https://coveralls.io/builds/31209625) Coverage increased (+0.04%) to 87.325% when pulling **204faf58f69386d1b6f8d0410dcf2667d6d08051 on XenoAmess:should_we_add_break_here** into **f333bc647c860375cc4eda10b2c3c8d4d57f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440715) Remaining Estimate: 0h Time Spent: 10m > maybe we can add a break here > -- > > Key: COMPRESS-535 > URL: https://issues.apache.org/jira/browse/COMPRESS-535 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (LANG-1544) MethodUtils.invokeMethod NullPointerException in case of null in args list
[
https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124880#comment-17124880
]
Peter Nagy commented on LANG-1544:
--
Dear Robert,
if you ask me, you are welcome! :-)
Best regards, Peter
> MethodUtils.invokeMethod NullPointerException in case of null in args list
> --
>
> Key: LANG-1544
> URL: https://issues.apache.org/jira/browse/LANG-1544
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
>Affects Versions: 3.10
>Reporter: Peter Nagy
>Priority: Critical
>
> MethodUtils:774
>
> if (classArray[offset].equals(toClassArray[offset])) {
> continue;
> } else if (ClassUtils.isAssignable(classArray[offset], toClassArray[offset],
> true)
>
> cause NPE if classArray[offset] is null. Can you please extend the if
> condition with a null check, like this?
>
> if (classArray[offset] != null &&
> classArray[offset].equals(toClassArray[offset]))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (COMPRESS-535) maybe we can add a break here
JIN XU created COMPRESS-535: --- Summary: maybe we can add a break here Key: COMPRESS-535 URL: https://issues.apache.org/jira/browse/COMPRESS-535 Project: Commons Compress Issue Type: Improvement Reporter: JIN XU [https://github.com/apache/commons-compress/pull/106] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] XenoAmess opened a new pull request #106: maybe we can add a break here
XenoAmess opened a new pull request #106: URL: https://github.com/apache/commons-compress/pull/106 Hi. Can we add a break here? Also, should we try implement a data structure or something for doing this? a loop like this sounds slow. If you don't mind I will give it a try several hours later (if I still have some time). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1537) refine javadoc and fix typos.
[
https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124859#comment-17124859
]
Gilles Sadowski commented on MATH-1537:
---
{quote}wrapping another layer [...] ?
{quote}
In
[DfpTest.java|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=src/test/java/org/apache/commons/math4/dfp/DfpTest.java;h=63f59ac2cbc3567bc777e34a5210fccf05710e50;hb=HEAD]
for example, there are 12 occurrences of
{code:java}
Assert.fail("assertion failed. compare flags = "+field.getIEEEFlags());
{code}
that could be replaced by a call to a method
{code:java}
private static void fail(DfpField field) {
Assert.fail("assertion failed. compare flags = " + field.getIEEEFlags());
}
{code}
> refine javadoc and fix typos.
> -
>
> Key: MATH-1537
> URL: https://issues.apache.org/jira/browse/MATH-1537
> Project: Commons Math
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-math/pull/136]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MATH-1537) refine javadoc and fix typos.
[
https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124836#comment-17124836
]
JIN XU commented on MATH-1537:
--
[~erans]
1. for
{code:java}
\infty
{code}
:
Sorry for that mistake.
2. for "change repetitive lines to use a method call instead"
You mean wrapping another layer outside of assertTrue?
> refine javadoc and fix typos.
> -
>
> Key: MATH-1537
> URL: https://issues.apache.org/jira/browse/MATH-1537
> Project: Commons Math
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-math/pull/136]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MATH-1537) refine javadoc and fix typos.
[
https://issues.apache.org/jira/browse/MATH-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124827#comment-17124827
]
Gilles Sadowski commented on MATH-1537:
---
All PRs merged in commit 715d89d2625b09915feb1dd1b60270842eeffb7a ("master"
branch).
I didn't get why you changed
{noformat}
\infty
{noformat}
to
{noformat}
\infinity
{noformat}
in the MathJaX (LaTeX) comments; so changed it back.
Another cleanup suggestion is to change repetitive lines (see e.g.
concatenation of strings, where you corrected "assersion" -> "assertion") to
use a method call instead.
> refine javadoc and fix typos.
> -
>
> Key: MATH-1537
> URL: https://issues.apache.org/jira/browse/MATH-1537
> Project: Commons Math
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-math/pull/136]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440701 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot Created on: 03/Jun/20 10:11 Start Date: 03/Jun/20 10:11 Worklog Time Spent: 10m Work Description: asfgit closed pull request #137: URL: https://github.com/apache/commons-math/pull/137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440701) Time Spent: 1h 40m (was: 1.5h) > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440700 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot Created on: 03/Jun/20 10:11 Start Date: 03/Jun/20 10:11 Worklog Time Spent: 10m Work Description: asfgit closed pull request #138: URL: https://github.com/apache/commons-math/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440700) Time Spent: 1.5h (was: 1h 20m) > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (MATH-1537) refine javadoc and fix typos.
[ https://issues.apache.org/jira/browse/MATH-1537?focusedWorklogId=440702&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440702 ] ASF GitHub Bot logged work on MATH-1537: Author: ASF GitHub Bot Created on: 03/Jun/20 10:11 Start Date: 03/Jun/20 10:11 Worklog Time Spent: 10m Work Description: asfgit closed pull request #139: URL: https://github.com/apache/commons-math/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440702) Time Spent: 1h 50m (was: 1h 40m) > refine javadoc and fix typos. > - > > Key: MATH-1537 > URL: https://issues.apache.org/jira/browse/MATH-1537 > Project: Commons Math > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-math/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] asfgit closed pull request #137: [MATH-1537] refine javadoc
asfgit closed pull request #137: URL: https://github.com/apache/commons-math/pull/137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] asfgit closed pull request #139: [MATH-1537] fix_typos
asfgit closed pull request #139: URL: https://github.com/apache/commons-math/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] asfgit closed pull request #138: [MATH-1537] delete unused imports
asfgit closed pull request #138: URL: https://github.com/apache/commons-math/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-534) use StandardCharsets.
[ https://issues.apache.org/jira/browse/COMPRESS-534?focusedWorklogId=440653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440653 ] ASF GitHub Bot logged work on COMPRESS-534: --- Author: ASF GitHub Bot Created on: 03/Jun/20 08:20 Start Date: 03/Jun/20 08:20 Worklog Time Spent: 10m Work Description: bodewig commented on pull request #105: URL: https://github.com/apache/commons-compress/pull/105#issuecomment-638041296 Many thanks @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440653) Time Spent: 20m (was: 10m) > use StandardCharsets. > - > > Key: COMPRESS-534 > URL: https://issues.apache.org/jira/browse/COMPRESS-534 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/105] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (COMPRESS-534) use StandardCharsets.
[ https://issues.apache.org/jira/browse/COMPRESS-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-534. - Fix Version/s: 1.21 Resolution: Fixed > use StandardCharsets. > - > > Key: COMPRESS-534 > URL: https://issues.apache.org/jira/browse/COMPRESS-534 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/105] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig commented on pull request #105: [COMPRESS-534] use StandardCharsets.
bodewig commented on pull request #105: URL: https://github.com/apache/commons-compress/pull/105#issuecomment-638041296 Many thanks @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] bodewig merged pull request #105: [COMPRESS-534] use StandardCharsets.
bodewig merged pull request #105: URL: https://github.com/apache/commons-compress/pull/105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-534) use StandardCharsets.
[ https://issues.apache.org/jira/browse/COMPRESS-534?focusedWorklogId=440654&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440654 ] ASF GitHub Bot logged work on COMPRESS-534: --- Author: ASF GitHub Bot Created on: 03/Jun/20 08:20 Start Date: 03/Jun/20 08:20 Worklog Time Spent: 10m Work Description: bodewig merged pull request #105: URL: https://github.com/apache/commons-compress/pull/105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440654) Time Spent: 0.5h (was: 20m) > use StandardCharsets. > - > > Key: COMPRESS-534 > URL: https://issues.apache.org/jira/browse/COMPRESS-534 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/105] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (COMPRESS-533) Refine javadoc and fix typos
[ https://issues.apache.org/jira/browse/COMPRESS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-533. - Fix Version/s: 1.21 Resolution: Fixed > Refine javadoc and fix typos > > > Key: COMPRESS-533 > URL: https://issues.apache.org/jira/browse/COMPRESS-533 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Fix For: 1.21 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/104] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-534) use StandardCharsets.
[ https://issues.apache.org/jira/browse/COMPRESS-534?focusedWorklogId=440647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440647 ] ASF GitHub Bot logged work on COMPRESS-534: --- Author: ASF GitHub Bot Created on: 03/Jun/20 07:57 Start Date: 03/Jun/20 07:57 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #105: URL: https://github.com/apache/commons-compress/pull/105#issuecomment-638029254 [](https://coveralls.io/builds/31205580) Coverage increased (+0.08%) to 87.31% when pulling **243bfff8cace2a29e32b0622ae205b6b66c07616 on XenoAmess:use_StandardCharsets** into **04abbdf3b7e78e9fd4ba5c46e22f0472a7974ad6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440647) Remaining Estimate: 0h Time Spent: 10m > use StandardCharsets. > - > > Key: COMPRESS-534 > URL: https://issues.apache.org/jira/browse/COMPRESS-534 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/105] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] coveralls commented on pull request #105: [COMPRESS-534] use StandardCharsets.
coveralls commented on pull request #105: URL: https://github.com/apache/commons-compress/pull/105#issuecomment-638029254 [](https://coveralls.io/builds/31205580) Coverage increased (+0.08%) to 87.31% when pulling **243bfff8cace2a29e32b0622ae205b6b66c07616 on XenoAmess:use_StandardCharsets** into **04abbdf3b7e78e9fd4ba5c46e22f0472a7974ad6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMPRESS-534) use StandardCharsets.
JIN XU created COMPRESS-534: --- Summary: use StandardCharsets. Key: COMPRESS-534 URL: https://issues.apache.org/jira/browse/COMPRESS-534 Project: Commons Compress Issue Type: Improvement Reporter: JIN XU [https://github.com/apache/commons-compress/pull/105] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] XenoAmess opened a new pull request #105: use StandardCharsets.
XenoAmess opened a new pull request #105: URL: https://github.com/apache/commons-compress/pull/105 In most cases using StandardCharsets is faster. You can get more information at `decode(String charsetName, byte[] ba, int off, int len)`` and `decode(Charset cs, byte[] ba, int off, int len)` in class java.lang.StringCoding This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMPRESS-533) Refine javadoc and fix typos
[ https://issues.apache.org/jira/browse/COMPRESS-533?focusedWorklogId=440625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440625 ] ASF GitHub Bot logged work on COMPRESS-533: --- Author: ASF GitHub Bot Created on: 03/Jun/20 07:07 Start Date: 03/Jun/20 07:07 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #104: URL: https://github.com/apache/commons-compress/pull/104#issuecomment-638002153 > I'm not sure we've got an agreed upon language at all :-) > In this particular case it may depend on the context. `archiveName` would be the file name of an archive, `archiverName` represent the archive format tar/zip/7z... Ok, I get it now, thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440625) Time Spent: 1h 40m (was: 1.5h) > Refine javadoc and fix typos > > > Key: COMPRESS-533 > URL: https://issues.apache.org/jira/browse/COMPRESS-533 > Project: Commons Compress > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-compress/pull/104] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] XenoAmess commented on pull request #104: [COMPRESS-533] Refine javadoc and fix typos
XenoAmess commented on pull request #104: URL: https://github.com/apache/commons-compress/pull/104#issuecomment-638002153 > I'm not sure we've got an agreed upon language at all :-) > In this particular case it may depend on the context. `archiveName` would be the file name of an archive, `archiverName` represent the archive format tar/zip/7z... Ok, I get it now, thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
