[GitHub] [commons-vfs] dwalluck commented on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
dwalluck commented on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647840475 > @dwalluck If you mean creating a temp file and clone the content into it, that can be done. > But should in another function. > Whenever you create a temp file you should consider about when to delete it. I am not sure if I will make sense, but I will try. I think there are two issues: 1. If I want to get a `java.io.File` from a `FileObject`, it isn't clear to me if this would be done automatically for a remote file (non-`file://` URL) 2. If I want to take advantage of the file cache, say for multiple calls to the same URL, then I think I want the cache to persist. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647823878 > Is it possible to get a local file for a remote object like an HTTP URL? Even if it must copy the input stream first, it would be nice to have such functionality provided. @dwalluck If you mean creating a temp file and clone the content into it, that can be done. But should in another function. Whenever you create a temp file you should consider about when to delete it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess edited a comment on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess edited a comment on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647823878 > Is it possible to get a local file for a remote object like an HTTP URL? Even if it must copy the input stream first, it would be nice to have such functionality provided. @dwalluck If you mean creating a temp file and clone the content into it, this can be done. But should in another function. Whenever you create a temp file you should consider about when to delete it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] XenoAmess commented on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
XenoAmess commented on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647823878 > Is it possible to get a local file for a remote object like an HTTP URL? Even if it must copy the input stream first, it would be nice to have such functionality provided. @dwalluck If you mean creating a temp file and clone the content into it, this can be done. But should in another function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #278: Lang-1345 Enhance non-empty strings
coveralls edited a comment on pull request #278: URL: https://github.com/apache/commons-lang/pull/278#issuecomment-315913704 [](https://coveralls.io/builds/31617304) Coverage decreased (-0.2%) to 94.9% when pulling **3ec23f1f2606d6578340209b5a6540c911a7e6c8 on ThrawnCA:LANG-1345-enhance-non-empty-strings** into **f6923510352fc3fbfad68bc6c5ac5258a34671b7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dwalluck commented on pull request #89: [VFS-443] added function FileSystemManager.toFile(FileObject fileObject)
dwalluck commented on pull request #89: URL: https://github.com/apache/commons-vfs/pull/89#issuecomment-647809251 Is it possible to get a local file for a remote object like an HTTP URL? Even if it must copy the input stream first, it would be nice to have such functionality provided. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] commented on pull request #44: Bump checkstyle from 6.9 to 8.18
dependabot[bot] commented on pull request #44: URL: https://github.com/apache/commons-net/pull/44#issuecomment-647798916 Looks like com.puppycrawl.tools:checkstyle is no longer a dependency, so this is no longer needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] closed pull request #44: Bump checkstyle from 6.9 to 8.18
dependabot[bot] closed pull request #44: URL: https://github.com/apache/commons-net/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647708419 Thanks @XenoAmess for the information. What should i do now? Is the Pr merged or should i reopen it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition
bhawna94 commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647728065 Oh okay i thought they had closed the PR without merging. My bad!! Btw thanks for all your assistance. @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess edited a comment on pull request #146: Simplify if condition
XenoAmess edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647722091 > Thanks @XenoAmess for the information. What should i do now? I cant reopen this PR. you needn't. this pr is already merged. lol you can see more details in https://github.com/apache/commons-math/commits/master , your commit is in there now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition
XenoAmess commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647722091 > Thanks @XenoAmess for the information. What should i do now? I cant reopen this PR. you needn't. this pr is already merged. lol This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition
bhawna94 commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647708419 Thanks @XenoAmess for the information. What should i do now? I cant reopen this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] XenoAmess commented on pull request #146: Simplify if condition
XenoAmess commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647650646 @bhawna94 sometimes they close it instead of merge due to some git reason. If they close with a commit then the commit might be your commit. this time it is https://github.com/apache/commons-math/commit/0d937abf8ca9878aadc1b4e62e333976e74e8942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111 > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week (probably tomorrow at lunch break if not too busy, or maybe once I get home) Any reason for closing this PR? I am not able to reopen it again. @kinow Could you please reopen it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 edited a comment on pull request #146: Simplify if condition
bhawna94 edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111 > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week (probably tomorrow at lunch break if not too busy, or maybe once I get home) Any reason for closing this PR? I am not able to reopen it again. @kinow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] bhawna94 commented on pull request #146: Simplify if condition
bhawna94 commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647599111 > Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week (probably tomorrow at lunch break if not too busy, or maybe once I get home) Any reason for closing this PR? I am not able to reopen it again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-673) Make some simplifications
[ https://issues.apache.org/jira/browse/IO-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-673. Fix Version/s: 2.7.1 Resolution: Fixed > Make some simplifications > - > > Key: IO-673 > URL: https://issues.apache.org/jira/browse/IO-673 > Project: Commons IO > Issue Type: Improvement >Reporter: Jerome Wolff >Priority: Minor > Fix For: 2.7.1 > > > # Redundant assignment of local variables removed > # Lambda expression simplified > PR: [https://github.com/apache/commons-io/pull/121] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory merged pull request #121: Make some simplifications
garydgregory merged pull request #121: URL: https://github.com/apache/commons-io/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-538) ZipEntry created using ZipArchiveOutputStream(File) constructor adds 'ZIP64 Extended Information Extra Field' even when zip64 is not required.
[
https://issues.apache.org/jira/browse/COMPRESS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141969#comment-17141969
]
Peter Lee commented on COMPRESS-538:
Ah, I see. Will look deeper here. A bit busy recently ... hope I could carve
out some time this week for this. :)
> ZipEntry created using ZipArchiveOutputStream(File) constructor adds 'ZIP64
> Extended Information Extra Field' even when zip64 is not required.
> --
>
> Key: COMPRESS-538
> URL: https://issues.apache.org/jira/browse/COMPRESS-538
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.8, 1.9, 1.20
>Reporter: Pritesh
>Assignee: Peter Lee
>Priority: Major
>
> When creating a zip file using
> [ZipArchiveOutputStream(File)|https://commons.apache.org/proper/commons-compress/apidocs/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.html#ZipArchiveOutputStream-java.io.File-]
> constructor each entry get an extra `Zip64ExtendedInformationExtraField`
> header which shouldn't be there.
>
> The issue can be reproduced using below code sample
> {code:java}
> public static void main(String[] args) throws IOException {
> // Create file
> final File file = File.createTempFile("apache_", ".zip");
> try ( ZipArchiveOutputStream zos = new ZipArchiveOutputStream(file)) {
> zos.putArchiveEntry(new ZipArchiveEntry("TextFile1.txt"));
> zos.closeArchiveEntry();
> }
> // List Headers File
> final ZipFile zipFile = new ZipFile(file);
> final Enumeration entries =
> zipFile.getEntries();
> while (entries.hasMoreElements()) {
> final ZipArchiveEntry entry = entries.nextElement();
> for (ZipExtraField zipExtraField : entry.getExtraFields()) {
> System.out.println("EntryName:" + entry.getName() + " Header:
> "+ zipExtraField.getHeaderId().getValue()); // Header shouldn't be present.
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] asfgit closed pull request #146: Simplify if condition
asfgit closed pull request #146: URL: https://github.com/apache/commons-math/pull/146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] kinow edited a comment on pull request #146: Simplify if condition
kinow edited a comment on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647407576 Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week :+1: (probably tomorrow at lunch break if not too busy, or maybe once I get home) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] kinow commented on pull request #146: Simplify if condition
kinow commented on pull request #146: URL: https://github.com/apache/commons-math/pull/146#issuecomment-647407576 Sorry @bhawna94 I am away from my computer, approved from my mobile. The changes appear to be in source code, and not only for tests. Would you mind creating an issue for this PR, please? I will take care to update changelog and merge it later this week :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-748) TarProvider Incorrectly marks file IMAGINARY after garbage collection with weakRefFilesCache
[ https://issues.apache.org/jira/browse/VFS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141851#comment-17141851 ] linchen commented on VFS-748: - Pass the test case you gave， tbz2 and tgz are extension-map with tar in providers.xml. In other words, parsing tbz2 and tgz files requires TarFileSystem.java for processing. According to the comment on line 210 of the code TarFileSystem.java : "This is only called for files which do not exist in the Tar file", I have reason to believe that this is in line with the author's expectations. > TarProvider Incorrectly marks file IMAGINARY after garbage collection with > weakRefFilesCache > > > Key: VFS-748 > URL: https://issues.apache.org/jira/browse/VFS-748 > Project: Commons VFS > Issue Type: Bug >Affects Versions: 2.2 > Environment: commons-vfs2.2.jar > commons-compress-1.18.jar >Reporter: Tim >Priority: Major > Attachments: TarBug.java, test.tar.gz > > > A Tar FileObject becomes unusable once it is removed from the filesCache. > The example provided here uses the the WeakRefFilesCache but I suspect the > bug is not limited to this cache type only, since it is the recreation of the > entry after removal that is flawed. > > The following code snippet will repeatedly access the the tarball until > garbage collection occurs. When this happens the cache entry is dropped but > upon reaccess, a new cache entry is created that incorrectly marks the file > as "IMAGINARY". All subsequent access to this file is are not possible in > the VM. > > Output from the class provided looks like this > 97 > 98 > 99 > 100 > tgz:[file:///C:/env/ws/vfsTarBug/target/classes/test.tar.gz!/] did not exist > > The number of successful iterations may vary depending upon the behavior of > the GC. > Tracing the run, the culprit appears to be a createFile method which hard > codes the tarExists argument to false when it should be true. The stack > trace for this appears below. > at > org.apache.commons.vfs2.provider.tar.TarFileSystem.createFile(TarFileSystem.java:210)at > > org.apache.commons.vfs2.provider.tar.TarFileSystem.createFile(TarFileSystem.java:210) > at > org.apache.commons.vfs2.provider.AbstractFileSystem.resolveFile(AbstractFileSystem.java:320) > - locked <0x53d2> (a org.apache.commons.vfs2.provider.tar.TarFileSystem) > at > org.apache.commons.vfs2.provider.AbstractFileSystem.resolveFile(AbstractFileSystem.java:300) > at > org.apache.commons.vfs2.provider.AbstractFileSystem.getRoot(AbstractFileSystem.java:274) > at > org.apache.commons.vfs2.provider.AbstractLayeredFileProvider.createFileSystem(AbstractLayeredFileProvider.java:82) > - locked <0x53e2> (a org.apache.commons.vfs2.provider.tar.TarFileProvider) > at > org.apache.commons.vfs2.provider.AbstractLayeredFileProvider.findFile(AbstractLayeredFileProvider.java:56) > at > org.apache.commons.vfs2.impl.DefaultFileSystemManager.resolveFile(DefaultFileSystemManager.java:711) > at > org.pentaho.di.core.vfs.ConcurrentFileSystemManager.resolveFile(ConcurrentFileSystemManager.java:91) > at > org.apache.commons.vfs2.impl.DefaultFileSystemManager.resolveFile(DefaultFileSystemManager.java:648) -- This message was sent by Atlassian Jira (v8.3.4#803005)
