[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468187=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468187 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 08/Aug/20 04:49 Start Date: 08/Aug/20 04:49 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32620597) Coverage decreased (-0.0003%) to 94.665% when pulling **302c0d64261b210e22852e2b726fdfefce0e8a38 on XenoAmess:refine_chomp** into **cf0bc2b5dbb08ee1f5c0c8d54df307e23345544d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468187) Time Spent: 4.5h (was: 4h 20m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 4.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #565: [LANG-1576] refine StringUtils.chomp
coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32620597) Coverage decreased (-0.0003%) to 94.665% when pulling **302c0d64261b210e22852e2b726fdfefce0e8a38 on XenoAmess:refine_chomp** into **cf0bc2b5dbb08ee1f5c0c8d54df307e23345544d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-670822156 @aherbert Hi. I changed the jmh codes according to your suggestions, and re-run performance test. full test at: https://pastebin.ubuntu.com/p/cqNKS35zSP/ in short: ``` Benchmark (data) (name) Mode Cnt Score Error Units StringUtilsChompTest.singleStringNULL old avgt5 2.737 ?0.166 ns/op StringUtilsChompTest.singleStringNULL new avgt5 2.789 ?0.213 ns/op StringUtilsChompTest.singleString CHAR0 old avgt5 3.227 ?0.459 ns/op StringUtilsChompTest.singleString CHAR0 new avgt5 3.168 ?0.233 ns/op StringUtilsChompTest.singleStringCHAR0_CR old avgt5 3.706 ?0.035 ns/op StringUtilsChompTest.singleStringCHAR0_CR new avgt5 3.674 ?0.480 ns/op StringUtilsChompTest.singleStringCHAR0_LF old avgt5 3.656 ?0.410 ns/op StringUtilsChompTest.singleStringCHAR0_LF new avgt5 3.682 ?0.525 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF old avgt5 9.538 ?1.558 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF new avgt5 9.359 ?0.499 ns/op StringUtilsChompTest.singleString CHAR1 old avgt5 3.880 ?0.531 ns/op StringUtilsChompTest.singleString CHAR1 new avgt5 3.803 ?0.451 ns/op StringUtilsChompTest.singleStringCHAR1_CR old avgt5 17.378 ?2.431 ns/op StringUtilsChompTest.singleStringCHAR1_CR new avgt5 21.752 ? 23.793 ns/op StringUtilsChompTest.singleStringCHAR1_LF old avgt5 19.025 ?4.690 ns/op StringUtilsChompTest.singleStringCHAR1_LF new avgt5 18.087 ?2.450 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF old avgt5 17.940 ?1.500 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF new avgt5 18.130 ?1.195 ns/op StringUtilsChompTest.singleString CHAR2 old avgt5 4.216 ?1.192 ns/op StringUtilsChompTest.singleString CHAR2 new avgt5 4.341 ?0.310 ns/op StringUtilsChompTest.singleStringCHAR2_CR old avgt5 17.308 ?2.704 ns/op StringUtilsChompTest.singleStringCHAR2_CR new avgt5 18.087 ?2.312 ns/op StringUtilsChompTest.singleStringCHAR2_LF old avgt5 18.527 ?2.699 ns/op StringUtilsChompTest.singleStringCHAR2_LF new avgt5 18.200 ?1.919 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF old avgt5 17.692 ?0.991 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF new avgt5 18.285 ?2.505 ns/op StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt5 66999.815 ?10053.205 ns/op StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt5 76290.287 ?15986.436 ns/op ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468186=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468186 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 08/Aug/20 04:28 Start Date: 08/Aug/20 04:28 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-670822156 @aherbert Hi. I changed the jmh codes according to your suggestions, and re-run performance test. full test at: https://pastebin.ubuntu.com/p/cqNKS35zSP/ in short: ``` Benchmark (data) (name) Mode Cnt Score Error Units StringUtilsChompTest.singleStringNULL old avgt5 2.737 ?0.166 ns/op StringUtilsChompTest.singleStringNULL new avgt5 2.789 ?0.213 ns/op StringUtilsChompTest.singleString CHAR0 old avgt5 3.227 ?0.459 ns/op StringUtilsChompTest.singleString CHAR0 new avgt5 3.168 ?0.233 ns/op StringUtilsChompTest.singleStringCHAR0_CR old avgt5 3.706 ?0.035 ns/op StringUtilsChompTest.singleStringCHAR0_CR new avgt5 3.674 ?0.480 ns/op StringUtilsChompTest.singleStringCHAR0_LF old avgt5 3.656 ?0.410 ns/op StringUtilsChompTest.singleStringCHAR0_LF new avgt5 3.682 ?0.525 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF old avgt5 9.538 ?1.558 ns/op StringUtilsChompTest.singleString CHAR0_CR_LF new avgt5 9.359 ?0.499 ns/op StringUtilsChompTest.singleString CHAR1 old avgt5 3.880 ?0.531 ns/op StringUtilsChompTest.singleString CHAR1 new avgt5 3.803 ?0.451 ns/op StringUtilsChompTest.singleStringCHAR1_CR old avgt5 17.378 ?2.431 ns/op StringUtilsChompTest.singleStringCHAR1_CR new avgt5 21.752 ? 23.793 ns/op StringUtilsChompTest.singleStringCHAR1_LF old avgt5 19.025 ?4.690 ns/op StringUtilsChompTest.singleStringCHAR1_LF new avgt5 18.087 ?2.450 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF old avgt5 17.940 ?1.500 ns/op StringUtilsChompTest.singleString CHAR1_CR_LF new avgt5 18.130 ?1.195 ns/op StringUtilsChompTest.singleString CHAR2 old avgt5 4.216 ?1.192 ns/op StringUtilsChompTest.singleString CHAR2 new avgt5 4.341 ?0.310 ns/op StringUtilsChompTest.singleStringCHAR2_CR old avgt5 17.308 ?2.704 ns/op StringUtilsChompTest.singleStringCHAR2_CR new avgt5 18.087 ?2.312 ns/op StringUtilsChompTest.singleStringCHAR2_LF old avgt5 18.527 ?2.699 ns/op StringUtilsChompTest.singleStringCHAR2_LF new avgt5 18.200 ?1.919 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF old avgt5 17.692 ?0.991 ns/op StringUtilsChompTest.singleString CHAR2_CR_LF new avgt5 18.285 ?2.505 ns/op StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt5 66999.815 ?10053.205 ns/op StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt5 76290.287 ?15986.436 ns/op ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468186) Time Spent: 4h 20m (was: 4h 10m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 4h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] garydgregory opened a new pull request #123: Add Path support to ZipArchiveOutputStream
garydgregory opened a new pull request #123: URL: https://github.com/apache/commons-compress/pull/123 Add `Path` support to `ZipArchiveOutputStream` with an eye on implementing additional `ArchiveOutputStream.createArchiveEntry(Path, String, LinkOption...)` methods in a later PR if this one is OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173447#comment-17173447 ] Phil Steitz commented on DBCP-559: -- I am working on a PR with tests for this, though I will happily review any PRs that come in before I finish. A [similar request|[https://lists.apache.org/thread.html/rf9006a5e3285bc32f0742ad4833c39852601305d5e56fc03dde60043%40%3Cusers.tomcat.apache.org%3E]] was recently posted to tomcat-user. I am hoping that close followed by the simple open proposed in the attachment file (possibly also exposed as combined, "restart") will lead to # Idle connections get immediately closed (close contract) # Checked out connections get closed as they return (but abandoned connection cleanup stops for the pool being closed) # Any config changes made since initialization of running pool are applied to the new pool # New connections get sourced from a new pool that is initialized in "open" # No timer thread leaks or other untoward side effects I will try to add tests to confirm. > 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效 > --- > > Key: DBCP-559 > URL: https://issues.apache.org/jira/browse/DBCP-559 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Wenzhi Ji >Priority: Major > Labels: ready-to-commit > Fix For: 2.8.0 > > Attachments: BasicDataSource.java, BasicDataSourceMXBean.java > > Original Estimate: 1h > Remaining Estimate: 1h > > 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。 > 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed > = false；以使建立的数据库连接生效。 > 变更的代码见附件。 > 注：附件是基于2.7.0版本代码进行优化的。 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DAEMON-423) space character in StopImage path not supported
[ https://issues.apache.org/jira/browse/DAEMON-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173153#comment-17173153 ] Gary D. Gregory commented on DAEMON-423: We welcome PRs on GitHub :) > space character in StopImage path not supported > --- > > Key: DAEMON-423 > URL: https://issues.apache.org/jira/browse/DAEMON-423 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.1.0, 1.2.2 >Reporter: Ralf Sieger >Priority: Major > > In exe mode with an stop image command like: > --StopImage "C:\Program Files\scripts\service\stop.cmd" > procrun is unable to stop the service. > The stderr just shows: > "Der Befehl "C:\Program" ist entweder falsch geschrieben oder > konnte nicht gefunden werden." > which translates to: > The command "C: \Program" is either misspelled or > could not be found. > > Having a space on StartImage path is working. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CONFIGURATION-792) commons-configuration 1.10 breaks code that worked with 1.9
[
https://issues.apache.org/jira/browse/CONFIGURATION-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173091#comment-17173091
]
Gary D. Gregory commented on CONFIGURATION-792:
---
The 1.x line is unlikely to see a new release, I am focused on 2.x.
> commons-configuration 1.10 breaks code that worked with 1.9
> ---
>
> Key: CONFIGURATION-792
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-792
> Project: Commons Configuration
> Issue Type: Bug
>Affects Versions: 1.10
>Reporter: Norbert Kiesel
>Priority: Major
>
> CONFIGURATION-556 changed how ConfigurationConverter.getConfiguration works:
> in 1.9, the Properties content was read into a newly created HashMap but in
> 1.10 this was changed to use the Properties as backing. While this allows to
> have changes to the Properties immediately reflected in the configuration, it
> breaks code that adds new entries to such a configuration.
> Example:
> {code:java}
> Properties properties = new Properties();
> properties.load(Files.newInputStream(Paths.get("sample.properties")));
> Configuration conf = ConfigurationConverter.getConfiguration(properties);
> conf.setProperty("version", "1.10");
> {code}
> will work in 1.9 but result in a NPE in 1.10.
> I understand that there are conflicting goals (compatibility with 1.7 or 1.9)
> but I think this should minimally be listed as a potential problem for
> upgrades to 1.10
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (DAEMON-423) space character in StopImage path not supported
Ralf Sieger created DAEMON-423: -- Summary: space character in StopImage path not supported Key: DAEMON-423 URL: https://issues.apache.org/jira/browse/DAEMON-423 Project: Commons Daemon Issue Type: Bug Components: prunsrv Affects Versions: 1.2.2, 1.1.0 Reporter: Ralf Sieger In exe mode with an stop image command like: --StopImage "C:\Program Files\scripts\service\stop.cmd" procrun is unable to stop the service. The stderr just shows: "Der Befehl "C:\Program" ist entweder falsch geschrieben oder konnte nicht gefunden werden." which translates to: The command "C: \Program" is either misspelled or could not be found. Having a space on StartImage path is working. -- This message was sent by Atlassian Jira (v8.3.4#803005)
