[GitHub] [commons-fileupload] kinow merged pull request #37: Bump maven-checkstyle-plugin from 2.10 to 3.1.1
kinow merged pull request #37: URL: https://github.com/apache/commons-fileupload/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #602: Made String Reverse Method Faster
XenoAmess commented on pull request #602: URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671747922 besides, you should run a jmh test to show the performance incresement. see HashSetvBitSetTest for example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #602: Made String Reverse Method Faster
XenoAmess edited a comment on pull request #602: URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671747098 Hi. It actually breaks BC... the original code can handle surrogate pairs. you can see details in StringBuilder's source codes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #602: Made String Reverse Method Faster
XenoAmess commented on pull request #602: URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671747098 Hi. It actually breaks BC... the original code can handle surrogate pairs. you can see details in StringBuilder's source. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #37: Bump maven-checkstyle-plugin from 2.10 to 3.1.1
coveralls commented on pull request #37: URL: https://github.com/apache/commons-fileupload/pull/37#issuecomment-671744973 [](https://coveralls.io/builds/32667251) Coverage remained the same at 78.357% when pulling **449b599bb62c8d445c421259bd610f4afd8cfb92 on dependabot/maven/org.apache.maven.plugins-maven-checkstyle-plugin-3.1.1** into **78dca9c612e7019175ace035897f9da15a2ff11a on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request #37: Bump maven-checkstyle-plugin from 2.10 to 3.1.1
dependabot[bot] opened a new pull request #37: URL: https://github.com/apache/commons-fileupload/pull/37 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 2.10 to 3.1.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/104b560b37f906fa843d2235d23ff9be5948f3eb";>104b560 [maven-release-plugin] prepare release maven-checkstyle-plugin-3.1.1 https://github.com/apache/maven-checkstyle-plugin/commit/eb47facb0cba61a5df9baa534e11e21170f05c46";>eb47fac added reproducible build output timestamp property https://github.com/apache/maven-checkstyle-plugin/commit/bc0785d5985ed214d717c555ef6586f55a249d92";>bc0785d [MCHECKSTYLE-391] Update parent to 34 https://github.com/apache/maven-checkstyle-plugin/commit/de614e3ce5f4b4b7fc12e6cbd54189638e58a551";>de614e3 [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change back to '... https://github.com/apache/maven-checkstyle-plugin/commit/c427a30030649947c0780d81517a30f188760541";>c427a30 [MCHECKSTYLE-390] Upgrade to checkstyle 8.29 https://github.com/apache/maven-checkstyle-plugin/commit/e1e2f28620e2baed8351fea5fa524e98749df55c";>e1e2f28 MCHECKSTYLE-384 Bump checkstyle to 8.28 https://github.com/apache/maven-checkstyle-plugin/commit/f0b96ab98437149486771df879a23e5740090f0c";>f0b96ab [MCHECKSTYLE-388] Upgrade dependencies https://github.com/apache/maven-checkstyle-plugin/commit/eae07f99f01584bfd3da90a8c5eb32364e8ee82b";>eae07f9 [MCHECKSTYLE-381] make call to checker.setClassLoader() optional. https://github.com/apache/maven-checkstyle-plugin/commit/26848dca567bf64cf2d26a5cb099d76c01792879";>26848dc Merge pull request https://github-redirect.dependabot.com/apache/maven-checkstyle-plugin/issues/12";>#12 from srdo/MCHECKSTYLE-371 https://github.com/apache/maven-checkstyle-plugin/commit/2485ea76e8b5b95a77fcc1b2e15cbab575f32ac3";>2485ea7 Merge pull request https://github-redirect.dependabot.com/apache/maven-checkstyle-plugin/issues/20";>#20 from elharo/patch-1 Additional commits viewable in https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-2.10...maven-checkstyle-plugin-3.1.1";>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request #10: Bump versions-maven-plugin from 2.7 to 2.8.1
dependabot[bot] opened a new pull request #10: URL: https://github.com/apache/commons-build-plugin/pull/10 Bumps [versions-maven-plugin](https://github.com/mojohaus/versions-maven-plugin) from 2.7 to 2.8.1. Release notes Sourced from https://github.com/mojohaus/versions-maven-plugin/releases";>versions-maven-plugin's releases. 2.8.1 :star: New Features Remove cobertura-maven-plugin https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/409";>#409 Removed plexus-i18n https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/405";>#405 Fixes https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/82";>#82 ensure version change affects only the current directory (and child directories), not the parent or sibling directories https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/pull/400";>#400 Fixes https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/321";>#321 fail the build when parsing XML of child modules fails due to invalid XML https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/pull/399";>#399 Upgrade GitHub Actions https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/398";>#398 Ensure display output is order, only order at point of printing https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/pull/394";>#394 use-latest-versions ignores dependencies with versions defined as properties https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/340";>#340 make build reproducible https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/424";>#424 :beetle: Bug Fixes Downgrade commons-lang3 to 3.8.1 to keep JDK7 promise https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/411";>#411 Warning if plugin is executed in parallel https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/373";>#373 display-plugin-updates fails if non-local parent is present in POM https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/422";>#422 :hammer: Dependency Upgrades Upgrade maven-invoker-plugin to 3.2.1 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/420";>#420 Upgrade modello-maven-plugin from 1.9.1 to 1.11 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/410";>#410 Upgrade plugin version for versions-maven-plugin from 2.4 to 2.7 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/408";>#408 Upgrade doxia from 1.7 to 1.9.1 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/407";>#407 Upgrade wagon from 2.12 to 3.4.0 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/406";>#406 Upgrade plexus-interactivity-api from 1.0-alpha-6 to 1.0 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/404";>#404 Upgrade plexus-container-default from 1.7.1 to 2.1.0 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/403";>#403 Upgrade hamcrest-library from 1.3 to hamcrest-core 2.2 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/402";>#402 Upgrade mockito 1.9.5 to 2.28.2 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/401";>#401 Upgrade woodstox-core-asl from 4.2.0 to 4.4.1 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/397";>#397 Upgrade maven-common-artifact-filters to 3.1.0 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/389";>#389 Upgrade plexus-utils to 3.3.0 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/388";>#388 commons-lang3 v3.9 https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/pull/380";>#380 :heart: Contributors We'd like to thank all the contributors who worked on this release! https://github.com/stefanseifert";>@stefanseifert https://github.com/nhojpatrick";>@nhojpatrick Commits https://github.com/mojohaus/versions-maven-plugin/commit/2bd95c901e4589d23a25473ca4f5850da181b3d5";>2bd95c9 [maven-release-plugin] prepare release versions-maven-plugin-2.8.1 https://github.com/mojohaus/versions-maven-plugin/commit/f4b555b3363402176811d5220aeeaa1c04377ede";>f4b555b Merge pull request https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/423";>#423 from stefanseifert/issue/422-plugin-updates-parent-npe https://github.com/mojohaus/versions-maven-plugin/commit/979e3631311a1982f3088e8576dcc815cf85ff19";>979e363 make build reproducible https://github-redirect.dependabot.com/mojohaus/versions-maven-plugin/issues/424";>#424 https://github.com/mojohaus/versions-maven-plugin/commit/29b368d003a4b86715e8a7c00b370411612007d8";>29b368
[GitHub] [commons-bcel] Hippo edited a comment on pull request #58: BCEL-341: Oak class file patch
Hippo edited a comment on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671710080 I realized that my idea for making it "more stable" would require a massive overhaul on the library, which doesn't seem like a good idea. I can think of a different approach if you would like, though I personally don't think its necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671710080 I realized that my idea for making it stable would require a massive overhaul on the library, which doesn't seem like a good idea. I can think of a different approach if you would like, though I personally don't think its necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671700881 [OakFile.java.zip](https://github.com/apache/commons-bcel/files/5054556/OakFile.java.zip) There is no license, it's practically a hello world program. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #140: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #140: URL: https://github.com/apache/commons-io/pull/140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #58: BCEL-341: Oak class file patch
garydgregory commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671654428 > [OakFile.class.zip](https://github.com/apache/commons-bcel/files/5053630/OakFile.class.zip) > > This is an oak class file that BCEL fails to parse without my patches, I fixed the checkstyle error. But I am still not sure how I feel about over complicating things with an oop system on weather to read a u1 or u2. But if that is what you want I will implement it once I get off work 👍 Thank you for the class file. I think we'll need the source to include it in the project repo to make sure the licensing is OK for an Apache project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #602: Made String Reverse Method Faster
coveralls edited a comment on pull request #602: URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671633372 [](https://coveralls.io/builds/32661981) Coverage increased (+0.01%) to 94.666% when pulling **2a07a009c4d4d4be044f121637ec3b01242ea36b on nishantc1527:master** into **9f52471fab5bf82db3d2f9e0086bf3c56c894ec6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #602: Made String Reverse Method Faster
coveralls commented on pull request #602: URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671633372 [](https://coveralls.io/builds/32661495) Coverage increased (+0.01%) to 94.666% when pulling **e3a30ea45a18fab29719d3fc82038fb4b0e2df56 on nishantc1527:master** into **9f52471fab5bf82db3d2f9e0086bf3c56c894ec6 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] nishantc1527 opened a new pull request #602: Made String Reverse Method Faster
nishantc1527 opened a new pull request #602: URL: https://github.com/apache/commons-lang/pull/602 Right now, StringUtils.reverse() is done the lazy way by initializing a new Stringbuilder, calling reverse, then converting back into a string. I filled out the reverse method by doing it manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-660) How to contribute patch for ByteArrayOutputStream
[ https://issues.apache.org/jira/browse/IO-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-660. - Resolution: Information Provided > How to contribute patch for ByteArrayOutputStream > - > > Key: IO-660 > URL: https://issues.apache.org/jira/browse/IO-660 > Project: Commons IO > Issue Type: Bug > Components: Streams/Writers >Affects Versions: 2.6 >Reporter: adam Retter >Priority: Trivial > > I would like to contribute some code to improve ByteArrayOutputStream. > > At the moment that class has explicit synchronisation, which impacts its > performance when used in single-thread scenarios. I would like to refactor it > into an AbstractByteArrayOutputStream and provide two implementations, one > with sync and one without. > > I also have a couple of additional utility methods that I would like to add > to it... > > What is the best way to start contributing to Commons-IO? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IO-681) IOUtils.close(Closeable) should allow a list of closeables
[ https://issues.apache.org/jira/browse/IO-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-681. - Fix Version/s: 2.8 Resolution: Fixed commit aefc8f42b027b33eb7b7d3346daef46e21384535 IO-681 IOUtils.close(Closeable) - allow a list --- src/changes/changes.xml | 3 +++ src/main/java/org/apache/commons/io/IOUtils.java | 10 ++ src/test/java/org/apache/commons/io/IOUtilsTestCase.java | 9 + 3 files changed, 18 insertions(+), 4 deletions(-) > IOUtils.close(Closeable) should allow a list of closeables > -- > > Key: IO-681 > URL: https://issues.apache.org/jira/browse/IO-681 > Project: Commons IO > Issue Type: Improvement >Reporter: Sebb >Priority: Minor > Fix For: 2.8 > > > It would be helpful to be able to apply IOUtils.close(Closeable) to multiple > closeables. > This was supported by the now deprecated method closeQuietly(Closeable...) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671613683 Actually I just thought of a more stable way to implement this, I will do so when I get the chance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-560) IOUtils write file lose data
[ https://issues.apache.org/jira/browse/IO-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-560. - Resolution: Information Provided > IOUtils write file lose data > > > Key: IO-560 > URL: https://issues.apache.org/jira/browse/IO-560 > Project: Commons IO > Issue Type: Bug > Components: Streams/Writers >Affects Versions: 1.3.2 > Environment: Mac OS 10.13.2 > Java version "1.8.0_111" > scalaVersion := "2.12.4" > IntelliJ IDEA 2017.2 >Reporter: chenjiangtao >Priority: Major > > # commons-io-1.3.2-IOUtils-Bug > ## IOUtils write file lose data > method: public static void write(String data, Writer output) > - result of file: mycat.jpg.b64 >  > - result of file: mystring >  > This bug test in Github > [https://github.com/chenjiangtao/commons-io-1.3.2-IOUtils-Bug] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671610099 [OakFile.class.zip](https://github.com/apache/commons-bcel/files/5053630/OakFile.class.zip) This is an oak class file that BCEL fails to parse without my patches, I fixed the checkstyle error. But I am still not sure how I feel about over complicating things with an oop system on weather to read a u1 or u2. But if that is what you want I will implement it once I get off work 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-683) CircularBufferInputStream.read() fails to convert byte to unsigned int
[ https://issues.apache.org/jira/browse/IO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175073#comment-17175073 ] Sebb commented on IO-683: - There is no URL to the Sonarlint warning - it just showed in my Visual Studio Code IDE. Any further discussion on this belongs on the dev list please. > CircularBufferInputStream.read() fails to convert byte to unsigned int > -- > > Key: IO-683 > URL: https://issues.apache.org/jira/browse/IO-683 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Assignee: Sebb >Priority: Major > Fix For: 2.8 > > > The method int CircularBufferInputStream.read() returns > CircularByteBuffer.read() which a byte. > However it does not convert it to an unsigned byte, so byte values outside > the range 0-127 will be sign-extended to a negative value. > This is wrong, and can result in premature EOF. > Note: this bug was reported by Sonarlint. > Spotbugs does not appear to detect the bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671591550 Since this is just support for oak class files, do I really need to write a test for it? Can't I just use the existing test cases? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #58: BCEL-341: Oak class file patch
garydgregory commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671588995 I think we should also have a class file or jar file that we can run through other existing tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-683) CircularBufferInputStream.read() fails to convert byte to unsigned int
[ https://issues.apache.org/jira/browse/IO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-683. - Fix Version/s: 2.8 Resolution: Fixed commit a521b43e774a92f4c07461536ffc810715c762d8 IO-683 failure to convert byte to unsigned CircularBufferInputStream.read() fails to convert byte to unsigned int --- src/changes/changes.xml| 3 +++ .../io/input/buffer/CircularBufferInputStream.java | 2 +- .../buffer/CircularBufferInputStreamTest.java | 22 ++ 3 files changed, 26 insertions(+), 1 deletion(-) > CircularBufferInputStream.read() fails to convert byte to unsigned int > -- > > Key: IO-683 > URL: https://issues.apache.org/jira/browse/IO-683 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Assignee: Sebb >Priority: Major > Fix For: 2.8 > > > The method int CircularBufferInputStream.read() returns > CircularByteBuffer.read() which a byte. > However it does not convert it to an unsigned byte, so byte values outside > the range 0-127 will be sign-extended to a negative value. > This is wrong, and can result in premature EOF. > Note: this bug was reported by Sonarlint. > Spotbugs does not appear to detect the bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-bcel] Hippo commented on pull request #58: BCEL-341: Oak class file patch
Hippo commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671586780 I will look into the check style error, and ill add a unit test. But as far as it being a version specific brute force hack is well, because this only occurs when one condition is met. Take a look here https://github.com/ItzSomebody/openjdk-jdk8u/blob/e87709def542f064a7ab9fa75542230e40876310/hotspot/src/share/vm/classfile/classFileParser.cpp#L2137 But if you really want me to give an oop approach on it I will do so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-683) CircularBufferInputStream.read() fails to convert byte to unsigned int
[ https://issues.apache.org/jira/browse/IO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175046#comment-17175046 ] Gary D. Gregory commented on IO-683: Hi [~sebb] May you please put a URL to this result here. Also perhaps in the README.md template, and our Site generation. ATM, I have no idea where to look. TY! Gary > CircularBufferInputStream.read() fails to convert byte to unsigned int > -- > > Key: IO-683 > URL: https://issues.apache.org/jira/browse/IO-683 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Assignee: Sebb >Priority: Major > > The method int CircularBufferInputStream.read() returns > CircularByteBuffer.read() which a byte. > However it does not convert it to an unsigned byte, so byte values outside > the range 0-127 will be sign-extended to a negative value. > This is wrong, and can result in premature EOF. > Note: this bug was reported by Sonarlint. > Spotbugs does not appear to detect the bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-683) CircularBufferInputStream.read() fails to convert byte to unsigned int
[ https://issues.apache.org/jira/browse/IO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated IO-683: Assignee: Sebb > CircularBufferInputStream.read() fails to convert byte to unsigned int > -- > > Key: IO-683 > URL: https://issues.apache.org/jira/browse/IO-683 > Project: Commons IO > Issue Type: Bug >Reporter: Sebb >Assignee: Sebb >Priority: Major > > The method int CircularBufferInputStream.read() returns > CircularByteBuffer.read() which a byte. > However it does not convert it to an unsigned byte, so byte values outside > the range 0-127 will be sign-extended to a negative value. > This is wrong, and can result in premature EOF. > Note: this bug was reported by Sonarlint. > Spotbugs does not appear to detect the bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated IO-552:
Assignee: (was: Sebb)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (IO-683) CircularBufferInputStream.read() fails to convert byte to unsigned int
Sebb created IO-683: --- Summary: CircularBufferInputStream.read() fails to convert byte to unsigned int Key: IO-683 URL: https://issues.apache.org/jira/browse/IO-683 Project: Commons IO Issue Type: Bug Reporter: Sebb The method int CircularBufferInputStream.read() returns CircularByteBuffer.read() which a byte. However it does not convert it to an unsigned byte, so byte values outside the range 0-127 will be sign-extended to a negative value. This is wrong, and can result in premature EOF. Note: this bug was reported by Sonarlint. Spotbugs does not appear to detect the bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated IO-552:
Assignee: Sebb
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Assignee: Sebb
>Priority: Critical
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-dbcp] garydgregory commented on pull request #36: PrepareStatement and prepareCall methods are extracted
garydgregory commented on pull request #36: URL: https://github.com/apache/commons-dbcp/pull/36#issuecomment-671571522 Closing, picked up from #37 @DoiMasayuki & @72er-de credited in changes.xml. TY! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory closed pull request #36: PrepareStatement and prepareCall methods are extracted
garydgregory closed pull request #36: URL: https://github.com/apache/commons-dbcp/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #41: fix travis-ci scripts
garydgregory commented on pull request #41: URL: https://github.com/apache/commons-dbcp/pull/41#issuecomment-671570737 Picked up .m2 caching in git master separately. TY @XenoAmess This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory closed pull request #41: fix travis-ci scripts
garydgregory closed pull request #41: URL: https://github.com/apache/commons-dbcp/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #36: PrepareStatement and prepareCall methods are extracted
garydgregory commented on pull request #36: URL: https://github.com/apache/commons-dbcp/pull/36#issuecomment-671569781 Should resolved by https://github.com/apache/commons-dbcp/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory merged pull request #37: Update to PR#36 - PrepareStatement and prepareCall methods are extracted
garydgregory merged pull request #37: URL: https://github.com/apache/commons-dbcp/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #37: Update to PR#36 - PrepareStatement and prepareCall methods are extracted
garydgregory commented on pull request #37: URL: https://github.com/apache/commons-dbcp/pull/37#issuecomment-671566978 Thank you @72er-de ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (DBCP-509) Not all methods are consistent in PerUserPooldataSource and InstanceKeyDataSource
[ https://issues.apache.org/jira/browse/DBCP-509?focusedWorklogId=468842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468842 ] ASF GitHub Bot logged work on DBCP-509: --- Author: ASF GitHub Bot Created on: 10/Aug/20 19:43 Start Date: 10/Aug/20 19:43 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #14: URL: https://github.com/apache/commons-dbcp/pull/14#issuecomment-671550816 @kinow May you please rebase on master? I'd like to see if the default goal in the POM properly causes the build to fail if JApiCmp fails. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468842) Remaining Estimate: 0h Time Spent: 10m > Not all methods are consistent in PerUserPooldataSource and > InstanceKeyDataSource > - > > Key: DBCP-509 > URL: https://issues.apache.org/jira/browse/DBCP-509 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.4.0 >Reporter: Bruno P. Kinoshita >Priority: Major > Fix For: 2.8.0 > > Time Spent: 10m > Remaining Estimate: 0h > > While working on DBCP-504 tests, I wrote a few files to help me automating > some of the tests (e.g. > https://gist.github.com/kinow/053b6d1f293fdc208a2a14571f246786). > In PerUserPooldataSource, I realized I had to change some tests that were > failing to handle null values. But not all methods. So I had a look at the > methods, and the majority was following a pattern > * using primitives > * default'ing to the class/parent method getDefaultPropertyZ() whenever Z > property was null > But three values were using objects instead of primitives, and allowing > null's: > * defaultAutoCommit > * defaultReadOnly > * perUserDefaultAutoCommit > I prepared a pull request that falls back to the default method's values. > It's more of a discussion issue, just to document what I found during > DBCP-504. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-dbcp] garydgregory commented on pull request #14: WIP DBCP-509: Consistency across methods in PerUserPooldataSource and its parent
garydgregory commented on pull request #14: URL: https://github.com/apache/commons-dbcp/pull/14#issuecomment-671550816 @kinow May you please rebase on master? I'd like to see if the default goal in the POM properly causes the build to fail if JApiCmp fails. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (DBCP-558) DelegatingConnection setReadOnly and setAutoCommit sometimes caches the wrong value
[ https://issues.apache.org/jira/browse/DBCP-558?focusedWorklogId=468835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468835 ] ASF GitHub Bot logged work on DBCP-558: --- Author: ASF GitHub Bot Created on: 10/Aug/20 19:39 Start Date: 10/Aug/20 19:39 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #35: URL: https://github.com/apache/commons-dbcp/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468835) Time Spent: 20m (was: 10m) > DelegatingConnection setReadOnly and setAutoCommit sometimes caches the wrong > value > --- > > Key: DBCP-558 > URL: https://issues.apache.org/jira/browse/DBCP-558 > Project: Commons DBCP > Issue Type: Bug >Affects Versions: 2.2.0 >Reporter: Louis Latreille >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > DelegatingConnection caches the input of setReadOnly and setAutoCommit > directly without checking if the underlying connection succeeded in setting > the configuration parameter. This results in wrong return value from > isReadOnly and getAutoCommit if the underlying connection doesn't support > read-only/non-read-only or auto-commit/non-auto-commit connections, as with > SqlServerConnection. > > To reproduce the issue: > # Create a DelegatingConnection with an underlying SqlServerConnection > # Set the connection read-only `con.setReadOnly(true)` > # Query the read-only state on the DelegatingConnection, you will get true > # Query the read-only state of the underlying SqlServerConnection, you will > get false (SqlServer JDBC driver doesn't support read-only connections) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (DBCP-558) DelegatingConnection setReadOnly and setAutoCommit sometimes caches the wrong value
[ https://issues.apache.org/jira/browse/DBCP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated DBCP-558: - Fix Version/s: (was: 2.8.0) > DelegatingConnection setReadOnly and setAutoCommit sometimes caches the wrong > value > --- > > Key: DBCP-558 > URL: https://issues.apache.org/jira/browse/DBCP-558 > Project: Commons DBCP > Issue Type: Bug >Affects Versions: 2.2.0 >Reporter: Louis Latreille >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > DelegatingConnection caches the input of setReadOnly and setAutoCommit > directly without checking if the underlying connection succeeded in setting > the configuration parameter. This results in wrong return value from > isReadOnly and getAutoCommit if the underlying connection doesn't support > read-only/non-read-only or auto-commit/non-auto-commit connections, as with > SqlServerConnection. > > To reproduce the issue: > # Create a DelegatingConnection with an underlying SqlServerConnection > # Set the connection read-only `con.setReadOnly(true)` > # Query the read-only state on the DelegatingConnection, you will get true > # Query the read-only state of the underlying SqlServerConnection, you will > get false (SqlServer JDBC driver doesn't support read-only connections) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-dbcp] garydgregory merged pull request #35: DBCP-558 Fix DelegatingConnection readOnly and autoCommit caching mechanism
garydgregory merged pull request #35: URL: https://github.com/apache/commons-dbcp/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[ https://issues.apache.org/jira/browse/DBCP-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved DBCP-559. -- Resolution: Fixed In git master, please verify and close. > 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效 > --- > > Key: DBCP-559 > URL: https://issues.apache.org/jira/browse/DBCP-559 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Wenzhi Ji >Priority: Major > Labels: ready-to-commit > Fix For: 2.8.0 > > Attachments: BasicDataSource.java, BasicDataSourceMXBean.java > > Original Estimate: 1h > Time Spent: 50m > Remaining Estimate: 10m > > 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。 > 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed > = false；以使建立的数据库连接生效。 > 变更的代码见附件。 > 注：附件是基于2.7.0版本代码进行优化的。 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[ https://issues.apache.org/jira/browse/DBCP-559?focusedWorklogId=468822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468822 ] ASF GitHub Bot logged work on DBCP-559: --- Author: ASF GitHub Bot Created on: 10/Aug/20 19:19 Start Date: 10/Aug/20 19:19 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #50: URL: https://github.com/apache/commons-dbcp/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468822) Remaining Estimate: 20m (was: 0.5h) Time Spent: 40m (was: 0.5h) > 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效 > --- > > Key: DBCP-559 > URL: https://issues.apache.org/jira/browse/DBCP-559 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.8.0 >Reporter: Wenzhi Ji >Priority: Major > Labels: ready-to-commit > Fix For: 2.8.0 > > Attachments: BasicDataSource.java, BasicDataSourceMXBean.java > > Original Estimate: 1h > Time Spent: 40m > Remaining Estimate: 20m > > 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。 > 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed > = false；以使建立的数据库连接生效。 > 变更的代码见附件。 > 注：附件是基于2.7.0版本代码进行优化的。 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-dbcp] garydgregory merged pull request #50: Add start, restart methods to BasicDataSource. JIRA: DBCP-559.
garydgregory merged pull request #50: URL: https://github.com/apache/commons-dbcp/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[
https://issues.apache.org/jira/browse/DBCP-559?focusedWorklogId=468823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468823
]
ASF GitHub Bot logged work on DBCP-559:
---
Author: ASF GitHub Bot
Created on: 10/Aug/20 19:19
Start Date: 10/Aug/20 19:19
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #50:
URL: https://github.com/apache/commons-dbcp/pull/50#discussion_r468123812
##
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##
@@ -433,6 +433,55 @@ public synchronized void close() throws SQLException {
}
}
+/**
+ * Starts the datasource.
+ *
+ * It is not necessary to call this method before using a newly created
BasicDataSource instance, but
+ * calling it in that context causes the datasource to be immediately
initialized (instead of waiting for
+ * the first {@link #getConnection()} request). Its primary use is to
restart and reinitialize a
+ * datasource that has been closed.
+ *
+ * When this method is called after {@link #close()}, connections checked
out by clients
+ * before the datasource was stopped do not count in {@link
#getMaxTotal()} or {@link #getNumActive()}.
+ * For example, if there are 3 connections checked out by clients when
{@link #close()} is invoked and they are
+ * not returned before {@link #start()} is invoked, after this method is
called, {@link #getNumActive()} will
+ * return 0. These connections will be physically closed when they are
returned, but they will not count against
+ * the maximum allowed in the newly started datasource.
+ *
+ * @throws SQLException if an error occurs initializing the datasource
+ */
+@Override
+public synchronized void start() throws SQLException {
Review comment:
Ok sounds good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468823)
Remaining Estimate: 10m (was: 20m)
Time Spent: 50m (was: 40m)
> 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
> ---
>
> Key: DBCP-559
> URL: https://issues.apache.org/jira/browse/DBCP-559
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.8.0
>Reporter: Wenzhi Ji
>Priority: Major
> Labels: ready-to-commit
> Fix For: 2.8.0
>
> Attachments: BasicDataSource.java, BasicDataSourceMXBean.java
>
> Original Estimate: 1h
> Time Spent: 50m
> Remaining Estimate: 10m
>
> 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。
> 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed
> = false；以使建立的数据库连接生效。
> 变更的代码见附件。
> 注：附件是基于2.7.0版本代码进行优化的。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-dbcp] garydgregory commented on a change in pull request #50: Add start, restart methods to BasicDataSource. JIRA: DBCP-559.
garydgregory commented on a change in pull request #50:
URL: https://github.com/apache/commons-dbcp/pull/50#discussion_r468123812
##
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##
@@ -433,6 +433,55 @@ public synchronized void close() throws SQLException {
}
}
+/**
+ * Starts the datasource.
+ *
+ * It is not necessary to call this method before using a newly created
BasicDataSource instance, but
+ * calling it in that context causes the datasource to be immediately
initialized (instead of waiting for
+ * the first {@link #getConnection()} request). Its primary use is to
restart and reinitialize a
+ * datasource that has been closed.
+ *
+ * When this method is called after {@link #close()}, connections checked
out by clients
+ * before the datasource was stopped do not count in {@link
#getMaxTotal()} or {@link #getNumActive()}.
+ * For example, if there are 3 connections checked out by clients when
{@link #close()} is invoked and they are
+ * not returned before {@link #start()} is invoked, after this method is
called, {@link #getNumActive()} will
+ * return 0. These connections will be physically closed when they are
returned, but they will not count against
+ * the maximum allowed in the newly started datasource.
+ *
+ * @throws SQLException if an error occurs initializing the datasource
+ */
+@Override
+public synchronized void start() throws SQLException {
Review comment:
Ok sounds good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[
https://issues.apache.org/jira/browse/DBCP-559?focusedWorklogId=468809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468809
]
ASF GitHub Bot logged work on DBCP-559:
---
Author: ASF GitHub Bot
Created on: 10/Aug/20 19:06
Start Date: 10/Aug/20 19:06
Worklog Time Spent: 10m
Work Description: psteitz commented on a change in pull request #50:
URL: https://github.com/apache/commons-dbcp/pull/50#discussion_r468116835
##
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##
@@ -433,6 +433,55 @@ public synchronized void close() throws SQLException {
}
}
+/**
+ * Starts the datasource.
+ *
+ * It is not necessary to call this method before using a newly created
BasicDataSource instance, but
+ * calling it in that context causes the datasource to be immediately
initialized (instead of waiting for
+ * the first {@link #getConnection()} request). Its primary use is to
restart and reinitialize a
+ * datasource that has been closed.
+ *
+ * When this method is called after {@link #close()}, connections checked
out by clients
+ * before the datasource was stopped do not count in {@link
#getMaxTotal()} or {@link #getNumActive()}.
+ * For example, if there are 3 connections checked out by clients when
{@link #close()} is invoked and they are
+ * not returned before {@link #start()} is invoked, after this method is
called, {@link #getNumActive()} will
+ * return 0. These connections will be physically closed when they are
returned, but they will not count against
+ * the maximum allowed in the newly started datasource.
+ *
+ * @throws SQLException if an error occurs initializing the datasource
+ */
+@Override
+public synchronized void start() throws SQLException {
Review comment:
I don't think want to expose the internal datasource directly. The call
to createDatasource is just to get initialization to happen. It's better for
clients to use BDS itself, I think.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468809)
Remaining Estimate: 0.5h (was: 40m)
Time Spent: 0.5h (was: 20m)
> 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
> ---
>
> Key: DBCP-559
> URL: https://issues.apache.org/jira/browse/DBCP-559
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.8.0
>Reporter: Wenzhi Ji
>Priority: Major
> Labels: ready-to-commit
> Fix For: 2.8.0
>
> Attachments: BasicDataSource.java, BasicDataSourceMXBean.java
>
> Original Estimate: 1h
> Time Spent: 0.5h
> Remaining Estimate: 0.5h
>
> 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。
> 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed
> = false；以使建立的数据库连接生效。
> 变更的代码见附件。
> 注：附件是基于2.7.0版本代码进行优化的。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-dbcp] psteitz commented on a change in pull request #50: Add start, restart methods to BasicDataSource. JIRA: DBCP-559.
psteitz commented on a change in pull request #50:
URL: https://github.com/apache/commons-dbcp/pull/50#discussion_r468116835
##
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##
@@ -433,6 +433,55 @@ public synchronized void close() throws SQLException {
}
}
+/**
+ * Starts the datasource.
+ *
+ * It is not necessary to call this method before using a newly created
BasicDataSource instance, but
+ * calling it in that context causes the datasource to be immediately
initialized (instead of waiting for
+ * the first {@link #getConnection()} request). Its primary use is to
restart and reinitialize a
+ * datasource that has been closed.
+ *
+ * When this method is called after {@link #close()}, connections checked
out by clients
+ * before the datasource was stopped do not count in {@link
#getMaxTotal()} or {@link #getNumActive()}.
+ * For example, if there are 3 connections checked out by clients when
{@link #close()} is invoked and they are
+ * not returned before {@link #start()} is invoked, after this method is
called, {@link #getNumActive()} will
+ * return 0. These connections will be physically closed when they are
returned, but they will not count against
+ * the maximum allowed in the newly started datasource.
+ *
+ * @throws SQLException if an error occurs initializing the datasource
+ */
+@Override
+public synchronized void start() throws SQLException {
Review comment:
I don't think want to expose the internal datasource directly. The call
to createDatasource is just to get initialization to happen. It's better for
clients to use BDS itself, I think.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (IO-601) requesting 2.6 tag for Commons IO's release version 2.6
[ https://issues.apache.org/jira/browse/IO-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174985#comment-17174985 ] Gary D. Gregory commented on IO-601: Except that the tag is wrong as release tags should be prefixed with "rel/". > requesting 2.6 tag for Commons IO's release version 2.6 > --- > > Key: IO-601 > URL: https://issues.apache.org/jira/browse/IO-601 > Project: Commons IO > Issue Type: Task > Components: Utilities >Affects Versions: 2.6 >Reporter: Jianfeng Tai >Priority: Major > > Hi, For release 2.6, I can see only RC builds are there, Could you please > create tag for official 2.6 release. Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-676) Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.
[ https://issues.apache.org/jira/browse/IO-676?focusedWorklogId=468772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468772 ] ASF GitHub Bot logged work on IO-676: - Author: ASF GitHub Bot Created on: 10/Aug/20 18:03 Start Date: 10/Aug/20 18:03 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #124: URL: https://github.com/apache/commons-io/pull/124#issuecomment-671503184 @Isira-Seneviratne Would you please rebase on master, this should cause all CI builds to run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468772) Time Spent: 5h 10m (was: 5h) > Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time > API. > -- > > Key: IO-676 > URL: https://issues.apache.org/jira/browse/IO-676 > Project: Commons IO > Issue Type: Improvement > Components: Utilities >Reporter: Isira Seneviratne >Priority: Major > Fix For: 2.8 > > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on pull request #124: [IO-676] Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time API.
garydgregory commented on pull request #124: URL: https://github.com/apache/commons-io/pull/124#issuecomment-671503184 @Isira-Seneviratne Would you please rebase on master, this should cause all CI builds to run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #140: Bump actions/checkout from v2.3.1 to v2.3.2
coveralls commented on pull request #140: URL: https://github.com/apache/commons-io/pull/140#issuecomment-671466126 [](https://coveralls.io/builds/32653572) Coverage decreased (-0.05%) to 89.881% when pulling **17f31c0cde2b4e643fc4e435b781063338b03359 on dependabot/github_actions/actions/checkout-v2.3.2** into **73db978a625662181fddfb6eabb562d979dfd02d on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #33: Bump biz.aQute.bndlib from 5.1.0 to 5.1.2
coveralls commented on pull request #33: URL: https://github.com/apache/commons-fileupload/pull/33#issuecomment-671463578 [](https://coveralls.io/builds/32653163) Coverage remained the same at 78.357% when pulling **c6beb031b5d52a8bcd2cc698a21ac18cc45a33ed on dependabot/maven/biz.aQute.bnd-biz.aQute.bndlib-5.1.2** into **f079fafcda8cb53cc0ebfbd94798604cb4752913 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #109: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #109: URL: https://github.com/apache/commons-vfs/pull/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] garydgregory merged pull request #4: Bump velocity-engine-core from 2.1 to 2.2
garydgregory merged pull request #4: URL: https://github.com/apache/commons-release-plugin/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] garydgregory merged pull request #38: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #38: URL: https://github.com/apache/commons-validator/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] garydgregory commented on pull request #4: Bump velocity-engine-core from 2.1 to 2.2
garydgregory commented on pull request #4: URL: https://github.com/apache/commons-release-plugin/pull/4#issuecomment-671459180 @dependabot rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] garydgregory merged pull request #8: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #8: URL: https://github.com/apache/commons-release-plugin/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] garydgregory merged pull request #39: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #39: URL: https://github.com/apache/commons-pool/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory merged pull request #56: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #56: URL: https://github.com/apache/commons-net/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #35: Bump maven-pmd-plugin from 3.12.0 to 3.13.0
coveralls commented on pull request #35: URL: https://github.com/apache/commons-fileupload/pull/35#issuecomment-671456116 [](https://coveralls.io/builds/32653084) Coverage remained the same at 78.357% when pulling **366a30ca239fd74d033ce9e90c6e4433d39ea2d1 on dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.13.0** into **f079fafcda8cb53cc0ebfbd94798604cb4752913 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-586) FileUtils.copyFile fails with java.io.IOException: No such device
[
https://issues.apache.org/jira/browse/IO-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved IO-586.
-
Resolution: Information Provided
The code no longer uses FileChannel.transferFrom.
It uses java.nio.file.Files.copy instead since version 2.7
If the problem persists in 2.7 please raise another issue.
> FileUtils.copyFile fails with java.io.IOException: No such device
> -
>
> Key: IO-586
> URL: https://issues.apache.org/jira/browse/IO-586
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.6
>Reporter: Andy
>Priority: Major
>
> When trying to copy file on CEPH filesystem, FileUtils.copyFile fails with
> exception. I don't see any workaround except of replacing that call and
> rebuilding the project.
> *Test Case*:
> Here's a simple class to reproduce the issue:
>
>
> {code:java}
> import org.apache.commons.io.FileUtils;
> import java.io.File;
> import java.io.IOException;
> import java.io.PrintWriter;
> import java.nio.file.Files;
> public class Test3 {
> public static void main(String[] args) throws IOException {
> PrintWriter writer = new PrintWriter("file.txt", "UTF-8");
> writer.println("test input " + Math.random());
> writer.close();
> FileUtils.copyFile(new File("file.txt"), new File("file-copy.txt"));
> }
> }
> {code}
> below is the stacktrace:
> {code:java}
> Exception in thread "main" java.io.IOException: No such device at
> sun.nio.ch.FileChannelImpl.map0(Native Method) at
> sun.nio.ch.FileChannelImpl.map(FileChannelImpl.java:926) at
> sun.nio.ch.FileChannelImpl.transferFromFileChannel(FileChannelImpl.java:634)
> at sun.nio.ch.FileChannelImpl.transferFrom(FileChannelImpl.java:708) at
> org.apache.commons.io.FileUtils.doCopyFile(FileUtils.java:1131) at
> org.apache.commons.io.FileUtils.copyFile(FileUtils.java:1076) at
> org.apache.commons.io.FileUtils.copyFile(FileUtils.java:1028) at
> ztst.Test3.main(Test3.java:17)
> {code}
> Here's our server's file system configuration:
> {code:java}
> 1. a squashfs (read only) image stored on a ceph's rbd
> 2. a directory on cephfs (read/write)
> 1 is the lower layer and 2 is the upper layer of an unionfs mount with the
> following options:
> cow
> max_files=32768
> allow_other
> use_ino
> direct_io
> statfs_omit_ro
> nonempty
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (IO-607) Update from Java 7 to Java 8
[ https://issues.apache.org/jira/browse/IO-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-607. - Resolution: Fixed The change has happened > Update from Java 7 to Java 8 > > > Key: IO-607 > URL: https://issues.apache.org/jira/browse/IO-607 > Project: Commons IO > Issue Type: New Feature >Reporter: Gary D. Gregory >Priority: Major > > Update from Java 7 to Java 8. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #601: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #601: URL: https://github.com/apache/commons-lang/pull/601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #600: Bump junit-pioneer from 0.8.0 to 0.9.0
garydgregory merged pull request #600: URL: https://github.com/apache/commons-lang/pull/600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] garydgregory merged pull request #31: Bump junit-jupiter from 5.5.2 to 5.6.2
garydgregory merged pull request #31: URL: https://github.com/apache/commons-fileupload/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #138: Bump junit-pioneer from 0.8.0 to 0.9.0
garydgregory merged pull request #138: URL: https://github.com/apache/commons-io/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #140: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory commented on pull request #140: URL: https://github.com/apache/commons-io/pull/140#issuecomment-671438959 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on pull request #31: Bump junit-jupiter from 5.5.2 to 5.6.2
garydgregory commented on pull request #31: URL: https://github.com/apache/commons-fileupload/pull/31#issuecomment-671436675 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on pull request #35: Bump maven-pmd-plugin from 3.12.0 to 3.13.0
garydgregory commented on pull request #35: URL: https://github.com/apache/commons-fileupload/pull/35#issuecomment-671436368 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on pull request #33: Bump biz.aQute.bndlib from 5.1.0 to 5.1.2
garydgregory commented on pull request #33: URL: https://github.com/apache/commons-fileupload/pull/33#issuecomment-671436529 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory merged pull request #17: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #17: URL: https://github.com/apache/commons-exec/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] garydgregory merged pull request #25: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #25: URL: https://github.com/apache/commons-email/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] garydgregory merged pull request #23: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #23: URL: https://github.com/apache/commons-dbutils/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on a change in pull request #50: Add start, restart methods to BasicDataSource. JIRA: DBCP-559.
garydgregory commented on a change in pull request #50:
URL: https://github.com/apache/commons-dbcp/pull/50#discussion_r467998603
##
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##
@@ -433,6 +433,55 @@ public synchronized void close() throws SQLException {
}
}
+/**
+ * Starts the datasource.
+ *
+ * It is not necessary to call this method before using a newly created
BasicDataSource instance, but
+ * calling it in that context causes the datasource to be immediately
initialized (instead of waiting for
+ * the first {@link #getConnection()} request). Its primary use is to
restart and reinitialize a
+ * datasource that has been closed.
+ *
+ * When this method is called after {@link #close()}, connections checked
out by clients
+ * before the datasource was stopped do not count in {@link
#getMaxTotal()} or {@link #getNumActive()}.
+ * For example, if there are 3 connections checked out by clients when
{@link #close()} is invoked and they are
+ * not returned before {@link #start()} is invoked, after this method is
called, {@link #getNumActive()} will
+ * return 0. These connections will be physically closed when they are
returned, but they will not count against
+ * the maximum allowed in the newly started datasource.
+ *
+ * @throws SQLException if an error occurs initializing the datasource
+ */
+@Override
+public synchronized void start() throws SQLException {
Review comment:
Since `createDataSource()` returns a `DataSource`, it would seem proper
for this method to return it as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (DBCP-559) 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
[
https://issues.apache.org/jira/browse/DBCP-559?focusedWorklogId=468706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468706
]
ASF GitHub Bot logged work on DBCP-559:
---
Author: ASF GitHub Bot
Created on: 10/Aug/20 15:42
Start Date: 10/Aug/20 15:42
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #50:
URL: https://github.com/apache/commons-dbcp/pull/50#discussion_r467998603
##
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##
@@ -433,6 +433,55 @@ public synchronized void close() throws SQLException {
}
}
+/**
+ * Starts the datasource.
+ *
+ * It is not necessary to call this method before using a newly created
BasicDataSource instance, but
+ * calling it in that context causes the datasource to be immediately
initialized (instead of waiting for
+ * the first {@link #getConnection()} request). Its primary use is to
restart and reinitialize a
+ * datasource that has been closed.
+ *
+ * When this method is called after {@link #close()}, connections checked
out by clients
+ * before the datasource was stopped do not count in {@link
#getMaxTotal()} or {@link #getNumActive()}.
+ * For example, if there are 3 connections checked out by clients when
{@link #close()} is invoked and they are
+ * not returned before {@link #start()} is invoked, after this method is
called, {@link #getNumActive()} will
+ * return 0. These connections will be physically closed when they are
returned, but they will not count against
+ * the maximum allowed in the newly started datasource.
+ *
+ * @throws SQLException if an error occurs initializing the datasource
+ */
+@Override
+public synchronized void start() throws SQLException {
Review comment:
Since `createDataSource()` returns a `DataSource`, it would seem proper
for this method to return it as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 468706)
Remaining Estimate: 40m (was: 50m)
Time Spent: 20m (was: 10m)
> 数据库连接可以通过BasicDataSource类的close()方法进行关闭，但该类没有提供open()方法使得新建的数据库连接生效
> ---
>
> Key: DBCP-559
> URL: https://issues.apache.org/jira/browse/DBCP-559
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.8.0
>Reporter: Wenzhi Ji
>Priority: Major
> Labels: ready-to-commit
> Fix For: 2.8.0
>
> Attachments: BasicDataSource.java, BasicDataSourceMXBean.java
>
> Original Estimate: 1h
> Time Spent: 20m
> Remaining Estimate: 40m
>
> 当前该开源软件具备的功能：若数据库连接被关闭（即closed置为true），则必须重启服务，才能使新的数据库连接生效（closed置为false）。
> 针对容灾场景，若数据库连接串发生变化，为了使新的数据库连接动态生效（热生效），不需要手工重启服务，建议该开源软件BasicDataSource类提供一个open()方法用于置closed
> = false；以使建立的数据库连接生效。
> 变更的代码见附件。
> 注：附件是基于2.7.0版本代码进行优化的。
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-dbcp] garydgregory merged pull request #51: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #51: URL: https://github.com/apache/commons-dbcp/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #92: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #92: URL: https://github.com/apache/commons-csv/pull/92 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] garydgregory merged pull request #60: Bump jackson-databind from 2.11.1 to 2.11.2
garydgregory merged pull request #60: URL: https://github.com/apache/commons-configuration/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] garydgregory merged pull request #61: Bump commons-pool2 from 2.8.0 to 2.8.1
garydgregory merged pull request #61: URL: https://github.com/apache/commons-configuration/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-609) FileUtils.copyToFile backward incompatibility bug
[
https://issues.apache.org/jira/browse/IO-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174388#comment-17174388
]
Sebb commented on IO-609:
-
Sorry, but the sample test case requires far too much work to get it to run on
anyone's system apart from your own.
It also includes lots of code which is not relevant to the bug report.
Also the line which throws the IOError is not identified.
Please provide the simplest possible test case that shows the issue, along with
any test data that is needed (e.g. test.zip in this case)
> FileUtils.copyToFile backward incompatibility bug
> -
>
> Key: IO-609
> URL: https://issues.apache.org/jira/browse/IO-609
> Project: Commons IO
> Issue Type: Bug
>Affects Versions: 2.6
>Reporter: xia0c
>Priority: Major
>
> Hi,
> The following code snippets throw an IOException: Stream closed. It works
> well before commons-io 2.6. When I update commons-io to 2.6, it failed. There
> is a backward incompatibility bug behind it.
> The function code:
> {code:java}
> public class Demo {
> private void backupFile(String srcPath, String entryPath,
> ZipOutputStream stream) throws IOException {
> ZipEntry zipEntry = new ZipEntry(entryPath);
> stream.putNextEntry(zipEntry);
> Files.copy(Paths.get(srcPath), stream);
> }
> private void backupDir(String srcDir, String dstDir, ZipOutputStream
> stream) throws IOException {
> File dir = new File(srcDir);
> for (String path : dir.list()) {
> System.out.println(path);
> backupFile(dir.getAbsolutePath() + File.separator + path,
> dstDir + File.separator + path, stream);
> }
> }
> public void backup(String name) throws IOException {
>
> Files.createDirectories(Paths.get("/Users/chenlingchao/eclipse_projects/workspace/BBI.BugDetection"));
> ZipOutputStream stream = new ZipOutputStream(
>
> Files.newOutputStream(Paths.get("/Users/chenlingchao/eclipse_projects/workspace/BBI.BugDetection/tmp"
> + File.separator + name)));
> try {
>
> backupDir("/Users/chenlingchao/eclipse_projects/workspace/BBI.BugDetection/tmp",
> "meta" + File.separator + "tables", stream);
> stream.closeEntry();
> } finally {
> stream.close();
> }
> }
>
> public void restore(String name) throws IOException {
> ZipInputStream stream = new ZipInputStream(
>
> Files.newInputStream(Paths.get("/Users/chenlingchao/eclipse_projects/workspace/BBI.BugDetection/tmp"
> + File.separator + name)));
> try {
> ZipEntry entry;
> while ((entry = stream.getNextEntry()) != null) {
> FileUtils.copyToFile(stream, new
> File("/Users/chenlingchao/eclipse_projects/workspace/BBI.BugDetection/tmp" +
> File.separator + entry.getName()));
> }
> } finally {
> stream.close();
> }
> }
> }
> {code}
> The test code:
> {code:java}
> @Test
> public void TestDemo() throws IOException{
> Demo test = new Demo();
> test.backup("test.zip");
> test.restore("test.zip");
> }
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-configuration] garydgregory merged pull request #62: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #62: URL: https://github.com/apache/commons-configuration/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] garydgregory merged pull request #124: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #124: URL: https://github.com/apache/commons-compress/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] garydgregory merged pull request #56: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #56: URL: https://github.com/apache/commons-codec/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #46: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #46: URL: https://github.com/apache/commons-cli/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] garydgregory merged pull request #9: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #9: URL: https://github.com/apache/commons-build-plugin/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] garydgregory merged pull request #33: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #33: URL: https://github.com/apache/commons-beanutils/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #59: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #59: URL: https://github.com/apache/commons-bcel/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (IO-622) FileUtils.readLines incompatible issue
[
https://issues.apache.org/jira/browse/IO-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb closed IO-622.
---
> FileUtils.readLines incompatible issue
> --
>
> Key: IO-622
> URL: https://issues.apache.org/jira/browse/IO-622
> Project: Commons IO
> Issue Type: Bug
>Affects Versions: 2.3, 2.4, 2.5, 2.6
>Reporter: xia0c
>Priority: Major
> Labels: performance
>
> Hi,
> The following code snippets throw an incompatible issue when I try to rolling
> update Commons IO to 2.6. It works well before 2.3.
> {code:java}
> @Test
> public void DemoTest(){
> List l = new ArrayList();
> File TestFile = new File("TestFile");
> try {
> l.addAll(org.apache.commons.io.FileUtils.readLines(TestFile, null));
> } catch (IOException e) {
> e.printStackTrace();
> }
> }
> {code}
> Thanks a lot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] garydgregory commented on pull request #58: BCEL-341: Oak class file patch
garydgregory commented on pull request #58: URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-671412245 -1 for now: - Fails the build due to a checkstyle error: https://travis-ci.org/github/apache/commons-bcel/jobs/716255992 - No unit tests. One or more unit tests should fail without the patch to the main folder. - The implementation feels at first glance like a class file version specific brute force hack using conditionals and booleans, as opposed to a more object oriented solution. Needs more study on my side as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-622) FileUtils.readLines incompatible issue
[
https://issues.apache.org/jira/browse/IO-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved IO-622.
-
Resolution: Information Provided
There used to be just one readLines method with two parameters:
FileUtils.readLines(File, String encoding)
There are now two such methods:
FileUtils.readLines(File, String)
FileUtils.readLines(File, Charset)
The compiler can no longer determine whether the null parameter is a String, or
a Charset.
You will have to change the source and recompile.
e.g.
FileUtils.readLines(TestFile, (String) null);
Note that the additional method does not affect binary compatibility.
[The compiled code includes the method signature, so the JVM can find the
correct method to call.]
> FileUtils.readLines incompatible issue
> --
>
> Key: IO-622
> URL: https://issues.apache.org/jira/browse/IO-622
> Project: Commons IO
> Issue Type: Bug
>Affects Versions: 2.3, 2.4, 2.5, 2.6
>Reporter: xia0c
>Priority: Major
> Labels: performance
>
> Hi,
> The following code snippets throw an incompatible issue when I try to rolling
> update Commons IO to 2.6. It works well before 2.3.
> {code:java}
> @Test
> public void DemoTest(){
> List l = new ArrayList();
> File TestFile = new File("TestFile");
> try {
> l.addAll(org.apache.commons.io.FileUtils.readLines(TestFile, null));
> } catch (IOException e) {
> e.printStackTrace();
> }
> }
> {code}
> Thanks a lot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [GitHub] [commons-collections] kinow commented on pull request #173: Bump actions/checkout from v2.3.1 to v2.3.2
HI All and Alex: This Collections commit *bbee9fbd9b7d4a392ea2a43e8413065195d1823a *[1] should have been -1 since it uses a Java 9 API which is now detected by our build: https://github.com/apache/commons-collections/runs/966117890?check_suite_focus=true Alex: Would mind updating the test to Java 8? Thank you, Gary [1] commit bbee9fbd9b7d4a392ea2a43e8413065195d1823a Author: Alex Herbert 2020-03-18 06:49:15 Committer: Alex Herbert 2020-03-18 06:49:15 Parent: 0feeab0820ff7d01681dab897a0d428eca3de3df (Change Hasher.getBits() to iterator()) Child: 514c2eddfcfe99f114b14e5db510af9f6daead51 (add a testcase for DynamicHasher.NoValuesIterator.nextInt()) Branches: master, origin/dependabot/maven/com.puppycrawl.tools-checkstyle-8.34, origin/dependabot/maven/org.apache.commons-commons-parent-51, origin/dependabot/maven/org.apache.commons-commons-parent-52, origin/dependabot/maven/org.apache.maven.plugins-maven-antrun-plugin-3.0.0, origin/dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.13.0, origin/HEAD, origin/master On Mon, Aug 10, 2020 at 5:49 AM GitBox wrote: > > kinow commented on pull request #173: > URL: > https://github.com/apache/commons-collections/pull/173#issuecomment-671261706 > > >Failures here don't appear related to this change. Looks like the build > is already broken on `master` > > > > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > >
[jira] [Resolved] (IO-668) Does commons-io-2.4 support for Java 11? If not, any timeline or recommendation?
[ https://issues.apache.org/jira/browse/IO-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-668. - Resolution: Information Provided > Does commons-io-2.4 support for Java 11? If not, any timeline or > recommendation? > > > Key: IO-668 > URL: https://issues.apache.org/jira/browse/IO-668 > Project: Commons IO > Issue Type: Wish >Affects Versions: 2.4 >Reporter: Xinmin Zhou >Priority: Major > > Hi Expert, > I would appreciate if you could share your knowledge related with me? Thanks. > Regards, > Xinmin -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (IO-668) Does commons-io-2.4 support for Java 11? If not, any timeline or recommendation?
[ https://issues.apache.org/jira/browse/IO-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb closed IO-668. --- > Does commons-io-2.4 support for Java 11? If not, any timeline or > recommendation? > > > Key: IO-668 > URL: https://issues.apache.org/jira/browse/IO-668 > Project: Commons IO > Issue Type: Wish >Affects Versions: 2.4 >Reporter: Xinmin Zhou >Priority: Major > > Hi Expert, > I would appreciate if you could share your knowledge related with me? Thanks. > Regards, > Xinmin -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (IO-657) Update to Jacoco v0.8.5
[ https://issues.apache.org/jira/browse/IO-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb closed IO-657. --- > Update to Jacoco v0.8.5 > --- > > Key: IO-657 > URL: https://issues.apache.org/jira/browse/IO-657 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Fix For: 2.8 > > Time Spent: 0.5h > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. > Step 4, update maven-dependencies to latest for compiler, jar, install -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (IO-658) Upgrade to JUnit Pioneer v0.5.4
[ https://issues.apache.org/jira/browse/IO-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb closed IO-658. --- > Upgrade to JUnit Pioneer v0.5.4 > --- > > Key: IO-658 > URL: https://issues.apache.org/jira/browse/IO-658 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (IO-658) Upgrade to JUnit Pioneer v0.5.4
[ https://issues.apache.org/jira/browse/IO-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-658. - Resolution: Won't Fix Already at 0.8.0 > Upgrade to JUnit Pioneer v0.5.4 > --- > > Key: IO-658 > URL: https://issues.apache.org/jira/browse/IO-658 > Project: Commons IO > Issue Type: Improvement >Reporter: John Patrick >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and > Lang", and > https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-parent] garydgregory merged pull request #15: Bump actions/checkout from v2.3.1 to v2.3.2
garydgregory merged pull request #15: URL: https://github.com/apache/commons-parent/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=468598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468598 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 10/Aug/20 14:08 Start Date: 10/Aug/20 14:08 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-671376780 @sebbASF > I don't think the RandomStrings test is a fair benchmark. Actually it is fair. see the string array generation function of that test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468598) Time Spent: 6h 20m (was: 6h 10m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 6h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
