[GitHub] [commons-collections] coveralls commented on pull request #217: Add constant variable
coveralls commented on pull request #217: URL: https://github.com/apache/commons-collections/pull/217#issuecomment-786469863 [](https://coveralls.io/builds/37472402) Coverage remained the same at 90.137% when pulling **9d89cf7b5c8db20a7db95c90250cb3e5ac940250 on arturobernalg:feature/constant** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] arturobernalg opened a new pull request #217: Add constant variable
arturobernalg opened a new pull request #217: URL: https://github.com/apache/commons-collections/pull/217 The idea it's reuse the constant variable in all the applications. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.
coveralls edited a comment on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632 [](https://coveralls.io/builds/37471381) Coverage decreased (-0.03%) to 90.11% when pulling **372e8129e103ebf2800d5396517f78552c2a349a on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.
coveralls edited a comment on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632 [](https://coveralls.io/builds/37470919) Coverage increased (+0.003%) to 90.139% when pulling **372e8129e103ebf2800d5396517f78552c2a349a on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.
coveralls edited a comment on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632 [](https://coveralls.io/builds/37470731) Coverage decreased (-0.03%) to 90.11% when pulling **d02da08028963e8fb19d9135533b2437f063ce77 on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.
coveralls edited a comment on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632 [](https://coveralls.io/builds/37470719) Coverage increased (+0.003%) to 90.139% when pulling **d02da08028963e8fb19d9135533b2437f063ce77 on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls commented on pull request #216: Checks if any value in the given Collections is null or empty.
coveralls commented on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632 [](https://coveralls.io/builds/37470677) Coverage decreased (-0.03%) to 90.11% when pulling **d02da08028963e8fb19d9135533b2437f063ce77 on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] arturobernalg opened a new pull request #216: Checks if any value in the given Collections is null or empty.
arturobernalg opened a new pull request #216: URL: https://github.com/apache/commons-collections/pull/216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (COMPRESS-568) NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
[
https://issues.apache.org/jira/browse/COMPRESS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Lee resolved COMPRESS-568.
Fix Version/s: 1.21
Resolution: Fixed
> NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
>
>
> Key: COMPRESS-568
> URL: https://issues.apache.org/jira/browse/COMPRESS-568
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Fix For: 1.21
>
> Attachments: npe.zip
>
>
> The following snippet of code throws an undeclared NullPointerException:
> {code:java}
> byte[] bytes =
> base64.getDecoder().decode("UEsDBAoACQAAAGu0ukYdiHewEwcDABwAYWFhVVQDAAn5ygAAUEsFBgAC/0IABQAAUEsBAh4DCgAJAP8ABbS6RgAAIAAHAAABAABQSwUGAP///wU=");
>
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try { ZipFile file = new ZipFile(input); } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.commons.compress.archivers.zip.ZipLong.getBytes()" because
> "this.modifyTime" is null
> at
> org.apache.commons.compress.archivers.zip.X5455_ExtendedTimestamp.getLocalFileDataData(X5455_ExtendedTimestamp.java:180)
> at
> org.apache.commons.compress.archivers.zip.ExtraFieldUtils.mergeLocalFileDataData(ExtraFieldUtils.java:250)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:691)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.addExtraField(ZipArchiveEntry.java:573)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.mergeExtraFields(ZipArchiveEntry.java:903)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:676)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.resolveLocalFileHeaderData(ZipFile.java:1237)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:373)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-568) NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
[
https://issues.apache.org/jira/browse/COMPRESS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291318#comment-17291318
]
Peter Lee commented on COMPRESS-568:
That's fine. Thank you for reporting this. :)
> NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
>
>
> Key: COMPRESS-568
> URL: https://issues.apache.org/jira/browse/COMPRESS-568
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Attachments: npe.zip
>
>
> The following snippet of code throws an undeclared NullPointerException:
> {code:java}
> byte[] bytes =
> base64.getDecoder().decode("UEsDBAoACQAAAGu0ukYdiHewEwcDABwAYWFhVVQDAAn5ygAAUEsFBgAC/0IABQAAUEsBAh4DCgAJAP8ABbS6RgAAIAAHAAABAABQSwUGAP///wU=");
>
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try { ZipFile file = new ZipFile(input); } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.commons.compress.archivers.zip.ZipLong.getBytes()" because
> "this.modifyTime" is null
> at
> org.apache.commons.compress.archivers.zip.X5455_ExtendedTimestamp.getLocalFileDataData(X5455_ExtendedTimestamp.java:180)
> at
> org.apache.commons.compress.archivers.zip.ExtraFieldUtils.mergeLocalFileDataData(ExtraFieldUtils.java:250)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:691)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.addExtraField(ZipArchiveEntry.java:573)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.mergeExtraFields(ZipArchiveEntry.java:903)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:676)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.resolveLocalFileHeaderData(ZipFile.java:1237)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:373)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CLI-287) HelpFormatter doesn't display header consisting of only whitespaces
[ https://issues.apache.org/jira/browse/CLI-287?focusedWorklogId=558282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558282 ] ASF GitHub Bot logged work on CLI-287: -- Author: ASF GitHub Bot Created on: 25/Feb/21 23:12 Start Date: 25/Feb/21 23:12 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #26: URL: https://github.com/apache/commons-cli/pull/26#issuecomment-786294423 [](https://coveralls.io/builds/37463276) Coverage remained the same at 96.358% when pulling **0faa49c00d3ce29076e0d62da59928f472edc471 on MrQubo:CLI-287** into **66cc7b4cb8b0f39edfe0ee37eead4ace04a7be4e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 558282) Time Spent: 0.5h (was: 20m) > HelpFormatter doesn't display header consisting of only whitespaces > --- > > Key: CLI-287 > URL: https://issues.apache.org/jira/browse/CLI-287 > Project: Commons CLI > Issue Type: Bug > Components: Help formatter >Affects Versions: 1.0, 1.4 >Reporter: Jakub Nowak >Priority: Trivial > Labels: easyfix > Time Spent: 0.5h > Remaining Estimate: 0h > > If header or footer passed to HelpFormatter::printHelp consists of only > whitespaces it is not displayed. > It prevents users from adding additional newlines. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-cli] coveralls commented on pull request #26: [CLI-287] Allow whitespace-only header and footer
coveralls commented on pull request #26: URL: https://github.com/apache/commons-cli/pull/26#issuecomment-786294423 [](https://coveralls.io/builds/37463276) Coverage remained the same at 96.358% when pulling **0faa49c00d3ce29076e0d62da59928f472edc471 on MrQubo:CLI-287** into **66cc7b4cb8b0f39edfe0ee37eead4ace04a7be4e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CLI-287) HelpFormatter doesn't display header consisting of only whitespaces
[ https://issues.apache.org/jira/browse/CLI-287?focusedWorklogId=558275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558275 ] ASF GitHub Bot logged work on CLI-287: -- Author: ASF GitHub Bot Created on: 25/Feb/21 23:01 Start Date: 25/Feb/21 23:01 Worklog Time Spent: 10m Work Description: enedil commented on pull request #26: URL: https://github.com/apache/commons-cli/pull/26#issuecomment-786285411 > Seems reasonable. What do others think? I also think it seems reasonable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 558275) Time Spent: 20m (was: 10m) > HelpFormatter doesn't display header consisting of only whitespaces > --- > > Key: CLI-287 > URL: https://issues.apache.org/jira/browse/CLI-287 > Project: Commons CLI > Issue Type: Bug > Components: Help formatter >Affects Versions: 1.0, 1.4 >Reporter: Jakub Nowak >Priority: Trivial > Labels: easyfix > Time Spent: 20m > Remaining Estimate: 0h > > If header or footer passed to HelpFormatter::printHelp consists of only > whitespaces it is not displayed. > It prevents users from adding additional newlines. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-cli] enedil commented on pull request #26: [CLI-287] Allow whitespace-only header and footer
enedil commented on pull request #26: URL: https://github.com/apache/commons-cli/pull/26#issuecomment-786285411 > Seems reasonable. What do others think? I also think it seems reasonable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #720: Reuse ObjectUtils.anyNull
coveralls commented on pull request #720: URL: https://github.com/apache/commons-lang/pull/720#issuecomment-786278049 [](https://coveralls.io/builds/37462607) Coverage decreased (-0.006%) to 94.908% when pulling **e67e63f8339d8610b22870e5fa9149f0a9d32e7e on arturobernalg:feature/not_null** into **813b1a5c34d75c7d78e389b2c9e5077dc8c38145 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #719: SimpleStopWatch is alternative for overcomplicated and buggy StopWatch
coveralls commented on pull request #719: URL: https://github.com/apache/commons-lang/pull/719#issuecomment-786276956 [](https://coveralls.io/builds/37462536) Coverage increased (+0.003%) to 94.917% when pulling **1be1f9d632b4188ec25c38a33132bf8052095958 on michaldo:simplestopwatch** into **813b1a5c34d75c7d78e389b2c9e5077dc8c38145 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #720: Reuse ObjectUtils.anyNull
arturobernalg commented on pull request #720:
URL: https://github.com/apache/commons-lang/pull/720#issuecomment-786266444
Reuse ObjectUtils.anyNull when need to instead of check if (obj == null ||
obj == null) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] arturobernalg opened a new pull request #720: Reuse ObjectUtils.anyNull
arturobernalg opened a new pull request #720: URL: https://github.com/apache/commons-lang/pull/720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] michaldo opened a new pull request #719: SimpleStopWatch is alternative for overcomplicated and buggy StopWatch
michaldo opened a new pull request #719: URL: https://github.com/apache/commons-lang/pull/719 In https://github.com/apache/commons-lang/pull/709 I proposed add `lap()` to StopWatch. During discussion I realized that StopWatch is overcomplicated and better is option is no-brainer SimpleStopWatch. With a `lap()`, of course This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DBCP-572) timed out connections remain active in the pool
Erol Guven created DBCP-572:
---
Summary: timed out connections remain active in the pool
Key: DBCP-572
URL: https://issues.apache.org/jira/browse/DBCP-572
Project: Commons DBCP
Issue Type: Bug
Affects Versions: 2.8.0
Reporter: Erol Guven
when the database does not respond within a time-out period, the connection
pool seems to still keep the connection in its pool and consider it active.
These active connections are never closed and seems to be kept in the pool
forever.
To reproduce:
* create a BasicDataSource
* suspend the database process using {{kill -STOP}} signal
* get a connection from multiple threads simultaneously which will timeout
* inspect org.apache.commons.pool2.impl.GenericObjectPool.getNumActive()
The active count is equivalent to the number of timed out connections.
The active count never goes down.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-pool] JSurf opened a new pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool
JSurf opened a new pull request #67: URL: https://github.com/apache/commons-pool/pull/67 Hi, we have added AbandonedConfig for GenericKeyedObjectPool. Would be nice to see this in the next official release This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #718: Use own validator ObjectUtils.anyNull to check null String input
garydgregory merged pull request #718: URL: https://github.com/apache/commons-lang/pull/718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #718: Use own validator ObjectUtils.anyNull to check null String input
garydgregory commented on pull request #718: URL: https://github.com/apache/commons-lang/pull/718#issuecomment-785945275 Eating our own dog food :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #717: Feature/not null or empty aux
garydgregory commented on pull request #717: URL: https://github.com/apache/commons-lang/pull/717#issuecomment-785917849 Closing in favor of a different implementation in git master which mirror the style and names of java.lang.Objects.requireNon*() methods. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #717: Feature/not null or empty aux
garydgregory closed pull request #717: URL: https://github.com/apache/commons-lang/pull/717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #716: Reuse the boolean array validations.
garydgregory closed pull request #716: URL: https://github.com/apache/commons-lang/pull/716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #716: Reuse the boolean array validations.
garydgregory commented on pull request #716: URL: https://github.com/apache/commons-lang/pull/716#issuecomment-785917398 Closing in favor of a different implementation in git master which mirror the style and names of java.lang.Objects.requireNon*() methods. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-568) NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
[
https://issues.apache.org/jira/browse/COMPRESS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290883#comment-17290883
]
Fabian Meumertzheim commented on COMPRESS-568:
--
Sorry, I should have tested with current HEAD as well. I also can't reproduce
this on
https://github.com/apache/commons-compress/commit/1b7528fbd6295a3958daf1b1114621ee5e40e83c
> NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
>
>
> Key: COMPRESS-568
> URL: https://issues.apache.org/jira/browse/COMPRESS-568
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Attachments: npe.zip
>
>
> The following snippet of code throws an undeclared NullPointerException:
> {code:java}
> byte[] bytes =
> base64.getDecoder().decode("UEsDBAoACQAAAGu0ukYdiHewEwcDABwAYWFhVVQDAAn5ygAAUEsFBgAC/0IABQAAUEsBAh4DCgAJAP8ABbS6RgAAIAAHAAABAABQSwUGAP///wU=");
>
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try { ZipFile file = new ZipFile(input); } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.commons.compress.archivers.zip.ZipLong.getBytes()" because
> "this.modifyTime" is null
> at
> org.apache.commons.compress.archivers.zip.X5455_ExtendedTimestamp.getLocalFileDataData(X5455_ExtendedTimestamp.java:180)
> at
> org.apache.commons.compress.archivers.zip.ExtraFieldUtils.mergeLocalFileDataData(ExtraFieldUtils.java:250)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:691)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.addExtraField(ZipArchiveEntry.java:573)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.mergeExtraFields(ZipArchiveEntry.java:903)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:676)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.resolveLocalFileHeaderData(ZipFile.java:1237)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:373)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory
[
https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290882#comment-17290882
]
Fabian Meumertzheim commented on COMPRESS-567:
--
Yes, the ZIP is clearly invalid, but I would expect a (subclass of) IOException
here instead of an IllegalArgumentException.
> IllegalArgumentException in ZipFile.positionAtCentralDirectory
> --
>
> Key: COMPRESS-567
> URL: https://issues.apache.org/jira/browse/COMPRESS-567
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Attachments: crash.zip
>
>
> The following snippet of code throws an undeclared IllegalArgumentException:
> {code:java}
> byte[] bytes = Base64.getDecoder().decode("UEsFBgAAAQD//1AAJP9QAA==");
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try {
> ZipFile file = new ZipFile(input);
> } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.IllegalArgumentException: Position has to be in range 0.. 2147483647
> at
> org.apache.commons.compress.utils.SeekableInMemoryByteChannel.position(SeekableInMemoryByteChannel.java:94)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory32(ZipFile.java:1128)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1037)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:702)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:371)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory
[
https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290875#comment-17290875
]
Peter Lee commented on COMPRESS-567:
The offset of start of CFH is a 4 bytes unsigned value with a maximum of 2^32 -
1 = 4,294,967,295, which may exceeds the allowed range of
SeekableInMemoryByteChannel.
So you are expecting some other exception instead of IllegalArgumentException,
is it?
> IllegalArgumentException in ZipFile.positionAtCentralDirectory
> --
>
> Key: COMPRESS-567
> URL: https://issues.apache.org/jira/browse/COMPRESS-567
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Attachments: crash.zip
>
>
> The following snippet of code throws an undeclared IllegalArgumentException:
> {code:java}
> byte[] bytes = Base64.getDecoder().decode("UEsFBgAAAQD//1AAJP9QAA==");
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try {
> ZipFile file = new ZipFile(input);
> } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.IllegalArgumentException: Position has to be in range 0.. 2147483647
> at
> org.apache.commons.compress.utils.SeekableInMemoryByteChannel.position(SeekableInMemoryByteChannel.java:94)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory32(ZipFile.java:1128)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1037)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:702)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:371)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-568) NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
[
https://issues.apache.org/jira/browse/COMPRESS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290866#comment-17290866
]
Peter Lee commented on COMPRESS-568:
Hi, Fabian.
I have tested this latest Commons Compress code and receive no NPE.
I think this issue has already been fixed.
> NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
>
>
> Key: COMPRESS-568
> URL: https://issues.apache.org/jira/browse/COMPRESS-568
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Attachments: npe.zip
>
>
> The following snippet of code throws an undeclared NullPointerException:
> {code:java}
> byte[] bytes =
> base64.getDecoder().decode("UEsDBAoACQAAAGu0ukYdiHewEwcDABwAYWFhVVQDAAn5ygAAUEsFBgAC/0IABQAAUEsBAh4DCgAJAP8ABbS6RgAAIAAHAAABAABQSwUGAP///wU=");
>
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try { ZipFile file = new ZipFile(input); } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.commons.compress.archivers.zip.ZipLong.getBytes()" because
> "this.modifyTime" is null
> at
> org.apache.commons.compress.archivers.zip.X5455_ExtendedTimestamp.getLocalFileDataData(X5455_ExtendedTimestamp.java:180)
> at
> org.apache.commons.compress.archivers.zip.ExtraFieldUtils.mergeLocalFileDataData(ExtraFieldUtils.java:250)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:691)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.addExtraField(ZipArchiveEntry.java:573)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.mergeExtraFields(ZipArchiveEntry.java:903)
> at
> org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:676)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.resolveLocalFileHeaderData(ZipFile.java:1237)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:373)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] coveralls commented on pull request #172: Remove empty loop in X0017_StrongEncryptionHeader
coveralls commented on pull request #172: URL: https://github.com/apache/commons-compress/pull/172#issuecomment-785825852 [](https://coveralls.io/builds/37443937) Coverage increased (+0.01%) to 87.367% when pulling **fda4e34ff43f3c7a742292d858b60fc3b4bb1663 on fmeum:patch-1** into **1b7528fbd6295a3958daf1b1114621ee5e40e83c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] fmeum opened a new pull request #172: Remove empty loop in X0017_StrongEncryptionHeader
fmeum opened a new pull request #172: URL: https://github.com/apache/commons-compress/pull/172 An empty loop in `X0017_StrongEncryptionHeader#parseCentralDirectoryFormat` can be made to run through 2^48 iterations, taking about 4 seconds on my machine, on crafted input. Since it has no side effects, it can be safely removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMPRESS-568) NullPointerException in X5455_ExtendedTimestamp.getLocalFileDataData
Fabian Meumertzheim created COMPRESS-568:
Summary: NullPointerException in
X5455_ExtendedTimestamp.getLocalFileDataData
Key: COMPRESS-568
URL: https://issues.apache.org/jira/browse/COMPRESS-568
Project: Commons Compress
Issue Type: Bug
Affects Versions: 1.20
Reporter: Fabian Meumertzheim
Attachments: npe.zip
The following snippet of code throws an undeclared NullPointerException:
{code:java}
byte[] bytes =
base64.getDecoder().decode("UEsDBAoACQAAAGu0ukYdiHewEwcDABwAYWFhVVQDAAn5ygAAUEsFBgAC/0IABQAAUEsBAh4DCgAJAP8ABbS6RgAAIAAHAAABAABQSwUGAP///wU=");
SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
try { ZipFile file = new ZipFile(input); } catch (IOException ignored) {}
{code}
The stack trace is:
{noformat}
java.lang.NullPointerException: Cannot invoke
"org.apache.commons.compress.archivers.zip.ZipLong.getBytes()" because
"this.modifyTime" is null
at
org.apache.commons.compress.archivers.zip.X5455_ExtendedTimestamp.getLocalFileDataData(X5455_ExtendedTimestamp.java:180)
at
org.apache.commons.compress.archivers.zip.ExtraFieldUtils.mergeLocalFileDataData(ExtraFieldUtils.java:250)
at
org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:691)
at
org.apache.commons.compress.archivers.zip.ZipArchiveEntry.addExtraField(ZipArchiveEntry.java:573)
at
org.apache.commons.compress.archivers.zip.ZipArchiveEntry.mergeExtraFields(ZipArchiveEntry.java:903)
at
org.apache.commons.compress.archivers.zip.ZipArchiveEntry.setExtra(ZipArchiveEntry.java:676)
at
org.apache.commons.compress.archivers.zip.ZipFile.resolveLocalFileHeaderData(ZipFile.java:1237)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:373)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
{noformat}
I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory
[
https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Meumertzheim updated COMPRESS-567:
-
Description:
The following snippet of code throws an undeclared IllegalArgumentException:
{code:java}
byte[] bytes = Base64.getDecoder().decode("UEsFBgAAAQD//1AAJP9QAA==");
SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
try {
ZipFile file = new ZipFile(input);
} catch (IOException ignored) {}
{code}
The stack trace is:
{noformat}
java.lang.IllegalArgumentException: Position has to be in range 0.. 2147483647
at
org.apache.commons.compress.utils.SeekableInMemoryByteChannel.position(SeekableInMemoryByteChannel.java:94)
at
org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory32(ZipFile.java:1128)
at
org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1037)
at
org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:702)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:371)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
{noformat}
I also attached the input as a ZIP file.
was:
The following snippet of code throws an undeclared IllegalArgumentException:
{code:java}
byte[] bytes = Base64.getDecoder().decode("UEsFBgAAAQD//1AAJP9QAA==");
SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
try {
ZipFile file = new ZipFile(input);
} catch (IOException ignored) {}
{code}
The stack trace is:
{noformat}
java.lang.IllegalArgumentException: Position has to be in range 0.. 2147483647
at
org.apache.commons.compress.utils.SeekableInMemoryByteChannel.position(SeekableInMemoryByteChannel.java:94)
at
org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory32(ZipFile.java:1128)
at
org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1037)
at
org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:702)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:371)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
{noformat}
I also attached the input as a ZIP file.
> IllegalArgumentException in ZipFile.positionAtCentralDirectory
> --
>
> Key: COMPRESS-567
> URL: https://issues.apache.org/jira/browse/COMPRESS-567
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Fabian Meumertzheim
>Priority: Major
> Attachments: crash.zip
>
>
> The following snippet of code throws an undeclared IllegalArgumentException:
> {code:java}
> byte[] bytes = Base64.getDecoder().decode("UEsFBgAAAQD//1AAJP9QAA==");
> SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
> try {
> ZipFile file = new ZipFile(input);
> } catch (IOException ignored) {}
> {code}
> The stack trace is:
> {noformat}
> java.lang.IllegalArgumentException: Position has to be in range 0.. 2147483647
> at
> org.apache.commons.compress.utils.SeekableInMemoryByteChannel.position(SeekableInMemoryByteChannel.java:94)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory32(ZipFile.java:1128)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1037)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:702)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:371)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
> at
> org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
> {noformat}
> I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory
Fabian Meumertzheim created COMPRESS-567:
Summary: IllegalArgumentException in
ZipFile.positionAtCentralDirectory
Key: COMPRESS-567
URL: https://issues.apache.org/jira/browse/COMPRESS-567
Project: Commons Compress
Issue Type: Bug
Affects Versions: 1.20
Reporter: Fabian Meumertzheim
Attachments: crash.zip
The following snippet of code throws an undeclared IllegalArgumentException:
{code:java}
byte[] bytes = Base64.getDecoder().decode("UEsFBgAAAQD//1AAJP9QAA==");
SeekableInMemoryByteChannel input = new SeekableInMemoryByteChannel(bytes);
try {
ZipFile file = new ZipFile(input);
} catch (IOException ignored) {}
{code}
The stack trace is:
{noformat}
java.lang.IllegalArgumentException: Position has to be in range 0.. 2147483647
at
org.apache.commons.compress.utils.SeekableInMemoryByteChannel.position(SeekableInMemoryByteChannel.java:94)
at
org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory32(ZipFile.java:1128)
at
org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1037)
at
org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:702)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:371)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:318)
at
org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:274)
{noformat}
I also attached the input as a ZIP file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
