[jira] [Commented] (IO-721) FileUtils.copyDirectory() tries to set last modified on source dir after update to 2.8.0
[
https://issues.apache.org/jira/browse/IO-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329991#comment-17329991
]
Dirk Heinrichs commented on IO-721:
---
So do I. However, that doesn't change the fact that the script above throws an
exception when using 2.8.0 and option "-t /tmp", but doesn't with "-t /tmp/foo".
> FileUtils.copyDirectory() tries to set last modified on source dir after
> update to 2.8.0
>
>
> Key: IO-721
> URL: https://issues.apache.org/jira/browse/IO-721
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.8.0
> Environment: Ubuntu 20.04 LTS
> Groovy 3.0.x
> Java 11 (from Ubuntu packages)
>Reporter: Dirk Heinrichs
>Priority: Major
>
> A simple
> {code:java}
> FileUtils.copyDirectory(source, dest, glob) {code}
> works fine when using Commons-IO 2.7, but fails with
> {code:java}
> Caught: java.io.IOException: Failed setLastModified on /path/to/source
> java.io.IOException: Failed setLastModified on /path/to/source
> at
> org.apache.commons.io.FileUtils.setLastModified(FileUtils.java:2561)
> at
> org.apache.commons.io.FileUtils.doCopyDirectory(FileUtils.java:1361)
> at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:733)
> at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:659)
> at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:606)
> {code}
> after update to 2.8.0. From reading the documentation, it's also my
> understanding that "setLastModified()" should be executed on "dest" to set
> the same modification time as "source", but *not* on "source".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #66: Bump actions/cache from v2.1.4 to v2.1.5
coveralls commented on pull request #66: URL: https://github.com/apache/commons-fileupload/pull/66#issuecomment-825398128 [](https://coveralls.io/builds/39069237) Coverage remained the same at 78.447% when pulling **1e5b6abfb28c7e3d2a101d1647a9d160eac76217 on dependabot/github_actions/actions/cache-v2.1.5** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] opened a new pull request #39: Bump maven-jxr-plugin from 3.0.0 to 3.1.1
dependabot[bot] opened a new pull request #39: URL: https://github.com/apache/commons-parent/pull/39 Bumps [maven-jxr-plugin](https://github.com/apache/maven-jxr) from 3.0.0 to 3.1.1. Commits https://github.com/apache/maven-jxr/commit/08070062e18b3cf1646147ff961f49f00e69b643";>0807006 [maven-release-plugin] prepare release jxr-3.1.1 https://github.com/apache/maven-jxr/commit/4dae5219cf334cbcda1f727808715b759539c720";>4dae521 [JXR-158] StringEntry shouldn't be Comparable https://github.com/apache/maven-jxr/commit/052d865cd4175042c322f0455fd1a126483b7782";>052d865 [JXR-159] Require Maven 3.1.1+ runtime https://github.com/apache/maven-jxr/commit/f04a98f6ad44f286067e8e6890e710a09046df5b";>f04a98f Test code improvements https://github.com/apache/maven-jxr/commit/38a4bfd46713b1eeb0ece6c1491260f673c1a56c";>38a4bfd Code cleanup, drop dependency to xalan https://github.com/apache/maven-jxr/commit/1596b8189592a135f9a2b8ec2ee23c72cd84796c";>1596b81 Merge pull request https://github-redirect.dependabot.com/apache/maven-jxr/issues/30";>#30 from apache/slf4j https://github.com/apache/maven-jxr/commit/b104da3c0733d52523e53f857cc154e56c347f01";>b104da3 correct XML declaration https://github.com/apache/maven-jxr/commit/98db35f527851db97cc28e86d0baeb0495c2691d";>98db35f make SLF4J dependency explicit https://github.com/apache/maven-jxr/commit/731dd7fe7d46544038b810f846d205f518f1a7a1";>731dd7f tidy up test dependencies https://github.com/apache/maven-jxr/commit/93bbe339fd4a71f8623de0f575a747921642a5eb";>93bbe33 [JXR-153] use locales for string comparison (https://github-redirect.dependabot.com/apache/maven-jxr/issues/28";>#28) Additional commits viewable in https://github.com/apache/maven-jxr/compare/jxr-3.0.0...jxr-3.1.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request #66: Bump actions/cache from v2.1.4 to v2.1.5
dependabot[bot] opened a new pull request #66: URL: https://github.com/apache/commons-fileupload/pull/66 Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5. Release notes Sourced from https://github.com/actions/cache/releases";>actions/cache's releases. v2.1.5 Fix permissions error seen when extracting caches with GNU tar that were previously created using BSD tar (https://github-redirect.dependabot.com/actions/cache/issues/527";>actions/cache#527) Commits https://github.com/actions/cache/commit/1a9e2138d905efd099035b49d8b7a3888c653ca8";>1a9e213 Update cache module to v1.0.7 (https://github-redirect.dependabot.com/actions/cache/issues/562";>#562) https://github.com/actions/cache/commit/981fa981ed950efef5277587ee4ba0eead30cadf";>981fa98 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/469";>#469 from ericmj/patch-1 https://github.com/actions/cache/commit/4498c5b4d8b0673dbc7d9731bc11d9cc5a2c6087";>4498c5b Drop the example based on using pip's internals (https://github-redirect.dependabot.com/actions/cache/issues/519";>#519) https://github.com/actions/cache/commit/4134e6de47156381d31ff74f8aabf86718858f70";>4134e6d It is not recommended to cache node_modules (https://github-redirect.dependabot.com/actions/cache/issues/537";>#537) https://github.com/actions/cache/commit/62a4d754427893bc6d043c6d4f5486490cab29b6";>62a4d75 Also cache _build for Elixir See full diff in https://github.com/actions/cache/compare/v2.1.4...1a9e2138d905efd099035b49d8b7a3888c653ca8";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?focusedWorklogId=587640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587640 ] ASF GitHub Bot logged work on FILEUPLOAD-315: - Author: ASF GitHub Bot Created on: 23/Apr/21 05:18 Start Date: 23/Apr/21 05:18 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #65: URL: https://github.com/apache/commons-fileupload/pull/65#issuecomment-825393013 [](https://coveralls.io/builds/39068943) Coverage decreased (-0.1%) to 78.344% when pulling **f2fa3c4b49493048dbc7b73fe568e6884550fa60 on arturobernalg:feature/FILEUPLOAD-315** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587640) Time Spent: 1h (was: 50m) > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > * Use computeIfAbsent -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?focusedWorklogId=587639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587639 ] ASF GitHub Bot logged work on FILEUPLOAD-312: - Author: ASF GitHub Bot Created on: 23/Apr/21 05:18 Start Date: 23/Apr/21 05:18 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #64: URL: https://github.com/apache/commons-fileupload/pull/64#issuecomment-825392965 [](https://coveralls.io/builds/39068922) Coverage increased (+0.1%) to 78.554% when pulling **149d38d7c1ff0e9f934774c7ad29eba0667d0d8a on arturobernalg:feature/FILEUPLOAD-312** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587639) Time Spent: 1h (was: 50m) > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #65: FILEUPLOAD-315 - java8 improvement:
coveralls commented on pull request #65: URL: https://github.com/apache/commons-fileupload/pull/65#issuecomment-825393013 [](https://coveralls.io/builds/39068943) Coverage decreased (-0.1%) to 78.344% when pulling **f2fa3c4b49493048dbc7b73fe568e6884550fa60 on arturobernalg:feature/FILEUPLOAD-315** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #64: FILEUPLOAD-312 - Use charset constant
coveralls commented on pull request #64: URL: https://github.com/apache/commons-fileupload/pull/64#issuecomment-825392965 [](https://coveralls.io/builds/39068922) Coverage increased (+0.1%) to 78.554% when pulling **149d38d7c1ff0e9f934774c7ad29eba0667d0d8a on arturobernalg:feature/FILEUPLOAD-312** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587637 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 23/Apr/21 05:16 Start Date: 23/Apr/21 05:16 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825121446 [](https://coveralls.io/builds/39068910) Coverage remained the same at 78.447% when pulling **06357585199fe659d9cc4914d04279bb6d5d18ec on arturobernalg:feature/FILEUPLOAD-314** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587637) Time Spent: 1h 10m (was: 1h) > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
coveralls edited a comment on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825121446 [](https://coveralls.io/builds/39068910) Coverage remained the same at 78.447% when pulling **06357585199fe659d9cc4914d04279bb6d5d18ec on arturobernalg:feature/FILEUPLOAD-314** into **289acf537a5d6f3ea5149ff03c10ee33c1d4bded on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?focusedWorklogId=587634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587634 ] ASF GitHub Bot logged work on FILEUPLOAD-315: - Author: ASF GitHub Bot Created on: 23/Apr/21 05:11 Start Date: 23/Apr/21 05:11 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #65: URL: https://github.com/apache/commons-fileupload/pull/65 * Use computeIfAbsent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587634) Time Spent: 50m (was: 40m) > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > * Use computeIfAbsent -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #65: FILEUPLOAD-315 - java8 improvement:
arturobernalg opened a new pull request #65: URL: https://github.com/apache/commons-fileupload/pull/65 * Use computeIfAbsent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated FILEUPLOAD-315: - Description: * Use computeIfAbsent > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > * Use computeIfAbsent -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?focusedWorklogId=587632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587632 ] ASF GitHub Bot logged work on FILEUPLOAD-312: - Author: ASF GitHub Bot Created on: 23/Apr/21 05:03 Start Date: 23/Apr/21 05:03 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #64: URL: https://github.com/apache/commons-fileupload/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587632) Time Spent: 50m (was: 40m) > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #64: FILEUPLOAD-312 - Use charset constant
arturobernalg opened a new pull request #64: URL: https://github.com/apache/commons-fileupload/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587630 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 23/Apr/21 04:58 Start Date: 23/Apr/21 04:58 Worklog Time Spent: 10m Work Description: arturobernalg edited a comment on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825386084 > [](https://coveralls.io/builds/39056969) > > Coverage remained the same at 78.323% when pulling **[15a88fc](https://github.com/apache/commons-fileupload/commit/15a88fc2e33355de746501c997c419ff613b98dc) on arturobernalg:feature/FILEUPLOAD-314** into **[b825323](https://github.com/apache/commons-fileupload/commit/b8253237867120ec8c99ea34b68ac86c6283dbc3) on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587630) Time Spent: 50m (was: 40m) > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587631 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 23/Apr/21 04:58 Start Date: 23/Apr/21 04:58 Worklog Time Spent: 10m Work Description: arturobernalg commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825386227 > Please, complete this PR by adding an entry to the contributors section in pom.xml. HI @jochenw added TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587631) Time Spent: 1h (was: 50m) > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg commented on pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
arturobernalg commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825386227 > Please, complete this PR by adding an entry to the contributors section in pom.xml. HI @jochenw added TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] arturobernalg edited a comment on pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
arturobernalg edited a comment on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825386084 > [](https://coveralls.io/builds/39056969) > > Coverage remained the same at 78.323% when pulling **[15a88fc](https://github.com/apache/commons-fileupload/commit/15a88fc2e33355de746501c997c419ff613b98dc) on arturobernalg:feature/FILEUPLOAD-314** into **[b825323](https://github.com/apache/commons-fileupload/commit/b8253237867120ec8c99ea34b68ac86c6283dbc3) on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587629 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 23/Apr/21 04:57 Start Date: 23/Apr/21 04:57 Worklog Time Spent: 10m Work Description: arturobernalg commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825386084 > [](https://coveralls.io/builds/39056969) > > Coverage remained the same at 78.323% when pulling **[15a88fc](https://github.com/apache/commons-fileupload/commit/15a88fc2e33355de746501c997c419ff613b98dc) on arturobernalg:feature/FILEUPLOAD-314** into **[b825323](https://github.com/apache/commons-fileupload/commit/b8253237867120ec8c99ea34b68ac86c6283dbc3) on apache:master**. HI @jochenw added TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587629) Time Spent: 40m (was: 0.5h) > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg commented on pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
arturobernalg commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825386084 > [](https://coveralls.io/builds/39056969) > > Coverage remained the same at 78.323% when pulling **[15a88fc](https://github.com/apache/commons-fileupload/commit/15a88fc2e33355de746501c997c419ff613b98dc) on arturobernalg:feature/FILEUPLOAD-314** into **[b825323](https://github.com/apache/commons-fileupload/commit/b8253237867120ec8c99ea34b68ac86c6283dbc3) on apache:master**. HI @jochenw added TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee merged pull request #189: Add oss-fuzz to README.md
PeterAlfredLee merged pull request #189: URL: https://github.com/apache/commons-compress/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-721) FileUtils.copyDirectory() tries to set last modified on source dir after update to 2.8.0
[
https://issues.apache.org/jira/browse/IO-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329934#comment-17329934
]
Darius Cooper commented on IO-721:
--
Why does one directory work, but not another? Is it permissions? I can run
touch on my /tmp directory.
> FileUtils.copyDirectory() tries to set last modified on source dir after
> update to 2.8.0
>
>
> Key: IO-721
> URL: https://issues.apache.org/jira/browse/IO-721
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.8.0
> Environment: Ubuntu 20.04 LTS
> Groovy 3.0.x
> Java 11 (from Ubuntu packages)
>Reporter: Dirk Heinrichs
>Priority: Major
>
> A simple
> {code:java}
> FileUtils.copyDirectory(source, dest, glob) {code}
> works fine when using Commons-IO 2.7, but fails with
> {code:java}
> Caught: java.io.IOException: Failed setLastModified on /path/to/source
> java.io.IOException: Failed setLastModified on /path/to/source
> at
> org.apache.commons.io.FileUtils.setLastModified(FileUtils.java:2561)
> at
> org.apache.commons.io.FileUtils.doCopyDirectory(FileUtils.java:1361)
> at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:733)
> at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:659)
> at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:606)
> {code}
> after update to 2.8.0. From reading the documentation, it's also my
> understanding that "setLastModified()" should be executed on "dest" to set
> the same modification time as "source", but *not* on "source".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[ https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329907#comment-17329907 ] Gilles Sadowski commented on NUMBERS-77: We should [add unit tests|https://coveralls.io/builds/39054112/source?filename=commons-numbers-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcommons%2Fnumbers%2Fcore%2FPrecision.java]. > Move utilities from "Commons Geometry" > -- > > Key: NUMBERS-77 > URL: https://issues.apache.org/jira/browse/NUMBERS-77 > Project: Commons Numbers > Issue Type: Task >Reporter: Gilles Sadowski >Priority: Major > Fix For: 1.1 > > Attachments: NUMBERS-77.diff > > Time Spent: 1h 10m > Remaining Estimate: 0h > > "Commons Geometry" defines utilities that would be a better fit in this > component. > Duplication of general-purpose codes should be avoided, in order to benefit > from consolidated usage (bug reporting, performance enhancements, ...). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IO-684) Add force version of PathUtils.delete() APIs and friends.
[
https://issues.apache.org/jira/browse/IO-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329900#comment-17329900
]
Bryan Turner commented on IO-684:
-
One thing the changes here don't address is the altered behavior of
{{FileUtils.cleanDirectory}} (and other helpers that use it, like
{{deleteDirectory}} and {{deleteQuietly}}). Because commons-io 2.6 used
{{File.delete}}, it would delete read-only files by default. However, with
{{FileUtils.forceDelete}} now updated to call
{{PathUtils.delete(file.toPath())}} without
{{StandardDeleteOption.OVERRIDE_READ_ONLY}}, this no longer works. It also
doesn't appear any overloads were added in {{FileUtils}} to get the old
behavior back again.
This behavior change is causing a lot of subtle breakages in code that I
maintain, as well as code that I use. Should the {{FileUtils}} variants perhaps
be updated to restore the old behavior by default? Or perhaps some overloads
added to callers can easily restore the old behavior if they need to after
upgrading?
> Add force version of PathUtils.delete() APIs and friends.
> -
>
> Key: IO-684
> URL: https://issues.apache.org/jira/browse/IO-684
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.7
>Reporter: Robin Jansohn
>Priority: Major
> Fix For: 2.8.0
>
>
> With the changes from IO-629 I'm getting an {{AccessDeniedException}} when
> trying to recursively delete a directory with read-only files, e.g. a
> {{.git}} repository. Before this change the directory was successfully
> deleted. It is due to the difference between {{File.delete()}} and
> {{Files.delete()}} (see https://stackoverflow.com/a/12234217/3375325).
> I think an option should be introduced to make the previous behavior
> available again with an overloaded method like {{PathUtils.delete(Path path,
> boolean force)}}.
> Stacktrace:
> {noformat}
> java.nio.file.AccessDeniedException:
> C:\Users\xyz\AppData\Local\Temp\.git\objects\pack\pack-6576964fbde069f1787513ce358d2260530d5738.idx
> at
> sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
> at
> sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
> at
> sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:108)
> at java.nio.file.Files.deleteIfExists(Files.java:1165)
> at
> org.apache.commons.io.file.DeletingPathVisitor.visitFile(DeletingPathVisitor.java:99)
> at
> org.apache.commons.io.file.DeletingPathVisitor.visitFile(DeletingPathVisitor.java:35)
> at java.nio.file.Files.walkFileTree(Files.java:2670)
> at java.nio.file.Files.walkFileTree(Files.java:2742)
> at
> org.apache.commons.io.file.PathUtils.visitFileTree(PathUtils.java:535)
> at
> org.apache.commons.io.file.PathUtils.deleteDirectory(PathUtils.java:265)
> at org.apache.commons.io.file.PathUtils.delete(PathUtils.java:254)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329898#comment-17329898
]
Gilles Sadowski commented on NUMBERS-77:
I've modified {{Precision.compareTo}} according to Alex's suggested fix (cf.
NUMBERS-154).
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (NUMBERS-154) Consistent sorting using "Precision" class
[
https://issues.apache.org/jira/browse/NUMBERS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski resolved NUMBERS-154.
-
Resolution: Fixed
Commit 4f0cf073de18650a2cedd9c1ca07cff9bee44d8d
> Consistent sorting using "Precision" class
> --
>
> Key: NUMBERS-154
> URL: https://issues.apache.org/jira/browse/NUMBERS-154
> Project: Commons Numbers
> Issue Type: Bug
> Components: core
>Affects Versions: 1.0-beta1
>Reporter: Gilles Sadowski
>Priority: Major
>
> As noted by Alex Herbert in NUMBERS-77, method {{compareTo}} (in class
> {{Precision}}) must handle NaN properly in order to ensure consistent sorting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (NUMBERS-154) Consistent sorting using "Precision" class
Gilles Sadowski created NUMBERS-154:
---
Summary: Consistent sorting using "Precision" class
Key: NUMBERS-154
URL: https://issues.apache.org/jira/browse/NUMBERS-154
Project: Commons Numbers
Issue Type: Bug
Components: core
Affects Versions: 1.0-beta1
Reporter: Gilles Sadowski
As noted by Alex Herbert in NUMBERS-77, method {{compareTo}} (in class
{{Precision}}) must handle NaN properly in order to ensure consistent sorting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw merged pull request #54: Bump maven-checkstyle-plugin from 3.1.1 to 3.1.2
jochenw merged pull request #54: URL: https://github.com/apache/commons-fileupload/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw merged pull request #56: Bump actions/cache from v2 to v2.1.4
jochenw merged pull request #56: URL: https://github.com/apache/commons-fileupload/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #57: Bump biz.aQute.bndlib from 5.2.0 to 5.3.0
dependabot[bot] commented on pull request #57: URL: https://github.com/apache/commons-fileupload/pull/57#issuecomment-825181567 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #57: Bump biz.aQute.bndlib from 5.2.0 to 5.3.0
jochenw commented on pull request #57: URL: https://github.com/apache/commons-fileupload/pull/57#issuecomment-825181553 Doesn't affect the actual code, so no need to upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw closed pull request #57: Bump biz.aQute.bndlib from 5.2.0 to 5.3.0
jochenw closed pull request #57: URL: https://github.com/apache/commons-fileupload/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-313) Remove redundant local variable
[ https://issues.apache.org/jira/browse/FILEUPLOAD-313?focusedWorklogId=587519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587519 ] ASF GitHub Bot logged work on FILEUPLOAD-313: - Author: ASF GitHub Bot Created on: 22/Apr/21 20:56 Start Date: 22/Apr/21 20:56 Worklog Time Spent: 10m Work Description: jochenw merged pull request #61: URL: https://github.com/apache/commons-fileupload/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587519) Time Spent: 0.5h (was: 20m) > Remove redundant local variable > --- > > Key: FILEUPLOAD-313 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-313 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw merged pull request #55: Bump junit-jupiter from 5.7.0 to 5.7.1
jochenw merged pull request #55: URL: https://github.com/apache/commons-fileupload/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw merged pull request #61: FILEUPLOAD-313 - Remove redundant local variable
jochenw merged pull request #61: URL: https://github.com/apache/commons-fileupload/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329409#comment-17329409
]
Alex Herbert edited comment on NUMBERS-77 at 4/22/21, 8:54 PM:
---
{quote}Let's refer to what's in "master" (there were fixes).
{quote}
Master was updated as I was writing the post. The javadoc looks fine.
Here is some more thoughts on compare and the Comparator interface.
I think that we can handle NaN by specifying that the compare returns [-1, 0,
1] for an ordering of non Nan numbers with equality (a zero result) defined by
some measure of closeness. NaN inputs are handled using Double.compare. So two
input NaNs will return 0:
{code:java}
public static int compareTo(double x, double y, double eps) {
if (equals(x, y, eps)) {
return 0;
} else if (x < y) {
return -1;
} else if (x > y) {
return 1;
}
// NaN input
return Double.compare(x, y);
}
{code}
Using this creates a function that handles non-finite numbers as per
Double.compare and can sort an array but not necessarily in its strict natural
order. The sort function in Arrays is described as stable, meaning that two
elements that have a compare result of 0 will not be reordered. Thus if you
resort the array you get the same result.
Sorting Matt's example using Precision as is:
{code:java}
@Test
void testUnstableSort() {
Double[] array = {0.02, 0.01, 1.0, 2.0, Double.NaN, Double.NaN};
for (int i = 0; i < 10; i++) {
Collections.shuffle(Arrays.asList(array));
Arrays.sort(array, (a, b) -> Precision.compareTo(a, b, 0.1));
System.out.println(Arrays.toString(array));
}
}
{code}
{noformat}
[NaN, 0.02, 0.01, 1.0, 2.0, NaN]
[0.01, 2.0, NaN, 0.02, 1.0, NaN]
[0.02, NaN, 0.01, 1.0, 2.0, NaN]
[NaN, NaN, 0.01, 0.02, 1.0, 2.0]
[NaN, 0.02, 0.01, 1.0, 2.0, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[NaN, 0.02, 0.01, 1.0, NaN, 2.0]
[1.0, NaN, 0.01, 0.02, 2.0, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[1.0, NaN, NaN, 0.02, 0.01, 2.0]
{noformat}
With the change to the above code:
{noformat}
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
{noformat}
Looking at the javadoc for Comparator:
# sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y
# relation is transitive: (compare(x, y) > 0) & (compare(y, z) > 0)) implies
compare(x, z) > 0
# compare(x, y)==0 implies that sgn(compare(x, z))==sgn(compare(y, z)) for all
z
# not strictly required that (compare(x, y)==0) == (x.equals( y )). Generally
speaking, any comparator that violates this condition should clearly indicate
this fact
I think that point 1 and 2 are covered. Point 4 is not but that is not
required.
But point 3 is not. Consider the points x > y > z:
{noformat}
Epsilon: |-|
|-|-|
x y z
compare(x, y) == 0
compare(x, z) == 1
compare(y, z) == 0 (violation, it should be 1){noformat}
Here x is equal to y but above z. So y should be above z but it is not.
Thus we cannot implement the contract of a comparator. This means we do not
have to change anything and can handle NaN in whatever way we like during
comparison.
Some options are:
# Leave the method and document it as unsuitable for use as part of the
implementation for Comparator.
# Update it to handle NaN as per Double.compare. It is still not strictly
suitable as part of the implementation for Comparator due to violation of rule
3. It works better for sorting but would return 0 when Precision.equals(NaN,
NaN) returns false.
# Remove the compare method from Precision, i.e. what is the use case if not
for ordering.
# Others...
was (Author: alexherbert):
{quote}Let's refer to what's in "master" (there were fixes).
{quote}
Master was updated as I was writing the post. The javadoc looks fine.
Here is some more thoughts on compare and the Comparator interface.
I think that we can handle NaN by specifying that the compare returns [-1, 0,
1] for an ordering of non Nan numbers with equality (a zero result) defined by
some measure of closeness. NaN inputs are handled using Double.compare. So two
input NaNs will return 0:
{code:java}
public static int compareTo(double x, double y, double eps) {
if (equals(x, y, eps)) {
return 0;
} else if (x < y) {
return -1;
} else if (x > y) {
return 1;
}
// NaN input
return Double.compare(x, y);
}
{code}
Using this creates a function that handles non-finite numbers as per
Double.compare and can sort an array but not necessarily in its strict natural
order. The sort function in Arrays is described as stable, meaning that two
elements that ha
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[ https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329414#comment-17329414 ] Alex Herbert commented on NUMBERS-77: - Snapshots are deployed by Jenkins: [commons-numbers-core|https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-numbers-core/] > Move utilities from "Commons Geometry" > -- > > Key: NUMBERS-77 > URL: https://issues.apache.org/jira/browse/NUMBERS-77 > Project: Commons Numbers > Issue Type: Task >Reporter: Gilles Sadowski >Priority: Major > Fix For: 1.1 > > Attachments: NUMBERS-77.diff > > Time Spent: 1h 10m > Remaining Estimate: 0h > > "Commons Geometry" defines utilities that would be a better fit in this > component. > Duplication of general-purpose codes should be avoided, in order to benefit > from consolidated usage (bug reporting, performance enhancements, ...). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?focusedWorklogId=587513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587513 ] ASF GitHub Bot logged work on FILEUPLOAD-312: - Author: ASF GitHub Bot Created on: 22/Apr/21 20:50 Start Date: 22/Apr/21 20:50 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60#issuecomment-825176472 Same as in #63: I am generally fine with those changes, but the patch is way too large. Please, dotake the time to split this into smaller pieces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587513) Time Spent: 40m (was: 0.5h) > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329409#comment-17329409
]
Alex Herbert commented on NUMBERS-77:
-
{quote}Let's refer to what's in "master" (there were fixes).
{quote}
Master was updated as I was writing the post. The javadoc looks fine.
Here is some more thoughts on compare and the Comparator interface.
I think that we can handle NaN by specifying that the compare returns [-1, 0,
1] for an ordering of non Nan numbers with equality (a zero result) defined by
some measure of closeness. NaN inputs are handled using Double.compare. So two
input NaNs will return 0:
{code:java}
public static int compareTo(double x, double y, double eps) {
if (equals(x, y, eps)) {
return 0;
} else if (x < y) {
return -1;
} else if (x > y) {
return 1;
}
// NaN input
return Double.compare(x, y);
}
{code}
Using this creates a function that handles non-finite numbers as per
Double.compare and can sort an array but not necessarily in its strict natural
order. The sort function in Arrays is described as stable, meaning that two
elements that have a compare result of 0 will not be reordered. Thus if you
resort the array you get the same result.
Sorting Matt's example using Precision as is:
{code:java}
@Test
void testUnstableSort() {
Double[] array = {0.02, 0.01, 1.0, 2.0, Double.NaN, Double.NaN};
for (int i = 0; i < 10; i++) {
Collections.shuffle(Arrays.asList(array));
Arrays.sort(array, (a, b) -> Precision.compareTo(a, b, 0.1));
System.out.println(Arrays.toString(array));
}
}
{code}
{noformat}
[NaN, 0.02, 0.01, 1.0, 2.0, NaN]
[0.01, 2.0, NaN, 0.02, 1.0, NaN]
[0.02, NaN, 0.01, 1.0, 2.0, NaN]
[NaN, NaN, 0.01, 0.02, 1.0, 2.0]
[NaN, 0.02, 0.01, 1.0, 2.0, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[NaN, 0.02, 0.01, 1.0, NaN, 2.0]
[1.0, NaN, 0.01, 0.02, 2.0, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[1.0, NaN, NaN, 0.02, 0.01, 2.0]
{noformat}
With the change to the above code:
{noformat}
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.01, 0.02, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
[0.02, 0.01, 1.0, 2.0, NaN, NaN]
{noformat}
Looking at the javadoc for Comparator:
# sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y
# relation is transitive: (compare(x, y) > 0) & (compare(y, z) > 0))
implies compare(x, z) > 0
# compare(x, y)==0 implies that sgn(compare(x, z))==sgn(compare(y, z)) for all
z
# not strictly required that (compare(x, y)==0) == (x.equals( y )). Generally
speaking, any comparator that violates this condition should clearly indicate
this fact
I think that point 1 and 2 are covered. Point 4 is not but that is not
required.
But point 3 is not. Consider the points x > y > z:
{noformat}
Epsilon: |-|
|-|-|
x y z
compare(x, y) == 0
compare(x, z) == 1
compare(y, z) == 0 (violation, it should be 1){noformat}
Here x is equal to y but above z. So y should be above z but it is not.
Thus we cannot implement the contract of a comparator. This means we do not
have to change anything and can handle NaN in whatever way we like during
comparison.
Some options are:
# Leave the method and document it as unsuitable for use as part of the
implementation for Comparator.
# Update it to handle NaN as per Double.compare. It is still not strictly
suitable as part of the implementation for Comparator due to violation of rule
3. It works better for sorting but would return 0 when Precision.equals(NaN,
NaN) returns false.
# Remove the compare method from Precision, i.e. what is the use case if not
for ordering.
# Others...
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?focusedWorklogId=587512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587512 ] ASF GitHub Bot logged work on FILEUPLOAD-312: - Author: ASF GitHub Bot Created on: 22/Apr/21 20:50 Start Date: 22/Apr/21 20:50 Worklog Time Spent: 10m Work Description: jochenw closed pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587512) Time Spent: 0.5h (was: 20m) > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw commented on pull request #60: FILEUPLOAD-312 - Use charset constant
jochenw commented on pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60#issuecomment-825176472 Same as in #63: I am generally fine with those changes, but the patch is way too large. Please, dotake the time to split this into smaller pieces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw closed pull request #60: FILEUPLOAD-312 - Use charset constant
jochenw closed pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
jochenw commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825155610 Please, complete this PR by adding an entry to the contributors section in pom.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587492 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 22/Apr/21 20:16 Start Date: 22/Apr/21 20:16 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825155610 Please, complete this PR by adding an entry to the contributors section in pom.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587492) Time Spent: 0.5h (was: 20m) > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IMAGING-291) Fix Typo
[ https://issues.apache.org/jira/browse/IMAGING-291?focusedWorklogId=587488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587488 ] ASF GitHub Bot logged work on IMAGING-291: -- Author: ASF GitHub Bot Created on: 22/Apr/21 20:14 Start Date: 22/Apr/21 20:14 Worklog Time Spent: 10m Work Description: kinow commented on pull request #135: URL: https://github.com/apache/commons-imaging/pull/135#issuecomment-825154265 Merged, thanks Arturo! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587488) Time Spent: 2h 20m (was: 2h 10m) > Fix Typo > - > > Key: IMAGING-291 > URL: https://issues.apache.org/jira/browse/IMAGING-291 > Project: Commons Imaging > Issue Type: Sub-task >Affects Versions: 1.0-alpha2 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Fix typo in javadoc and variables name -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on pull request #135: IMAGING-291 - Fix Typo
kinow commented on pull request #135: URL: https://github.com/apache/commons-imaging/pull/135#issuecomment-825154265 Merged, thanks Arturo! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-291) Fix Typo
[ https://issues.apache.org/jira/browse/IMAGING-291?focusedWorklogId=587487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587487 ] ASF GitHub Bot logged work on IMAGING-291: -- Author: ASF GitHub Bot Created on: 22/Apr/21 20:13 Start Date: 22/Apr/21 20:13 Worklog Time Spent: 10m Work Description: kinow closed pull request #135: URL: https://github.com/apache/commons-imaging/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587487) Time Spent: 2h 10m (was: 2h) > Fix Typo > - > > Key: IMAGING-291 > URL: https://issues.apache.org/jira/browse/IMAGING-291 > Project: Commons Imaging > Issue Type: Sub-task >Affects Versions: 1.0-alpha2 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Fix typo in javadoc and variables name -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] kinow closed pull request #135: IMAGING-291 - Fix Typo
kinow closed pull request #135: URL: https://github.com/apache/commons-imaging/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IMAGING-291) Fix Typo
[ https://issues.apache.org/jira/browse/IMAGING-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved IMAGING-291. Resolution: Fixed > Fix Typo > - > > Key: IMAGING-291 > URL: https://issues.apache.org/jira/browse/IMAGING-291 > Project: Commons Imaging > Issue Type: Sub-task >Affects Versions: 1.0-alpha2 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > Time Spent: 2h > Remaining Estimate: 0h > > Fix typo in javadoc and variables name -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IMAGING-291) Fix Typo
[ https://issues.apache.org/jira/browse/IMAGING-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-291: --- Fix Version/s: 1.0-alpha3 > Fix Typo > - > > Key: IMAGING-291 > URL: https://issues.apache.org/jira/browse/IMAGING-291 > Project: Commons Imaging > Issue Type: Sub-task >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > Time Spent: 2h > Remaining Estimate: 0h > > Fix typo in javadoc and variables name -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IMAGING-291) Fix Typo
[ https://issues.apache.org/jira/browse/IMAGING-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-291: --- Affects Version/s: 1.0-alpha2 > Fix Typo > - > > Key: IMAGING-291 > URL: https://issues.apache.org/jira/browse/IMAGING-291 > Project: Commons Imaging > Issue Type: Sub-task >Affects Versions: 1.0-alpha2 >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > Time Spent: 2h > Remaining Estimate: 0h > > Fix typo in javadoc and variables name -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IMAGING-291) Fix Typo
[ https://issues.apache.org/jira/browse/IMAGING-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-291: --- Assignee: Bruno P. Kinoshita > Fix Typo > - > > Key: IMAGING-291 > URL: https://issues.apache.org/jira/browse/IMAGING-291 > Project: Commons Imaging > Issue Type: Sub-task >Reporter: Arturo Bernal >Assignee: Bruno P. Kinoshita >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > Fix typo in javadoc and variables name -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[ https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329376#comment-17329376 ] Matt Juntunen commented on NUMBERS-77: -- Still not sold on the name but I'm 99% sure this will work for geometry. On a practical note, can I use this now or do I need to wait until it's released? Can Jenkins and Travis resolve a SNAPSHOT dependency on commons-numbers? > Move utilities from "Commons Geometry" > -- > > Key: NUMBERS-77 > URL: https://issues.apache.org/jira/browse/NUMBERS-77 > Project: Commons Numbers > Issue Type: Task >Reporter: Gilles Sadowski >Priority: Major > Fix For: 1.1 > > Attachments: NUMBERS-77.diff > > Time Spent: 1h 10m > Remaining Estimate: 0h > > "Commons Geometry" defines utilities that would be a better fit in this > component. > Duplication of general-purpose codes should be avoided, in order to benefit > from consolidated usage (bug reporting, performance enhancements, ...). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?focusedWorklogId=587456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587456 ] ASF GitHub Bot logged work on FILEUPLOAD-315: - Author: ASF GitHub Bot Created on: 22/Apr/21 19:22 Start Date: 22/Apr/21 19:22 Worklog Time Spent: 10m Work Description: jochenw commented on pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63#issuecomment-825122263 @arturobernalg A short review suggests, that I should appreciate the proposed changes. However, as I have written before, and elsewhere, I am not ready to accept a PR, that changes no less than thirteen files in one go. In my opinion, the nature of these changes would permit to split them up, and resubmit them, file by file. In which case, I'd gladly accept them. Thanks, but no, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587456) Time Spent: 0.5h (was: 20m) > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?focusedWorklogId=587457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587457 ] ASF GitHub Bot logged work on FILEUPLOAD-315: - Author: ASF GitHub Bot Created on: 22/Apr/21 19:22 Start Date: 22/Apr/21 19:22 Worklog Time Spent: 10m Work Description: jochenw closed pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587457) Time Spent: 40m (was: 0.5h) > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?focusedWorklogId=587455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587455 ] ASF GitHub Bot logged work on FILEUPLOAD-315: - Author: ASF GitHub Bot Created on: 22/Apr/21 19:22 Start Date: 22/Apr/21 19:22 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63#issuecomment-825122099 [](https://coveralls.io/builds/39057020) Coverage decreased (-0.1%) to 78.219% when pulling **60b7e11c660b528af91e68893c5e1414df5f592a on arturobernalg:feature/FILEUPLOAD-315** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587455) Time Spent: 20m (was: 10m) > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw closed pull request #63: FILEUPLOAD-315 - java8 improvement
jochenw closed pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #63: FILEUPLOAD-315 - java8 improvement
jochenw commented on pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63#issuecomment-825122263 @arturobernalg A short review suggests, that I should appreciate the proposed changes. However, as I have written before, and elsewhere, I am not ready to accept a PR, that changes no less than thirteen files in one go. In my opinion, the nature of these changes would permit to split them up, and resubmit them, file by file. In which case, I'd gladly accept them. Thanks, but no, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #63: FILEUPLOAD-315 - java8 improvement
coveralls commented on pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63#issuecomment-825122099 [](https://coveralls.io/builds/39057020) Coverage decreased (-0.1%) to 78.219% when pulling **60b7e11c660b528af91e68893c5e1414df5f592a on arturobernalg:feature/FILEUPLOAD-315** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587452 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 22/Apr/21 19:21 Start Date: 22/Apr/21 19:21 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825121446 [](https://coveralls.io/builds/39056969) Coverage remained the same at 78.323% when pulling **15a88fc2e33355de746501c997c419ff613b98dc on arturobernalg:feature/FILEUPLOAD-314** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587452) Time Spent: 20m (was: 10m) > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
coveralls commented on pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62#issuecomment-825121446 [](https://coveralls.io/builds/39056969) Coverage remained the same at 78.323% when pulling **15a88fc2e33355de746501c997c419ff613b98dc on arturobernalg:feature/FILEUPLOAD-314** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-313) Remove redundant local variable
[ https://issues.apache.org/jira/browse/FILEUPLOAD-313?focusedWorklogId=587450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587450 ] ASF GitHub Bot logged work on FILEUPLOAD-313: - Author: ASF GitHub Bot Created on: 22/Apr/21 19:16 Start Date: 22/Apr/21 19:16 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #61: URL: https://github.com/apache/commons-fileupload/pull/61#issuecomment-825118085 [](https://coveralls.io/builds/39056798) Coverage increased (+0.1%) to 78.447% when pulling **bc47cab7e607dec3f966d192907ff9e74d4e2ed8 on arturobernalg:feature/FILEUPLOAD-313** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587450) Time Spent: 20m (was: 10m) > Remove redundant local variable > --- > > Key: FILEUPLOAD-313 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-313 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #61: FILEUPLOAD-313 - Remove redundant local variable
coveralls commented on pull request #61: URL: https://github.com/apache/commons-fileupload/pull/61#issuecomment-825118085 [](https://coveralls.io/builds/39056798) Coverage increased (+0.1%) to 78.447% when pulling **bc47cab7e607dec3f966d192907ff9e74d4e2ed8 on arturobernalg:feature/FILEUPLOAD-313** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329363#comment-17329363
]
Gilles Sadowski commented on NUMBERS-77:
bq. In your diff [...]
Let's refer to what's in "master" (there were fixes).
bq. comparisons break down when NaN is input. Is this the behaviour we want?
Probably not if it can be helped. ;-)
bq. I like having the term "precision" in the name [...]
Then why
bq. prefer if the interface were top-level
since the nesting offers both?
bq. I'm going to need to update about a bajillion variable names [...]
Why?
It's perfectly fine that
{code}
final DoublePrecisionContext precision = new
EpsilonDoublePrecisionContext(1e-4);
{code}
becomes
{code}
final Precision.DoubleEquivalence precision =
Precision.doubleEquivalenceOfEpsilon(1e-4);
{code}
bq. [...] values [0.01, 0.02, 1, 2] are "correctly" sorted when using an
epsilon value of 0.1 but so are [0.02, 0.01, 1, 2].
Not a problem since indeed 0.01 and 0.02 are _equivalent_. Hence the name. ;-)
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329345#comment-17329345
]
Matt Juntunen commented on NUMBERS-77:
--
{quote}So currently the comparisons break down when NaN is input. Is this the
behaviour we want?
{quote}
It would be better if we could provide a comparison that produces a stable
sort. However, this may not be possible based on our use of "fuzzy"
comparisons. For example, the values {{[0.01, 0.02, 1, 2]}} are "correctly"
sorted when using an epsilon value of {{0.1}} but so are {{[0.02, 0.01, 1,
2]}}. The first two values are considered equal.
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-315) java8 improvement
[ https://issues.apache.org/jira/browse/FILEUPLOAD-315?focusedWorklogId=587420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587420 ] ASF GitHub Bot logged work on FILEUPLOAD-315: - Author: ASF GitHub Bot Created on: 22/Apr/21 18:24 Start Date: 22/Apr/21 18:24 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587420) Remaining Estimate: 0h Time Spent: 10m > java8 improvement > - > > Key: FILEUPLOAD-315 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #63: FILEUPLOAD-315 - java8 improvement
arturobernalg opened a new pull request #63: URL: https://github.com/apache/commons-fileupload/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-315) java8 improvement
Arturo Bernal created FILEUPLOAD-315: Summary: java8 improvement Key: FILEUPLOAD-315 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-315 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-314) Replace C-style array declaration for java
[ https://issues.apache.org/jira/browse/FILEUPLOAD-314?focusedWorklogId=587419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587419 ] ASF GitHub Bot logged work on FILEUPLOAD-314: - Author: ASF GitHub Bot Created on: 22/Apr/21 18:21 Start Date: 22/Apr/21 18:21 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587419) Remaining Estimate: 0h Time Spent: 10m > Replace C-style array declaration for java > -- > > Key: FILEUPLOAD-314 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #62: FILEUPLOAD-314 - Replace C-style array declaration for java
arturobernalg opened a new pull request #62: URL: https://github.com/apache/commons-fileupload/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-314) Replace C-style array declaration for java
Arturo Bernal created FILEUPLOAD-314: Summary: Replace C-style array declaration for java Key: FILEUPLOAD-314 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-314 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329342#comment-17329342
]
Matt Juntunen commented on NUMBERS-77:
--
bq. So if we agree on the basic design, I could merge the current version (as
per the attached diff). OK?
Yes, but I have a couple more points:
- I'm not sold on the name yet (see below).
- I would prefer if the interface were top-level instead of nested in
{{Precision}}. It makes it more convenient since this type will be used almost
everywhere in geometry.
bq. I feel that it doesn't say what the class does.
It's the same with the {{Precision}} class in general. I like having the term
"precision" in the name since you immediately know that you're going to be
working with floating point accuracy. My favorite names so far are (in order):
- {{PrecisionContext}}
- {{PrecisionComparator}}
- {{PrecisionCompareStrategy}}
(I'm probably a bit biased here, though, since if the name doesn't have
"precision" in it, I'm going to need to update about a bajillion variable names
and javadocs in geometry :-)
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-313) Remove redundant local variable
[ https://issues.apache.org/jira/browse/FILEUPLOAD-313?focusedWorklogId=587415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587415 ] ASF GitHub Bot logged work on FILEUPLOAD-313: - Author: ASF GitHub Bot Created on: 22/Apr/21 18:13 Start Date: 22/Apr/21 18:13 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #61: URL: https://github.com/apache/commons-fileupload/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587415) Remaining Estimate: 0h Time Spent: 10m > Remove redundant local variable > --- > > Key: FILEUPLOAD-313 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-313 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #61: FILEUPLOAD-313 - Remove redundant local variable
arturobernalg opened a new pull request #61: URL: https://github.com/apache/commons-fileupload/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-313) Remove redundant local variable
Arturo Bernal created FILEUPLOAD-313: Summary: Remove redundant local variable Key: FILEUPLOAD-313 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-313 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329332#comment-17329332
]
Alex Herbert commented on NUMBERS-77:
-
{quote}I think that there is a problem when {{0 < |a| < eps}}
{quote}
Good spot. It will return a and not 0.
Looking at Matt's example in AbstractHyperPlane then this is a case where -0.0
should not return -1 if you test it with 0.0. But that should be handled by an
epsilon for the eqZero call.
In your diff for the sign method your javadoc states:
{noformat}
* The returned value is
*
* {@code 0} if the arguments are considered equal,
* {@code -1} if {@code a < b},
* {@code +1} if {@code a > b} or if either value is NaN.
* {noformat}
This is copied from compare. It should be:
{noformat}
* The returned value is
*
* {@code 0} if the arguments is considered equal to zero,
* {@code -1} if {@code a < 0},
* {@code +1} if {@code a > 0} or if either value is NaN.
* {noformat}
Thinking about the result for compare, it is documented to return +1 when
either argument is NaN. If this class is ever used for sorting (as part of a
comparison of objects with double values) then this will result in an unstable
sort as this violates the expected behaviour:
{noformat}
if compare(a, NaN) == 1 then compare(NaN, a) == -1
{noformat}
Double.compare will place NaN after any non-Nan value, or any non-NaN value
before a NaN. It returns 0 for two NaN inputs.
{noformat}
compare(a, NaN) == -1
compare(NaN, a) == 1
compare(NaN, NaN) == 0
{noformat}
I think that NaN requires some special handling. For example assuming compare
returns 1 for NaN on either input you have:
{noformat}
eq(a, NaN) == false
eqZero(NaN) == false
lt(a, NaN) == false
lt(NaN, a) == false
lte(a, NaN) == false
lte(NaN, a) == false
gt(a, NaN) == true
gt(NaN, a) == true
gte(a, NaN) == true
gte(NaN, a) == true
sign(NaN) == 1{noformat}
This issue is also present in the Precision class which will return +1 for the
compare methods when NaN is one of the arguments. All the Precision methods for
equality state that nothing is equal to NaN and there are separate methods for
equalsIncludingNan. But the compare method does not specially handle it and so
cannot be used for sorting/ordering.
If you have an object that implements equals and compare using Precision.equals
and Precision.compareTo then it cannot be used in a sort as comparisons with
NaN always return 1. If you use Precision.equalsIncludingNan then the
comparator will fail its contract as two equal objects (NaN, NaN) will not have
zero returned from compare(NaN, NaN).
So currently the comparisons break down when NaN is input. Is this the
behaviour we want? If so it should be documented to not use these methods in
comparators for sorting.
Note you can test this using:
{code:java}
@Test
void testUnstableSort() {
Double[] array = {1.0, 2.0, 3.0, Double.NaN, Double.NaN};
for (int i = 0; i < 10; i++) {
Collections.shuffle(Arrays.asList(array));
Arrays.sort(array, (a, b) -> Precision.compareTo(a, b, 1e-10));
// CHECKSTYLE stop all
System.out.println(Arrays.toString(array));
}
}
{code}
Outputs some rubbish:
{noformat}
[NaN, 1.0, 2.0, 3.0, NaN]
[2.0, NaN, 1.0, NaN, 3.0]
[1.0, 2.0, 3.0, NaN, NaN]
[3.0, NaN, NaN, 1.0, 2.0]
[3.0, NaN, 1.0, 2.0, NaN]
[2.0, NaN, NaN, 1.0, 3.0]
[1.0, NaN, NaN, 2.0, 3.0]
[3.0, NaN, 1.0, NaN, 2.0]
[1.0, NaN, NaN, 2.0, 3.0]
[3.0, NaN, 1.0, 2.0, NaN]
{noformat}
Switching to Double.compare and it works.
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?focusedWorklogId=587398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587398 ] ASF GitHub Bot logged work on FILEUPLOAD-312: - Author: ASF GitHub Bot Created on: 22/Apr/21 17:41 Start Date: 22/Apr/21 17:41 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60#issuecomment-825054301 [](https://coveralls.io/builds/39053946) Coverage increased (+0.1%) to 78.43% when pulling **dc3074510a769599aefa84f368fcc27f94cf05ad on arturobernalg:feature/FILEUPLOAD-312** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587398) Time Spent: 20m (was: 10m) > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #60: FILEUPLOAD-312 - Use charset constant
coveralls commented on pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60#issuecomment-825054301 [](https://coveralls.io/builds/39053946) Coverage increased (+0.1%) to 78.43% when pulling **dc3074510a769599aefa84f368fcc27f94cf05ad on arturobernalg:feature/FILEUPLOAD-312** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329318#comment-17329318
]
Gilles Sadowski commented on NUMBERS-77:
Merged (with discussed changes) into master:
commit dbd2a473e4949d895054190f61cb950da1d6b36d
Name of the interface still TBC, as well as the implementation of {{signum}}.
Please check.
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (NUMBERS-77) Move utilities from "Commons Geometry"
[ https://issues.apache.org/jira/browse/NUMBERS-77?focusedWorklogId=587396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587396 ] ASF GitHub Bot logged work on NUMBERS-77: - Author: ASF GitHub Bot Created on: 22/Apr/21 17:38 Start Date: 22/Apr/21 17:38 Worklog Time Spent: 10m Work Description: asfgit closed pull request #89: URL: https://github.com/apache/commons-numbers/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587396) Time Spent: 1h 10m (was: 1h) > Move utilities from "Commons Geometry" > -- > > Key: NUMBERS-77 > URL: https://issues.apache.org/jira/browse/NUMBERS-77 > Project: Commons Numbers > Issue Type: Task >Reporter: Gilles Sadowski >Priority: Major > Fix For: 1.1 > > Attachments: NUMBERS-77.diff > > Time Spent: 1h 10m > Remaining Estimate: 0h > > "Commons Geometry" defines utilities that would be a better fit in this > component. > Duplication of general-purpose codes should be avoided, in order to benefit > from consolidated usage (bug reporting, performance enhancements, ...). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-numbers] asfgit closed pull request #89: NUMBERS-77: commons-geometry precision classes
asfgit closed pull request #89: URL: https://github.com/apache/commons-numbers/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-312) Use charset constant
[ https://issues.apache.org/jira/browse/FILEUPLOAD-312?focusedWorklogId=587394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587394 ] ASF GitHub Bot logged work on FILEUPLOAD-312: - Author: ASF GitHub Bot Created on: 22/Apr/21 17:34 Start Date: 22/Apr/21 17:34 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587394) Remaining Estimate: 0h Time Spent: 10m > Use charset constant > > > Key: FILEUPLOAD-312 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #60: FILEUPLOAD-312 - Use charset constant
arturobernalg opened a new pull request #60: URL: https://github.com/apache/commons-fileupload/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-312) Use charset constant
Arturo Bernal created FILEUPLOAD-312: Summary: Use charset constant Key: FILEUPLOAD-312 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-312 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-311) Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
[ https://issues.apache.org/jira/browse/FILEUPLOAD-311?focusedWorklogId=587361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587361 ] ASF GitHub Bot logged work on FILEUPLOAD-311: - Author: ASF GitHub Bot Created on: 22/Apr/21 16:36 Start Date: 22/Apr/21 16:36 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #59: URL: https://github.com/apache/commons-fileupload/pull/59#issuecomment-824999367 [](https://coveralls.io/builds/39051681) Coverage remained the same at 78.323% when pulling **4539ecbd688a419cc17b5d8a77999ca7c825a007 on arturobernalg:feature/FILEUPLOAD-311** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587361) Time Spent: 20m (was: 10m) > Replace construction of FileInputStream and FileOutputStream objects with > Files NIO APIs. > - > > Key: FILEUPLOAD-311 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-311 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls commented on pull request #59: FILEUPLOAD-311 - Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
coveralls commented on pull request #59: URL: https://github.com/apache/commons-fileupload/pull/59#issuecomment-824999367 [](https://coveralls.io/builds/39051681) Coverage remained the same at 78.323% when pulling **4539ecbd688a419cc17b5d8a77999ca7c825a007 on arturobernalg:feature/FILEUPLOAD-311** into **b8253237867120ec8c99ea34b68ac86c6283dbc3 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329237#comment-17329237
]
Gilles Sadowski edited comment on NUMBERS-77 at 4/22/21, 4:26 PM:
--
{quote}
{code}
default double signum(double a) {
return (a == 0.0 || compare(a, 0.0) == 0 || Double.isNaN(a)) ? a :
Math.copySign(1.0, a);
}
{code}
{quote}
I think that there is a problem when {{0 < |a| < eps}}.
The following
{code}
return a == 0d ||
Double.isNaN(a) ?
a :
eqZero(a) ?
Math.copySign(0d, a) :
Math.copySign(1d, a);
{code}
seems to behave as intended.
was (Author: erans):
{quote}
{code}
default double signum(double a) {
return (a == 0.0 || compare(a, 0.0) == 0 || Double.isNaN(a)) ? a :
Math.copySign(1.0, a);
}
{code}
{quote}
I think that there is a problem when {{0 < |a| < eps}}.
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-311) Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
[ https://issues.apache.org/jira/browse/FILEUPLOAD-311?focusedWorklogId=587354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587354 ] ASF GitHub Bot logged work on FILEUPLOAD-311: - Author: ASF GitHub Bot Created on: 22/Apr/21 16:22 Start Date: 22/Apr/21 16:22 Worklog Time Spent: 10m Work Description: arturobernalg opened a new pull request #59: URL: https://github.com/apache/commons-fileupload/pull/59 …utStream objects with Files NIO APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 587354) Remaining Estimate: 0h Time Spent: 10m > Replace construction of FileInputStream and FileOutputStream objects with > Files NIO APIs. > - > > Key: FILEUPLOAD-311 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-311 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #59: FILEUPLOAD-311 - Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
arturobernalg opened a new pull request #59: URL: https://github.com/apache/commons-fileupload/pull/59 …utStream objects with Files NIO APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FILEUPLOAD-311) Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
Arturo Bernal created FILEUPLOAD-311: Summary: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs. Key: FILEUPLOAD-311 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-311 Project: Commons FileUpload Issue Type: Sub-task Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-310) Minor improvements
Arturo Bernal created FILEUPLOAD-310: Summary: Minor improvements Key: FILEUPLOAD-310 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-310 Project: Commons FileUpload Issue Type: Improvement Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] arturobernalg closed pull request #52: Feature/minor improvement2
arturobernalg closed pull request #52: URL: https://github.com/apache/commons-fileupload/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] arturobernalg closed pull request #53: Feature/minor improvement3
arturobernalg closed pull request #53: URL: https://github.com/apache/commons-fileupload/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329237#comment-17329237
]
Gilles Sadowski commented on NUMBERS-77:
{quote}
{code}
default double signum(double a) {
return (a == 0.0 || compare(a, 0.0) == 0 || Double.isNaN(a)) ? a :
Math.copySign(1.0, a);
}
{code}
{quote}
I think that there is a problem when {{0 < |a| < eps}}.
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329202#comment-17329202
]
Gilles Sadowski commented on NUMBERS-77:
bq. [interface with default methods] is much cleaner.
So if we agree on the basic design, I could merge the current version (as per
the attached diff). OK?
bq. Are we sure that PrecisionContext isn't the best option?
I feel that it doesn't say *what* the class does.
bq. I was picturing this as an easy way to compare to zero. [...] handling of
-0.0 [...] is entirely up to the implementation.
It's potentially confusing (giving the false sense that it can be used wherever
"signum" would be).
bq. It's essentially a signum but returning an int for strict equality checking
(eg, cmp == 0).
It can be done the same with the return type being {{double}} (and the
appropriate comment that a strict equality check is done on purpose).
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] coveralls commented on pull request #189: Add oss-fuzz to README.md
coveralls commented on pull request #189: URL: https://github.com/apache/commons-compress/pull/189#issuecomment-824934712 [](https://coveralls.io/builds/39048991) Coverage decreased (-0.01%) to 87.197% when pulling **f10e5e30697fcd97fac5ab082bea018d22b98009 on PeterAlfredLee:add-fuzz-to-readme** into **63c4e1537ff0fc1bb69d94cd70949a9ebf443c68 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee opened a new pull request #189: Add oss-fuzz to README.md
PeterAlfredLee opened a new pull request #189: URL: https://github.com/apache/commons-compress/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329187#comment-17329187
]
Matt Juntunen commented on NUMBERS-77:
--
bq. Could the functionality be used as is in [Geometry]?
Yes, I believe so.
bq. Maybe the name is still not right.
Are we sure that {{PrecisionContext}} isn't the best option? This interface is
essentially a configurable wrapper around the {{Precision}} methods. The
"context" in this case is the configuration that has been applied at
instantiation, i.e. the epsilon value.
bq. there is no need for the AbstractPrecisionComparator when all the methods
can be default methods in the interface
I agree. That is much cleaner.
bq. Or maybe signum(double a) was actually intended , in which case the return
type should also be changed.
I was picturing this as an easy way to compare to zero. You can see it used
[here|https://github.com/apache/commons-geometry/blob/master/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/AbstractHyperplane.java#L39].
It's essentially a signum but returning an int for strict equality checking
(eg, {{cmp == 0}}). It could easily be written as
{code:java}
default int sign(double a) {
return compare(a, 0.0);
}
{code}
In regard to the handling of -0.0, that is entirely up to the implementation.
If {{compare(d, -0.0)}} returns 0, then so should this method.
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-77) Move utilities from "Commons Geometry"
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327876#comment-17327876
]
Alex Herbert commented on NUMBERS-77:
-
Looking at Matt's PR I would agree that there is no need for the
AbstractPrecisionComparator when all the methods can be default methods in the
interface. I like the implementation from Gilles with a simple interface with
default methods.
All the comparisons in {{sign}} seem redundant:
{code:java}
default int sign(double a) {
final int cmp = compare(a, 0.0);
if (cmp < 0) {
return -1;
} else if (cmp > 0) {
return 1;
}
return 0;
}
{code}
The only reason for all the comparisons is if you expect compare to return a
value that is not in [-1, 0, 1]. If so then the implementation of compare is
wrong. Surely it would be:
{code:java}
default int sign(double a) {
return compare(a, 0.0);
}
{code}
The question is do you wish it to return -1 for -0.0? Using Double.compare(a,
0.0) as the implementation it would do. Using the operators < and > it would
not. Any use of an epsilon should allow it.
So you have to deal with the use of -0.0 and 0.0 and what to expect. This would
be a signum function that handles -0.0 and 0.0 as returning 0.0:
{code:java}
default double signum(double a) {
return (a == 0.0 || compare(a, 0.0) == 0 || Double.isNaN(d)) ? d :
Math.copySign(1.0, d);
}
{code}
> Move utilities from "Commons Geometry"
> --
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
