[GitHub] [commons-math] msrocka commented on a change in pull request #176: MATH-1572 - Simplify Conditions:
msrocka commented on a change in pull request #176:
URL: https://github.com/apache/commons-math/pull/176#discussion_r623715426
##
File path:
src/main/java/org/apache/commons/math4/stat/inference/KolmogorovSmirnovTest.java
##
@@ -1133,11 +1133,7 @@ private static boolean hasTies(double[] x, double[] y) {
throw new InsufficientDataException();
}
- if (values.length == x.length + y.length) {
- return false; // There are no ties.
- }
-
- return true;
+ return values.length != x.length + y.length; // There are no ties.
Review comment:
The comment is then wrong, isn't it? Before it checked if there are no
ties (`values.length == x.length + y.length`) and the comment was related to
the `false` return value. Now it directly checks if there are ties which is
basically the name of the method so that the comment could be simply removed,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (MATH-1572) Simplify Conditions
[
https://issues.apache.org/jira/browse/MATH-1572?focusedWorklogId=591402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591402
]
ASF GitHub Bot logged work on MATH-1572:
Author: ASF GitHub Bot
Created on: 30/Apr/21 08:43
Start Date: 30/Apr/21 08:43
Worklog Time Spent: 10m
Work Description: msrocka commented on a change in pull request #176:
URL: https://github.com/apache/commons-math/pull/176#discussion_r623715426
##
File path:
src/main/java/org/apache/commons/math4/stat/inference/KolmogorovSmirnovTest.java
##
@@ -1133,11 +1133,7 @@ private static boolean hasTies(double[] x, double[] y) {
throw new InsufficientDataException();
}
- if (values.length == x.length + y.length) {
- return false; // There are no ties.
- }
-
- return true;
+ return values.length != x.length + y.length; // There are no ties.
Review comment:
The comment is then wrong, isn't it? Before it checked if there are no
ties (`values.length == x.length + y.length`) and the comment was related to
the `false` return value. Now it directly checks if there are ties which is
basically the name of the method so that the comment could be simply removed,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 591402)
Time Spent: 40m (was: 0.5h)
> Simplify Conditions
> ---
>
> Key: MATH-1572
> URL: https://issues.apache.org/jira/browse/MATH-1572
> Project: Commons Math
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> * Simplifiable boolean expression
> * Simplifiable conditional expression
> * Redundant 'if' statement
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-dbcp] fgdrf commented on pull request #38: [DBCP-562] avoids exposing password via JMX
fgdrf commented on pull request #38: URL: https://github.com/apache/commons-dbcp/pull/38#issuecomment-829966472 build fails due to API incompatible change: ``` Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.15.3:cmp (default-cli) on project commons-dbcp2: There is at least one incompatibility: org.apache.commons.dbcp2.BasicDataSourceMXBean.getPassword():METHOD_REMOVED -> [Help 1] Error: Error: To see the full stack trace of the errors, re-run Maven with the -e switch. Error: Re-run Maven using the -X switch to enable full debug logging. Error: Error: For more information about the errors and possible solutions, please read the following articles: Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException Error: Process completed with exit code 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (DBCP-562) Password should not be exposed via JMXBean
[ https://issues.apache.org/jira/browse/DBCP-562?focusedWorklogId=591415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591415 ] ASF GitHub Bot logged work on DBCP-562: --- Author: ASF GitHub Bot Created on: 30/Apr/21 09:26 Start Date: 30/Apr/21 09:26 Worklog Time Spent: 10m Work Description: fgdrf commented on pull request #38: URL: https://github.com/apache/commons-dbcp/pull/38#issuecomment-829966472 build fails due to API incompatible change: ``` Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.15.3:cmp (default-cli) on project commons-dbcp2: There is at least one incompatibility: org.apache.commons.dbcp2.BasicDataSourceMXBean.getPassword():METHOD_REMOVED -> [Help 1] Error: Error: To see the full stack trace of the errors, re-run Maven with the -e switch. Error: Re-run Maven using the -X switch to enable full debug logging. Error: Error: For more information about the errors and possible solutions, please read the following articles: Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException Error: Process completed with exit code 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 591415) Time Spent: 1h 10m (was: 1h) > Password should not be exposed via JMXBean > -- > > Key: DBCP-562 > URL: https://issues.apache.org/jira/browse/DBCP-562 > Project: Commons DBCP > Issue Type: Bug >Affects Versions: 2.5.0, 2.7.0 >Reporter: Frank Gasdorf >Priority: Critical > Labels: security > Time Spent: 1h 10m > Remaining Estimate: 0h > > if a BasicDataSource is created with jmxName set, password property is > exposed/exported via jmx and is visible for everybody who is connected to jmx > port. > > Expectation : Do not export it via BasicDataSourceMXBean Interface -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs
jochenw commented on pull request #75: URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829981338 I am hesitant. I am fully aware, that commons-lang (as an example) has a rather exhaustive set of rules, that are asserted by Spotbugs, Checkstyle, etc. On the other hand, I notice that I have a tendency to spend more time dealing with Spotbugs, than with the actual coding, if I work on commons-lang. Besides, I'm a member of the "code style's not that important" faction. (Might be my own problem, because I don't use it frequently enough to become really comfortable.) Perhaps, others might voice an opinion? @garydgregory, @sebbASF, @grobmeier, or @kinow, I'd value your opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?focusedWorklogId=591425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591425
]
ASF GitHub Bot logged work on FILEUPLOAD-323:
-
Author: ASF GitHub Bot
Created on: 30/Apr/21 09:53
Start Date: 30/Apr/21 09:53
Worklog Time Spent: 10m
Work Description: jochenw commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829981338
I am hesitant. I am fully aware, that commons-lang (as an example) has a
rather exhaustive set of rules, that are asserted by Spotbugs, Checkstyle, etc.
On the other hand, I notice that I have a tendency to spend more time dealing
with Spotbugs, than with the actual coding, if I work on commons-lang. Besides,
I'm a member of the "code style's not that important" faction. (Might be my own
problem, because I don't use it frequently enough to become really comfortable.)
Perhaps, others might voice an opinion? @garydgregory, @sebbASF, @grobmeier,
or @kinow, I'd value your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 591425)
Time Spent: 40m (was: 0.5h)
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type
[GitHub] [commons-fileupload] jochenw edited a comment on pull request #75: FILEUPLOAD-323 - Implement spotbugs
jochenw edited a comment on pull request #75: URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829981338 I am hesitant. I am fully aware, that commons-lang (as an example) has a rather exhaustive set of rules, that are asserted by Spotbugs, Checkstyle, etc. On the other hand, I notice that I have a tendency to spend more time dealing with Checkstyle, than with the actual coding, if I work on commons-lang. Besides, I'm a member of the "code style's not that important" faction. (Might be my own problem, because I don't use it frequently enough to become really comfortable.) Perhaps, others might voice an opinion? @garydgregory, @sebbASF, @grobmeier, or @kinow, I'd value your opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?focusedWorklogId=591427&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591427
]
ASF GitHub Bot logged work on FILEUPLOAD-323:
-
Author: ASF GitHub Bot
Created on: 30/Apr/21 09:56
Start Date: 30/Apr/21 09:56
Worklog Time Spent: 10m
Work Description: jochenw edited a comment on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829981338
I am hesitant. I am fully aware, that commons-lang (as an example) has a
rather exhaustive set of rules, that are asserted by Spotbugs, Checkstyle, etc.
On the other hand, I notice that I have a tendency to spend more time dealing
with Checkstyle, than with the actual coding, if I work on commons-lang.
Besides, I'm a member of the "code style's not that important" faction. (Might
be my own problem, because I don't use it frequently enough to become really
comfortable.)
Perhaps, others might voice an opinion? @garydgregory, @sebbASF, @grobmeier,
or @kinow, I'd value your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 591427)
Time Spent: 50m (was: 40m)
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
[jira] [Work logged] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?focusedWorklogId=591428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591428
]
ASF GitHub Bot logged work on FILEUPLOAD-323:
-
Author: ASF GitHub Bot
Created on: 30/Apr/21 09:56
Start Date: 30/Apr/21 09:56
Worklog Time Spent: 10m
Work Description: jochenw merged pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 591428)
Time Spent: 1h (was: 50m)
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type javax.servlet.http.HttpServletRequest
> [org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
> JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.util.Streams.asString(InputStream):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
> DM_DEFAULT_ENCODING
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw merged pull request #75: FILEUPLOAD-323 - Implement spotbugs
jochenw merged pull request #75: URL: https://github.com/apache/commons-fileupload/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #69: FILEUPLOAD-318 - Use try with resource
jochenw commented on pull request #69:
URL: https://github.com/apache/commons-fileupload/pull/69#issuecomment-829994588
I still notice something like
} catch (IOException e) {
throw new IOException("Unexpected input data");
}
Change that to `throw new UncheckedIOException(e)`, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-318) Use try with resource
[
https://issues.apache.org/jira/browse/FILEUPLOAD-318?focusedWorklogId=591432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591432
]
ASF GitHub Bot logged work on FILEUPLOAD-318:
-
Author: ASF GitHub Bot
Created on: 30/Apr/21 10:16
Start Date: 30/Apr/21 10:16
Worklog Time Spent: 10m
Work Description: jochenw commented on pull request #69:
URL: https://github.com/apache/commons-fileupload/pull/69#issuecomment-829994588
I still notice something like
} catch (IOException e) {
throw new IOException("Unexpected input data");
}
Change that to `throw new UncheckedIOException(e)`, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 591432)
Time Spent: 1h 40m (was: 1.5h)
> Use try with resource
> --
>
> Key: FILEUPLOAD-318
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-318
> Project: Commons FileUpload
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Try to use Try with resource in order to avoid deprecated method
> IOUtils.closeQuietly
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-fileupload] kinow commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs
kinow commented on pull request #75: URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-82881 Hi @jochenw I also don't have a strong preference. Most times I just try to remember to read some code in the project I'm working on and mimic the code style. I find SpotBugs/checkstyle/etc helpful when we find a set of rules that allow you to spot simple mistakes, especially those that appear in PR's of first-time contributors, and can be quickly spotted by CI. But agree that some rules can be annoying (e.g. when you wrote a perfectly legible 121 characters line, and checkstyle tells you to reduce in character or add a line break 🤷♂️ ). I think this PR can be a good initial work for spotbugs. We can tweak it so that it doesn't bother you and others when they need to work on the component, whilst also helping you and other devs to keep the code uniform-ish, and filter simple bugs in CI (i.e. feel free to suggest what rules are being helpful or not, what to disable, etc). Just my 0.02 cents :o) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?focusedWorklogId=591434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591434
]
ASF GitHub Bot logged work on FILEUPLOAD-323:
-
Author: ASF GitHub Bot
Created on: 30/Apr/21 10:26
Start Date: 30/Apr/21 10:26
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-82881
Hi @jochenw
I also don't have a strong preference. Most times I just try to remember to
read some code in the project I'm working on and mimic the code style.
I find SpotBugs/checkstyle/etc helpful when we find a set of rules that
allow you to spot simple mistakes, especially those that appear in PR's of
first-time contributors, and can be quickly spotted by CI. But agree that some
rules can be annoying (e.g. when you wrote a perfectly legible 121 characters
line, and checkstyle tells you to reduce in character or add a line break 🤷♂️
).
I think this PR can be a good initial work for spotbugs. We can tweak it so
that it doesn't bother you and others when they need to work on the component,
whilst also helping you and other devs to keep the code uniform-ish, and filter
simple bugs in CI (i.e. feel free to suggest what rules are being helpful or
not, what to disable, etc).
Just my 0.02 cents :o)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 591434)
Time Spent: 1h 10m (was: 1h)
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk
[GitHub] [commons-rng] aherbert opened a new pull request #86: RNG-133: LineSampler to sample uniformly on a line segment
aherbert opened a new pull request #86: URL: https://github.com/apache/commons-rng/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal resolved FILEUPLOAD-323.
--
Resolution: Fixed
In master
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type javax.servlet.http.HttpServletRequest
> [org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
> JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.util.Streams.asString(InputStream):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
> DM_DEFAULT_ENCODING
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-323) Implement spotbugs
[
https://issues.apache.org/jira/browse/FILEUPLOAD-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal closed FILEUPLOAD-323.
> Implement spotbugs
> --
>
> Key: FILEUPLOAD-323
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-323
> Project: Commons FileUpload
> Issue Type: New Feature
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The idea it's use spotbugs in an intend of find or prevents bugs in Java code.
> This Jira it's for keep track and work in the implementations
>
>
> Need to check:
> {code:java}
> [INFO] BugInstance size is 12 [INFO] Error size is 0 [INFO] Total bugs: 12
> [ERROR] High: Found reliance on default encoding in
> org.apache.commons.fileupload2.MultipartStream.readHeaders():
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.MultipartStream,
> org.apache.commons.fileupload2.MultipartStream] At MultipartStream.java:[line
> 592]Another occurrence at MultipartStream.java:[line 595] DM_DEFAULT_ENCODING
> [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.BOUNDARY_PREFIX should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 205] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.FIELD_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 194] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.HEADER_SEPARATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 188] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.MultipartStream.STREAM_TERMINATOR should be
> package protected [org.apache.commons.fileupload2.MultipartStream] At
> MultipartStream.java:[line 200] MS_PKGPROTECT [ERROR] Medium:
> org.apache.commons.fileupload2.ParameterParser.parse(char[], int, int, char)
> may expose internal representation by storing an externally mutable object
> into ParameterParser.chars [org.apache.commons.fileupload2.ParameterParser]
> At ParameterParser.java:[line 302] EI_EXPOSE_REP2 [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.disk.DiskFileItem.getString(): new
> String(byte[]) [org.apache.commons.fileupload2.disk.DiskFileItem] At
> DiskFileItem.java:[line 360] DM_DEFAULT_ENCODING [ERROR] Medium:
> org.apache.commons.fileupload2.disk.DiskFileItem.get() may expose internal
> representation by returning DiskFileItem.cachedContent
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 305] EI_EXPOSE_REP [ERROR] Medium: Exceptional return value of
> java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.delete()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 432] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium: Exceptional return
> value of java.io.File.delete() ignored in
> org.apache.commons.fileupload2.disk.DiskFileItem.finalize()
> [org.apache.commons.fileupload2.disk.DiskFileItem] At DiskFileItem.java:[line
> 550] RV_RETURN_VALUE_IGNORED_BAD_PRACTICE [ERROR] Medium:
> org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload.parseRequest(HttpServletRequest)
> doesn't override method in superclass because parameter type
> jakarta.servlet.http.HttpServletRequest doesn't match superclass parameter
> type javax.servlet.http.HttpServletRequest
> [org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload] At
> JakSrvltFileUpload.java:[line 110] NM_WRONG_PACKAGE [ERROR] High: Found
> reliance on default encoding in
> org.apache.commons.fileupload2.util.Streams.asString(InputStream):
> java.io.ByteArrayOutputStream.toString()
> [org.apache.commons.fileupload2.util.Streams] At Streams.java:[line 142]
> DM_DEFAULT_ENCODING
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-fileupload] jochenw merged pull request #69: FILEUPLOAD-318 - Use try with resource
jochenw merged pull request #69: URL: https://github.com/apache/commons-fileupload/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-318) Use try with resource
[ https://issues.apache.org/jira/browse/FILEUPLOAD-318?focusedWorklogId=591597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591597 ] ASF GitHub Bot logged work on FILEUPLOAD-318: - Author: ASF GitHub Bot Created on: 30/Apr/21 15:47 Start Date: 30/Apr/21 15:47 Worklog Time Spent: 10m Work Description: jochenw merged pull request #69: URL: https://github.com/apache/commons-fileupload/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 591597) Time Spent: 1h 50m (was: 1h 40m) > Use try with resource > -- > > Key: FILEUPLOAD-318 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-318 > Project: Commons FileUpload > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Try to use Try with resource in order to avoid deprecated method > IOUtils.closeQuietly > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RNG-134) BoxSampler to sampler uniformly from a box (or hyperrectangle)
Alex Herbert created RNG-134:
Summary: BoxSampler to sampler uniformly from a box (or
hyperrectangle)
Key: RNG-134
URL: https://issues.apache.org/jira/browse/RNG-134
Project: Commons RNG
Issue Type: New Feature
Components: sampling
Affects Versions: 1.4
Reporter: Alex Herbert
Assignee: Alex Herbert
Create a sampler to sample uniformly within a
[hyperrectangle|https://en.wikipedia.org/wiki/Hyperrectangle].
Alternative names for a hyperrectangle are a box or an orthotope. Below I use
the term box for simplicity and to match the BallSampler for an n-ball.
{code:java}
public abstract class BoxSampler implements
SharedStateSampler {
public static BoxSampler of(double[] a,
double[] b,
UniformRandomProvider rng);
}
{code}
Inputs {{a}} and {{b}} are the minimum and maximum of the box in each dimension.
Sampling can be performed using the same method as the LineSampler but using a
uniform deviate for each dimension (instead of the same deviate for all
dimensions):
{noformat}
p = a + u * (b - a)
= a + ub - ua
= (1 - u)a + ub
{noformat}
This will produce the same results as using an instance of the the
{{ContinuousUniformSampler}} for each dimension with all samplers using a
common RNG.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-rng] coveralls commented on pull request #86: RNG-133: LineSampler to sample uniformly on a line segment
coveralls commented on pull request #86: URL: https://github.com/apache/commons-rng/pull/86#issuecomment-830209176 [](https://coveralls.io/builds/39266780) Coverage increased (+0.009%) to 99.541% when pulling **cc0caf66c06ab33b9ca05a4bf040a52146839bac on aherbert:feature-RNG-133** into **6e346fefff881e9fcc0509a5a0af93283089c53a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FILEUPLOAD-287) Multipart/mixed parts not handled correctly
[
https://issues.apache.org/jira/browse/FILEUPLOAD-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337496#comment-17337496
]
Arturo Bernal commented on FILEUPLOAD-287:
--
HI [~joesephz]
Could you please provide a unit test where is reproduced in order to to
analyze it?
TY
> Multipart/mixed parts not handled correctly
> ---
>
> Key: FILEUPLOAD-287
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-287
> Project: Commons FileUpload
> Issue Type: Bug
>Affects Versions: 1.3.3
>Reporter: Etienne Dethoor
>Priority: Critical
>
> If i submit a request with global header
> {{Content-Type="multipart/mixed;boundary="uuid:5985c43c-16a5-483a-88ff-64602f2a2f3f";charset=UTF-8"}}
> data to a servlet with :
> {code:xml}
> --uuid:5985c43c-16a5-483a-88ff-64602f2a2f3f
> Content-Type: text/plain
> Content-Transfer-Encoding: binary
> Content-ID: myFile
> My_Content_Here
> --uuid:5985c43c-16a5-483a-88ff-64602f2a2f3f
> Content-Type: application/xml
> Content-Transfer-Encoding: binary
> Content-ID: myOtherFileHere
> M_Other_Content_Here
> {code}
> The differents parts are not recognized because of
> {{FileUploadBase.getFieldName()}} method who want a {{Content-Disposition}}
> header for each part of the request.
> The [rfc|https://tools.ietf.org/html/rfc7578#section-4.2] specified that this
> header is mandatory for the {{multipart/form-data}} content-type.
> For the {{multipart/mixed}}, if i well understand, the rfc doesn't say this
> header is mandatory for each parts of the request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FILEUPLOAD-324) Use java9 profile on JDK 9 and later
Arturo Bernal created FILEUPLOAD-324: Summary: Use java9 profile on JDK 9 and later Key: FILEUPLOAD-324 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-324 Project: Commons FileUpload Issue Type: New Feature Reporter: Arturo Bernal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-291) commons-fileupload-1.3.3.jar is missing reference to javax/portlet/ActionRequest to support Java 11
[ https://issues.apache.org/jira/browse/FILEUPLOAD-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337548#comment-17337548 ] Jochen Wiedmann commented on FILEUPLOAD-291: No response from user after three years on an issue, that is purportedly critical. Closing. > commons-fileupload-1.3.3.jar is missing reference to > javax/portlet/ActionRequest to support Java 11 > --- > > Key: FILEUPLOAD-291 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-291 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.3.3 >Reporter: Bonda Pavan Kumar >Priority: Critical > > We are using apache *commons-fileupload-1.3.3.jar* for internal requirements > and this is having potential issues with respect to Java 11 support. On > preliminary analysis, identified that this jar (1.3.3 version) is having a > missing reference to this class *javax/portlet/ActionRequest*. > Can this be prioritized at the earliest? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FILEUPLOAD-324) Use java9 profile on JDK 9 and later
[ https://issues.apache.org/jira/browse/FILEUPLOAD-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337549#comment-17337549 ] Jochen Wiedmann commented on FILEUPLOAD-324: [~arturobernalg] What is this about? What is a java9 profile? > Use java9 profile on JDK 9 and later > > > Key: FILEUPLOAD-324 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-324 > Project: Commons FileUpload > Issue Type: New Feature >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FILEUPLOAD-291) commons-fileupload-1.3.3.jar is missing reference to javax/portlet/ActionRequest to support Java 11
[ https://issues.apache.org/jira/browse/FILEUPLOAD-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Wiedmann closed FILEUPLOAD-291. -- Resolution: Incomplete > commons-fileupload-1.3.3.jar is missing reference to > javax/portlet/ActionRequest to support Java 11 > --- > > Key: FILEUPLOAD-291 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-291 > Project: Commons FileUpload > Issue Type: Bug >Affects Versions: 1.3.3 >Reporter: Bonda Pavan Kumar >Priority: Critical > > We are using apache *commons-fileupload-1.3.3.jar* for internal requirements > and this is having potential issues with respect to Java 11 support. On > preliminary analysis, identified that this jar (1.3.3 version) is having a > missing reference to this class *javax/portlet/ActionRequest*. > Can this be prioritized at the earliest? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (DAEMON-433) support native memory tracking in jsvc
Clément Guillaume created DAEMON-433:
Summary: support native memory tracking in jsvc
Key: DAEMON-433
URL: https://issues.apache.org/jira/browse/DAEMON-433
Project: Commons Daemon
Issue Type: New Feature
Reporter: Clément Guillaume
the {{XX:NativeMemoryTracking}} option needs to be set in a particular way to
work (otherwise you get the error "Native Memory Tracking did not setup
properly, using wrong launcher?")
there has been few email threads about this
https://lists.apache.org/thread.html/80ced30c47c1bceb4ef4e35b7ddc812b54b3079d4aa426ac73838f4f%40%3Cusers.tomcat.apache.org%3E
https://lists.apache.org/thread.html/2a90b1b1c9a8309b92576507464f953d8f5ba6d49183fc700e8f1060%40%3Cuser.commons.apache.org%3E
and I believe support has been added for windows procrun DAEMON-412
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-rng] coveralls edited a comment on pull request #86: RNG-133: LineSampler to sample uniformly on a line segment
coveralls edited a comment on pull request #86: URL: https://github.com/apache/commons-rng/pull/86#issuecomment-830209176 [](https://coveralls.io/builds/39276483) Coverage increased (+0.009%) to 99.541% when pulling **90a4cf8b60973c8970bace9e115cf3cdbc1ee660 on aherbert:feature-RNG-133** into **6e346fefff881e9fcc0509a5a0af93283089c53a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
