[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request #36: Bump actions/setup-java from 1.4.3 to 2.1.0

[GitBox]

dependabot[bot] opened a new pull request #36:
URL: https://github.com/apache/commons-build-plugin/pull/36


   Bumps [actions/setup-java](https://github.com/actions/setup-java) from 1.4.3 
to 2.1.0.
   
   Release notes
   Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's 
releases.
   
   v2.1.0
   Add support for Adopt OpenJDK OpenJ9:
   Supported distributions
   Currently, the following distributions are supported:
   
   
   
   Keyword
   Distribution
   Official site
   License
   
   
   
   
   zulu
   Zulu OpenJDK
   https://www.azul.com/downloads/zulu-community/?package=jdk";>Link
   https://www.azul.com/products/zulu-and-zulu-enterprise/zulu-terms-of-use/";>Link
   
   
   adopt or adopt-hotspot
   Adopt OpenJDK Hotspot
   https://adoptopenjdk.net/";>Link
   https://adoptopenjdk.net/about.html";>Link
   
   
   adopt-openj9
   Adopt OpenJDK OpenJ9
   https://adoptopenjdk.net/";>Link
   https://adoptopenjdk.net/about.html";>Link
   
   
   
   v2.0.0
   The major release actions/setup-java@v2
   See more details in https://github.com/actions/setup-java/blob/main/README.md";>README 
file.
   This action provides the following functionality for GitHub Actions 
runners:
   
   Downloading and setting up a requested version of Java. See https://github.com/actions/setup-java/blob/HEAD/#Usage";>Usage for a 
list of supported distributions
   Extracting and caching custom version of Java from a local file
   Configuring runner for publishing using Apache Maven
   Configuring runner for publishing using Gradle
   Configuring runner for using GPG private key
   Registering problem matchers for error output
   
   V2 vs V1
   
   V2 supports custom distributions and provides support for Zulu OpenJDK 
and Adopt OpenJDK out of the box. V1 supports only Zulu OpenJDK
   V2 requires you to specify distribution along with the version. V1 
defaults to Zulu OpenJDK, only version input is required. Follow https://github.com/actions/setup-java/blob/HEAD/docs/switching-to-v2.md";>the
 migration guide to switch from V1 to V2
   
   Usage
   Inputs java-version and distribution are 
mandatory. See https://github.com/actions/setup-java/blob/README.md#Supported-distributions";>Supported
 distributions section for a list of available options.
   Basic
   Adopt OpenJDK
   steps:
   - uses: actions/checkout@v2
   - uses: actions/setup-java@v2
 with:
   distribution: 'adopt' # See 'Supported distributions' for available 
options
   java-version: '11'
   - run: java -cp java HelloWorldApp
   
   Zulu OpenJDK
   steps:
   - uses: actions/checkout@v2
   - uses: actions/setup-java@v2
 with:
   distribution: 'zulu' # See 'Supported distributions' for available 
options
   java-version: '11'
    
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/actions/setup-java/commit/d9126d7df2f1b080b603441eaf5810ced3614e78";>d9126d7
 Bump hosted-git-info from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/actions/setup-java/issues/178";>#178)
   https://github.com/actions/setup-java/commit/53ac717e09ee911c7c5ac6b51f670384756dafbc";>53ac717
 Improve README and advanced usage guide (https://github-redirect.dependabot.com/actions/setup-java/issues/174";>#174)
   https://github.com/actions/setup-java/commit/cbc183b1c1042817f9819d15402b42b38bf7b7b9";>cbc183b
 Added 'adopt-hotspot' and 'adopt-openj9' (https://github-redirect.dependabot.com/actions/setup-java/issues/155";>#155)
   https://github.com/actions/setup-java/commit/0443912ed73df2ee8596160daba017daab1c8ca9";>0443912
 Fix typo in documentation "jdkfile" (https://github-redirect.dependabot.com/actions/setup-java/issues/167";>#167)
   https://github.com/actions/setup-java/commit/56b2808da7b1e33196293b0b9709698c7b2b8199";>56b2808
 Fix typo on distribution "jdkfile" (https://github-redirect.dependabot.com/actions/setup-java/issues/163";>#163)
   https://github.com/actions/setup-java/commit/00401c44888c9399df79fa4c83ebb874ecc3d04c";>00401c4
 add cron for e2e tests, twice a day (https://github-redirect.dependabot.com/actions/setup-java/issues/162";>#162)
   https://github.com/actions/setup-java/commit/1e063f2878e6facb4a1c1348a20a57e1484cc3ef";>1e063f2
 Fix navigation issue of supported distributions (https://github-redirect.dependabot.com/actions/setup-java/issues/153";>#153)
   https://github.com/actions/setup-java/commit/8764a52df183aa0ccea74521dfd9d506ffc7a19a";>8764a52
 Rename v2-preview to v2 in docs and tests (https://github-redirect.dependabot.com/actions/setup-java/issues/151";>#151)
   https://github.com/actions/setup-java/commit/b53500dabc37db6cc1dcd35059bdcd85df25d140";>b53500d
 Merge "v2-preview" branch into "main" (https://github-redirect.dependabot.com/actions/setup-java/issues/150";>#150)
   https://github.com/actions/setup-java/commit/ebb424f2cb8fcb418a7b62a00e052ee78fc9ed68";>ebb424f
 Beatify "main" warning about breaking changes (https://github-redirect.dependabot.com/actions/s

[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #35: Bump actions/setup-java from 1.4.3 to 2

[GitBox]

dependabot[bot] closed pull request #35:
URL: https://github.com/apache/commons-build-plugin/pull/35


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #35: Bump actions/setup-java from 1.4.3 to 2

[GitBox]

dependabot[bot] commented on pull request #35:
URL: 
https://github.com/apache/commons-build-plugin/pull/35#issuecomment-842851599


   Superseded by #36.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-beanutils] dependabot[bot] closed pull request #86: Bump actions/setup-java from 1.4.3 to 2

[GitBox]

dependabot[bot] closed pull request #86:
URL: https://github.com/apache/commons-beanutils/pull/86


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-beanutils] dependabot[bot] commented on pull request #86: Bump actions/setup-java from 1.4.3 to 2

[GitBox]

dependabot[bot] commented on pull request #86:
URL: https://github.com/apache/commons-beanutils/pull/86#issuecomment-842851055


   Superseded by #88.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-beanutils] dependabot[bot] opened a new pull request #88: Bump actions/setup-java from 1.4.3 to 2.1.0

[GitBox]

dependabot[bot] opened a new pull request #88:
URL: https://github.com/apache/commons-beanutils/pull/88


   Bumps [actions/setup-java](https://github.com/actions/setup-java) from 1.4.3 
to 2.1.0.
   
   Release notes
   Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's 
releases.
   
   v2.1.0
   Add support for Adopt OpenJDK OpenJ9:
   Supported distributions
   Currently, the following distributions are supported:
   
   
   
   Keyword
   Distribution
   Official site
   License
   
   
   
   
   zulu
   Zulu OpenJDK
   https://www.azul.com/downloads/zulu-community/?package=jdk";>Link
   https://www.azul.com/products/zulu-and-zulu-enterprise/zulu-terms-of-use/";>Link
   
   
   adopt or adopt-hotspot
   Adopt OpenJDK Hotspot
   https://adoptopenjdk.net/";>Link
   https://adoptopenjdk.net/about.html";>Link
   
   
   adopt-openj9
   Adopt OpenJDK OpenJ9
   https://adoptopenjdk.net/";>Link
   https://adoptopenjdk.net/about.html";>Link
   
   
   
   v2.0.0
   The major release actions/setup-java@v2
   See more details in https://github.com/actions/setup-java/blob/main/README.md";>README 
file.
   This action provides the following functionality for GitHub Actions 
runners:
   
   Downloading and setting up a requested version of Java. See https://github.com/actions/setup-java/blob/HEAD/#Usage";>Usage for a 
list of supported distributions
   Extracting and caching custom version of Java from a local file
   Configuring runner for publishing using Apache Maven
   Configuring runner for publishing using Gradle
   Configuring runner for using GPG private key
   Registering problem matchers for error output
   
   V2 vs V1
   
   V2 supports custom distributions and provides support for Zulu OpenJDK 
and Adopt OpenJDK out of the box. V1 supports only Zulu OpenJDK
   V2 requires you to specify distribution along with the version. V1 
defaults to Zulu OpenJDK, only version input is required. Follow https://github.com/actions/setup-java/blob/HEAD/docs/switching-to-v2.md";>the
 migration guide to switch from V1 to V2
   
   Usage
   Inputs java-version and distribution are 
mandatory. See https://github.com/actions/setup-java/blob/README.md#Supported-distributions";>Supported
 distributions section for a list of available options.
   Basic
   Adopt OpenJDK
   steps:
   - uses: actions/checkout@v2
   - uses: actions/setup-java@v2
 with:
   distribution: 'adopt' # See 'Supported distributions' for available 
options
   java-version: '11'
   - run: java -cp java HelloWorldApp
   
   Zulu OpenJDK
   steps:
   - uses: actions/checkout@v2
   - uses: actions/setup-java@v2
 with:
   distribution: 'zulu' # See 'Supported distributions' for available 
options
   java-version: '11'
    
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/actions/setup-java/commit/d9126d7df2f1b080b603441eaf5810ced3614e78";>d9126d7
 Bump hosted-git-info from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/actions/setup-java/issues/178";>#178)
   https://github.com/actions/setup-java/commit/53ac717e09ee911c7c5ac6b51f670384756dafbc";>53ac717
 Improve README and advanced usage guide (https://github-redirect.dependabot.com/actions/setup-java/issues/174";>#174)
   https://github.com/actions/setup-java/commit/cbc183b1c1042817f9819d15402b42b38bf7b7b9";>cbc183b
 Added 'adopt-hotspot' and 'adopt-openj9' (https://github-redirect.dependabot.com/actions/setup-java/issues/155";>#155)
   https://github.com/actions/setup-java/commit/0443912ed73df2ee8596160daba017daab1c8ca9";>0443912
 Fix typo in documentation "jdkfile" (https://github-redirect.dependabot.com/actions/setup-java/issues/167";>#167)
   https://github.com/actions/setup-java/commit/56b2808da7b1e33196293b0b9709698c7b2b8199";>56b2808
 Fix typo on distribution "jdkfile" (https://github-redirect.dependabot.com/actions/setup-java/issues/163";>#163)
   https://github.com/actions/setup-java/commit/00401c44888c9399df79fa4c83ebb874ecc3d04c";>00401c4
 add cron for e2e tests, twice a day (https://github-redirect.dependabot.com/actions/setup-java/issues/162";>#162)
   https://github.com/actions/setup-java/commit/1e063f2878e6facb4a1c1348a20a57e1484cc3ef";>1e063f2
 Fix navigation issue of supported distributions (https://github-redirect.dependabot.com/actions/setup-java/issues/153";>#153)
   https://github.com/actions/setup-java/commit/8764a52df183aa0ccea74521dfd9d506ffc7a19a";>8764a52
 Rename v2-preview to v2 in docs and tests (https://github-redirect.dependabot.com/actions/setup-java/issues/151";>#151)
   https://github.com/actions/setup-java/commit/b53500dabc37db6cc1dcd35059bdcd85df25d140";>b53500d
 Merge "v2-preview" branch into "main" (https://github-redirect.dependabot.com/actions/setup-java/issues/150";>#150)
   https://github.com/actions/setup-java/commit/ebb424f2cb8fcb418a7b62a00e052ee78fc9ed68";>ebb424f
 Beatify "main" warning about breaking changes (https://github-redirect.dependabot.com/actions/setu

[GitHub] [commons-rng] coveralls edited a comment on pull request #89: RNG-136: Add ObjectSampler and SharedStateObjectSampler interfaces

[GitBox]

coveralls edited a comment on pull request #89:
URL: https://github.com/apache/commons-rng/pull/89#issuecomment-842617274


   
   [![Coverage 
Status](https://coveralls.io/builds/39757512/badge)](https://coveralls.io/builds/39757512)
   
   Coverage increased (+0.0001%) to 99.554% when pulling 
**6f0ea6b082b2a406c51abc7ce2125706b2d7bb4e on aherbert:feature-RNG-136** into 
**d36538538e0dd425e365c8b9b2e39d93a4a10f41 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-rng] coveralls edited a comment on pull request #89: RNG-136: Add ObjectSampler and SharedStateObjectSampler interfaces

[GitBox]

coveralls edited a comment on pull request #89:
URL: https://github.com/apache/commons-rng/pull/89#issuecomment-842617274


   
   [![Coverage 
Status](https://coveralls.io/builds/39757302/badge)](https://coveralls.io/builds/39757302)
   
   Coverage increased (+0.0001%) to 99.554% when pulling 
**6f0ea6b082b2a406c51abc7ce2125706b2d7bb4e on aherbert:feature-RNG-136** into 
**d36538538e0dd425e365c8b9b2e39d93a4a10f41 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-rng] coveralls commented on pull request #89: RNG-136: Add ObjectSampler and SharedStateObjectSampler interfaces

[GitBox]

coveralls commented on pull request #89:
URL: https://github.com/apache/commons-rng/pull/89#issuecomment-842617274


   
   [![Coverage 
Status](https://coveralls.io/builds/39757302/badge)](https://coveralls.io/builds/39757302)
   
   Coverage increased (+0.0002%) to 99.554% when pulling 
**6f0ea6b082b2a406c51abc7ce2125706b2d7bb4e on aherbert:feature-RNG-136** into 
**d36538538e0dd425e365c8b9b2e39d93a4a10f41 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-rng] aherbert opened a new pull request #89: RNG-136: Add ObjectSampler and SharedStateObjectSampler interfaces

[GitBox]

aherbert opened a new pull request #89:
URL: https://github.com/apache/commons-rng/pull/89


   Add generic ObjectSampler interfaces. These are the object typed equivalent 
to the DiscreteSampler and SharedStateDiscreteSampler interfaces (which return 
samples of int).
   
   Deprecate the UnitSphereSampler.nextVector method. It is replaced by the
   ObjectSampler.sample method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (IO-732) Char equivalent of UnsynchronizedByteArrayOutputStream (and InputStream)

[PJ Fanning (Jira)]

PJ Fanning created IO-732:
-

 Summary: Char equivalent of UnsynchronizedByteArrayOutputStream 
(and InputStream)
 Key: IO-732
 URL: https://issues.apache.org/jira/browse/IO-732
 Project: Commons IO
  Issue Type: New Feature
  Components: Streams/Writers
Affects Versions: 2.8.0
Reporter: PJ Fanning


I was thinking of writing this and submitting it but just want to see if people 
think it makes sense first.

The idea is to take AbstractByteArrayOutputStream and to replace the byte[] 
with char[] (maybe called AbstractStringWriter) and to create an 
UnsynchronizedStringWriter that extends it. Could so something similar with 
UnsynchronizedByteArrayInputStream - to get an UnsynchronizedStringReader.

The nice thing about AbstractByteArrayOutputStream is the way it avoids 
arraycopy. The existing commons-io StringBuilderWriter still has arraycopy 
under the hood (in the java.lang.StringBuilder).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (RNG-136) ObjectSampler and SharedStateObjectSampler interfaces

[Alex Herbert (Jira)]

 [ 
https://issues.apache.org/jira/browse/RNG-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Herbert updated RNG-136:
-
Description: 
The sampling package currently contains interfaces for creating int and double 
samples and their extensions to implement the SharedStateSampler interface:
{code:java}
public interface DiscreteSampler {
int sample();
}
public interface SharedStateDiscreteSampler
extends DiscreteSampler, SharedStateSampler {
// Composite interface
}
public interface ContinuousSampler {
double sample();
}
public interface SharedStateContinuousSampler
extends ContinuousSampler, SharedStateSampler 
{
// Composite interface
}
{code}
Add a matching ObjectSampler interface for all samplers that create objects:
{code:java}
public interface ObjectSampler {
T sample();
}
public interface SharedStateObjectSampler extends
ObjectSampler,
SharedStateSampler> {
// Composite interface
}
{code}
Samplers currently returning an object should implement the new interface:
{code:java}
int[] CombinationSampler.sample()
int[] PermutationSampler.sample()
double[] UnitVectorSampler.nextVector()
T CollectionSampler.sample()
T DiscreteProbabilityCollectionSampler.sample()
double[] BoxSampler.sample()
double[] LineSampler.sample()
double[] TriangleSampler.sample()
double[] TetrahedronSampler.sample()
double[] UnitBallSampler.sample()
{code}
Only the UnitVectorSampler will require a new {{sample}} method. The current 
{{nextVector}} method can be marked deprecated.

  was:
The sampling package currently contains interfaces for creating int and double 
samples and their extensions to implement the SharedStateSampler interface:
{code:java}
public interface DiscreteSampler {
int sample();
}
public interface SharedStateDiscreteSampler
extends DiscreteSampler, SharedStateSampler {
// Composite interface
}
public interface ContinuousSampler {
double sample();
}
public interface SharedStateContinuousSampler
extends ContinuousSampler, SharedStateSampler 
{
// Composite interface
}
{code}
Add a matching ObjectSampler interface for all samplers that create objects:
{code:java}
public interface ObjectSampler {
T sample();
}
public interface SharedStateObjectSampler extends
ObjectSampler,
SharedStateSampler> {
// Composite interface
}
{code}
Samplers currently returning an object should implement the new interface:
{code:java}
double[] CombinationSampler.sample()
double[] PermutationSampler.sample()
double[] UnitVectorSampler.nextVector()
T CollectionSampler.sample()
T DiscreteProbabilityCollectionSampler.sample()
double[] BoxSampler.sample()
double[] LineSampler.sample()
double[] TriangleSampler.sample()
double[] TetrahedronSampler.sample()
double[] UnitBallSampler.sample()
{code}
Only the UnitVectorSampler will require a new {{sample}} method. The current 
{{nextVector}} method can be marked deprecated.


> ObjectSampler and SharedStateObjectSampler interfaces
> ---
>
> Key: RNG-136
> URL: https://issues.apache.org/jira/browse/RNG-136
> Project: Commons RNG
>  Issue Type: New Feature
>  Components: sampling
>Affects Versions: 1.4
>Reporter: Alex Herbert
>Assignee: Alex Herbert
>Priority: Major
>
> The sampling package currently contains interfaces for creating int and 
> double samples and their extensions to implement the SharedStateSampler 
> interface:
> {code:java}
> public interface DiscreteSampler {
> int sample();
> }
> public interface SharedStateDiscreteSampler
> extends DiscreteSampler, SharedStateSampler {
> // Composite interface
> }
> public interface ContinuousSampler {
> double sample();
> }
> public interface SharedStateContinuousSampler
> extends ContinuousSampler, 
> SharedStateSampler {
> // Composite interface
> }
> {code}
> Add a matching ObjectSampler interface for all samplers that create objects:
> {code:java}
> public interface ObjectSampler {
> T sample();
> }
> public interface SharedStateObjectSampler extends
> ObjectSampler,
> SharedStateSampler> {
> // Composite interface
> }
> {code}
> Samplers currently returning an object should implement the new interface:
> {code:java}
> int[] CombinationSampler.sample()
> int[] PermutationSampler.sample()
> double[] UnitVectorSampler.nextVector()
> T CollectionSampler.sample()
> T DiscreteProbabilityCollectionSampler.sample()
> double[] BoxSampler.sample()
> double[] LineSampler.sample()
> double[] TriangleSampler.sample()
> double[] TetrahedronSampler.sample()
> double[] UnitBallSampler.sample()
> {code}
> Only the UnitVectorSampler will require a new {{sample}} method. The current 
> {{nextVector}} method can be marked deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (COMPRESS-542) Corrupt 7z allocates huge amount of SevenZEntries

[Robin Schimpf (Jira)]

[ 
https://issues.apache.org/jira/browse/COMPRESS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346406#comment-17346406
 ] 

Robin Schimpf commented on COMPRESS-542:


Didn't have the time for a close look but just running the test and see it go 
down to ~100ms is impressive. Great work!

> Corrupt 7z allocates huge amount of SevenZEntries
> -
>
> Key: COMPRESS-542
> URL: https://issues.apache.org/jira/browse/COMPRESS-542
> Project: Commons Compress
>  Issue Type: Bug
>Affects Versions: 1.20
>Reporter: Robin Schimpf
>Priority: Major
> Attachments: 
> Reduced_memory_allocation_for_corrupted_7z_archives.patch, 
> endheadercorrupted.7z, endheadercorrupted2.7z
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> We ran into a problem where a 1.43GB corrupt 7z file tried to allocate about 
> 138 million SevenZArchiveEntries which will use about 12GB of memory. Sadly 
> I'm unable to share the file. If you have enough Memory available the 
> following exception is thrown.
> {code:java}
> java.io.IOException: Start header corrupt and unable to guess end Header
>   at 
> org.apache.commons.compress.archivers.sevenz.SevenZFile.tryToLocateEndHeader(SevenZFile.java:511)
>   at 
> org.apache.commons.compress.archivers.sevenz.SevenZFile.readHeaders(SevenZFile.java:470)
>   at 
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:336)
>   at 
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:128)
>   at 
> org.apache.commons.compress.archivers.sevenz.SevenZFile.(SevenZFile.java:369)
> {code}
> 7z itself aborts really quick when I'm trying to list the content of the file.
> {code:java}
> 7z l "corrupt.7z"
> 7-Zip 18.01 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2018-01-28
> Scanning the drive for archives:
> 1 file, 1537752212 bytes (1467 MiB)
> Listing archive: corrupt.7z
> ERROR: corrupt.7z : corrupt.7z
> Open ERROR: Can not open the file as [7z] archive
> ERRORS:
> Is not archive
> Errors: 1
> {code}
> I hacked together the attached patch which will reduce the memory allocation 
> to about 1GB. So lazy instantiation of the entries could be a good solution 
> to the problem. Optimal would be to only create the entries if the headers 
> could be parsed correctly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-codec] coveralls edited a comment on pull request #85: CODEC-301: BaseNCodec: Reduce byte[] allocations by reusing buffers

[GitBox]

coveralls edited a comment on pull request #85:
URL: https://github.com/apache/commons-codec/pull/85#issuecomment-837456691


   
   [![Coverage 
Status](https://coveralls.io/builds/39753862/badge)](https://coveralls.io/builds/39753862)
   
   Coverage increased (+0.005%) to 94.647% when pulling 
**f083ff75869a2e312774ea9c90eb15a8ab1a6592 on 
apinske:bugfix/base64_allocations** into 
**a7c5af95a731b2a3a1baa6454f4c63ae30f719ec on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-text] kinow closed pull request #232: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

kinow closed pull request #232:
URL: https://github.com/apache/commons-text/pull/232


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] coveralls commented on pull request #134: Bump junit-bom from 5.7.0 to 5.7.2

[GitBox]

coveralls commented on pull request #134:
URL: https://github.com/apache/commons-crypto/pull/134#issuecomment-842062635






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] coveralls commented on pull request #234: Simplify Assertions

[GitBox]

coveralls commented on pull request #234:
URL: https://github.com/apache/commons-io/pull/234#issuecomment-842525185


   
   [![Coverage 
Status](https://coveralls.io/builds/39753265/badge)](https://coveralls.io/builds/39753265)
   
   Coverage decreased (-0.1%) to 89.255% when pulling 
**cb342e84fa1feebd23fb4c42abf5a7aea7ace417 on 
arturobernalg:feature/simplifyAssertions** into 
**e569d0f76924502007ba838dded7d5fdfcedd578 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] coveralls commented on pull request #151: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #151:
URL: https://github.com/apache/commons-imaging/pull/151#issuecomment-842022131


   
   [![Coverage 
Status](https://coveralls.io/builds/39731415/badge)](https://coveralls.io/builds/39731415)
   
   Coverage remained the same at 76.665% when pulling 
**ae3fead7de65a7de276a45a2a4537f5d783b2fde on 
dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.2** into 
**535a83e7ca598678114617697aa81cd2d4b558f0 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-codec] aherbert commented on pull request #85: CODEC-301: BaseNCodec: Reduce byte[] allocations by reusing buffers

[GitBox]

aherbert commented on pull request #85:
URL: https://github.com/apache/commons-codec/pull/85#issuecomment-841841625


   Hi @apinske, the changes look good. I've added a suggestion to address the 
issue with not reading the length requested by the user. Can you check this and 
see if it addresses the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #761: Bump junit-bom from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #761:
URL: https://github.com/apache/commons-lang/pull/761#issuecomment-842022598


   
   [![Coverage 
Status](https://coveralls.io/builds/39731358/badge)](https://coveralls.io/builds/39731358)
   
   Coverage remained the same at 94.927% when pulling 
**73d1ee4ea7be060a8e16260da3bcb23cd01973f4 on 
dependabot/maven/org.junit-junit-bom-5.7.2** into 
**c893f5d3ae90d5060db044ee3d0c79f36aea9511 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] coveralls commented on pull request #232: Bump junit-bom from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #232:
URL: https://github.com/apache/commons-io/pull/232#issuecomment-842027610


   
   [![Coverage 
Status](https://coveralls.io/builds/39731589/badge)](https://coveralls.io/builds/39731589)
   
   Coverage decreased (-0.1%) to 89.255% when pulling 
**956bca39c80e1b8d9cda6a8a5407b458cec4bcc2 on 
dependabot/maven/org.junit-junit-bom-5.7.2** into 
**50bfa728a8852149cfe33bf7e53136e269ec9b74 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-collections] kinow closed pull request #236: Bump commons.junit.version from 5.7.1 to 5.7.2

[GitBox]

kinow closed pull request #236:
URL: https://github.com/apache/commons-collections/pull/236


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #30: Bump spotbugs from 4.2.2 to 4.2.3

[GitBox]

dependabot[bot] commented on pull request #30:
URL: 
https://github.com/apache/commons-build-plugin/pull/30#issuecomment-841892686


   Looks like com.github.spotbugs:spotbugs is up-to-date now, so this is no 
longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] coveralls edited a comment on pull request #221: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

[GitBox]

coveralls edited a comment on pull request #221:
URL: https://github.com/apache/commons-io/pull/221#issuecomment-816807362






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] kinow closed pull request #151: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

kinow closed pull request #151:
URL: https://github.com/apache/commons-imaging/pull/151


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] LeeKyoungIl commented on pull request #760: ObjectUtils: Add nullSafeEquals method for Object compare.

[GitBox]

LeeKyoungIl commented on pull request #760:
URL: https://github.com/apache/commons-lang/pull/760#issuecomment-841902039


   @garydgregory 
   Hi! 
   
   In my personal opinion, reflectionEquals is uncomfortable to use, but you 
can close it if you think it is similar.
   Thanks. !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (LANG-1572) implement TODO in CharSequenceUtils.indexOf : remake it.

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/LANG-1572?focusedWorklogId=598109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598109
 ]

ASF GitHub Bot logged work on LANG-1572:


Author: ASF GitHub Bot
Created on: 17/May/21 18:33
Start Date: 17/May/21 18:33
Worklog Time Spent: 10m 
  Work Description: aherbert commented on a change in pull request #560:
URL: https://github.com/apache/commons-lang/pull/560#discussion_r633049410



##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -133,24 +133,87 @@ static int indexOf(final CharSequence cs, final int 
searchChar, int start) {
  * @param start the start index
  * @return the index where the search sequence was found
  */
-static int indexOf(final CharSequence cs, final CharSequence searchChar, 
final int start) {
-if (cs instanceof String) {
-return ((String) cs).indexOf(searchChar.toString(), start);
-} else if (cs instanceof StringBuilder) {
-return ((StringBuilder) cs).indexOf(searchChar.toString(), start);
-} else if (cs instanceof StringBuffer) {
-return ((StringBuffer) cs).indexOf(searchChar.toString(), start);
-}
-return cs.toString().indexOf(searchChar.toString(), start);
-//if (cs instanceof String && searchChar instanceof String) {
-//// TODO: Do we assume searchChar is usually relatively small;
-////   If so then calling toString() on it is better than 
reverting to
-////   the green implementation in the else block
-//return ((String) cs).indexOf((String) searchChar, start);
-//} else {
-//// TODO: Implement rather than convert to String
-//return cs.toString().indexOf(searchChar.toString(), start);
-//}
+static int indexOf(final CharSequence cs, final CharSequence searchChar, 
int start) {
+// if searchChar is a String, and cs is some specific kind of 
AbstractString,
+//   which both have a indexOf function and widely used by normal java 
codes,
+// then we just invoke their indexOf function.
+if (searchChar instanceof String) {
+if (cs instanceof String) {
+return ((String) cs).indexOf((String) searchChar, start);
+} else if (cs instanceof StringBuilder) {
+return ((StringBuilder) cs).indexOf((String) searchChar, 
start);
+} else if (cs instanceof StringBuffer) {
+return ((StringBuffer) cs).indexOf((String) searchChar, start);
+}
+}
+
+int len1 = cs.length();
+int len2 = searchChar.length();
+
+// successful-result >= 0
+if (start < 0) {
+start = 0;
+}
+
+
+// successful-result <= len1
+if (start > len1) {
+start = len1;
+}
+
+// if len2 == 0 return directly.
+if (len2 == 0) {
+return start;
+}
+
+// limit means the largest possible value of successful-result
+final int limit = len1 - len2;
+
+// if start > limit, then have no enough length for a search,
+//   thus cannot find a index, thus fail.
+// if len2 < 0, then it is illegal for this function.
+// if limit < 0, then it means len2 > len1, thus fail.
+if (start > limit || len2 < 0 || limit < 0) {
+return -1;
+}
+
+// notice that when we enter here, we make sure:
+// start in [0, limit]
+// limit in [0, len1-1]
+// len2 in [1, len1]
+
+// if len2 is small enough, and cs is some specific kind of 
AbstractString,
+//   which both have a indexOf function and widely used by normal java 
codes,
+// then we just invoke their indexOf function.
+if (len2 <= TO_STRING_LIMIT) {
+if (cs instanceof String) {
+return ((String) cs).indexOf(searchChar.toString(), start);
+} else if (cs instanceof StringBuilder) {
+return ((StringBuilder) cs).indexOf(searchChar.toString(), 
start);
+} else if (cs instanceof StringBuffer) {
+return ((StringBuffer) cs).indexOf(searchChar.toString(), 
start);
+}
+}
+
+char char0 = searchChar.charAt(0);
+
+int i = start;
+while (true) {

Review comment:
   No need for the ugly double while loop:
   ```java
   for (int i = start; i <= limit; i++) {
   if (cs.charAt(i) == char0 && checkLaterThan1(cs, searchChar, len2, i)) {
   return i;
   }
   }
   return -1;
   ```

##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -133,24 +133,87 @@ static int indexOf(final CharSequence cs, final int 
searchChar, int start) {
  * @param sta

[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #31: Bump spotbugs-maven-plugin from 4.2.0 to 4.2.3

[GitBox]

dependabot[bot] closed pull request #31:
URL: https://github.com/apache/commons-build-plugin/pull/31


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] aherbert commented on a change in pull request #560: [LANG-1572] green implementation CharSequenceUtils.indexOf

[GitBox]

aherbert commented on a change in pull request #560:
URL: https://github.com/apache/commons-lang/pull/560#discussion_r633049410



##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -133,24 +133,87 @@ static int indexOf(final CharSequence cs, final int 
searchChar, int start) {
  * @param start the start index
  * @return the index where the search sequence was found
  */
-static int indexOf(final CharSequence cs, final CharSequence searchChar, 
final int start) {
-if (cs instanceof String) {
-return ((String) cs).indexOf(searchChar.toString(), start);
-} else if (cs instanceof StringBuilder) {
-return ((StringBuilder) cs).indexOf(searchChar.toString(), start);
-} else if (cs instanceof StringBuffer) {
-return ((StringBuffer) cs).indexOf(searchChar.toString(), start);
-}
-return cs.toString().indexOf(searchChar.toString(), start);
-//if (cs instanceof String && searchChar instanceof String) {
-//// TODO: Do we assume searchChar is usually relatively small;
-////   If so then calling toString() on it is better than 
reverting to
-////   the green implementation in the else block
-//return ((String) cs).indexOf((String) searchChar, start);
-//} else {
-//// TODO: Implement rather than convert to String
-//return cs.toString().indexOf(searchChar.toString(), start);
-//}
+static int indexOf(final CharSequence cs, final CharSequence searchChar, 
int start) {
+// if searchChar is a String, and cs is some specific kind of 
AbstractString,
+//   which both have a indexOf function and widely used by normal java 
codes,
+// then we just invoke their indexOf function.
+if (searchChar instanceof String) {
+if (cs instanceof String) {
+return ((String) cs).indexOf((String) searchChar, start);
+} else if (cs instanceof StringBuilder) {
+return ((StringBuilder) cs).indexOf((String) searchChar, 
start);
+} else if (cs instanceof StringBuffer) {
+return ((StringBuffer) cs).indexOf((String) searchChar, start);
+}
+}
+
+int len1 = cs.length();
+int len2 = searchChar.length();
+
+// successful-result >= 0
+if (start < 0) {
+start = 0;
+}
+
+
+// successful-result <= len1
+if (start > len1) {
+start = len1;
+}
+
+// if len2 == 0 return directly.
+if (len2 == 0) {
+return start;
+}
+
+// limit means the largest possible value of successful-result
+final int limit = len1 - len2;
+
+// if start > limit, then have no enough length for a search,
+//   thus cannot find a index, thus fail.
+// if len2 < 0, then it is illegal for this function.
+// if limit < 0, then it means len2 > len1, thus fail.
+if (start > limit || len2 < 0 || limit < 0) {
+return -1;
+}
+
+// notice that when we enter here, we make sure:
+// start in [0, limit]
+// limit in [0, len1-1]
+// len2 in [1, len1]
+
+// if len2 is small enough, and cs is some specific kind of 
AbstractString,
+//   which both have a indexOf function and widely used by normal java 
codes,
+// then we just invoke their indexOf function.
+if (len2 <= TO_STRING_LIMIT) {
+if (cs instanceof String) {
+return ((String) cs).indexOf(searchChar.toString(), start);
+} else if (cs instanceof StringBuilder) {
+return ((StringBuilder) cs).indexOf(searchChar.toString(), 
start);
+} else if (cs instanceof StringBuffer) {
+return ((StringBuffer) cs).indexOf(searchChar.toString(), 
start);
+}
+}
+
+char char0 = searchChar.charAt(0);
+
+int i = start;
+while (true) {

Review comment:
   No need for the ugly double while loop:
   ```java
   for (int i = start; i <= limit; i++) {
   if (cs.charAt(i) == char0 && checkLaterThan1(cs, searchChar, len2, i)) {
   return i;
   }
   }
   return -1;
   ```

##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -133,24 +133,87 @@ static int indexOf(final CharSequence cs, final int 
searchChar, int start) {
  * @param start the start index
  * @return the index where the search sequence was found
  */
-static int indexOf(final CharSequence cs, final CharSequence searchChar, 
final int start) {
-if (cs instanceof String) {
-return ((String) cs).indexOf(searchChar.toString(), start);
-} else if (cs instanceof StringBuilder) {
-return ((StringBuilder) cs).indexOf(searchChar.toString(), sta

[GitHub] [commons-lang] garydgregory commented on pull request #760: ObjectUtils: Add nullSafeEquals method for Object compare.

[GitBox]

garydgregory commented on pull request #760:
URL: https://github.com/apache/commons-lang/pull/760#issuecomment-841833580


   Hi @LeeKyoungIl 
   This seems redundant with 
https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-collections] coveralls commented on pull request #236: Bump commons.junit.version from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #236:
URL: 
https://github.com/apache/commons-collections/pull/236#issuecomment-842020921


   
   [![Coverage 
Status](https://coveralls.io/builds/39731312/badge)](https://coveralls.io/builds/39731312)
   
   Coverage increased (+0.03%) to 90.142% when pulling 
**14b6228a2d2b17e5754ca698c81551a3d88e45b9 on 
dependabot/maven/commons.junit.version-5.7.2** into 
**a95f0eb816e6b7bb3736ffc0c083912a22e9cee9 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] arturobernalg closed pull request #212: Check Any null and Not Negative values

[GitBox]

arturobernalg closed pull request #212:
URL: https://github.com/apache/commons-io/pull/212


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #31: Bump spotbugs-maven-plugin from 4.2.0 to 4.2.3

[GitBox]

dependabot[bot] commented on pull request #31:
URL: 
https://github.com/apache/commons-build-plugin/pull/31#issuecomment-841892685


   Looks like com.github.spotbugs:spotbugs-maven-plugin is up-to-date now, so 
this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-429) ByteArrayOutputStream can overflow

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-429?focusedWorklogId=598072&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598072
 ]

ASF GitHub Bot logged work on IO-429:
-

Author: ASF GitHub Bot
Created on: 17/May/21 18:29
Start Date: 17/May/21 18:29
Worklog Time Spent: 10m 
  Work Description: garydgregory closed pull request #175:
URL: https://github.com/apache/commons-io/pull/175


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 598072)
Time Spent: 3h 20m  (was: 3h 10m)

> ByteArrayOutputStream can overflow
> --
>
> Key: IO-429
> URL: https://issues.apache.org/jira/browse/IO-429
> Project: Commons IO
>  Issue Type: Bug
>  Components: Utilities
>Reporter: Fabian Lange
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> There are many places involved in the problem, and a good fix might be 
> problematic performance wise.
> For example:
> IOUtils.toByteArray(InputStream input) invoked with a Stream which feeds more 
> than Integer.MAX_VALUE bytes will either crash with 
> NegativeArraySizeException or maybe worse overflow in such a way that it 
> returns fine (but only with partial data)
> The ByteArrayOutputStream will happily consume the full stream but "int 
> count" will overflow. At some point then toByteArray is invoked which will do 
> like new byte[count].
> maybe "needNewBuffer" can throw the IllegalArgumentException, as it gets  the 
> count and could check for the overflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-io] garydgregory closed pull request #175: IO-429: Check for long streams in IOUtils.toByteArray

[GitBox]

garydgregory closed pull request #175:
URL: https://github.com/apache/commons-io/pull/175


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #30: Bump spotbugs from 4.2.2 to 4.2.3

[GitBox]

dependabot[bot] closed pull request #30:
URL: https://github.com/apache/commons-build-plugin/pull/30


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] coveralls commented on pull request #233: Minor improvements:

[GitBox]

coveralls commented on pull request #233:
URL: https://github.com/apache/commons-io/pull/233#issuecomment-842043707


   
   [![Coverage 
Status](https://coveralls.io/builds/39732123/badge)](https://coveralls.io/builds/39732123)
   
   Coverage decreased (-0.1%) to 89.255% when pulling 
**3f458ca8562f5abc77b47979bc5ff226e4e4712f on 
arturobernalg:feature/minor_improvement** into 
**50bfa728a8852149cfe33bf7e53136e269ec9b74 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory commented on a change in pull request #221: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

[GitBox]

garydgregory commented on a change in pull request #221:
URL: https://github.com/apache/commons-io/pull/221#discussion_r633126756



##
File path: src/test/java/org/apache/commons/io/IOUtilsTestCase.java
##
@@ -118,7 +116,7 @@ public void setUp() {
 if (!testFile.getParentFile().exists()) {
 throw new IOException("Cannot create file " + testFile + " as 
the parent directory does not exist");
 }
-final BufferedOutputStream output = new BufferedOutputStream(new 
FileOutputStream(testFile));
+final BufferedOutputStream output = new 
BufferedOutputStream(Files.newOutputStream(testFile.toPath()));

Review comment:
   In these test methods, you keep calling `toPath()` over and over, why 
not just call it once?

##
File path: src/test/java/org/apache/commons/io/IOUtilsTestCase.java
##
@@ -118,7 +116,7 @@ public void setUp() {
 if (!testFile.getParentFile().exists()) {
 throw new IOException("Cannot create file " + testFile + " as 
the parent directory does not exist");
 }
-final BufferedOutputStream output = new BufferedOutputStream(new 
FileOutputStream(testFile));
+final BufferedOutputStream output = new 
BufferedOutputStream(Files.newOutputStream(testFile.toPath()));

Review comment:
   In these test methods, you keep calling `toPath()` over and over, why 
not just call it once? IOW should `testFile` be `testPath` or have both?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] leskin-in commented on pull request #175: IO-429: Check for long streams in IOUtils.toByteArray

[GitBox]

leskin-in commented on pull request #175:
URL: https://github.com/apache/commons-io/pull/175#issuecomment-841833386


   @garydgregory , 
[that](https://github.com/apache/commons-io/commit/7e0d317ac61427e6004372622df4014c1e602487)
 is a nice solution.
   
   As `ThresholdingOutputStream.written` is `long`, 
[`ThresholdingOutputStream.checkThreshold()`](https://github.com/apache/commons-io/blob/587a0354f0581fb6e32dda0ef14ca8f07c945c2d/src/main/java/org/apache/commons/io/output/ThresholdingOutputStream.java#L94-L107)
 works fine for `Integer.MAX_VALUE`.
   
   Should this PR be closed then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-codec] apinske commented on a change in pull request #85: CODEC-301: BaseNCodec: Reduce byte[] allocations by reusing buffers

[GitBox]

apinske commented on a change in pull request #85:
URL: https://github.com/apache/commons-codec/pull/85#discussion_r633113323



##
File path: 
src/main/java/org/apache/commons/codec/binary/BaseNCodecInputStream.java
##
@@ -171,7 +174,7 @@ public int read(final byte array[], final int offset, final 
int len) throws IOEx
 */
 while (readLen == 0) {

Review comment:
   Looks good. Tests pass. I adjusted the new Base64-Test to provided 
bigger buffers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-429) ByteArrayOutputStream can overflow

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-429?focusedWorklogId=598018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598018
 ]

ASF GitHub Bot logged work on IO-429:
-

Author: ASF GitHub Bot
Created on: 17/May/21 18:24
Start Date: 17/May/21 18:24
Worklog Time Spent: 10m 
  Work Description: leskin-in commented on pull request #175:
URL: https://github.com/apache/commons-io/pull/175#issuecomment-841833386


   @garydgregory , 
[that](https://github.com/apache/commons-io/commit/7e0d317ac61427e6004372622df4014c1e602487)
 is a nice solution.
   
   As `ThresholdingOutputStream.written` is `long`, 
[`ThresholdingOutputStream.checkThreshold()`](https://github.com/apache/commons-io/blob/587a0354f0581fb6e32dda0ef14ca8f07c945c2d/src/main/java/org/apache/commons/io/output/ThresholdingOutputStream.java#L94-L107)
 works fine for `Integer.MAX_VALUE`.
   
   Should this PR be closed then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 598018)
Time Spent: 3h 10m  (was: 3h)

> ByteArrayOutputStream can overflow
> --
>
> Key: IO-429
> URL: https://issues.apache.org/jira/browse/IO-429
> Project: Commons IO
>  Issue Type: Bug
>  Components: Utilities
>Reporter: Fabian Lange
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> There are many places involved in the problem, and a good fix might be 
> problematic performance wise.
> For example:
> IOUtils.toByteArray(InputStream input) invoked with a Stream which feeds more 
> than Integer.MAX_VALUE bytes will either crash with 
> NegativeArraySizeException or maybe worse overflow in such a way that it 
> returns fine (but only with partial data)
> The ByteArrayOutputStream will happily consume the full stream but "int 
> count" will overflow. At some point then toByteArray is invoked which will do 
> like new byte[count].
> maybe "needNewBuffer" can throw the IllegalArgumentException, as it gets  the 
> count and could check for the overflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-crypto] dependabot[bot] closed pull request #131: Bump junit-bom from 5.7.0 to 5.7.1

[GitBox]

dependabot[bot] closed pull request #131:
URL: https://github.com/apache/commons-crypto/pull/131


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=598013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598013
 ]

ASF GitHub Bot logged work on IO-726:
-

Author: ASF GitHub Bot
Created on: 17/May/21 18:23
Start Date: 17/May/21 18:23
Worklog Time Spent: 10m 
  Work Description: garydgregory edited a comment on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 598013)
Time Spent: 1.5h  (was: 1h 20m)

> Add MemoryMappedInputStream
> ---
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: S Hollander
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of 
> memory mapped files. I propose an {{InputStream}} that provides a bridge 
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream 
> provided a 25% increase in throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-collections] dependabot[bot] commented on pull request #236: Bump commons.junit.version from 5.7.1 to 5.7.2

[GitBox]

dependabot[bot] commented on pull request #236:
URL: 
https://github.com/apache/commons-collections/pull/236#issuecomment-842145790


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory edited a comment on pull request #215: IO-726 Add MemoryMappedInputStream.

[GitBox]

garydgregory edited a comment on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #233: Minor improvements

[GitBox]

garydgregory merged pull request #233:
URL: https://github.com/apache/commons-io/pull/233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #757: Use own validator ClassUtils.getName to get String input

[GitBox]

coveralls commented on pull request #757:
URL: https://github.com/apache/commons-lang/pull/757#issuecomment-841774504


   
   [![Coverage 
Status](https://coveralls.io/builds/39720623/badge)](https://coveralls.io/builds/39720623)
   
   Coverage increased (+0.006%) to 94.933% when pulling 
**aff9858ac18ab7a40a6004df49744a76eadbcfcf on arturobernalg:feature/getName** 
into **acd7283f1931644acad1f739325e2ec2024729a6 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=597973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597973
 ]

ASF GitHub Bot logged work on IO-726:
-

Author: ASF GitHub Bot
Created on: 17/May/21 18:18
Start Date: 17/May/21 18:18
Worklog Time Spent: 10m 
  Work Description: garydgregory commented on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   @shollander 
   The Java 17-EA builds but I can't see why; may you please rebase on master, 
all builds are green there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597973)
Time Spent: 1h 20m  (was: 1h 10m)

> Add MemoryMappedInputStream
> ---
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: S Hollander
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of 
> memory mapped files. I propose an {{InputStream}} that provides a bridge 
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream 
> provided a 25% increase in throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-scxml] dependabot[bot] commented on pull request #15: Bump junit-jupiter-api from 5.4.2 to 5.7.1

[GitBox]

dependabot[bot] commented on pull request #15:
URL: https://github.com/apache/commons-scxml/pull/15#issuecomment-841988322


   Superseded by #20.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-codec] aherbert commented on a change in pull request #85: CODEC-301: BaseNCodec: Reduce byte[] allocations by reusing buffers

[GitBox]

aherbert commented on a change in pull request #85:
URL: https://github.com/apache/commons-codec/pull/85#discussion_r633110634



##
File path: 
src/main/java/org/apache/commons/codec/binary/BaseNCodecInputStream.java
##
@@ -171,7 +174,7 @@ public int read(final byte array[], final int offset, final 
int len) throws IOEx
 */
 while (readLen == 0) {

Review comment:
   You commented that the read only attempts to read at most the size of 
the input buffer (`buf`), effectively ignoring the user requested length to 
read (`len`). This prevents a user reading with a very large `array` in a 
single method call.
   
   How about this:
   ```java
   // Attempt to read the request length
   while (readLen < len) {
   if (!baseNCodec.hasData(context)) {
   // Obtain more data.
   // *** TBC: remove buffer allocation here ***
   final byte[] buf = new byte[doEncode ? 4096 : 8192];
   final int c = in.read(buf);
   if (doEncode) {
   baseNCodec.encode(buf, 0, c, context);
   } else {
   baseNCodec.decode(buf, 0, c, context);
   }
   }
   final int read = baseNCodec.readResults(array, offset + readLen, len - 
readLen, context);
   if (read < 0) {
   // Return the amount read or EOF
   return readLen != 0 ? readLen : -1;
   }
   readLen += read;
   }
   ```
   
   The above change passes the test suite using the old code. Can you try it 
with your changes to recycle the buffer.
   
   IIUC recycling the buffer will not cause memory expansion here. With the new 
changes the call to `readResults` should either: read all the data if the user 
has provided a very large destination `array` and the Context is reset to zero; 
or read some of the data up to the `len` requested by the user. The Context 
will then return true for the next call into this method in the 
`hasData(context)` statement and the Context will be emptied next time.
   

##
File path: src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
##
@@ -711,12 +711,15 @@ public boolean isStrictDecoding() {
  * @return The number of bytes successfully extracted into the provided 
byte[] array.
  */
 int readResults(final byte[] b, final int bPos, final int bAvail, final 
Context context) {
-if (context.buffer != null) {
+if (hasData(context)) {
 final int len = Math.min(available(context), bAvail);
 System.arraycopy(context.buffer, context.readPos, b, bPos, len);
 context.readPos += len;
 if (context.readPos >= context.pos) {

Review comment:
   Perhaps this would be clearer as:
   ```java
   if (!hasData(context))
   ```
   Reusing the hasData method makes it the single point of entry to the logic 
with the pos and readPos markers.
   The comment can then be changed to:
   ```java
   // All data read.
   // Reset position markers but do not set buffer to null to allow its reuse.
   // hasData(context) will still return false, and this method will return 0 
until
   // more data is available, or -1 if EOF.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-crypto] dependabot[bot] commented on pull request #131: Bump junit-bom from 5.7.0 to 5.7.1

[GitBox]

dependabot[bot] commented on pull request #131:
URL: https://github.com/apache/commons-crypto/pull/131#issuecomment-842059290


   Superseded by #134.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-pool] coveralls commented on pull request #76: Bump junit-bom from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #76:
URL: https://github.com/apache/commons-pool/pull/76#issuecomment-842025418


   
   [![Coverage 
Status](https://coveralls.io/builds/39731528/badge)](https://coveralls.io/builds/39731528)
   
   Coverage decreased (-0.03%) to 84.146% when pulling 
**4cdf2fa79553ba84c3da089a93ded53b5cf4aee8 on 
dependabot/maven/org.junit-junit-bom-5.7.2** into 
**5c347abd556c0369f0697dc5b6be78889a5ceca3 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #215: IO-726 Add MemoryMappedInputStream.

[GitBox]

garydgregory commented on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   @shollander 
   The Java 17-EA builds but I can't see why; may you please rebase on master, 
all builds are green there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] LeeKyoungIl edited a comment on pull request #760: ObjectUtils: Add nullSafeEquals method for Object compare.

[GitBox]

LeeKyoungIl edited a comment on pull request #760:
URL: https://github.com/apache/commons-lang/pull/760#issuecomment-841902039






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-fileupload] jochenw merged pull request #88: FILEUPLOAD-336 - WhitespaceAround

[GitBox]

jochenw merged pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-scxml] dependabot[bot] closed pull request #15: Bump junit-jupiter-api from 5.4.2 to 5.7.1

[GitBox]

dependabot[bot] closed pull request #15:
URL: https://github.com/apache/commons-scxml/pull/15


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-fileupload] coveralls commented on pull request #90: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #90:
URL: https://github.com/apache/commons-fileupload/pull/90#issuecomment-842021793


   
   [![Coverage 
Status](https://coveralls.io/builds/39731424/badge)](https://coveralls.io/builds/39731424)
   
   Coverage remained the same at 78.278% when pulling 
**4deff6d3fa709c458bb3a86d3afe2003afd51ef2 on 
dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.2** into 
**6e499fd98da67f889ecfc08babaf7bc7ca6c7678 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-text] coveralls commented on pull request #232: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #232:
URL: https://github.com/apache/commons-text/pull/232#issuecomment-842018999


   
   [![Coverage 
Status](https://coveralls.io/builds/39731328/badge)](https://coveralls.io/builds/39731328)
   
   Coverage remained the same at 97.961% when pulling 
**c169300f9f3b906b130ba85ca0097823670fccec on 
dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.2** into 
**f01c2a0f0f3b054bdaa56945c0eb7881842eedfd on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] dependabot[bot] commented on pull request #151: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

dependabot[bot] commented on pull request #151:
URL: https://github.com/apache/commons-imaging/pull/151#issuecomment-842140143


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-text] dependabot[bot] commented on pull request #232: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

dependabot[bot] commented on pull request #232:
URL: https://github.com/apache/commons-text/pull/232#issuecomment-842149990


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] arturobernalg commented on a change in pull request #221: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

[GitBox]

arturobernalg commented on a change in pull request #221:
URL: https://github.com/apache/commons-io/pull/221#discussion_r633231050



##
File path: src/test/java/org/apache/commons/io/IOUtilsTestCase.java
##
@@ -118,7 +116,7 @@ public void setUp() {
 if (!testFile.getParentFile().exists()) {
 throw new IOException("Cannot create file " + testFile + " as 
the parent directory does not exist");
 }
-final BufferedOutputStream output = new BufferedOutputStream(new 
FileOutputStream(testFile));
+final BufferedOutputStream output = new 
BufferedOutputStream(Files.newOutputStream(testFile.toPath()));

Review comment:
   HI @garydgregory 
   you're right. Changed.
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #232: Bump junit-bom from 5.7.1 to 5.7.2

[GitBox]

garydgregory merged pull request #232:
URL: https://github.com/apache/commons-io/pull/232


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-csv] coveralls commented on pull request #149: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

coveralls commented on pull request #149:
URL: https://github.com/apache/commons-csv/pull/149#issuecomment-842018393


   
   [![Coverage 
Status](https://coveralls.io/builds/39731314/badge)](https://coveralls.io/builds/39731314)
   
   Coverage remained the same at 98.463% when pulling 
**d3d34b83d819c70cd72bcbe7734b85cddeb2f3f6 on 
dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.2** into 
**d3e74a7fb34fd3d8b470c695741b2b5591eda3c4 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] gwlucastrig commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

[GitBox]

gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841791184


   It looks like providing compatibility with Android OS may not be practical.
   Android has its own graphics and media classes.  So anything with java.awt
   in it will not port. Common Imaging using BufferedImage extensively.   Most
   other AWT elements are used only a little.  Color shows up the most.  The
   ICC_ColorSpace also shows up. A couple of the test applications use
   Graphics to draw some test images as input.
   
   I think I might post a question on Java Coderanch or Stackoverflow to ask
   about compatible solutions.
   
   
   On Sat, May 15, 2021 at 8:18 AM Bruno P. Kinoshita ***@***.***>
   wrote:
   
   > If those classes are from awt, the issue is that we have a dependency to
   > java.desktop (I think that's the java module name) and also cause an issue
   > to users of the API that are using Android (as IIUC, there's no awt in
   > Android's Java SDK?).
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   
   Search "java.awt" (229 hits in 121 files of 557 searched)
   commons-imaging\src\main\java\org\apache\commons\imaging\ColorTools.java (11 
hits)
Line 20: import java.awt.RenderingHints;
Line 21: import java.awt.Transparency;
Line 22: import java.awt.color.ColorSpace;
Line 23: import java.awt.color.ICC_ColorSpace;
Line 24: import java.awt.color.ICC_Profile;
Line 25: import java.awt.image.BufferedImage;
Line 26: import java.awt.image.ColorConvertOp;
Line 27: import java.awt.image.ColorModel;
Line 28: import java.awt.image.ComponentColorModel;
Line 29: import java.awt.image.DirectColorModel;
Line 30: import java.awt.image.ImagingOpException;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\BufferedImageFactory.java
 (1 hit)
Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\ImageBuilder.java
 (9 hits)
Line 43: import java.awt.color.ColorSpace;
Line 44: import java.awt.image.BufferedImage;
Line 45: import java.awt.image.ColorModel;
Line 46: import java.awt.image.DataBuffer;
Line 47: import java.awt.image.DataBufferInt;
Line 48: import java.awt.image.DirectColorModel;
Line 49: import java.awt.image.Raster;
Line 50: import java.awt.image.RasterFormatException;
Line 51: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\RgbBufferedImageFactory.java
 (1 hit)
Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\SimpleBufferedImageFactory.java
 (1 hit)
Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpImageParser.java
 (2 hits)
Line 27: import java.awt.Dimension;
Line 28: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriter.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriterPalette.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriterRgb.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\dcx\DcxImageParser.java
 (2 hits)
Line 23: import java.awt.Dimension;
Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\gif\GifImageParser.java
 (2 hits)
Line 28: import java.awt.Dimension;
Line 29: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\icns\IcnsDecoder.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\icns\IcnsImageParser.java
 (2 hits)
Line 23: import java.awt.Dimension;
Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\ico\IcoImageParser.java
 (2 hits)
Line 26: import java.awt.Dimension;
Line 27: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\jpeg\decoder\JpegDecoder.java
 (6 hits)
Line 21: import java.awt.image.BufferedImage;
Line 22: import java.awt.image.ColorModel;
  

[jira] [Work logged] (IMAGING-159) There should be a Parameters class

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=597883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597883
 ]

ASF GitHub Bot logged work on IMAGING-159:
--

Author: ASF GitHub Bot
Created on: 17/May/21 18:07
Start Date: 17/May/21 18:07
Worklog Time Spent: 10m 
  Work Description: kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841797895


   Whew, I knew we relied on awt, but looks like we are using it in a lot more 
places than I imagined. Let me update the PR to use a rectangle as ou suggested 
@gwlucastrig . Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597883)
Time Spent: 4h  (was: 3h 50m)

> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
>  Issue Type: Improvement
>  Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
>  Labels: github
> Fix For: 1.0-alpha3
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem 
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
>   if (!(value instanceof Number)) {
> throw new ImageWriteException(
>   "Invalid compression parameter, must be numeric: "
>  + value);
>   }
>   compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides 
> additional methods like {{public int getInt(String key)}}. The implementation 
> could then look up the value from the map through an exception if it is null 
> or not a number.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-fileupload] arturobernalg commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

[GitBox]

arturobernalg commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-841809925


   > Resolving Checkstyle issues is helpful, of course. Thanks!
   > 
   > But, as we now have conflicts: Could you, please, rebase?
   
   HI @jochenw 
   there is still a lot of work regarding checkstyle. I can work on fix those 
error while waiting for ticker response FILEUPLOAD-275  
   TY 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] kinow commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

[GitBox]

kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841797895


   Whew, I knew we relied on awt, but looks like we are using it in a lot more 
places than I imagined. Let me update the PR to use a rectangle as ou suggested 
@gwlucastrig . Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-fileupload] jochenw commented on pull request #88: FILEUPLOAD-336 - WhitespaceAround

[GitBox]

jochenw commented on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-841805649


   Resolving Checkstyle issues is helpful, of course. Thanks!
   
   But, as we now have conflicts: Could you, please, rebase?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IMAGING-159) There should be a Parameters class

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=597875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597875
 ]

ASF GitHub Bot logged work on IMAGING-159:
--

Author: ASF GitHub Bot
Created on: 17/May/21 18:06
Start Date: 17/May/21 18:06
Worklog Time Spent: 10m 
  Work Description: gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841791184


   It looks like providing compatibility with Android OS may not be practical.
   Android has its own graphics and media classes.  So anything with java.awt
   in it will not port. Common Imaging using BufferedImage extensively.   Most
   other AWT elements are used only a little.  Color shows up the most.  The
   ICC_ColorSpace also shows up. A couple of the test applications use
   Graphics to draw some test images as input.
   
   I think I might post a question on Java Coderanch or Stackoverflow to ask
   about compatible solutions.
   
   
   On Sat, May 15, 2021 at 8:18 AM Bruno P. Kinoshita ***@***.***>
   wrote:
   
   > If those classes are from awt, the issue is that we have a dependency to
   > java.desktop (I think that's the java module name) and also cause an issue
   > to users of the API that are using Android (as IIUC, there's no awt in
   > Android's Java SDK?).
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   
   Search "java.awt" (229 hits in 121 files of 557 searched)
   commons-imaging\src\main\java\org\apache\commons\imaging\ColorTools.java (11 
hits)
Line 20: import java.awt.RenderingHints;
Line 21: import java.awt.Transparency;
Line 22: import java.awt.color.ColorSpace;
Line 23: import java.awt.color.ICC_ColorSpace;
Line 24: import java.awt.color.ICC_Profile;
Line 25: import java.awt.image.BufferedImage;
Line 26: import java.awt.image.ColorConvertOp;
Line 27: import java.awt.image.ColorModel;
Line 28: import java.awt.image.ComponentColorModel;
Line 29: import java.awt.image.DirectColorModel;
Line 30: import java.awt.image.ImagingOpException;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\BufferedImageFactory.java
 (1 hit)
Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\ImageBuilder.java
 (9 hits)
Line 43: import java.awt.color.ColorSpace;
Line 44: import java.awt.image.BufferedImage;
Line 45: import java.awt.image.ColorModel;
Line 46: import java.awt.image.DataBuffer;
Line 47: import java.awt.image.DataBufferInt;
Line 48: import java.awt.image.DirectColorModel;
Line 49: import java.awt.image.Raster;
Line 50: import java.awt.image.RasterFormatException;
Line 51: import java.awt.image.WritableRaster;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\RgbBufferedImageFactory.java
 (1 hit)
Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\common\SimpleBufferedImageFactory.java
 (1 hit)
Line 20: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpImageParser.java
 (2 hits)
Line 27: import java.awt.Dimension;
Line 28: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriter.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriterPalette.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\bmp\BmpWriterRgb.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\dcx\DcxImageParser.java
 (2 hits)
Line 23: import java.awt.Dimension;
Line 24: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\gif\GifImageParser.java
 (2 hits)
Line 28: import java.awt.Dimension;
Line 29: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\icns\IcnsDecoder.java
 (1 hit)
Line 19: import java.awt.image.BufferedImage;
   
commons-imaging\src\main\java\org\apache\commons\imaging\formats\icns\IcnsImageParser.java
 (2 hits)
Line 23: import java.awt.Dimension;
Line 24: import java.awt.image.Bu

[GitHub] [commons-fileupload] coveralls edited a comment on pull request #88: FILEUPLOAD-336 - WhitespaceAround

[GitBox]

coveralls edited a comment on pull request #88:
URL: https://github.com/apache/commons-fileupload/pull/88#issuecomment-836153815






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-fileupload] jochenw merged pull request #86: FILEUPLOAD-334 - LineLength - Line is longer than 120 characters

[GitBox]

jochenw merged pull request #86:
URL: https://github.com/apache/commons-fileupload/pull/86


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (LANG-1572) implement TODO in CharSequenceUtils.indexOf : remake it.

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/LANG-1572?focusedWorklogId=597859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597859
 ]

ASF GitHub Bot logged work on LANG-1572:


Author: ASF GitHub Bot
Created on: 17/May/21 18:04
Start Date: 17/May/21 18:04
Worklog Time Spent: 10m 
  Work Description: garydgregory commented on pull request #560:
URL: https://github.com/apache/commons-lang/pull/560#issuecomment-841730320


   Hm, why do we want something so much more complicated? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597859)
Time Spent: 2h  (was: 1h 50m)

> implement TODO in CharSequenceUtils.indexOf : remake it.
> 
>
> Key: LANG-1572
> URL: https://issues.apache.org/jira/browse/LANG-1572
> Project: Commons Lang
>  Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Major
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/560]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-lang] LeeKyoungIl closed pull request #759: ObjectUtils: Add nullSafeEquals method for Object compare.

[GitBox]

LeeKyoungIl closed pull request #759:
URL: https://github.com/apache/commons-lang/pull/759






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #560: [LANG-1572] green implementation CharSequenceUtils.indexOf

[GitBox]

garydgregory commented on pull request #560:
URL: https://github.com/apache/commons-lang/pull/560#issuecomment-841730320


   Hm, why do we want something so much more complicated? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-fileupload] coveralls edited a comment on pull request #86: FILEUPLOAD-334 - LineLength - Line is longer than 120 characters

[GitBox]

coveralls edited a comment on pull request #86:
URL: https://github.com/apache/commons-fileupload/pull/86#issuecomment-834519898


   
   [![Coverage 
Status](https://coveralls.io/builds/39720855/badge)](https://coveralls.io/builds/39720855)
   
   Coverage decreased (-0.06%) to 78.278% when pulling 
**64caa719fb84bdf6054ee716184c66716e5538f0 on 
arturobernalg:feature/FILEUPLOAD-334** into 
**09d63053a3d295462e645feca9a67668cd19518d on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] coveralls edited a comment on pull request #760: ObjectUtils: Add nullSafeEquals method for Object compare.

[GitBox]

coveralls edited a comment on pull request #760:
URL: https://github.com/apache/commons-lang/pull/760#issuecomment-841822150


   
   [![Coverage 
Status](https://coveralls.io/builds/39721710/badge)](https://coveralls.io/builds/39721710)
   
   Coverage decreased (-0.01%) to 94.917% when pulling 
**c2ba5efa65930173d31720458251cc964ac41531 on 
LeeKyoungIl:feature/null-safe-equals-method** into 
**acd7283f1931644acad1f739325e2ec2024729a6 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #760: ObjectUtils: Add nullSafeEquals method for Object compare.

[GitBox]

coveralls commented on pull request #760:
URL: https://github.com/apache/commons-lang/pull/760#issuecomment-841822150


   
   [![Coverage 
Status](https://coveralls.io/builds/39721687/badge)](https://coveralls.io/builds/39721687)
   
   Coverage decreased (-0.004%) to 94.923% when pulling 
**f345ce7e12006f4ea07d661f2a2f77e7b4b0e487 on 
LeeKyoungIl:feature/null-safe-equals-method** into 
**acd7283f1931644acad1f739325e2ec2024729a6 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-429) ByteArrayOutputStream can overflow

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-429?focusedWorklogId=597837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597837
 ]

ASF GitHub Bot logged work on IO-429:
-

Author: ASF GitHub Bot
Created on: 17/May/21 18:01
Start Date: 17/May/21 18:01
Worklog Time Spent: 10m 
  Work Description: garydgregory commented on pull request #175:
URL: https://github.com/apache/commons-io/pull/175#issuecomment-841824967






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597837)
Time Spent: 3h  (was: 2h 50m)

> ByteArrayOutputStream can overflow
> --
>
> Key: IO-429
> URL: https://issues.apache.org/jira/browse/IO-429
> Project: Commons IO
>  Issue Type: Bug
>  Components: Utilities
>Reporter: Fabian Lange
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> There are many places involved in the problem, and a good fix might be 
> problematic performance wise.
> For example:
> IOUtils.toByteArray(InputStream input) invoked with a Stream which feeds more 
> than Integer.MAX_VALUE bytes will either crash with 
> NegativeArraySizeException or maybe worse overflow in such a way that it 
> returns fine (but only with partial data)
> The ByteArrayOutputStream will happily consume the full stream but "int 
> count" will overflow. At some point then toByteArray is invoked which will do 
> like new byte[count].
> maybe "needNewBuffer" can throw the IllegalArgumentException, as it gets  the 
> count and could check for the overflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-io] garydgregory commented on pull request #175: IO-429: Check for long streams in IOUtils.toByteArray

[GitBox]

garydgregory commented on pull request #175:
URL: https://github.com/apache/commons-io/pull/175#issuecomment-841824967






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (LANG-1572) implement TODO in CharSequenceUtils.indexOf : remake it.

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/LANG-1572?focusedWorklogId=597823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597823
 ]

ASF GitHub Bot logged work on LANG-1572:


Author: ASF GitHub Bot
Created on: 17/May/21 17:59
Start Date: 17/May/21 17:59
Worklog Time Spent: 10m 
  Work Description: jochenw commented on pull request #560:
URL: https://github.com/apache/commons-lang/pull/560#issuecomment-841724647


   Would you, please, be so kind to rebase again? Sorry for that inconvenience.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597823)
Time Spent: 1h 50m  (was: 1h 40m)

> implement TODO in CharSequenceUtils.indexOf : remake it.
> 
>
> Key: LANG-1572
> URL: https://issues.apache.org/jira/browse/LANG-1572
> Project: Commons Lang
>  Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/560]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-lang] coveralls commented on pull request #758: Use own validator ClassUtils.getSimpleName to get String input

[GitBox]

coveralls commented on pull request #758:
URL: https://github.com/apache/commons-lang/pull/758#issuecomment-841792055


   
   [![Coverage 
Status](https://coveralls.io/builds/39721145/badge)](https://coveralls.io/builds/39721145)
   
   Coverage increased (+0.006%) to 94.933% when pulling 
**9d954ea36ae0571820ca4a6dafb18d43c25d9ad3 on 
arturobernalg:feature/getSimpleName** into 
**acd7283f1931644acad1f739325e2ec2024729a6 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-lang] jochenw commented on pull request #560: [LANG-1572] green implementation CharSequenceUtils.indexOf

[GitBox]

jochenw commented on pull request #560:
URL: https://github.com/apache/commons-lang/pull/560#issuecomment-841724647


   Would you, please, be so kind to rebase again? Sorry for that inconvenience.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] arturobernalg opened a new pull request #234: Simplify Assertions

[GitBox]

arturobernalg opened a new pull request #234:
URL: https://github.com/apache/commons-io/pull/234


   Change assertions with simpler but equivalent calls.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-codec] aherbert commented on a change in pull request #85: CODEC-301: BaseNCodec: Reduce byte[] allocations by reusing buffers

[GitBox]

aherbert commented on a change in pull request #85:
URL: https://github.com/apache/commons-codec/pull/85#discussion_r633577750



##
File path: src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
##
@@ -711,12 +711,15 @@ public boolean isStrictDecoding() {
  * @return The number of bytes successfully extracted into the provided 
byte[] array.
  */
 int readResults(final byte[] b, final int bPos, final int bAvail, final 
Context context) {
-if (context.buffer != null) {
+if (hasData(context)) {
 final int len = Math.min(available(context), bAvail);
 System.arraycopy(context.buffer, context.readPos, b, bPos, len);
 context.readPos += len;
 if (context.readPos >= context.pos) {

Review comment:
   Perhaps this would be clearer as:
   ```java
   if (!hasData(context))
   ```
   Reusing the hasData method makes it the single point of entry to the logic 
with the pos and readPos markers.
   The comment can then be changed to:
   ```java
   // All data read.
   // Reset position markers but do not set buffer to null to allow its reuse.
   // hasData(context) will still return false, and this method will return 0 
until
   // more data is available, or -1 if EOF.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=597680&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597680
 ]

ASF GitHub Bot logged work on IO-726:
-

Author: ASF GitHub Bot
Created on: 17/May/21 14:22
Start Date: 17/May/21 14:22
Worklog Time Spent: 10m 
  Work Description: garydgregory edited a comment on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   Hi @shollander 
   The Java 17-EA builds which seems to be fixed in the latest EA; may you 
please rebase on master, all builds are green there.
   This appears to introduce some duplication with 
`org.apache.commons.io.input.BufferedFileChannelInputStream`; it would be 
better if this cleaning functionality was defined only once and reused.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597680)
Time Spent: 1h 10m  (was: 1h)

> Add MemoryMappedInputStream
> ---
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: S Hollander
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of 
> memory mapped files. I propose an {{InputStream}} that provides a bridge 
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream 
> provided a 25% increase in throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-io] garydgregory edited a comment on pull request #215: IO-726 Add MemoryMappedInputStream.

[GitBox]

garydgregory edited a comment on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   Hi @shollander 
   The Java 17-EA builds which seems to be fixed in the latest EA; may you 
please rebase on master, all builds are green there.
   This appears to introduce some duplication with 
`org.apache.commons.io.input.BufferedFileChannelInputStream`; it would be 
better if this cleaning functionality was defined only once and reused.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=597675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597675
 ]

ASF GitHub Bot logged work on IO-726:
-

Author: ASF GitHub Bot
Created on: 17/May/21 14:16
Start Date: 17/May/21 14:16
Worklog Time Spent: 10m 
  Work Description: garydgregory edited a comment on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   Hi @shollander 
   The Java 17-EA builds but I can't see why; may you please rebase on master, 
all builds are green there.
   This appears to introduce some duplication with 
`org.apache.commons.io.input.BufferedFileChannelInputStream`; it would be 
better if this cleaning functionality was defined only once and reused.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597675)
Time Spent: 1h  (was: 50m)

> Add MemoryMappedInputStream
> ---
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: S Hollander
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of 
> memory mapped files. I propose an {{InputStream}} that provides a bridge 
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream 
> provided a 25% increase in throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-io] garydgregory edited a comment on pull request #215: IO-726 Add MemoryMappedInputStream.

[GitBox]

garydgregory edited a comment on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   Hi @shollander 
   The Java 17-EA builds but I can't see why; may you please rebase on master, 
all builds are green there.
   This appears to introduce some duplication with 
`org.apache.commons.io.input.BufferedFileChannelInputStream`; it would be 
better if this cleaning functionality was defined only once and reused.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Work logged] (IO-726) Add MemoryMappedInputStream

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/IO-726?focusedWorklogId=597671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597671
 ]

ASF GitHub Bot logged work on IO-726:
-

Author: ASF GitHub Bot
Created on: 17/May/21 14:12
Start Date: 17/May/21 14:12
Worklog Time Spent: 10m 
  Work Description: garydgregory commented on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   @shollander 
   The Java 17-EA builds but I can't see why; may you please rebase on master, 
all builds are green there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 597671)
Time Spent: 50m  (was: 40m)

> Add MemoryMappedInputStream
> ---
>
> Key: IO-726
> URL: https://issues.apache.org/jira/browse/IO-726
> Project: Commons IO
>  Issue Type: New Feature
>  Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: S Hollander
>Priority: Major
> Fix For: 2.9.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> A very useful tool for improving performance with disk-based IO is the use of 
> memory mapped files. I propose an {{InputStream}} that provides a bridge 
> between memory mapped files and the {{InputStream}} ecosystem.
> In my limited performance tests, the use of the MemoryMappedInputStream 
> provided a 25% increase in throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-io] garydgregory commented on pull request #215: IO-726 Add MemoryMappedInputStream.

[GitBox]

garydgregory commented on pull request #215:
URL: https://github.com/apache/commons-io/pull/215#issuecomment-842358898


   @shollander 
   The Java 17-EA builds but I can't see why; may you please rebase on master, 
all builds are green there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #233: Minor improvements

[GitBox]

garydgregory merged pull request #233:
URL: https://github.com/apache/commons-io/pull/233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #232: Bump junit-bom from 5.7.1 to 5.7.2

[GitBox]

garydgregory merged pull request #232:
URL: https://github.com/apache/commons-io/pull/232


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (COMPRESS-552) OSGI check broken - try to load class BundleEvent always fails

[Stefan Bodewig (Jira)]

 [ 
https://issues.apache.org/jira/browse/COMPRESS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Bodewig resolved COMPRESS-552.
-
Resolution: Fixed

Great, thank you [~mtomcat_daobi]

> OSGI check broken - try to load class BundleEvent always fails
> --
>
> Key: COMPRESS-552
> URL: https://issues.apache.org/jira/browse/COMPRESS-552
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Compressors
>Affects Versions: 1.20
>Reporter: Björn Michael
>Priority: Major
> Fix For: 1.21
>
> Attachments: commons-compress-1.21-SNAPSHOT.jar
>
>
> There is a check for running in OSGI env. in {{ZstdUtils}}, {{BrotliUtils}}, 
> {{LZMAUtils}} and {{XZUtils}} like this:
> {code:java}
> static {
> cachedZstdAvailability = CachedAvailability.DONT_CACHE;
> try {
> Class.forName("org.osgi.framework.BundleEvent");
> } catch (final Exception ex) { // NOSONAR
> setCacheZstdAvailablity(true);
> }
> }
> {code}
> Loading the class {{org.osgi.framework.BundleEvent}} always fails because 
> {{Import-Package}} directive for {{org.osgi.framework}} is missing in 
> _MANIFEST.MF_. Or it requires another more sophisticated approaches 
> ([https://stackoverflow.com/q/5879040/1061929]).
> Tested with Eclipse 4.14 (org.eclipse.osgi_3.15.100.v20191114-1701.jar)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [commons-text] kinow closed pull request #232: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

kinow closed pull request #232:
URL: https://github.com/apache/commons-text/pull/232


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-text] dependabot[bot] commented on pull request #232: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

dependabot[bot] commented on pull request #232:
URL: https://github.com/apache/commons-text/pull/232#issuecomment-842149990


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-collections] kinow closed pull request #236: Bump commons.junit.version from 5.7.1 to 5.7.2

[GitBox]

kinow closed pull request #236:
URL: https://github.com/apache/commons-collections/pull/236


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-collections] dependabot[bot] commented on pull request #236: Bump commons.junit.version from 5.7.1 to 5.7.2

[GitBox]

dependabot[bot] commented on pull request #236:
URL: 
https://github.com/apache/commons-collections/pull/236#issuecomment-842145790


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] kinow closed pull request #151: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

kinow closed pull request #151:
URL: https://github.com/apache/commons-imaging/pull/151


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] dependabot[bot] commented on pull request #151: Bump junit-jupiter from 5.7.1 to 5.7.2

[GitBox]

dependabot[bot] commented on pull request #151:
URL: https://github.com/apache/commons-imaging/pull/151#issuecomment-842140143


   OK, I won't notify you again about this release, but will get in touch when 
a new version is available.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (COMPRESS-552) OSGI check broken - try to load class BundleEvent always fails

[Jira]

[ 
https://issues.apache.org/jira/browse/COMPRESS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345924#comment-17345924
 ] 

Björn Michael commented on COMPRESS-552:


{{OsgiUtils.isRunningInOsgiEnvironment()}} returns {{true}} with given 
{{commons-compress-1.21-SNAPSHOT.jar}}. Thank you.

> OSGI check broken - try to load class BundleEvent always fails
> --
>
> Key: COMPRESS-552
> URL: https://issues.apache.org/jira/browse/COMPRESS-552
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Compressors
>Affects Versions: 1.20
>Reporter: Björn Michael
>Priority: Major
> Fix For: 1.21
>
> Attachments: commons-compress-1.21-SNAPSHOT.jar
>
>
> There is a check for running in OSGI env. in {{ZstdUtils}}, {{BrotliUtils}}, 
> {{LZMAUtils}} and {{XZUtils}} like this:
> {code:java}
> static {
> cachedZstdAvailability = CachedAvailability.DONT_CACHE;
> try {
> Class.forName("org.osgi.framework.BundleEvent");
> } catch (final Exception ex) { // NOSONAR
> setCacheZstdAvailablity(true);
> }
> }
> {code}
> Loading the class {{org.osgi.framework.BundleEvent}} always fails because 
> {{Import-Package}} directive for {{org.osgi.framework}} is missing in 
> _MANIFEST.MF_. Or it requires another more sophisticated approaches 
> ([https://stackoverflow.com/q/5879040/1061929]).
> Tested with Eclipse 4.14 (org.eclipse.osgi_3.15.100.v20191114-1701.jar)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)