[jira] [Work logged] (CSV-285) Replace BufferedReader with PushbackReader
[
https://issues.apache.org/jira/browse/CSV-285?focusedWorklogId=623399=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623399
]
ASF GitHub Bot logged work on CSV-285:
--
Author: ASF GitHub Bot
Created on: 16/Jul/21 04:27
Start Date: 16/Jul/21 04:27
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881167323
[](https://coveralls.io/builds/41419456)
Coverage decreased (-0.3%) to 97.99% when pulling
**532a3f10eea650e252d32737ec560e0287114606 on belugabehr:CSV-285** into
**27843d8dc0ec6e5af910674bfb4cba4e48b2475b on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623399)
Time Spent: 40m (was: 0.5h)
> Replace BufferedReader with PushbackReader
> --
>
> Key: CSV-285
> URL: https://issues.apache.org/jira/browse/CSV-285
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {{commons-csv}} uses, as its base {{Reader}} a {{BufferedReader}}, however
> the more natural choice is {{PushBackReader}}.
> {quote}
> This is useful in situations where it is convenient for a fragment of code to
> read an indefinite number of data bytes that are delimited by a particular
> byte value; after reading the terminating byte, the code fragment can
> "unread" it, so that the next read operation on the input stream will reread
> the byte that was pushed back. For example, bytes representing the characters
> constituting an identifier might be terminated by a byte representing an
> operator character; a method whose job is to read just an identifier can read
> until it sees the operator and then push the operator back to be re-read.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html
> {{commons-csv}} currently implements these "pushback" features on top of a
> {{BufferedReader}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] coveralls commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
coveralls commented on pull request #169: URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881167323 [](https://coveralls.io/builds/41419456) Coverage decreased (-0.3%) to 97.99% when pulling **532a3f10eea650e252d32737ec560e0287114606 on belugabehr:CSV-285** into **27843d8dc0ec6e5af910674bfb4cba4e48b2475b on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-285) Replace BufferedReader with PushbackReader
[
https://issues.apache.org/jira/browse/CSV-285?focusedWorklogId=623383=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623383
]
ASF GitHub Bot logged work on CSV-285:
--
Author: ASF GitHub Bot
Created on: 16/Jul/21 03:40
Start Date: 16/Jul/21 03:40
Worklog Time Spent: 10m
Work Description: belugabehr commented on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881152812
Hold off on this one for right now, the JMH tests are not as favorable as I
was expected. I need to review the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623383)
Time Spent: 20m (was: 10m)
> Replace BufferedReader with PushbackReader
> --
>
> Key: CSV-285
> URL: https://issues.apache.org/jira/browse/CSV-285
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{commons-csv}} uses, as its base {{Reader}} a {{BufferedReader}}, however
> the more natural choice is {{PushBackReader}}.
> {quote}
> This is useful in situations where it is convenient for a fragment of code to
> read an indefinite number of data bytes that are delimited by a particular
> byte value; after reading the terminating byte, the code fragment can
> "unread" it, so that the next read operation on the input stream will reread
> the byte that was pushed back. For example, bytes representing the characters
> constituting an identifier might be terminated by a byte representing an
> operator character; a method whose job is to read just an identifier can read
> until it sees the operator and then push the operator back to be re-read.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html
> {{commons-csv}} currently implements these "pushback" features on top of a
> {{BufferedReader}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-285) Replace BufferedReader with PushbackReader
[
https://issues.apache.org/jira/browse/CSV-285?focusedWorklogId=623384=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623384
]
ASF GitHub Bot logged work on CSV-285:
--
Author: ASF GitHub Bot
Created on: 16/Jul/21 03:40
Start Date: 16/Jul/21 03:40
Worklog Time Spent: 10m
Work Description: belugabehr edited a comment on pull request #169:
URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881152812
Hold off on this one for right now, the JMH tests are not as favorable as I
was expecting. I need to review the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623384)
Time Spent: 0.5h (was: 20m)
> Replace BufferedReader with PushbackReader
> --
>
> Key: CSV-285
> URL: https://issues.apache.org/jira/browse/CSV-285
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{commons-csv}} uses, as its base {{Reader}} a {{BufferedReader}}, however
> the more natural choice is {{PushBackReader}}.
> {quote}
> This is useful in situations where it is convenient for a fragment of code to
> read an indefinite number of data bytes that are delimited by a particular
> byte value; after reading the terminating byte, the code fragment can
> "unread" it, so that the next read operation on the input stream will reread
> the byte that was pushed back. For example, bytes representing the characters
> constituting an identifier might be terminated by a byte representing an
> operator character; a method whose job is to read just an identifier can read
> until it sees the operator and then push the operator back to be re-read.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html
> {{commons-csv}} currently implements these "pushback" features on top of a
> {{BufferedReader}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] belugabehr edited a comment on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
belugabehr edited a comment on pull request #169: URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881152812 Hold off on this one for right now, the JMH tests are not as favorable as I was expecting. I need to review the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #169: CSV-285: Replace BufferedReader with PushbackReader
belugabehr commented on pull request #169: URL: https://github.com/apache/commons-csv/pull/169#issuecomment-881152812 Hold off on this one for right now, the JMH tests are not as favorable as I was expected. I need to review the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-285) Replace BufferedReader with PushbackReader
[
https://issues.apache.org/jira/browse/CSV-285?focusedWorklogId=623379=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623379
]
ASF GitHub Bot logged work on CSV-285:
--
Author: ASF GitHub Bot
Created on: 16/Jul/21 03:30
Start Date: 16/Jul/21 03:30
Worklog Time Spent: 10m
Work Description: belugabehr opened a new pull request #169:
URL: https://github.com/apache/commons-csv/pull/169
https://issues.apache.org/jira/browse/CSV-285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623379)
Remaining Estimate: 0h
Time Spent: 10m
> Replace BufferedReader with PushbackReader
> --
>
> Key: CSV-285
> URL: https://issues.apache.org/jira/browse/CSV-285
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{commons-csv}} uses, as its base {{Reader}} a {{BufferedReader}}, however
> the more natural choice is {{PushBackReader}}.
> {quote}
> This is useful in situations where it is convenient for a fragment of code to
> read an indefinite number of data bytes that are delimited by a particular
> byte value; after reading the terminating byte, the code fragment can
> "unread" it, so that the next read operation on the input stream will reread
> the byte that was pushed back. For example, bytes representing the characters
> constituting an identifier might be terminated by a byte representing an
> operator character; a method whose job is to read just an identifier can read
> until it sees the operator and then push the operator back to be re-read.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html
> {{commons-csv}} currently implements these "pushback" features on top of a
> {{BufferedReader}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] belugabehr opened a new pull request #169: CSV-285: Replace BufferedReader with PushbackReader
belugabehr opened a new pull request #169: URL: https://github.com/apache/commons-csv/pull/169 https://issues.apache.org/jira/browse/CSV-285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (CSV-285) Replace BufferedReader with PushbackReader
[
https://issues.apache.org/jira/browse/CSV-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor updated CSV-285:
---
Summary: Replace BufferedReader with PushbackReader (was: Replace
BufferedReader with Pushback Reader)
> Replace BufferedReader with PushbackReader
> --
>
> Key: CSV-285
> URL: https://issues.apache.org/jira/browse/CSV-285
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Major
>
> {{commons-csv}} uses, as its base {{Reader}} a {{BufferedReader}}, however
> the more natural choice is {{PushBackReader}}.
> {quote}
> This is useful in situations where it is convenient for a fragment of code to
> read an indefinite number of data bytes that are delimited by a particular
> byte value; after reading the terminating byte, the code fragment can
> "unread" it, so that the next read operation on the input stream will reread
> the byte that was pushed back. For example, bytes representing the characters
> constituting an identifier might be terminated by a byte representing an
> operator character; a method whose job is to read just an identifier can read
> until it sees the operator and then push the operator back to be re-read.
> {quote}
> https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html
> {{commons-csv}} currently implements these "pushback" features on top of a
> {{BufferedReader}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (CSV-285) Replace BufferedReader with Pushback Reader
David Mollitor created CSV-285:
--
Summary: Replace BufferedReader with Pushback Reader
Key: CSV-285
URL: https://issues.apache.org/jira/browse/CSV-285
Project: Commons CSV
Issue Type: Improvement
Reporter: David Mollitor
{{commons-csv}} uses, as its base {{Reader}} a {{BufferedReader}}, however the
more natural choice is {{PushBackReader}}.
{quote}
This is useful in situations where it is convenient for a fragment of code to
read an indefinite number of data bytes that are delimited by a particular byte
value; after reading the terminating byte, the code fragment can "unread" it,
so that the next read operation on the input stream will reread the byte that
was pushed back. For example, bytes representing the characters constituting an
identifier might be terminated by a byte representing an operator character; a
method whose job is to read just an identifier can read until it sees the
operator and then push the operator back to be re-read.
{quote}
https://docs.oracle.com/javase/8/docs/api/java/io/PushbackInputStream.html
{{commons-csv}} currently implements these "pushback" features on top of a
{{BufferedReader}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-vfs] garydgregory commented on pull request #20: AbstractFileObject: call doGetType() without holding the lock
garydgregory commented on pull request #20: URL: https://github.com/apache/commons-vfs/pull/20#issuecomment-880989991 I am trying to digest this into manageable chunks and I see a standalone edit to `SftpFileObject` that adds `synchronized` to three method declarations. Those three methods deal with the mutable and thread-unsafe `com.jcraft.jsch.SftpATTRS`. Why just those three methods? I do not know but it seems that all access to this SftpATTRS should be synchronized, so I added `synchronized` to the methods that read or write the SftpATTRS instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #88: Fix for failed test cases when running with root
garydgregory commented on pull request #88: URL: https://github.com/apache/commons-vfs/pull/88#issuecomment-880974647 Hi @PeterAlfredLee If this is still a concern, may you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory edited a comment on pull request #88: Fix for failed test cases when running with root
garydgregory edited a comment on pull request #88: URL: https://github.com/apache/commons-vfs/pull/88#issuecomment-630785113 -1 This is way to restrictive and makes no sense to me: Only non-root users can perform certain tests? The root user should have all all rights over all files. What is the actual problem you are trying to solve? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #186: VFS-805 - HTTP seek always exhausts response
garydgregory commented on pull request #186: URL: https://github.com/apache/commons-vfs/pull/186#issuecomment-880973762 @Aklakan In git master now, with adjustments. TY for you PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #186: VFS-805 - HTTP seek always exhausts response
garydgregory closed pull request #186: URL: https://github.com/apache/commons-vfs/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (VFS-805) HTTP seek always exhausts response
[
https://issues.apache.org/jira/browse/VFS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-805.
-
Fix Version/s: 2.9.0
Resolution: Fixed
> HTTP seek always exhausts response
> --
>
> Key: VFS-805
> URL: https://issues.apache.org/jira/browse/VFS-805
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Claus Stadler
>Priority: Major
> Fix For: 2.9.0
>
>
> Seeking on an HTTP resource always downloads ALL content if a Content-Length
> header is present. The problem is that seeking closes the current input
> stream which eventually ends up in ContentLengthInputStream.close() of the
> (ancient) http client library.
>
> To be clear, the problem is actually not with the seek itself, but with the
> underlying close implementation that always exhausts the HTTP response body.
> See the example below.
>
> My use case is to perform binary search on sorted datasets on the Web (RDF
> data in sorted ntriple syntax) - the binary search works locally and *in
> principle* works on HTTP resources abstracted with VFS2, but the seek
> implementation that downloads *ALL* data (in my case several GBs)
> unfortunately defeats the purpose :(
>
> From org.apache.commons.httpclient.ContentLengthInputStream
> (commons-httpclient-3.1):
> {code:java}
> public void close() throws IOException {
> if (!closed) {
> try {
> ChunkedInputStream.exhaustInputStream(this);
> } finally {
> // close after above so that we don't throw an exception
> trying
> // to read after closed!
> closed = true;
> }
> }
> }
> {code}
> Example:
> {code:java}
> public static void main(String[] args) throws Exception {
> String url = "http://localhost/large-file-2gb.txt;;
> FileSystemManager fsManager = VFS.getManager();
>
> try (FileObject file = fsManager.resolveFile(url)) {
> try (RandomAccessContent r =
> file.getContent().getRandomAccessContent(RandomAccessMode.READ)) {
>
> StopWatch sw1 = StopWatch.createStarted();
> r.seek(20);
> System.out.println("Initial seek: " +
> sw1.getTime(TimeUnit.MILLISECONDS));
> StopWatch sw2 = StopWatch.createStarted();
> byte[] bytes = new byte[100];
> r.readFully(bytes);
> System.out.println("Read: " +
> sw2.getTime(TimeUnit.MILLISECONDS));
>
> StopWatch sw3 = StopWatch.createStarted();
> r.seek(100);
> System.out.println("Subsequent seek: " +
> sw3.getTime(TimeUnit.MILLISECONDS));
> }
> }
> System.out.println("Done");
> }
> {code}
> Output (times in milliseconds):
> {code}
> Initial seek: 0
> Read: 4
> Subsequent seek: 2538
> Done
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-vfs] garydgregory removed a comment on pull request #91: VFS-676 : change dependency from java.util.zip to Commons Compress
garydgregory removed a comment on pull request #91: URL: https://github.com/apache/commons-vfs/pull/91#issuecomment-634679615 Before we -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #53: [VFS-398] FtpFileObject.getChildren() fails when a folder contains a file with a colon in the name
garydgregory commented on pull request #53: URL: https://github.com/apache/commons-vfs/pull/53#issuecomment-880969376 @amiraroshan ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] XenoAmess edited a comment on pull request #7: move maven-javadoc-plugin to
XenoAmess edited a comment on pull request #7: URL: https://github.com/apache/commons-parent/pull/7#issuecomment-880920064 > @XenoAmess > May you please rebase on master and test? TY! @garydgregory rebase/test done. 15+ hours/day, 6 days/week working in these months. sorry for the delay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] XenoAmess commented on pull request #7: move maven-javadoc-plugin to
XenoAmess commented on pull request #7: URL: https://github.com/apache/commons-parent/pull/7#issuecomment-880920064 > @XenoAmess > May you please rebase on master and test? TY! @garydgregory rebase/test done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (CODEC-302) MurmurHash2.hash32 can return negative
[ https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iris Scholer closed CODEC-302. -- Resolution: Not A Bug Once converted to an unsigned string the int hash works fine. > MurmurHash2.hash32 can return negative > -- > > Key: CODEC-302 > URL: https://issues.apache.org/jira/browse/CODEC-302 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.15 >Reporter: Iris Scholer >Priority: Major > Attachments: MurmurTest.java, test-screenshot.png > > > When running hash32, many values return a negative hash. Since the original > implementation used unsigned values, this is unintended behavior and breaks > compatibility with other implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CODEC-302) MurmurHash2.hash32 can return negative
[ https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381487#comment-17381487 ] Iris Scholer commented on CODEC-302: Ah. I seem to have forgotten to update the hash from the last test I did. This resolves the issue. Thank you guys for dealing with me, I'll close the issue. > MurmurHash2.hash32 can return negative > -- > > Key: CODEC-302 > URL: https://issues.apache.org/jira/browse/CODEC-302 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.15 >Reporter: Iris Scholer >Priority: Major > Attachments: MurmurTest.java, test-screenshot.png > > > When running hash32, many values return a negative hash. Since the original > implementation used unsigned values, this is unintended behavior and breaks > compatibility with other implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VFS-784) SSL Connection failing with http4 provider with squid proxy nginx combination
[
https://issues.apache.org/jira/browse/VFS-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-784.
-
Fix Version/s: 2.8.1
Resolution: Fixed
> SSL Connection failing with http4 provider with squid proxy nginx combination
> -
>
> Key: VFS-784
> URL: https://issues.apache.org/jira/browse/VFS-784
> Project: Commons VFS
> Issue Type: Bug
>Reporter: satish bhor
>Priority: Major
> Fix For: 2.8.1
>
>
> Below error throw with nginx/squid configs
> {code:java}
> at
> org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1383)
> at
> org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1383)
> at
> org.apache.commons.vfs2.provider.AbstractFileObject.getOutputStream(AbstractFileObject.java:1265)
> at
> org.apache.commons.vfs2.provider.DefaultFileContent.buildOutputStream(DefaultFileContent.java:540)
> at
> org.apache.commons.vfs2.provider.DefaultFileContent.getOutputStream(DefaultFileContent.java:406)
> at
> org.apache.commons.vfs2.provider.DefaultFileContent.getOutputStream(DefaultFileContent.java:394)
> at
> org.apache.commons.vfs2.provider.VFSExample.main(VFSExample.java:44)Caused
> by: org.apache.commons.vfs2.FileSystemException: Unknown message with code
> "sun.security.validator.ValidatorException: PKIX path building failed:
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find
> valid certification path to requested target". at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.executeRequest(Webdav4FileObject.java:473)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.getProperties(Webdav4FileObject.java:503)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.getProperties(Webdav4FileObject.java:494)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.getProperty(Webdav4FileObject.java:528)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.getProperty(Webdav4FileObject.java:533)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.isDirectory(Webdav4FileObject.java:567)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.doGetType(Webdav4FileObject.java:333)
> at
> org.apache.commons.vfs2.provider.AbstractFileObject.getType(AbstractFileObject.java:1377)
> ... 5 moreCaused by: javax.net.ssl.SSLHandshakeException:
> sun.security.validator.ValidatorException: PKIX path building failed:
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find
> valid certification path to requested target at
> sun.security.ssl.Alerts.getSSLException(Alerts.java:192) at
> sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1946) at
> sun.security.ssl.Handshaker.fatalSE(Handshaker.java:316) at
> sun.security.ssl.Handshaker.fatalSE(Handshaker.java:310) at
> sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1639)
> at
> sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:223)
> at sun.security.ssl.Handshaker.processLoop(Handshaker.java:1037) at
> sun.security.ssl.Handshaker.process_record(Handshaker.java:965) at
> sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1064) at
> sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1367)
> at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1395) at
> sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1379) at
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:436)
> at
> org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.upgrade(DefaultHttpClientConnectionOperator.java:191)
> at
> org.apache.http.impl.conn.PoolingHttpClientConnectionManager.upgrade(PoolingHttpClientConnectionManager.java:392)
> at
> org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:428)
> at
> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
> at
> org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186) at
> org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89) at
> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
> at
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
> at
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
> at
> org.apache.commons.vfs2.provider.http4.Http4FileObject.executeHttpUriRequest(Http4FileObject.java:231)
> at
> org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.executeRequest(Webdav4FileObject.java:459)
> ... 12 moreCaused by: sun.security.validator.ValidatorException: PKIX path
>
[jira] [Commented] (CODEC-302) MurmurHash2.hash32 can return negative
[
https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381473#comment-17381473
]
Gilles Sadowski commented on CODEC-302:
---
On [http://murmurhash.shorelabs.com/] the string
{noformat}
This test should return positive.
{noformat}
and seed
{noformat}
1
{noformat}
return
{noformat}
3461248272
{noformat}
i.e. the same output as
{code:java}
final int hash = MurmurHash2.hash32(string.getBytes(StandardCharsets.UTF_8),
string.length(), 1);
System.out.println(Integer.toUnsignedString(hash));
{code}
from Commons Codec.
> MurmurHash2.hash32 can return negative
> --
>
> Key: CODEC-302
> URL: https://issues.apache.org/jira/browse/CODEC-302
> Project: Commons Codec
> Issue Type: Bug
>Affects Versions: 1.15
>Reporter: Iris Scholer
>Priority: Major
> Attachments: MurmurTest.java, test-screenshot.png
>
>
> When running hash32, many values return a negative hash. Since the original
> implementation used unsigned values, this is unintended behavior and breaks
> compatibility with other implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-vfs] garydgregory merged pull request #119: VFS-784 - Pass SSL connection factory to PoolingHttpClientConnectionManager
garydgregory merged pull request #119: URL: https://github.com/apache/commons-vfs/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #186: VFS-805 - HTTP seek always exhausts response
garydgregory commented on a change in pull request #186:
URL: https://github.com/apache/commons-vfs/pull/186#discussion_r670587749
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/MonitoredHttpResponseContentInputStream.java
##
@@ -38,8 +41,25 @@ public MonitoredHttpResponseContentInputStream(final
ClassicHttpResponse httpRes
this.httpResponse = httpResponse;
}
+/**
+ * Prevent closing the stream itself if the httpResponse is closeable.
+ * Closing the stream may consume all remaining data no matter how large
(VFS-805).
+ */
+@Override
+protected void closeSuper() throws IOException {
+// Suppressed close() invocation on the underlying input stream
+}
+
@Override
protected void onClose() throws IOException {
+// Replace the response's entity with a dummy entity in order to
prevent
+// exhausting all data (VFS-805)
+// Note: HC 5.1 introduces a dedicated NullEntity class
Review comment:
@Aklakan
Our HC 5 code base is now on HC 5.1
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/MonitoredHttpResponseContentInputStream.java
##
@@ -38,8 +41,25 @@ public MonitoredHttpResponseContentInputStream(final
ClassicHttpResponse httpRes
this.httpResponse = httpResponse;
}
+/**
+ * Prevent closing the stream itself if the httpResponse is closeable.
+ * Closing the stream may consume all remaining data no matter how large
(VFS-805).
+ */
+@Override
+protected void closeSuper() throws IOException {
+// Suppressed close() invocation on the underlying input stream
+}
+
@Override
protected void onClose() throws IOException {
+// Replace the response's entity with a dummy entity in order to
prevent
+// exhausting all data (VFS-805)
+// Note: HC 5.1 introduces a dedicated NullEntity class
+HttpEntity nullEntity = new ByteArrayEntity(new byte[0],
ContentType.APPLICATION_OCTET_STREAM);
+
Review comment:
No need for extra blank lines.
##
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/MonitoredHttpResponseContentInputStream.java
##
@@ -38,8 +41,25 @@ public MonitoredHttpResponseContentInputStream(final
ClassicHttpResponse httpRes
this.httpResponse = httpResponse;
}
+/**
+ * Prevent closing the stream itself if the httpResponse is closeable.
+ * Closing the stream may consume all remaining data no matter how large
(VFS-805).
+ */
+@Override
+protected void closeSuper() throws IOException {
+// Suppressed close() invocation on the underlying input stream
+}
+
@Override
protected void onClose() throws IOException {
+// Replace the response's entity with a dummy entity in order to
prevent
+// exhausting all data (VFS-805)
+// Note: HC 5.1 introduces a dedicated NullEntity class
+HttpEntity nullEntity = new ByteArrayEntity(new byte[0],
ContentType.APPLICATION_OCTET_STREAM);
+
+httpResponse.setEntity(nullEntity);
Review comment:
```
httpResponse.setEntity(NullEntity.INSTANCE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #181: [COMMONSSITE-145]upgrade checkstyle
garydgregory closed pull request #181: URL: https://github.com/apache/commons-vfs/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #181: [COMMONSSITE-145]upgrade checkstyle
garydgregory commented on pull request #181: URL: https://github.com/apache/commons-vfs/pull/181#issuecomment-880790640 Done elsewhere. TY though :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #184: Bump sshd-core from 0.8.0 to 2.7.0
garydgregory commented on pull request #184: URL: https://github.com/apache/commons-vfs/pull/184#issuecomment-880789382 We need help porting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory edited a comment on pull request #193: Bump slf4j.version from 1.7.26 to 1.7.31
garydgregory edited a comment on pull request #193: URL: https://github.com/apache/commons-vfs/pull/193#issuecomment-880788679 Closing: SLF4J breaks binary compatibility. ``` java.lang.AbstractMethodError: org.slf4j.impl.Log4jLoggerAdapter.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #193: Bump slf4j.version from 1.7.26 to 1.7.31
dependabot[bot] commented on pull request #193: URL: https://github.com/apache/commons-vfs/pull/193#issuecomment-880788705 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #193: Bump slf4j.version from 1.7.26 to 1.7.31
garydgregory closed pull request #193: URL: https://github.com/apache/commons-vfs/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #193: Bump slf4j.version from 1.7.26 to 1.7.31
garydgregory commented on pull request #193: URL: https://github.com/apache/commons-vfs/pull/193#issuecomment-880788679 Closing: SLF4J breaks binary compatiblity. ``` java.lang.AbstractMethodError: org.slf4j.impl.Log4jLoggerAdapter.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #188: Bump slf4j-simple from 1.7.26 to 1.7.31
garydgregory commented on pull request #188: URL: https://github.com/apache/commons-vfs/pull/188#issuecomment-880788533 Closing: SLF4J breaks binary compatiblity. ``` java.lang.AbstractMethodError: org.slf4j.impl.Log4jLoggerAdapter.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #188: Bump slf4j-simple from 1.7.26 to 1.7.31
garydgregory closed pull request #188: URL: https://github.com/apache/commons-vfs/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #188: Bump slf4j-simple from 1.7.26 to 1.7.31
dependabot[bot] commented on pull request #188: URL: https://github.com/apache/commons-vfs/pull/188#issuecomment-880788553 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #189: Bump slf4j-log4j12 from 1.5.11 to 1.7.31
garydgregory closed pull request #189: URL: https://github.com/apache/commons-vfs/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #189: Bump slf4j-log4j12 from 1.5.11 to 1.7.31
garydgregory commented on pull request #189: URL: https://github.com/apache/commons-vfs/pull/189#issuecomment-880788312 Closing: SLF4J breaks binary compatiblity. ``` java.lang.AbstractMethodError: org.slf4j.impl.Log4jLoggerAdapter.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #189: Bump slf4j-log4j12 from 1.5.11 to 1.7.31
dependabot[bot] commented on pull request #189: URL: https://github.com/apache/commons-vfs/pull/189#issuecomment-880788395 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #199: Bump checkstyle from 8.41.1 to 8.44
garydgregory commented on pull request #199: URL: https://github.com/apache/commons-vfs/pull/199#issuecomment-880786766 Done elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #199: Bump checkstyle from 8.41.1 to 8.44
dependabot[bot] commented on pull request #199: URL: https://github.com/apache/commons-vfs/pull/199#issuecomment-880786796 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #199: Bump checkstyle from 8.41.1 to 8.44
garydgregory closed pull request #199: URL: https://github.com/apache/commons-vfs/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1597) Low-discrepancy sequence
[
https://issues.apache.org/jira/browse/MATH-1597?focusedWorklogId=623070=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623070
]
ASF GitHub Bot logged work on MATH-1597:
Author: ASF GitHub Bot
Created on: 15/Jul/21 14:03
Start Date: 15/Jul/21 14:03
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #190:
URL: https://github.com/apache/commons-math/pull/190#issuecomment-874527665
[](https://coveralls.io/builds/41399708)
Coverage increased (+0.02%) to 90.46% when pulling
**ac65dcabb5ff4e77c7f1aad7e2d26c57d3e395af on samyBadjoudj:feature/MATH-1597**
into **dcf83c02a7a341ce40d02521a9e8d4cb863e4728 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623070)
Time Spent: 2h 40m (was: 2.5h)
> Low-discrepancy sequence
>
>
> Key: MATH-1597
> URL: https://issues.apache.org/jira/browse/MATH-1597
> Project: Commons Math
> Issue Type: Sub-task
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 4.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Two low-discrepancy sequences are implemented in Commons Math (in package
> {{o.a.c.math4.legacy.random}}:
> * {{SobolSequenceGenerator}}
> * {{HaltonSequenceGenerator}}
> They both provide several methods:
> * {{nextVector()}}
> * {{skipTo(int)}}
> * {{getNextIndex()}}
> of which only the first is part of their common API through the
> {{RandomVectorGenerator}}.
> I propose to create an interface that would better represent the specific
> concept (and avoid the confusion with pseudo-random generators):
> {code}
> public interface LowDiscrepancySequence extends Supplier { /* ...
> */}
> {code}
> Thus, instead of class {{SobolSequenceGenerator}} we'd have:
> {code}
> public class SobolSequence implements LowDiscrepancySequence {
> // ...
> }
> {code}
> This functionality could be moved to a new {{o.a.c.m.legacy.quasirandom}}
> package (?).
> Method {{skipTo}} could be replaced with an API similar to Commons RNG
> {{JumpableUniformRandomProvider}} (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] coveralls edited a comment on pull request #190: MATH-1597: LowDiscrepancySequence supplier/jump for Halton and Sobol
coveralls edited a comment on pull request #190: URL: https://github.com/apache/commons-math/pull/190#issuecomment-874527665 [](https://coveralls.io/builds/41399708) Coverage increased (+0.02%) to 90.46% when pulling **ac65dcabb5ff4e77c7f1aad7e2d26c57d3e395af on samyBadjoudj:feature/MATH-1597** into **dcf83c02a7a341ce40d02521a9e8d4cb863e4728 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request #199: Bump checkstyle from 8.41.1 to 8.44
dependabot[bot] opened a new pull request #199: URL: https://github.com/apache/commons-vfs/pull/199 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.41.1 to 8.44. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.44 https://checkstyle.org/releasenotes.html#Release_8.44;>https://checkstyle.org/releasenotes.html#Release_8.44 checkstyle-8.43 https://checkstyle.org/releasenotes.html#Release_8.43;>https://checkstyle.org/releasenotes.html#Release_8.43 checkstyle-8.42 https://checkstyle.org/releasenotes.html#Release_8.42;>https://checkstyle.org/releasenotes.html#Release_8.42 Commits https://github.com/checkstyle/checkstyle/commit/c32a729001aebe12741ad9881c7a36cdba0075c4;>c32a729 [maven-release-plugin] prepare release checkstyle-8.44 https://github.com/checkstyle/checkstyle/commit/94b60c17b5214cb4700b8dce0344577bc98283d0;>94b60c1 doc: erlease notes 8.44 https://github.com/checkstyle/checkstyle/commit/28fe68362d6d177b7add72ceebe09d3636f54084;>28fe683 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9142;>#9142: Migrate to Truth in AutomaticBeanTest https://github.com/checkstyle/checkstyle/commit/0d9b3afe600b247eaccf758a0c6ae2bc8409a268;>0d9b3af config: bump sevntu to 1.40.0 https://github.com/checkstyle/checkstyle/commit/6f2ce0991dbf65522194d08f3a2f4e155e532112;>6f2ce09 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10174;>#10174: Updated inputs for AnnotationLocationCheckTest https://github.com/checkstyle/checkstyle/commit/8bd7b36c963b5b9c65a79aeb5f1c1204ce1b049b;>8bd7b36 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10175;>#10175: Updated inputs for ArrayTypeStyleCheckTest https://github.com/checkstyle/checkstyle/commit/d9ebde55f07fce2fd541cf6d10d35806c2b3ff4d;>d9ebde5 minor: fix IDEA violations https://github.com/checkstyle/checkstyle/commit/f6068e04e8388c30cb5d98397fb623b0b445d690;>f6068e0 minor: remove old files from circleci config https://github.com/checkstyle/checkstyle/commit/b3ddc70feafc7cbe317f5eddc7c51b4a606b8dcc;>b3ddc70 infra: remove Jenkins file as it is too stale https://github.com/checkstyle/checkstyle/commit/c4e4eecf5ed04515bfea52b2db745c0c10f1;>c4e4eec minor: fixed TeamCity violation Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.41.1...checkstyle-8.44;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #198: Bump spotbugs from 4.2.2 to 4.3.0
dependabot[bot] commented on pull request #198: URL: https://github.com/apache/commons-vfs/pull/198#issuecomment-880719321 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #198: Bump spotbugs from 4.2.2 to 4.3.0
garydgregory commented on pull request #198: URL: https://github.com/apache/commons-vfs/pull/198#issuecomment-880719294 Done elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #198: Bump spotbugs from 4.2.2 to 4.3.0
garydgregory closed pull request #198: URL: https://github.com/apache/commons-vfs/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] garydgregory merged pull request #89: Bump actions/cache from 2.1.4 to 2.1.6
garydgregory merged pull request #89: URL: https://github.com/apache/commons-beanutils/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] closed pull request #88: Bump actions/setup-java from 1.4.3 to 2.1.0
dependabot[bot] closed pull request #88: URL: https://github.com/apache/commons-beanutils/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] commented on pull request #88: Bump actions/setup-java from 1.4.3 to 2.1.0
dependabot[bot] commented on pull request #88: URL: https://github.com/apache/commons-beanutils/pull/88#issuecomment-880712126 Looks like actions/setup-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (CSV-278) Reuse Buffers in Lexer for Delimiter Detection
[ https://issues.apache.org/jira/browse/CSV-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CSV-278. - Fix Version/s: 1.9.0 Resolution: Fixed > Reuse Buffers in Lexer for Delimiter Detection > -- > > Key: CSV-278 > URL: https://issues.apache.org/jira/browse/CSV-278 > Project: Commons CSV > Issue Type: Sub-task >Reporter: David Mollitor >Priority: Minor > Fix For: 1.9.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > When a character is read, and it could be the first character of the > delimiter, a look-ahead is performed on the stream to determine if this will > be the delimiter. This look ahead initiates a new buffer to read into for > each call. This can cause overhead and much more turn in the heap. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CSV-278) Reuse Buffers in Lexer for Delimiter Detection
[
https://issues.apache.org/jira/browse/CSV-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381356#comment-17381356
]
Gary D. Gregory commented on CSV-278:
-
Here are the results for my runs.
-- BEFORE APPLYING PR https://github.com/apache/commons-csv/pull/162
{noformat}
# JMH version: 1.32
# VM version: JDK 1.8.0_292, OpenJDK 64-Bit Server VM, 25.292-b10
# VM invoker:
/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre/bin/java
# VM options: -server -Xms1024M -Xmx1024M
# Blackhole mode: full + dont-inline hint
# Warmup: 5 iterations, 10 s each
# Measurement: 20 iterations, 10 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op
# Benchmark: org.apache.commons.csv.CSVBenchmark.parseCommonsCSV
# Run progress: 0.00% complete, ETA 00:04:10
# Fork: 1 of 1
# Warmup Iteration 1: 2078.928 ms/op
# Warmup Iteration 2: 1735.951 ms/op
# Warmup Iteration 3: 1731.464 ms/op
# Warmup Iteration 4: 1732.816 ms/op
# Warmup Iteration 5: 1732.228 ms/op
Iteration 1: 1731.764 ms/op
Iteration 2: 1732.523 ms/op
Iteration 3: 1734.367 ms/op
Iteration 4: 1732.795 ms/op
Iteration 5: 1731.759 ms/op
Iteration 6: 1731.918 ms/op
Iteration 7: 1759.762 ms/op
Iteration 8: 1733.014 ms/op
Iteration 9: 1760.990 ms/op
Iteration 10: 1734.031 ms/op
Iteration 11: 1731.014 ms/op
Iteration 12: 1733.838 ms/op
Iteration 13: 1884.243 ms/op
Iteration 14: 1794.986 ms/op
Iteration 15: 1725.279 ms/op
Iteration 16: 1725.826 ms/op
Iteration 17: 1726.203 ms/op
Iteration 18: 1725.926 ms/op
Iteration 19: 1727.094 ms/op
Iteration 20: 1726.190 ms/op
Result "org.apache.commons.csv.CSVBenchmark.parseCommonsCSV":
1744.176 ±(99.9%) 32.134 ms/op [Average]
(min, avg, max) = (1725.279, 1744.176, 1884.243), stdev = 37.006
CI (99.9%): [1712.042, 1776.310] (assumes normal distribution)
# Run complete. Total time: 00:04:23
REMEMBER: The numbers below are just data. To gain reusable insights, you need
to follow up on
why the numbers are the way they are. Use profilers (see -prof, -lprof), design
factorial
experiments, perform baseline and negative tests that provide experimental
control, make sure
the benchmarking environment is safe on JVM/OS/HW level, ask for reviews from
the domain experts.
Do not assume the numbers tell you what you want them to tell.
Benchmark Mode Cnt ScoreError Units
CSVBenchmark.parseCommonsCSV avgt 20 1744.176 ± 32.134 ms/op
{noformat}
-- AFTER APPLYING PR https://github.com/apache/commons-csv/pull/162
{noformat}
# JMH version: 1.32
# VM version: JDK 1.8.0_292, OpenJDK 64-Bit Server VM, 25.292-b10
# VM invoker:
/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre/bin/java
# VM options: -server -Xms1024M -Xmx1024M
# Blackhole mode: full + dont-inline hint
# Warmup: 5 iterations, 10 s each
# Measurement: 20 iterations, 10 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op
# Benchmark: org.apache.commons.csv.CSVBenchmark.parseCommonsCSV
# Run progress: 0.00% complete, ETA 00:04:10
# Fork: 1 of 1
# Warmup Iteration 1: 1797.286 ms/op
# Warmup Iteration 2: 1530.711 ms/op
# Warmup Iteration 3: 1523.519 ms/op
# Warmup Iteration 4: 1558.774 ms/op
# Warmup Iteration 5: 1528.387 ms/op
Iteration 1: 1559.851 ms/op
Iteration 2: 1524.913 ms/op
Iteration 3: 1524.326 ms/op
Iteration 4: 1525.966 ms/op
Iteration 5: 1530.290 ms/op
Iteration 6: 1525.912 ms/op
Iteration 7: 1525.376 ms/op
Iteration 8: 1525.431 ms/op
Iteration 9: 1525.917 ms/op
Iteration 10: 1526.005 ms/op
Iteration 11: 1532.988 ms/op
Iteration 12: 1517.567 ms/op
Iteration 13: 1516.962 ms/op
Iteration 14: 1520.299 ms/op
Iteration 15: 1517.392 ms/op
Iteration 16: 1517.772 ms/op
Iteration 17: 1517.473 ms/op
Iteration 18: 1518.316 ms/op
Iteration 19: 1517.181 ms/op
Iteration 20: 1542.505 ms/op
Result "org.apache.commons.csv.CSVBenchmark.parseCommonsCSV":
1525.622 ±(99.9%) 8.962 ms/op [Average]
(min, avg, max) = (1516.962, 1525.622, 1559.851), stdev = 10.321
CI (99.9%): [1516.660, 1534.585] (assumes normal distribution)
# Run complete. Total time: 00:04:29
REMEMBER: The numbers below are just data. To gain reusable insights, you need
to follow up on
why the numbers are the way they are. Use profilers (see -prof, -lprof), design
factorial
experiments, perform baseline and negative tests that provide experimental
control, make sure
the benchmarking environment is safe on JVM/OS/HW level, ask for reviews from
the domain experts.
Do not assume the numbers tell you what you want them to tell.
Benchmark Mode Cnt Score Error Units
CSVBenchmark.parseCommonsCSV avgt 20 1525.622 ± 8.962 ms/op
{noformat}
> Reuse Buffers in Lexer for Delimiter Detection
>
[jira] [Work logged] (CSV-278) Reuse Buffers in Lexer for Delimiter Detection
[ https://issues.apache.org/jira/browse/CSV-278?focusedWorklogId=623056=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623056 ] ASF GitHub Bot logged work on CSV-278: -- Author: ASF GitHub Bot Created on: 15/Jul/21 13:41 Start Date: 15/Jul/21 13:41 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #162: URL: https://github.com/apache/commons-csv/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 623056) Time Spent: 2h 40m (was: 2.5h) > Reuse Buffers in Lexer for Delimiter Detection > -- > > Key: CSV-278 > URL: https://issues.apache.org/jira/browse/CSV-278 > Project: Commons CSV > Issue Type: Sub-task >Reporter: David Mollitor >Priority: Minor > Time Spent: 2h 40m > Remaining Estimate: 0h > > When a character is read, and it could be the first character of the > delimiter, a look-ahead is performed on the stream to determine if this will > be the delimiter. This look ahead initiates a new buffer to read into for > each call. This can cause overhead and much more turn in the heap. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-csv] garydgregory merged pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
garydgregory merged pull request #162: URL: https://github.com/apache/commons-csv/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381346#comment-17381346 ] Gilles Sadowski commented on MATH-1563: --- bq. The existing model has been reversed engineered from the source code. Thanks. bq. I have proposed few alterations to the existing model as well as few additions. Could you please highligh the proposed enhancements in a post to the "dev" ML? [I don't know much this part of the library, except for what has been discussed recently.] bq. [UML] diagrams as attached below. It's better to provide them in a standard format (e.g. PNG). bq. I have used umlet (https://www.umlet.com/ ) for drawing the diagrams. I'm out of luck with that tool (it prints a stack trace on trying to open a new file, it does not close, it doesn't display file "GA-OperatorModel.uxf")... > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-Model.uxf, GA-OperatorModel.uxf, > GA-OperatorModel.uxf, GA-Overview.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=623042=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623042
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 13:17
Start Date: 15/Jul/21 13:17
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r670451842
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests [CSV-265] {@link CSVRecord#getCharacterPosition()} returns the
correct position after encountering a comment.
+ */
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+// @formatter:off
+final String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+final CSVFormat csvFormat = CSVFormat.DEFAULT.builder()
+.setCommentMarker('#')
+.setHeader()
+.setSkipHeaderRecord(true)
+.build();
+// @formatter:on
+try (final CSVParser parser = csvFormat.parse(new StringReader(csv))) {
+final Iterator itr = parser.iterator();
+final CSVRecord record1 = itr.next();
+assertEquals(csv.indexOf("# Comment2"),
record1.getCharacterPosition());
+final CSVRecord record2 = itr.next();
+assertEquals(csv.indexOf("# Comment3"),
record2.getCharacterPosition());
+}
Review comment:
I'm trying to better understand what you are trying to do here... may
you please add a test with comments that span multiple lines; for example,
input like:
```
# one
# two
data,data,data
# three
# four
data,data,data
```
TY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623042)
Time Spent: 1h 50m (was: 1h 40m)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=623041=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623041
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 13:17
Start Date: 15/Jul/21 13:17
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r670451842
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests [CSV-265] {@link CSVRecord#getCharacterPosition()} returns the
correct position after encountering a comment.
+ */
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+// @formatter:off
+final String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+final CSVFormat csvFormat = CSVFormat.DEFAULT.builder()
+.setCommentMarker('#')
+.setHeader()
+.setSkipHeaderRecord(true)
+.build();
+// @formatter:on
+try (final CSVParser parser = csvFormat.parse(new StringReader(csv))) {
+final Iterator itr = parser.iterator();
+final CSVRecord record1 = itr.next();
+assertEquals(csv.indexOf("# Comment2"),
record1.getCharacterPosition());
+final CSVRecord record2 = itr.next();
+assertEquals(csv.indexOf("# Comment3"),
record2.getCharacterPosition());
+}
Review comment:
I'm trying to better understand what you are trying to do here... may
you please add a test with comments that span multiple lines; for example,
input like:
```
# one
# two
data,data,data
# three
# foor
data,data,data
```
TY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623041)
Time Spent: 1h 40m (was: 1.5h)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] garydgregory commented on a change in pull request #120: [CSV-265] Update buffer position when reading line comment
garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r670451842
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests [CSV-265] {@link CSVRecord#getCharacterPosition()} returns the
correct position after encountering a comment.
+ */
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+// @formatter:off
+final String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+final CSVFormat csvFormat = CSVFormat.DEFAULT.builder()
+.setCommentMarker('#')
+.setHeader()
+.setSkipHeaderRecord(true)
+.build();
+// @formatter:on
+try (final CSVParser parser = csvFormat.parse(new StringReader(csv))) {
+final Iterator itr = parser.iterator();
+final CSVRecord record1 = itr.next();
+assertEquals(csv.indexOf("# Comment2"),
record1.getCharacterPosition());
+final CSVRecord record2 = itr.next();
+assertEquals(csv.indexOf("# Comment3"),
record2.getCharacterPosition());
+}
Review comment:
I'm trying to better understand what you are trying to do here... may
you please add a test with comments that span multiple lines; for example,
input like:
```
# one
# two
data,data,data
# three
# four
data,data,data
```
TY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on a change in pull request #120: [CSV-265] Update buffer position when reading line comment
garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r670451842
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests [CSV-265] {@link CSVRecord#getCharacterPosition()} returns the
correct position after encountering a comment.
+ */
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+// @formatter:off
+final String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+final CSVFormat csvFormat = CSVFormat.DEFAULT.builder()
+.setCommentMarker('#')
+.setHeader()
+.setSkipHeaderRecord(true)
+.build();
+// @formatter:on
+try (final CSVParser parser = csvFormat.parse(new StringReader(csv))) {
+final Iterator itr = parser.iterator();
+final CSVRecord record1 = itr.next();
+assertEquals(csv.indexOf("# Comment2"),
record1.getCharacterPosition());
+final CSVRecord record2 = itr.next();
+assertEquals(csv.indexOf("# Comment3"),
record2.getCharacterPosition());
+}
Review comment:
I'm trying to better understand what you are trying to do here... may
you please add a test with comments that span multiple lines; for example,
input like:
```
# one
# two
data,data,data
# three
# foor
data,data,data
```
TY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #97: improve readability of StackMap toString() output
garydgregory merged pull request #97: URL: https://github.com/apache/commons-bcel/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CSV-284.
-
Fix Version/s: 1.9.0
Resolution: Fixed
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Fix For: 1.9.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?focusedWorklogId=623037=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623037
]
ASF GitHub Bot logged work on CSV-284:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 13:04
Start Date: 15/Jul/21 13:04
Worklog Time Spent: 10m
Work Description: garydgregory merged pull request #168:
URL: https://github.com/apache/commons-csv/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 623037)
Time Spent: 50m (was: 40m)
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] garydgregory merged pull request #168: CSV-284: Formalize PerformanceTest
garydgregory merged pull request #168: URL: https://github.com/apache/commons-csv/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (TEXT-207) Include DoubleFormats utility from commons-geometry
[
https://issues.apache.org/jira/browse/TEXT-207?focusedWorklogId=622989=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622989
]
ASF GitHub Bot logged work on TEXT-207:
---
Author: ASF GitHub Bot
Created on: 15/Jul/21 11:49
Start Date: 15/Jul/21 11:49
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #248:
URL: https://github.com/apache/commons-text/pull/248#discussion_r667588788
##
File path: src/test/java/org/apache/commons/text/numbers/ParsedDecimalTest.java
##
@@ -0,0 +1,764 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.numbers;
+
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.math.RoundingMode;
+import java.util.function.BiFunction;
+
+import org.apache.commons.rng.UniformRandomProvider;
+import org.apache.commons.rng.simple.RandomSource;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.function.Executable;
+
+class ParsedDecimalTest {
+
+@Test
+void testFrom() {
+// act/assert
+checkFrom(0.0, "0", 0);
+
+checkFrom(1.0, "1", 0);
+checkFrom(10.0, "1", 1);
+checkFrom(100.0, "1", 2);
+checkFrom(1000.0, "1", 3);
+checkFrom(1.0, "1", 4);
+
+checkFrom(0.1, "1", -1);
+checkFrom(0.01, "1", -2);
+checkFrom(0.001, "1", -3);
+checkFrom(0.0001, "1", -4);
+checkFrom(0.1, "1", -5);
+
+checkFrom(1.2, "12", -1);
+checkFrom(0.00971, "971", -5);
+checkFrom(56300, "563", 2);
+
+checkFrom(123.0, "123", 0);
+checkFrom(1230.0, "123", 1);
+checkFrom(12300.0, "123", 2);
+checkFrom(123000.0, "123", 3);
+
+checkFrom(12.3, "123", -1);
+checkFrom(1.23, "123", -2);
+checkFrom(0.123, "123", -3);
+checkFrom(0.0123, "123", -4);
+
+checkFrom(1.987654321e270, "1987654321", 261);
+checkFrom(1.987654321e-270, "1987654321", -279);
+
+checkFrom(Math.PI, "3141592653589793", -15);
+checkFrom(Math.E, "2718281828459045", -15);
+
+checkFrom(Double.MAX_VALUE, "17976931348623157", 292);
+checkFrom(Double.MIN_VALUE, "49", -325);
+checkFrom(Double.MIN_NORMAL, "22250738585072014", -324);
+}
+
+@Test
+void testFrom_notFinite() {
+// arrange
+final String msg = "Double is not finite";
+
+// act/assert
+assertThrowsWithMessage(() -> ParsedDecimal.from(Double.NaN),
+IllegalArgumentException.class, msg);
+assertThrowsWithMessage(() ->
ParsedDecimal.from(Double.NEGATIVE_INFINITY),
+IllegalArgumentException.class, msg);
+assertThrowsWithMessage(() ->
ParsedDecimal.from(Double.POSITIVE_INFINITY),
+IllegalArgumentException.class, msg);
+}
+
+@Test
+void testIsZero() {
+// act/assert
+Assertions.assertTrue(ParsedDecimal.from(0.0).isZero());
+Assertions.assertTrue(ParsedDecimal.from(-0.0).isZero());
+
+Assertions.assertFalse(ParsedDecimal.from(1.0).isZero());
+Assertions.assertFalse(ParsedDecimal.from(-1.0).isZero());
+
+Assertions.assertFalse(ParsedDecimal.from(Double.MIN_NORMAL).isZero());
+
Assertions.assertFalse(ParsedDecimal.from(-Double.MIN_NORMAL).isZero());
+
+Assertions.assertFalse(ParsedDecimal.from(Double.MAX_VALUE).isZero());
+Assertions.assertFalse(ParsedDecimal.from(-Double.MIN_VALUE).isZero());
+}
+
+@Test
+void testRound_one() {
+// arrange
+final double a = 1e-10;
+final double b = -1;
+final double c = 1e10;
+
+// act/assert
+assertRound(a, -11, false, "1", -10);
+assertRound(a, -10, false, "1", -10);
+assertRound(a, -9, false, "0", 0);
+
+assertRound(b, -1, true, "1", 0);
+assertRound(b, 0, true, "1", 0);
+assertRound(b, 1, true, "0", 0);
+
+assertRound(c, 9, false, "1", 10);
+assertRound(c, 10, false, "1", 10);
+
[GitHub] [commons-text] kinow commented on a change in pull request #248: TEXT-207: adding DoubleFormat utility
kinow commented on a change in pull request #248:
URL: https://github.com/apache/commons-text/pull/248#discussion_r667588788
##
File path: src/test/java/org/apache/commons/text/numbers/ParsedDecimalTest.java
##
@@ -0,0 +1,764 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.numbers;
+
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.math.RoundingMode;
+import java.util.function.BiFunction;
+
+import org.apache.commons.rng.UniformRandomProvider;
+import org.apache.commons.rng.simple.RandomSource;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.function.Executable;
+
+class ParsedDecimalTest {
+
+@Test
+void testFrom() {
+// act/assert
+checkFrom(0.0, "0", 0);
+
+checkFrom(1.0, "1", 0);
+checkFrom(10.0, "1", 1);
+checkFrom(100.0, "1", 2);
+checkFrom(1000.0, "1", 3);
+checkFrom(1.0, "1", 4);
+
+checkFrom(0.1, "1", -1);
+checkFrom(0.01, "1", -2);
+checkFrom(0.001, "1", -3);
+checkFrom(0.0001, "1", -4);
+checkFrom(0.1, "1", -5);
+
+checkFrom(1.2, "12", -1);
+checkFrom(0.00971, "971", -5);
+checkFrom(56300, "563", 2);
+
+checkFrom(123.0, "123", 0);
+checkFrom(1230.0, "123", 1);
+checkFrom(12300.0, "123", 2);
+checkFrom(123000.0, "123", 3);
+
+checkFrom(12.3, "123", -1);
+checkFrom(1.23, "123", -2);
+checkFrom(0.123, "123", -3);
+checkFrom(0.0123, "123", -4);
+
+checkFrom(1.987654321e270, "1987654321", 261);
+checkFrom(1.987654321e-270, "1987654321", -279);
+
+checkFrom(Math.PI, "3141592653589793", -15);
+checkFrom(Math.E, "2718281828459045", -15);
+
+checkFrom(Double.MAX_VALUE, "17976931348623157", 292);
+checkFrom(Double.MIN_VALUE, "49", -325);
+checkFrom(Double.MIN_NORMAL, "22250738585072014", -324);
+}
+
+@Test
+void testFrom_notFinite() {
+// arrange
+final String msg = "Double is not finite";
+
+// act/assert
+assertThrowsWithMessage(() -> ParsedDecimal.from(Double.NaN),
+IllegalArgumentException.class, msg);
+assertThrowsWithMessage(() ->
ParsedDecimal.from(Double.NEGATIVE_INFINITY),
+IllegalArgumentException.class, msg);
+assertThrowsWithMessage(() ->
ParsedDecimal.from(Double.POSITIVE_INFINITY),
+IllegalArgumentException.class, msg);
+}
+
+@Test
+void testIsZero() {
+// act/assert
+Assertions.assertTrue(ParsedDecimal.from(0.0).isZero());
+Assertions.assertTrue(ParsedDecimal.from(-0.0).isZero());
+
+Assertions.assertFalse(ParsedDecimal.from(1.0).isZero());
+Assertions.assertFalse(ParsedDecimal.from(-1.0).isZero());
+
+Assertions.assertFalse(ParsedDecimal.from(Double.MIN_NORMAL).isZero());
+
Assertions.assertFalse(ParsedDecimal.from(-Double.MIN_NORMAL).isZero());
+
+Assertions.assertFalse(ParsedDecimal.from(Double.MAX_VALUE).isZero());
+Assertions.assertFalse(ParsedDecimal.from(-Double.MIN_VALUE).isZero());
+}
+
+@Test
+void testRound_one() {
+// arrange
+final double a = 1e-10;
+final double b = -1;
+final double c = 1e10;
+
+// act/assert
+assertRound(a, -11, false, "1", -10);
+assertRound(a, -10, false, "1", -10);
+assertRound(a, -9, false, "0", 0);
+
+assertRound(b, -1, true, "1", 0);
+assertRound(b, 0, true, "1", 0);
+assertRound(b, 1, true, "0", 0);
+
+assertRound(c, 9, false, "1", 10);
+assertRound(c, 10, false, "1", 10);
+assertRound(c, 11, false, "0", 0);
+}
+
+@Test
+void testRound_nine() {
+// arrange
+final double a = 9e-10;
+final double b = -9;
+final double c = 9e10;
+
+// act/assert
+assertRound(a, -11, false, "9", -10);
+assertRound(a, -10, false, "9", -10);
+assertRound(a, -9, false, "1", -9);
+
+assertRound(b, -1, true, "9", 0);
+
[jira] [Work logged] (TEXT-207) Include DoubleFormats utility from commons-geometry
[
https://issues.apache.org/jira/browse/TEXT-207?focusedWorklogId=622985=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622985
]
ASF GitHub Bot logged work on TEXT-207:
---
Author: ASF GitHub Bot
Created on: 15/Jul/21 11:34
Start Date: 15/Jul/21 11:34
Worklog Time Spent: 10m
Work Description: darkma773r commented on pull request #248:
URL: https://github.com/apache/commons-text/pull/248#issuecomment-880621515
@kinow, thanks for the detailed review! I've been busy recently so I haven't
been able to look at this yet. I'll try to get to it in the next few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622985)
Time Spent: 3h 50m (was: 3h 40m)
> Include DoubleFormats utility from commons-geometry
> ---
>
> Key: TEXT-207
> URL: https://issues.apache.org/jira/browse/TEXT-207
> Project: Commons Text
> Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> commons-geometry currently contains a
> [DoubleFormats|https://github.com/apache/commons-geometry/blob/master/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/utils/DoubleFormats.java]
> utility class in the {{commons-geometry-io-core}} module that produces
> standardized string representations of doubles for use in text-based data
> formats. It has the following features:
> - It is completely thread-safe.
> - It produces string in scientific, engineering, plain, or mixed (plain or
> scientific depending on value) formats.
> - Performance is comparable to {{DecimalFormat}} and {{BigDecimal}}.
> As mentioned on the dev mailing list, I believe that this class has broader
> applicability than just geometric data formats and would be a good fit for
> commons-text.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] darkma773r commented on pull request #248: TEXT-207: adding DoubleFormat utility
darkma773r commented on pull request #248: URL: https://github.com/apache/commons-text/pull/248#issuecomment-880621515 @kinow, thanks for the detailed review! I've been busy recently so I haven't been able to look at this yet. I'll try to get to it in the next few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory commented on pull request #51: Bump apache from 23 to 24
garydgregory commented on pull request #51: URL: https://github.com/apache/commons-parent/pull/51#issuecomment-880614810 Waiting for https://github.com/mojohaus/versions-maven-plugin/issues/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] opened a new pull request #51: Bump apache from 23 to 24
dependabot[bot] opened a new pull request #51: URL: https://github.com/apache/commons-parent/pull/51 Bumps [apache](https://github.com/apache/maven-apache-parent) from 23 to 24. Commits See full diff in https://github.com/apache/maven-apache-parent/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] coveralls commented on pull request #78: Prefetch the parameter metadata before filling the statements in batch.
coveralls commented on pull request #78: URL: https://github.com/apache/commons-dbutils/pull/78#issuecomment-880556039 [](https://coveralls.io/builds/41393050) Coverage increased (+0.3%) to 65.901% when pulling **28ea739a3e7f406cd23f8f5c985f5009c83e475f on whjpji:prefetch_pmd** into **0ec111e38a4f4458d16d4b0299cfe0f6ae86464a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] whjpji opened a new pull request #78: Prefetch the parameter metadata before filling the statements in batch.
whjpji opened a new pull request #78: URL: https://github.com/apache/commons-dbutils/pull/78 When the batch size is large (e.g. 100,000), fetching the parameter metadata can be extremly time-consuming in the batch operation (in my case, nearly slow down as 100 times of performance in contrast to prefetch in advance). So I added a parameter to the `batch` method to allow the user to choose whether to prefetch the paramter metadata only once before filling the statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CODEC-302) MurmurHash2.hash32 can return negative
[ https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381115#comment-17381115 ] Iris Scholer commented on CODEC-302: Yes, the result is different. I attached a simple JUnit test that shows this. The test hash was generated using [this site|http://murmurhash.shorelabs.com/] which generates values consistent with the original implementation, as well as with a [different Java library|https://github.com/sangupta/murmur] I have tested. !test-screenshot.png! Screenshot of the output after running the test. [^MurmurTest.java] > MurmurHash2.hash32 can return negative > -- > > Key: CODEC-302 > URL: https://issues.apache.org/jira/browse/CODEC-302 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.15 >Reporter: Iris Scholer >Priority: Major > Attachments: MurmurTest.java, test-screenshot.png > > > When running hash32, many values return a negative hash. Since the original > implementation used unsigned values, this is unintended behavior and breaks > compatibility with other implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CODEC-302) MurmurHash2.hash32 can return negative
[ https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iris Scholer updated CODEC-302: --- Attachment: test-screenshot.png > MurmurHash2.hash32 can return negative > -- > > Key: CODEC-302 > URL: https://issues.apache.org/jira/browse/CODEC-302 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.15 >Reporter: Iris Scholer >Priority: Major > Attachments: MurmurTest.java, test-screenshot.png > > > When running hash32, many values return a negative hash. Since the original > implementation used unsigned values, this is unintended behavior and breaks > compatibility with other implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CODEC-302) MurmurHash2.hash32 can return negative
[ https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iris Scholer updated CODEC-302: --- Attachment: MurmurTest.java > MurmurHash2.hash32 can return negative > -- > > Key: CODEC-302 > URL: https://issues.apache.org/jira/browse/CODEC-302 > Project: Commons Codec > Issue Type: Bug >Affects Versions: 1.15 >Reporter: Iris Scholer >Priority: Major > Attachments: MurmurTest.java > > > When running hash32, many values return a negative hash. Since the original > implementation used unsigned values, this is unintended behavior and breaks > compatibility with other implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CODEC-302) MurmurHash2.hash32 can return negative
[
https://issues.apache.org/jira/browse/CODEC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381099#comment-17381099
]
Alex Herbert commented on CODEC-302:
You should think of the signed integer as 32-bits. The sign is just another bit.
If you output the result using:
{code:java}
// Create the hash
int h = ...;
Integer.toHexString(h);
Integer.toUnsignedString(h);
{code}
Does this produce a different result to other implementations?
If the bits are the same then this is not a bug but an interpretation issue. If
the bits are different then this is a bug and an example of input that produces
different output from a reference would be useful.
> MurmurHash2.hash32 can return negative
> --
>
> Key: CODEC-302
> URL: https://issues.apache.org/jira/browse/CODEC-302
> Project: Commons Codec
> Issue Type: Bug
>Affects Versions: 1.15
>Reporter: Iris Scholer
>Priority: Major
>
> When running hash32, many values return a negative hash. Since the original
> implementation used unsigned values, this is unintended behavior and breaks
> compatibility with other implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381077#comment-17381077 ] AVIJIT BASAK commented on MATH-1563: Updated the previous model. Changes are listed below: 1) AdaptiveGeneticAlgorithm class is introduced 2) Introduced FitnessCalculator interface for chromosome and removed Fitness interface. Modified diagrams are attached below: [^GA-Overview.uxf] [^GA-Model.uxf] > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-Model.uxf, GA-OperatorModel.uxf, > GA-OperatorModel.uxf, GA-Overview.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1563: --- Attachment: GA-OperatorModel.uxf > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-Model.uxf, GA-OperatorModel.uxf, > GA-OperatorModel.uxf, GA-Overview.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1563: --- Attachment: GA-Model.uxf > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-Model.uxf, GA-OperatorModel.uxf, > GA-Overview.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1563: --- Attachment: GA-Overview.uxf > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-Model.uxf, GA-OperatorModel.uxf, > GA-Overview.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=622862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622862
]
ASF GitHub Bot logged work on IMAGING-159:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 06:07
Start Date: 15/Jul/21 06:07
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637226
[](https://coveralls.io/builds/41387908)
Coverage decreased (-0.1%) to 76.579% when pulling
**aabd298d703efb5b917506d1f6bc6eddfece3c87 on kinow:IMAGING-159-1** into
**a87b545e1019b43bfbe31fa5df3a4f3095a8b438 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622862)
Time Spent: 4.5h (was: 4h 20m)
> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] coveralls edited a comment on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
coveralls edited a comment on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637226 [](https://coveralls.io/builds/41387908) Coverage decreased (-0.1%) to 76.579% when pulling **aabd298d703efb5b917506d1f6bc6eddfece3c87 on kinow:IMAGING-159-1** into **a87b545e1019b43bfbe31fa5df3a4f3095a8b438 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
