[jira] [Work logged] (LANG-1593) Common behaviour for StringUtils join APIs when called with char or String delimiter
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=644768=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644768
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
Created on: 01/Sep/21 05:24
Start Date: 01/Sep/21 05:24
Worklog Time Spent: 10m
Work Description: HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r699853027
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##
@@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {
assertNull(StringUtils.join((short[]) null, SEPARATOR_CHAR, 0, 1));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 0, 0));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 1, 0));
+assertEquals("1,2", StringUtils.join(SHORT_PRIM_LIST, SEPARATOR));
Review comment:
Sorry for the late reply, I was on vac.
I will take a look on your comments and try to apply changes later this
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 644768)
Time Spent: 5h 50m (was: 5h 40m)
> Common behaviour for StringUtils join APIs when called with char or String
> delimiter
>
>
> Key: LANG-1593
> URL: https://issues.apache.org/jira/browse/LANG-1593
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 3.4, 3.11
>Reporter: Kiruahxh
>Priority: Minor
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> For now, join(int[], char) is working well.
> However, the same join method called with a string delimiter behaves
> differently : it returns a single memory address which is not the desired
> behavior.
> I think that, for coherence, calling StringUtils with a char or String
> delimiter should return the exact same value.
> Ex :
> {code:java}
> CLASSPATH="./commons-lang3-3.11.jar" jshell
> | Welcome to JShell -- Version 11.0.8
> jshell> import org.apache.commons.lang3.StringUtils
> jshell> int[] arr = {1, 2, 3, 4, 5, 6, 7};
> jshell> String result = StringUtils.join(arr, '-');
> result ==> "1-2-3-4-5-6-7"
> jshell> String result = StringUtils.join(arr, "-");
> result ==> "[I@69663380-"
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] HubertWo commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r699853027
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##
@@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {
assertNull(StringUtils.join((short[]) null, SEPARATOR_CHAR, 0, 1));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 0, 0));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 1, 0));
+assertEquals("1,2", StringUtils.join(SHORT_PRIM_LIST, SEPARATOR));
Review comment:
Sorry for the late reply, I was on vac.
I will take a look on your comments and try to apply changes later this
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #130: Bump checkstyle from 8.45.1 to 9.0
dependabot[bot] opened a new pull request #130: URL: https://github.com/apache/commons-dbcp/pull/130 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.45.1 to 9.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-9.0 https://checkstyle.org/releasenotes.html#Release_9.0;>https://checkstyle.org/releasenotes.html#Release_9.0 Commits https://github.com/checkstyle/checkstyle/commit/76546b60c2a4ecbd98f714f478dc263da312f27e;>76546b6 [maven-release-plugin] prepare release checkstyle-9.0 https://github.com/checkstyle/checkstyle/commit/47c73246d187a1effddfe8baaed217232727c266;>47c7324 doc: relasenotes 9.0 https://github.com/checkstyle/checkstyle/commit/378a8688a969789b9d8d10245663a79677aea07f;>378a868 dependency: bump pmd.version from 6.37.0 to 6.38.0 https://github.com/checkstyle/checkstyle/commit/f4b0113be9333d4b43c594dd56756432990819ff;>f4b0113 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Removed hardcoded configs in test methods https://github.com/checkstyle/checkstyle/commit/c74d3bbf4d42bcbed7933109a15f11706be488e4;>c74d3bb Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Add inline config support for tests with multiple modules https://github.com/checkstyle/checkstyle/commit/71f7cedba49c2ddc64b8ba170ce62c32b9805f54;>71f7ced Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added functionality for module parent https://github.com/checkstyle/checkstyle/commit/7c5900dcf981c727e0bb8c1d6dfb86f30fd05424;>7c5900d infra: disable pitest pitest-report-java-ast-visitor until https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10755;>#10755 https://github.com/checkstyle/checkstyle/commit/a81510a192c579996559c2ff77be191bf62c16b9;>a81510a Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10751;>#10751: use forbidden api annotation for specific suppression https://github.com/checkstyle/checkstyle/commit/87a853309bd81a1bf28d98c1bc34ff66fc937b0a;>87a8533 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added new TestInputConfiguration to hold child modules and viol... https://github.com/checkstyle/checkstyle/commit/1891eec4f9cba1fc960b1a775e3345a2abdfae52;>1891eec Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Renamed TestInputConfiguration to ModuleInputConfiguration Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.45.1...checkstyle-9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #266: Bump checkstyle from 8.45.1 to 9.0
coveralls commented on pull request #266: URL: https://github.com/apache/commons-io/pull/266#issuecomment-909847449 [](https://coveralls.io/builds/42564886) Coverage increased (+0.1%) to 89.251% when pulling **e75e40db8f5c1e70204550ec1ddd4d78224a8e58 on dependabot/maven/com.puppycrawl.tools-checkstyle-9.0** into **364f84538f4c8bde1b1428c0f4508d233a1c386c on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #91: Bump checkstyle from 8.45.1 to 9.0
coveralls commented on pull request #91: URL: https://github.com/apache/commons-codec/pull/91#issuecomment-909810576 [](https://coveralls.io/builds/42560531) Coverage remained the same at 94.682% when pulling **866b5f32dcd4e8bc5853bc444342fad1b5e93821 on dependabot/maven/com.puppycrawl.tools-checkstyle-9.0** into **fd44e6b491c9d606d0b91ac0029269d265024cd9 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] opened a new pull request #25: Bump jackson-databind from 2.9.3 to 2.12.5
dependabot[bot] opened a new pull request #25: URL: https://github.com/apache/commons-scxml/pull/25 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.3 to 2.12.5. Commits See full diff in https://github.com/FasterXML/jackson/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] closed pull request #22: Bump jackson-databind from 2.9.3 to 2.12.4
dependabot[bot] closed pull request #22: URL: https://github.com/apache/commons-scxml/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] commented on pull request #22: Bump jackson-databind from 2.9.3 to 2.12.4
dependabot[bot] commented on pull request #22: URL: https://github.com/apache/commons-scxml/pull/22#issuecomment-909753323 Superseded by #25. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] opened a new pull request #266: Bump checkstyle from 8.45.1 to 9.0
dependabot[bot] opened a new pull request #266: URL: https://github.com/apache/commons-io/pull/266 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.45.1 to 9.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-9.0 https://checkstyle.org/releasenotes.html#Release_9.0;>https://checkstyle.org/releasenotes.html#Release_9.0 Commits https://github.com/checkstyle/checkstyle/commit/76546b60c2a4ecbd98f714f478dc263da312f27e;>76546b6 [maven-release-plugin] prepare release checkstyle-9.0 https://github.com/checkstyle/checkstyle/commit/47c73246d187a1effddfe8baaed217232727c266;>47c7324 doc: relasenotes 9.0 https://github.com/checkstyle/checkstyle/commit/378a8688a969789b9d8d10245663a79677aea07f;>378a868 dependency: bump pmd.version from 6.37.0 to 6.38.0 https://github.com/checkstyle/checkstyle/commit/f4b0113be9333d4b43c594dd56756432990819ff;>f4b0113 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Removed hardcoded configs in test methods https://github.com/checkstyle/checkstyle/commit/c74d3bbf4d42bcbed7933109a15f11706be488e4;>c74d3bb Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Add inline config support for tests with multiple modules https://github.com/checkstyle/checkstyle/commit/71f7cedba49c2ddc64b8ba170ce62c32b9805f54;>71f7ced Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added functionality for module parent https://github.com/checkstyle/checkstyle/commit/7c5900dcf981c727e0bb8c1d6dfb86f30fd05424;>7c5900d infra: disable pitest pitest-report-java-ast-visitor until https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10755;>#10755 https://github.com/checkstyle/checkstyle/commit/a81510a192c579996559c2ff77be191bf62c16b9;>a81510a Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10751;>#10751: use forbidden api annotation for specific suppression https://github.com/checkstyle/checkstyle/commit/87a853309bd81a1bf28d98c1bc34ff66fc937b0a;>87a8533 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added new TestInputConfiguration to hold child modules and viol... https://github.com/checkstyle/checkstyle/commit/1891eec4f9cba1fc960b1a775e3345a2abdfae52;>1891eec Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Renamed TestInputConfiguration to ModuleInputConfiguration Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.45.1...checkstyle-9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NET-687) [FTPS] javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
[
https://issues.apache.org/jira/browse/NET-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407704#comment-17407704
]
Vladimir I commented on NET-687:
[~ggregory]
I am looking for a solution.
At first, would be nice to decide if an encrypted control channel should lead
to encryption in the data channels. Second to decide if `execPROT` is mandatory
or optional.
> [FTPS] javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
> --
>
> Key: NET-687
> URL: https://issues.apache.org/jira/browse/NET-687
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 3.7
> Environment: Tested with JDK 8, 11, 13, 14
>Reporter: Mikael
>Priority: Major
> Fix For: 3.7.1
>
>
> After adding the self signed polynesie.cer certificate to JVM security
> (_jdk-x.x.x/lib/security_) :
> {code:java}
> keytool.exe -import -storepass "changeit" -keystore "./cacerts" -alias
> polynesie.cer -file ./polynesie.cer -noprompt{code}
> polynesie.cer obtained by copying certificate part from this command line
> result :
> {code:java}
> openssl s_client -connect ftp0.gov.pf:21 -starttls ftp{code}
> Trying to retrieve a file with ftpes :
> {code:java}
> java -cp commons-net-examples-3.5.jar;commons-net-3.5.jar
> examples/ftp/FTPClientExample -A -p TLS,false -e -b ftp0.gov.pf
> DataVRS/fiche_Station_VRS_VAI1.pdf fiche_Station_VRS_VAI1.pdf{code}
> Produce this exception :
> {code:java}
> javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
> at
> java.base/sun.security.ssl.SSLSocketInputRecord.handleUnknownRecord(Unknown
> Source)
> at java.base/sun.security.ssl.SSLSocketInputRecord.decode(Unknown
> Source)
> at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
> at java.base/sun.security.ssl.SSLSocketImpl.readRecord(Unknown Source)
> at
> java.base/sun.security.ssl.SSLSocketImpl.performInitialHandshake(Unknown
> Source)
> at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
> Source)
> at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(Unknown
> Source)
> at
> org.apache.commons.net.ftp.FTPSClient._openDataConnection_(FTPSClient.java:642)
> at
> org.apache.commons.net.ftp.FTPClient._retrieveFile(FTPClient.java:1907)
> at
> org.apache.commons.net.ftp.FTPClient.retrieveFile(FTPClient.java:1893)
> at testFTP2.FTPClientExample.main(FTPClientExample.java:513)
> {code}
> It is probably the same error of ssl_reuse session as NET-408.
> Same try with ftp4j library reports this error :
> {code:java}
> code=522, message= SSL connection failed; session reuse required: see
> require_ssl_reuse option in vsftpd.conf man page
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-text] kinow closed pull request #262: Bump checkstyle from 8.45.1 to 9.0
kinow closed pull request #262: URL: https://github.com/apache/commons-text/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #262: Bump checkstyle from 8.45.1 to 9.0
dependabot[bot] commented on pull request #262: URL: https://github.com/apache/commons-text/pull/262#issuecomment-909661409 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #262: Bump checkstyle from 8.45.1 to 9.0
dependabot[bot] opened a new pull request #262: URL: https://github.com/apache/commons-text/pull/262 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.45.1 to 9.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-9.0 https://checkstyle.org/releasenotes.html#Release_9.0;>https://checkstyle.org/releasenotes.html#Release_9.0 Commits https://github.com/checkstyle/checkstyle/commit/76546b60c2a4ecbd98f714f478dc263da312f27e;>76546b6 [maven-release-plugin] prepare release checkstyle-9.0 https://github.com/checkstyle/checkstyle/commit/47c73246d187a1effddfe8baaed217232727c266;>47c7324 doc: relasenotes 9.0 https://github.com/checkstyle/checkstyle/commit/378a8688a969789b9d8d10245663a79677aea07f;>378a868 dependency: bump pmd.version from 6.37.0 to 6.38.0 https://github.com/checkstyle/checkstyle/commit/f4b0113be9333d4b43c594dd56756432990819ff;>f4b0113 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Removed hardcoded configs in test methods https://github.com/checkstyle/checkstyle/commit/c74d3bbf4d42bcbed7933109a15f11706be488e4;>c74d3bb Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Add inline config support for tests with multiple modules https://github.com/checkstyle/checkstyle/commit/71f7cedba49c2ddc64b8ba170ce62c32b9805f54;>71f7ced Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added functionality for module parent https://github.com/checkstyle/checkstyle/commit/7c5900dcf981c727e0bb8c1d6dfb86f30fd05424;>7c5900d infra: disable pitest pitest-report-java-ast-visitor until https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10755;>#10755 https://github.com/checkstyle/checkstyle/commit/a81510a192c579996559c2ff77be191bf62c16b9;>a81510a Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10751;>#10751: use forbidden api annotation for specific suppression https://github.com/checkstyle/checkstyle/commit/87a853309bd81a1bf28d98c1bc34ff66fc937b0a;>87a8533 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added new TestInputConfiguration to hold child modules and viol... https://github.com/checkstyle/checkstyle/commit/1891eec4f9cba1fc960b1a775e3345a2abdfae52;>1891eec Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Renamed TestInputConfiguration to ModuleInputConfiguration Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.45.1...checkstyle-9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1628) Binary classifiers: logistic and probit regression in Math4
[ https://issues.apache.org/jira/browse/MATH-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407622#comment-17407622 ] Gilles Sadowski commented on MATH-1628: --- You probably don't have write access to the ASF's repository; you could provide a GitHub pull request (after "cloning" the Commons Math's repository). If you don't use GH, you can attach a patch to this report. > Binary classifiers: logistic and probit regression in Math4 > --- > > Key: MATH-1628 > URL: https://issues.apache.org/jira/browse/MATH-1628 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: R W R Darling >Priority: Minor > Fix For: 4.0 > > > Proposal: add Logistic Regression and Probit Regression classes to > h1. > [org.apache.commons.math4.legacy.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] > Proposer has already written a [Probit Regression > |https://en.wikipedia.org/wiki/Probit_model]class with no dependencies beyond > Math3. > Only a few lines would have to be changed to make a [Logistic > Regression|https://en.wikipedia.org/wiki/Logistic_regression] class too. > Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1628) Binary classifiers: logistic and probit regression in Math4
[ https://issues.apache.org/jira/browse/MATH-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] R W R Darling updated MATH-1628: Description: Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math4.legacy.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] Proposer has already written a [Probit Regression |https://en.wikipedia.org/wiki/Probit_model]class with no dependencies beyond Math3. Only a few lines would have to be changed to make a [Logistic Regression|https://en.wikipedia.org/wiki/Logistic_regression] class too. Proposer would like to know whether others are interested in this addition. was: Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math4.legacy.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] Proposer has already written a Probit Regression class with no dependencies beyond Math3. Only a few lines would have to be changed to make a Logistic Regression class too. Proposer would like to know whether others are interested in this addition. > Binary classifiers: logistic and probit regression in Math4 > --- > > Key: MATH-1628 > URL: https://issues.apache.org/jira/browse/MATH-1628 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: R W R Darling >Priority: Minor > Fix For: 4.0 > > > Proposal: add Logistic Regression and Probit Regression classes to > h1. > [org.apache.commons.math4.legacy.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] > Proposer has already written a [Probit Regression > |https://en.wikipedia.org/wiki/Probit_model]class with no dependencies beyond > Math3. > Only a few lines would have to be changed to make a [Logistic > Regression|https://en.wikipedia.org/wiki/Logistic_regression] class too. > Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1628) Binary classifiers: logistic and probit regression in Math4
[ https://issues.apache.org/jira/browse/MATH-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] R W R Darling updated MATH-1628: Description: Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math4.legacy.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] Proposer has already written a Probit Regression class with no dependencies beyond Math3. Only a few lines would have to be changed to make a Logistic Regression class too. Proposer would like to know whether others are interested in this addition. was: Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] Proposer has already written a Probit Regression class with no dependencies beyond Math3. Only a few lines would have to be changed to make a Logistic Regression class too. Proposer would like to know whether others are interested in this addition. Summary: Binary classifiers: logistic and probit regression in Math4 (was: Binary classifiers: logistic and probit regression in Math3) > Binary classifiers: logistic and probit regression in Math4 > --- > > Key: MATH-1628 > URL: https://issues.apache.org/jira/browse/MATH-1628 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: R W R Darling >Priority: Minor > Fix For: 4.0 > > > Proposal: add Logistic Regression and Probit Regression classes to > h1. > [org.apache.commons.math4.legacy.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] > Proposer has already written a Probit Regression class with no dependencies > beyond Math3. > Only a few lines would have to be changed to make a Logistic Regression > class too. > Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1628) Binary classifiers: logistic and probit regression in Math3
[ https://issues.apache.org/jira/browse/MATH-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407614#comment-17407614 ] R W R Darling commented on MATH-1628: - Thank you for the prompt response, Gilles. Are you saying I can commit a ProbitRegression class to the math4 package you mention? Or does someone have to review it first? > Binary classifiers: logistic and probit regression in Math3 > --- > > Key: MATH-1628 > URL: https://issues.apache.org/jira/browse/MATH-1628 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: R W R Darling >Priority: Minor > Fix For: 4.0 > > > Proposal: add Logistic Regression and Probit Regression classes to > h1. > [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] > Proposer has already written a Probit Regression class with no dependencies > beyond Math3. > Only a few lines would have to be changed to make a Logistic Regression > class too. > Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] carldea commented on pull request #796: Adopt is no more, long live Zulu!
carldea commented on pull request #796: URL: https://github.com/apache/commons-lang/pull/796#issuecomment-909521607 Do you still consider building on both distros Temurin and Zulu? ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #797: Avoid multiple equivalent occurrences of the same expression.
coveralls edited a comment on pull request #797: URL: https://github.com/apache/commons-lang/pull/797#issuecomment-909360686 [](https://coveralls.io/builds/42499518) Coverage decreased (-0.0006%) to 94.96% when pulling **5ded54e9a5667561a6ed0dea3bc8a4e081132a23 on arturobernalg:feature/duplicate** into **c28b2e4e717a13527aded2625bbf431506674e9f on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DBCP-580) Not compatible with org.dbunit.IDatabaseTester
[
https://issues.apache.org/jira/browse/DBCP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arelowo updated DBCP-580:
-
Description:
We tried to upgrade to the latest version from 1.4 but it seems to be causing
an issue with our db unit test.
We get the following printed over and over again when the onSetup() method is
invoked
{code:java}
at java.lang.StringBuilder.append(StringBuilder.java:131)at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584){code}
We tested different versions and it seems 2.1.1 does not have this bug.
was:
We tried to upgrade to the latest version but it seems to be causing an issue
with our db unit test.
We get the following printed over and over again when the onSetup() method is
invoked
{code:java}
at java.lang.StringBuilder.append(StringBuilder.java:131)at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584){code}
> Not compatible with org.dbunit.IDatabaseTester
> ---
>
> Key: DBCP-580
> URL: https://issues.apache.org/jira/browse/DBCP-580
> Project: Commons DBCP
> Issue Type: Bug
>Affects Versions: 2.7.0, 2.9.0
> Environment:
> com.github.springtestdbunit
> spring-test-dbunit
> 1.3.0
> test
>
>
> org.dbunit
> dbunit
> 2.7.2
>
[jira] [Created] (DBCP-580) Not compatible with org.dbunit.IDatabaseTester
Arelowo created DBCP-580:
Summary: Not compatible with org.dbunit.IDatabaseTester
Key: DBCP-580
URL: https://issues.apache.org/jira/browse/DBCP-580
Project: Commons DBCP
Issue Type: Bug
Affects Versions: 2.9.0, 2.7.0
Environment:
com.github.springtestdbunit
spring-test-dbunit
1.3.0
test
org.dbunit
dbunit
2.7.2
test
Reporter: Arelowo
We tried to upgrade to the latest version but it seems to be causing an issue
with our db unit test.
We get the following printed over and over again when the onSetup() method is
invoked
{code:java}
at java.lang.StringBuilder.append(StringBuilder.java:131)at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
at java.lang.String.valueOf(String.java:2994) at
java.lang.StringBuilder.append(StringBuilder.java:131) at
org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #769: Minor changes:
coveralls edited a comment on pull request #769: URL: https://github.com/apache/commons-lang/pull/769#issuecomment-858653996 [](https://coveralls.io/builds/42498974) Coverage decreased (-0.001%) to 94.96% when pulling **ca43af7a2bf331b172d0728bfea510d4cda93be5 on arturobernalg:feature/minor_changes** into **c28b2e4e717a13527aded2625bbf431506674e9f on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1628) Binary classifiers: logistic and probit regression in Math3
[ https://issues.apache.org/jira/browse/MATH-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407539#comment-17407539 ] Gilles Sadowski commented on MATH-1628: --- bq. add [...] classes to [math3] PRs should target the current development version; i.e. package [o.a.c.math4.legacy.stat|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=tree;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat;h=82c9100fa0086bfb826999e3d021b8537d245a29;hb=HEAD]. > Binary classifiers: logistic and probit regression in Math3 > --- > > Key: MATH-1628 > URL: https://issues.apache.org/jira/browse/MATH-1628 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: R W R Darling >Priority: Minor > Fix For: 4.0 > > > Proposal: add Logistic Regression and Probit Regression classes to > h1. > [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] > Proposer has already written a Probit Regression class with no dependencies > beyond Math3. > Only a few lines would have to be changed to make a Logistic Regression > class too. > Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1628) Binary classifiers: logistic and probit regression in Math3
[ https://issues.apache.org/jira/browse/MATH-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] R W R Darling updated MATH-1628: Description: Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] Proposer has already written a Probit Regression class with no dependencies beyond Math3. Only a few lines would have to be changed to make a Logistic Regression class too. Proposer would like to know whether others are interested in this addition. was: Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] IProposer has already written a Probit Regression class with no dependencies beyond Math3. Only a few lines would have to be changed to make a Logistic Regression class too. Proposer would like to know whether others are interested in this addition. > Binary classifiers: logistic and probit regression in Math3 > --- > > Key: MATH-1628 > URL: https://issues.apache.org/jira/browse/MATH-1628 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: R W R Darling >Priority: Minor > Fix For: 4.0 > > > Proposal: add Logistic Regression and Probit Regression classes to > h1. > [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] > Proposer has already written a Probit Regression class with no dependencies > beyond Math3. > Only a few lines would have to be changed to make a Logistic Regression > class too. > Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MATH-1628) Binary classifiers: logistic and probit regression in Math3
R W R Darling created MATH-1628: --- Summary: Binary classifiers: logistic and probit regression in Math3 Key: MATH-1628 URL: https://issues.apache.org/jira/browse/MATH-1628 Project: Commons Math Issue Type: New Feature Affects Versions: 4.0 Reporter: R W R Darling Fix For: 4.0 Proposal: add Logistic Regression and Probit Regression classes to h1. [org.apache.commons.math3.stat.regression|https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/package-summary.html] IProposer has already written a Probit Regression class with no dependencies beyond Math3. Only a few lines would have to be changed to make a Logistic Regression class too. Proposer would like to know whether others are interested in this addition. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #797: Avoid multiple equivalent occurrences of the same expression.
coveralls edited a comment on pull request #797: URL: https://github.com/apache/commons-lang/pull/797#issuecomment-909360686 [](https://coveralls.io/builds/42517941) Coverage decreased (-0.0006%) to 94.949% when pulling **c4efa20d495fc1a418f343c789c43ac7ff6a11c2 on arturobernalg:feature/duplicate** into **8c153b833353e815ba0912aeea47130238379e25 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #797: Avoid multiple equivalent occurrences of the same expression.
coveralls commented on pull request #797: URL: https://github.com/apache/commons-lang/pull/797#issuecomment-909360686 [](https://coveralls.io/builds/42517928) Coverage decreased (-0.0006%) to 94.949% when pulling **c4efa20d495fc1a418f343c789c43ac7ff6a11c2 on arturobernalg:feature/duplicate** into **8c153b833353e815ba0912aeea47130238379e25 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MATH-1619) Implementation of Adaptive Probability Generation
[ https://issues.apache.org/jira/browse/MATH-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1619: --- Description: An Adaptive Probability Generation has been proposed as part of the Jira. A new class AdaptiveGeneticAlgorithm should be introduced as an implementation, which would extend the AbstractGeneticAlgorithm class. A new ProbabilityGenerator interface would be introduced to enable configurable probability generation strategy. The implementation of the ProbabilityGenerator interface for crossover and mutation probability generation will be provided during creation of AdaptiveGeneticAlgorithm instance. There can be different probability generation strategy like based on chromosome rank, no of generations passed etc, population statistics\al parameters. The design of ProbabilityGenerator should consider for arguments like chromosome rank, population stats etc. to enable interchangeable probability generation by the same AdaptiveGeneticalgorithm class. Removed Components: None New Components: AdaptiveGeneticAlgorithm, CrossoverProbabilityGenerator, MutationProbabilityGenerator ConstantCrossoverProbabilityGenerator, ConstantMutationProbabilityGenerator, LinearAdaptiveCrossoverProbabilityGenerator, LinearAdaptiveMutationProbabilityGenerator, LinearAdaptiveRandomCrossoverProbabilityGenerator, LinearAdaptiveRandomMutationProbabilityGenerator, TimeVaryingLinearAdaptiveCrossoverProbabilityGenerator, TimeVaryingLinearAdaptiveMutationProbabilityGenerator, Affected components: None was: An Adaptive Probability Generation has been proposed as part of the Jira. A new class AdaptiveGeneticAlgorithm should be introduced as an implementation, which would extend the AbstractGeneticAlgorithm class. A new ProbabilityGenerator interface would be introduced to enable configurable probability generation strategy. The implementation of the ProbabilityGenerator interface for crossover and mutation probability generation will be provided during creation of AdaptiveGeneticAlgorithm instance. There can be different probability generation strategy like based on chromosome rank, no of generations passed etc, population statistics\al parameters. The design of ProbabilityGenerator should consider for arguments like chromosome rank, population stats etc. to enable interchangeable probability generation by the same AdaptiveGeneticalgorithm class. Removed Components: None New Components: AdaptiveGeneticAlgorithm, ProbabilityGenerator, ConstantProbabilityGenerator, LinearAdaptiveProbabilityGenerator, TimeVaryingLinearAdaptiveProbabilityGenerator Affected components: None > Implementation of Adaptive Probability Generation > - > > Key: MATH-1619 > URL: https://issues.apache.org/jira/browse/MATH-1619 > Project: Commons Math > Issue Type: Sub-task >Affects Versions: 3.6.1 >Reporter: AVIJIT BASAK >Priority: Major > > An Adaptive Probability Generation has been proposed as part of the Jira. A > new class AdaptiveGeneticAlgorithm should be introduced as an implementation, > which would extend the AbstractGeneticAlgorithm class. A new > ProbabilityGenerator interface would be introduced to enable configurable > probability generation strategy. The implementation of the > ProbabilityGenerator interface for crossover and mutation probability > generation will be provided during creation of AdaptiveGeneticAlgorithm > instance. There can be different probability generation strategy like based > on chromosome rank, no of generations passed etc, population statistics\al > parameters. The design of ProbabilityGenerator should consider for arguments > like chromosome rank, population stats etc. to enable interchangeable > probability generation by the same AdaptiveGeneticalgorithm class. > Removed Components: None > New Components: AdaptiveGeneticAlgorithm, CrossoverProbabilityGenerator, > MutationProbabilityGenerator ConstantCrossoverProbabilityGenerator, > ConstantMutationProbabilityGenerator, > LinearAdaptiveCrossoverProbabilityGenerator, > LinearAdaptiveMutationProbabilityGenerator, > LinearAdaptiveRandomCrossoverProbabilityGenerator, > LinearAdaptiveRandomMutationProbabilityGenerator, > TimeVaryingLinearAdaptiveCrossoverProbabilityGenerator, > TimeVaryingLinearAdaptiveMutationProbabilityGenerator, > Affected components: None > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] dependabot[bot] opened a new pull request #91: Bump checkstyle from 8.45.1 to 9.0
dependabot[bot] opened a new pull request #91: URL: https://github.com/apache/commons-codec/pull/91 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.45.1 to 9.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-9.0 https://checkstyle.org/releasenotes.html#Release_9.0;>https://checkstyle.org/releasenotes.html#Release_9.0 Commits https://github.com/checkstyle/checkstyle/commit/76546b60c2a4ecbd98f714f478dc263da312f27e;>76546b6 [maven-release-plugin] prepare release checkstyle-9.0 https://github.com/checkstyle/checkstyle/commit/47c73246d187a1effddfe8baaed217232727c266;>47c7324 doc: relasenotes 9.0 https://github.com/checkstyle/checkstyle/commit/378a8688a969789b9d8d10245663a79677aea07f;>378a868 dependency: bump pmd.version from 6.37.0 to 6.38.0 https://github.com/checkstyle/checkstyle/commit/f4b0113be9333d4b43c594dd56756432990819ff;>f4b0113 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Removed hardcoded configs in test methods https://github.com/checkstyle/checkstyle/commit/c74d3bbf4d42bcbed7933109a15f11706be488e4;>c74d3bb Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Add inline config support for tests with multiple modules https://github.com/checkstyle/checkstyle/commit/71f7cedba49c2ddc64b8ba170ce62c32b9805f54;>71f7ced Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added functionality for module parent https://github.com/checkstyle/checkstyle/commit/7c5900dcf981c727e0bb8c1d6dfb86f30fd05424;>7c5900d infra: disable pitest pitest-report-java-ast-visitor until https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10755;>#10755 https://github.com/checkstyle/checkstyle/commit/a81510a192c579996559c2ff77be191bf62c16b9;>a81510a Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10751;>#10751: use forbidden api annotation for specific suppression https://github.com/checkstyle/checkstyle/commit/87a853309bd81a1bf28d98c1bc34ff66fc937b0a;>87a8533 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Added new TestInputConfiguration to hold child modules and viol... https://github.com/checkstyle/checkstyle/commit/1891eec4f9cba1fc960b1a775e3345a2abdfae52;>1891eec Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10745;>#10745: Renamed TestInputConfiguration to ModuleInputConfiguration Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.45.1...checkstyle-9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MATH-1618) Change in Existing Design
[ https://issues.apache.org/jira/browse/MATH-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1618: --- Description: *1) Creation of abstraction for GeneticAlgorithm*: In order to have different types of implementation for Genetic Algorithm like adaptive GA along with the existing one, we need to introduce an abstraction and a hierarchy of algorithm. AbstracttGeneticAlgorithm class needs to be implemented which would be extended by all other Algorithm class. This would also ease any future extension. Removed Components: None New Components: AbstractGeneticAlgorithm Affected Components: GeneticAlgorithm *2) Delegation of fitness calculation*: As per the current design Fitness interface is implemented by chromosome class, which forces implementation of fitness() method for any concrete chromosome. However this restricts the use of same concrete chromosome implementation to be reused for different problem domain. This inheritance based implementation should be replaced by composition. A new interface FitnessCalculator would be introduced. An instance of FitnessCalculator will be provided during creation of every concrete chromosome. This will enable reuse of concrete chromosome classes in different problem domain and hence improve extensibility and re-usability. This will require addition of an argument for each factory method and constructors. Removed Components: Fitness New Components: FitnessCalculator Affected Components: Chromosome, AbstractListChromosome, BinaryChromosome, RandomKey *3) Enable finer control for mutation and crossover probability*: Current design uses the crossover and mutation probability at the chromosome level. For finer control of mutation and crossover process the probability would be managed within MutationPolicy and CrossoverPolicy implementations. Probability would be passed as an argument to the respective operations. This way the corresponding operations will be responsible for managing probability and apply in convenient way. I have seen the controlling the mutation probability at the allele(gene) level improves the exploring capability of the optimization process and hence improves robustness. Removed Components: None New Components: None Affected Components: MutationPolicy, CrossoverPolicy and all other implementation classes *4) Addition of new Simulation Stopping conditions*: New simulation stopping conditions would be added based on population statistical characteristics. The simulation can be stopped based on variations of population average fitness or best fitness. These parameters are much better to represent nature of convergence. This will improve robustness to a considerable extent. Removed Components: None New Components: UnchangedAvgFitness, UnchangedBestFitness, PopulationStatisticalSummary Affected Components: SimulationStoppingCondition, GeneticAlgorithm, FixedElapsedTime, FixedGenerationCount *5) Introduction of Convergence listeners*: New convergence listener interface and registry would be introduced to enable tracking of convergence. Removed components: None New Components: ConvergenceListener, ListenerRegistry Affected Components: AbstractGeneticAlgorithm, GeneticAlgorithm *6) Restructuring Elitism*: Elitism can be handled by the hierarchy of Algorithm classes. Use of a separate ElitisticListPopulation class may not be necessary. The method nextGeneration() in Population would accept the elitism rate as an argument. Any concrete instance of Population would provide the necessary implementation. Removed components: ElitisticListPopulation New Component: None Affected Components: AbstractGeneticAlgorithm, GeneticAlgorithm, Population, ListPopulation was: *1) Creation of abstraction for GeneticAlgorithm*: In order to have different types of implementation for Genetic Algorithm like adaptive GA along with the existing one, we need to introduce an abstraction and a hierarchy of algorithm. AbstracttGeneticAlgorithm class needs to be implemented which would be extended by all other Algorithm class. This would also ease any future extension. Removed Components: None New Components: AbstractGeneticAlgorithm Affected Components: GeneticAlgorithm *2) Delegation of fitness calculation*: As per the current design Fitness interface is implemented by chromosome class, which forces implementation of fitness() method for any concrete chromosome. However this restricts the use of same concrete chromosome implementation to be reused for different problem domain. This inheritance based implementation should be replaced by composition. A new interface FitnessCalculator would be introduced. An instance of FitnessCalculator will be provided during creation of every concrete chromosome. This will enable reuse of concrete chromosome classes in different problem domain and hence improve extensibility and
[GitHub] [commons-daemon] markt-asf commented on a change in pull request #32: DAEMON-336 - If lCallbacks is empty don't call the fnCallbacks to avoid an ACCESS_VIOLATION
markt-asf commented on a change in pull request #32:
URL: https://github.com/apache/commons-daemon/pull/32#discussion_r699116202
##
File path: src/native/windows/src/handles.c
##
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
-/* Call the user callback first */
-(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
-/* Now go through the callback chain */
-TAILQ_FOREACH(lpCall, >lCallbacks, queue) {
+if (!TAILQ_EMPTY(>lCallbacks)) {
+/* Call the user callback first */
+(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
Why is this inside the test of `lCallbacks`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #797: Avoid multiple equivalent occurrences of the same expression.
garydgregory merged pull request #797: URL: https://github.com/apache/commons-lang/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #109: FILEUPLOAD-342 Remove methods which use javax|jakarta classes from FileUploadBase
coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=644355=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644355 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 31/Aug/21 15:15 Start Date: 31/Aug/21 15:15 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 644355) Time Spent: 1h 10m (was: 1h) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #797: Avoid multiple equivalent occurrences of the same expression.
arturobernalg commented on a change in pull request #797:
URL: https://github.com/apache/commons-lang/pull/797#discussion_r698687604
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@ -1365,12 +1365,10 @@ public static boolean isAssignable(Class cls, final
Class toClass, final b
if (Float.TYPE.equals(cls)) {
return Double.TYPE.equals(toClass);
}
-if (Character.TYPE.equals(cls)) {
-return Integer.TYPE.equals(toClass) ||
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) ||
Double.TYPE.equals(toClass);
-}
-if (Short.TYPE.equals(cls)) {
+if (Character.TYPE.equals(cls) || Short.TYPE.equals(cls)) {
return Integer.TYPE.equals(toClass) ||
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) ||
Double.TYPE.equals(toClass);
}
+
if (Byte.TYPE.equals(cls)) {
Review comment:
HI. @garydgregory
Fixed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #797: Avoid multiple equivalent occurrences of the same expression.
garydgregory commented on a change in pull request #797:
URL: https://github.com/apache/commons-lang/pull/797#discussion_r698539764
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@ -1365,12 +1365,10 @@ public static boolean isAssignable(Class cls, final
Class toClass, final b
if (Float.TYPE.equals(cls)) {
return Double.TYPE.equals(toClass);
}
-if (Character.TYPE.equals(cls)) {
-return Integer.TYPE.equals(toClass) ||
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) ||
Double.TYPE.equals(toClass);
-}
-if (Short.TYPE.equals(cls)) {
+if (Character.TYPE.equals(cls) || Short.TYPE.equals(cls)) {
return Integer.TYPE.equals(toClass) ||
Long.TYPE.equals(toClass) || Float.TYPE.equals(toClass) ||
Double.TYPE.equals(toClass);
}
+
if (Byte.TYPE.equals(cls)) {
Review comment:
Extra spacing not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-daemon] stevehof commented on a change in pull request #32: DAEMON-336 - If lCallbacks is empty don't call the fnCallbacks to avoid an ACCESS_VIOLATION
stevehof commented on a change in pull request #32:
URL: https://github.com/apache/commons-daemon/pull/32#discussion_r699137461
##
File path: src/native/windows/src/handles.c
##
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
-/* Call the user callback first */
-(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
-/* Now go through the callback chain */
-TAILQ_FOREACH(lpCall, >lCallbacks, queue) {
+if (!TAILQ_EMPTY(>lCallbacks)) {
+/* Call the user callback first */
+(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
This would also throw an access violation, i believe in the JVM.dll
which is with a version i do not have pdb files for. I tested this on master
with the current 1.2.5 fixes and this could also likely be caused by code from
the java side of things. I do not have a good understanding of the issues here
but i do know that lCallbacks was empty and that fnCallback would also raise an
access violation. What are these meant to be calling? I presume something in
the java, however i could not find any documentation, and this is the only
"issue" to an otherwise well running service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1593) Common behaviour for StringUtils join APIs when called with char or String delimiter
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=644091=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644091
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
Created on: 31/Aug/21 14:46
Start Date: 31/Aug/21 14:46
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r699367138
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##
@@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {
assertNull(StringUtils.join((short[]) null, SEPARATOR_CHAR, 0, 1));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 0, 0));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 1, 0));
+assertEquals("1,2", StringUtils.join(SHORT_PRIM_LIST, SEPARATOR));
Review comment:
@HubertWo
The point of String vs char separators is that a String can be longer than
one character, so you should test for String separators longer than one
character to make sure the right work takes place under the covers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 644091)
Time Spent: 5h 40m (was: 5.5h)
> Common behaviour for StringUtils join APIs when called with char or String
> delimiter
>
>
> Key: LANG-1593
> URL: https://issues.apache.org/jira/browse/LANG-1593
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 3.4, 3.11
>Reporter: Kiruahxh
>Priority: Minor
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> For now, join(int[], char) is working well.
> However, the same join method called with a string delimiter behaves
> differently : it returns a single memory address which is not the desired
> behavior.
> I think that, for coherence, calling StringUtils with a char or String
> delimiter should return the exact same value.
> Ex :
> {code:java}
> CLASSPATH="./commons-lang3-3.11.jar" jshell
> | Welcome to JShell -- Version 11.0.8
> jshell> import org.apache.commons.lang3.StringUtils
> jshell> int[] arr = {1, 2, 3, 4, 5, 6, 7};
> jshell> String result = StringUtils.join(arr, '-');
> result ==> "1-2-3-4-5-6-7"
> jshell> String result = StringUtils.join(arr, "-");
> result ==> "[I@69663380-"
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
garydgregory commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r699367138
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##
@@ -1226,6 +1241,8 @@ public void testJoin_ArrayOfShorts() {
assertNull(StringUtils.join((short[]) null, SEPARATOR_CHAR, 0, 1));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 0, 0));
assertEquals(StringUtils.EMPTY, StringUtils.join(SHORT_PRIM_LIST,
SEPARATOR_CHAR, 1, 0));
+assertEquals("1,2", StringUtils.join(SHORT_PRIM_LIST, SEPARATOR));
Review comment:
@HubertWo
The point of String vs char separators is that a String can be longer than
one character, so you should test for String separators longer than one
character to make sure the right work takes place under the covers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #797: Avoid multiple equivalent occurrences of the same expression.
garydgregory merged pull request #797: URL: https://github.com/apache/commons-lang/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] opened a new pull request #57: Bump commons.pmd-impl.version from 6.37.0 to 6.38.0
dependabot[bot] opened a new pull request #57: URL: https://github.com/apache/commons-parent/pull/57 Bumps `commons.pmd-impl.version` from 6.37.0 to 6.38.0. Updates `pmd-core` from 6.37.0 to 6.38.0 Release notes Sourced from https://github.com/pmd/pmd/releases;>pmd-core's releases. PMD 6.38.0 (28-August-2021) 28-August-2021 - 6.38.0 The PMD team is pleased to announce PMD 6.38.0. This is a minor release. Table Of Contents https://github.com/pmd/pmd/blob/HEAD/#fixed-issues;>Fixed Issues https://github.com/pmd/pmd/blob/HEAD/#external-contributions;>External Contributions https://github.com/pmd/pmd/blob/HEAD/#stats;>Stats Fixed Issues apex https://github-redirect.dependabot.com/pmd/pmd/issues/3462;>#3462: [apex] SOQL performed in a for-each loop doesn't trigger ApexCRUDViolationRule https://github-redirect.dependabot.com/pmd/pmd/issues/3484;>#3484: [apex] ApexCRUDViolationRule maintains state across files core https://github-redirect.dependabot.com/pmd/pmd/issues/3446;>#3446: [core] Allow XPath rules to access the current file name java-bestpractices https://github-redirect.dependabot.com/pmd/pmd/issues/3403;>#3403: [java] MethodNamingConventions junit5TestPattern does not detect parameterized tests External Contributions https://github-redirect.dependabot.com/pmd/pmd/pull/3445;>#3445: [java] Fix https://github-redirect.dependabot.com/pmd/pmd/issues/3403;>#3403 about MethodNamingConventions and JUnit5 parameterized tests - https://github.com/CyrilSicard;>Cyril Sicard https://github-redirect.dependabot.com/pmd/pmd/pull/3470;>#3470: [apex] Fix ApexCRUDViolationRule - add super call - https://github.com/jfeingold35;>Josh Feingold Stats 32 commits 8 closed tickets PRs Days since last release: 27 Commits https://github.com/pmd/pmd/commit/7d11a020521d587cf4631c44512464ad1f4e83cb;>7d11a02 [maven-release-plugin] prepare release pmd_releases/6.38.0 https://github.com/pmd/pmd/commit/5aa23354d4a0219a220d4713fed90735f321c610;>5aa2335 Prepare pmd release 6.38.0 https://github.com/pmd/pmd/commit/17d0473eb290e43a13e7ec68306ac5143241195a;>17d0473 Merge pull request https://github-redirect.dependabot.com/pmd/pmd/issues/3482;>#3482 from adangel:guidelines-standard-rules https://github.com/pmd/pmd/commit/af51d2d33198eb844f1ca6fb83f07a31f37803fa;>af51d2d Bump build-tools from 16-SNAPSHOT to 16 https://github.com/pmd/pmd/commit/2636fde5d969a202339b3bd1898f280067dd42d5;>2636fde Merge pull request https://github-redirect.dependabot.com/pmd/pmd/issues/3470;>#3470 from jfeingold35:addSuperCall https://github.com/pmd/pmd/commit/e22a43452789bf31692949684ba37311a9ea95df;>e22a434 [doc] Update release notes (https://github-redirect.dependabot.com/pmd/pmd/issues/3462;>#3462, https://github-redirect.dependabot.com/pmd/pmd/issues/3484;>#3484, https://github-redirect.dependabot.com/pmd/pmd/issues/3470;>#3470) https://github.com/pmd/pmd/commit/b2adc915bbf73f90a520236730c3752500e70cda;>b2adc91 Merge pull request https://github-redirect.dependabot.com/pmd/pmd/issues/3447;>#3447 from oowekyala:issue3446-apex-file-name https://github.com/pmd/pmd/commit/e9e51ddfdb772ff77850ef4391608df843ec2117;>e9e51dd [doc] Update release notes (https://github-redirect.dependabot.com/pmd/pmd/issues/3447;>#3447, https://github-redirect.dependabot.com/pmd/pmd/issues/3446;>#3446) https://github.com/pmd/pmd/commit/5a22ef104bd7da582a36b8cedb7c5c608f8c9e92;>5a22ef1 [doc] Document new xpath fun pmd:fileName() https://github.com/pmd/pmd/commit/742871afcc73f33ce387036399ecc8ad4a1be67d;>742871a [doc] Add rule guidelines Additional commits viewable in https://github.com/pmd/pmd/compare/pmd_releases/6.37.0...pmd_releases/6.38.0;>compare view Updates `pmd-java` from 6.37.0 to 6.38.0 Release notes Sourced from https://github.com/pmd/pmd/releases;>pmd-java's releases. PMD 6.38.0 (28-August-2021) 28-August-2021 - 6.38.0 The PMD team is pleased to announce PMD 6.38.0. This is a minor release. Table Of Contents https://github.com/pmd/pmd/blob/HEAD/#fixed-issues;>Fixed Issues https://github.com/pmd/pmd/blob/HEAD/#external-contributions;>External Contributions https://github.com/pmd/pmd/blob/HEAD/#stats;>Stats Fixed Issues apex https://github-redirect.dependabot.com/pmd/pmd/issues/3462;>#3462: [apex] SOQL performed in a for-each loop doesn't trigger ApexCRUDViolationRule https://github-redirect.dependabot.com/pmd/pmd/issues/3484;>#3484: [apex] ApexCRUDViolationRule maintains state across files core https://github-redirect.dependabot.com/pmd/pmd/issues/3446;>#3446: [core] Allow XPath rules to access the current file name java-bestpractices https://github-redirect.dependabot.com/pmd/pmd/issues/3403;>#3403: [java]
[jira] [Work logged] (FILEUPLOAD-342) FileUploadBase should not import HttpServletRequest
[ https://issues.apache.org/jira/browse/FILEUPLOAD-342?focusedWorklogId=643964=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643964 ] ASF GitHub Bot logged work on FILEUPLOAD-342: - Author: ASF GitHub Bot Created on: 31/Aug/21 10:57 Start Date: 31/Aug/21 10:57 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 643964) Time Spent: 1h (was: 50m) > FileUploadBase should not import HttpServletRequest > --- > > Key: FILEUPLOAD-342 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-342 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > FileUploadBase has few deprecated methods which use > 'javax.servlet.http.HttpServletRequest`. > > This causes class loading problem when using the new Jakarta based > `JakSrvltFileUpload.isMultipartContent(jakartaRequest)` because > javax.servlet.** in not on the classpath. > > Would it be OK to remove the deprecated methods in 2.0 ? > The applications should use > org.apache.commons.fileupload2.servlet.ServletFileUpload#isMultipartContent() > or > org.apache.commons.fileupload2.jaksrvlt.JakSrvltFileUpload#isMultipartContent() > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #109: FILEUPLOAD-342 Remove methods which use javax|jakarta classes from FileUploadBase
coveralls edited a comment on pull request #109: URL: https://github.com/apache/commons-fileupload/pull/109#issuecomment-902651897 [](https://coveralls.io/builds/42501247) Coverage decreased (-0.6%) to 77.521% when pulling **1bb61b675b00866aea512b12adf2678201dca609 on martin-g:FILEUPLOAD-342-remove-deprecated-methods-in-FileUploadBase** into **8fa525dd420dcfcec0341a445b0d06c811731d99 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] stevehof commented on a change in pull request #32: DAEMON-336 - If lCallbacks is empty don't call the fnCallbacks to avoid an ACCESS_VIOLATION
stevehof commented on a change in pull request #32:
URL: https://github.com/apache/commons-daemon/pull/32#discussion_r699137461
##
File path: src/native/windows/src/handles.c
##
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
-/* Call the user callback first */
-(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
-/* Now go through the callback chain */
-TAILQ_FOREACH(lpCall, >lCallbacks, queue) {
+if (!TAILQ_EMPTY(>lCallbacks)) {
+/* Call the user callback first */
+(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
This would also throw an access violation, i believe in the JVM.dll
which is with a version i do not have pdb files for. I tested this on master
with the current 1.2.5 fixes and this could also likely be caused by code from
the java side of things. I do not have a good understanding of the issues here
but i do know that lCallbacks was empty and that fnCallback would also raise an
access violation. What are these meant to be calling? I presume something in
the java, however i could not find any documentation, and this is the only
"issue" to an otherwise well running service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DAEMON-336) prunsrv crash on service stop
[ https://issues.apache.org/jira/browse/DAEMON-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407185#comment-17407185 ] Mark Thomas commented on DAEMON-336: I have made a comment on the detail of the patch but I'd like to see the steps to reproduce this with 1.2.4 before applying the patch as I am not currently convinced it is necessary with the 1.2.4 code. > prunsrv crash on service stop > - > > Key: DAEMON-336 > URL: https://issues.apache.org/jira/browse/DAEMON-336 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.15 > Environment: Windows 8.1 with Java 8 64bit, Java mode >Reporter: Volker Berlin >Priority: Major > > If the service should be stop then it crash. In the event log you can see: > Name der fehlerhaften Anwendung: foo-serverService.exe, Version: 1.0.15.0, > Zeitstempel: 0x51543b9d > Name des fehlerhaften Moduls: ntdll.dll, Version: 6.3.9600.17736, > Zeitstempel: 0x550f4336 > Ausnahmecode: 0xc005 > Fehleroffset: 0x00035150 > ID des fehlerhaften Prozesses: 0x1578 > Startzeit der fehlerhaften Anwendung: 0x01d0be119603c23f > Pfad der fehlerhaften Anwendung: C:\Program Files\foo > Server\foo-serverService.exe > Pfad des fehlerhaften Moduls: C:\WINDOWS\SYSTEM32\ntdll.dll > Berichtskennung: da5b2537-2a04-11e5-8063-7427ea3e8675 > Vollständiger Name des fehlerhaften Pakets: > Anwendungs-ID, die relativ zum fehlerhaften Paket ist: -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-daemon] markt-asf commented on a change in pull request #32: DAEMON-336 - If lCallbacks is empty don't call the fnCallbacks to avoid an ACCESS_VIOLATION
markt-asf commented on a change in pull request #32:
URL: https://github.com/apache/commons-daemon/pull/32#discussion_r699116202
##
File path: src/native/windows/src/handles.c
##
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
-/* Call the user callback first */
-(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
-/* Now go through the callback chain */
-TAILQ_FOREACH(lpCall, >lCallbacks, queue) {
+if (!TAILQ_EMPTY(>lCallbacks)) {
+/* Call the user callback first */
+(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
Why is this inside the test of `lCallbacks`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
