[GitHub] [commons-imaging] kinow commented on pull request #173: ISSUE-311 support multivariable rasters
kinow commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942829570 >I've fixed most of the whitespace-related issues. So I hope the code will be easier to review. >Unfortunately, some of the Javadoc received different line-breaks, and I don't think I will be able to restore them without an undue amount of effort. Thanks and not a problem @gwlucastrig ! >Otherwise, the code is now ready for review. :+1: hopefully will be complete by end of week. Thanks for the PR ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls edited a comment on pull request #173: ISSUE-311 support multivariable rasters
coveralls edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-938618702 [](https://coveralls.io/builds/43492119) Coverage increased (+0.1%) to 77.126% when pulling **9ccd9c7adde7ce5d13484c8a09325949bcab1f22 on gwlucastrig:Imaging311** into **b76efb67b075f53b33af28026fea15e2916f771c on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942817937 I've fixed most of the whitespace-related issues. So I hope the code will be easier to review. Unfortunately, some of the Javadoc received different line-breaks, and I don't think I will be able to restore them without an undue amount of effort. Otherwise, the code is now ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls edited a comment on pull request #173: ISSUE-311 support multivariable rasters
coveralls edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-938618702 [](https://coveralls.io/builds/43491648) Coverage increased (+0.1%) to 77.126% when pulling **9106ea3d5a596a36135c0c6964477750fc92f9cd on gwlucastrig:Imaging311** into **b76efb67b075f53b33af28026fea15e2916f771c on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #816: Make final var when is possible.
coveralls commented on pull request #816: URL: https://github.com/apache/commons-lang/pull/816#issuecomment-942569564 [](https://coveralls.io/builds/43482845) Coverage remained the same at 94.947% when pulling **8861b67cf49b12eadde8441757ea5ec6f322272e on arturobernalg:feature/final_var** into **5911e928c4b66d92e3ee287d097fbe73d48c0b22 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] Jadezzz closed pull request #261: Mutations 5. 6. 7.
Jadezzz closed pull request #261: URL: https://github.com/apache/commons-collections/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] Jadezzz commented on pull request #261: Mutations 5. 6. 7.
Jadezzz commented on pull request #261: URL: https://github.com/apache/commons-collections/pull/261#issuecomment-942587986 Sorry, pushed by accident -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1674) Range construction with abstract/derived classes
[
https://issues.apache.org/jira/browse/LANG-1674?focusedWorklogId=665195=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665195
]
ASF GitHub Bot logged work on LANG-1674:
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:54
Start Date: 13/Oct/21 18:54
Worklog Time Spent: 10m
Work Description: singhbaljit commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941740481
@garydgregory ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 665195)
Time Spent: 1.5h (was: 1h 20m)
> Range construction with abstract/derived classes
>
>
> Key: LANG-1674
> URL: https://issues.apache.org/jira/browse/LANG-1674
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Baljit Singh
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The constructors for {{org.apache.commons.lang3.Range}} don't play nicely
> with abstract/derived classes. Example:
> {quote}
> abstract class AbstractComparable implements Comparable {
> @Override public int compareTo(AbstractComparable o) {}
> }
> class DerivedA extends AbstractComparable {}
> class DerivedB extends AbstractComparable {}
> // compiles, and reasonable since AbstractComparable is the common parent
> static final Range RANGE_MIXED = Range.between(new
> DerivedA(), new DerivedB());
> // compiles, but unreasonable to force usage of parent class
> static final Range RANGE_SAME_CLASS = Range.between(new
> DerivedA(), new DerivedA());
> // compiler error
> static final Range RANGE_A = Range.between(new DerivedA(), new
> DerivedA());
> // compiler error
> static final Range RANGE_B = Range.is(new DerivedB());
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] coveralls commented on pull request #174: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #174: URL: https://github.com/apache/commons-imaging/pull/174#issuecomment-941286599 [](https://coveralls.io/builds/43450140) Coverage remained the same at 77.003% when pulling **b7be1ac1121097e1ad6aa353171cd6f4e659810f on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **b76efb67b075f53b33af28026fea15e2916f771c on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] singhbaljit commented on pull request #810: LANG-1674: Make Range constructors more generic
singhbaljit commented on pull request #810: URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941740481 @garydgregory ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] jochenw merged pull request #225: Use Boolean constants instead of Boolean.valueOf
jochenw merged pull request #225: URL: https://github.com/apache/commons-compress/pull/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig edited a comment on pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942174126 The coverage changes are done. I am done making changes to the code. I am going to take a look at the formatting and see if I can undo some of the whitespace changes I accidentally introduced. The one class that really needs attention is ImageDataReader. There were a lot of meaningful changes to that class, but I'd like to reduce the number of irrelevant changes to simplify the review process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)
[
https://issues.apache.org/jira/browse/IO-714?focusedWorklogId=665107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665107
]
ASF GitHub Bot logged work on IO-714:
-
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:44
Start Date: 13/Oct/21 18:44
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #283:
URL: https://github.com/apache/commons-io/pull/283#issuecomment-941360554
I'll review again later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 665107)
Time Spent: 1h (was: 50m)
> ReaderInputStream does not call CharsetEncoder.flush(...)
> -
>
> Key: IO-714
> URL: https://issues.apache.org/jira/browse/IO-714
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: Marcono1234
>Priority: Major
> Attachments:
> 0001-Fixed-ReaderInputStream-not-calling-CharsetEncoder.f.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> As defined by the {{CharsetEncoder}}
> [documentation|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/charset/CharsetEncoder.html]
> the _encoding operation_ consists of:
> # (reset)
> # encode
> # flush
> However, {{org.apache.commons.io.input.ReaderInputStream}} does not call
> {{flush}}. This leads to incorrect results for charsets whose {{flush}}
> method appends additional bytes.
> Example:
> {code}
> // Charset whose CharsetEncoder.flush(...) puts bytes
> Charset charset = Charset.forName("Cp930");
> // \u0391: Causes CharsetEncoder.flush(...) to put additional bytes
> String s = "\u0391";
> byte[] expected = s.getBytes(charset);
> byte[] actual;
> try (InputStream in = new ReaderInputStream(new StringReader(s), charset)) {
> actual = IOUtils.toByteArray(in);
> }
> if (!Arrays.equals(expected, actual)) {
> throw new AssertionError("\n Expected: " + Arrays.toString(expected) +
> "\n Actual: " + Arrays.toString(actual));
> }
> {code}
> Also make sure to check the result of {{flush()}} because {{OVERFLOW}} as
> result is possible. In theory {{isError() == true}} might be possible as
> well, but I don't think any of charset implementations currently return that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on pull request #283: [IO-714] Fixed ReaderInputStream not calling CharsetEncoder.flush issue
garydgregory commented on pull request #283: URL: https://github.com/apache/commons-io/pull/283#issuecomment-941360554 I'll review again later... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942174126 The coverage changes are done. I am done making changes to the code. I am going to take a look at the formatting and see if I can undo some of the whitespace changes I accidentally introduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #174: Bump spotbugs from 4.4.1 to 4.4.2
kinow merged pull request #174: URL: https://github.com/apache/commons-imaging/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1674) Range construction with abstract/derived classes
[
https://issues.apache.org/jira/browse/LANG-1674?focusedWorklogId=664979=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664979
]
ASF GitHub Bot logged work on LANG-1674:
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:33
Start Date: 13/Oct/21 18:33
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941845831
I'll review sometime this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 664979)
Time Spent: 1h 20m (was: 1h 10m)
> Range construction with abstract/derived classes
>
>
> Key: LANG-1674
> URL: https://issues.apache.org/jira/browse/LANG-1674
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Baljit Singh
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The constructors for {{org.apache.commons.lang3.Range}} don't play nicely
> with abstract/derived classes. Example:
> {quote}
> abstract class AbstractComparable implements Comparable {
> @Override public int compareTo(AbstractComparable o) {}
> }
> class DerivedA extends AbstractComparable {}
> class DerivedB extends AbstractComparable {}
> // compiles, and reasonable since AbstractComparable is the common parent
> static final Range RANGE_MIXED = Range.between(new
> DerivedA(), new DerivedB());
> // compiles, but unreasonable to force usage of parent class
> static final Range RANGE_SAME_CLASS = Range.between(new
> DerivedA(), new DerivedA());
> // compiler error
> static final Range RANGE_A = Range.between(new DerivedA(), new
> DerivedA());
> // compiler error
> static final Range RANGE_B = Range.is(new DerivedB());
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic
garydgregory commented on pull request #810: URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941845831 I'll review sometime this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls edited a comment on pull request #173: ISSUE-311 support multivariable rasters
coveralls edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-938618702 [](https://coveralls.io/builds/43469630) Coverage increased (+0.1%) to 77.126% when pulling **66272116f2cb559d6eacfc29bd6d5674a9a02a86 on gwlucastrig:Imaging311** into **b76efb67b075f53b33af28026fea15e2916f771c on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #120: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #120: URL: https://github.com/apache/commons-fileupload/pull/120#issuecomment-941470091 [](https://coveralls.io/builds/43452645) Coverage remained the same at 77.585% when pulling **9ffb032168e58b1086150a41db20544bf4626fb1 on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **19a702b155008dd146a0c5848754f544242cea9f on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #70: Bump spotbugs from 4.4.1 to 4.4.2
garydgregory merged pull request #70: URL: https://github.com/apache/commons-cli/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kevinwang1975 commented on pull request #283: [IO-714] Fixed ReaderInputStream not calling CharsetEncoder.flush issue
kevinwang1975 commented on pull request #283: URL: https://github.com/apache/commons-io/pull/283#issuecomment-941276341 Hi @garydgregory , all checks are green now. Please let me know what I do next? Do I need to request for reviewers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)
[
https://issues.apache.org/jira/browse/IO-714?focusedWorklogId=664855=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664855
]
ASF GitHub Bot logged work on IO-714:
-
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:21
Start Date: 13/Oct/21 18:21
Worklog Time Spent: 10m
Work Description: kevinwang1975 commented on pull request #283:
URL: https://github.com/apache/commons-io/pull/283#issuecomment-941276341
Hi @garydgregory , all checks are green now. Please let me know what I do
next? Do I need to request for reviewers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 664855)
Time Spent: 50m (was: 40m)
> ReaderInputStream does not call CharsetEncoder.flush(...)
> -
>
> Key: IO-714
> URL: https://issues.apache.org/jira/browse/IO-714
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: Marcono1234
>Priority: Major
> Attachments:
> 0001-Fixed-ReaderInputStream-not-calling-CharsetEncoder.f.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> As defined by the {{CharsetEncoder}}
> [documentation|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/charset/CharsetEncoder.html]
> the _encoding operation_ consists of:
> # (reset)
> # encode
> # flush
> However, {{org.apache.commons.io.input.ReaderInputStream}} does not call
> {{flush}}. This leads to incorrect results for charsets whose {{flush}}
> method appends additional bytes.
> Example:
> {code}
> // Charset whose CharsetEncoder.flush(...) puts bytes
> Charset charset = Charset.forName("Cp930");
> // \u0391: Causes CharsetEncoder.flush(...) to put additional bytes
> String s = "\u0391";
> byte[] expected = s.getBytes(charset);
> byte[] actual;
> try (InputStream in = new ReaderInputStream(new StringReader(s), charset)) {
> actual = IOUtils.toByteArray(in);
> }
> if (!Arrays.equals(expected, actual)) {
> throw new AssertionError("\n Expected: " + Arrays.toString(expected) +
> "\n Actual: " + Arrays.toString(actual));
> }
> {code}
> Also make sure to check the result of {{flush()}} because {{OVERFLOW}} as
> result is possible. In theory {{isError() == true}} might be possible as
> well, but I don't think any of charset implementations currently return that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-collections] Jadezzz commented on pull request #261: Mutations 5. 6. 7.
Jadezzz commented on pull request #261: URL: https://github.com/apache/commons-collections/pull/261#issuecomment-942587986 Sorry, pushed by accident -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] Jadezzz closed pull request #261: Mutations 5. 6. 7.
Jadezzz closed pull request #261: URL: https://github.com/apache/commons-collections/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #816: Make final var when is possible.
coveralls commented on pull request #816: URL: https://github.com/apache/commons-lang/pull/816#issuecomment-942569564 [](https://coveralls.io/builds/43482845) Coverage remained the same at 94.947% when pulling **8861b67cf49b12eadde8441757ea5ec6f322272e on arturobernalg:feature/final_var** into **5911e928c4b66d92e3ee287d097fbe73d48c0b22 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (LANG-1676) another case for RangeTest.isOverlapped
[ https://issues.apache.org/jira/browse/LANG-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushikesh Jogdand updated LANG-1676: Patch : [https://patch-diff.githubusercontent.com/raw/apache/commons-lang/pull/815.patch] Diff: [https://patch-diff.githubusercontent.com/raw/apache/commons-lang/pull/815.diff] Github PR: [https://github.com/apache/commons-lang/pull/815] > another case for RangeTest.isOverlapped > --- > > Key: LANG-1676 > URL: https://issues.apache.org/jira/browse/LANG-1676 > Project: Commons Lang > Issue Type: Test > Components: lang.* >Reporter: Rushikesh Jogdand >Priority: Trivial > Labels: unit-test-missing > > Add test for case – > when other range fully contains this range, this.isOverlapped(other) should > return true. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1676) another case for RangeTest.isOverlapped
Rushikesh Jogdand created LANG-1676: --- Summary: another case for RangeTest.isOverlapped Key: LANG-1676 URL: https://issues.apache.org/jira/browse/LANG-1676 Project: Commons Lang Issue Type: Test Components: lang.* Reporter: Rushikesh Jogdand Add test for case – when other range fully contains this range, this.isOverlapped(other) should return true. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IMAGING-194) Tiff with JPEG,Zip compression fails to decompress
[
https://issues.apache.org/jira/browse/IMAGING-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428230#comment-17428230
]
Gary Lucas edited comment on IMAGING-194 at 10/13/21, 2:27 PM:
---
Does anyone have some manageable-sized, public domain files that we can use to
develop/test this capability?
Does anyone have a current need for this feature?
Through my job, I've got some interest in accessing JPEG based TIFFs. The U.S.
National Weather Service has started posting some satellite images as GeoTIFFs
containing JPEG-formatted data. I will be investigating the level-of-effort for
implementing the ability to read such files. But the task may be out-of-scope
for what I am willing to take on unless there are a significant number of
people interested in the feature.
You can find the satellite images of interest at
[GOES-East - Latest CONUS Images - NOAA / NESDIS /
STAR|https://www.star.nesdis.noaa.gov/GOES/conus.php?sat=G16]
and
[GOES Imagery Viewer - NOAA / NESDIS /
STAR|https://www.star.nesdis.noaa.gov/GOES/]
Some of the satellite-derived imagery is really quite beautiful.
was (Author: gwlucas):
Does anyone have some manageable-sized, public domain files that we can use to
develop/test this capability?
> Tiff with JPEG,Zip compression fails to decompress
> --
>
> Key: IMAGING-194
> URL: https://issues.apache.org/jira/browse/IMAGING-194
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: TIFF
>Affects Versions: 1.0-alpha1
>Reporter: Satya Deep Maheshwari
>Priority: Major
>
> Tiff with JPEG, Zip compression fails to decompress with the below exception:
> {code}
> org.apache.commons.imaging.ImageReadException: Tiff: unknown/unsupported
> compression: 7
> at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReader.decompress(DataReader.java:215)
> at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStrips.readImageData(DataReaderStrips.java:210)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:650)
> at
> org.apache.commons.imaging.formats.tiff.TiffDirectory.getTiffImage(TiffDirectory.java:157)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:463)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1407)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1370)
> {code}
> From the
> [documentation|https://commons.apache.org/proper/commons-imaging/formatsupport.html]
> , it seems this compression format is not supported. Excerpt from the
> document below:
> {quote}
> Supported through version 6.0. TIFFs is a open-ended container format, so
> it's not possible to support every possibly variation. Supports Bi-Level,
> Palette/Indexed, RGB, CMYK, YCbCr, CIELab and LOGLUV images. Supports reading
> and writing LZW, CCITT Modified Huffman/Group 3/Group 4, and Packbits/RLE
> compression. Notably missing other forms of compression though, including
> JPEG. Supports reading Tiled images.
> {quote}
> This ticket is logged to add JPEG/Zip compression format support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IMAGING-194) Tiff with JPEG,Zip compression fails to decompress
[
https://issues.apache.org/jira/browse/IMAGING-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428230#comment-17428230
]
Gary Lucas commented on IMAGING-194:
Does anyone have some manageable-sized, public domain files that we can use to
develop/test this capability?
> Tiff with JPEG,Zip compression fails to decompress
> --
>
> Key: IMAGING-194
> URL: https://issues.apache.org/jira/browse/IMAGING-194
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: TIFF
>Affects Versions: 1.0-alpha1
>Reporter: Satya Deep Maheshwari
>Priority: Major
>
> Tiff with JPEG, Zip compression fails to decompress with the below exception:
> {code}
> org.apache.commons.imaging.ImageReadException: Tiff: unknown/unsupported
> compression: 7
> at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReader.decompress(DataReader.java:215)
> at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStrips.readImageData(DataReaderStrips.java:210)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:650)
> at
> org.apache.commons.imaging.formats.tiff.TiffDirectory.getTiffImage(TiffDirectory.java:157)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:463)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1407)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1370)
> {code}
> From the
> [documentation|https://commons.apache.org/proper/commons-imaging/formatsupport.html]
> , it seems this compression format is not supported. Excerpt from the
> document below:
> {quote}
> Supported through version 6.0. TIFFs is a open-ended container format, so
> it's not possible to support every possibly variation. Supports Bi-Level,
> Palette/Indexed, RGB, CMYK, YCbCr, CIELab and LOGLUV images. Supports reading
> and writing LZW, CCITT Modified Huffman/Group 3/Group 4, and Packbits/RLE
> compression. Notably missing other forms of compression though, including
> JPEG. Supports reading Tiled images.
> {quote}
> This ticket is logged to add JPEG/Zip compression format support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] garydgregory merged pull request #70: Bump spotbugs from 4.4.1 to 4.4.2
garydgregory merged pull request #70: URL: https://github.com/apache/commons-cli/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1633) Commons-Math does not build under java 17
[
https://issues.apache.org/jira/browse/MATH-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428203#comment-17428203
]
Alex Herbert commented on MATH-1633:
Replacing SpotBugs 3.1.8 with 4.3.0 allows the spotbugs plugin to run in JDK
17. The build then fails on bugs found by SpotBugs. These are not detected
using JDK 8 with SpotBugs 3.1.8.
SpotBugs is skipped in the {{commons-math4-legacy}} module so this relates to
updated code. I had to fix the legacy code to use the updated API from Commons
Statistics.
The errors are related to exposing a reference to a private field through
getter methods. I inspected a few and this seems intentional.
I added this to the spotbugs exclude filter:
{noformat}
{noformat}
The code then almost builds on JDK 17. It fails for the legacy module as
AccurateMath does not implement all java.util.Math methods.
I have pushed the update to master.
> Commons-Math does not build under java 17
> -
>
> Key: MATH-1633
> URL: https://issues.apache.org/jira/browse/MATH-1633
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 4.0
>Reporter: Erik Svensson
>Priority: Major
>
> Building with java 17 fails with
> {{[WARNING] Error injecting: org.codehaus.mojo.spotbugs.SpotBugsMojo}}
> {{com.google.inject.ProvisionException: Unable to provision, see the
> following errors:}}
> {{1) Error injecting constructor, java.lang.NoClassDefFoundError: Could not
> initialize class org.codehaus.groovy.vmplugin.v7.Java7}}
> {{ at org.codehaus.mojo.spotbugs.SpotBugsMojo.(Unknown Source)}}
> {{ while locating org.codehaus.mojo.spotbugs.SpotBugsMojo}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig edited a comment on pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942174126 The coverage changes are done. I am done making changes to the code. I am going to take a look at the formatting and see if I can undo some of the whitespace changes I accidentally introduced. The one class that really needs attention is ImageDataReader. There were a lot of meaningful changes to that class, but I'd like to reduce the number of irrelevant changes to simplify the review process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MATH-1633) Commons-Math does not build under java 17
Erik Svensson created MATH-1633:
---
Summary: Commons-Math does not build under java 17
Key: MATH-1633
URL: https://issues.apache.org/jira/browse/MATH-1633
Project: Commons Math
Issue Type: Bug
Affects Versions: 4.0
Reporter: Erik Svensson
Building with java 17 fails with
{{[WARNING] Error injecting: org.codehaus.mojo.spotbugs.SpotBugsMojo}}
{{com.google.inject.ProvisionException: Unable to provision, see the following
errors:}}
{{1) Error injecting constructor, java.lang.NoClassDefFoundError: Could not
initialize class org.codehaus.groovy.vmplugin.v7.Java7}}
{{ at org.codehaus.mojo.spotbugs.SpotBugsMojo.(Unknown Source)}}
{{ while locating org.codehaus.mojo.spotbugs.SpotBugsMojo}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] gwlucastrig commented on pull request #173: ISSUE-311 support multivariable rasters
gwlucastrig commented on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-942174126 The coverage changes are done. I am done making changes to the code. I am going to take a look at the formatting and see if I can undo some of the whitespace changes I accidentally introduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls edited a comment on pull request #173: ISSUE-311 support multivariable rasters
coveralls edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-938618702 [](https://coveralls.io/builds/43469630) Coverage increased (+0.1%) to 77.126% when pulling **66272116f2cb559d6eacfc29bd6d5674a9a02a86 on gwlucastrig:Imaging311** into **b76efb67b075f53b33af28026fea15e2916f771c on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] Rushi98 opened a new pull request #815: add another case in RangeTest:testIsOverlappedBy
Rushi98 opened a new pull request #815:
URL: https://github.com/apache/commons-lang/pull/815
Add test for when other range fully contains this range.
The existing suite of tests would have allowed for following implementation
of isOverlappedBy to pass -
```
public boolean isOverlappedBy(final Range otherRange) {
if (otherRange == null) {
return false;
}
return contains(otherRange.minimum) || contains(otherRange.maximum);
}
```
This would have been regression, since it does not consider case when other
range fully contains this range. So, now we have a test to guard against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
