[GitHub] [commons-cli] coveralls commented on pull request #79: Bump spotbugs from 4.4.2 to 4.5.0
coveralls commented on pull request #79: URL: https://github.com/apache/commons-cli/pull/79#issuecomment-966888060 [](https://coveralls.io/builds/44216707) Coverage remained the same at 96.195% when pulling **50783ca88190774fc3a208315daf3766e6b763b8 on dependabot/maven/com.github.spotbugs-spotbugs-4.5.0** into **ae7bc3f3cf57cabf3e663ba5df76affa36633255 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] dependabot[bot] opened a new pull request #79: Bump spotbugs from 4.4.2 to 4.5.0
dependabot[bot] opened a new pull request #79: URL: https://github.com/apache/commons-cli/pull/79 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.2 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #43: Bump spotbugs from 4.3.0 to 4.4.2
dependabot[bot] commented on pull request #43: URL: https://github.com/apache/commons-build-plugin/pull/43#issuecomment-966863442 Superseded by #49. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #43: Bump spotbugs from 4.3.0 to 4.4.2
dependabot[bot] closed pull request #43: URL: https://github.com/apache/commons-build-plugin/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request #49: Bump spotbugs from 4.3.0 to 4.5.0
dependabot[bot] opened a new pull request #49: URL: https://github.com/apache/commons-build-plugin/pull/49 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.3.0 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[jira] [Created] (POOL-401) GKOP invalidateObject should make capacity available to all keyed pools
Phil Steitz created POOL-401: Summary: GKOP invalidateObject should make capacity available to all keyed pools Key: POOL-401 URL: https://issues.apache.org/jira/browse/POOL-401 Project: Commons Pool Issue Type: Bug Reporter: Phil Steitz GKOP invalidateObject currently only creates and adds objects if there are borrowers waiting for the keyed pool that the instance being invalidated came from. If there are no take waiters on that pool, or there is a more heavily loaded pool, the (total) capacity should be reused in a different pool. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-pool] garydgregory commented on a change in pull request #113: Ensure capacity freed by clear is made available to GKOP borrowers. J…
garydgregory commented on a change in pull request #113:
URL: https://github.com/apache/commons-pool/pull/113#discussion_r747918619
##
File path:
src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
##
@@ -570,23 +569,47 @@ private int calculateDeficit(final ObjectDeque
objectDeque) {
*/
@Override
public void clear() {
-poolMap.keySet().forEach(this::clear);
-}
+final Iterator iter = poolMap.keySet().iterator();
+while (iter.hasNext()) {
+clear(iter.next(), false);
+}
+}
Review comment:
Why not use a lambda?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (LANG-1444) NumberUtils.createNumber() does not create BigDecimal for decimal fractions tending to zero
[
https://issues.apache.org/jira/browse/LANG-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442523#comment-17442523
]
asha somayajula commented on LANG-1444:
---
Can a PR be created for this?
> NumberUtils.createNumber() does not create BigDecimal for decimal fractions
> tending to zero
> ---
>
> Key: LANG-1444
> URL: https://issues.apache.org/jira/browse/LANG-1444
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.math.*
>Affects Versions: 3.8.1
>Reporter: Costa Theodosiou
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The following code demonstrates the issue:
> {{System.out.println(NumberUtils.createNumber("1.1").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.001").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.1").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.001").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.1").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.001").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.1").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.001").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.1").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.001").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.1").getClass().getName());}}
> {{System.out.println(NumberUtils.createNumber("1.001").getClass().getName());}}
> will print:
> {{java.lang.Float}}
> {{java.lang.Float}}
> {{java.lang.Float}}
> {{java.lang.Float}}
> {{java.lang.Double}}
> {{java.lang.Double}}
> {{java.lang.Double}}
> {{java.lang.Double}}
> {{java.lang.Float}}
> {{java.lang.Float}}
> {{java.lang.Float}}
> {{java.lang.Float}}
> It seems the problem is towards the bottom of the createNumber method that
> compares the float to double string representation:
> f.toString().equals(d.toString())
> For the misbehaving tests, the string "1.0".equals("1.0")
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (LANG-1666) Add ObjectUtils.equalsAny
[
https://issues.apache.org/jira/browse/LANG-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442522#comment-17442522
]
asha somayajula commented on LANG-1666:
---
Can this be worked or is the PR intended to be merged?
> Add ObjectUtils.equalsAny
> -
>
> Key: LANG-1666
> URL: https://issues.apache.org/jira/browse/LANG-1666
> Project: Commons Lang
> Issue Type: New Feature
>Reporter: Felix Hagemans
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I think an {{equalsAny}} utility method would be a nice simple addition to
> the ObjectUtils class. For example:
> {code:java}if (valueA.equals(someObject.getSomeGetter()) ||
> valueB.equals(someObject.getSomeGetter()) { ... }{code}
> could be written a lot cleaner:
> {code:java}if (ObjectUtils.equalsAny(someObject.getSomeGetter(), valueA,
> valueB) { ... }{code}
> It would work similar to the already existing StringUtils.equalsAny method.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-io] dependabot[bot] opened a new pull request #302: Bump spotbugs from 4.4.2 to 4.5.0
dependabot[bot] opened a new pull request #302: URL: https://github.com/apache/commons-io/pull/302 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.2 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-io] kinow commented on a change in pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream
kinow commented on a change in pull request #301:
URL: https://github.com/apache/commons-io/pull/301#discussion_r747903081
##
File path: src/main/java/org/apache/commons/io/input/AutoCloseInputStream.java
##
@@ -76,7 +76,7 @@ protected void afterRead(final int n) throws IOException {
*/
@Override
public void close() throws IOException {
-in.close();
+super.close();
Review comment:
Right, had a look at the source code, and I think:
- before: `in.close()` (removed above) could throw any `IOException` directly
- after: `super.close()` will call `ProxyInputStream#close()` which will
then call `TaggedInputStream#handleIOException` (instead of
`ProxyInputStream#handleIOException`)
So all good here :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-pool] kinow merged pull request #112: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #112: URL: https://github.com/apache/commons-pool/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] kinow merged pull request #114: Bump spotbugs from 4.4.2 to 4.5.0
kinow merged pull request #114: URL: https://github.com/apache/commons-pool/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #185: Bump spotbugs from 4.4.2 to 4.5.0
kinow merged pull request #185: URL: https://github.com/apache/commons-imaging/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #284: Bump spotbugs from 4.4.2 to 4.5.0
dependabot[bot] opened a new pull request #284: URL: https://github.com/apache/commons-text/pull/284 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.2 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[jira] [Commented] (COLLECTIONS-700) Add a ConcurrentWeakHashMap
[
https://issues.apache.org/jira/browse/COLLECTIONS-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442441#comment-17442441
]
asha somayajula commented on COLLECTIONS-700:
-
Can I work this issue? If yes, is there a good place to start? My first really
here on Jira and on commons
Thanks,
Asha
> Add a ConcurrentWeakHashMap
> ---
>
> Key: COLLECTIONS-700
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-700
> Project: Commons Collections
> Issue Type: New Feature
> Components: Map
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
>Priority: Major
>
> Add a {{ConcurrentWeakHashMap}}: A concurrent
> {{[WeakHashMap|https://docs.oracle.com/javase/8/docs/api/java/util/WeakHashMap.html]}}.
> A need for this was found to best support BeanUtils's BEANUTILS-509
> This issue is looking for a volunteer.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-email] dependabot[bot] opened a new pull request #59: Bump spotbugs from 4.2.2 to 4.5.0
dependabot[bot] opened a new pull request #59: URL: https://github.com/apache/commons-email/pull/59 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.2 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-email] dependabot[bot] closed pull request #57: Bump spotbugs from 4.2.2 to 4.4.2
dependabot[bot] closed pull request #57: URL: https://github.com/apache/commons-email/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #57: Bump spotbugs from 4.2.2 to 4.4.2
dependabot[bot] commented on pull request #57: URL: https://github.com/apache/commons-email/pull/57#issuecomment-966591731 Superseded by #59. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #293: Refactor `ReaderInputStream` implementation
garydgregory commented on pull request #293: URL: https://github.com/apache/commons-io/pull/293#issuecomment-966580231 "Please let me know what you think." All builds are red -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory removed a comment on pull request #291: Improve `ReaderInputStream` documentation
garydgregory removed a comment on pull request #291: URL: https://github.com/apache/commons-io/pull/291#issuecomment-966576842 You have 2 PRs with same title, this is confusing and wasted reviewers' time. Please pick one and close the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #291: Improve `ReaderInputStream` documentation
garydgregory commented on pull request #291: URL: https://github.com/apache/commons-io/pull/291#issuecomment-966576842 You have 2 PRs with same title, this is confusing and wasted reviewers' time. Please pick one and close the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a change in pull request #291: Improve `ReaderInputStream` documentation
garydgregory commented on a change in pull request #291:
URL: https://github.com/apache/commons-io/pull/291#discussion_r747770070
##
File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java
##
@@ -129,6 +128,9 @@ public ReaderInputStream(final Reader reader) {
* Constructs a new {@link ReaderInputStream} with a default input buffer
size of {@value #DEFAULT_BUFFER_SIZE}
* characters.
*
+ * The encoder created for the specified charset will use {@link
CodingErrorAction#REPLACE} for malformed input
+ * and unmappable characters.
+ *
Review comment:
Close HTML tags.
##
File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java
##
@@ -156,6 +161,9 @@ public ReaderInputStream(final Reader reader, final Charset
charset, final int b
/**
* Constructs a new {@link ReaderInputStream}.
*
+ * This constructor does not call {@link CharsetEncoder#reset() reset}
on the provided encoder. The caller
+ * of this constructor should do this when providing an encoder which had
already been in use.
+ *
Review comment:
Close HTML tags.
##
File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java
##
@@ -185,6 +196,9 @@ public ReaderInputStream(final Reader reader, final
CharsetEncoder charsetEncode
* Constructs a new {@link ReaderInputStream} with a default input buffer
size of {@value #DEFAULT_BUFFER_SIZE}
* characters.
*
+ * The encoder created for the specified charset will use {@link
CodingErrorAction#REPLACE} for malformed input
+ * and unmappable characters.
+ *
Review comment:
Close HTML tags.
##
File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java
##
@@ -195,6 +209,9 @@ public ReaderInputStream(final Reader reader, final String
charsetName) {
/**
* Constructs a new {@link ReaderInputStream}.
*
+ * The encoder created for the specified charset will use {@link
CodingErrorAction#REPLACE} for malformed input
+ * and unmappable characters.
+ *
Review comment:
Close HTML tags.
##
File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java
##
@@ -213,6 +230,16 @@ public void close() throws IOException {
reader.close();
}
+/**
+ * The implementation by {@link ReaderInputStream} always returns 0.
+ */
+@Override
+public int available() throws IOException {
+// Could implement this using Reader.ready(), but would be rather
cumbersome
+// and probably not very efficient
+return 0;
+}
+
Review comment:
This PR is only supposed to be about docs as stated in the PR title.
Furthermore this change is not matched with a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a change in pull request #300: IOUtils chain together IOException for Closeables, add overload
garydgregory commented on a change in pull request #300:
URL: https://github.com/apache/commons-io/pull/300#discussion_r747768611
##
File path: src/main/java/org/apache/commons/io/function/IOConsumer.java
##
@@ -85,13 +150,25 @@
*/
void accept(T t) throws IOException;
+/**
+ * Returns this {@code IOConsumer} wrapped inside of a {@link Consumer}
+ * that throws {@link UncheckedIOException} for any {@link IOException}s
+ * that are thrown by this {@code IOConsumer}.
+ *
+ * @return a {@code Consumer} that wraps this {@code IOConsumer}.
+ * @since 2.12.0
+ */
+default Consumer asConsumer() {
+return wrap(this);
Review comment:
I do not think we need an extra method that just delegates to an
existing one. What is the added value? Am I missing something here?
##
File path: src/main/java/org/apache/commons/io/IOUtils.java
##
@@ -394,6 +394,25 @@ public static void close(final Closeable... closeables)
throws IOException {
IOConsumer.forEach(closeables, IOUtils::close);
}
+/**
+ * Closes the entries in the given {@link Stream} as null-safe operations,
+ * and closes the underlying {@code Stream}.
+ *
+ * @param The element type.
+ * @param closeables The resource(s) to close, may be null.
+ * @throws IOExceptionList if an I/O error occurs.
+ * @since 2.12.0
+ */
+public static void close(final Stream closeables)
throws IOExceptionList {
+if (closeables != null) {
+try {
+IOConsumer.forEachIndexed(closeables, IOUtils::close);
+} finally {
+closeables.close();
Review comment:
This method should not release a resource it did not acquire IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a change in pull request #300: IOUtils chain together IOException for Closeables, add overload
garydgregory commented on a change in pull request #300:
URL: https://github.com/apache/commons-io/pull/300#discussion_r747766235
##
File path: src/main/java/org/apache/commons/io/IOUtils.java
##
@@ -414,6 +433,48 @@ public static void close(final Closeable closeable, final
IOConsumer The element type.
+ * @param consumer Consume the IOException thrown by {@link
Closeable#close()}.
+ * @param closeables The resource(s) to close, may be null.
+ * @throws IOException if an I/O error occurs.
+ */
+public static void close(final
IOConsumer consumer, final Stream closeables) throws
IOException {
+if (closeables != null) {
+try {
+close(closeables);
+} catch (final IOException e) {
+if (consumer != null) {
+consumer.accept(e);
+}
+} finally {
+closeables.close();
Review comment:
This seems wrong to me since this method did not create the stream. The
caller should manage the stream IMO, it does not matter that a stream also
happens to be closeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #185: Bump spotbugs from 4.4.2 to 4.5.0
coveralls commented on pull request #185: URL: https://github.com/apache/commons-imaging/pull/185#issuecomment-966539020 [](https://coveralls.io/builds/44202800) Coverage remained the same at 77.132% when pulling **b3e98cd76a6dcf5780c15909cef4a81aa7c55878 on dependabot/maven/com.github.spotbugs-spotbugs-4.5.0** into **310395799ed09a6b8848115b847bf0a49bc0ad45 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] denislilajFox closed pull request #283: Create build.yml
denislilajFox closed pull request #283: URL: https://github.com/apache/commons-text/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] dependabot[bot] opened a new pull request #185: Bump spotbugs from 4.4.2 to 4.5.0
dependabot[bot] opened a new pull request #185: URL: https://github.com/apache/commons-imaging/pull/185 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.2 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-text] denislilajFox closed pull request #282: AddedFiles
denislilajFox closed pull request #282: URL: https://github.com/apache/commons-text/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DAEMON-435) While stopping service, service crashed with error 1067
[ https://issues.apache.org/jira/browse/DAEMON-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442361#comment-17442361 ] Gary D. Gregory commented on DAEMON-435: Hi [~kavig] It would help to get logging from the Java app you are managing, which might be the most revealing of all. You could also clone our git repo and build the current version of prunsrv.exe which provides more debug logging. See in src\native\windows\README.txt for build instructions. > While stopping service, service crashed with error 1067 > --- > > Key: DAEMON-435 > URL: https://issues.apache.org/jira/browse/DAEMON-435 > Project: Commons Daemon > Issue Type: Bug >Affects Versions: 1.2.4 >Reporter: Kaviarasi >Priority: Blocker > > When stopping the service, service crashes with Error 1067: The process > terminated unexpectedly. > > When enabled the debug mode for prunsrv, following messages are seen > > [2021-10-29 12:34:53] [debug] ( prunsrv.c:1892) [ 1816] Apache Commons Daemon > procrun log initialized. > [2021-10-29 12:34:53] [info] ( prunsrv.c:1896) [ 1816] Apache Commons Daemon > procrun (1.2.4.0 64-bit) started. > [2021-10-29 12:34:53] [info] ( prunsrv.c:945 ) [ 1816] Updating service... > [2021-10-29 12:34:53] [warn] ( service.c:143 ) [ 1816] Failed to obtain > service description > [2021-10-29 12:34:53] [info] ( prunsrv.c:1007) [ 1816] Updated service > 'OracleAVAgent'. > [2021-10-29 12:34:53] [info] ( prunsrv.c:1014) [ 1816] Finished updating > service 'OracleAVAgent'. > [2021-10-29 12:34:53] [info] ( prunsrv.c:1980) [ 1816] Apache Commons Daemon > procrun finished. > [2021-10-29 12:34:53] [debug] ( prunsrv.c:1032) [12208] reportServiceStatusE: > dwCurrentState = 4, dwWin32ExitCode = 0, dwWaitHint = 0, > dwServiceSpecificExitCode = 0. > [2021-10-29 12:34:53] [debug] ( prunsrv.c:1032) [12208] reportServiceStatusE: > dwCurrentState = 3, dwWin32ExitCode = 0, dwWaitHint = 3000, > dwServiceSpecificExitCode = 0. > [2021-10-29 12:34:53] [info] ( prunsrv.c:1132) [10076] Stopping service... > [2021-10-29 12:34:53] [debug] ( javajni.c:414 ) [10076] Loaded JVM DLL '', > home ''. > [2021-10-29 12:34:53] [debug] ( javajni.c:419 ) [10076] > JNI_GetCreatedJavaVMs... > [2021-10-29 12:34:53] [debug] ( javajni.c:1039) [ 8808] DLL search path set > to ' > [2021-10-29 12:34:53] [debug] ( javajni.c:1003) [ 8808] argv[0] = STOP > [2021-10-29 12:34:53] [debug] ( javajni.c:1003) [ 8808] argv[1] = -l > [2021-10-29 12:34:53] [debug] ( javajni.c:1003) [ 8808] argv[2] = WARNING > [2021-10-29 12:34:53] [debug] ( javajni.c:1062) [ 8808] Java worker thread > started for oracle/av/platform/agent/AgentController:main > [2021-10-29 12:34:53] [debug] ( javajni.c:1068) [ 8808] JNI calling static > void method oracle/av/platform/agent/AgentController:main > [2021-10-29 12:34:54] [debug] ( javajni.c:566 ) [12220] Exit hook with exit > code 0 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (POOL-391) GenericKeyedObjectPool is not thread safe when invoke method `borrowObject` and `destroy` simultaneously
[
https://issues.apache.org/jira/browse/POOL-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442354#comment-17442354
]
Phil Steitz commented on POOL-391:
--
A fix for this is in [https://github.com/apache/commons-pool/pull/113]
The lack of "atomicity" is by design, to avoid synchronization delays waiting
for creates to complete. Other public methods that create capacity (return,
invalidate, evict, etc) call reuseCapacity, which allocates freed capacity to
pools that have borrowers waiting. The PR modifies clear() to (optionally) do
this.
> GenericKeyedObjectPool is not thread safe when invoke method `borrowObject`
> and `destroy` simultaneously
> -
>
> Key: POOL-391
> URL: https://issues.apache.org/jira/browse/POOL-391
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 2.4.2, 2.5.0, 2.6.0, 2.7.0, 2.8.0, 2.9.0
>Reporter: Codievilky August
>Priority: Blocker
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The method `brrowObject` is not thread safe with `destroy` or `clear` method.
> The reason is when use GenericKeyedObjectPool#destroy method，it did not
> ensure the *Atomicity* of destroy object from the ObjectDeque。
> This may cause in the GenericKeyedObjectPool#borrowObject method，may get the
> wrong number of GenericKeyedObjectPool.ObjectDeque#getCreateCount when need
> to create. And the GenericKeyedObjectPool#borrowObject will block until
> timeout.
> Here is the sample test code to recur the bug:
> {code:java}
> // code placeholder
> public class CommonPoolMultiThreadTest {
> public static void main(String[] args) {
> GenericKeyedObjectPoolConfig config = new GenericKeyedObjectPoolConfig();
> config.setMaxTotalPerKey(1);
> config.setMinIdlePerKey(0);
> config.setMaxIdlePerKey(-1);
> config.setMaxTotal(-1);
> config.setMaxWaitMillis(TimeUnit.SECONDS.toMillis(5));
> GenericKeyedObjectPool testPool = new
> GenericKeyedObjectPool<>(
> new KeyedPooledObjectFactory() {
> @Override
> public PooledObject makeObject(Integer key) throws
> Exception {
> System.out.println("start to create");
> return new DefaultPooledObject<>(10);
> } @Override
> public void destroyObject(Integer key, PooledObject p)
> throws Exception {
> System.out.println("start to destroy");
> Thread.sleep(2000);
> } @Override
> public boolean validateObject(Integer key, PooledObject p)
> {
> return true;
> } @Override
> public void activateObject(Integer key, PooledObject p)
> throws Exception {
> // do nothing
> } @Override
> public void passivateObject(Integer key, PooledObject p)
> throws Exception {
> // do nothing
> }
> }, config
> );
> int borrowKey = 10;
> Thread t = new Thread(() -> {
> try {
> while (true) {
> Integer integer = testPool.borrowObject(borrowKey);
> testPool.returnObject(borrowKey, integer);
> Thread.sleep(10);
> }
> } catch (Exception e) {
> e.printStackTrace();
> System.exit(1);
> }
> });
> Thread t2 = new Thread(() -> {
> try {
> while (true) {
> testPool.clear(borrowKey);
> Thread.sleep(10);
> }
> } catch (Exception e) {
> e.printStackTrace();
> System.exit(1);
> }
> });
> t.start();
> t2.start();
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-lang] dependabot[bot] commented on pull request #818: Bump spotbugs from 4.2.3 to 4.4.2
dependabot[bot] commented on pull request #818: URL: https://github.com/apache/commons-lang/pull/818#issuecomment-966399289 Superseded by #826. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] opened a new pull request #826: Bump spotbugs from 4.2.3 to 4.5.0
dependabot[bot] opened a new pull request #826: URL: https://github.com/apache/commons-lang/pull/826 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.3 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-lang] dependabot[bot] closed pull request #818: Bump spotbugs from 4.2.3 to 4.4.2
dependabot[bot] closed pull request #818: URL: https://github.com/apache/commons-lang/pull/818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe opened a new pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream
wodencafe opened a new pull request #301: URL: https://github.com/apache/commons-io/pull/301 This pull request is to use `TaggedInputStream` as a superclass where possible, in place of `ProxyInputStream`, to allow access to the methods `isCauseOf` and `throwIfCauseOf`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] closed pull request #65: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] closed pull request #65: URL: https://github.com/apache/commons-parent/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] commented on pull request #65: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] commented on pull request #65: URL: https://github.com/apache/commons-parent/pull/65#issuecomment-966297690 Superseded by #73. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] dependabot[bot] opened a new pull request #73: Bump spotbugs from 4.4.1 to 4.5.0
dependabot[bot] opened a new pull request #73: URL: https://github.com/apache/commons-parent/pull/73 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-pool] coveralls commented on pull request #114: Bump spotbugs from 4.4.2 to 4.5.0
coveralls commented on pull request #114: URL: https://github.com/apache/commons-pool/pull/114#issuecomment-966268486 [](https://coveralls.io/builds/44192907) Coverage decreased (-0.06%) to 84.989% when pulling **d6b96f65b93d49bf52e01341ad9f9d1f6b4fb9cc on dependabot/maven/com.github.spotbugs-spotbugs-4.5.0** into **1c57be31e8dae6cd504ee7932d62f332eef69ec1 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] dependabot[bot] opened a new pull request #114: Bump spotbugs from 4.4.2 to 4.5.0
dependabot[bot] opened a new pull request #114: URL: https://github.com/apache/commons-pool/pull/114 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.2 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[GitHub] [commons-bsf] dependabot[bot] closed pull request #24: Bump spotbugs from 4.2.0 to 4.4.2
dependabot[bot] closed pull request #24: URL: https://github.com/apache/commons-bsf/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bsf] dependabot[bot] commented on pull request #24: Bump spotbugs from 4.2.0 to 4.4.2
dependabot[bot] commented on pull request #24: URL: https://github.com/apache/commons-bsf/pull/24#issuecomment-966235201 Superseded by #30. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bsf] dependabot[bot] opened a new pull request #30: Bump spotbugs from 4.2.0 to 4.5.0
dependabot[bot] opened a new pull request #30: URL: https://github.com/apache/commons-bsf/pull/30 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.0 to 4.5.0. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.5.0 CHANGELOG Changed Replace 分析 with 解析 in Japanese document (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1573;>#1573) https://github.com/KengoTODA;>@KengoTODA Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/540;>#540) https://github.com/luana-martins;>@luana-martins Bump gson from 2.8.8 to 2.8.9 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1784;>#1784) Changes related to dominators analysis in package edu.umd.cs.findbugs.classfile.engine.bcel (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1741;>#1741): https://github.com/gamesh411;>@gamesh411 DominatorsAnalysisFactory renamed to NonExceptionDominatorsAnalysisFactory (clarification) NonExceptionPostdominatorsAnalysisFactory renamed to NonExceptionPostDominatorsAnalysisFactory (spelling) NonImplicitExceptionDominatorsAnalysis introduced (API consistency) Added Rule DCN_NULLPOINTER_EXCEPTION covers catching NullPointerExceptions in accordance with SEI Cert rule https://wiki.sei.cmu.edu/confluence/display/java/ERR08-J.+Do+not+catch+NullPointerException+or+any+of+its+ancestors;>ERR08-J (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1740;>#1740) https://github.com/gamesh411;>@gamesh411 Multiple types of report can be generated in batch. Set multiple commandline options for report configuration like -html=report/spotbugs.html -xml:withMessages=report/spotbugs.xml. https://github.com/KengoTODA;>@KengoTODA New rule REFL_REFLECTION_INCREASES_ACCESSIBILITY_OF_CLASS to detect public methods instantiating a class they get in their parameter. This rule based on the SEI CERT rule SEC05-J. Do not use reflection to increase accessibility of classes, methods, or fields. (https://wiki.sei.cmu.edu/confluence/display/java/SEC05-J.+Do+not+use+reflection+to+increase+accessibility+of+classes%2C+methods%2C+or+fields;>#SEC05-J) https://github.com/baloghadamsoftware;>@baloghadamsoftware New detector FindOverridableMethodCall to detect invocation of overridable method in constructors (MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR) and clone() method (MC_OVERRIDABLE_METHOD_CALL_IN_CLONE), according to SEI CERT rules https://wiki.sei.cmu.edu/confluence/display/java/MET05-J.+Ensure+that+constructors+do+not+call+overridable+methods;>MET05-J. Ensure that constructors do not call overridable methods and https://wiki.sei.cmu.edu/confluence/pages/viewpage.action?pageId=88487921;>MET06-J. Do not invoke overridable methods in clone(). https://github.com/baloghadamsoftware;>@baloghadamsoftware https://spotbugs.readthedocs.io/pt_BR/latest/;>Translation of online manual to Brazilian Portuguese (PT-BR). https://github.com/luana-martins;>@luana-martins Fixed False negative about the rule ES_COMPARING_STRINGS_WITH_EQ (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1764;>#1764) https://github.com/KengoTODA;>@KengoTODA False negative about the rule IM_MULTIPLYING_RESULT_OF_IREM (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>#1498)(https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1498;>spotbugs/spotbugs#1498) https://github.com/ecxia;>@ecxia Deprecated -output command line option is deprecated. Use command line options for report configuration like -xml=spotbugs.xml instead. CHECKSUM file checksum (sha256) spotbugs-4.5.0-javadoc.jar 6f11c4d1aa5ad3f77f8d63b7ded099547d2010ee725c6c1d4eb512735726ca69 spotbugs-4.5.0-sources.jar 4bf5daff85cf2e7fbc1b0950be87d7933f1bb80756cf9f55c534a63f07551eb9 spotbugs-4.5.0.tgz 327d5e36afa223737e871114e173c6f2d4543e22c6167bc7825001a752a3cf31 spotbugs-4.5.0.zip 988c43c5c36f3799fe9a0cf9714f95940a2d60764a9aa0af3e6ccc137106b97e spotbugs-annotations-4.5.0-javadoc.jar 76c580b054ce653658d747fcf8aa76d5934f119f2f988cec2e9feafb3f6b9bed spotbugs-annotations-4.5.0-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar 65199ea3fe5dc4d106e30ebf67a92c7c816da816563d75c8ea6da1f0ff662857 spotbugs-ant-4.5.0-javadoc.jar c12a84e031a3ec5a0fd405e1f696f8e32ddd4a43769eb8dd145b77383e0b5506 spotbugs-ant-4.5.0-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar
[jira] [Work logged] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=680230=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680230
]
ASF GitHub Bot logged work on IO-552:
-
Author: ASF GitHub Bot
Created on: 11/Nov/21 11:15
Start Date: 11/Nov/21 11:15
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #297:
URL: https://github.com/apache/commons-io/pull/297#issuecomment-966218165
> @kinow Do you have any idea why the macos-latest, Java 11 CI would fail?
The test that failed does not appear to be related to the changes made in this
PR, from what I can tell thinking
No idea @wodencafe , sorry. I started looking at Commons IO recently
(normally focus on other components, but am on a sabbatical, so more spare
time), and haven't seen the error yet.
But agree that it doesn't appear to be related to your change. For others,
the failure:
```bash
Error: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.208 s <<< FAILURE! - in org.apache.commons.io.FileUtilsWaitForTest
Error: org.apache.commons.io.FileUtilsWaitForTest.testWaitForInterrupted
Time elapsed: 0.02 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: but was:
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
at
org.apache.commons.io.FileUtilsWaitForTest.testWaitForInterrupted(FileUtilsWaitForTest.java:56)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at
org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:188)
at
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:154)
at
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 680230)
Time Spent: 1h 50m (was: 1h 40m)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt")
[GitHub] [commons-io] kinow commented on pull request #297: IO-552: Honor tilde as a valid character for file and directory names
kinow commented on pull request #297: URL: https://github.com/apache/commons-io/pull/297#issuecomment-966218165 > @kinow Do you have any idea why the macos-latest, Java 11 CI would fail? The test that failed does not appear to be related to the changes made in this PR, from what I can tell thinking No idea @wodencafe , sorry. I started looking at Commons IO recently (normally focus on other components, but am on a sabbatical, so more spare time), and haven't seen the error yet. But agree that it doesn't appear to be related to your change. For others, the failure: ```bash Error: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.208 s <<< FAILURE! - in org.apache.commons.io.FileUtilsWaitForTest Error: org.apache.commons.io.FileUtilsWaitForTest.testWaitForInterrupted Time elapsed: 0.02 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35) at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179) at org.apache.commons.io.FileUtilsWaitForTest.testWaitForInterrupted(FileUtilsWaitForTest.java:56) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84) at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115) at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:188) at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:154) at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=680228=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680228
]
ASF GitHub Bot logged work on IO-552:
-
Author: ASF GitHub Bot
Created on: 11/Nov/21 11:08
Start Date: 11/Nov/21 11:08
Worklog Time Spent: 10m
Work Description: wodencafe commented on pull request #297:
URL: https://github.com/apache/commons-io/pull/297#issuecomment-966212835
@kinow Do you have any idea why the macos-latest, Java 11 CI would fail? The
test that failed does not appear to be related to the changes made in this PR,
from what I can tell :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 680228)
Time Spent: 1h 40m (was: 1.5h)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-io] wodencafe commented on pull request #297: IO-552: Honor tilde as a valid character for file and directory names
wodencafe commented on pull request #297: URL: https://github.com/apache/commons-io/pull/297#issuecomment-966212835 @kinow Do you have any idea why the macos-latest, Java 11 CI would fail? The test that failed does not appear to be related to the changes made in this PR, from what I can tell :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=680227=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680227
]
ASF GitHub Bot logged work on IO-552:
-
Author: ASF GitHub Bot
Created on: 11/Nov/21 11:06
Start Date: 11/Nov/21 11:06
Worklog Time Spent: 10m
Work Description: wodencafe commented on a change in pull request #297:
URL: https://github.com/apache/commons-io/pull/297#discussion_r747406658
##
File path: src/test/java/org/apache/commons/io/FilenameUtilsTest.java
##
@@ -251,6 +263,8 @@ public void testGetExtension() {
assertEquals("", FilenameUtils.getExtension("a/b/c"));
assertEquals("", FilenameUtils.getExtension("a.b\\c"));
assertEquals("txt", FilenameUtils.getExtension("a.b\\c.txt"));
+assertEquals("~", FilenameUtils.getExtension("a.b\\c.~"));
Review comment:
Thank you @kinow , happy to help :grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 680227)
Time Spent: 1.5h (was: 1h 20m)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-io] wodencafe commented on a change in pull request #297: IO-552: Honor tilde as a valid character for file and directory names
wodencafe commented on a change in pull request #297:
URL: https://github.com/apache/commons-io/pull/297#discussion_r747406658
##
File path: src/test/java/org/apache/commons/io/FilenameUtilsTest.java
##
@@ -251,6 +263,8 @@ public void testGetExtension() {
assertEquals("", FilenameUtils.getExtension("a/b/c"));
assertEquals("", FilenameUtils.getExtension("a.b\\c"));
assertEquals("txt", FilenameUtils.getExtension("a.b\\c.txt"));
+assertEquals("~", FilenameUtils.getExtension("a.b\\c.~"));
Review comment:
Thank you @kinow , happy to help :grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=680210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680210
]
ASF GitHub Bot logged work on IO-552:
-
Author: ASF GitHub Bot
Created on: 11/Nov/21 09:52
Start Date: 11/Nov/21 09:52
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #297:
URL: https://github.com/apache/commons-io/pull/297#discussion_r747353966
##
File path: src/test/java/org/apache/commons/io/FilenameUtilsTest.java
##
@@ -251,6 +263,8 @@ public void testGetExtension() {
assertEquals("", FilenameUtils.getExtension("a/b/c"));
assertEquals("", FilenameUtils.getExtension("a.b\\c"));
assertEquals("txt", FilenameUtils.getExtension("a.b\\c.txt"));
+assertEquals("~", FilenameUtils.getExtension("a.b\\c.~"));
Review comment:
Now this is a test case I would never had thought about :smile: great
job @wodencafe !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 680210)
Time Spent: 1h 20m (was: 1h 10m)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-io] kinow commented on a change in pull request #297: IO-552: Honor tilde as a valid character for file and directory names
kinow commented on a change in pull request #297:
URL: https://github.com/apache/commons-io/pull/297#discussion_r747353966
##
File path: src/test/java/org/apache/commons/io/FilenameUtilsTest.java
##
@@ -251,6 +263,8 @@ public void testGetExtension() {
assertEquals("", FilenameUtils.getExtension("a/b/c"));
assertEquals("", FilenameUtils.getExtension("a.b\\c"));
assertEquals("txt", FilenameUtils.getExtension("a.b\\c.txt"));
+assertEquals("~", FilenameUtils.getExtension("a.b\\c.~"));
Review comment:
Now this is a test case I would never had thought about :smile: great
job @wodencafe !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
