[jira] [Commented] (NET-408) problem connecting to ProFTPD with FTPES
[
https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484550#comment-17484550
]
Matthias Perktold commented on NET-408:
---
Regarding the problems with FileZilla Server 1.2.0, I [asked on
Stackoverflow|https://stackoverflow.com/questions/70903926/how-to-establish-a-ftps-data-connection-to-a-filezilla-server-1-2-0]
and it looks like the workaround doesn't work when TLS 1.3 is used. Does
anyone have an idea how to adjust the workaround such that it does?
> problem connecting to ProFTPD with FTPES
>
>
> Key: NET-408
> URL: https://issues.apache.org/jira/browse/NET-408
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
>Affects Versions: 2.2, 3.0
> Environment: ProFTPD 1.3.3d on SUSE Linux Enterprise Server 10.1
> 32bit, Kernel 2.6.16.46-0.12-default (config file attached)
> ProFTPD 1.3.3d on OpenSUSE 64bit Linux 2.6.34.8-0.2-desktop
> Java 1.5
>Reporter: Michael Voigt
>Priority: Major
> Attachments: BCFTPSClient.java, FTPSClientWithTLSResumption.zip,
> PTFTPSClient.java, ftpes.jpg, proftpd.conf
>
>
> I have a problem with the FTPClient connecting to a ProFTPD server.
> If the server uses the configuration option "TLSProtocol TLSv1", I
> cannot connect to it at all. I recieve the following error message:
> - javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection
> On the server side I see in the log:
> unable to accept TLS connection: protocol error:
> - (1) error:14094416:SSL routines:SSL3_READ_BYTES:sslv3 alert
> certificate unknown
> - TLS/TLS-C negotiation failed on control channel
> If the server uses the configuration option "TLSProtocol SSLv23", I
> can connect to it but I cant transfer any files. In the server log I
> see:
> - starting TLS negotiation on data connection
> - TLSv1/SSLv3 renegotiation accepted, using cipher RC4-MD5 (128 bits)
> - client did not reuse SSL session, rejecting data connection (see
> TLSOption NoSessionReuseRequired)
> - unable to open data connection: TLS negotiation failed
> If I add the NoSessionReuseRequired parameter to the ProFTPD config
> everything works fine.
> Here is my code:
>FTPClient ftpClient = new FTPClient();
>ftpClient = new FTPSClient("TLS");
>// this throws an exception with TLSProtocol TLSv1
>ftpClient.connect(host, port);
>int reply = ftpClient.getReplyCode();
>if (!FTPReply.isPositiveCompletion(reply)) {
>ftpClient.disconnect();
>log.error("The FTP Server did not return a positive
> completion reply!");
>throw new
> FtpTransferException(ECCUtils.ERROR_FTP_CONNECTION);
>}
>boolean loginSuccessful = ftpClient.login(userName, password);
>if (!loginSuccessful) {
>log.error("Login to the FTP Server failed! The
> credentials are not valid.");
>throw new
> FtpTransferException(ECCUtils.ERROR_FTP_LOGIN);
>}
>ftpClient.execPBSZ(0);
>ftpClient.execPROT("P");
>boolean success = ftpClient.storeFile(fileName, fis);
>if (!success) {
>// this is false if "NoSessionReuseRequired" is not set
>}
> Now my question is if it is generally possible to connect to a server
> with "TLSProtocol TLSv1" or "TLSProtocol SSLv23" without the
> "NoSessionReuseRequired" parameter? Could someone provide a piece of
> example code for this?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-io] arturobernalg closed pull request #322: Avoid use deprecated read basic file attributes method.
arturobernalg closed pull request #322: URL: https://github.com/apache/commons-io/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025384907 Hmm, if it hasn't been set up on ci2/buildbot I'm a bit confused as to how those previous snapshots got there as https://builds.apache.org/job/Commons/job/commons-io/ seems to imply the build there has been failing for a year. Eek. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025376139 Someone has to set it up on https://ci2.apache.org/#/ IIRC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025365768 Does something need to be done to trigger a snapshot build off master? I thought they were dailies if there were any new commits, but I don't see new snapshot builds yet at https://repository.apache.org/content/repositories/snapshots/commons-io/commons-io/2.12.0-SNAPSHOT/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #322: Avoid use deprecated read basic file attributes method.
garydgregory commented on pull request #322: URL: https://github.com/apache/commons-io/pull/322#issuecomment-1025285794 The class `PathUtils` defines `readBasicFileAttributes(Path)` and `readBasicFileAttributes(Path. LinkOption...)`, the former being deprecated. When `readBasicFileAttributes(Path)` is removed in 3.0, sources will compile automatically against `readBasicFileAttributes(Path. LinkOption...)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] arturobernalg commented on pull request #322: Avoid use deprecated read basic file attributes method.
arturobernalg commented on pull request #322: URL: https://github.com/apache/commons-io/pull/322#issuecomment-1025236210 > Why? You'd never do this with a vararg method, especially once the deprecated method is deleted in the next major version. Plus, if we do this now, then we'd want to change it again in 3.0 IMO. sorry @garydgregory, don't fallow you. What we should never do? TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #321: Use java8 reference
garydgregory merged pull request #321: URL: https://github.com/apache/commons-io/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #322: Avoid use deprecated read basic file attributes method.
garydgregory commented on pull request #322: URL: https://github.com/apache/commons-io/pull/322#issuecomment-1025233047 Why? You'd never do this with a vararg method, especially once the deprecated method is deleted in the next major version. Plus, if we do this now, then we'd want to change it again in 3.0 IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (IMAGING-237) The PNG parser must inform the user if the compression method is not supported
[ https://issues.apache.org/jira/browse/IMAGING-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-237: --- Assignee: Bruno P. Kinoshita > The PNG parser must inform the user if the compression method is not supported > -- > > Key: IMAGING-237 > URL: https://issues.apache.org/jira/browse/IMAGING-237 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: PNG >Affects Versions: 1.0-alpha1 >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > > Today I was looking at the ICCP chunk type and the PNG image parser, and > noticed that it was using the deflate compression only, regardless of the > compression method value passed by the user. > The documentation does say that deflate (0) is the supported compression, but > that vendor implementations may use different compression algorithms. So > instead of trying to use deflate (which would raise a runtime exception), we > should inform the user that the compression method is not supported. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (IMAGING-327) Rename setExif method in TiffImagingParameters
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-327: --- Fix Version/s: 1.0-alpha3 > Rename setExif method in TiffImagingParameters > -- > > Key: IMAGING-327 > URL: https://issues.apache.org/jira/browse/IMAGING-327 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: TIFF >Affects Versions: 1.0-alpha2 >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (IMAGING-327) Rename setExif method in TiffImagingParameters
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-327: --- Affects Version/s: 1.0-alpha2 > Rename setExif method in TiffImagingParameters > -- > > Key: IMAGING-327 > URL: https://issues.apache.org/jira/browse/IMAGING-327 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: TIFF >Affects Versions: 1.0-alpha2 >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (IMAGING-327) Rename setExif method in TiffImagingParameters
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-327: --- Assignee: Bruno P. Kinoshita > Rename setExif method in TiffImagingParameters > -- > > Key: IMAGING-327 > URL: https://issues.apache.org/jira/browse/IMAGING-327 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: TIFF >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (IMAGING-237) The PNG parser must inform the user if the compression method is not supported
[ https://issues.apache.org/jira/browse/IMAGING-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-237: --- Assignee: (was: Bruno P. Kinoshita) > The PNG parser must inform the user if the compression method is not supported > -- > > Key: IMAGING-237 > URL: https://issues.apache.org/jira/browse/IMAGING-237 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: PNG >Affects Versions: 1.0-alpha1 >Reporter: Bruno P. Kinoshita >Priority: Minor > > Today I was looking at the ICCP chunk type and the PNG image parser, and > noticed that it was using the deflate compression only, regardless of the > compression method value passed by the user. > The documentation does say that deflate (0) is the supported compression, but > that vendor implementations may use different compression algorithms. So > instead of trying to use deflate (which would raise a runtime exception), we > should inform the user that the compression method is not supported. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (IMAGING-327) Rename setExif method in TiffImagingParameters
[ https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved IMAGING-327. Resolution: Fixed > Rename setExif method in TiffImagingParameters > -- > > Key: IMAGING-327 > URL: https://issues.apache.org/jira/browse/IMAGING-327 > Project: Commons Imaging > Issue Type: Improvement > Components: Format: TIFF >Affects Versions: 1.0-alpha2 >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-imaging] kinow commented on pull request #197: Imaging-327, change getExif method name
kinow commented on pull request #197: URL: https://github.com/apache/commons-imaging/pull/197#issuecomment-1025231835 Merged, thanks @gwlucastrig ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #197: Imaging-327, change getExif method name
kinow closed pull request #197: URL: https://github.com/apache/commons-imaging/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig commented on pull request #197: Imaging-327, change getExif method name
gwlucastrig commented on pull request #197: URL: https://github.com/apache/commons-imaging/pull/197#issuecomment-1025223322 Well, it took three tries, but I got it. Ready to go. No further changes are anticipated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #197: Imaging-327, change getExif method name
coveralls commented on pull request #197: URL: https://github.com/apache/commons-imaging/pull/197#issuecomment-1025221610 [](https://coveralls.io/builds/46066622) Coverage remained the same at 76.864% when pulling **a368920bd1f60af1d4d196e40f872c5f6eecb4b8 on gwlucastrig:Imaging-327** into **43de8544e97929b9cae3f84b4175b899efd47fed on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] gwlucastrig opened a new pull request #197: Imaging-327, change getExif method name
gwlucastrig opened a new pull request #197: URL: https://github.com/apache/commons-imaging/pull/197 I am submitting the method-name change as described in Imaging-327. I have made only minimal changes for internal member element names and limited my work to just the TiffImagingParameters class and its unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IMAGING-327) Rename setExif method in TiffImagingParameters
[
https://issues.apache.org/jira/browse/IMAGING-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484408#comment-17484408
]
Gary Lucas commented on IMAGING-327:
The new TiffImagingParameters class offers a welcome improvement over the
previous API, but I suggest that we should rename one of the methods to better
reflect what it does.
When creating a new TIFF file, an application passes in a new TiffDirectory
using an instance of TiffOutputSet.
{code:java}
TiffOutputSet tiffOutputSet = new TiffOutputSet();
tiffOutputSet.addDirectory(tiffDirectory);
TiffImagingParameters tiffParams = new TiffImagingParameters();
tiffParams.setExif(tiffOutputSet); {code}
I propose to change the name of the setExif() method to be setOutputSet().
This change will affect some of the unit tests as well as the main API.
Although output sets may include TIFF tags related to the EXIF standard, not
all output sets are EXIF data.
I believe that the setExif() method owes its name to the code used in the
legacy implementation and the API that has now been replaced. SInce we are
improving the API, it makes sense to change it. Here's an example of the
legacy version:
{code:java}
TiffOutputSet tiffOutputSet = new TiffOutputSet();
tiffOutputSet.addDirectory(tiffDirectory);
params.put(ImagingConstants.PARAM_KEY_EXIF, tiffOutputSet); {code}
> Rename setExif method in TiffImagingParameters
> --
>
> Key: IMAGING-327
> URL: https://issues.apache.org/jira/browse/IMAGING-327
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: TIFF
>Reporter: Gary Lucas
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (IMAGING-327) Rename setExif method in TiffImagingParameters
Gary Lucas created IMAGING-327: -- Summary: Rename setExif method in TiffImagingParameters Key: IMAGING-327 URL: https://issues.apache.org/jira/browse/IMAGING-327 Project: Commons Imaging Issue Type: Improvement Components: Format: TIFF Reporter: Gary Lucas -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-io] garydgregory closed pull request #59: Tailer: speed-up by avoiding BAOS.toByteArray()
garydgregory closed pull request #59: URL: https://github.com/apache/commons-io/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #59: Tailer: speed-up by avoiding BAOS.toByteArray()
garydgregory commented on pull request #59: URL: https://github.com/apache/commons-io/pull/59#issuecomment-1025189373 Closing, no reply since September of last year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory closed pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
garydgregory closed pull request #295: URL: https://github.com/apache/commons-io/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a change in pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
garydgregory commented on a change in pull request #295:
URL: https://github.com/apache/commons-io/pull/295#discussion_r795216962
##
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##
@@ -81,20 +94,46 @@ private static Writer initWriter(final File file, final
Object encoding, final b
if (!fileExistedAlready) {
FileUtils.deleteQuietly(file);
}
-throw ex;
+if (ex instanceof UnsupportedCharsetException) {
+throw new IOException(ex);
Review comment:
Closing, no reply since November of last year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
garydgregory commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-1025188890 Closing, no reply since November of last year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #303: BoundedInputStream extend ProxyInputStream
garydgregory commented on pull request #303: URL: https://github.com/apache/commons-io/pull/303#issuecomment-1025188684 Closing, no reply since November of last year in #301. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory closed pull request #303: BoundedInputStream extend ProxyInputStream
garydgregory closed pull request #303: URL: https://github.com/apache/commons-io/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory closed pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream
garydgregory closed pull request #301: URL: https://github.com/apache/commons-io/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #301: IOUtils use TaggedInputStream instead of ProxyInputStream
garydgregory commented on pull request #301: URL: https://github.com/apache/commons-io/pull/301#issuecomment-1025188592 Closing, no reply since November of last year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a change in pull request #291: Improve `ReaderInputStream` documentation
garydgregory commented on a change in pull request #291:
URL: https://github.com/apache/commons-io/pull/291#discussion_r795216510
##
File path: src/main/java/org/apache/commons/io/input/ReaderInputStream.java
##
@@ -213,6 +230,16 @@ public void close() throws IOException {
reader.close();
}
+/**
+ * The implementation by {@link ReaderInputStream} always returns 0.
+ */
+@Override
+public int available() throws IOException {
+// Could implement this using Reader.ready(), but would be rather
cumbersome
+// and probably not very efficient
+return 0;
+}
+
Review comment:
Please drop this method, it duplicates the superclass' implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #299: IOUtils clean up javadoc
garydgregory commented on pull request #299: URL: https://github.com/apache/commons-io/pull/299#issuecomment-1025187607 HI @wodencafe It's quite hard to review such a giant changeset that claims to only be about Javadoc but also changes the code in `contentEqualsIgnoreEOL`, so let's drop code changes, then I can just review Javadoc. TY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-484) FilenameUtils should handle embedded null bytes
[ https://issues.apache.org/jira/browse/IO-484?focusedWorklogId=717668=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717668 ] ASF GitHub Bot logged work on IO-484: - Author: ASF GitHub Bot Created on: 30/Jan/22 17:02 Start Date: 30/Jan/22 17:02 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #310: URL: https://github.com/apache/commons-io/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 717668) Time Spent: 1h 40m (was: 1.5h) > FilenameUtils should handle embedded null bytes > --- > > Key: IO-484 > URL: https://issues.apache.org/jira/browse/IO-484 > Project: Commons IO > Issue Type: Bug > Components: Utilities >Affects Versions: 2.4 >Reporter: Kristian Rosenvold >Assignee: Kristian Rosenvold >Priority: Major > Fix For: 2.5 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > embedding nulls in filenames exposes injection vectors if the application > passes unsanitized data to some functions in FileNameUtils -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-io] garydgregory merged pull request #310: (doc) [IO-484] Fix incorrect FilenameUtils documentation for null bytes
garydgregory merged pull request #310: URL: https://github.com/apache/commons-io/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] chadlwilson edited a comment on pull request #319: Fixes regression on copyURLToFile with partial regression tests
chadlwilson edited a comment on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025159115 Okay thanks, will give it a go when the snapshot is rebuilt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] chadlwilson closed pull request #319: Fixes regression on copyURLToFile with partial regression tests
chadlwilson closed pull request #319: URL: https://github.com/apache/commons-io/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] chadlwilson commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests
chadlwilson commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025159115 Okay thanks, will give it a go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #319: Fixes regression on copyURLToFile with partial regression tests
garydgregory commented on pull request #319: URL: https://github.com/apache/commons-io/pull/319#issuecomment-1025157666 Hello @chadlwilson I adapted the new tests and provided a different fix. Please test git master for your use case. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
