[jira] [Work logged] (LANG-1172) LocaleUtils.toLocale does not handle extensions
[
https://issues.apache.org/jira/browse/LANG-1172?focusedWorklogId=737207=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737207
]
ASF GitHub Bot logged work on LANG-1172:
Author: ASF GitHub Bot
Created on: 06/Mar/22 05:11
Start Date: 06/Mar/22 05:11
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-1059896889
You should build git master locally to make sure you can use the jar in your
app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737207)
Time Spent: 3.5h (was: 3h 20m)
> LocaleUtils.toLocale does not handle extensions
> ---
>
> Key: LANG-1172
> URL: https://issues.apache.org/jira/browse/LANG-1172
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3
>Reporter: David Buhler
>Priority: Major
> Fix For: 3.13.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> The {{toLocale()}} method is unable to handle locale strings that have custom
> extensions that are completely valid according to the [BCP47
> spec|https://tools.ietf.org/html/bcp47#section-4]. Oracle documentation for
> sub tag extensions can be [found
> here|https://docs.oracle.com/javase/tutorial/i18n/locale/extensions.html].
> An example locale string with a custom extension might be {{fr-CA-x-nb}}.
> This issue seems to have been introduced with ticket LANG-915.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-lang] garydgregory commented on pull request #766: LANG-1172: Support dash as a delimiter in locales
garydgregory commented on pull request #766: URL: https://github.com/apache/commons-lang/pull/766#issuecomment-1059896889 You should build git master locally to make sure you can use the jar in your app. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1172) LocaleUtils.toLocale does not handle extensions
[
https://issues.apache.org/jira/browse/LANG-1172?focusedWorklogId=737203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737203
]
ASF GitHub Bot logged work on LANG-1172:
Author: ASF GitHub Bot
Created on: 06/Mar/22 03:15
Start Date: 06/Mar/22 03:15
Worklog Time Spent: 10m
Work Description: c-w commented on pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#issuecomment-1059885900
Thanks for the merge! :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737203)
Time Spent: 3h 20m (was: 3h 10m)
> LocaleUtils.toLocale does not handle extensions
> ---
>
> Key: LANG-1172
> URL: https://issues.apache.org/jira/browse/LANG-1172
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3
>Reporter: David Buhler
>Priority: Major
> Fix For: 3.13.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> The {{toLocale()}} method is unable to handle locale strings that have custom
> extensions that are completely valid according to the [BCP47
> spec|https://tools.ietf.org/html/bcp47#section-4]. Oracle documentation for
> sub tag extensions can be [found
> here|https://docs.oracle.com/javase/tutorial/i18n/locale/extensions.html].
> An example locale string with a custom extension might be {{fr-CA-x-nb}}.
> This issue seems to have been introduced with ticket LANG-915.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-lang] c-w commented on pull request #766: LANG-1172: Support dash as a delimiter in locales
c-w commented on pull request #766: URL: https://github.com/apache/commons-lang/pull/766#issuecomment-1059885900 Thanks for the merge! :tada: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1172) LocaleUtils.toLocale does not handle extensions
[
https://issues.apache.org/jira/browse/LANG-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-1172.
---
Fix Version/s: 3.13.0
Resolution: Fixed
> LocaleUtils.toLocale does not handle extensions
> ---
>
> Key: LANG-1172
> URL: https://issues.apache.org/jira/browse/LANG-1172
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3
>Reporter: David Buhler
>Priority: Major
> Fix For: 3.13.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The {{toLocale()}} method is unable to handle locale strings that have custom
> extensions that are completely valid according to the [BCP47
> spec|https://tools.ietf.org/html/bcp47#section-4]. Oracle documentation for
> sub tag extensions can be [found
> here|https://docs.oracle.com/javase/tutorial/i18n/locale/extensions.html].
> An example locale string with a custom extension might be {{fr-CA-x-nb}}.
> This issue seems to have been introduced with ticket LANG-915.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (LANG-1172) LocaleUtils.toLocale does not handle extensions
[
https://issues.apache.org/jira/browse/LANG-1172?focusedWorklogId=737198=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737198
]
ASF GitHub Bot logged work on LANG-1172:
Author: ASF GitHub Bot
Created on: 06/Mar/22 00:21
Start Date: 06/Mar/22 00:21
Worklog Time Spent: 10m
Work Description: garydgregory merged pull request #766:
URL: https://github.com/apache/commons-lang/pull/766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737198)
Time Spent: 3h 10m (was: 3h)
> LocaleUtils.toLocale does not handle extensions
> ---
>
> Key: LANG-1172
> URL: https://issues.apache.org/jira/browse/LANG-1172
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.3
>Reporter: David Buhler
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The {{toLocale()}} method is unable to handle locale strings that have custom
> extensions that are completely valid according to the [BCP47
> spec|https://tools.ietf.org/html/bcp47#section-4]. Oracle documentation for
> sub tag extensions can be [found
> here|https://docs.oracle.com/javase/tutorial/i18n/locale/extensions.html].
> An example locale string with a custom extension might be {{fr-CA-x-nb}}.
> This issue seems to have been introduced with ticket LANG-915.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-lang] garydgregory merged pull request #766: LANG-1172: Support dash as a delimiter in locales
garydgregory merged pull request #766: URL: https://github.com/apache/commons-lang/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[ https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737190=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737190 ] ASF GitHub Bot logged work on COLLECTIONS-777: -- Author: ASF GitHub Bot Created on: 05/Mar/22 23:10 Start Date: 05/Mar/22 23:10 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059847431 > EmptyPropertiesTest is failing but I've not touched that, and it passes locally using Java 1.8, 11 and 17. So not sure what to do. Write more asserts until you nail it down ;-) - Could the default platform encoding be an issue? - Could an end-of-line character or character sequence be an issue? - Is this OS specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737190) Time Spent: 4h 40m (was: 4.5h) > Fully migrate Commons Collection to JUnit 5 > --- > > Key: COLLECTIONS-777 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-777 > Project: Commons Collections > Issue Type: Improvement > Components: Core >Reporter: Arturo Bernal >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > The idea it's fully migrate Commons Collection to JUnit 5. This time i'll > split the work in sub-task in order to avoid PR with to many files -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[ https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737191 ] ASF GitHub Bot logged work on COLLECTIONS-777: -- Author: ASF GitHub Bot Created on: 05/Mar/22 23:10 Start Date: 05/Mar/22 23:10 Worklog Time Spent: 10m Work Description: garydgregory edited a comment on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059847431 > EmptyPropertiesTest is failing but I've not touched that, and it passes locally using Java 1.8, 11 and 17. So not sure what to do. Write more asserts until you nail it down ;-) - Could the default platform encoding be an issue? - Could an end-of-line character or character sequence be an issue? - Is this OS-specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737191) Time Spent: 4h 50m (was: 4h 40m) > Fully migrate Commons Collection to JUnit 5 > --- > > Key: COLLECTIONS-777 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-777 > Project: Commons Collections > Issue Type: Improvement > Components: Core >Reporter: Arturo Bernal >Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > The idea it's fully migrate Commons Collection to JUnit 5. This time i'll > split the work in sub-task in order to avoid PR with to many files -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-collections] garydgregory edited a comment on pull request #287: COLLECTIONS-777 JUnit v5
garydgregory edited a comment on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059847431 > EmptyPropertiesTest is failing but I've not touched that, and it passes locally using Java 1.8, 11 and 17. So not sure what to do. Write more asserts until you nail it down ;-) - Could the default platform encoding be an issue? - Could an end-of-line character or character sequence be an issue? - Is this OS-specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on pull request #287: COLLECTIONS-777 JUnit v5
garydgregory commented on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059847431 > EmptyPropertiesTest is failing but I've not touched that, and it passes locally using Java 1.8, 11 and 17. So not sure what to do. Write more asserts until you nail it down ;-) - Could the default platform encoding be an issue? - Could an end-of-line character or character sequence be an issue? - Is this OS specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[ https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737185 ] ASF GitHub Bot logged work on COLLECTIONS-777: -- Author: ASF GitHub Bot Created on: 05/Mar/22 21:57 Start Date: 05/Mar/22 21:57 Worklog Time Spent: 10m Work Description: nhojpatrick commented on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059837231 EmptyPropertiesTest is failing but I've not touched that, and it passes locally using Java 1.8, 11 and 17. So not sure what to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737185) Time Spent: 4.5h (was: 4h 20m) > Fully migrate Commons Collection to JUnit 5 > --- > > Key: COLLECTIONS-777 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-777 > Project: Commons Collections > Issue Type: Improvement > Components: Core >Reporter: Arturo Bernal >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > > The idea it's fully migrate Commons Collection to JUnit 5. This time i'll > split the work in sub-task in order to avoid PR with to many files -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-collections] nhojpatrick commented on pull request #287: COLLECTIONS-777 JUnit v5
nhojpatrick commented on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059837231 EmptyPropertiesTest is failing but I've not touched that, and it passes locally using Java 1.8, 11 and 17. So not sure what to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #850: improve DateUtils by adding calenda.month in comparison in considerin…
garydgregory closed pull request #850: URL: https://github.com/apache/commons-lang/pull/850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #850: improve DateUtils by adding calenda.month in comparison in considerin…
garydgregory commented on pull request #850: URL: https://github.com/apache/commons-lang/pull/850#issuecomment-1059833201 Closing, zero feedback from OP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737174=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737174
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF GitHub Bot
Created on: 05/Mar/22 20:39
Start Date: 05/Mar/22 20:39
Worklog Time Spent: 10m
Work Description: nhojpatrick commented on a change in pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#discussion_r820145813
##
File path: src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
##
@@ -138,18 +135,13 @@ public void testWhileClosure() {
ClosureUtils.whileClosure(PredicateUtils.uniquePredicate(),
cmd).execute(null);
assertEquals(1, cmd.count);
-try {
-ClosureUtils.whileClosure(null, ClosureUtils.nopClosure());
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(FalsePredicate.falsePredicate(), null);
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(null, null);
-fail();
-} catch (final NullPointerException ex) {}
+assertAll(
+() -> assertThrows(NullPointerException.class, () ->
ClosureUtils.whileClosure(null, ClosureUtils.nopClosure())),
+
Review comment:
I had not spotted i was doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737174)
Time Spent: 4h 20m (was: 4h 10m)
> Fully migrate Commons Collection to JUnit 5
> ---
>
> Key: COLLECTIONS-777
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-777
> Project: Commons Collections
> Issue Type: Improvement
> Components: Core
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> The idea it's fully migrate Commons Collection to JUnit 5. This time i'll
> split the work in sub-task in order to avoid PR with to many files
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] nhojpatrick commented on a change in pull request #287: COLLECTIONS-777 JUnit v5
nhojpatrick commented on a change in pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#discussion_r820145813
##
File path: src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
##
@@ -138,18 +135,13 @@ public void testWhileClosure() {
ClosureUtils.whileClosure(PredicateUtils.uniquePredicate(),
cmd).execute(null);
assertEquals(1, cmd.count);
-try {
-ClosureUtils.whileClosure(null, ClosureUtils.nopClosure());
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(FalsePredicate.falsePredicate(), null);
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(null, null);
-fail();
-} catch (final NullPointerException ex) {}
+assertAll(
+() -> assertThrows(NullPointerException.class, () ->
ClosureUtils.whileClosure(null, ClosureUtils.nopClosure())),
+
Review comment:
I had not spotted i was doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-imaging] oskaredv closed pull request #207: Imaging 306 tests
oskaredv closed pull request #207: URL: https://github.com/apache/commons-imaging/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] oskaredv opened a new pull request #207: Imaging 306 tests
oskaredv opened a new pull request #207: URL: https://github.com/apache/commons-imaging/pull/207 CMYK/CMY test fails because values are in range 0-1. HSL test also probably fails due to this. Rest of the rests succeeds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1662) Create methods on ReflectionToStringBuilder to reflect only select fields
[
https://issues.apache.org/jira/browse/LANG-1662?focusedWorklogId=737161=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737161
]
ASF GitHub Bot logged work on LANG-1662:
Author: ASF GitHub Bot
Created on: 05/Mar/22 18:45
Start Date: 05/Mar/22 18:45
Worklog Time Spent: 10m
Work Description: garydgregory edited a comment on pull request #849:
URL: https://github.com/apache/commons-lang/pull/849#issuecomment-1059813450
Hello @GutoVeronezi
Thank you for your PR.
The name `setSelectedFieldNames1 is confusing because it is not symmetric
(for lack of a better word) with `setExcludeFieldNames`, I think it would be
best as `setIncludeFieldNames` which then is a bit odd since ALL fields are
included by default, so there should be _clear_ documentation that using
`setIncludeFieldNames` overrides this default behavior.
The following behavior should throw an `IllegalStateException` IMO:
```
ReflectionToStringBuilder reflectionToStringBuilder = new
ReflectionToStringBuilder(example, ToStringStyle.JSON_STYLE);
reflectionToStringBuilder.setIncludedFieldNames("a", "b", "e");
reflectionToStringBuilder.setExcludedFieldNames("a", "b", "e"); //
throws IllegalStateException?
System.out.println(reflectionToStringBuilder.build()); // throws
IllegalStateException?
```
IOW what does it mean to set a field as both included and excluded? Does the
"last API call win" or, does the code simply throw an `IllegalStateException`
if the includes and excludes set intersect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737161)
Remaining Estimate: 4.5h (was: 4h 40m)
Time Spent: 1.5h (was: 1h 20m)
> Create methods on ReflectionToStringBuilder to reflect only select fields
> -
>
> Key: LANG-1662
> URL: https://issues.apache.org/jira/browse/LANG-1662
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
>Reporter: Daniel Augusto Veronezi Salvador
>Priority: Minor
> Original Estimate: 6h
> Time Spent: 1.5h
> Remaining Estimate: 4.5h
>
> *ReflectionToStringBuilder* has methods to exclude fields from *toString*; If
> we have an object with several fields and want to reflect only a fews, we
> have to list all the fields that we don't want to reflect and pass to
> *excludeFieldNames*.
> Would be valid implement a way to pass the fields that we want and reflect
> only the selected fields?
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-lang] garydgregory edited a comment on pull request #849: [LANG-1662] Create methods on ReflectionToStringBuilder to reflect only select fields
garydgregory edited a comment on pull request #849:
URL: https://github.com/apache/commons-lang/pull/849#issuecomment-1059813450
Hello @GutoVeronezi
Thank you for your PR.
The name `setSelectedFieldNames1 is confusing because it is not symmetric
(for lack of a better word) with `setExcludeFieldNames`, I think it would be
best as `setIncludeFieldNames` which then is a bit odd since ALL fields are
included by default, so there should be _clear_ documentation that using
`setIncludeFieldNames` overrides this default behavior.
The following behavior should throw an `IllegalStateException` IMO:
```
ReflectionToStringBuilder reflectionToStringBuilder = new
ReflectionToStringBuilder(example, ToStringStyle.JSON_STYLE);
reflectionToStringBuilder.setIncludedFieldNames("a", "b", "e");
reflectionToStringBuilder.setExcludedFieldNames("a", "b", "e"); //
throws IllegalStateException?
System.out.println(reflectionToStringBuilder.build()); // throws
IllegalStateException?
```
IOW what does it mean to set a field as both included and excluded? Does the
"last API call win" or, does the code simply throw an `IllegalStateException`
if the includes and excludes set intersect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1662) Create methods on ReflectionToStringBuilder to reflect only select fields
[
https://issues.apache.org/jira/browse/LANG-1662?focusedWorklogId=737160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737160
]
ASF GitHub Bot logged work on LANG-1662:
Author: ASF GitHub Bot
Created on: 05/Mar/22 18:44
Start Date: 05/Mar/22 18:44
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #849:
URL: https://github.com/apache/commons-lang/pull/849#issuecomment-1059813450
Hello @GutoVeronezi
Thank you for your PR.
The name `setSelectedFieldNames1 is confusing because it is not symmetric
(for lack of a better word) with `setExcludeFieldNames`, I think it would be
best as `setIncludeFieldNames` which then is a bit odd since ALL fields are
included by default, so there should be _clear_ documentation that using
`setIncludeFieldNames` overrides this default behavior.
The following behavior should throw an `IllegalStateException` IMO:
```
ReflectionToStringBuilder reflectionToStringBuilder = new
ReflectionToStringBuilder(example, ToStringStyle.JSON_STYLE);
reflectionToStringBuilder.setIncludedFieldNames("a", "b", "e");
reflectionToStringBuilder.setExcludedFieldNames("a", "b", "e"); //
throws IllegalStateException?
System.out.println(reflectionToStringBuilder.build()); // throws
IllegalStateException?
```
IOW what does it mean to set a field as both included and excluded, does the
"last API call win" or, does the code simply throw an `IllegalStateException`
if the include and exclude set intersect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737160)
Remaining Estimate: 4h 40m (was: 4h 50m)
Time Spent: 1h 20m (was: 1h 10m)
> Create methods on ReflectionToStringBuilder to reflect only select fields
> -
>
> Key: LANG-1662
> URL: https://issues.apache.org/jira/browse/LANG-1662
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
>Reporter: Daniel Augusto Veronezi Salvador
>Priority: Minor
> Original Estimate: 6h
> Time Spent: 1h 20m
> Remaining Estimate: 4h 40m
>
> *ReflectionToStringBuilder* has methods to exclude fields from *toString*; If
> we have an object with several fields and want to reflect only a fews, we
> have to list all the fields that we don't want to reflect and pass to
> *excludeFieldNames*.
> Would be valid implement a way to pass the fields that we want and reflect
> only the selected fields?
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-lang] garydgregory commented on pull request #849: [LANG-1662] Create methods on ReflectionToStringBuilder to reflect only select fields
garydgregory commented on pull request #849:
URL: https://github.com/apache/commons-lang/pull/849#issuecomment-1059813450
Hello @GutoVeronezi
Thank you for your PR.
The name `setSelectedFieldNames1 is confusing because it is not symmetric
(for lack of a better word) with `setExcludeFieldNames`, I think it would be
best as `setIncludeFieldNames` which then is a bit odd since ALL fields are
included by default, so there should be _clear_ documentation that using
`setIncludeFieldNames` overrides this default behavior.
The following behavior should throw an `IllegalStateException` IMO:
```
ReflectionToStringBuilder reflectionToStringBuilder = new
ReflectionToStringBuilder(example, ToStringStyle.JSON_STYLE);
reflectionToStringBuilder.setIncludedFieldNames("a", "b", "e");
reflectionToStringBuilder.setExcludedFieldNames("a", "b", "e"); //
throws IllegalStateException?
System.out.println(reflectionToStringBuilder.build()); // throws
IllegalStateException?
```
IOW what does it mean to set a field as both included and excluded, does the
"last API call win" or, does the code simply throw an `IllegalStateException`
if the include and exclude set intersect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #855: Add countBlanks() function
garydgregory commented on pull request #855: URL: https://github.com/apache/commons-lang/pull/855#issuecomment-1059812394 Zero feedback from OP, closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #855: Add countBlanks() function
garydgregory closed pull request #855: URL: https://github.com/apache/commons-lang/pull/855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #831: feat: list2tree method add
garydgregory closed pull request #831: URL: https://github.com/apache/commons-lang/pull/831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #831: feat: list2tree method add
garydgregory commented on pull request #831: URL: https://github.com/apache/commons-lang/pull/831#issuecomment-1059810436 Closing: See my previous comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #243: JUnitj v5 more progression
garydgregory merged pull request #243: URL: https://github.com/apache/commons-vfs/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] garydgregory merged pull request #251: Bump actions/checkout from 2 to 3
garydgregory merged pull request #251: URL: https://github.com/apache/commons-compress/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #243: JUnitj v5 more progression
garydgregory commented on a change in pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243#discussion_r820123383
##
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/RunTest.java
##
@@ -23,6 +23,7 @@
import junit.framework.TestResult;
public class RunTest {
+
Review comment:
In the future, please don't mix in style changes, it makes the PR larger
and it takes longer to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a change in pull request #243: JUnitj v5 more progression
garydgregory commented on a change in pull request #243:
URL: https://github.com/apache/commons-vfs/pull/243#discussion_r820123383
##
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/RunTest.java
##
@@ -23,6 +23,7 @@
import junit.framework.TestResult;
public class RunTest {
+
Review comment:
In the i
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[ https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737124=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737124 ] ASF GitHub Bot logged work on COLLECTIONS-777: -- Author: ASF GitHub Bot Created on: 05/Mar/22 15:57 Start Date: 05/Mar/22 15:57 Worklog Time Spent: 10m Work Description: codecov-commenter edited a comment on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059548290 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#287](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3c235f9) into [master](https://codecov.io/gh/apache/commons-collections/commit/f93c7d5976550881dfd5382e7bbda89d8c997f6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f93c7d5) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #287 +/- ## = Coverage 85.80% 85.80% Complexity 4674 4674 = Files 292 292 Lines 1347213472 Branches 1955 1955 = Hits 1156011560 Misses 1332 1332 Partials580 580 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f93c7d5...3c235f9](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737124) Time Spent: 4h 10m (was: 4h) > Fully migrate Commons Collection to JUnit 5 > --- > > Key: COLLECTIONS-777 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-777 > Project: Commons Collections > Issue Type: Improvement > Components: Core >Reporter: Arturo Bernal >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > The idea it's fully migrate Commons Collection to JUnit 5. This time i'll > split the work in sub-task in order to avoid PR with to many files -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-collections] codecov-commenter edited a comment on pull request #287: COLLECTIONS-777 JUnit v5
codecov-commenter edited a comment on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059548290 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#287](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3c235f9) into [master](https://codecov.io/gh/apache/commons-collections/commit/f93c7d5976550881dfd5382e7bbda89d8c997f6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f93c7d5) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #287 +/- ## = Coverage 85.80% 85.80% Complexity 4674 4674 = Files 292 292 Lines 1347213472 Branches 1955 1955 = Hits 1156011560 Misses 1332 1332 Partials580 580 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f93c7d5...3c235f9](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] nhojpatrick commented on pull request #243: JUnitj v5 more progression
nhojpatrick commented on pull request #243: URL: https://github.com/apache/commons-vfs/pull/243#issuecomment-1059787035 @garydgregory Have removed failing tests as I couldn't quickly fix, will get in the next batch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1677) It should be possible to exclude fields in ReflectionDiffBuilder
[ https://issues.apache.org/jira/browse/LANG-1677?focusedWorklogId=737091=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737091 ] ASF GitHub Bot logged work on LANG-1677: Author: ASF GitHub Bot Created on: 05/Mar/22 13:31 Start Date: 05/Mar/22 13:31 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1059765423 I'll take a look over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737091) Time Spent: 1h 40m (was: 1.5h) > It should be possible to exclude fields in ReflectionDiffBuilder > > > Key: LANG-1677 > URL: https://issues.apache.org/jira/browse/LANG-1677 > Project: Commons Lang > Issue Type: Wish > Components: lang.builder.* >Affects Versions: 3.12.0 >Reporter: Dennis Baerten >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > When using ReflectionDiffBuilder to make a diff between two object it will be > default include all fields. As stated in the documentation static and > transient fields are excluded. > Using the transient modifier in combination with other frameworks ( such as > Hibernate ) also has a side affect that those fields are not persisted. > The use case I'm trying to solve it making a diff of an object that get's > updated and has a LastModificationDate and LastModificationUser and thus will > always be a field in the diff. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-lang] garydgregory commented on pull request #838: LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…
garydgregory commented on pull request #838: URL: https://github.com/apache/commons-lang/pull/838#issuecomment-1059765423 I'll take a look over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737077
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF GitHub Bot
Created on: 05/Mar/22 11:49
Start Date: 05/Mar/22 11:49
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#discussion_r820088257
##
File path: src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
##
@@ -138,18 +135,13 @@ public void testWhileClosure() {
ClosureUtils.whileClosure(PredicateUtils.uniquePredicate(),
cmd).execute(null);
assertEquals(1, cmd.count);
-try {
-ClosureUtils.whileClosure(null, ClosureUtils.nopClosure());
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(FalsePredicate.falsePredicate(), null);
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(null, null);
-fail();
-} catch (final NullPointerException ex) {}
+assertAll(
+() -> assertThrows(NullPointerException.class, () ->
ClosureUtils.whileClosure(null, ClosureUtils.nopClosure())),
+
Review comment:
Why are there extra blank lines between arguments? We don't do this for
other method calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737077)
Time Spent: 4h (was: 3h 50m)
> Fully migrate Commons Collection to JUnit 5
> ---
>
> Key: COLLECTIONS-777
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-777
> Project: Commons Collections
> Issue Type: Improvement
> Components: Core
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> The idea it's fully migrate Commons Collection to JUnit 5. This time i'll
> split the work in sub-task in order to avoid PR with to many files
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] garydgregory commented on a change in pull request #287: COLLECTIONS-777 JUnit v5
garydgregory commented on a change in pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#discussion_r820088257
##
File path: src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
##
@@ -138,18 +135,13 @@ public void testWhileClosure() {
ClosureUtils.whileClosure(PredicateUtils.uniquePredicate(),
cmd).execute(null);
assertEquals(1, cmd.count);
-try {
-ClosureUtils.whileClosure(null, ClosureUtils.nopClosure());
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(FalsePredicate.falsePredicate(), null);
-fail();
-} catch (final NullPointerException ex) {}
-try {
-ClosureUtils.whileClosure(null, null);
-fail();
-} catch (final NullPointerException ex) {}
+assertAll(
+() -> assertThrows(NullPointerException.class, () ->
ClosureUtils.whileClosure(null, ClosureUtils.nopClosure())),
+
Review comment:
Why are there extra blank lines between arguments? We don't do this for
other method calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[ https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737066 ] ASF GitHub Bot logged work on COLLECTIONS-777: -- Author: ASF GitHub Bot Created on: 05/Mar/22 10:41 Start Date: 05/Mar/22 10:41 Worklog Time Spent: 10m Work Description: nhojpatrick commented on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059740409 So locally it the last push got; ``` [INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ commons-collections4 --- [INFO] You have 0 Checkstyle violations. ``` So should be ready now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737066) Time Spent: 3h 50m (was: 3h 40m) > Fully migrate Commons Collection to JUnit 5 > --- > > Key: COLLECTIONS-777 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-777 > Project: Commons Collections > Issue Type: Improvement > Components: Core >Reporter: Arturo Bernal >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > The idea it's fully migrate Commons Collection to JUnit 5. This time i'll > split the work in sub-task in order to avoid PR with to many files -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[ https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737065 ] ASF GitHub Bot logged work on COLLECTIONS-777: -- Author: ASF GitHub Bot Created on: 05/Mar/22 10:41 Start Date: 05/Mar/22 10:41 Worklog Time Spent: 10m Work Description: codecov-commenter edited a comment on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059548290 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#287](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b401620) into [master](https://codecov.io/gh/apache/commons-collections/commit/f93c7d5976550881dfd5382e7bbda89d8c997f6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f93c7d5) will **decrease** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #287 +/- ## - Coverage 85.80% 85.75% -0.06% + Complexity 4674 4672 -2 Files 292 292 Lines 1347213472 Branches 1955 1955 - Hits 1156011553 -7 - Misses 1332 1336 +4 - Partials580 583 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/287/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `85.66% <0.00%> (-2.58%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f93c7d5...b401620](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 737065) Time Spent: 3h 40m (was: 3.5h) > Fully migrate Commons Collection to JUnit 5 > --- > > Key: COLLECTIONS-777 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-777 > Project: Commons Collections > Issue Type: Improvement > Components: Core >Reporter: Arturo Bernal >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > The idea
[GitHub] [commons-collections] nhojpatrick commented on pull request #287: COLLECTIONS-777 JUnit v5
nhojpatrick commented on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059740409 So locally it the last push got; ``` [INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ commons-collections4 --- [INFO] You have 0 Checkstyle violations. ``` So should be ready now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] codecov-commenter edited a comment on pull request #287: COLLECTIONS-777 JUnit v5
codecov-commenter edited a comment on pull request #287: URL: https://github.com/apache/commons-collections/pull/287#issuecomment-1059548290 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#287](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b401620) into [master](https://codecov.io/gh/apache/commons-collections/commit/f93c7d5976550881dfd5382e7bbda89d8c997f6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f93c7d5) will **decrease** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #287 +/- ## - Coverage 85.80% 85.75% -0.06% + Complexity 4674 4672 -2 Files 292 292 Lines 1347213472 Branches 1955 1955 - Hits 1156011553 -7 - Misses 1332 1336 +4 - Partials580 583 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/287/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `85.66% <0.00%> (-2.58%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f93c7d5...b401620](https://codecov.io/gh/apache/commons-collections/pull/287?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-777) Fully migrate Commons Collection to JUnit 5
[
https://issues.apache.org/jira/browse/COLLECTIONS-777?focusedWorklogId=737064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737064
]
ASF GitHub Bot logged work on COLLECTIONS-777:
--
Author: ASF GitHub Bot
Created on: 05/Mar/22 10:40
Start Date: 05/Mar/22 10:40
Worklog Time Spent: 10m
Work Description: nhojpatrick commented on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1059740311
So MapUtilsTest, show should it indent?
As this throws and indentation issue;
```
() -> assertThrows(IllegalArgumentException.class, () ->
MapUtils.putAll(new HashMap(), new String[][]{
{"RED", "#FF"},
null,
{"BLUE", "#FF"}
})),
```
But this doesn't;
```
() -> assertThrows(IllegalArgumentException.class, () ->
MapUtils.putAll(new HashMap(), new String[][]{
{"RED", "#FF"},
{"GREEN"},
{"BLUE", "#FF"}
})),
```
According to the rule I need to change it to;
```
() -> assertThrows(IllegalArgumentException.class, () ->
MapUtils.putAll(new HashMap(), new String[][]{
{"RED", "#FF"},
null,
{"BLUE", "#FF"}
})),
```
Which then looks weird and doesn't match the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737064)
Time Spent: 3.5h (was: 3h 20m)
> Fully migrate Commons Collection to JUnit 5
> ---
>
> Key: COLLECTIONS-777
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-777
> Project: Commons Collections
> Issue Type: Improvement
> Components: Core
>Reporter: Arturo Bernal
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> The idea it's fully migrate Commons Collection to JUnit 5. This time i'll
> split the work in sub-task in order to avoid PR with to many files
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] nhojpatrick commented on pull request #287: COLLECTIONS-777 JUnit v5
nhojpatrick commented on pull request #287:
URL:
https://github.com/apache/commons-collections/pull/287#issuecomment-1059740311
So MapUtilsTest, show should it indent?
As this throws and indentation issue;
```
() -> assertThrows(IllegalArgumentException.class, () ->
MapUtils.putAll(new HashMap(), new String[][]{
{"RED", "#FF"},
null,
{"BLUE", "#FF"}
})),
```
But this doesn't;
```
() -> assertThrows(IllegalArgumentException.class, () ->
MapUtils.putAll(new HashMap(), new String[][]{
{"RED", "#FF"},
{"GREEN"},
{"BLUE", "#FF"}
})),
```
According to the rule I need to change it to;
```
() -> assertThrows(IllegalArgumentException.class, () ->
MapUtils.putAll(new HashMap(), new String[][]{
{"RED", "#FF"},
null,
{"BLUE", "#FF"}
})),
```
Which then looks weird and doesn't match the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IMAGING-319) updateExifMetadataLossless lost the first character of a String
[
https://issues.apache.org/jira/browse/IMAGING-319?focusedWorklogId=737051=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737051
]
ASF GitHub Bot logged work on IMAGING-319:
--
Author: ASF GitHub Bot
Created on: 05/Mar/22 09:05
Start Date: 05/Mar/22 09:05
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #203:
URL: https://github.com/apache/commons-imaging/pull/203#issuecomment-1059725853
That was quite the detective work @gwlucastrig :clap: The change is really
small, but I couldn't understand just reading the code. Going to have to
re-read the JIRA and your description here :nerd_face: but it's looking good!
Thanks Gary!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 737051)
Time Spent: 0.5h (was: 20m)
> updateExifMetadataLossless lost the first character of a String
> ---
>
> Key: IMAGING-319
> URL: https://issues.apache.org/jira/browse/IMAGING-319
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
>Affects Versions: 1.0-alpha2
>Reporter: Sicheng Yang
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Attachments: Screen Shot 2021-11-26 at 4.01.06 PM-1.png, Screen Shot
> 2021-11-26 at 4.01.21 PM-1.png, iPhone12-geotag.JPG
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I try to use TiffOutputSet to generate a new image. However, if a tag that
> contains String, the program may miss the first character of the String.
>
> import java.io.*;
> import org.apache.commons.imaging.ImageReadException;
> import org.apache.commons.imaging.ImageWriteException;
> import org.apache.commons.imaging.Imaging;
> import org.apache.commons.imaging.common.ImageMetadata;
> import org.apache.commons.imaging.formats.jpeg.JpegImageMetadata;
> import org.apache.commons.imaging.formats.jpeg.exif.ExifRewriter;
> import org.apache.commons.imaging.formats.tiff.TiffImageMetadata;
> import org.apache.commons.imaging.formats.tiff.write.TiffOutputSet;
> public class LibraryTest {
> public static void main(String[] args) throws ImageReadException,
> IOException, ImageWriteException {
> File source = new File("./assets/iPhone12-geotag.JPG");
> File result = new
> File("./assets/results/editted-iPhone12-geotag.JPG");
> final ImageMetadata metadata = Imaging.getMetadata(source);
> final JpegImageMetadata jpegMetadata = (JpegImageMetadata) metadata;
> final TiffImageMetadata exif = jpegMetadata.getExif();
> TiffOutputSet outputSet = exif.getOutputSet();
> BufferedOutputStream bufferedOutputStream = new
> BufferedOutputStream(new FileOutputStream(result));
> new ExifRewriter().updateExifMetadataLossless(source,
> bufferedOutputStream, outputSet);
> }
> }
>
> This is the sample code.
> Tag value in original image
> !image-2021-11-26-16-01-58-645.png!
> Tag value in output image
> !image-2021-11-26-16-04-12-185.png!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-imaging] kinow commented on pull request #203: IMAGING-319: Correct length calculation in EXIF rewriter
kinow commented on pull request #203: URL: https://github.com/apache/commons-imaging/pull/203#issuecomment-1059725853 That was quite the detective work @gwlucastrig :clap: The change is really small, but I couldn't understand just reading the code. Going to have to re-read the JIRA and your description here :nerd_face: but it's looking good! Thanks Gary! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
