[jira] [Created] (JEXL-366) Fail to evaluate string and number comparison

2022-04-25 Thread Hussachai Puripunpinyo (Jira) 
Hussachai Puripunpinyo created JEXL-366:
---

 Summary: Fail to evaluate string and number comparison
 Key: JEXL-366
 URL: https://issues.apache.org/jira/browse/JEXL-366
 Project: Commons JEXL
  Issue Type: Bug
Reporter: Hussachai Puripunpinyo


The comparison logic doesn't cover the case when one operand is a string and 
another operand is a numerable type (int, short, long,..).

The expected result for '1.0' == 1 should be true but it fails because the 
string comparison check is after the numerable type check. JEXL tries to parse 
'1.0' using toLong function and it fails with this error message `For input 
string: "1.0"`

Moving a string comparison up before other number type checks will not cover 
some corner cases such as
'1.00' == 1.0 // String comparison will yield false but it obviously doesn't 
make sense.

The proposed change is to add the following code to handle the corner case when 
one operand is string and another operand is numerable. To cover this corner 
case, we can apply toBigDecimal to both *lhs* and *rhs* since it should cover 
any arbitrary number in a string form, and it handles other number types well.
{code:java}
if (isNumberable(left) || isNumberable(right)) {
if (left instanceof String || right instanceof String) {
final BigDecimal l = toBigDecimal(left);
final BigDecimal r = toBigDecimal(right);
return l.compareTo(r);
} else {
// this code block remains the same
}
return 0;
} {code}

JEXL syntax is very similar to ECMA script except a few small set that are not 
the same. So, I think following the ECMA spec for this comparison check makes 
sense.


The following code is JavaScript and it can be used in the JEXL test to make 
sure that the behavior of comparison are the same. 
Note that '1.0' == 1 yields true
{code:java}
function assert(condition, source) {
    if (!condition) {
        throw `Assertion failed for ${source}`;
    }
}
  // Basic compare
let exprs = [
  "1 == 1", true,
  "1 != 1", false,
  "1 != 2", true,
  "1 > 2", false,
  "1 >= 2", false,
  "1 < 2", true,
  "1 <= 2", true,
  // Int <-> Float Coercion
  "1.0 == 1", true,
  "1 == 1.0", true,
  "1.1 != 1", true,
  "1.1 < 2", true,
  // numbers and strings
  "'1' == 1", true,
  "'' == 0", true, // empty string is coerced to zero (ECMA compliance)
  "1.0 >= '1'", true,
  "1.0 > '1'", false
];for (e = 0; e < exprs.length; e += 2) {
  let stext = exprs[e];
  let expected = exprs[e + 1];
  assert(eval(stext) == expected, stext);
  
} {code}
 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (VFS-770) FileSystemManager.createFileSystem(FileObject) fails on Gzip files.

2022-04-25 Thread Bernd Eckenfels (Jira) 


[ 
https://issues.apache.org/jira/browse/VFS-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527834#comment-17527834
 ] 

Bernd Eckenfels commented on VFS-770:
-

BTW just FYI April 22 Update of Java 17 (and others) introduced new Mime types 
including the ones for `.gz` (`application/gzip`) and `.jar` 
(`application/java-archive`).

This bugfix helps with these new types in a way that it will consider the file 
extensions when the new types are not registered. It therefore would have 
prevented a regression for us.

Backports are here: https://bugs.openjdk.java.net/browse/JDK-8273655



> FileSystemManager.createFileSystem(FileObject) fails on Gzip files.
> ---
>
> Key: VFS-770
> URL: https://issues.apache.org/jira/browse/VFS-770
> Project: Commons VFS
>  Issue Type: Bug
>Affects Versions: 2.6.0
> Environment: Both Java 8 and Java 13
>Reporter: Thomas BELOT
>Priority: Major
> Fix For: 2.10.0
>
>
> Stack trace : 
> {noformat}
> Exception in thread "main" org.apache.commons.vfs2.FileSystemException: Could 
> not find a file provider that can handle file "file:///C:/DIR/00-test.gz".
>   at 
> org.apache.commons.vfs2.FileSystemException.requireNonNull(FileSystemException.java:87)
>   at 
> org.apache.commons.vfs2.impl.DefaultFileSystemManager.createFileSystem(DefaultFileSystemManager.java:909)
>   at MyClass.test(MyClass.java:77)
>   at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
>   at 
> java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
>   at one.util.streamex.AbstractStreamEx.forEach(AbstractStreamEx.java:314)
>   at MyClass.main(MyClass.java:45)
> {noformat}
> Caused by : 
> [fileNameMap.getContentTypeFor(name);|https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=blob;f=commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/FileContentInfoFilenameFactory.java;h=2888ff6545055c8d00cbd73412671d17560b2592;hb=HEAD#l42]
>  which delegates content type resolution to Java's 
> URLConnection.getFileNameMap() which in turn resolves GZip to a generic 
> application/octet-stream hence leading to this exception.
>  If the resolution had triggered a null or an application/x-gzip it would not 
> have lead to this problem.
> Forcing resolution with fsManager.createFileSystem("gz",f) is a workaround



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [commons-io] kinow merged pull request #351: chore: Set permissions for GitHub actions

2022-04-25 Thread GitBox 


kinow merged PR #351:
URL: https://github.com/apache/commons-io/pull/351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] kinow commented on pull request #351: chore: Set permissions for GitHub actions

2022-04-25 Thread GitBox 


kinow commented on PR #351:
URL: https://github.com/apache/commons-io/pull/351#issuecomment-1109208140

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] naveensrinivasan opened a new pull request, #351: chore: Set permissions for GitHub actions

2022-04-25 Thread GitBox 


naveensrinivasan opened a new pull request, #351:
URL: https://github.com/apache/commons-io/pull/351

Restrict the GitHub token permissions only to the required ones; this way, 
even if the attackers will succeed in compromising your workflow, they won’t be 
able to do much.
   
   - Included permissions for the action. 
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
   
   
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
   
   https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
   
   [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn 
requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)
   
   Signed-off-by: naveen <172697+naveensriniva...@users.noreply.github.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #53: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


dependabot[bot] opened a new pull request, #53:
URL: https://github.com/apache/commons-scxml/pull/53

   Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 
to 2.
   
   Changelog
   Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's
 changelog.
   
   2.1.8 - 08 Apr 2022
   
   Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014
   Fix error where the init action would fail due to a GitHub API request 
that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025
   
   2.1.7 - 05 Apr 2022
   
   A bug where additional queries specified in the workflow file would 
sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018
   
   2.1.6 - 30 Mar 2022
   
   [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000
   Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990
   Fix a bug where an invalid commit_oid was being sent to 
code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956
   
   
   
   
   Commits
   
   https://github.com/github/codeql-action/commit/2c03704a6c1a830d08e4d9bec16d5e11341fdfbd;>2c03704
 Allow the version of the ML-powered pack to depend on the CLI version
   https://github.com/github/codeql-action/commit/dd6b592e3e5e9cb8d577f77fcbac3e0a277834f4;>dd6b592
 Simplify ML-powered query status report definition
   https://github.com/github/codeql-action/commit/a90d8bf7113ff4d559a93e924657f47182b7ff14;>a90d8bf
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1011;>#1011
 from github/henrymercer/ml-powered-queries-pr-check
   https://github.com/github/codeql-action/commit/dc0338e4932696fa7e12853666bd55126f578ec7;>dc0338e
 Use latest major version of actions/upload-artifact
   https://github.com/github/codeql-action/commit/57096fe795dd4d80156b5aca370361a411c788ac;>57096fe
 Add a PR check to validate that ML-powered queries are run correctly
   https://github.com/github/codeql-action/commit/b0ddf36abe59aeef1e1161800244ed201a198092;>b0ddf36
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1012;>#1012
 from github/henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/1ea2f2d7f1d93eaf4eac2be602aac0c587fd74ec;>1ea2f2d
 Merge branch 'main' into henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/9dcc141f122e30f8d48b9927b17b081acd406b1d;>9dcc141
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1010;>#1010
 from github/henrymercer/stop-running-ml-powered-quer...
   https://github.com/github/codeql-action/commit/ea751a9fae12fc5267ceb93f51622421afc5e87b;>ea751a9
 Update other Actions from v2 to v3
   https://github.com/github/codeql-action/commit/a2949f47b3d667fc2d35d39f10089aa60cbd7071;>a2949f4
 Update actions/checkout from v2 to v3
   Additional commits viewable in https://github.com/github/codeql-action/compare/v1...v2;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action=github_actions=1=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR

[GitHub] [commons-io] garydgregory commented on pull request #350: Add FileWatcher feature

2022-04-25 Thread GitBox 


garydgregory commented on PR #350:
URL: https://github.com/apache/commons-io/pull/350#issuecomment-1109091990

   Hm, Commons VFS already does stuff like this, for example 
https://commons.apache.org/proper/commons-vfs/commons-vfs2/apidocs/org/apache/commons/vfs2/impl/DefaultFileMonitor.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-io] kinow commented on a diff in pull request #350: Add FileWatcher feature

2022-04-25 Thread GitBox 


kinow commented on code in PR #350:
URL: https://github.com/apache/commons-io/pull/350#discussion_r858042609


##
src/main/java/org/apache/commons/io/FileWatcher.java:
##
@@ -0,0 +1,90 @@
+package org.apache.commons.io;

Review Comment:
   Missing apache license is causing most builds to fail due to RAT test 
failure.



##
src/main/java/org/apache/commons/io/watcher/WatcherProperties.java:
##
@@ -0,0 +1,31 @@
+package org.apache.commons.io.watcher;

Review Comment:
   License header.



##
src/main/java/org/apache/commons/io/watcher/WatcherException.java:
##
@@ -0,0 +1,7 @@
+package org.apache.commons.io.watcher;

Review Comment:
   License header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-imaging] kinow merged pull request #216: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


kinow merged PR #216:
URL: https://github.com/apache/commons-imaging/pull/216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-email] dependabot[bot] opened a new pull request, #75: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


dependabot[bot] opened a new pull request, #75:
URL: https://github.com/apache/commons-email/pull/75

   Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 
to 2.
   
   Changelog
   Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's
 changelog.
   
   2.1.8 - 08 Apr 2022
   
   Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014
   Fix error where the init action would fail due to a GitHub API request 
that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025
   
   2.1.7 - 05 Apr 2022
   
   A bug where additional queries specified in the workflow file would 
sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018
   
   2.1.6 - 30 Mar 2022
   
   [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000
   Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990
   Fix a bug where an invalid commit_oid was being sent to 
code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956
   
   
   
   
   Commits
   
   https://github.com/github/codeql-action/commit/2c03704a6c1a830d08e4d9bec16d5e11341fdfbd;>2c03704
 Allow the version of the ML-powered pack to depend on the CLI version
   https://github.com/github/codeql-action/commit/dd6b592e3e5e9cb8d577f77fcbac3e0a277834f4;>dd6b592
 Simplify ML-powered query status report definition
   https://github.com/github/codeql-action/commit/a90d8bf7113ff4d559a93e924657f47182b7ff14;>a90d8bf
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1011;>#1011
 from github/henrymercer/ml-powered-queries-pr-check
   https://github.com/github/codeql-action/commit/dc0338e4932696fa7e12853666bd55126f578ec7;>dc0338e
 Use latest major version of actions/upload-artifact
   https://github.com/github/codeql-action/commit/57096fe795dd4d80156b5aca370361a411c788ac;>57096fe
 Add a PR check to validate that ML-powered queries are run correctly
   https://github.com/github/codeql-action/commit/b0ddf36abe59aeef1e1161800244ed201a198092;>b0ddf36
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1012;>#1012
 from github/henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/1ea2f2d7f1d93eaf4eac2be602aac0c587fd74ec;>1ea2f2d
 Merge branch 'main' into henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/9dcc141f122e30f8d48b9927b17b081acd406b1d;>9dcc141
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1010;>#1010
 from github/henrymercer/stop-running-ml-powered-quer...
   https://github.com/github/codeql-action/commit/ea751a9fae12fc5267ceb93f51622421afc5e87b;>ea751a9
 Update other Actions from v2 to v3
   https://github.com/github/codeql-action/commit/a2949f47b3d667fc2d35d39f10089aa60cbd7071;>a2949f4
 Update actions/checkout from v2 to v3
   Additional commits viewable in https://github.com/github/codeql-action/compare/v1...v2;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action=github_actions=1=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR

[GitHub] [commons-io] Marcono1234 commented on pull request #293: Refactor `ReaderInputStream` implementation

2022-04-25 Thread GitBox 


Marcono1234 commented on PR #293:
URL: https://github.com/apache/commons-io/pull/293#issuecomment-1108955380

   Regardless of what will happen with this pull request, should I report the 
two issues mentioned above on Jira?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-ognl] dependabot[bot] opened a new pull request, #72: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


dependabot[bot] opened a new pull request, #72:
URL: https://github.com/apache/commons-ognl/pull/72

   Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 
to 2.
   
   Changelog
   Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's
 changelog.
   
   2.1.8 - 08 Apr 2022
   
   Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014
   Fix error where the init action would fail due to a GitHub API request 
that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025
   
   2.1.7 - 05 Apr 2022
   
   A bug where additional queries specified in the workflow file would 
sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018
   
   2.1.6 - 30 Mar 2022
   
   [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000
   Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990
   Fix a bug where an invalid commit_oid was being sent to 
code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956
   
   
   
   
   Commits
   
   https://github.com/github/codeql-action/commit/2c03704a6c1a830d08e4d9bec16d5e11341fdfbd;>2c03704
 Allow the version of the ML-powered pack to depend on the CLI version
   https://github.com/github/codeql-action/commit/dd6b592e3e5e9cb8d577f77fcbac3e0a277834f4;>dd6b592
 Simplify ML-powered query status report definition
   https://github.com/github/codeql-action/commit/a90d8bf7113ff4d559a93e924657f47182b7ff14;>a90d8bf
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1011;>#1011
 from github/henrymercer/ml-powered-queries-pr-check
   https://github.com/github/codeql-action/commit/dc0338e4932696fa7e12853666bd55126f578ec7;>dc0338e
 Use latest major version of actions/upload-artifact
   https://github.com/github/codeql-action/commit/57096fe795dd4d80156b5aca370361a411c788ac;>57096fe
 Add a PR check to validate that ML-powered queries are run correctly
   https://github.com/github/codeql-action/commit/b0ddf36abe59aeef1e1161800244ed201a198092;>b0ddf36
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1012;>#1012
 from github/henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/1ea2f2d7f1d93eaf4eac2be602aac0c587fd74ec;>1ea2f2d
 Merge branch 'main' into henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/9dcc141f122e30f8d48b9927b17b081acd406b1d;>9dcc141
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1010;>#1010
 from github/henrymercer/stop-running-ml-powered-quer...
   https://github.com/github/codeql-action/commit/ea751a9fae12fc5267ceb93f51622421afc5e87b;>ea751a9
 Update other Actions from v2 to v3
   https://github.com/github/codeql-action/commit/a2949f47b3d667fc2d35d39f10089aa60cbd7071;>a2949f4
 Update actions/checkout from v2 to v3
   Additional commits viewable in https://github.com/github/codeql-action/compare/v1...v2;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action=github_actions=1=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or

[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request, #144: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


dependabot[bot] opened a new pull request, #144:
URL: https://github.com/apache/commons-fileupload/pull/144

   Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 
to 2.
   
   Changelog
   Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's
 changelog.
   
   2.1.8 - 08 Apr 2022
   
   Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014
   Fix error where the init action would fail due to a GitHub API request 
that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025
   
   2.1.7 - 05 Apr 2022
   
   A bug where additional queries specified in the workflow file would 
sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018
   
   2.1.6 - 30 Mar 2022
   
   [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000
   Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990
   Fix a bug where an invalid commit_oid was being sent to 
code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956
   
   
   
   
   Commits
   
   https://github.com/github/codeql-action/commit/2c03704a6c1a830d08e4d9bec16d5e11341fdfbd;>2c03704
 Allow the version of the ML-powered pack to depend on the CLI version
   https://github.com/github/codeql-action/commit/dd6b592e3e5e9cb8d577f77fcbac3e0a277834f4;>dd6b592
 Simplify ML-powered query status report definition
   https://github.com/github/codeql-action/commit/a90d8bf7113ff4d559a93e924657f47182b7ff14;>a90d8bf
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1011;>#1011
 from github/henrymercer/ml-powered-queries-pr-check
   https://github.com/github/codeql-action/commit/dc0338e4932696fa7e12853666bd55126f578ec7;>dc0338e
 Use latest major version of actions/upload-artifact
   https://github.com/github/codeql-action/commit/57096fe795dd4d80156b5aca370361a411c788ac;>57096fe
 Add a PR check to validate that ML-powered queries are run correctly
   https://github.com/github/codeql-action/commit/b0ddf36abe59aeef1e1161800244ed201a198092;>b0ddf36
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1012;>#1012
 from github/henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/1ea2f2d7f1d93eaf4eac2be602aac0c587fd74ec;>1ea2f2d
 Merge branch 'main' into henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/9dcc141f122e30f8d48b9927b17b081acd406b1d;>9dcc141
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1010;>#1010
 from github/henrymercer/stop-running-ml-powered-quer...
   https://github.com/github/codeql-action/commit/ea751a9fae12fc5267ceb93f51622421afc5e87b;>ea751a9
 Update other Actions from v2 to v3
   https://github.com/github/codeql-action/commit/a2949f47b3d667fc2d35d39f10089aa60cbd7071;>a2949f4
 Update actions/checkout from v2 to v3
   Additional commits viewable in https://github.com/github/codeql-action/compare/v1...v2;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action=github_actions=1=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen

[GitHub] [commons-io] saiple opened a new pull request, #350: Add FileWatcher feature

2022-04-25 Thread GitBox 


saiple opened a new pull request, #350:
URL: https://github.com/apache/commons-io/pull/350

   Hello everyone.
   I want to suggest to add some features to creating file system watchers very 
easy.
   
   You only need to write one line a code:
   FileWatcher.createWatcher(path, watchEvent -> 
System.out.println(watchEvent.kind().name() + " " + watchEvent.context()));
   Put here path, which should be watched, watch properties (optional), and 
supplier, if this event would triggered.
   
   Be free to review and comment. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-exec] dependabot[bot] opened a new pull request, #52: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


dependabot[bot] opened a new pull request, #52:
URL: https://github.com/apache/commons-exec/pull/52

   Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 
to 2.
   
   Changelog
   Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's
 changelog.
   
   2.1.8 - 08 Apr 2022
   
   Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014
   Fix error where the init action would fail due to a GitHub API request 
that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025
   
   2.1.7 - 05 Apr 2022
   
   A bug where additional queries specified in the workflow file would 
sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018
   
   2.1.6 - 30 Mar 2022
   
   [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000
   Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990
   Fix a bug where an invalid commit_oid was being sent to 
code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956
   
   
   
   
   Commits
   
   https://github.com/github/codeql-action/commit/2c03704a6c1a830d08e4d9bec16d5e11341fdfbd;>2c03704
 Allow the version of the ML-powered pack to depend on the CLI version
   https://github.com/github/codeql-action/commit/dd6b592e3e5e9cb8d577f77fcbac3e0a277834f4;>dd6b592
 Simplify ML-powered query status report definition
   https://github.com/github/codeql-action/commit/a90d8bf7113ff4d559a93e924657f47182b7ff14;>a90d8bf
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1011;>#1011
 from github/henrymercer/ml-powered-queries-pr-check
   https://github.com/github/codeql-action/commit/dc0338e4932696fa7e12853666bd55126f578ec7;>dc0338e
 Use latest major version of actions/upload-artifact
   https://github.com/github/codeql-action/commit/57096fe795dd4d80156b5aca370361a411c788ac;>57096fe
 Add a PR check to validate that ML-powered queries are run correctly
   https://github.com/github/codeql-action/commit/b0ddf36abe59aeef1e1161800244ed201a198092;>b0ddf36
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1012;>#1012
 from github/henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/1ea2f2d7f1d93eaf4eac2be602aac0c587fd74ec;>1ea2f2d
 Merge branch 'main' into henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/9dcc141f122e30f8d48b9927b17b081acd406b1d;>9dcc141
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1010;>#1010
 from github/henrymercer/stop-running-ml-powered-quer...
   https://github.com/github/codeql-action/commit/ea751a9fae12fc5267ceb93f51622421afc5e87b;>ea751a9
 Update other Actions from v2 to v3
   https://github.com/github/codeql-action/commit/a2949f47b3d667fc2d35d39f10089aa60cbd7071;>a2949f4
 Update actions/checkout from v2 to v3
   Additional commits viewable in https://github.com/github/codeql-action/compare/v1...v2;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action=github_actions=1=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or

[GitHub] [commons-imaging] dependabot[bot] opened a new pull request, #216: Bump github/codeql-action from 1 to 2

2022-04-25 Thread GitBox 


dependabot[bot] opened a new pull request, #216:
URL: https://github.com/apache/commons-imaging/pull/216

   Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 
to 2.
   
   Changelog
   Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's
 changelog.
   
   2.1.8 - 08 Apr 2022
   
   Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014
   Fix error where the init action would fail due to a GitHub API request 
that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025
   
   2.1.7 - 05 Apr 2022
   
   A bug where additional queries specified in the workflow file would 
sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018
   
   2.1.6 - 30 Mar 2022
   
   [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000
   Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990
   Fix a bug where an invalid commit_oid was being sent to 
code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956
   
   
   
   
   Commits
   
   https://github.com/github/codeql-action/commit/2c03704a6c1a830d08e4d9bec16d5e11341fdfbd;>2c03704
 Allow the version of the ML-powered pack to depend on the CLI version
   https://github.com/github/codeql-action/commit/dd6b592e3e5e9cb8d577f77fcbac3e0a277834f4;>dd6b592
 Simplify ML-powered query status report definition
   https://github.com/github/codeql-action/commit/a90d8bf7113ff4d559a93e924657f47182b7ff14;>a90d8bf
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1011;>#1011
 from github/henrymercer/ml-powered-queries-pr-check
   https://github.com/github/codeql-action/commit/dc0338e4932696fa7e12853666bd55126f578ec7;>dc0338e
 Use latest major version of actions/upload-artifact
   https://github.com/github/codeql-action/commit/57096fe795dd4d80156b5aca370361a411c788ac;>57096fe
 Add a PR check to validate that ML-powered queries are run correctly
   https://github.com/github/codeql-action/commit/b0ddf36abe59aeef1e1161800244ed201a198092;>b0ddf36
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1012;>#1012
 from github/henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/1ea2f2d7f1d93eaf4eac2be602aac0c587fd74ec;>1ea2f2d
 Merge branch 'main' into henrymercer/update-actions-major-versions
   https://github.com/github/codeql-action/commit/9dcc141f122e30f8d48b9927b17b081acd406b1d;>9dcc141
 Merge pull request https://github-redirect.dependabot.com/github/codeql-action/issues/1010;>#1010
 from github/henrymercer/stop-running-ml-powered-quer...
   https://github.com/github/codeql-action/commit/ea751a9fae12fc5267ceb93f51622421afc5e87b;>ea751a9
 Update other Actions from v2 to v3
   https://github.com/github/codeql-action/commit/a2949f47b3d667fc2d35d39f10089aa60cbd7071;>a2949f4
 Update actions/checkout from v2 to v3
   Additional commits viewable in https://github.com/github/codeql-action/compare/v1...v2;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action=github_actions=1=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the

[jira] [Resolved] (JEXL-360) Add missing bitshift operators ( >>, >>>, <<)

2022-04-25 Thread Henri Biestro (Jira) 


 [ 
https://issues.apache.org/jira/browse/JEXL-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henri Biestro resolved JEXL-360.

Resolution: Fixed

Commit 
[9230334|https://github.com/apache/commons-jexl/commit/9230334a33714bd5a62e4df5e297ad74aa556be6]

> Add missing bitshift operators ( >>, >>>, <<)
> -
>
> Key: JEXL-360
> URL: https://issues.apache.org/jira/browse/JEXL-360
> Project: Commons JEXL
>  Issue Type: Improvement
>Affects Versions: 3.2.1
>Reporter: Ian Hawkins
>Assignee: Henri Biestro
>Priority: Minor
>  Labels: newbie
> Fix For: 3.3
>
>
> Hi!
> Jexl appears to be missing the >>  <<  >>>  <<< bit shift operators - it 
> would be really useful to have them so we can do things like (b >> 
> bitnumber), etc.
> Thanks!
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (JEXL-360) Add missing bitshift operators ( >>, >>>, <<)

2022-04-25 Thread Henri Biestro (Jira) 


 [ 
https://issues.apache.org/jira/browse/JEXL-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henri Biestro updated JEXL-360:
---
Fix Version/s: 3.3

> Add missing bitshift operators ( >>, >>>, <<)
> -
>
> Key: JEXL-360
> URL: https://issues.apache.org/jira/browse/JEXL-360
> Project: Commons JEXL
>  Issue Type: Improvement
>Affects Versions: 3.2.1
>Reporter: Ian Hawkins
>Assignee: Henri Biestro
>Priority: Minor
>  Labels: newbie
> Fix For: 3.3
>
>
> Hi!
> Jexl appears to be missing the >>  <<  >>>  <<< bit shift operators - it 
> would be really useful to have them so we can do things like (b >> 
> bitnumber), etc.
> Thanks!
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Updated] (JEXL-360) Add missing bitshift operators ( >>, >>>, <<)

2022-04-25 Thread Henri Biestro (Jira) 


 [ 
https://issues.apache.org/jira/browse/JEXL-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henri Biestro updated JEXL-360:
---
Assignee: Henri Biestro

> Add missing bitshift operators ( >>, >>>, <<)
> -
>
> Key: JEXL-360
> URL: https://issues.apache.org/jira/browse/JEXL-360
> Project: Commons JEXL
>  Issue Type: Improvement
>Affects Versions: 3.2.1
>Reporter: Ian Hawkins
>Assignee: Henri Biestro
>Priority: Minor
>  Labels: newbie
>
> Hi!
> Jexl appears to be missing the >>  <<  >>>  <<< bit shift operators - it 
> would be really useful to have them so we can do things like (b >> 
> bitnumber), etc.
> Thanks!
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[GitHub] [commons-jexl] henrib merged pull request #91: JEXL-360

2022-04-25 Thread GitBox 


henrib merged PR #91:
URL: https://github.com/apache/commons-jexl/pull/91


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-beanutils] garydgregory commented on pull request #47: Add Converters for Additional Types

2022-04-25 Thread GitBox 


garydgregory commented on PR #47:
URL: https://github.com/apache/commons-beanutils/pull/47#issuecomment-1108474764

   I'm sure it's fine for now (13 files).
   
   Gary
   
   On Mon, Apr 25, 2022, 07:28 Seth Falco ***@***.***> wrote:
   
   > @garydgregory  If this PR it too large
   > to review at once, would you prefer if I split it up into smaller ones?
   >
   > I could do one PR per converter for example?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-beanutils] SethFalco commented on pull request #47: Add Converters for Additional Types

2022-04-25 Thread GitBox 


SethFalco commented on PR #47:
URL: https://github.com/apache/commons-beanutils/pull/47#issuecomment-1108449860

   @garydgregory If this PR it too large to review at once, would you prefer if 
I split it up into smaller ones?
   
   I could do one PR per converter for example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-beanutils] SethFalco commented on pull request #92: Fix warnings and To-Dos

2022-04-25 Thread GitBox 


SethFalco commented on PR #92:
URL: https://github.com/apache/commons-beanutils/pull/92#issuecomment-1108441461

   Just rebased with master, hoping this should be cool now.
   Seems I forgot to re-request review after resolving the comments, sorry 
about that. ^-^'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-jexl] henrib opened a new pull request, #91: JEXL-360

2022-04-25 Thread GitBox 


henrib opened a new pull request, #91:
URL: https://github.com/apache/commons-jexl/pull/91

   Failed previous PR merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [commons-jexl] henrib merged pull request #89: JEXL-360

2022-04-25 Thread GitBox 


henrib merged PR #89:
URL: https://github.com/apache/commons-jexl/pull/89


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (COLLECTIONS-811) Consider integration Guava testlib tests

2022-04-25 Thread Gary D. Gregory (Jira) 


[ 
https://issues.apache.org/jira/browse/COLLECTIONS-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527354#comment-17527354
 ] 

Gary D. Gregory commented on COLLECTIONS-811:
-

Reuse sounds reasonable to me.

> Consider integration Guava testlib tests
> 
>
> Key: COLLECTIONS-811
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-811
> Project: Commons Collections
>  Issue Type: Test
>Reporter: Bruno P. Kinoshita
>Priority: Minor
>
> In COLLECTIONS-802 an issue reported was found with the help of Google Guava 
> testlib tests.
> Maybe we could either have something similar (i.e. build ourselves?), use 
> Google Guava's testlib, or find another similar solution. From what I 
> understood, it uses a factory function to create an implementation of a 
> collection interface (e.g. Map) and then runs a series of functional tests 
> over the created object, failing tests if a contract is broken (e.g. 
> iterating a map doesn't leave the next-object as null, as it was the case of 
> the 802 issue).



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-04-25 Thread Gilles Sadowski (Jira) 


[ 
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527327#comment-17527327
 ] 

Gilles Sadowski commented on GEOMETRY-144:
--

+1

{code}
package org.apache.commons.geometry.euclidean.twod;

public class ConvexHull2D {
// ...

private ConvexHull2D(/* ... */) {
// ...
}

// Factory.
public static ConvexHull2D of(/* ... */) {
// ...
}

// ...
}
{code}


> Review API in "hull" module
> ---
>
> Key: GEOMETRY-144
> URL: https://issues.apache.org/jira/browse/GEOMETRY-144
> Project: Commons Geometry
>  Issue Type: Task
>Reporter: Gilles Sadowski
>Assignee: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
>
> Review codes in the 
> [{{commons-geometry-hull}}|https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=tree;f=commons-geometry-hull;hb=HEAD]
>  module.
> (x) Minimize the public API



--
This message was sent by Atlassian Jira
(v8.20.7#820007)