[GitHub] [commons-text] kinow merged pull request #323: Bump commons.pmd-impl.version from 6.44.0 to 6.45.0
kinow merged PR #323: URL: https://github.com/apache/commons-text/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IMAGING-313) Provide summary of GeoTIFF tags in example TIFF-dump application
[ https://issues.apache.org/jira/browse/IMAGING-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved IMAGING-313. Assignee: Bruno P. Kinoshita Resolution: Duplicate According to [~gwlucas] it was done as part of IMAGING-314. > Provide summary of GeoTIFF tags in example TIFF-dump application > > > Key: IMAGING-313 > URL: https://issues.apache.org/jira/browse/IMAGING-313 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha3 >Reporter: Gary Lucas >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 1.0-alpha3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (IMAGING-313) Provide summary of GeoTIFF tags in example TIFF-dump application
[ https://issues.apache.org/jira/browse/IMAGING-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated IMAGING-313: --- Fix Version/s: 1.0-alpha3 > Provide summary of GeoTIFF tags in example TIFF-dump application > > > Key: IMAGING-313 > URL: https://issues.apache.org/jira/browse/IMAGING-313 > Project: Commons Imaging > Issue Type: New Feature > Components: Format: TIFF >Affects Versions: 1.0-alpha3 >Reporter: Gary Lucas >Priority: Minor > Fix For: 1.0-alpha3 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [commons-text] dependabot[bot] opened a new pull request, #323: Bump commons.pmd-impl.version from 6.44.0 to 6.45.0
dependabot[bot] opened a new pull request, #323: URL: https://github.com/apache/commons-text/pull/323 Bumps `commons.pmd-impl.version` from 6.44.0 to 6.45.0. Updates `pmd-core` from 6.44.0 to 6.45.0 Release notes Sourced from https://github.com/pmd/pmd/releases";>pmd-core's releases. PMD 6.45.0 (30-April-2022) 30-April-2022 - 6.45.0 The PMD team is pleased to announce PMD 6.45.0. This is a minor release. Table Of Contents https://github.com/pmd/pmd/blob/HEAD/#new-and-noteworthy";>New and noteworthy https://github.com/pmd/pmd/blob/HEAD/#pmd-user-survey";>PMD User Survey https://github.com/pmd/pmd/blob/HEAD/#support-for-html";>Support for HTML https://github.com/pmd/pmd/blob/HEAD/#new-rules";>New rules https://github.com/pmd/pmd/blob/HEAD/#modified-rules";>Modified rules https://github.com/pmd/pmd/blob/HEAD/#fixed-issues";>Fixed Issues https://github.com/pmd/pmd/blob/HEAD/#api-changes";>API Changes https://github.com/pmd/pmd/blob/HEAD/#experimental-apis";>Experimental APIs https://github.com/pmd/pmd/blob/HEAD/#external-contributions";>External Contributions https://github.com/pmd/pmd/blob/HEAD/#stats";>Stats New and noteworthy PMD User Survey Help shape the future of PMD by telling us how you use it. Our little survey is still open in case you didn't participate yet. Please participate in our survey at https://forms.gle/4d8r1a1RDzfixHDc7";>https://forms.gle/4d8r1a1RDzfixHDc7. Thank you! Support for HTML This version of PMD ships a new language module to support analyzing of HTML. Support for HTML is experimental and might change without notice. The language implementation is not complete yet and the AST doesn't look well for text nodes and comment nodes and might be changed in the future. You can write your own rules, but we don't guarantee that the rules work with the next (minor) version of PMD without adjustments. Please give us feedback about how practical this new language is in https://github.com/pmd/pmd/discussions";>discussions. Please report missing features or bugs as new https://github.com/pmd/pmd/issues";>issues. New rules The HTML rule https://pmd.github.io/pmd-6.45.0/pmd_rules_html_bestpractices.html#avoidinlinestyles";>AvoidInlineStyles finds elements which use a style attribute. In order to help maintaining a webpage it is considered good practice to separate content and styles. Instead of inline styles one should use CSS files and classes. ... (truncated) Commits https://github.com/pmd/pmd/commit/1d2b40b3c0ad670c886a2e5c8ce62df467be3184";>1d2b40b [maven-release-plugin] prepare release pmd_releases/6.45.0 https://github.com/pmd/pmd/commit/2212ff1fca16dd5e9d49d2d21fe9b7ecb0950b6f";>2212ff1 Prepare pmd release 6.45.0 https://github.com/pmd/pmd/commit/e4577c47ea9e71044aea6c773584fcdb98ef281a";>e4577c4 [doc] Add user survey to release notes (https://github-redirect.dependabot.com/pmd/pmd/issues/3814";>#3814) https://github.com/pmd/pmd/commit/915b7f8b619d4992c3dc7ea166db73b79c83f9ae";>915b7f8 Merge pull request https://github-redirect.dependabot.com/pmd/pmd/issues/3939";>#3939 from adangel:improved-rule-test-support https://github.com/pmd/pmd/commit/efcc58308604a8210677f11c6dd5ae816fb458dc";>efcc583 [test] Improve test method name, display test method https://github.com/pmd/pmd/commit/094bb1310ae011e484ad7c61dc1c66b0320c8f0d";>094bb13 Update gems https://github.com/pmd/pmd/commit/4eb2471939d49fe325fb2af1f60bf8b7b31c733d";>4eb2471 Update gems https://github.com/pmd/pmd/commit/e110a8447381a003e81b4212ddbf0e721b5bcb2e";>e110a84 Merge pull request https://github-redirect.dependabot.com/pmd/pmd/issues/3943";>#3943 from turrisxyz:setup-permissions https://github.com/pmd/pmd/commit/47beb1c3cdcb8af1a0334c1c16bf589e760a3077";>47beb1c Add https://github.com/naveensrinivasan";>@naveensrinivasan as a contributor https://github.com/pmd/pmd/commit/94057f688d041ad140604bb1fb1249bad54adb31";>94057f6 [doc] Update release notes (https://github-redirect.dependabot.com/pmd/pmd/issues/3943";>#3943) Additional commits viewable in https://github.com/pmd/pmd/compare/pmd_releases/6.44.0...pmd_releases/6.45.0";>compare view Updates `pmd-java` from 6.44.0 to 6.45.0 Release notes Sourced from https://github.com/pmd/pmd/releases";>pmd-java's releases. PMD 6.45.0 (30-April-2022) 30-April-2022 - 6.45.0 The PMD team is pleased to announce PMD 6.45.0. This is a minor release. Table Of Contents https://github.com/pmd/pmd/blob/HEAD/#new-and-noteworthy";>New and noteworthy https://github.com/pmd/pmd/blob/HEAD/#pmd-user-survey";>PMD User Survey https://github.com/pmd/pmd/blob/HEAD/#support-for-html";>Support for HTML https://github.com/pmd/pmd/blob/HEAD/#new-rules";>New rules https://github.com/pmd/pmd/blob/
[GitHub] [commons-lang] garydgregory commented on pull request #893: Bump checkstyle from 9.3 to 10.2
garydgregory commented on PR #893: URL: https://github.com/apache/commons-lang/pull/893#issuecomment-1126392377 Closing, requires Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #180: Bump checkstyle from 9.3 to 10.2
garydgregory commented on PR #180: URL: https://github.com/apache/commons-configuration/pull/180#issuecomment-1126350373 Closing, requires Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JEXL-369) Add 'let' and 'const' variable declarations
[
https://issues.apache.org/jira/browse/JEXL-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536787#comment-17536787
]
Dmitri Blinov commented on JEXL-369:
I'm also sceptical about the following test case (and similar...)
{code:java}
@Test
public void testForVariable0a() {
final JexlEngine jexl = new JexlBuilder().strict(true).create();
try {
final JexlScript script = jexl.createScript("for(let x : 1..3) {
let c = 0}; return x");
Assert.fail("Should not have been parsed");
} catch (final JexlException ex) {
// OK
}
}
{code}
I would have expect the code to fail only if lexical shade mode is explicitly
enabled, like this
{code:java}
@Test
public void testForVariable0a() {
final JexlFeatures f = new JexlFeatures();
f.lexicalShade(true);
final JexlEngine jexl = new
JexlBuilder().strict(true).features(f).create();
try {
final JexlScript script = jexl.createScript("for(let x : 1..3) {
let c = 0}; return x");
Assert.fail("Should not have been parsed");
} catch (final JexlException ex) {
// OK
}
} {code}
The lexical shade mode is not what everyone may wish to enforce
> Add 'let' and 'const' variable declarations
> ---
>
> Key: JEXL-369
> URL: https://issues.apache.org/jira/browse/JEXL-369
> Project: Commons JEXL
> Issue Type: Improvement
>Affects Versions: 3.2.1
>Reporter: Henri Biestro
>Assignee: Henri Biestro
>Priority: Major
> Fix For: 3.3
>
>
> WHAT:
> Add creation of lexical scope variables, modifiable with 'let',
> non-modifiable through 'const'.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-rng] lgtm-com[bot] commented on pull request #111: RNG-176: Enhance the UniformRandomProvider interface
lgtm-com[bot] commented on PR #111: URL: https://github.com/apache/commons-rng/pull/111#issuecomment-1126232986 This pull request **introduces 1 alert** when merging f3df9db1005142c24cb96ea0b9807282166d3718 into c285f7d222e7fee7da9e67d29e00c3d73d296a3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/commons-rng/rev/pr-a44c3483670e639c221d8efab12bdc23887015ba) **new alerts:** * 1 for Dereferenced variable may be null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] opened a new pull request, #180: Bump checkstyle from 9.3 to 10.2
dependabot[bot] opened a new pull request, #180: URL: https://github.com/apache/commons-configuration/pull/180 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.2. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-10.2 https://checkstyle.org/releasenotes.html#Release_10.2";>https://checkstyle.org/releasenotes.html#Release_10.2 checkstyle-10.1 https://checkstyle.org/releasenotes.html#Release_10.1";>https://checkstyle.org/releasenotes.html#Release_10.1 checkstyle-10.0 https://checkstyle.org/releasenotes.html#Release_10.0";>https://checkstyle.org/releasenotes.html#Release_10.0 Commits https://github.com/checkstyle/checkstyle/commit/0678fc609ec1889e3534940aa9d094887a4af2f3";>0678fc6 [maven-release-plugin] prepare release checkstyle-10.2 https://github.com/checkstyle/checkstyle/commit/acf70b4d7e8e4423579f02bf88d9773ba9574a77";>acf70b4 doc: release notes for 10.2 https://github.com/checkstyle/checkstyle/commit/591b41028cecc786ea94556791a8e53a99defb4c";>591b410 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/4845";>#4845: remove dependency on netbuddy from test inputs https://github.com/checkstyle/checkstyle/commit/0fda5157d34980c229090931af2a1a1ce74e87a9";>0fda515 dependency: bump maven-antrun-plugin from 3.0.0 to 3.1.0 https://github.com/checkstyle/checkstyle/commit/7f5fcc814f63a590d24b34a3e6289facfbffc264";>7f5fcc8 supplemental: Modify pitest.sh to support unstable mutations list https://github.com/checkstyle/checkstyle/commit/0ab05c948d302dde4f3e4144e97af30a2613900a";>0ab05c9 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11528";>#11528: Kill surviving mutation in EqualsAvoidNullCheck https://github.com/checkstyle/checkstyle/commit/c2abb6fb4cef7c4d3e565bd05d061841fc86db50";>c2abb6f minor: fix link (link-check-plugin) https://github.com/checkstyle/checkstyle/commit/4a7e6fa6b7eeb0658d09c64bc9f390f24c3ab10b";>4a7e6fa dependency: bump nexus-staging-maven-plugin from 1.6.12 to 1.6.13 https://github.com/checkstyle/checkstyle/commit/8035e76a5ba81f4841519d0d3ceb9e7a4f913506";>8035e76 dependency: bump mockito-inline from 4.5.0 to 4.5.1 https://github.com/checkstyle/checkstyle/commit/d00939d8400537a7eecc56e7ec1fdaf3f0574333";>d00939d dependency: bump maven-site-plugin from 3.11.0 to 3.12.0 Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rng] lgtm-com[bot] commented on pull request #111: RNG-176: Enhance the UniformRandomProvider interface
lgtm-com[bot] commented on PR #111: URL: https://github.com/apache/commons-rng/pull/111#issuecomment-1126186494 This pull request **introduces 1 alert** when merging 9c264dde637936775cb0cdc787719c14a6ad4623 into c285f7d222e7fee7da9e67d29e00c3d73d296a3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/commons-rng/rev/pr-49dd5ae2da7dd17afce81c7cd7257c991670117d) **new alerts:** * 1 for Dereferenced variable may be null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] opened a new pull request, #893: Bump checkstyle from 9.3 to 10.2
dependabot[bot] opened a new pull request, #893: URL: https://github.com/apache/commons-lang/pull/893 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.2. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-10.2 https://checkstyle.org/releasenotes.html#Release_10.2";>https://checkstyle.org/releasenotes.html#Release_10.2 checkstyle-10.1 https://checkstyle.org/releasenotes.html#Release_10.1";>https://checkstyle.org/releasenotes.html#Release_10.1 checkstyle-10.0 https://checkstyle.org/releasenotes.html#Release_10.0";>https://checkstyle.org/releasenotes.html#Release_10.0 Commits https://github.com/checkstyle/checkstyle/commit/0678fc609ec1889e3534940aa9d094887a4af2f3";>0678fc6 [maven-release-plugin] prepare release checkstyle-10.2 https://github.com/checkstyle/checkstyle/commit/acf70b4d7e8e4423579f02bf88d9773ba9574a77";>acf70b4 doc: release notes for 10.2 https://github.com/checkstyle/checkstyle/commit/591b41028cecc786ea94556791a8e53a99defb4c";>591b410 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/4845";>#4845: remove dependency on netbuddy from test inputs https://github.com/checkstyle/checkstyle/commit/0fda5157d34980c229090931af2a1a1ce74e87a9";>0fda515 dependency: bump maven-antrun-plugin from 3.0.0 to 3.1.0 https://github.com/checkstyle/checkstyle/commit/7f5fcc814f63a590d24b34a3e6289facfbffc264";>7f5fcc8 supplemental: Modify pitest.sh to support unstable mutations list https://github.com/checkstyle/checkstyle/commit/0ab05c948d302dde4f3e4144e97af30a2613900a";>0ab05c9 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11528";>#11528: Kill surviving mutation in EqualsAvoidNullCheck https://github.com/checkstyle/checkstyle/commit/c2abb6fb4cef7c4d3e565bd05d061841fc86db50";>c2abb6f minor: fix link (link-check-plugin) https://github.com/checkstyle/checkstyle/commit/4a7e6fa6b7eeb0658d09c64bc9f390f24c3ab10b";>4a7e6fa dependency: bump nexus-staging-maven-plugin from 1.6.12 to 1.6.13 https://github.com/checkstyle/checkstyle/commit/8035e76a5ba81f4841519d0d3ceb9e7a4f913506";>8035e76 dependency: bump mockito-inline from 4.5.0 to 4.5.1 https://github.com/checkstyle/checkstyle/commit/d00939d8400537a7eecc56e7ec1fdaf3f0574333";>d00939d dependency: bump maven-site-plugin from 3.11.0 to 3.12.0 Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RNG-176) Enhance the UniformRandomProvider interface with extra methods and default implementations
[
https://issues.apache.org/jira/browse/RNG-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536692#comment-17536692
]
Alex Herbert commented on RNG-176:
--
{quote}Please make a prominent note in the sources that those codes are
redundant (and should be removed at the next opportunity).
{quote}
I started doing this but the justification of linkage errors seems weak. I
think we can drop the redundant methods.
A user should only have to include the client-api, simple and/or sampling
modules. The sampling module only depends on the client-api. It can function
with client-api version 1.0. Here a linkage error will not occur if they create
their instance of an RNG without using the simple module.
The simple module must be matched in version to the core module, otherwise the
latest generators for the version of simple cannot be created. This is if an
incremental release has added samplers. This is the case for 1.4 to 1.5. Errors
will depend on what the calling code is doing. If using an existing enum then
there should be no issue as 1.5 should be able to create a functioning RNG for
any generator in 1.4. If listing all enums using RandomSource.values() then
some instances will throw a class not found error if the core version does not
have the implementations.
The core module should be brought in as a transitive dependency as the correct
(matching) version. If not then the user should correct this and specify
matching versions for each module.
The question is whether we support binary compatibility (i.e. the ability to
upgrade with no code changes) with mismatched jar versions of the simple module
and the client-api. This may occur where a user is required to provide a
UniformRandomProvider to another library. This library only specifies
client-api v1.0. So the user includes the latest version of simple to be able
to create one.
I tried this and maven resolves this dependency tree:
{noformat}
com.abc:lib:jar:1.0
\- org.apache.commons:commons-rng-client-api:jar:1.0:compile
com.abc:client:jar:1.0
+- org.apache.commons:commons-rng-simple:jar:1.5-SNAPSHOT:compile
| \- org.apache.commons:commons-rng-core:jar:1.5-SNAPSHOT:compile
\- com.abc:lib:jar:1.0:compile
\- org.apache.commons:commons-rng-client-api:jar:1.0:compile
{noformat}
So here maven picks 1.0 for the client-api as it is the closest transitive
dependency. But if methods are removed from core 1.5 it then relies on
client-api 1.5 for some default implementations. So a linkage error will occur.
Currently the POM for simple only includes core. If I add the client API to the
POM for simple (since client-api and core must have matching versions) then
this is resolved as:
{noformat}
com.abc:client:jar:1.0
+- org.apache.commons:commons-rng-simple:jar:1.5-SNAPSHOT:compile
| +- org.apache.commons:commons-rng-client-api:jar:1.5-SNAPSHOT:compile
| \- org.apache.commons:commons-rng-core:jar:1.5-SNAPSHOT:compile
\- com.abc:lib:jar:1.0:compile
{noformat}
This has solved the problem.
So it seems that the multi-module packaging imposes these restrictions:
# Require that the core and client-api modules versions be in sync
# Require that the simple, core and client-api module versions be in sync
The solution would be:
# Add a dependency on the client-api module in the simple module to satisfy
restriction 2
# Remove the redundant methods from the core module that have defaults in the
client-api. These jars must be in sync and so no linkage errors can occur with
missing methods
# Fix the binary compatibility check to allow this
I have done 1 in master as this seems sensible. For example there are
interfaces in the client-api that are used in the simple module such as
JumpableUniformRandomProvider that appears after v1.0 (in this case 1.3). It
seems sensible to avoid a transitive dependency and use an explicit one.
I have added revapi to master as an additional binary compatibility check tool.
This tool allows the changes under discussion. This tool detects only one issue
with the current build and this is in an internal package. I have added this as
a noted api difference to ignore. When the CI builds have verified master is OK
then I will try updating the PR by removing the redundant methods from the core
module. This will require japicmp is disabled for this module in this release
cycle (as it compares the current build with the previous release).
> Enhance the UniformRandomProvider interface with extra methods and default
> implementations
> --
>
> Key: RNG-176
> URL: https://issues.apache.org/jira/browse/RNG-176
> Project: Commons RNG
> Issue Type: New Feature
>Affects Versions: 1.4
>Reporter: Alex Herbert
>Assignee: Alex Herbert
>Priority: Major
>
[jira] [Commented] (COMPRESS-620) ArchiveInputStream fails reading filenames with ANSI characters
[
https://issues.apache.org/jira/browse/COMPRESS-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536633#comment-17536633
]
Michael Osipov commented on COMPRESS-620:
-
For the time being, supply the encoding explicitly to the constructor.
> ArchiveInputStream fails reading filenames with ANSI characters
> ---
>
> Key: COMPRESS-620
> URL: https://issues.apache.org/jira/browse/COMPRESS-620
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.21
>Reporter: Avi
>Priority: Major
>
> I attempted to extract ANSI art packs from [SixteenColors ANSI
> archive|https://github.com/sixteencolors/sixteencolors-archive] but many of
> them fail.
>
> Upon some debugging it appears that as many of the file names contain ANSI
> characters which are parsed by the ArchiveInputStream as question marks, the
> file fails to be saved to disk as question mark is a bad character to be had
> in a filename.
> Specific code:
> ArchiveInputStream archiveInputStream =
> archiveStreamFactory.createArchiveInputStream(ArchiveStreamFactory.ZIP,
> inputStream);
> ArchiveEntry archiveEntry = null;
> while((archiveEntry = archiveInputStream.getNextEntry()) != null) {
> Path path = Paths.get(extractDirectory, archiveEntry.getName());
> example of a non parseable filename in an archive:
> https://github.com/sixteencolors/sixteencolors-archive/blob/master/1992/ace-r%232.zip
> A∙C∙E.ANS
> Bad ZIP file example:
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Comment Edited] (COMPRESS-620) ArchiveInputStream fails reading filenames with ANSI characters
[
https://issues.apache.org/jira/browse/COMPRESS-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536631#comment-17536631
]
Michael Osipov edited comment on COMPRESS-620 at 5/13/22 1:01 PM:
--
Though, I am not a Commons Compress developer, it is a bug in Commons Compress
for me. Let's analyze:
The offending entry:
{noformat}
10E92 4 50 4B 01 02 CENTRAL HEADER #1002014B50
10E96 1 0B Created Zip Spec 0B '1.1'
10E97 1 00 Created OS00 'MS-DOS'
10E98 1 0A Extract Zip Spec 0A '1.0'
10E99 1 00 Extract OS00 'MS-DOS'
10E9A 2 00 00 General Purpose Flag
[Bit 1] 0 '4k Sliding Dictionary'
[Bit 2] 0 '2 Shannon-Fano Trees'
10E9C 2 06 00 Compression Method0006 'Imploded'
10E9E 4 EE 40 79 19 Last Mod Time 197940EE 'Wed Nov 25 08:07:28
1992'
10EA2 4 47 B9 D7 53 CRC 53D7B947
10EA6 4 BE 08 00 00 Compressed Length 08BE
10EAA 4 4F 5E 00 00 Uncompressed Length 5E4F
10EAE 2 09 00 Filename Length 0009
10EB0 2 00 00 Extra Length
10EB2 2 00 00 Comment Length
10EB4 2 00 00 Disk Start
10EB6 2 00 00 Int File Attributes
[Bit 0] 0 'Binary Data'
10EB8 4 20 00 00 00 Ext File Attributes 0020
[Bit 5] Archive
10EBC 4 16 C6 00 00 Local Header Offset C616
10EC0 9 41 F9 43 F9 Filename 'A▒C▒E.ANS'
45 2E 41 4E
53
{noformat}
>From the ZIP note:
{quote}
APPENDIX D - Language Encoding (EFS)
D.1 The ZIP format has historically supported only the original IBM PC
character
encoding set, commonly referred to as IBM Code Page 437. This limits storing
file name characters to only those within the original MS-DOS range of values
and does not properly support file names in other character encodings, or
languages. To address this limitation, this specification will support the
following change.
D.2 If general purpose bit 11 is unset, the file name and comment SHOULD
conform
to the original ZIP character encoding. If general purpose bit 11 is set, the
filename and comment MUST support The Unicode Standard, Version 4.1.0 or
greater using the character encoding form defined by the UTF-8 storage
specification. The Unicode Standard is published by the The Unicode
Consortium (www.unicode.org). UTF-8 encoded data stored within ZIP files
is expected to not include a byte order mark (BOM).
{quote}
bit 11 is not set, so we should assume CP437 here. The file is correct and not
defect for me. BTW, there is NO ANSI encoding. That is an American institute.
Please be precise.
Now the fauly code
[here|https://commons.apache.org/proper/commons-compress/xref/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.html#L306]:
{code:java}
306 final GeneralPurposeBit gpFlag = GeneralPurposeBit.parse(lfhBuf,
off);
307 final boolean hasUTF8Flag = gpFlag.usesUTF8ForNames();
308 final ZipEncoding entryEncoding = hasUTF8Flag ?
ZipEncodingHelper.UTF8_ZIP_ENCODING : zipEncoding;
309 current.hasDataDescriptor = gpFlag.usesDataDescriptor();
310 current.entry.setGeneralPurposeBit(gpFlag);
{code}
Unless you specifiy {{zipEncoding}} it is
[here|https://commons.apache.org/proper/commons-compress/xref/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.html#L187]:
{code;java}
187 public ZipArchiveInputStream(final InputStream inputStream) {
188 this(inputStream, ZipEncodingHelper.UTF8);
189 }
{code}
Although the note says SHOULD, I still would expect CP437 here, for UTF-8 there
is bit 11. Anything else is non-sense.
This deviation is not documented which is just bad.
was (Author: michael-o):
Though, I am not a Commons Compress developer, it is a bug in Commons Compress
for me. Let's analyze:
The offending entry:
{noformat}
10E92 4 50 4B 01 02 CENTRAL HEADER #1002014B50
10E96 1 0B Created Zip Spec 0B '1.1'
10E97 1 00 Created OS00 'MS-DOS'
10E98 1 0A Extract Zip Spec 0A '1.0'
10E99 1 00 Extract OS00 'MS-DOS'
10E9A 2 00 00 General Purpose Flag
[Bit 1] 0 '4k Sliding Dictionary'
[Bit 2] 0 '2 Shannon-Fano Trees'
10E9C 2 06 00 Compression Method0006 'Imploded'
10E9E 4 EE 40 79 19 Last Mod Time 197940EE 'Wed Nov 25 08:07:28
1992'
10EA2 4 47 B9 D7 53 CRC 53D7B947
10EA6 4 BE 08 00 00 Compressed Leng
[jira] [Comment Edited] (COMPRESS-620) ArchiveInputStream fails reading filenames with ANSI characters
[
https://issues.apache.org/jira/browse/COMPRESS-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536631#comment-17536631
]
Michael Osipov edited comment on COMPRESS-620 at 5/13/22 1:01 PM:
--
Though, I am not a Commons Compress developer, it is a bug in Commons Compress
for me. Let's analyze:
The offending entry:
{noformat}
10E92 4 50 4B 01 02 CENTRAL HEADER #1002014B50
10E96 1 0B Created Zip Spec 0B '1.1'
10E97 1 00 Created OS00 'MS-DOS'
10E98 1 0A Extract Zip Spec 0A '1.0'
10E99 1 00 Extract OS00 'MS-DOS'
10E9A 2 00 00 General Purpose Flag
[Bit 1] 0 '4k Sliding Dictionary'
[Bit 2] 0 '2 Shannon-Fano Trees'
10E9C 2 06 00 Compression Method0006 'Imploded'
10E9E 4 EE 40 79 19 Last Mod Time 197940EE 'Wed Nov 25 08:07:28
1992'
10EA2 4 47 B9 D7 53 CRC 53D7B947
10EA6 4 BE 08 00 00 Compressed Length 08BE
10EAA 4 4F 5E 00 00 Uncompressed Length 5E4F
10EAE 2 09 00 Filename Length 0009
10EB0 2 00 00 Extra Length
10EB2 2 00 00 Comment Length
10EB4 2 00 00 Disk Start
10EB6 2 00 00 Int File Attributes
[Bit 0] 0 'Binary Data'
10EB8 4 20 00 00 00 Ext File Attributes 0020
[Bit 5] Archive
10EBC 4 16 C6 00 00 Local Header Offset C616
10EC0 9 41 F9 43 F9 Filename 'A▒C▒E.ANS'
45 2E 41 4E
53
{noformat}
>From the ZIP note:
{quote}
APPENDIX D - Language Encoding (EFS)
D.1 The ZIP format has historically supported only the original IBM PC
character
encoding set, commonly referred to as IBM Code Page 437. This limits storing
file name characters to only those within the original MS-DOS range of values
and does not properly support file names in other character encodings, or
languages. To address this limitation, this specification will support the
following change.
D.2 If general purpose bit 11 is unset, the file name and comment SHOULD
conform
to the original ZIP character encoding. If general purpose bit 11 is set, the
filename and comment MUST support The Unicode Standard, Version 4.1.0 or
greater using the character encoding form defined by the UTF-8 storage
specification. The Unicode Standard is published by the The Unicode
Consortium (www.unicode.org). UTF-8 encoded data stored within ZIP files
is expected to not include a byte order mark (BOM).
{quote}
bit 11 is not set, so we should assume CP437 here. The file is correct and not
defect for me. BTW, there is NO ANSI encoding. That is an American institute.
Please be precise.
Now the fauly code
[here|https://commons.apache.org/proper/commons-compress/xref/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.html#L306]:
{code:java}
306 final GeneralPurposeBit gpFlag = GeneralPurposeBit.parse(lfhBuf,
off);
307 final boolean hasUTF8Flag = gpFlag.usesUTF8ForNames();
308 final ZipEncoding entryEncoding = hasUTF8Flag ?
ZipEncodingHelper.UTF8_ZIP_ENCODING : zipEncoding;
309 current.hasDataDescriptor = gpFlag.usesDataDescriptor();
310 current.entry.setGeneralPurposeBit(gpFlag);
{code}
Unless you specifiy {{zipEncoding}} it is
[here|https://commons.apache.org/proper/commons-compress/xref/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.html#L187]:
{code:java}
187 public ZipArchiveInputStream(final InputStream inputStream) {
188 this(inputStream, ZipEncodingHelper.UTF8);
189 }
{code}
Although the note says SHOULD, I still would expect CP437 here, for UTF-8 there
is bit 11. Anything else is non-sense.
This deviation is not documented which is just bad.
was (Author: michael-o):
Though, I am not a Commons Compress developer, it is a bug in Commons Compress
for me. Let's analyze:
The offending entry:
{noformat}
10E92 4 50 4B 01 02 CENTRAL HEADER #1002014B50
10E96 1 0B Created Zip Spec 0B '1.1'
10E97 1 00 Created OS00 'MS-DOS'
10E98 1 0A Extract Zip Spec 0A '1.0'
10E99 1 00 Extract OS00 'MS-DOS'
10E9A 2 00 00 General Purpose Flag
[Bit 1] 0 '4k Sliding Dictionary'
[Bit 2] 0 '2 Shannon-Fano Trees'
10E9C 2 06 00 Compression Method0006 'Imploded'
10E9E 4 EE 40 79 19 Last Mod Time 197940EE 'Wed Nov 25 08:07:28
1992'
10EA2 4 47 B9 D7 53 CRC 53D7B947
10EA6 4 BE 08 00 00 Compressed Leng
[jira] [Commented] (COMPRESS-620) ArchiveInputStream fails reading filenames with ANSI characters
[
https://issues.apache.org/jira/browse/COMPRESS-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536631#comment-17536631
]
Michael Osipov commented on COMPRESS-620:
-
Though, I am not a Commons Compress developer, it is a bug in Commons Compress
for me. Let's analyze:
The offending entry:
{noformat}
10E92 4 50 4B 01 02 CENTRAL HEADER #1002014B50
10E96 1 0B Created Zip Spec 0B '1.1'
10E97 1 00 Created OS00 'MS-DOS'
10E98 1 0A Extract Zip Spec 0A '1.0'
10E99 1 00 Extract OS00 'MS-DOS'
10E9A 2 00 00 General Purpose Flag
[Bit 1] 0 '4k Sliding Dictionary'
[Bit 2] 0 '2 Shannon-Fano Trees'
10E9C 2 06 00 Compression Method0006 'Imploded'
10E9E 4 EE 40 79 19 Last Mod Time 197940EE 'Wed Nov 25 08:07:28
1992'
10EA2 4 47 B9 D7 53 CRC 53D7B947
10EA6 4 BE 08 00 00 Compressed Length 08BE
10EAA 4 4F 5E 00 00 Uncompressed Length 5E4F
10EAE 2 09 00 Filename Length 0009
10EB0 2 00 00 Extra Length
10EB2 2 00 00 Comment Length
10EB4 2 00 00 Disk Start
10EB6 2 00 00 Int File Attributes
[Bit 0] 0 'Binary Data'
10EB8 4 20 00 00 00 Ext File Attributes 0020
[Bit 5] Archive
10EBC 4 16 C6 00 00 Local Header Offset C616
10EC0 9 41 F9 43 F9 Filename 'A▒C▒E.ANS'
45 2E 41 4E
53
{noformat}
>From the ZIP note:
{quote}
APPENDIX D - Language Encoding (EFS)
D.1 The ZIP format has historically supported only the original IBM PC
character
encoding set, commonly referred to as IBM Code Page 437. This limits storing
file name characters to only those within the original MS-DOS range of values
and does not properly support file names in other character encodings, or
languages. To address this limitation, this specification will support the
following change.
D.2 If general purpose bit 11 is unset, the file name and comment SHOULD
conform
to the original ZIP character encoding. If general purpose bit 11 is set, the
filename and comment MUST support The Unicode Standard, Version 4.1.0 or
greater using the character encoding form defined by the UTF-8 storage
specification. The Unicode Standard is published by the The Unicode
Consortium (www.unicode.org). UTF-8 encoded data stored within ZIP files
is expected to not include a byte order mark (BOM).
{quote}
bit 11 is not set, so we must assume CP437 here. The file is correct and not
defect for me. BTW, there is NO ANSI encoding. That is an American institute.
Please be precise.
Now the fauly code
[here|https://commons.apache.org/proper/commons-compress/xref/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.html#L306]:
{code:java}
306 final GeneralPurposeBit gpFlag = GeneralPurposeBit.parse(lfhBuf,
off);
307 final boolean hasUTF8Flag = gpFlag.usesUTF8ForNames();
308 final ZipEncoding entryEncoding = hasUTF8Flag ?
ZipEncodingHelper.UTF8_ZIP_ENCODING : zipEncoding;
309 current.hasDataDescriptor = gpFlag.usesDataDescriptor();
310 current.entry.setGeneralPurposeBit(gpFlag);
{code}
Unless you specifiy {{zipEncoding}} it is
[here|https://commons.apache.org/proper/commons-compress/xref/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.html#L187]:
{code;java}
187 public ZipArchiveInputStream(final InputStream inputStream) {
188 this(inputStream, ZipEncodingHelper.UTF8);
189 }
{code}
Although the note says SHOULD, I still would expect CP437 here, for UTF-8 there
is bit 11. Anything else is non-sense.
This deviation is not documented which is just bad.
> ArchiveInputStream fails reading filenames with ANSI characters
> ---
>
> Key: COMPRESS-620
> URL: https://issues.apache.org/jira/browse/COMPRESS-620
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
>Affects Versions: 1.21
>Reporter: Avi
>Priority: Major
>
> I attempted to extract ANSI art packs from [SixteenColors ANSI
> archive|https://github.com/sixteencolors/sixteencolors-archive] but many of
> them fail.
>
> Upon some debugging it appears that as many of the file names contain ANSI
> characters which are parsed by the ArchiveInputStream as question marks, the
> file fails to be saved to disk as question mark is a bad character to be had
> in a filename.
> Specific code:
> ArchiveInputStream archiveInputStream =
> archiveStreamFactory.creat
[GitHub] [commons-collections] codecov-commenter commented on pull request #309: Bump checkstyle from 9.3 to 10.2
codecov-commenter commented on PR #309: URL: https://github.com/apache/commons-collections/pull/309#issuecomment-1126016252 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#309](https://codecov.io/gh/apache/commons-collections/pull/309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b594aec) into [master](https://codecov.io/gh/apache/commons-collections/commit/1677daceab74895fdf5056c9a48aa94f9e709fb9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1677dac) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #309 +/- ## = Coverage 85.87% 85.87% Complexity 4676 4676 = Files 292 292 Lines 1346913469 Branches 1955 1955 = Hits 1156611566 Misses 1326 1326 Partials577 577 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/309?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/309?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1677dac...b594aec](https://codecov.io/gh/apache/commons-collections/pull/309?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] opened a new pull request, #309: Bump checkstyle from 9.3 to 10.2
dependabot[bot] opened a new pull request, #309: URL: https://github.com/apache/commons-collections/pull/309 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.2. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-10.2 https://checkstyle.org/releasenotes.html#Release_10.2";>https://checkstyle.org/releasenotes.html#Release_10.2 checkstyle-10.1 https://checkstyle.org/releasenotes.html#Release_10.1";>https://checkstyle.org/releasenotes.html#Release_10.1 checkstyle-10.0 https://checkstyle.org/releasenotes.html#Release_10.0";>https://checkstyle.org/releasenotes.html#Release_10.0 Commits https://github.com/checkstyle/checkstyle/commit/0678fc609ec1889e3534940aa9d094887a4af2f3";>0678fc6 [maven-release-plugin] prepare release checkstyle-10.2 https://github.com/checkstyle/checkstyle/commit/acf70b4d7e8e4423579f02bf88d9773ba9574a77";>acf70b4 doc: release notes for 10.2 https://github.com/checkstyle/checkstyle/commit/591b41028cecc786ea94556791a8e53a99defb4c";>591b410 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/4845";>#4845: remove dependency on netbuddy from test inputs https://github.com/checkstyle/checkstyle/commit/0fda5157d34980c229090931af2a1a1ce74e87a9";>0fda515 dependency: bump maven-antrun-plugin from 3.0.0 to 3.1.0 https://github.com/checkstyle/checkstyle/commit/7f5fcc814f63a590d24b34a3e6289facfbffc264";>7f5fcc8 supplemental: Modify pitest.sh to support unstable mutations list https://github.com/checkstyle/checkstyle/commit/0ab05c948d302dde4f3e4144e97af30a2613900a";>0ab05c9 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11528";>#11528: Kill surviving mutation in EqualsAvoidNullCheck https://github.com/checkstyle/checkstyle/commit/c2abb6fb4cef7c4d3e565bd05d061841fc86db50";>c2abb6f minor: fix link (link-check-plugin) https://github.com/checkstyle/checkstyle/commit/4a7e6fa6b7eeb0658d09c64bc9f390f24c3ab10b";>4a7e6fa dependency: bump nexus-staging-maven-plugin from 1.6.12 to 1.6.13 https://github.com/checkstyle/checkstyle/commit/8035e76a5ba81f4841519d0d3ceb9e7a4f913506";>8035e76 dependency: bump mockito-inline from 4.5.0 to 4.5.1 https://github.com/checkstyle/checkstyle/commit/d00939d8400537a7eecc56e7ec1fdaf3f0574333";>d00939d dependency: bump maven-site-plugin from 3.11.0 to 3.12.0 Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow merged pull request #112: Bump jacoco-maven-plugin from 0.8.7 to 0.8.8
kinow merged PR #112: URL: https://github.com/apache/commons-release-plugin/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] opened a new pull request, #112: Bump jacoco-maven-plugin from 0.8.7 to 0.8.8
dependabot[bot] opened a new pull request, #112: URL: https://github.com/apache/commons-release-plugin/pull/112 Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.7 to 0.8.8. Release notes Sourced from https://github.com/jacoco/jacoco/releases";>jacoco-maven-plugin's releases. 0.8.8 New Features JaCoCo now officially supports Java 17 and 18 (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1282";>#1282, https://github-redirect.dependabot.com/jacoco/jacoco/issues/1198";>#1198). Experimental support for Java 19 class files (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1264";>#1264). Part of bytecode generated by the Java compilers for assert statement is filtered out during generation of report (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1196";>#1196). Branch added by the Kotlin compiler version 1.6.0 and above for "unsafe" cast operator is filtered out during generation of report (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1266";>#1266). Improved support for multiple JaCoCo runtimes in the same VM (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1057";>#1057). Fixed bugs Fixed NullPointerException during filtering (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1189";>#1189). Fix range for debug symbols of method parameters (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1246";>#1246). Non-functional Changes JaCoCo now depends on ASM 9.2 (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1206";>#1206). Messages of exceptions occurring during analysis or instrumentation now include JaCoCo version (GitHub https://github-redirect.dependabot.com/jacoco/jacoco/issues/1217";>#1217). Commits https://github.com/jacoco/jacoco/commit/5dcf34ad180c125ee3214437b0ca4f9b7b6258fc";>5dcf34a Prepare release 0.8.8 https://github.com/jacoco/jacoco/commit/aa16a7c25cfc119ba3486bb114d3d54dc1bcca6c";>aa16a7c Improve support for multiple JaCoCo runtimes in the same VM (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1057";>#1057) https://github.com/jacoco/jacoco/commit/7e516b1eaba146f0b5c05cfc3c3ac1a2a0735cb8";>7e516b1 Update documentation: JDK versions 17 and 18 are officially supported (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1282";>#1282) https://github.com/jacoco/jacoco/commit/c54fa8a521022ac9af9a8c2f0533b2652d5d205a";>c54fa8a Include JaCoCo version in instrumentation/analysis exception messages (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1217";>#1217) https://github.com/jacoco/jacoco/commit/046ba52e9fd1288cf121fd1013c9019d71946954";>046ba52 Happy New Year 2022! https://github.com/jacoco/jacoco/commit/2036acc5d2e88fed74b9a70728af1bebedb34055";>2036acc Update KotlinUnsafeCastOperatorFilter for Kotlin 1.6 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1266";>#1266) https://github.com/jacoco/jacoco/commit/ac756b60c029d0acf5e1202c9966b2c5a79b6b8c";>ac756b6 Add experimental support for Java 19 class files (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1264";>#1264) https://github.com/jacoco/jacoco/commit/a0cf1e6c0ce9bbfeda705201278689a01b3d274b";>a0cf1e6 Upgrade gmavenplus-plugin to 1.13.0 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1253";>#1253) https://github.com/jacoco/jacoco/commit/024de66740f7308ce98b6ce895a4ae1d049d282d";>024de66 Fix build for JDK 18 >= EA b21 (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1249";>#1249) https://github.com/jacoco/jacoco/commit/70d5b98d8c438126e9e95f186017ef972b031ef8";>70d5b98 Fix range for debug symbols of method parameters (https://github-redirect.dependabot.com/jacoco/jacoco/issues/1246";>#1246) Additional commits viewable in https://github.com/jacoco/jacoco/compare/v0.8.7...v0.8.8";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@de
[jira] [Reopened] (JEXL-369) Add 'let' and 'const' variable declarations
[ https://issues.apache.org/jira/browse/JEXL-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro reopened JEXL-369: Const vars should be assigned before use; Const var name may not be reused in different blocks; > Add 'let' and 'const' variable declarations > --- > > Key: JEXL-369 > URL: https://issues.apache.org/jira/browse/JEXL-369 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Henri Biestro >Assignee: Henri Biestro >Priority: Major > Fix For: 3.3 > > > WHAT: > Add creation of lexical scope variables, modifiable with 'let', > non-modifiable through 'const'. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (LANG-1680) FastDateFormat does not support the 'L'-Pattern from SimpleDateFormat
[
https://issues.apache.org/jira/browse/LANG-1680?focusedWorklogId=770061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770061
]
ASF GitHub Bot logged work on LANG-1680:
Author: ASF GitHub Bot
Created on: 13/May/22 07:57
Start Date: 13/May/22 07:57
Worklog Time Spent: 10m
Work Description: stevebosman-oc commented on PR #892:
URL: https://github.com/apache/commons-lang/pull/892#issuecomment-1125763691
Odd, I seem to have encountered a version of
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8146356 but that
claims to have been fixed in an earlier version of the 1.8 JDK than the one I'm
running
Issue Time Tracking
---
Worklog Id: (was: 770061)
Time Spent: 1.5h (was: 1h 20m)
> FastDateFormat does not support the 'L'-Pattern from SimpleDateFormat
> -
>
> Key: LANG-1680
> URL: https://issues.apache.org/jira/browse/LANG-1680
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.12.0
> Environment: All
>Reporter: Michael Krause
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The MMM-Pattern in SimpleDateFormat is context-sensitve.
> If you execute
> FastDateFormat.getInstance("MMMyy",
> Locale.GERMAN).format(Calendar.getInstance())
> You get "Jan.22". Observer the dot after 'Jan'. If you do the equivalent
> with SimpleDateFormat with 'LLLyy' instead as the pattern
> new SimpleDateFormat("LLLyy",
> Locale.GERMANY).format(Calendar.getInstance().getTime());
> you get "Jan22" as expected.
>
> If the 'L'-Pattern is used with FastDateFormat, it throws an
> IllegalArgumentException
> {{java.lang.IllegalArgumentException: Illegal pattern component: LLL}}{{
> at
> org.apache.commons.lang3.time.FastDatePrinter.parsePattern(FastDatePrinter.java:311)}}{{
> }}
> {{The Source shows that the L-Pattern is not implemented.}}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-lang] stevebosman-oc commented on pull request #892: LANG-1680 Add support for standalone month formats
stevebosman-oc commented on PR #892: URL: https://github.com/apache/commons-lang/pull/892#issuecomment-1125763691 Odd, I seem to have encountered a version of https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8146356 but that claims to have been fixed in an earlier version of the 1.8 JDK than the one I'm running -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMPRESS-620) ArchiveInputStream fails reading filenames with ANSI characters
Avi created COMPRESS-620:
Summary: ArchiveInputStream fails reading filenames with ANSI
characters
Key: COMPRESS-620
URL: https://issues.apache.org/jira/browse/COMPRESS-620
Project: Commons Compress
Issue Type: Bug
Components: Archivers
Affects Versions: 1.21
Reporter: Avi
I attempted to extract ANSI art packs from [SixteenColors ANSI
archive|https://github.com/sixteencolors/sixteencolors-archive] but many of
them fail.
Upon some debugging it appears that as many of the file names contain ANSI
characters which are parsed by the ArchiveInputStream as question marks, the
file fails to be saved to disk as question mark is a bad character to be had in
a filename.
Specific code:
ArchiveInputStream archiveInputStream =
archiveStreamFactory.createArchiveInputStream(ArchiveStreamFactory.ZIP,
inputStream);
ArchiveEntry archiveEntry = null;
while((archiveEntry = archiveInputStream.getNextEntry()) != null) {
Path path = Paths.get(extractDirectory, archiveEntry.getName());
example of a non parseable filename in an archive:
https://github.com/sixteencolors/sixteencolors-archive/blob/master/1992/ace-r%232.zip
A∙C∙E.ANS
Bad ZIP file example:
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
