[jira] [Commented] (RNG-179) The Fast Loaded Dice Roller: A Near-Optimal Exact Sampler for Discrete Probability Distributions
[
https://issues.apache.org/jira/browse/RNG-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544623#comment-17544623
]
Alex Herbert commented on RNG-179:
--
I updated the code to remove the use of BigInteger to store the relative
weights. The integers are now stored as a 53-bit long integer (created from the
mantissa of the input double weight) and an exponent offset. The weight is thus:
{code:java}
weight = value * 2^exponent
BigInteger.valueOf(value).shiftLeft(exponent) {code}
Each bit of the integer can now be tested by determining if the bit is within
the integer using:
{code:java}
// Old (the BigInteger value was cached)
BigInteger.valueOf(value).shiftLeft(offset).testBit(n)
// New
private static boolean testBit(long value, int offset, int n) {
if (n < offset) {
// All logical trailing bits are zero
return false;
}
final int bit = n - offset;
return bit <= 53 && (value & (1L << bit)) != 0;
}{code}
The new code is marginally faster at testing the bits. Looking at the source
for BigInteger there are some branch statements that are avoided and the number
of instructions is lower (since BigInteger does some extra logic to handle zero
and negatives).
The construction performance can be improved further by ignoring very small
weights. I added an alpha parameter that will ignore any weights that are at
least 2^alpha smaller in magnitude than the largest weight. The comparison uses
only the exponent offsets. Any filtered weights are set to zero and ignored
from further processing. This does not reduce the in-memory size of the
discrete distribution generating tree.
The following table shows the previous BigInteger performance against the new
version. A version with alpha=53 is shown. This only affects the Binomial
distribution which reduces from 68 weights down to 55 with a noticeable
improvement in construction speed. The speed is still much slower than just
approximately mapping to long[].
||Distribution||double[] BigInteger||double[]||double[] alpha=53||long[]||
|4SidedLoadedDie|842.9|703.2|738.1|666.6|
|Binomial_N67_P0.7|55466.3|34948.1|23003.8|6833.3|
|Geometric_P0.2|48722.1|37459.9|36418.5|10702.3|
|Poisson_Mean10_Mean20|19013.6|15893.4|13786.8|5862.4|
|Poisson_Mean3.22|7434.5|6600.3|6395.6|2417.2|
|Random 3072|2184490.83|1551266.0|1560548.4|1009663.4|
The slowest to construct is the Random 3072 data. This has 3072 weights. In
this case alpha=53 makes no difference as the weights are sampled from the 2^53
dyadic rationals and no weights can be excluded. The speed of the new version
is approximately 0.71x the old version.
For the Binomial distribution the affect of alpha on sampling is negligible
(data not shown). This is due to the fact that the weights that were excluded
will be sampled at most every 2^53 times. Thus the bulk of the distribution
targeted by the sampler is essentially unchanged.
h2. Conclusion
The sampler construction is slow. To maintain the property of exact sampling
from the input distribution requires exact math to be performed on the weights.
This can be changed to ignore very small relative weights, or the weights
mapped to long. Both improve construction performance but result is the
sampling no longer being exact. The performance of sampling is not affected (if
only very small weights are ignored).
> The Fast Loaded Dice Roller: A Near-Optimal Exact Sampler for Discrete
> Probability Distributions
>
>
> Key: RNG-179
> URL: https://issues.apache.org/jira/browse/RNG-179
> Project: Commons RNG
> Issue Type: New Feature
> Components: sampling
>Reporter: Vladimir Sitnikov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It might make sense to implement Fast Loaded Dice Roller sampler.
> See https://arxiv.org/pdf/2003.03830v2.pdf,
> https://github.com/probcomp/fast-loaded-dice-roller
> The authors claim that Fast Loaded Dice Roller is faster than the Alias
> Method.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-chain] dependabot[bot] closed pull request #33: Bump actions/cache from 2.1.4 to 3.0.3
dependabot[bot] closed pull request #33: Bump actions/cache from 2.1.4 to 3.0.3 URL: https://github.com/apache/commons-chain/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #33: Bump actions/cache from 2.1.4 to 3.0.3
dependabot[bot] commented on PR #33: URL: https://github.com/apache/commons-chain/pull/33#issuecomment-1142639815 Looks like actions/cache is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] closed pull request #29: Bump actions/cache from 2.1.4 to 3.0.2
dependabot[bot] closed pull request #29: Bump actions/cache from 2.1.4 to 3.0.2 URL: https://github.com/apache/commons-chain/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #29: Bump actions/cache from 2.1.4 to 3.0.2
dependabot[bot] commented on PR #29: URL: https://github.com/apache/commons-chain/pull/29#issuecomment-1142637480 Superseded by #33. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] opened a new pull request, #33: Bump actions/cache from 2.1.4 to 3.0.3
dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/commons-chain/pull/33 Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 3.0.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>actions/cache#624) v3.0.2 This release adds the support for dynamic cache size cap on GHES. v3.0.1 Added support for caching from GHES 3.5. Fixed download issue for files 2GB during restore. v3.0.0 This change adds a minimum runner version(node12 - node16), which can break users using an out-of-date/fork of the runner. This would be most commonly affecting users on GHES 3.3 or before, as those runners do not support node16 actions and they can use actions from github.com via https://docs.github.com/en/enterprise-server@3.0/admin/github-actions/managing-access-to-actions-from-githubcom/enabling-automatic-access-to-githubcom-actions-using-github-connect;>github connect or manually copying the repo to their GHES instance. Few dependencies and cache action usage examples have also been updated. v2.1.7 Support 10GB cache upload using the latest version 1.0.8 of https://www.npmjs.com/package/@actions/cache;>@actions/cache v2.1.6 Catch unhandled bad file descriptor errors that sometimes occurs when the cache server returns non-successful response (https://github-redirect.dependabot.com/actions/cache/pull/596;>actions/cache#596) v2.1.5 Fix permissions error seen when extracting caches with GNU tar that were previously created using BSD tar (https://github-redirect.dependabot.com/actions/cache/issues/527;>actions/cache#527) Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) Commits https://github.com/actions/cache/commit/30f413bfed0a2bc738fdfd409e5a9e96b24545fd;>30f413b Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/808;>#808 from actions/users/kotewar/update-actions-cache-version https://github.com/actions/cache/commit/f2ea0f25f2b1682903f47758e4d974259aa04bbc;>f2ea0f2 Updated Readme with what's new and removed v2 info https://github.com/actions/cache/commit/d5956bbc3c018cab116f8c5b3fddebf4c84860d9;>d5956bb Updated release and package versions https://github.com/actions/cache/commit/a686c72e4a9eb6c1e96fe8459ff3ed4ec0df82b5;>a686c72 Revert Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/8e680ea4405aa0db49134fc28c93e37abce96d2e;>8e680ea Revert Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/c376fc84c91391874fb5bd69fe5a5465922f70a0;>c376fc8 Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/4ce1a96732c56fd55c0f2962bc5b8326a0ee09c2;>4ce1a96 Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/a2bd439f8e01bb9153bb5d198238a9879614334a;>a2bd439 Updated license version and dist https://github.com/actions/cache/commit/35ef551d1fb7681545ef56c17d23785a2cd7fc46;>35ef551 Upgraded @actions/cache to 2.0.5 https://github.com/actions/cache/commit/14c4fd4871149762bbba2312aaf4b031861333d5;>14c4fd4 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/690;>#690 from pimterry/patch-1 Additional commits viewable in https://github.com/actions/cache/compare/v2.1.4...v3.0.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging -
[GitHub] [commons-chain] dependabot[bot] closed pull request #32: Bump actions/checkout from 2.3.4 to 3.0.2
dependabot[bot] closed pull request #32: Bump actions/checkout from 2.3.4 to 3.0.2 URL: https://github.com/apache/commons-chain/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #32: Bump actions/checkout from 2.3.4 to 3.0.2
dependabot[bot] commented on PR #32: URL: https://github.com/apache/commons-chain/pull/32#issuecomment-1142637381 Looks like actions/checkout is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #265: Bump mockito-core from 4.5.1 to 4.6.0
garydgregory merged PR #265: URL: https://github.com/apache/commons-vfs/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #147: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] commented on PR #147: URL: https://github.com/apache/commons-fileupload/pull/147#issuecomment-1142617050 Looks like actions/cache is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] closed pull request #147: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] closed pull request #147: Bump actions/cache from 3.0.2 to 3.0.3 URL: https://github.com/apache/commons-fileupload/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] commented on pull request #53: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] commented on PR #53: URL: https://github.com/apache/commons-exec/pull/53#issuecomment-1142615924 Looks like actions/cache is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] closed pull request #53: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] closed pull request #53: Bump actions/cache from 3.0.2 to 3.0.3 URL: https://github.com/apache/commons-exec/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] closed pull request #78: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] closed pull request #78: Bump actions/cache from 3.0.2 to 3.0.3 URL: https://github.com/apache/commons-email/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #78: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] commented on PR #78: URL: https://github.com/apache/commons-email/pull/78#issuecomment-1142615404 Looks like actions/cache is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request, #78: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/commons-email/pull/78 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.2 to 3.0.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>actions/cache#624) Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) Commits https://github.com/actions/cache/commit/30f413bfed0a2bc738fdfd409e5a9e96b24545fd;>30f413b Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/808;>#808 from actions/users/kotewar/update-actions-cache-version https://github.com/actions/cache/commit/f2ea0f25f2b1682903f47758e4d974259aa04bbc;>f2ea0f2 Updated Readme with what's new and removed v2 info https://github.com/actions/cache/commit/d5956bbc3c018cab116f8c5b3fddebf4c84860d9;>d5956bb Updated release and package versions https://github.com/actions/cache/commit/a686c72e4a9eb6c1e96fe8459ff3ed4ec0df82b5;>a686c72 Revert Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/8e680ea4405aa0db49134fc28c93e37abce96d2e;>8e680ea Revert Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/c376fc84c91391874fb5bd69fe5a5465922f70a0;>c376fc8 Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/4ce1a96732c56fd55c0f2962bc5b8326a0ee09c2;>4ce1a96 Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/a2bd439f8e01bb9153bb5d198238a9879614334a;>a2bd439 Updated license version and dist https://github.com/actions/cache/commit/35ef551d1fb7681545ef56c17d23785a2cd7fc46;>35ef551 Upgraded @actions/cache to 2.0.5 https://github.com/actions/cache/commit/14c4fd4871149762bbba2312aaf4b031861333d5;>14c4fd4 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/690;>#690 from pimterry/patch-1 Additional commits viewable in https://github.com/actions/cache/compare/v3.0.2...v3.0.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #265: Bump mockito-core from 4.5.1 to 4.6.0
garydgregory commented on PR #265: URL: https://github.com/apache/commons-vfs/pull/265#issuecomment-1142585602 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #264: Bump spotbugs-maven-plugin from 4.6.0.0 to 4.7.0.0
garydgregory merged PR #264: URL: https://github.com/apache/commons-vfs/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request, #147: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] opened a new pull request, #147: URL: https://github.com/apache/commons-fileupload/pull/147 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.2 to 3.0.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>actions/cache#624) Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) Commits https://github.com/actions/cache/commit/30f413bfed0a2bc738fdfd409e5a9e96b24545fd;>30f413b Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/808;>#808 from actions/users/kotewar/update-actions-cache-version https://github.com/actions/cache/commit/f2ea0f25f2b1682903f47758e4d974259aa04bbc;>f2ea0f2 Updated Readme with what's new and removed v2 info https://github.com/actions/cache/commit/d5956bbc3c018cab116f8c5b3fddebf4c84860d9;>d5956bb Updated release and package versions https://github.com/actions/cache/commit/a686c72e4a9eb6c1e96fe8459ff3ed4ec0df82b5;>a686c72 Revert Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/8e680ea4405aa0db49134fc28c93e37abce96d2e;>8e680ea Revert Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/c376fc84c91391874fb5bd69fe5a5465922f70a0;>c376fc8 Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/4ce1a96732c56fd55c0f2962bc5b8326a0ee09c2;>4ce1a96 Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/a2bd439f8e01bb9153bb5d198238a9879614334a;>a2bd439 Updated license version and dist https://github.com/actions/cache/commit/35ef551d1fb7681545ef56c17d23785a2cd7fc46;>35ef551 Upgraded @actions/cache to 2.0.5 https://github.com/actions/cache/commit/14c4fd4871149762bbba2312aaf4b031861333d5;>14c4fd4 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/690;>#690 from pimterry/patch-1 Additional commits viewable in https://github.com/actions/cache/compare/v3.0.2...v3.0.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] opened a new pull request, #53: Bump actions/cache from 3.0.2 to 3.0.3
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/commons-exec/pull/53 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.2 to 3.0.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>actions/cache#624) Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) Commits https://github.com/actions/cache/commit/30f413bfed0a2bc738fdfd409e5a9e96b24545fd;>30f413b Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/808;>#808 from actions/users/kotewar/update-actions-cache-version https://github.com/actions/cache/commit/f2ea0f25f2b1682903f47758e4d974259aa04bbc;>f2ea0f2 Updated Readme with what's new and removed v2 info https://github.com/actions/cache/commit/d5956bbc3c018cab116f8c5b3fddebf4c84860d9;>d5956bb Updated release and package versions https://github.com/actions/cache/commit/a686c72e4a9eb6c1e96fe8459ff3ed4ec0df82b5;>a686c72 Revert Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/8e680ea4405aa0db49134fc28c93e37abce96d2e;>8e680ea Revert Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/c376fc84c91391874fb5bd69fe5a5465922f70a0;>c376fc8 Added release information for 3.0.2 in RELEASES.md https://github.com/actions/cache/commit/4ce1a96732c56fd55c0f2962bc5b8326a0ee09c2;>4ce1a96 Updated package version to 3.0.3 and dependencies https://github.com/actions/cache/commit/a2bd439f8e01bb9153bb5d198238a9879614334a;>a2bd439 Updated license version and dist https://github.com/actions/cache/commit/35ef551d1fb7681545ef56c17d23785a2cd7fc46;>35ef551 Upgraded @actions/cache to 2.0.5 https://github.com/actions/cache/commit/14c4fd4871149762bbba2312aaf4b031861333d5;>14c4fd4 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/690;>#690 from pimterry/patch-1 Additional commits viewable in https://github.com/actions/cache/compare/v3.0.2...v3.0.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-820) FileObject.copyFrom leaves extra bytes when copying from a smaller file
[
https://issues.apache.org/jira/browse/VFS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544453#comment-17544453
]
Gary D. Gregory commented on VFS-820:
-
Hi [~agoubard]
Thank you for confirming the fix.
> FileObject.copyFrom leaves extra bytes when copying from a smaller file
> ---
>
> Key: VFS-820
> URL: https://issues.apache.org/jira/browse/VFS-820
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
> Environment: Tested on Windows 10
>Reporter: Anthony Goubard
>Priority: Major
> Fix For: 2.10.0
>
>
> If you copy a file using the _FileObject.copyFrom_ method and the destination
> file is larger than the source file, the destination will contain the bytes
> of the source file and the remaining bytes of the destination (See example).
>
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.charset.StandardCharsets;
> import java.nio.file.Files;
> import org.apache.commons.vfs2.FileObject;
> import org.apache.commons.vfs2.Selectors;
> import org.apache.commons.vfs2.VFS;
> public class BugCopyToLargerFile {
> private static final String LARGE_TEXT = "This is a larger text.\nTo show
> that the extra bytes are remining after a copy of a small file";
> private static final String SHORT_TEXT = "This is a short text.";
> public static final void main(String args[]) throws IOException {
> File largeFile = new File(System.getProperty("java.io.tmpdir"),
> "large.txt");
> File shortFile = new File(System.getProperty("java.io.tmpdir"),
> "short.txt");
> FileObject largeFileObject = VFS.getManager().toFileObject(largeFile);
> Files.writeString(largeFile.toPath(), LARGE_TEXT,
> StandardCharsets.UTF_8);
> FileObject shortFileObject = VFS.getManager().toFileObject(shortFile);
> Files.writeString(shortFile.toPath(), SHORT_TEXT,
> StandardCharsets.UTF_8);
> checkFileContent(shortFile, SHORT_TEXT);
> checkFileContent(largeFile, LARGE_TEXT);
> largeFileObject.copyFrom(shortFileObject, Selectors.SELECT_ALL);
> checkFileContent(largeFile, SHORT_TEXT);
> }
> private static void checkFileContent(File file, String content) throws
> IOException {
> String fileContent = Files.readString(file.toPath(),
> StandardCharsets.UTF_8);
> if (fileContent.equals(content)) {
> System.out.println(file.getName() + " correct");
> } else {
> System.out.println(file.getName() + " incorrect content: " +
> fileContent);
> }
> }
> }
> {code}
> {noformat}
> short.txt correct
> large.txt correct
> large.txt incorrect content: This is a short text..
> To show that the extra bytes are remining after a copy of a small file
> {noformat}
> Note that the javadoc of copyFrom contains "If this file does exist, it is
> deleted first." but it doesn't happen in the code.
> One solution would be to delete the file like in _FileObject.moveTo_ method
> {code:java}
> if (exists() && !isSameFile(file)) {
> deleteSelf();
> }
> {code}
> But I think that the problem is in the _DefaultFileContent.write_ methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (VFS-820) FileObject.copyFrom leaves extra bytes when copying from a smaller file
[
https://issues.apache.org/jira/browse/VFS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated VFS-820:
Fix Version/s: 2.10.0
(was: Nightly Builds)
> FileObject.copyFrom leaves extra bytes when copying from a smaller file
> ---
>
> Key: VFS-820
> URL: https://issues.apache.org/jira/browse/VFS-820
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
> Environment: Tested on Windows 10
>Reporter: Anthony Goubard
>Priority: Major
> Fix For: 2.10.0
>
>
> If you copy a file using the _FileObject.copyFrom_ method and the destination
> file is larger than the source file, the destination will contain the bytes
> of the source file and the remaining bytes of the destination (See example).
>
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.charset.StandardCharsets;
> import java.nio.file.Files;
> import org.apache.commons.vfs2.FileObject;
> import org.apache.commons.vfs2.Selectors;
> import org.apache.commons.vfs2.VFS;
> public class BugCopyToLargerFile {
> private static final String LARGE_TEXT = "This is a larger text.\nTo show
> that the extra bytes are remining after a copy of a small file";
> private static final String SHORT_TEXT = "This is a short text.";
> public static final void main(String args[]) throws IOException {
> File largeFile = new File(System.getProperty("java.io.tmpdir"),
> "large.txt");
> File shortFile = new File(System.getProperty("java.io.tmpdir"),
> "short.txt");
> FileObject largeFileObject = VFS.getManager().toFileObject(largeFile);
> Files.writeString(largeFile.toPath(), LARGE_TEXT,
> StandardCharsets.UTF_8);
> FileObject shortFileObject = VFS.getManager().toFileObject(shortFile);
> Files.writeString(shortFile.toPath(), SHORT_TEXT,
> StandardCharsets.UTF_8);
> checkFileContent(shortFile, SHORT_TEXT);
> checkFileContent(largeFile, LARGE_TEXT);
> largeFileObject.copyFrom(shortFileObject, Selectors.SELECT_ALL);
> checkFileContent(largeFile, SHORT_TEXT);
> }
> private static void checkFileContent(File file, String content) throws
> IOException {
> String fileContent = Files.readString(file.toPath(),
> StandardCharsets.UTF_8);
> if (fileContent.equals(content)) {
> System.out.println(file.getName() + " correct");
> } else {
> System.out.println(file.getName() + " incorrect content: " +
> fileContent);
> }
> }
> }
> {code}
> {noformat}
> short.txt correct
> large.txt correct
> large.txt incorrect content: This is a short text..
> To show that the extra bytes are remining after a copy of a small file
> {noformat}
> Note that the javadoc of copyFrom contains "If this file does exist, it is
> deleted first." but it doesn't happen in the code.
> One solution would be to delete the file like in _FileObject.moveTo_ method
> {code:java}
> if (exists() && !isSameFile(file)) {
> deleteSelf();
> }
> {code}
> But I think that the problem is in the _DefaultFileContent.write_ methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (VFS-820) FileObject.copyFrom leaves extra bytes when copying from a smaller file
[
https://issues.apache.org/jira/browse/VFS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Goubard resolved VFS-820.
-
Fix Version/s: Nightly Builds
Resolution: Fixed
> FileObject.copyFrom leaves extra bytes when copying from a smaller file
> ---
>
> Key: VFS-820
> URL: https://issues.apache.org/jira/browse/VFS-820
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
> Environment: Tested on Windows 10
>Reporter: Anthony Goubard
>Priority: Major
> Fix For: Nightly Builds
>
>
> If you copy a file using the _FileObject.copyFrom_ method and the destination
> file is larger than the source file, the destination will contain the bytes
> of the source file and the remaining bytes of the destination (See example).
>
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.charset.StandardCharsets;
> import java.nio.file.Files;
> import org.apache.commons.vfs2.FileObject;
> import org.apache.commons.vfs2.Selectors;
> import org.apache.commons.vfs2.VFS;
> public class BugCopyToLargerFile {
> private static final String LARGE_TEXT = "This is a larger text.\nTo show
> that the extra bytes are remining after a copy of a small file";
> private static final String SHORT_TEXT = "This is a short text.";
> public static final void main(String args[]) throws IOException {
> File largeFile = new File(System.getProperty("java.io.tmpdir"),
> "large.txt");
> File shortFile = new File(System.getProperty("java.io.tmpdir"),
> "short.txt");
> FileObject largeFileObject = VFS.getManager().toFileObject(largeFile);
> Files.writeString(largeFile.toPath(), LARGE_TEXT,
> StandardCharsets.UTF_8);
> FileObject shortFileObject = VFS.getManager().toFileObject(shortFile);
> Files.writeString(shortFile.toPath(), SHORT_TEXT,
> StandardCharsets.UTF_8);
> checkFileContent(shortFile, SHORT_TEXT);
> checkFileContent(largeFile, LARGE_TEXT);
> largeFileObject.copyFrom(shortFileObject, Selectors.SELECT_ALL);
> checkFileContent(largeFile, SHORT_TEXT);
> }
> private static void checkFileContent(File file, String content) throws
> IOException {
> String fileContent = Files.readString(file.toPath(),
> StandardCharsets.UTF_8);
> if (fileContent.equals(content)) {
> System.out.println(file.getName() + " correct");
> } else {
> System.out.println(file.getName() + " incorrect content: " +
> fileContent);
> }
> }
> }
> {code}
> {noformat}
> short.txt correct
> large.txt correct
> large.txt incorrect content: This is a short text..
> To show that the extra bytes are remining after a copy of a small file
> {noformat}
> Note that the javadoc of copyFrom contains "If this file does exist, it is
> deleted first." but it doesn't happen in the code.
> One solution would be to delete the file like in _FileObject.moveTo_ method
> {code:java}
> if (exists() && !isSameFile(file)) {
> deleteSelf();
> }
> {code}
> But I think that the problem is in the _DefaultFileContent.write_ methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (VFS-820) FileObject.copyFrom leaves extra bytes when copying from a smaller file
[
https://issues.apache.org/jira/browse/VFS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544435#comment-17544435
]
Anthony Goubard commented on VFS-820:
-
Hi [~ggregory],
Yes, retested with 2.10-SNAPSHOT and it no longer has the problem.
output is now:
{noformat}
short.txt correct
large.txt correct
large.txt correct
{noformat}
> FileObject.copyFrom leaves extra bytes when copying from a smaller file
> ---
>
> Key: VFS-820
> URL: https://issues.apache.org/jira/browse/VFS-820
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
> Environment: Tested on Windows 10
>Reporter: Anthony Goubard
>Priority: Major
>
> If you copy a file using the _FileObject.copyFrom_ method and the destination
> file is larger than the source file, the destination will contain the bytes
> of the source file and the remaining bytes of the destination (See example).
>
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.charset.StandardCharsets;
> import java.nio.file.Files;
> import org.apache.commons.vfs2.FileObject;
> import org.apache.commons.vfs2.Selectors;
> import org.apache.commons.vfs2.VFS;
> public class BugCopyToLargerFile {
> private static final String LARGE_TEXT = "This is a larger text.\nTo show
> that the extra bytes are remining after a copy of a small file";
> private static final String SHORT_TEXT = "This is a short text.";
> public static final void main(String args[]) throws IOException {
> File largeFile = new File(System.getProperty("java.io.tmpdir"),
> "large.txt");
> File shortFile = new File(System.getProperty("java.io.tmpdir"),
> "short.txt");
> FileObject largeFileObject = VFS.getManager().toFileObject(largeFile);
> Files.writeString(largeFile.toPath(), LARGE_TEXT,
> StandardCharsets.UTF_8);
> FileObject shortFileObject = VFS.getManager().toFileObject(shortFile);
> Files.writeString(shortFile.toPath(), SHORT_TEXT,
> StandardCharsets.UTF_8);
> checkFileContent(shortFile, SHORT_TEXT);
> checkFileContent(largeFile, LARGE_TEXT);
> largeFileObject.copyFrom(shortFileObject, Selectors.SELECT_ALL);
> checkFileContent(largeFile, SHORT_TEXT);
> }
> private static void checkFileContent(File file, String content) throws
> IOException {
> String fileContent = Files.readString(file.toPath(),
> StandardCharsets.UTF_8);
> if (fileContent.equals(content)) {
> System.out.println(file.getName() + " correct");
> } else {
> System.out.println(file.getName() + " incorrect content: " +
> fileContent);
> }
> }
> }
> {code}
> {noformat}
> short.txt correct
> large.txt correct
> large.txt incorrect content: This is a short text..
> To show that the extra bytes are remining after a copy of a small file
> {noformat}
> Note that the javadoc of copyFrom contains "If this file does exist, it is
> deleted first." but it doesn't happen in the code.
> One solution would be to delete the file like in _FileObject.moveTo_ method
> {code:java}
> if (exists() && !isSameFile(file)) {
> deleteSelf();
> }
> {code}
> But I think that the problem is in the _DefaultFileContent.write_ methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #264: Bump spotbugs-maven-plugin from 4.6.0.0 to 4.7.0.0
dependabot[bot] opened a new pull request, #264: URL: https://github.com/apache/commons-vfs/pull/264 Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.6.0.0 to 4.7.0.0. Release notes Sourced from https://github.com/spotbugs/spotbugs-maven-plugin/releases;>spotbugs-maven-plugin's releases. Spotbugs-maven-plugin 4.7.0.0 Support spotbugs 4.7.0 Fix https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/68;>#68, note still requires use of a separate plugin, see [here}(https://github.com/spotbugs/spotbugs-maven-plugin#eclipse-m2e-integration) Fix https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/114;>#114 by introducing verify mojo to allow split of analysis and verification into lifecycle phases of one's choosing. One use case for that is running multiple code analyzers at once and only failing the build at a later stage, so that all of them have a chance to run. Verify then in this case just uses an existing file. Updated readme with various informatino about groovy, security manager, and m2e specific to this application considerations that are often asked about. Commits https://github.com/spotbugs/spotbugs-maven-plugin/commit/f08f5990d4173d7b0e64939b0f3d7c9da5da39ca;>f08f599 [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.0.0 https://github.com/spotbugs/spotbugs-maven-plugin/commit/a45eac35b7f2cdb017aec29f107f3637fd023352;>a45eac3 [pom] Skip pdf plugin as it doesn't work well https://github.com/spotbugs/spotbugs-maven-plugin/commit/8e86861cfc3b7f018163e5a542d2e0a3ea6b63ff;>8e86861 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/434;>#434 from hazendaz/spotbugs https://github.com/spotbugs/spotbugs-maven-plugin/commit/bc6bad23c1c078a229510e9e87474e65709725fa;>bc6bad2 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/433;>#433 from spotbugs/dependabot/maven/org.codehaus.plexus-pl... https://github.com/spotbugs/spotbugs-maven-plugin/commit/02a5e756ce695aec8849a9ecc2c5894a47f8a2eb;>02a5e75 [pom] Bump jxr plugin to 3.2.0 https://github.com/spotbugs/spotbugs-maven-plugin/commit/0036acfefcc3729b83874631db84949a2025de7d;>0036acf [pom] Bump findsecbugs IT to 1.12.0 https://github.com/spotbugs/spotbugs-maven-plugin/commit/623220ea4a62b58e965c7b6159929e1bd9b74233;>623220e [pom] Bump IT compiler to 3.10.1 https://github.com/spotbugs/spotbugs-maven-plugin/commit/c21d15a63ab5ada3798c17cff808a6453320d36b;>c21d15a [actions] Use jdk 11 with site for now https://github.com/spotbugs/spotbugs-maven-plugin/commit/c5bff4703bc7146948b52bb2c209dd8442293530;>c5bff47 [pom] Update comment in pom https://github.com/spotbugs/spotbugs-maven-plugin/commit/e9bf09ce01072c610b43325f068527bc0f717cad;>e9bf09c Bump plexus-utils from 3.4.1 to 3.4.2 Additional commits viewable in https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.6.0.0...spotbugs-maven-plugin-4.7.0.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
[GitHub] [commons-vfs] garydgregory merged pull request #262: Bump hadoop.version from 3.3.2 to 3.3.3
garydgregory merged PR #262: URL: https://github.com/apache/commons-vfs/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #265: Bump mockito-core from 4.5.1 to 4.6.0
dependabot[bot] opened a new pull request, #265: URL: https://github.com/apache/commons-vfs/pull/265 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.5.1 to 4.6.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0;>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654;>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654;>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653;>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653;>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651;>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651;>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648;>#2648 : Add support for customising strictness via https://github.com/Mock;>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650;>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650;>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock;>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648;>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648;>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645;>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645;>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643;>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643;>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642;>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642;>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641;>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641;>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640;>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640;>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637;>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637;>mockito/mockito#2637) Bump com.diffplug.spotless from 6.5.1 to 6.5.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2636;>#2636)](https://github-redirect.dependabot.com/mockito/mockito/pull/2636;>mockito/mockito#2636) Bump versions.bytebuddy from 1.12.9 to 1.12.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2635;>#2635)](https://github-redirect.dependabot.com/mockito/mockito/pull/2635;>mockito/mockito#2635) Bump com.diffplug.spotless from 6.5.0 to 6.5.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2632;>#2632)](https://github-redirect.dependabot.com/mockito/mockito/pull/2632;>mockito/mockito#2632) Bump com.diffplug.spotless from 6.4.2 to 6.5.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2631;>#2631)](https://github-redirect.dependabot.com/mockito/mockito/pull/2631;>mockito/mockito#2631) Commits https://github.com/mockito/mockito/commit/93bba1171c7f41585ea8cc9c7ecc140929772124;>93bba11 Bump shipkit-changelog from 1.1.15 to 1.2.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2654;>#2654) https://github.com/mockito/mockito/commit/70cf2d2f48506fca24f16963e9c3d2223898ae5a;>70cf2d2 Add support for customizing strictness via @Mock annotation and `MockSettin... https://github.com/mockito/mockito/commit/6ce278b47367c18373572009e836056c64ac9e97;>6ce278b Bump versions.errorprone from 2.13.1 to 2.14.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2653;>#2653) https://github.com/mockito/mockito/commit/7d2e4cce07a7842eaab3e15351d1f1a89f59e122;>7d2e4cc Bump shipkit-auto-version from 1.1.20 to 1.2.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2651;>#2651)
[GitHub] [commons-vfs] garydgregory merged pull request #263: Bump mockito-core from 4.5.0 to 4.5.1
garydgregory merged PR #263: URL: https://github.com/apache/commons-vfs/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-820) FileObject.copyFrom leaves extra bytes when copying from a smaller file
[
https://issues.apache.org/jira/browse/VFS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544424#comment-17544424
]
Gary D. Gregory commented on VFS-820:
-
Hello [~agoubard]
I think commit {{34efda6b7c932d671012e5ff11c58e1ddd17a95d}} fixed the issue.
Would you test 2.10-SNAPSHOT from
https://repository.apache.org/content/repositories/snapshots/org/apache/commons/
?
> FileObject.copyFrom leaves extra bytes when copying from a smaller file
> ---
>
> Key: VFS-820
> URL: https://issues.apache.org/jira/browse/VFS-820
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
> Environment: Tested on Windows 10
>Reporter: Anthony Goubard
>Priority: Major
>
> If you copy a file using the _FileObject.copyFrom_ method and the destination
> file is larger than the source file, the destination will contain the bytes
> of the source file and the remaining bytes of the destination (See example).
>
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.charset.StandardCharsets;
> import java.nio.file.Files;
> import org.apache.commons.vfs2.FileObject;
> import org.apache.commons.vfs2.Selectors;
> import org.apache.commons.vfs2.VFS;
> public class BugCopyToLargerFile {
> private static final String LARGE_TEXT = "This is a larger text.\nTo show
> that the extra bytes are remining after a copy of a small file";
> private static final String SHORT_TEXT = "This is a short text.";
> public static final void main(String args[]) throws IOException {
> File largeFile = new File(System.getProperty("java.io.tmpdir"),
> "large.txt");
> File shortFile = new File(System.getProperty("java.io.tmpdir"),
> "short.txt");
> FileObject largeFileObject = VFS.getManager().toFileObject(largeFile);
> Files.writeString(largeFile.toPath(), LARGE_TEXT,
> StandardCharsets.UTF_8);
> FileObject shortFileObject = VFS.getManager().toFileObject(shortFile);
> Files.writeString(shortFile.toPath(), SHORT_TEXT,
> StandardCharsets.UTF_8);
> checkFileContent(shortFile, SHORT_TEXT);
> checkFileContent(largeFile, LARGE_TEXT);
> largeFileObject.copyFrom(shortFileObject, Selectors.SELECT_ALL);
> checkFileContent(largeFile, SHORT_TEXT);
> }
> private static void checkFileContent(File file, String content) throws
> IOException {
> String fileContent = Files.readString(file.toPath(),
> StandardCharsets.UTF_8);
> if (fileContent.equals(content)) {
> System.out.println(file.getName() + " correct");
> } else {
> System.out.println(file.getName() + " incorrect content: " +
> fileContent);
> }
> }
> }
> {code}
> {noformat}
> short.txt correct
> large.txt correct
> large.txt incorrect content: This is a short text..
> To show that the extra bytes are remining after a copy of a small file
> {noformat}
> Note that the javadoc of copyFrom contains "If this file does exist, it is
> deleted first." but it doesn't happen in the code.
> One solution would be to delete the file like in _FileObject.moveTo_ method
> {code:java}
> if (exists() && !isSameFile(file)) {
> deleteSelf();
> }
> {code}
> But I think that the problem is in the _DefaultFileContent.write_ methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Deleted] (EMAIL-202) How to Import OST File into Outlook 365?
[
https://issues.apache.org/jira/browse/EMAIL-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert deleted EMAIL-202:
---
> How to Import OST File into Outlook 365?
>
>
> Key: EMAIL-202
> URL: https://issues.apache.org/jira/browse/EMAIL-202
> Project: Commons Email
> Issue Type: New Feature
>Reporter: Rosario Contarino
>Priority: Major
>
> This blog post explains how to import an OST file into Outlook 365,
> overcoming the obstacles that may obstruct the migration process. When
> determining the best migration method, caution should be exercised because
> manual approaches may not perform as expected, resulting in a loss of
> business continuity.
> Let's have a look at the several ways to [Open OST File in
> Outlook|http://www.adviksoft.com/blog/open-ost-file-in-outlook-2016-2019/]
> 365:
> h2. Method 1: Convert OST files to PST files, then upload to Office 365
> This is a two-step indirect approach that includes the following steps:
> To convert an OST file to a PST file, follow these steps.
> In Office 365, you can import a PST file. Converting OST files to PST files
> is the first step.
> # Go to "File" on your Outlook account.
> # Select "Import and Export" from the File menu.
> # Choose the appropriate option.
> # Choose from the following options: Click "Next" after exporting to a file.
> # Click "Next" after selecting the PST option.
> # Choose the emails or folders you want to work with. Select the "Include
> Subfolder" checkbox. "Next" should be selected.
> # Select a location to save the PST file from the drop-down menu.
> # Select the "Replace duplicate with items imported" checkbox and then click
> Next.
> # If necessary, give the PST file a password.
> # To export the PST file, click the "Ok" button.
> The software-based import approach is provided by {*}Advik [Outlook OST
> Converter|http://www.adviksoft.com/ost/converter.html]{*}, on the other hand,
> is more convenient and exact because to its easy-to-use interface.
> h3. *What is the best way to import a PST file into Outlook?*
> The user can import emails, calendar data, and contacts from a PST file into
> Outlook 2019, 2016, or 2013 using the Import/Export function as follows:
> 1: Choose File >> Open & Export >> Import/Export from the File menu.
> 2: Next, select "Import from another software or file."
> 3: Click Next after selecting Outlook Data File (.pst).
> 4: Select the PST file you wish to import by clicking Browse.
> 5: Select the option you wish to employ to manage your duplicate items under
> Options.
> 6: If the PST file has a password set to it, type it in and click OK.
> 7: Select the Import things to the same folder option after selecting the
> folder to import into.
> 8: Click the Finish button.
> This is a direct procedure, which entails exporting converted OST files to
> Office 365 accounts. This solution allows you to export your Outlook data
> while offline. OST to Microsoft Office 365 This solution does not require
> access to an Exchange server.
> The steps below will assist you in making a successful migration:
> # Open and run the software.
> # To pick the OST file, go to the software's main screen and click the
> Browse button. If you don't know where the OST-file is, you can use the Find
> button.
> # To begin the conversion process, click Convert.
> # A preview will be displayed by the software. Validate the information.
> h4. *Conclusion*
> Office 365 includes a number of business apps in addition to the Outlook
> email client, making it more useful for conducting business. Furthermore,
> Microsoft manages Office 365, removing the burden of operating the program
> and the Exchange server from the enterprise.
> The manual and software-based techniques for importing OST to Office 365 were
> emphasized in this free technical tutorial, along with a comparison of the
> methods. Based on the comparison, manual procedures appear to be complex,
> time-consuming, and unlikely to deliver the desired results.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (EMAIL-202) How to Import OST File into Outlook 365?
Rosario Contarino created EMAIL-202:
---
Summary: How to Import OST File into Outlook 365?
Key: EMAIL-202
URL: https://issues.apache.org/jira/browse/EMAIL-202
Project: Commons Email
Issue Type: New Feature
Reporter: Rosario Contarino
This blog post explains how to import an OST file into Outlook 365, overcoming
the obstacles that may obstruct the migration process. When determining the
best migration method, caution should be exercised because manual approaches
may not perform as expected, resulting in a loss of business continuity.
Let's have a look at the several ways to [Open OST File in
Outlook|http://www.adviksoft.com/blog/open-ost-file-in-outlook-2016-2019/] 365:
h2. Method 1: Convert OST files to PST files, then upload to Office 365
This is a two-step indirect approach that includes the following steps:
To convert an OST file to a PST file, follow these steps.
In Office 365, you can import a PST file. Converting OST files to PST files is
the first step.
# Go to "File" on your Outlook account.
# Select "Import and Export" from the File menu.
# Choose the appropriate option.
# Choose from the following options: Click "Next" after exporting to a file.
# Click "Next" after selecting the PST option.
# Choose the emails or folders you want to work with. Select the "Include
Subfolder" checkbox. "Next" should be selected.
# Select a location to save the PST file from the drop-down menu.
# Select the "Replace duplicate with items imported" checkbox and then click
Next.
# If necessary, give the PST file a password.
# To export the PST file, click the "Ok" button.
The software-based import approach is provided by {*}Advik [Outlook OST
Converter|http://www.adviksoft.com/ost/converter.html]{*}, on the other hand,
is more convenient and exact because to its easy-to-use interface.
h3. *What is the best way to import a PST file into Outlook?*
The user can import emails, calendar data, and contacts from a PST file into
Outlook 2019, 2016, or 2013 using the Import/Export function as follows:
1: Choose File >> Open & Export >> Import/Export from the File menu.
2: Next, select "Import from another software or file."
3: Click Next after selecting Outlook Data File (.pst).
4: Select the PST file you wish to import by clicking Browse.
5: Select the option you wish to employ to manage your duplicate items under
Options.
6: If the PST file has a password set to it, type it in and click OK.
7: Select the Import things to the same folder option after selecting the
folder to import into.
8: Click the Finish button.
This is a direct procedure, which entails exporting converted OST files to
Office 365 accounts. This solution allows you to export your Outlook data while
offline. OST to Microsoft Office 365 This solution does not require access to
an Exchange server.
The steps below will assist you in making a successful migration:
# Open and run the software.
# To pick the OST file, go to the software's main screen and click the Browse
button. If you don't know where the OST-file is, you can use the Find button.
# To begin the conversion process, click Convert.
# A preview will be displayed by the software. Validate the information.
h4. *Conclusion*
Office 365 includes a number of business apps in addition to the Outlook email
client, making it more useful for conducting business. Furthermore, Microsoft
manages Office 365, removing the burden of operating the program and the
Exchange server from the enterprise.
The manual and software-based techniques for importing OST to Office 365 were
emphasized in this free technical tutorial, along with a comparison of the
methods. Based on the comparison, manual procedures appear to be complex,
time-consuming, and unlikely to deliver the desired results.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (VFS-820) FileObject.copyFrom leaves extra bytes when copying from a smaller file
Anthony Goubard created VFS-820:
---
Summary: FileObject.copyFrom leaves extra bytes when copying from
a smaller file
Key: VFS-820
URL: https://issues.apache.org/jira/browse/VFS-820
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.9.0
Environment: Tested on Windows 10
Reporter: Anthony Goubard
If you copy a file using the _FileObject.copyFrom_ method and the destination
file is larger than the source file, the destination will contain the bytes of
the source file and the remaining bytes of the destination (See example).
{code:java}
import java.io.File;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import org.apache.commons.vfs2.FileObject;
import org.apache.commons.vfs2.Selectors;
import org.apache.commons.vfs2.VFS;
public class BugCopyToLargerFile {
private static final String LARGE_TEXT = "This is a larger text.\nTo show
that the extra bytes are remining after a copy of a small file";
private static final String SHORT_TEXT = "This is a short text.";
public static final void main(String args[]) throws IOException {
File largeFile = new File(System.getProperty("java.io.tmpdir"),
"large.txt");
File shortFile = new File(System.getProperty("java.io.tmpdir"),
"short.txt");
FileObject largeFileObject = VFS.getManager().toFileObject(largeFile);
Files.writeString(largeFile.toPath(), LARGE_TEXT,
StandardCharsets.UTF_8);
FileObject shortFileObject = VFS.getManager().toFileObject(shortFile);
Files.writeString(shortFile.toPath(), SHORT_TEXT,
StandardCharsets.UTF_8);
checkFileContent(shortFile, SHORT_TEXT);
checkFileContent(largeFile, LARGE_TEXT);
largeFileObject.copyFrom(shortFileObject, Selectors.SELECT_ALL);
checkFileContent(largeFile, SHORT_TEXT);
}
private static void checkFileContent(File file, String content) throws
IOException {
String fileContent = Files.readString(file.toPath(),
StandardCharsets.UTF_8);
if (fileContent.equals(content)) {
System.out.println(file.getName() + " correct");
} else {
System.out.println(file.getName() + " incorrect content: " +
fileContent);
}
}
}
{code}
{noformat}
short.txt correct
large.txt correct
large.txt incorrect content: This is a short text..
To show that the extra bytes are remining after a copy of a small file
{noformat}
Note that the javadoc of copyFrom contains "If this file does exist, it is
deleted first." but it doesn't happen in the code.
One solution would be to delete the file like in _FileObject.moveTo_ method
{code:java}
if (exists() && !isSameFile(file)) {
deleteSelf();
}
{code}
But I think that the problem is in the _DefaultFileContent.write_ methods
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
