[GitHub] [commons-geometry] darkma773r commented on pull request #199: Remove unnecessary validations. It's not null when it reaches it.
darkma773r commented on PR #199: URL: https://github.com/apache/commons-geometry/pull/199#issuecomment-1257409768 Yes, these changes look good. However, I'm confused since, unless I'm missing something, master already has these changes: - https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/oned/RegionBSPTree1D.java#L204 - https://github.com/apache/commons-geometry/blob/master/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/RegionBSPTree1S.java#L247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?focusedWorklogId=811977=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811977
]
ASF GitHub Bot logged work on CSV-290:
--
Author: ASF GitHub Bot
Created on: 26/Sep/22 02:20
Start Date: 26/Sep/22 02:20
Worklog Time Spent: 10m
Work Description: angusdev commented on PR #265:
URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257389351
Please hold this PR.
Seems need to escape when writing , but no escape when reading PostgreSQL
produced CSV. May need to create a separate CSVFormat (e.g.
POSTGRESQL_CSV_READ), need sometime to test the behaviour.
Issue Time Tracking
---
Worklog Id: (was: 811977)
Time Spent: 50m (was: 40m)
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:398)
> at Test.main(Test.java:25)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-csv] angusdev commented on pull request #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats
angusdev commented on PR #265: URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257389351 Please hold this PR. Seems need to escape when writing , but no escape when reading PostgreSQL produced CSV. May need to create a separate CSVFormat (e.g. POSTGRESQL_CSV_READ), need sometime to test the behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?focusedWorklogId=811976=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811976
]
ASF GitHub Bot logged work on CSV-290:
--
Author: ASF GitHub Bot
Created on: 26/Sep/22 02:12
Start Date: 26/Sep/22 02:12
Worklog Time Spent: 10m
Work Description: angusdev commented on PR #265:
URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257383391
I can't test previous versions of PostgreSQL. But it is pretty safe to say
that it applies to all versions.
Postgresql support export to CVS since version 8.0 (year 2005,
https://www.postgresql.org/docs/8.0/release-8-0.html)
In the documentation of 8.1
(https://www.postgresql.org/docs/8.1/sql-copy.html), it didn't state clearly
but implied that the CSV export will not escape special characters. The
backslash escape is used for import data from text file (COPY FROM) only.
For text format (tab delimited), there is no reason to quote the text.
Issue Time Tracking
---
Worklog Id: (was: 811976)
Time Spent: 40m (was: 0.5h)
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:398)
> at Test.main(Test.java:25)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-csv] angusdev commented on pull request #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats
angusdev commented on PR #265: URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257383391 I can't test previous versions of PostgreSQL. But it is pretty safe to say that it applies to all versions. Postgresql support export to CVS since version 8.0 (year 2005, https://www.postgresql.org/docs/8.0/release-8-0.html) In the documentation of 8.1 (https://www.postgresql.org/docs/8.1/sql-copy.html), it didn't state clearly but implied that the CSV export will not escape special characters. The backslash escape is used for import data from text file (COPY FROM) only. For text format (tab delimited), there is no reason to quote the text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] ArdenL-Liu commented on a diff in pull request #61: [Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException
ArdenL-Liu commented on code in PR #61:
URL: https://github.com/apache/commons-exec/pull/61#discussion_r979508469
##
src/main/java/org/apache/commons/exec/CommandLine.java:
##
@@ -398,6 +398,7 @@ private static String[] translateCommandline(final String
toProcess) {
*
* @param dirtyExecutable the executable
* @return the platform-specific executable string
+ * @throws IllegalArgumentException If dirtyExecutable is null or empty
Review Comment:
Hi garydgregory,
I reviewed CommandLine.java again, and added the javadoc to the constructor
CommandLine(String).
you can review it.
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?focusedWorklogId=811956=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811956
]
ASF GitHub Bot logged work on CSV-290:
--
Author: ASF GitHub Bot
Created on: 25/Sep/22 23:11
Start Date: 25/Sep/22 23:11
Worklog Time Spent: 10m
Work Description: garydgregory commented on PR #265:
URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257300816
Hi @angusdev
Thank you for the PR.
Does the version of PostgreSQL matter?
Issue Time Tracking
---
Worklog Id: (was: 811956)
Time Spent: 0.5h (was: 20m)
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:398)
> at Test.main(Test.java:25)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-csv] garydgregory commented on pull request #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats
garydgregory commented on PR #265: URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257300816 Hi @angusdev Thank you for the PR. Does the version of PostgreSQL matter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609259#comment-17609259
]
Angus C commented on CSV-290:
-
https://github.com/apache/commons-csv/pull/265
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:398)
> at Test.main(Test.java:25)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?focusedWorklogId=811954=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811954
]
ASF GitHub Bot logged work on CSV-290:
--
Author: ASF GitHub Bot
Created on: 25/Sep/22 22:10
Start Date: 25/Sep/22 22:10
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #265:
URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257289564
#
[Codecov](https://codecov.io/gh/apache/commons-csv/pull/265?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Report
> Merging
[#265](https://codecov.io/gh/apache/commons-csv/pull/265?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
(d992e26) into
[master](https://codecov.io/gh/apache/commons-csv/commit/048d507de95b3aaabac5ecc29878390601b47ff3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
(048d507) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@Coverage Diff@@
## master #265 +/- ##
=
Coverage 97.34% 97.34%
Complexity 535 535
=
Files11 11
Lines 1169 1169
Branches205 205
=
Hits 1138 1138
Misses 18 18
Partials 13 13
```
| [Impacted
Files](https://codecov.io/gh/apache/commons-csv/pull/265?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...rc/main/java/org/apache/commons/csv/CSVFormat.java](https://codecov.io/gh/apache/commons-csv/pull/265/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVkZvcm1hdC5qYXZh)
| `97.16% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Issue Time Tracking
---
Worklog Id: (was: 811954)
Time Spent: 20m (was: 10m)
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
>
[GitHub] [commons-csv] codecov-commenter commented on pull request #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats
codecov-commenter commented on PR #265: URL: https://github.com/apache/commons-csv/pull/265#issuecomment-1257289564 # [Codecov](https://codecov.io/gh/apache/commons-csv/pull/265?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#265](https://codecov.io/gh/apache/commons-csv/pull/265?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d992e26) into [master](https://codecov.io/gh/apache/commons-csv/commit/048d507de95b3aaabac5ecc29878390601b47ff3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (048d507) will **not change** coverage. > The diff coverage is `100.00%`. ```diff @@Coverage Diff@@ ## master #265 +/- ## = Coverage 97.34% 97.34% Complexity 535 535 = Files11 11 Lines 1169 1169 Branches205 205 = Hits 1138 1138 Misses 18 18 Partials 13 13 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-csv/pull/265?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rc/main/java/org/apache/commons/csv/CSVFormat.java](https://codecov.io/gh/apache/commons-csv/pull/265/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVkZvcm1hdC5qYXZh) | `97.16% <100.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?focusedWorklogId=811953=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811953
]
ASF GitHub Bot logged work on CSV-290:
--
Author: ASF GitHub Bot
Created on: 25/Sep/22 21:54
Start Date: 25/Sep/22 21:54
Worklog Time Spent: 10m
Work Description: angusdev opened a new pull request, #265:
URL: https://github.com/apache/commons-csv/pull/265
I tested in psql 14.5 Homebrew in Mac M1.
CSVFormat.POSTGRESQL_CSV - special characters are not escaped.
CSVFormat.POSTGRESQL_TEXT - values are not quoted.
```sql
drop table COMMONS_CSV_PSQL_TEST;
create table COMMONS_CSV_PSQL_TEST (ID INTEGER, COL1 VARCHAR, COL2 VARCHAR,
COL3 VARCHAR, COL4 VARCHAR);
insert into COMMONS_CSV_PSQL_TEST select 1, 'abc', 'test line 1' || chr(10)
|| 'test line 2', null, '';
insert into COMMONS_CSV_PSQL_TEST select 2, 'xyz', '\b:' || chr(8) || ' \n:'
|| chr(10) || ' \r:' || chr(13), 'a', 'b';
insert into COMMONS_CSV_PSQL_TEST values (3, 'a', 'b,c,d', '"quoted"', 'e');
copy COMMONS_CSV_PSQL_TEST TO '/tmp/psql.csv' WITH (FORMAT CSV);
copy COMMONS_CSV_PSQL_TEST TO '/tmp/psql.tsv';
```
```
cat /tmp/psql.csv
1,abc,"test line 1
test line 2",,""
2,xyz,"\b:^H \n:
\r:^M",a,b
3,a,"b,c,d","""quoted""",e
```
```
cat /tmp/psql.tsv
1abctest line 1\ntest line 2 \N
2xyz\\b:\b \\n:\n \\r:\r a b
3a b,c,d "quoted"e
```
Issue Time Tracking
---
Worklog Id: (was: 811953)
Remaining Estimate: 0h
Time Spent: 10m
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:398)
> at Test.main(Test.java:25)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-csv] angusdev opened a new pull request, #265: CSV-290 - Fix the wrong assumptions in PostgreSQL formats
angusdev opened a new pull request, #265: URL: https://github.com/apache/commons-csv/pull/265 I tested in psql 14.5 Homebrew in Mac M1. CSVFormat.POSTGRESQL_CSV - special characters are not escaped. CSVFormat.POSTGRESQL_TEXT - values are not quoted. ```sql drop table COMMONS_CSV_PSQL_TEST; create table COMMONS_CSV_PSQL_TEST (ID INTEGER, COL1 VARCHAR, COL2 VARCHAR, COL3 VARCHAR, COL4 VARCHAR); insert into COMMONS_CSV_PSQL_TEST select 1, 'abc', 'test line 1' || chr(10) || 'test line 2', null, ''; insert into COMMONS_CSV_PSQL_TEST select 2, 'xyz', '\b:' || chr(8) || ' \n:' || chr(10) || ' \r:' || chr(13), 'a', 'b'; insert into COMMONS_CSV_PSQL_TEST values (3, 'a', 'b,c,d', '"quoted"', 'e'); copy COMMONS_CSV_PSQL_TEST TO '/tmp/psql.csv' WITH (FORMAT CSV); copy COMMONS_CSV_PSQL_TEST TO '/tmp/psql.tsv'; ``` ``` cat /tmp/psql.csv 1,abc,"test line 1 test line 2",,"" 2,xyz,"\b:^H \n: \r:^M",a,b 3,a,"b,c,d","""quoted""",e ``` ``` cat /tmp/psql.tsv 1abctest line 1\ntest line 2 \N 2xyz\\b:\b \\n:\n \\r:\r a b 3a b,c,d "quoted"e ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CSV-290) Produced CSV using PostgreSQL format cannot be read
[
https://issues.apache.org/jira/browse/CSV-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609257#comment-17609257
]
Angus C commented on CSV-290:
-
I tested in psql 14.5 Homebrew in Mac M1.
for {{{}CSVFormat.POSTGRESQL_CSV{}}}, special characters are not escaped.
for {{{}CSVFormat.POSTGRESQL_TEXT{}}}, values are not quoted.
{code:sql}
create table COMMONS_CSV_PSQL_TEST (ID INTEGER, COL1 VARCHAR, COL2 VARCHAR,
COL3 VARCHAR, COL4 VARCHAR);
insert into COMMONS_CSV_PSQL_TEST select 1, 'abc', 'test line 1' || chr(10) ||
'test line 2', null, '';
insert into COMMONS_CSV_PSQL_TEST select 2, 'xyz', '\b:' || chr(8) || ' \n:' ||
chr(10) || ' \r:' || chr(13), 'a', 'b';
insert into COMMONS_CSV_PSQL_TEST values (3, 'a', 'b,c,d', '"quoted"', 'e');
copy COMMONS_CSV_PSQL_TEST to '/tmp/psql.csv' with (FORMAT CSV);
copy COMMONS_CSV_PSQL_TEST to '/tmp/psql.tsv';{code}
{code:java}
cat /tmp/psql.csv
1,abc,"test line 1
test line 2",,""
2,xyz,"\b:^H \n:
\r:^M",a,b
3,a,"b,c,d","""quoted""",e{code}
{code:java}
cat /tmp/psql.tsv
1 abc test line 1\ntest line 2 \N
2 xyz \\b:\b \\n:\n \\r:\r a b
3 a b,c,d "quoted" e{code}
> Produced CSV using PostgreSQL format cannot be read
> ---
>
> Key: CSV-290
> URL: https://issues.apache.org/jira/browse/CSV-290
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.6, 1.9.0
>Reporter: Anatoliy Artemenko
>Priority: Major
>
> {code:java}
> // code placeholder
> {code}
> CSV, produced using printer:
>
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> cannot be be read with same format parser:
>
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
>
> To reproduce:
>
> {code:java}
> StringWriter sw = new StringWriter();
> CSVPrinter printer = new CSVPrinter(sw,
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> printer.printRecord("column1", "column2");
> printer.printRecord("v11", "v12");
> printer.printRecord("v21", "v22");
> printer.close();
> CSVParser parser = new CSVParser(new StringReader(sw.toString()),
> CSVFormat.POSTGRESQL_CSV.withFirstRecordAsHeader());
> System.out.println("headers: " +
> Arrays.equals(parser.getHeaderNames().toArray(), new String[] {"column1",
> "column2"}));
> Iterator i = parser.iterator();
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v11", "v12"}));
> System.out.println("row: " + Arrays.equals(i.next().toList().toArray(), new
> String[] {"v21", "v22"}));{code}
> I'd expect the above code to work, but it fails:
> {code:java}
> java.io.IOException: (startline 1) EOF reached before encapsulated token
> finishedjava.io.IOException: (startline 1) EOF reached before encapsulated
> token finished
> at org.apache.commons.csv.Lexer.parseEncapsulatedToken(Lexer.java:371)
> at org.apache.commons.csv.Lexer.nextToken(Lexer.java:285)
> at org.apache.commons.csv.CSVParser.nextRecord(CSVParser.java:701)
> at org.apache.commons.csv.CSVParser.createHeaders(CSVParser.java:480)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:432)
> at org.apache.commons.csv.CSVParser.(CSVParser.java:398)
> at Test.main(Test.java:25)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-fileupload] garydgregory merged pull request #167: Bump commons-parent from 53 to 54
garydgregory merged PR #167: URL: https://github.com/apache/commons-fileupload/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] closed pull request #89: Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2.0
dependabot[bot] closed pull request #89: Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2.0 URL: https://github.com/apache/commons-email/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] closed pull request #88: Bump spotbugs from 4.2.2 to 4.7.2
dependabot[bot] closed pull request #88: Bump spotbugs from 4.2.2 to 4.7.2 URL: https://github.com/apache/commons-email/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #89: Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2.0
dependabot[bot] commented on PR #89: URL: https://github.com/apache/commons-email/pull/89#issuecomment-1257212030 Looks like com.github.spotbugs:spotbugs-maven-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #88: Bump spotbugs from 4.2.2 to 4.7.2
dependabot[bot] commented on PR #88: URL: https://github.com/apache/commons-email/pull/88#issuecomment-1257212028 Looks like com.github.spotbugs:spotbugs is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] garydgregory commented on pull request #93: Bump commons-parent from 53 to 54
garydgregory commented on PR #93: URL: https://github.com/apache/commons-email/pull/93#issuecomment-1257211708 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] codecov-commenter commented on pull request #89: Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2.0
codecov-commenter commented on PR #89: URL: https://github.com/apache/commons-email/pull/89#issuecomment-1257209897 # [Codecov](https://codecov.io/gh/apache/commons-email/pull/89?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#89](https://codecov.io/gh/apache/commons-email/pull/89?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (89c76dc) into [master](https://codecov.io/gh/apache/commons-email/commit/5420eb80a7d36af2193cb519a3b42766f46f551b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5420eb8) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #89 +/- ## = Coverage 65.71% 65.71% Complexity 304 304 = Files18 18 Lines 1053 1053 Branches138 138 = Hits692 692 Misses 282 282 Partials 79 79 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] aherbert commented on pull request #341: Fix flaky test occurred in 'CollectionBagTest.testCollectionToArray2'
aherbert commented on PR #341: URL: https://github.com/apache/commons-collections/pull/341#issuecomment-1257208824 Please add the fixes to this PR since they are all related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] codecov-commenter commented on pull request #93: Bump commons-parent from 53 to 54
codecov-commenter commented on PR #93: URL: https://github.com/apache/commons-email/pull/93#issuecomment-1257206407 # [Codecov](https://codecov.io/gh/apache/commons-email/pull/93?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#93](https://codecov.io/gh/apache/commons-email/pull/93?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0116a61) into [master](https://codecov.io/gh/apache/commons-email/commit/8a2d4ac4bb514f1b6b13dbd48ee9ba24a8a74d15?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8a2d4ac) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #93 +/- ## = Coverage 65.71% 65.71% Complexity 304 304 = Files18 18 Lines 1053 1053 Branches138 138 = Hits692 692 Misses 282 282 Partials 79 79 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request, #93: Bump commons-parent from 53 to 54
dependabot[bot] opened a new pull request, #93: URL: https://github.com/apache/commons-email/pull/93 Bumps [commons-parent](https://github.com/apache/commons-parent) from 53 to 54. Changelog Sourced from https://github.com/apache/commons-parent/blob/master/RELEASE-NOTES.txt;>commons-parent's changelog. Apache Commons Parent 54 RELEASE NOTES The Apache Commons Parent team is pleased to announce the release of Apache Commons Parent 54. The Apache Commons Parent POM provides common settings for all Apache Commons components. Version 54: SBOMs, drop JDepend, replace FindBugs with SpotBugs, dependency bumps. Changes in this version include: New features: o Add .vscode/* to RAT excludes. o Add property commons.javadoc18.java.link. Thanks to Dependabot. o Add JUnit BOM to dependency management. o Add CycloneDX SBOM generation https://github-redirect.dependabot.com/apache/commons-parent/issues/122;>#122. Thanks to Steve Springett. o Add SPDX SBOM generation. Thanks to Gary Gregory. Changes: o Bump actions/cache from 3 to 3.0.8, https://github-redirect.dependabot.com/apache/commons-parent/issues/118;>#118. Thanks to Gary Gregory, Dependabot. o Bump actions/checkout from 3 to 3.0.2. Thanks to Gary Gregory. o Bump actions/setup-java from 2 to 3. Thanks to Gary Gregory. o Bump apache from 24 to 27 https://github-redirect.dependabot.com/apache/commons-parent/issues/112;>#112, https://github-redirect.dependabot.com/apache/commons-parent/issues/127;>#127. Thanks to Dependabot. o Bump build-helper-maven-plugin from 3.2.0 to 3.3.0 https://github-redirect.dependabot.com/apache/commons-parent/issues/105;>#105. Thanks to Dependabot. o Bump jacoco-maven-plugin from 0.8.7 to 0.8.8. Thanks to Gary Gregory. o Bump spotbugs from 4.5.3 to 4.7.2 https://github-redirect.dependabot.com/apache/commons-parent/issues/120;>#120, https://github-redirect.dependabot.com/apache/commons-parent/issues/143;>#143. Thanks to Gary Gregory, Dependabot. o Bump spotbugs-maven-plugin from 4.5.3.0 to 4.7.2.0, https://github-redirect.dependabot.com/apache/commons-parent/issues/129;>#129, https://github-redirect.dependabot.com/apache/commons-parent/issues/142;>#142. Thanks to Gary Gregory, Dependabot. o Bump maven-project-info-reports-plugin from 3.2.2 to 3.4.1 https://github-redirect.dependabot.com/apache/commons-parent/issues/107;>#107, https://github-redirect.dependabot.com/apache/commons-parent/issues/128;>#128. Thanks to Dependabot. o Bump maven-site-plugin from 3.11.0 to 3.12.1 https://github-redirect.dependabot.com/apache/commons-parent/issues/108;>#108, https://github-redirect.dependabot.com/apache/commons-parent/issues/132;>#132. Fix [WARNING] An issue has occurred with apache-rat-plugin:0.14:rat report, skipping LinkageError org.apache.rat.mp.RatReportMojo.generate(Lorg/codehaus/doxia/sink/Sink;Ljava/util/Locale;)V, Thanks to Dependabot. o Bump maven-bundle-plugin from 5.1.4 to 5.1.8, https://github-redirect.dependabot.com/apache/commons-parent/issues/111;>#111, https://github-redirect.dependabot.com/apache/commons-parent/issues/126;>#126, https://github-redirect.dependabot.com/apache/commons-parent/issues/133;>#133. Thanks to Gary Gregory, Dependabot. o Bump net.sourceforge.pmd:pmd-* from 6.44.0 to 6.49.0, https://github-redirect.dependabot.com/apache/commons-parent/issues/138;>#138. Thanks to Gary Gregory, Dependabot. o Bump maven-jxr-plugin from 3.1.1 to 3.3.0 https://github-redirect.dependabot.com/apache/commons-parent/issues/110;>#110, https://github-redirect.dependabot.com/apache/commons-parent/issues/136;>#136. Thanks to Dependabot. o Bump maven-javadoc-plugin from 3.3.2 to 3.4.1 https://github-redirect.dependabot.com/apache/commons-parent/issues/114;>#114. Thanks to Dependabot, Gary Gregory. o Bump apache-rat from 0.13 to 0.15. Thanks to Gary Gregory. o Bump biz.aQute.bndlib from 6.2.0 to 6.3.1. Thanks to Gary Gregory. o Bump maven-pmd-plugin from 3.16.0 to 3.19.0 https://github-redirect.dependabot.com/apache/commons-parent/issues/141;>#141. Thanks to Gary Gregory, Dependabot. o Bump maven-enforcer-plugin from 3.0.0 to 3.1.0. Thanks to Gary Gregory. o Bump org.apache.maven.wagon:wagon-ssh 3.5.1 to 3.5.2. Thanks to Gary Gregory. o Bump maven-assembly-plugin from 3.3.0 to 3.4.2 https://github-redirect.dependabot.com/apache/commons-parent/issues/123;>#123. Thanks to Dependabot, Gary Gregory. o
[GitHub] [commons-email] dependabot[bot] commented on pull request #92: Bump slf4j-jdk14 from 1.7.7 to 2.0.2
dependabot[bot] commented on PR #92: URL: https://github.com/apache/commons-email/pull/92#issuecomment-1257205252 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] garydgregory closed pull request #92: Bump slf4j-jdk14 from 1.7.7 to 2.0.2
garydgregory closed pull request #92: Bump slf4j-jdk14 from 1.7.7 to 2.0.2 URL: https://github.com/apache/commons-email/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] garydgregory commented on pull request #92: Bump slf4j-jdk14 from 1.7.7 to 2.0.2
garydgregory commented on PR #92: URL: https://github.com/apache/commons-email/pull/92#issuecomment-1257205248 To laster, pick up a different dependabot check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] codecov-commenter commented on pull request #135: Bump spotbugs-maven-plugin from 4.4.2 to 4.7.2.0
codecov-commenter commented on PR #135: URL: https://github.com/apache/commons-dbutils/pull/135#issuecomment-1257205042 # [Codecov](https://codecov.io/gh/apache/commons-dbutils/pull/135?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#135](https://codecov.io/gh/apache/commons-dbutils/pull/135?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2ecd135) into [master](https://codecov.io/gh/apache/commons-dbutils/commit/05bcc4bf6e38e73b9224261a5b1aa0544ad9b0b8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (05bcc4b) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #135 +/- ## = Coverage 61.99% 61.99% Complexity 404 404 = Files39 39 Lines 1463 1463 Branches122 122 = Hits907 907 Misses 503 503 Partials 53 53 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] commented on pull request #36: Bump ossf/scorecard-action from 1.1.2 to 2.0.3
dependabot[bot] commented on PR #36: URL: https://github.com/apache/commons-digester/pull/36#issuecomment-1257204592 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory closed pull request #36: Bump ossf/scorecard-action from 1.1.2 to 2.0.3
garydgregory closed pull request #36: Bump ossf/scorecard-action from 1.1.2 to 2.0.3 URL: https://github.com/apache/commons-digester/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] garydgregory commented on pull request #36: Bump ossf/scorecard-action from 1.1.2 to 2.0.3
garydgregory commented on PR #36: URL: https://github.com/apache/commons-digester/pull/36#issuecomment-1257204580 Close, needed Apache Infra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] garydgregory merged pull request #55: Bump commons-parent from 53 to 54
garydgregory merged PR #55: URL: https://github.com/apache/commons-daemon/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DBCP-586) Make BasicDataSource.getConnectionPool() public to access GenericObjectPool#toString()/getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated DBCP-586:
-
Summary: Make BasicDataSource.getConnectionPool() public to access
GenericObjectPool#toString()/getStatsString() (was: BasicDataSource should
support GenericObjectPool->getStatsString())
> Make BasicDataSource.getConnectionPool() public to access
> GenericObjectPool#toString()/getStatsString()
> ---
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Fix For: 2.10.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DBCP-586) Make BasicDataSource.getConnectionPool() public to access GenericObjectPool.toString()/getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated DBCP-586:
-
Summary: Make BasicDataSource.getConnectionPool() public to access
GenericObjectPool.toString()/getStatsString() (was: Make
BasicDataSource.getConnectionPool() public to access
GenericObjectPool#toString()/getStatsString())
> Make BasicDataSource.getConnectionPool() public to access
> GenericObjectPool.toString()/getStatsString()
> ---
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Fix For: 2.10.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608901#comment-17608901
]
Gary D. Gregory edited comment on DBCP-586 at 9/25/22 12:54 PM:
-FTR to be made public:-
* -org.apache.commons.pool2.impl.BaseGenericObjectPool.getStatsString()-
* -org.apache.commons.pool2.impl.GenericKeyedObjectPool.getStatsString()-
* -org.apache.commons.pool2.impl.GenericObjectPool.getStatsString()-
was (Author: garydgregory):
FTR to be made public:
* org.apache.commons.pool2.impl.BaseGenericObjectPool.getStatsString()
* org.apache.commons.pool2.impl.GenericKeyedObjectPool.getStatsString()
* org.apache.commons.pool2.impl.GenericObjectPool.getStatsString()
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Fix For: 2.10.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved DBCP-586.
--
Fix Version/s: 2.10.0
Resolution: Fixed
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Fix For: 2.10.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609157#comment-17609157
]
Gary D. Gregory commented on DBCP-586:
--
Hello [~Tux12Fun]
The method {{BasicDataSource.getConnectionPool()}} is now public. Please try
git master or a snapshot build by pointing Maven to the snapshot repo at
https://repository.apache.org/content/repositories/snapshots/
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-collections] Partha-SUST16 commented on pull request #341: Fix flaky test occurred in 'CollectionBagTest.testCollectionToArray2'
Partha-SUST16 commented on PR #341: URL: https://github.com/apache/commons-collections/pull/341#issuecomment-1257148269 I have found some more flaky tests for `HashBagTest.testCollectionToArray2`, `PredicatedBagTest.testCollectionToArray2`, `SynchronizedBagTest.testCollectionToArray2`, `TransformedBagTest.testCollectionToArray2`, `UnmodifiableBagTest.testCollectionToArray2`. All of this is caused for the same reason (using `HashBag`) internally. & their fix is also same. Should I make individual pr for all of them or include here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] codecov-commenter commented on pull request #341: Fix flaky test occurred in 'CollectionBagTest.testCollectionToArray2'
codecov-commenter commented on PR #341: URL: https://github.com/apache/commons-collections/pull/341#issuecomment-1257147706 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/341?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#341](https://codecov.io/gh/apache/commons-collections/pull/341?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (58c5f0b) into [master](https://codecov.io/gh/apache/commons-collections/commit/474713f727f49707a4ac77ed737d0205d22152ee?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (474713f) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #341 +/- ## = Coverage 85.93% 85.93% Complexity 4669 4669 = Files 289 289 Lines 1344513445 Branches 1977 1977 = Hits 1155411554 Misses 1327 1327 Partials564 564 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] Partha-SUST16 opened a new pull request, #341: Fix flaky test occurred in 'CollectionBagTest.testCollectionToArray2'
Partha-SUST16 opened a new pull request, #341: URL: https://github.com/apache/commons-collections/pull/341 ### What is the purpose of this PR - This PR fixes the flaky test `org.apache.commons.collections4.bag.CollectionBagTest.testCollectionToArray2` - The mentioned test may fail or pass without changes made to the source code when it is run in different JVMs due to `HashMap`'s non-deterministic iteration order. ### Why the test fails - As the `CollectionBagTest` uses `HashBag` as its `collection` which uses `HashMap` internally and as per `Java 8` documentation, the ordering of `HashMap` is not constant, so assigning the same hashmap as an array to different objects can change the ordering. So when comparing these two arrays with `assertEquals` the test may fail as their ordering can be different. ### Reproduce the test failure - Run the test with 'NonDex' maven plugin. The command to recreate the flaky test failure is ` mvn -pl . edu.illinois:nondex-maven-plugin:1.1.2:nondex -debug -Dtest=org.apache.commons.collections4.bag.CollectionBagTest#testCollectionToArray2` - Fixing the flaky test now may prevent flaky test failures in future Java versions. ### Expected result - The tests should run successfully when run with 'NonDex' maven with the same command for recreating the flaky test. ### Actual Result - We get the failure: `[ERROR] org.apache.commons.collections4.bag.CollectionBagTest.testCollectionToArray2 Time elapsed: 0.025 s <<< FAILURE! junit.framework.AssertionFailedError: toArrays should be equal expected:<[10, 6.0, 11, 4, Seven, Eight, 5.0, 15, 2, 12, 16, Thirteen, null, , Three, Nine, One, One, 14]> but was:<[, null, Seven, 2, 5.0, 12, 10, 11, 14, 16, One, One, Nine, Eight, Thirteen, 15, 4, 6.0, Three]> ` ### Fix - Override the `getIterationBehaviour()' method from `AbstractCollectionTest` and return `UNORDERED` in `CollectionBagTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
