[GitHub] [commons-fileupload] dependabot[bot] closed pull request #169: Bump actions/cache from 3.0.8 to 3.0.9
dependabot[bot] closed pull request #169: Bump actions/cache from 3.0.8 to 3.0.9 URL: https://github.com/apache/commons-fileupload/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #169: Bump actions/cache from 3.0.8 to 3.0.9
dependabot[bot] commented on PR #169: URL: https://github.com/apache/commons-fileupload/pull/169#issuecomment-1265829516 Superseded by #170. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request, #170: Bump actions/cache from 3.0.8 to 3.0.10
dependabot[bot] opened a new pull request, #170: URL: https://github.com/apache/commons-fileupload/pull/170 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.8 to 3.0.10. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.10 Fix a bug with sorting inputs. Update definition for restore-keys in README.md v3.0.9 Enhanced the warning message for cache unavailability in case of GHES. Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. Releases 3.0.0 Updated minimum runner version support from node 12 - node 16 3.0.1 Added support for caching from GHES 3.5. Fixed download issue for files 2GB during restore. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) 3.0.4 Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (https://github-redirect.dependabot.com/actions/cache/issues/689;>issue) 3.0.5 Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (https://github-redirect.dependabot.com/actions/cache/pull/834;>PR) 3.0.6 Fixed https://github-redirect.dependabot.com/actions/cache/issues/809;>#809 - zstd -d: no such file or directory error Fixed https://github-redirect.dependabot.com/actions/cache/issues/833;>#833 - cache doesn't work with github workspace directory 3.0.7 Fixed https://github-redirect.dependabot.com/actions/cache/issues/810;>#810 - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour. Commits https://github.com/actions/cache/commit/56461b9eb0f8438fd15c7a9968e3c9ebb18ceff1;>56461b9 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/931;>#931 from ELHoussineT/patch-1 https://github.com/actions/cache/commit/f85d12c3b2c1550a31f2682b45455046b431fed5;>f85d12c Merge branch 'main' into patch-1 https://github.com/actions/cache/commit/98044e486f42920b65b6a2c2d0031e6e19dd0879;>98044e4 Update README.md https://github.com/actions/cache/commit/edc49897ecb897dea729ecab47992b4bfad847d4;>edc4989 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/942;>#942 from actions/vsvipul/fix-sort https://github.com/actions/cache/commit/68d96986b532923ef04d50de9cbaef6241839806;>68d9698 Remove sort logic from inputs https://github.com/actions/cache/commit/ac8075791e805656e71b4ba23325ace9e3421120;>ac80757 Actions/cache release 3.0.9 (https://github-redirect.dependabot.com/actions/cache/issues/930;>#930) https://github.com/actions/cache/commit/0ff05979343fa0bc49c99a4fea5dae9f0964e94f;>0ff0597 Update examples.md (https://github-redirect.dependabot.com/actions/cache/issues/920;>#920) https://github.com/actions/cache/commit/12681847c623a9274356751fdf0a63576ff3f846;>1268184 Update README.md (https://github-redirect.dependabot.com/actions/cache/issues/936;>#936) https://github.com/actions/cache/commit/3238536a48bfc94aa1be336fef0d93ad1725d57e;>3238536 Update README.md https://github.com/actions/cache/commit/1a78ace1311f934d8a2b1bc050fa0c40b7207833;>1a78ace Updated the GHES warning message (https://github-redirect.dependabot.com/actions/cache/issues/925;>#925) Additional commits viewable in https://github.com/actions/cache/compare/v3.0.8...v3.0.10;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/cache=github_actions=3.0.8=3.0.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this
[GitHub] [commons-exec] dependabot[bot] opened a new pull request, #67: Bump actions/cache from 3.0.8 to 3.0.10
dependabot[bot] opened a new pull request, #67: URL: https://github.com/apache/commons-exec/pull/67 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.8 to 3.0.10. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.10 Fix a bug with sorting inputs. Update definition for restore-keys in README.md v3.0.9 Enhanced the warning message for cache unavailability in case of GHES. Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. Releases 3.0.0 Updated minimum runner version support from node 12 - node 16 3.0.1 Added support for caching from GHES 3.5. Fixed download issue for files 2GB during restore. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) 3.0.4 Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (https://github-redirect.dependabot.com/actions/cache/issues/689;>issue) 3.0.5 Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (https://github-redirect.dependabot.com/actions/cache/pull/834;>PR) 3.0.6 Fixed https://github-redirect.dependabot.com/actions/cache/issues/809;>#809 - zstd -d: no such file or directory error Fixed https://github-redirect.dependabot.com/actions/cache/issues/833;>#833 - cache doesn't work with github workspace directory 3.0.7 Fixed https://github-redirect.dependabot.com/actions/cache/issues/810;>#810 - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour. Commits https://github.com/actions/cache/commit/56461b9eb0f8438fd15c7a9968e3c9ebb18ceff1;>56461b9 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/931;>#931 from ELHoussineT/patch-1 https://github.com/actions/cache/commit/f85d12c3b2c1550a31f2682b45455046b431fed5;>f85d12c Merge branch 'main' into patch-1 https://github.com/actions/cache/commit/98044e486f42920b65b6a2c2d0031e6e19dd0879;>98044e4 Update README.md https://github.com/actions/cache/commit/edc49897ecb897dea729ecab47992b4bfad847d4;>edc4989 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/942;>#942 from actions/vsvipul/fix-sort https://github.com/actions/cache/commit/68d96986b532923ef04d50de9cbaef6241839806;>68d9698 Remove sort logic from inputs https://github.com/actions/cache/commit/ac8075791e805656e71b4ba23325ace9e3421120;>ac80757 Actions/cache release 3.0.9 (https://github-redirect.dependabot.com/actions/cache/issues/930;>#930) https://github.com/actions/cache/commit/0ff05979343fa0bc49c99a4fea5dae9f0964e94f;>0ff0597 Update examples.md (https://github-redirect.dependabot.com/actions/cache/issues/920;>#920) https://github.com/actions/cache/commit/12681847c623a9274356751fdf0a63576ff3f846;>1268184 Update README.md (https://github-redirect.dependabot.com/actions/cache/issues/936;>#936) https://github.com/actions/cache/commit/3238536a48bfc94aa1be336fef0d93ad1725d57e;>3238536 Update README.md https://github.com/actions/cache/commit/1a78ace1311f934d8a2b1bc050fa0c40b7207833;>1a78ace Updated the GHES warning message (https://github-redirect.dependabot.com/actions/cache/issues/925;>#925) Additional commits viewable in https://github.com/actions/cache/compare/v3.0.8...v3.0.10;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/cache=github_actions=3.0.8=3.0.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and
[GitHub] [commons-exec] dependabot[bot] closed pull request #66: Bump actions/cache from 3.0.8 to 3.0.9
dependabot[bot] closed pull request #66: Bump actions/cache from 3.0.8 to 3.0.9 URL: https://github.com/apache/commons-exec/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] commented on pull request #66: Bump actions/cache from 3.0.8 to 3.0.9
dependabot[bot] commented on PR #66: URL: https://github.com/apache/commons-exec/pull/66#issuecomment-1265757382 Superseded by #67. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] dependabot[bot] opened a new pull request, #240: Bump actions/cache from 3.0.9 to 3.0.10
dependabot[bot] opened a new pull request, #240: URL: https://github.com/apache/commons-imaging/pull/240 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.9 to 3.0.10. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.10 Fix a bug with sorting inputs. Update definition for restore-keys in README.md Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. Releases 3.0.0 Updated minimum runner version support from node 12 - node 16 3.0.1 Added support for caching from GHES 3.5. Fixed download issue for files 2GB during restore. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) 3.0.4 Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (https://github-redirect.dependabot.com/actions/cache/issues/689;>issue) 3.0.5 Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (https://github-redirect.dependabot.com/actions/cache/pull/834;>PR) 3.0.6 Fixed https://github-redirect.dependabot.com/actions/cache/issues/809;>#809 - zstd -d: no such file or directory error Fixed https://github-redirect.dependabot.com/actions/cache/issues/833;>#833 - cache doesn't work with github workspace directory 3.0.7 Fixed https://github-redirect.dependabot.com/actions/cache/issues/810;>#810 - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour. 3.0.8 Fix zstd not working for windows on gnu tar in issues https://github-redirect.dependabot.com/actions/cache/issues/888;>#888 and https://github-redirect.dependabot.com/actions/cache/issues/891;>#891. Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable SEGMENT_DOWNLOAD_TIMEOUT_MIN. Default is 60 minutes. Commits https://github.com/actions/cache/commit/56461b9eb0f8438fd15c7a9968e3c9ebb18ceff1;>56461b9 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/931;>#931 from ELHoussineT/patch-1 https://github.com/actions/cache/commit/f85d12c3b2c1550a31f2682b45455046b431fed5;>f85d12c Merge branch 'main' into patch-1 https://github.com/actions/cache/commit/98044e486f42920b65b6a2c2d0031e6e19dd0879;>98044e4 Update README.md https://github.com/actions/cache/commit/edc49897ecb897dea729ecab47992b4bfad847d4;>edc4989 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/942;>#942 from actions/vsvipul/fix-sort https://github.com/actions/cache/commit/68d96986b532923ef04d50de9cbaef6241839806;>68d9698 Remove sort logic from inputs https://github.com/actions/cache/commit/3238536a48bfc94aa1be336fef0d93ad1725d57e;>3238536 Update README.md See full diff in https://github.com/actions/cache/compare/v3.0.9...v3.0.10;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/cache=github_actions=3.0.9=3.0.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) -
[GitHub] [commons-bcel] garydgregory commented on pull request #50: Bump javaee-api from 6.0 to 8.0.1
garydgregory commented on PR #50: URL: https://github.com/apache/commons-bcel/pull/50#issuecomment-1265323949 A test calls for the specific version of the dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] commented on pull request #50: Bump javaee-api from 6.0 to 8.0.1
dependabot[bot] commented on PR #50: URL: https://github.com/apache/commons-bcel/pull/50#issuecomment-1265324005 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory closed pull request #50: Bump javaee-api from 6.0 to 8.0.1
garydgregory closed pull request #50: Bump javaee-api from 6.0 to 8.0.1 URL: https://github.com/apache/commons-bcel/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] aherbert merged pull request #341: Fix flaky test occurred in 'CollectionBagTest.testCollectionToArray2'
aherbert merged PR #341: URL: https://github.com/apache/commons-collections/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] closed pull request #38: Bump actions/cache from 3.0.3 to 3.0.8
dependabot[bot] closed pull request #38: Bump actions/cache from 3.0.3 to 3.0.8 URL: https://github.com/apache/commons-chain/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #38: Bump actions/cache from 3.0.3 to 3.0.8
dependabot[bot] commented on PR #38: URL: https://github.com/apache/commons-chain/pull/38#issuecomment-1264941064 Superseded by #39. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] opened a new pull request, #39: Bump actions/cache from 3.0.3 to 3.0.9
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/commons-chain/pull/39 Bumps [actions/cache](https://github.com/actions/cache) from 3.0.3 to 3.0.9. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.9 Enhanced the warning message for cache unavailability in case of GHES. v3.0.8 What's Changed Fix zstd not working for windows on gnu tar in issues. Allow users to provide a custom timeout as input for aborting cache segment download using the environment variable SEGMENT_DOWNLOAD_TIMEOUT_MIN. Default is 60 minutes. v3.0.7 What's Changed Fix for the download stuck problem has been added in actions/cache for users who were intermittently facing the issue. As part of this fix, new timeout has been introduced in the download step to stop the download if it doesn't complete within an hour and run the rest of the workflow without erroring out. v3.0.6 What's Changed Add example for clojure lein project dependencies by https://github.com/shivamarora1;>@shivamarora1 in PR https://github-redirect.dependabot.com/actions/cache/pull/835;>actions/cache#835 Update toolkit's cache npm module to latest. Bump cache version to v3.0.6 by https://github.com/pdotl;>@pdotl in PR https://github-redirect.dependabot.com/actions/cache/pull/887;>actions/cache#887 Fix issue https://github-redirect.dependabot.com/actions/cache/issues/809;>#809 where cache save/restore was failing for Amazon Linux 2 runners due to older tar version Fix issue https://github-redirect.dependabot.com/actions/cache/issues/833;>#833 where cache save was not working for caching github workspace directory New Contributors https://github.com/shivamarora1;>@shivamarora1 made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/835;>actions/cache#835 https://github.com/pdotl;>@pdotl made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/887;>actions/cache#887 Full Changelog: https://github.com/actions/cache/compare/v3...v3.0.6;>https://github.com/actions/cache/compare/v3...v3.0.6 v3.0.5 Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. v3.0.4 In this release, we have fixed the tar creation error while trying to create it with path as ~/ home folder on ubuntu-latest. Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) 3.0.4 Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (https://github-redirect.dependabot.com/actions/cache/issues/689;>issue) 3.0.5 Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (https://github-redirect.dependabot.com/actions/cache/pull/834;>PR) 3.0.6 Fixed https://github-redirect.dependabot.com/actions/cache/issues/809;>#809 - zstd -d: no such file or directory error Fixed https://github-redirect.dependabot.com/actions/cache/issues/833;>#833 - cache doesn't work with github workspace directory 3.0.7 Fixed https://github-redirect.dependabot.com/actions/cache/issues/810;>#810 - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour. 3.0.8 Fix zstd not working for windows on gnu tar in issues https://github-redirect.dependabot.com/actions/cache/issues/888;>#888 and https://github-redirect.dependabot.com/actions/cache/issues/891;>#891. Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable SEGMENT_DOWNLOAD_TIMEOUT_MIN. Default is 60 minutes. 3.0.9 Enhanced the warning message for cache unavailablity in case of GHES. Commits https://github.com/actions/cache/commit/ac8075791e805656e71b4ba23325ace9e3421120;>ac80757 Actions/cache release 3.0.9 (https://github-redirect.dependabot.com/actions/cache/issues/930;>#930) https://github.com/actions/cache/commit/0ff05979343fa0bc49c99a4fea5dae9f0964e94f;>0ff0597 Update examples.md (https://github-redirect.dependabot.com/actions/cache/issues/920;>#920) https://github.com/actions/cache/commit/12681847c623a9274356751fdf0a63576ff3f846;>1268184 Update README.md (https://github-redirect.dependabot.com/actions/cache/issues/936;>#936) https://github.com/actions/cache/commit/1a78ace1311f934d8a2b1bc050fa0c40b7207833;>1a78ace Updated the GHES warning message
[jira] [Commented] (CSV-274) CSVParser.iterator() does not iterate over result set as expected.
[ https://issues.apache.org/jira/browse/CSV-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613153#comment-17613153 ] Peter Hull commented on CSV-274: OK I've added PR https://github.com/apache/commons-csv/pull/270 > CSVParser.iterator() does not iterate over result set as expected. > -- > > Key: CSV-274 > URL: https://issues.apache.org/jira/browse/CSV-274 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.8 >Reporter: David Guiney >Priority: Major > > To return a stream of `CSVRecords` in a Spliterators, I need to call > `CSVParser.getRecords().iterator()`. I worry that the `getRecords()` will > load the records from the parser into memory, before creating the iterator > which can be a problem with large CSV files. > My code: > {code:java} > public Stream convertFileToMaps(Path path) throws IOException { > try (CSVParser parser = CSVParser.parse(path, > Charset.defaultCharset(), CSVFormat.RFC4180 > .withFirstRecordAsHeader())) { > return > StreamSupport.stream(Spliterators.spliteratorUnknownSize(parser.iterator(), > 0), false); > } > } > {code} > and: > {code:java} > public Stream convertFileToMaps(Path path) throws IOException { > try (CSVParser parser = CSVParser.parse(path, > Charset.defaultCharset(), CSVFormat.RFC4180 > .withFirstRecordAsHeader())) { > return StreamSupport.stream(parser.spliterator(), false); > } > } > {code} > When I collect the results of my method, it gives me > {code:java} > [] > {code} > > If I replace `parser.iterator()` with `parser.getRecords().iterator()` then I > get the desired results. Is the iterator not meant to be an iterator of the > list of `CSVRecord`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-bcel] garydgregory merged pull request #151: Use Math.max
garydgregory merged PR #151: URL: https://github.com/apache/commons-bcel/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #152: Simplify boolean expressions
garydgregory merged PR #152: URL: https://github.com/apache/commons-bcel/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-782) SequenceReader should close readers when its close method is called
[ https://issues.apache.org/jira/browse/IO-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613096#comment-17613096 ] matteodg commented on IO-782: - See pull request at [https://github.com/apache/commons-io/pull/391] > SequenceReader should close readers when its close method is called > --- > > Key: IO-782 > URL: https://issues.apache.org/jira/browse/IO-782 > Project: Commons IO > Issue Type: Bug > Components: Streams/Writers >Affects Versions: 2.11.0 >Reporter: matteodg >Priority: Major > > {{SequenceReader.close()}} method should close readers. > This is to be compliant with common practice of any {{Reader}} decorator, > like for example {{BufferedReader}} is doing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IO-782) SequenceReader should close readers when its close method is called
matteodg created IO-782: --- Summary: SequenceReader should close readers when its close method is called Key: IO-782 URL: https://issues.apache.org/jira/browse/IO-782 Project: Commons IO Issue Type: Bug Components: Streams/Writers Affects Versions: 2.11.0 Reporter: matteodg {{SequenceReader.close()}} method should close readers. This is to be compliant with common practice of any {{Reader}} decorator, like for example {{BufferedReader}} is doing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MATH-1650) Add clamped spline interpolation
[ https://issues.apache.org/jira/browse/MATH-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Scholz updated MATH-1650: - Description: We would like to contribute a new _clamped_ spline interpolation function in addition to the already available unclamped spline function. Our new {{ClampedSplineInterpolator}} is based on the same textbook as the original {{{}SplineInterpolator{}}}. The clamped spline offers additional parameterisation of starting and ending slopes (1st derivatives) as boundary conditions in order to provide more flexibility in spline creation. In this patch we follow the approach of subclassing the original {{SplineInterpolator}} and simply overloading it's {{interpolate()}} function by these two additional parameters. Is this an acceptable way or does the community recommend a different design approach? After clarifying the basic implementation approach we could also supply necessary tests etc. and finally contribute everything via ordinary GitHub pull request. Refer to our post on the dev mailing list: https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8 was: We would like to contribute a new _clamped_ spline interpolation function in addition to the already available unclamped spline function. Our new {{ClampedSplineInterpolator}} is based on the same textbook as the original {{{}SplineInterpolator{}}}. The clamped spline offers additional parameterisation of starting and ending slopes (1st derivatives) as boundary conditions in order to provide more flexibility in spline creation. In this patch we follow the approach of subclassing the original {{SplineInterpolator}} and simply overloading it's {{interpolate()}} function by these two additional parameters. Is this an acceptable way or does the community recommend a different design approach? After clarifying the basic implementation approach we could also supply necessary tests etc. and finally contribute everything via ordinary GitHub pull request. Refer to our post on the dev mailing list: [https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8|[https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8]] > Add clamped spline interpolation > > > Key: MATH-1650 > URL: https://issues.apache.org/jira/browse/MATH-1650 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.X >Reporter: Michael Scholz >Priority: Minor > Labels: Polynomials, interpolation, spline > Attachments: 2022-10-05_ClampedSplineInterpolator.patch > > > We would like to contribute a new _clamped_ spline interpolation function in > addition to the already available unclamped spline function. Our new > {{ClampedSplineInterpolator}} is based on the same textbook as the original > {{{}SplineInterpolator{}}}. The clamped spline offers additional > parameterisation of starting and ending slopes (1st derivatives) as boundary > conditions in order to provide more flexibility in spline creation. > In this patch we follow the approach of subclassing the original > {{SplineInterpolator}} and simply overloading it's {{interpolate()}} function > by these two additional parameters. Is this an acceptable way or does the > community recommend a different design approach? > After clarifying the basic implementation approach we could also supply > necessary tests etc. and finally contribute everything via ordinary GitHub > pull request. > Refer to our post on the dev mailing list: > https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MATH-1650) Add clamped spline interpolation
Michael Scholz created MATH-1650: Summary: Add clamped spline interpolation Key: MATH-1650 URL: https://issues.apache.org/jira/browse/MATH-1650 Project: Commons Math Issue Type: New Feature Affects Versions: 4.X Reporter: Michael Scholz Attachments: 2022-10-05_ClampedSplineInterpolator.patch We would like to contribute a new _clamped_ spline interpolation function in addition to the already available unclamped spline function. Our new {{ClampedSplineInterpolator}} is based on the same textbook as the original {{{}SplineInterpolator{}}}. The clamped spline offers additional parameterisation of starting and ending slopes (1st derivatives) as boundary conditions in order to provide more flexibility in spline creation. In this patch we follow the approach of subclassing the original {{SplineInterpolator}} and simply overloading it's {{interpolate()}} function by these two additional parameters. Is this an acceptable way or does the community recommend a different design approach? After clarifying the basic implementation approach we could also supply necessary tests etc. and finally contribute everything via ordinary GitHub pull request. Refer to our post on the dev mailing list: [https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8|[https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8]] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CSV-274) CSVParser.iterator() does not iterate over result set as expected.
[ https://issues.apache.org/jira/browse/CSV-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612966#comment-17612966 ] Gary D. Gregory commented on CSV-274: - Hi [~peterhull90] and all, If you have any ideas on improving the documentation or code, please do feel free to open a PR on GitHub :) > CSVParser.iterator() does not iterate over result set as expected. > -- > > Key: CSV-274 > URL: https://issues.apache.org/jira/browse/CSV-274 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.8 >Reporter: David Guiney >Priority: Major > > To return a stream of `CSVRecords` in a Spliterators, I need to call > `CSVParser.getRecords().iterator()`. I worry that the `getRecords()` will > load the records from the parser into memory, before creating the iterator > which can be a problem with large CSV files. > My code: > {code:java} > public Stream convertFileToMaps(Path path) throws IOException { > try (CSVParser parser = CSVParser.parse(path, > Charset.defaultCharset(), CSVFormat.RFC4180 > .withFirstRecordAsHeader())) { > return > StreamSupport.stream(Spliterators.spliteratorUnknownSize(parser.iterator(), > 0), false); > } > } > {code} > and: > {code:java} > public Stream convertFileToMaps(Path path) throws IOException { > try (CSVParser parser = CSVParser.parse(path, > Charset.defaultCharset(), CSVFormat.RFC4180 > .withFirstRecordAsHeader())) { > return StreamSupport.stream(parser.spliterator(), false); > } > } > {code} > When I collect the results of my method, it gives me > {code:java} > [] > {code} > > If I replace `parser.iterator()` with `parser.getRecords().iterator()` then I > get the desired results. Is the iterator not meant to be an iterator of the > list of `CSVRecord`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (POOL-409) BasicDataSource should support GenericObjectPool->getStatsString()
[ https://issues.apache.org/jira/browse/POOL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved POOL-409. -- Fix Version/s: 2.12.0 Resolution: Fixed > BasicDataSource should support GenericObjectPool->getStatsString() > -- > > Key: POOL-409 > URL: https://issues.apache.org/jira/browse/POOL-409 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.11.1 >Reporter: Thomas Freller >Priority: Major > Labels: improvement > Fix For: 2.12.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > Hello, > I'm developing a Application that is running on a default JRE without an > Webserver/JMX. > For optimizing Database connections it would be very useful if i could access > > BasicDataSource->GenericObjectPool->{*}getStatsString(){*} > > I don't see any reason why this Method is protected and not public in > GenericObjectPool. > Then BasicDataSource shoud provide a method getStatsString() or the values > that represent the statistic data. > > If there is any other easy way to access this data within my Java Code I'll > implement this if you could give me an example how to get this working > easily. I don't want do configure any jmx stuff. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (POOL-409) BasicDataSource should support GenericObjectPool->getStatsString()
[ https://issues.apache.org/jira/browse/POOL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612964#comment-17612964 ] Gary D. Gregory commented on POOL-409: -- The stack trace is normal, it is saved in an instance variable and printed ("creationStackTrace=...") > BasicDataSource should support GenericObjectPool->getStatsString() > -- > > Key: POOL-409 > URL: https://issues.apache.org/jira/browse/POOL-409 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.11.1 >Reporter: Thomas Freller >Priority: Major > Labels: improvement > Original Estimate: 2h > Remaining Estimate: 2h > > Hello, > I'm developing a Application that is running on a default JRE without an > Webserver/JMX. > For optimizing Database connections it would be very useful if i could access > > BasicDataSource->GenericObjectPool->{*}getStatsString(){*} > > I don't see any reason why this Method is protected and not public in > GenericObjectPool. > Then BasicDataSource shoud provide a method getStatsString() or the values > that represent the statistic data. > > If there is any other easy way to access this data within my Java Code I'll > implement this if you could give me an example how to get this working > easily. I don't want do configure any jmx stuff. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (POOL-407) Threads get stuck when idleObjects list is empty.
[ https://issues.apache.org/jira/browse/POOL-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612963#comment-17612963 ] Gary D. Gregory commented on POOL-407: -- Ah, gotcha. Thanks for the pointer. > Threads get stuck when idleObjects list is empty. > - > > Key: POOL-407 > URL: https://issues.apache.org/jira/browse/POOL-407 > Project: Commons Pool > Issue Type: Bug >Affects Versions: 2.8.1 >Reporter: Sarthak Shukla >Priority: Major > > While borrowing object from pool, threads are getting stuck. I initialised > the pool size as 1. And had 3 threads created. First thread enters > borrowObject method, since there are no idle objects to poll from, it will > create one object and move forward. > {code:java} > p = (PooledObject)this.idleObjects.pollFirst(); > if (p == null) { > p = this.create(); > if (p != null) { > create = true; > } > } {code} > The other two threads will also follow same path and check for idle > objects(there are none), will try to create one object but the pool size is > set to 1. Thus, the two threads will move forward and enter > *idleObjects.takeFirst()* function. Value of blockWhenExhausted is true and > borrowMaxWaitMillis is -1 as we don't want timeout. > {code:java} > if (blockWhenExhausted) { >if (p == null) { > if (borrowMaxWaitMillis < 0L) { >p = (PooledObject)this.idleObjects.takeFirst(); > } else { >p = (PooledObject)this.idleObjects.pollFirst(borrowMaxWaitMillis, > TimeUnit.MILLISECONDS); > } >} >if (p == null) { > throw new NoSuchElementException("Timeout waiting for idle object"); >} > }{code} > Now, the main thread does *this.factory.activateObject(p);* and object gets > activated. Now, when the validation is checked *validate = > this.factory.validateObject(p);* it comes out to be false as provider might > have been disconnected. > So, the object is destroyed by calling *this.destroy(p);* > {code:java} > private void destroy(PooledObject toDestroy) throws Exception { > toDestroy.invalidate(); > this.idleObjects.remove(toDestroy); > this.allObjects.remove(new > BaseGenericObjectPool.IdentityWrapper(toDestroy.getObject())); > try { > this.factory.destroyObject(toDestroy); > } finally { > this.destroyedCount.incrementAndGet(); > this.createCount.decrementAndGet(); > } > }{code} > The object which was created is now destroyed and removed from idleObject and > allObjects list. Now, the other two threads are still waiting to take object > from idle objects list but there are no object present. Hence, the two > threads are in wait state for infinite period and the application waits > forever until we kill the process. > {code:java} > public E takeFirst() throws InterruptedException { >this.lock.lock(); >Object var2; >try { > Object x; > while((x = this.unlinkFirst()) == null) { > this.notEmpty.await(); > } > var2 = x; > } finally { > this.lock.unlock(); > } > return var2; > } {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CSV-274) CSVParser.iterator() does not iterate over result set as expected.
[ https://issues.apache.org/jira/browse/CSV-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612947#comment-17612947 ] Peter Hull commented on CSV-274: I think this is not a bug that should be fixed in the code, but maybe this kind of usage could be warned about in the docs? As I understand it the issue is that the parser gets closed as control exits the try-with-resources block, hence the iterator and the stream that wraps it will not return any more records. I also made this mistake, and I felt it was not immediately obvious why my code was wrong. > CSVParser.iterator() does not iterate over result set as expected. > -- > > Key: CSV-274 > URL: https://issues.apache.org/jira/browse/CSV-274 > Project: Commons CSV > Issue Type: Bug > Components: Parser >Affects Versions: 1.8 >Reporter: David Guiney >Priority: Major > > To return a stream of `CSVRecords` in a Spliterators, I need to call > `CSVParser.getRecords().iterator()`. I worry that the `getRecords()` will > load the records from the parser into memory, before creating the iterator > which can be a problem with large CSV files. > My code: > {code:java} > public Stream convertFileToMaps(Path path) throws IOException { > try (CSVParser parser = CSVParser.parse(path, > Charset.defaultCharset(), CSVFormat.RFC4180 > .withFirstRecordAsHeader())) { > return > StreamSupport.stream(Spliterators.spliteratorUnknownSize(parser.iterator(), > 0), false); > } > } > {code} > and: > {code:java} > public Stream convertFileToMaps(Path path) throws IOException { > try (CSVParser parser = CSVParser.parse(path, > Charset.defaultCharset(), CSVFormat.RFC4180 > .withFirstRecordAsHeader())) { > return StreamSupport.stream(parser.spliterator(), false); > } > } > {code} > When I collect the results of my method, it gives me > {code:java} > [] > {code} > > If I replace `parser.iterator()` with `parser.getRecords().iterator()` then I > get the desired results. Is the iterator not meant to be an iterator of the > list of `CSVRecord`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (POOL-409) BasicDataSource should support GenericObjectPool->getStatsString()
[ https://issues.apache.org/jira/browse/POOL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612890#comment-17612890 ] Thomas Freller commented on POOL-409: - Tested your Snapshot and it seams looking good. {code:java} 10:15:23.128 [main] INFO ssl_worker.SSL_Worker - Current ThreadPool ActiveCount: 0 / CorePoolSize: 2 / LargestPoolSize: 2 / MaximumPoolSize: 30 / PoolSize: 2 / TaskCount: 8 / QueueSize: 0 / QueueRemainingCapacity: 900 10:15:23.130 [main] INFO ssl_worker.SSL_Worker - Current DBPool Stats Active (current/max): 0/1 Idle (min/current/max): 1/1/1 GenericObjectPool [maxTotal=1, blockWhenExhausted=true, maxWaitDuration=PT1M30S, lifo=true, fairness=false, testOnCreate=false, testOnBorrow=true, testOnReturn=false, testWhileIdle=false, durationBetweenEvictionRuns=PT-0.001S, numTestsPerEvictionRun=3, minEvictableIdleTimeDuration=PT30M, softMinEvictableIdleTimeDuration=PT-0.001S, evictionPolicy=org.apache.commons.pool2.impl.DefaultEvictionPolicy@39d9314d, closeLock=java.lang.Object@b978d10, closed=false, evictionLock=java.lang.Object@5b7a8434, evictor=null, evictionIterator=null, factoryClassLoader=java.lang.ref.WeakReference@5c45d770, oname=null, creationStackTrace=java.lang.Exception at org.apache.commons.pool2.impl.BaseGenericObjectPool.(BaseGenericObjectPool.java:415) at org.apache.commons.pool2.impl.GenericObjectPool.(GenericObjectPool.java:146) at org.apache.commons.dbcp2.BasicDataSource.createObjectPool(BasicDataSource.java:588) at org.apache.commons.dbcp2.BasicDataSource.createConnectionPool(BasicDataSource.java:487) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:539) at org.apache.commons.dbcp2.BasicDataSource.setLogWriter(BasicDataSource.java:2153) at db_pool.MySQLConPool.(MySQLConPool.java:65) at ssl_worker.SSL_Worker.main(SSL_Worker.java:184) , borrowedCount=174, returnedCount=174, createdCount=3, destroyedCount=2, destroyedByEvictorCount=0, destroyedByBorrowValidationCount=0, activeTimes=StatsStore [[12, 15, 20, 15, 21, 14024, 2, 2, 3, 17, 0, 15, 13, 12, 15, 12, 13, 13, 12, 12, 11, 16, 12, 10, 9, 14, 10, 11, 1, 0, 22, 14, 0, 13, 1, 14, 16, 12, 17, 17, 15, 17, 16, 16, 19, 13, 11, 13, 15, 13, 11, 20, 12, 12, 12, 15, 15, 15, 13, 13, 14, 12, 12, 13, 16, 13, 15, 13, 13, 15, 14020, 1, 1, 1]], size=100, index=74], idleTimes=StatsStore [[0, 0, 0, 1, 0, 0, 0, 1, 1, 208524, 0, 1, 7, 3, 2, 2, 3, 2, 2, 2, 2, 2, 2, 2, 2, 11, 4, 17, 2, 2, 76936, 0, 0, 1, 0, 2, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1]], size=100, index=74], waitTimes=StatsStore [[11, 11, 30, 19, 12, 20, 14022, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 0, 1, 0, 17, 15, 1, 16, 0, 12, 12, 12, 14, 27, 12, 16, 14, 14, 17, 12, 9, 11, 14, 11, 10, 18, 10, 10, 10, 14, 14, 13, 10, 11, 12, 8, 10, 12, 15, 11, 14, 11, 12, 13, 14018, 1, 1]], size=100, index=74], maxBorrowWaitDuration=PT14.032S, swallowedExceptionListener=org.apache.commons.dbcp2.SwallowedExceptionLogger@2ce6c6ec, factoryType=null, maxIdle=1, minIdle=1, factory=org.apache.commons.dbcp2.PoolableConnectionFactory@1bae316d, allObjects={IdentityWrapper [instance=189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J]=Object: 189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J, State: IDLE}, createCount=1, idleObjects=[Object: 189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J, State: IDLE], abandonedConfig=null] {code} The Stacktrace is as it should be or? because the Key-Field is creationStackTrace. So for me its okay. > BasicDataSource should support GenericObjectPool->getStatsString() > -- > > Key: POOL-409 > URL: https://issues.apache.org/jira/browse/POOL-409 > Project: Commons Pool > Issue Type: Improvement >Affects Versions: 2.11.1 >Reporter: Thomas Freller >Priority: Major > Labels: improvement > Original Estimate: 2h > Remaining Estimate: 2h > > Hello, > I'm developing a Application that is running on a default JRE without an > Webserver/JMX. > For optimizing Database connections it would be very useful if i could access > > BasicDataSource->GenericObjectPool->{*}getStatsString(){*} > > I don't see any reason why this Method is protected and not public in > GenericObjectPool. > Then BasicDataSource shoud provide a method getStatsString() or the values > that represent the statistic data. > > If there is any other easy way to access this data within my Java Code I'll > implement this if you could give me an example how to get this working > easily. I don't want do configure any jmx
[jira] (DBCP-586) Make BasicDataSource.getConnectionPool() public to access GenericObjectPool.toString()/getStatsString()
[ https://issues.apache.org/jira/browse/DBCP-586 ] Thomas Freller deleted comment on DBCP-586: - was (Author: JIRAUSER283078): Seams looking good. {code:java} 10:15:23.128 [main] INFO ssl_worker.SSL_Worker - Current ThreadPool ActiveCount: 0 / CorePoolSize: 2 / LargestPoolSize: 2 / MaximumPoolSize: 30 / PoolSize: 2 / TaskCount: 8 / QueueSize: 0 / QueueRemainingCapacity: 900 10:15:23.130 [main] INFO ssl_worker.SSL_Worker - Current DBPool Stats Active (current/max): 0/1 Idle (min/current/max): 1/1/1 GenericObjectPool [maxTotal=1, blockWhenExhausted=true, maxWaitDuration=PT1M30S, lifo=true, fairness=false, testOnCreate=false, testOnBorrow=true, testOnReturn=false, testWhileIdle=false, durationBetweenEvictionRuns=PT-0.001S, numTestsPerEvictionRun=3, minEvictableIdleTimeDuration=PT30M, softMinEvictableIdleTimeDuration=PT-0.001S, evictionPolicy=org.apache.commons.pool2.impl.DefaultEvictionPolicy@39d9314d, closeLock=java.lang.Object@b978d10, closed=false, evictionLock=java.lang.Object@5b7a8434, evictor=null, evictionIterator=null, factoryClassLoader=java.lang.ref.WeakReference@5c45d770, oname=null, creationStackTrace=java.lang.Exception at org.apache.commons.pool2.impl.BaseGenericObjectPool.(BaseGenericObjectPool.java:415) at org.apache.commons.pool2.impl.GenericObjectPool.(GenericObjectPool.java:146) at org.apache.commons.dbcp2.BasicDataSource.createObjectPool(BasicDataSource.java:588) at org.apache.commons.dbcp2.BasicDataSource.createConnectionPool(BasicDataSource.java:487) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:539) at org.apache.commons.dbcp2.BasicDataSource.setLogWriter(BasicDataSource.java:2153) at db_pool.MySQLConPool.(MySQLConPool.java:65) at ssl_worker.SSL_Worker.main(SSL_Worker.java:184) , borrowedCount=174, returnedCount=174, createdCount=3, destroyedCount=2, destroyedByEvictorCount=0, destroyedByBorrowValidationCount=0, activeTimes=StatsStore [[12, 15, 20, 15, 21, 14024, 2, 2, 3, 17, 0, 15, 13, 12, 15, 12, 13, 13, 12, 12, 11, 16, 12, 10, 9, 14, 10, 11, 1, 0, 22, 14, 0, 13, 1, 14, 16, 12, 17, 17, 15, 17, 16, 16, 19, 13, 11, 13, 15, 13, 11, 20, 12, 12, 12, 15, 15, 15, 13, 13, 14, 12, 12, 13, 16, 13, 15, 13, 13, 15, 14020, 1, 1, 1]], size=100, index=74], idleTimes=StatsStore [[0, 0, 0, 1, 0, 0, 0, 1, 1, 208524, 0, 1, 7, 3, 2, 2, 3, 2, 2, 2, 2, 2, 2, 2, 2, 11, 4, 17, 2, 2, 76936, 0, 0, 1, 0, 2, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1]], size=100, index=74], waitTimes=StatsStore [[11, 11, 30, 19, 12, 20, 14022, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 0, 1, 0, 17, 15, 1, 16, 0, 12, 12, 12, 14, 27, 12, 16, 14, 14, 17, 12, 9, 11, 14, 11, 10, 18, 10, 10, 10, 14, 14, 13, 10, 11, 12, 8, 10, 12, 15, 11, 14, 11, 12, 13, 14018, 1, 1]], size=100, index=74], maxBorrowWaitDuration=PT14.032S, swallowedExceptionListener=org.apache.commons.dbcp2.SwallowedExceptionLogger@2ce6c6ec, factoryType=null, maxIdle=1, minIdle=1, factory=org.apache.commons.dbcp2.PoolableConnectionFactory@1bae316d, allObjects={IdentityWrapper [instance=189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J]=Object: 189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J, State: IDLE}, createCount=1, idleObjects=[Object: 189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J, State: IDLE], abandonedConfig=null] {code} The Stacktrace is as it should be or? because the Key-Field is creationStackTrace. So for me its okay. > Make BasicDataSource.getConnectionPool() public to access > GenericObjectPool.toString()/getStatsString() > --- > > Key: DBCP-586 > URL: https://issues.apache.org/jira/browse/DBCP-586 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.9.0 >Reporter: Thomas Freller >Priority: Major > Labels: improvement > Fix For: 2.10.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > Hello, > I'm developing a Application that is running on a default JRE without an > Webserver/JMX. > For optimizing Database connections it would be very useful if i could access > > BasicDataSource->GenericObjectPool->{*}getStatsString(){*} > > I don't see any reason why this Method is protected and not public in > GenericObjectPool. > Then BasicDataSource shoud provide a method getStatsString() or the values > that represent the statistic data. > > If there is any other easy way to access this data within my Java Code I'll > implement this if you could give me an example how to get this working > easily. I
[jira] [Commented] (DBCP-586) Make BasicDataSource.getConnectionPool() public to access GenericObjectPool.toString()/getStatsString()
[ https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612889#comment-17612889 ] Thomas Freller commented on DBCP-586: - Seams looking good. {code:java} 10:15:23.128 [main] INFO ssl_worker.SSL_Worker - Current ThreadPool ActiveCount: 0 / CorePoolSize: 2 / LargestPoolSize: 2 / MaximumPoolSize: 30 / PoolSize: 2 / TaskCount: 8 / QueueSize: 0 / QueueRemainingCapacity: 900 10:15:23.130 [main] INFO ssl_worker.SSL_Worker - Current DBPool Stats Active (current/max): 0/1 Idle (min/current/max): 1/1/1 GenericObjectPool [maxTotal=1, blockWhenExhausted=true, maxWaitDuration=PT1M30S, lifo=true, fairness=false, testOnCreate=false, testOnBorrow=true, testOnReturn=false, testWhileIdle=false, durationBetweenEvictionRuns=PT-0.001S, numTestsPerEvictionRun=3, minEvictableIdleTimeDuration=PT30M, softMinEvictableIdleTimeDuration=PT-0.001S, evictionPolicy=org.apache.commons.pool2.impl.DefaultEvictionPolicy@39d9314d, closeLock=java.lang.Object@b978d10, closed=false, evictionLock=java.lang.Object@5b7a8434, evictor=null, evictionIterator=null, factoryClassLoader=java.lang.ref.WeakReference@5c45d770, oname=null, creationStackTrace=java.lang.Exception at org.apache.commons.pool2.impl.BaseGenericObjectPool.(BaseGenericObjectPool.java:415) at org.apache.commons.pool2.impl.GenericObjectPool.(GenericObjectPool.java:146) at org.apache.commons.dbcp2.BasicDataSource.createObjectPool(BasicDataSource.java:588) at org.apache.commons.dbcp2.BasicDataSource.createConnectionPool(BasicDataSource.java:487) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:539) at org.apache.commons.dbcp2.BasicDataSource.setLogWriter(BasicDataSource.java:2153) at db_pool.MySQLConPool.(MySQLConPool.java:65) at ssl_worker.SSL_Worker.main(SSL_Worker.java:184) , borrowedCount=174, returnedCount=174, createdCount=3, destroyedCount=2, destroyedByEvictorCount=0, destroyedByBorrowValidationCount=0, activeTimes=StatsStore [[12, 15, 20, 15, 21, 14024, 2, 2, 3, 17, 0, 15, 13, 12, 15, 12, 13, 13, 12, 12, 11, 16, 12, 10, 9, 14, 10, 11, 1, 0, 22, 14, 0, 13, 1, 14, 16, 12, 17, 17, 15, 17, 16, 16, 19, 13, 11, 13, 15, 13, 11, 20, 12, 12, 12, 15, 15, 15, 13, 13, 14, 12, 12, 13, 16, 13, 15, 13, 13, 15, 14020, 1, 1, 1]], size=100, index=74], idleTimes=StatsStore [[0, 0, 0, 1, 0, 0, 0, 1, 1, 208524, 0, 1, 7, 3, 2, 2, 3, 2, 2, 2, 2, 2, 2, 2, 2, 11, 4, 17, 2, 2, 76936, 0, 0, 1, 0, 2, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1]], size=100, index=74], waitTimes=StatsStore [[11, 11, 30, 19, 12, 20, 14022, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0, 0, 1, 0, 17, 15, 1, 16, 0, 12, 12, 12, 14, 27, 12, 16, 14, 14, 17, 12, 9, 11, 14, 11, 10, 18, 10, 10, 10, 14, 14, 13, 10, 11, 12, 8, 10, 12, 15, 11, 14, 11, 12, 13, 14018, 1, 1]], size=100, index=74], maxBorrowWaitDuration=PT14.032S, swallowedExceptionListener=org.apache.commons.dbcp2.SwallowedExceptionLogger@2ce6c6ec, factoryType=null, maxIdle=1, minIdle=1, factory=org.apache.commons.dbcp2.PoolableConnectionFactory@1bae316d, allObjects={IdentityWrapper [instance=189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J]=Object: 189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J, State: IDLE}, createCount=1, idleObjects=[Object: 189706321, URL=jdbc:mariadb://localhost/data?user=ssl_worker=***=true, MariaDB Connector/J, State: IDLE], abandonedConfig=null] {code} The Stacktrace is as it should be or? because the Key-Field is creationStackTrace. So for me its okay. > Make BasicDataSource.getConnectionPool() public to access > GenericObjectPool.toString()/getStatsString() > --- > > Key: DBCP-586 > URL: https://issues.apache.org/jira/browse/DBCP-586 > Project: Commons DBCP > Issue Type: Improvement >Affects Versions: 2.9.0 >Reporter: Thomas Freller >Priority: Major > Labels: improvement > Fix For: 2.10.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > Hello, > I'm developing a Application that is running on a default JRE without an > Webserver/JMX. > For optimizing Database connections it would be very useful if i could access > > BasicDataSource->GenericObjectPool->{*}getStatsString(){*} > > I don't see any reason why this Method is protected and not public in > GenericObjectPool. > Then BasicDataSource shoud provide a method getStatsString() or the values > that represent the statistic data. > > If there is any other easy way to access this data within my Java Code I'll > implement this if you could
[jira] [Commented] (POOL-407) Threads get stuck when idleObjects list is empty.
[ https://issues.apache.org/jira/browse/POOL-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612860#comment-17612860 ] Marten Gajda commented on POOL-407: --- [~ggregory] the missing classes are in the src/main folder of the project [https://github.com/dmfs/POOL-407] I probably can file a PR by the end of the week. > Threads get stuck when idleObjects list is empty. > - > > Key: POOL-407 > URL: https://issues.apache.org/jira/browse/POOL-407 > Project: Commons Pool > Issue Type: Bug >Affects Versions: 2.8.1 >Reporter: Sarthak Shukla >Priority: Major > > While borrowing object from pool, threads are getting stuck. I initialised > the pool size as 1. And had 3 threads created. First thread enters > borrowObject method, since there are no idle objects to poll from, it will > create one object and move forward. > {code:java} > p = (PooledObject)this.idleObjects.pollFirst(); > if (p == null) { > p = this.create(); > if (p != null) { > create = true; > } > } {code} > The other two threads will also follow same path and check for idle > objects(there are none), will try to create one object but the pool size is > set to 1. Thus, the two threads will move forward and enter > *idleObjects.takeFirst()* function. Value of blockWhenExhausted is true and > borrowMaxWaitMillis is -1 as we don't want timeout. > {code:java} > if (blockWhenExhausted) { >if (p == null) { > if (borrowMaxWaitMillis < 0L) { >p = (PooledObject)this.idleObjects.takeFirst(); > } else { >p = (PooledObject)this.idleObjects.pollFirst(borrowMaxWaitMillis, > TimeUnit.MILLISECONDS); > } >} >if (p == null) { > throw new NoSuchElementException("Timeout waiting for idle object"); >} > }{code} > Now, the main thread does *this.factory.activateObject(p);* and object gets > activated. Now, when the validation is checked *validate = > this.factory.validateObject(p);* it comes out to be false as provider might > have been disconnected. > So, the object is destroyed by calling *this.destroy(p);* > {code:java} > private void destroy(PooledObject toDestroy) throws Exception { > toDestroy.invalidate(); > this.idleObjects.remove(toDestroy); > this.allObjects.remove(new > BaseGenericObjectPool.IdentityWrapper(toDestroy.getObject())); > try { > this.factory.destroyObject(toDestroy); > } finally { > this.destroyedCount.incrementAndGet(); > this.createCount.decrementAndGet(); > } > }{code} > The object which was created is now destroyed and removed from idleObject and > allObjects list. Now, the other two threads are still waiting to take object > from idle objects list but there are no object present. Hence, the two > threads are in wait state for infinite period and the application waits > forever until we kill the process. > {code:java} > public E takeFirst() throws InterruptedException { >this.lock.lock(); >Object var2; >try { > Object x; > while((x = this.unlinkFirst()) == null) { > this.notEmpty.await(); > } > var2 = x; > } finally { > this.lock.unlock(); > } > return var2; > } {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)