[GitHub] [commons-bcel] codecov-commenter commented on pull request #183: added accessors to model and unit tests, javadoc comments
codecov-commenter commented on PR #183: URL: https://github.com/apache/commons-bcel/pull/183#issuecomment-1338812871 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#183](https://codecov.io/gh/apache/commons-bcel/pull/183?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a493f0) into [master](https://codecov.io/gh/apache/commons-bcel/commit/e86f1f6a54b326060ab88f2b6043342456f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e86f1f6) will **decrease** coverage by `0.01%`. > The diff coverage is `65.51%`. ```diff @@ Coverage Diff @@ ## master #183 +/- ## - Coverage 61.64% 61.62% -0.02% - Complexity 3654 3681 +27 Files 363 363 Lines 1563315701 +68 Branches 1950 1958 +8 + Hits 9637 9676 +39 - Misses 5122 5146 +24 - Partials874 879 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/main/java/org/apache/bcel/classfile/Code.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0NvZGUuamF2YQ==) | `71.00% <50.00%> (-0.88%)` | :arrow_down: | | [...main/java/org/apache/bcel/classfile/JavaClass.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0phdmFDbGFzcy5qYXZh) | `71.23% <50.00%> (-0.30%)` | :arrow_down: | | [...rc/main/java/org/apache/bcel/classfile/Method.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01ldGhvZC5qYXZh) | `69.23% <50.00%> (-1.27%)` | :arrow_down: | | [...rc/main/java/org/apache/bcel/classfile/Module.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZS5qYXZh) | `61.38% <57.89%> (-1.41%)` | :arrow_down: | | [...java/org/apache/bcel/classfile/ModuleRequires.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZVJlcXVpcmVzLmphdmE=) | `62.96% <62.50%> (-5.22%)` | :arrow_down: | | [...java/org/apache/bcel/classfile/ModuleProvides.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZVByb3ZpZGVzLmphdmE=) | `65.78% <68.75%> (-3.45%)` | :arrow_down: | | [.../java/org/apache/bcel/classfile/ModuleExports.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZUV4cG9ydHMuamF2YQ==) | `66.66% <71.42%> (-2.30%)` | :arrow_down: | | [...in/java/org/apache/bcel/classfile/ModuleOpens.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZU9wZW5zLmphdmE=) | `66.66% <71.42%> (-2.30%)` | :arrow_down: | | [.../java/org/apache/bcel/classfile/FieldOrMethod.java](https://codecov.io/gh/apache/commons-bcel/pull/183/diff?src=pr&el=tree&utm_medium=referral
[GitHub] [commons-bcel] nbauma109 closed pull request #183: added accessors to model and unit tests, javadoc comments
nbauma109 closed pull request #183: added accessors to model and unit tests, javadoc comments URL: https://github.com/apache/commons-bcel/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DBUTILS-144) RowProcessor.asMap is invalid for multiple computed columns with no aliases
[
https://issues.apache.org/jira/browse/DBUTILS-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Franklin Hall resolved DBUTILS-144.
Fix Version/s: 2.0
Resolution: Fixed
Added extra check for null then use column index if still null.
> RowProcessor.asMap is invalid for multiple computed columns with no aliases
> ---
>
> Key: DBUTILS-144
> URL: https://issues.apache.org/jira/browse/DBUTILS-144
> Project: Commons DbUtils
> Issue Type: Bug
>Affects Versions: 1.7
> Environment: JDK: OpenJDK 1.8.0_212
> JDBC Driver: JTDS 1.2.8.1
> Database: SQL Server 2017 (Docker image
> mcr.microsoft.com/mssql/server:2017-latest)
>
>Reporter: Robert Huffman
>Assignee: Carl Franklin Hall
>Priority: Minor
> Fix For: 2.0
>
>
> At least one database driver (JDTS) returns an empty string for both
> ResultSet.getColumnName and ResultSet.getColumnLabel if it is not a table
> column and it has no alias. If there are more than one such column in a
> result set, then BasicRowProcessor.toMap will put all of them in the map
> using the empty string as key. This means only the last column added will be
> retained in the map.
> For example, this query will create map with a single entry (the result of
> the second case statement) using the key "":
> {{SELECT}}
> {{ CASE WHEN foo = 0 THEN '' ELSE 'FOO' END,}}
> {{ CASE WHEN bar = 0 THEN '' ELSE 'BAR' END}}
> FROM FooBar
> Presumably this is not an issue for most usages. However, for a tool that
> does something like run canned queries and output the result as JSON, this is
> a problem. I propose that if both the columnName and columnLabel are null or
> zero length, the column index (converted to a String) be used as the key.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DBUTILS-144) RowProcessor.asMap is invalid for multiple computed columns with no aliases
[
https://issues.apache.org/jira/browse/DBUTILS-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Franklin Hall updated DBUTILS-144:
---
Assignee: Carl Franklin Hall
> RowProcessor.asMap is invalid for multiple computed columns with no aliases
> ---
>
> Key: DBUTILS-144
> URL: https://issues.apache.org/jira/browse/DBUTILS-144
> Project: Commons DbUtils
> Issue Type: Bug
>Affects Versions: 1.7
> Environment: JDK: OpenJDK 1.8.0_212
> JDBC Driver: JTDS 1.2.8.1
> Database: SQL Server 2017 (Docker image
> mcr.microsoft.com/mssql/server:2017-latest)
>
>Reporter: Robert Huffman
>Assignee: Carl Franklin Hall
>Priority: Minor
>
> At least one database driver (JDTS) returns an empty string for both
> ResultSet.getColumnName and ResultSet.getColumnLabel if it is not a table
> column and it has no alias. If there are more than one such column in a
> result set, then BasicRowProcessor.toMap will put all of them in the map
> using the empty string as key. This means only the last column added will be
> retained in the map.
> For example, this query will create map with a single entry (the result of
> the second case statement) using the key "":
> {{SELECT}}
> {{ CASE WHEN foo = 0 THEN '' ELSE 'FOO' END,}}
> {{ CASE WHEN bar = 0 THEN '' ELSE 'BAR' END}}
> FROM FooBar
> Presumably this is not an issue for most usages. However, for a tool that
> does something like run canned queries and output the result as JSON, this is
> a problem. I propose that if both the columnName and columnLabel are null or
> zero length, the column index (converted to a String) be used as the key.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (DBUTILS-148) Update deprecated Mockito.initMocks
[ https://issues.apache.org/jira/browse/DBUTILS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Franklin Hall resolved DBUTILS-148. Fix Version/s: 2.0 Resolution: Fixed Replaced with `@RunWith(MockitoJUnitRunner.class)` annotation on the class. Cleaned up the unused mockings. > Update deprecated Mockito.initMocks > --- > > Key: DBUTILS-148 > URL: https://issues.apache.org/jira/browse/DBUTILS-148 > Project: Commons DbUtils > Issue Type: Improvement >Reporter: Carl Franklin Hall >Assignee: Carl Franklin Hall >Priority: Trivial > Fix For: 2.0 > > > `Mockito.initMocks(...)` has been deprecated. Uses of this should be updated > following the latest guidance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DBUTILS-148) Update deprecated Mockito.initMocks
Carl Franklin Hall created DBUTILS-148: -- Summary: Update deprecated Mockito.initMocks Key: DBUTILS-148 URL: https://issues.apache.org/jira/browse/DBUTILS-148 Project: Commons DbUtils Issue Type: Improvement Reporter: Carl Franklin Hall Assignee: Carl Franklin Hall `Mockito.initMocks(...)` has been deprecated. Uses of this should be updated following the latest guidance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DBUTILS-145) org.apache.commons.dbutils.BeanProcessor doesn't work in multi-thread environment
[
https://issues.apache.org/jira/browse/DBUTILS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Franklin Hall closed DBUTILS-145.
--
Resolution: Duplicate
Closing this is a duplicate of DBUTILS-135 where the issue was resolved.
> org.apache.commons.dbutils.BeanProcessor doesn't work in multi-thread
> environment
> -
>
> Key: DBUTILS-145
> URL: https://issues.apache.org/jira/browse/DBUTILS-145
> Project: Commons DbUtils
> Issue Type: Bug
>Affects Versions: 1.7
> Environment: Checked on Windows 10 and CentOS 7.5 with Java 8 and
> Java 11.
>Reporter: Jan Jurcik
>Priority: Blocker
> Attachments: test-commons-dbutils-multithread.zip
>
>
> Using of BeanProcessor class with multiple threads fails, even every thread
> has its own instance. Th reason is this part of code:
>
> /**
> * ServiceLoader to find ColumnHandler implementations on the
> classpath. The iterator for this is
> * lazy and each time iterator() is called.
> */
> // FIXME: I think this instantiates new handlers on each iterator() call.
> This might be worth caching upfront.
> private static final ServiceLoader columnHandlers =
> ServiceLoader.load(ColumnHandler.class);
> /**
> * ServiceLoader to find PropertyHandler implementations on the
> classpath. The iterator for this is
> * lazy and each time iterator() is called.
> */
> // FIXME: I think this instantiates new handlers on each iterator() call.
> This might be worth caching upfront.
> private static final ServiceLoader propertyHandlers =
> ServiceLoader.load(PropertyHandler.class);
>
> and then using as Iterable:
>
> for (ColumnHandler handler : columnHandlers) {
> if (handler.match(propType)) {
> retval = handler.apply(rs, index);
> break;
> }
> }
> As per ServiceLoader javadoc, this class is not thread safe:
> [https://docs.oracle.com/javase/8/docs/api/java/util/ServiceLoader.html] and
> using the same instance in multiple threads causes either
> NoSuchElementException or ClassCastException.
> Attached is very simple maven java 8 project (the same happens also in other
> versions of Java), which executes simple query and tries to convert it to
> Java Bean. Run it in multi processor environment to simulate the issue. part
> of the project is also fixed version of the class *FixedBeanProcessor* which
> should work on Java 6+.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-bcel] garydgregory merged pull request #184: setup-java: rollback from 3.7.0 to 3.6.0
garydgregory merged PR #184: URL: https://github.com/apache/commons-bcel/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] nbauma109 opened a new pull request, #184: setup-java: rollback from 3.7.0 to 3.6.0
nbauma109 opened a new pull request, #184: URL: https://github.com/apache/commons-bcel/pull/184 See https://github.com/actions/setup-java/issues/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (JEXL-389) Improve parsing timings
Dmitri Blinov created JEXL-389: -- Summary: Improve parsing timings Key: JEXL-389 URL: https://issues.apache.org/jira/browse/JEXL-389 Project: Commons JEXL Issue Type: Improvement Reporter: Dmitri Blinov There seems to be a known and old issue with javacc with respect to creation of LookaheadSuccess exception instance inside parser class, which hits the performance if parsing is intensively used and many Parser objects are created. More details and suggested fixing approach can be looked at https://issues.apache.org/jira/browse/SOLR-11242 I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-bcel] nbauma109 closed pull request #183: added accessors to model and unit tests, javadoc comments
nbauma109 closed pull request #183: added accessors to model and unit tests, javadoc comments URL: https://github.com/apache/commons-bcel/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] nbauma109 commented on pull request #183: added accessors to model and unit tests, javadoc comments
nbauma109 commented on PR #183: URL: https://github.com/apache/commons-bcel/pull/183#issuecomment-1337729835 Unable to resolve action `actions/setup-java@v3.7.0`, unable to find version `v3.7.0` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand commented on a diff in pull request #120: fix: handle ServiceConfigurationError
tvand commented on code in PR #120:
URL: https://github.com/apache/commons-jcs/pull/120#discussion_r1039756273
##
commons-jcs-core/src/main/java/org/apache/commons/jcs3/log/LogManager.java:
##
@@ -57,15 +61,34 @@ private static LogFactory createLogFactory()
LogManager.logSystem = System.getProperty("jcs.logSystem",
LOGSYSTEM_JAVA_UTIL_LOGGING);
}
-
-for (final LogFactory factory : factories)
-{
-if (logSystem.equalsIgnoreCase(factory.getName()))
-{
-return factory;
+List errors = new ArrayList<>();
+Iterator itr = factories.iterator();
+LogFactory factory = null;
+while (itr.hasNext()) {
+try {
+LogFactory instance = itr.next();
+if (logSystem.equalsIgnoreCase(instance.getName())) {
+factory = instance;
+break;
+}
+} catch (ServiceConfigurationError e) {
+errors.add(e);
}
}
-
+if (factory != null) {
+if (!errors.isEmpty()) {
+Log log = factory.getLog(LogFactoryHolder.class);
+for (ServiceConfigurationError error : errors) {
+log.debug("Error loading LogFactory", error);
+}
+log.debug("Found LogFacgtory for " + logSystem);
+}
+return factory;
+}
+if (!errors.isEmpty()) {
+throw new RuntimeException("Could not find factory
implementation for log subsystem " + logSystem,
+errors.get(0));
Review Comment:
I was thinking something in the lines of System.err.println(e.getMessage());
for every error in the list.
The stack trace is not interesting because it is the same for every error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-jcs] tvand commented on a diff in pull request #120: fix: handle ServiceConfigurationError
tvand commented on code in PR #120:
URL: https://github.com/apache/commons-jcs/pull/120#discussion_r1039751555
##
commons-jcs-core/src/main/java/org/apache/commons/jcs3/log/LogManager.java:
##
@@ -57,15 +61,34 @@ private static LogFactory createLogFactory()
LogManager.logSystem = System.getProperty("jcs.logSystem",
LOGSYSTEM_JAVA_UTIL_LOGGING);
}
-
-for (final LogFactory factory : factories)
-{
-if (logSystem.equalsIgnoreCase(factory.getName()))
-{
-return factory;
+List errors = new ArrayList<>();
+Iterator itr = factories.iterator();
+LogFactory factory = null;
+while (itr.hasNext()) {
+try {
+LogFactory instance = itr.next();
+if (logSystem.equalsIgnoreCase(instance.getName())) {
+factory = instance;
+break;
+}
+} catch (ServiceConfigurationError e) {
+errors.add(e);
}
}
-
+if (factory != null) {
+if (!errors.isEmpty()) {
+Log log = factory.getLog(LogFactoryHolder.class);
Review Comment:
Yeah, you are right. My bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-bcel] nbauma109 closed pull request #163: added accessors to model and unit tests, javadoc comments
nbauma109 closed pull request #163: added accessors to model and unit tests, javadoc comments URL: https://github.com/apache/commons-bcel/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #163: added accessors to model and unit tests, javadoc comments
codecov-commenter commented on PR #163: URL: https://github.com/apache/commons-bcel/pull/163#issuecomment-1337513547 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#163](https://codecov.io/gh/apache/commons-bcel/pull/163?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07dc2b7) into [master](https://codecov.io/gh/apache/commons-bcel/commit/587c9869e2dd9abc5dae70457c44f1ddabd0ef00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (587c986) will **increase** coverage by `15.89%`. > The diff coverage is `70.00%`. ```diff @@ Coverage Diff @@ ## master #163 +/- ## = + Coverage 44.92% 60.82% +15.89% - Complexity 2516 3643 +1127 = Files 362 363+1 Lines 1556715698 +131 Branches 1920 1951 +31 = + Hits 6994 9548 +2554 + Misses 7891 5272 -2619 - Partials682 878 +196 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rc/main/java/org/apache/bcel/classfile/Method.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01ldGhvZC5qYXZh) | `69.23% <50.00%> (-1.27%)` | :arrow_down: | | [...rc/main/java/org/apache/bcel/classfile/Module.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZS5qYXZh) | `61.38% <60.00%> (+13.71%)` | :arrow_up: | | [...java/org/apache/bcel/classfile/ModuleRequires.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZVJlcXVpcmVzLmphdmE=) | `62.96% <62.50%> (-0.68%)` | :arrow_down: | | [...java/org/apache/bcel/classfile/ModuleProvides.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZVByb3ZpZGVzLmphdmE=) | `65.78% <68.75%> (+65.78%)` | :arrow_up: | | [.../java/org/apache/bcel/classfile/ModuleExports.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZUV4cG9ydHMuamF2YQ==) | `66.66% <71.42%> (+14.94%)` | :arrow_up: | | [...in/java/org/apache/bcel/classfile/ModuleOpens.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL01vZHVsZU9wZW5zLmphdmE=) | `66.66% <71.42%> (+66.66%)` | :arrow_up: | | [src/main/java/org/apache/bcel/classfile/Code.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0NvZGUuamF2YQ==) | `70.70% <100.00%> (+4.04%)` | :arrow_up: | | [.../java/org/apache/bcel/classfile/FieldOrMethod.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0ZpZWxkT3JNZXRob2QuamF2YQ==) | `55.38% <100.00%> (+2.92%)` | :arrow_up: | | [...main/java/org/apache/bcel/classfile/JavaClass.java](https://codecov.io/gh/apache/commons-bcel/pull/163/diff?src=pr&el=tree&utm
[jira] [Closed] (VFS-825) GZip input and output stream results in StackOverflowError
[
https://issues.apache.org/jira/browse/VFS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Goubard closed VFS-825.
---
Merge verified in the master branch.
> GZip input and output stream results in StackOverflowError
> --
>
> Key: VFS-825
> URL: https://issues.apache.org/jira/browse/VFS-825
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Anthony Goubard
>Priority: Major
> Fix For: 2.10.0
>
>
> The methods GZipFileObject#doGetInputStream and
> GZipFileObject#doGetOuputStream generate a StackOverflowError.
> The loops are _GZipFileObject#doGetInputStream(int) >
> AbstractFileObject#getInputStream() > AbstractFileObject#getInputStream(int)
> > GZipFileObject#doGetInputStream(int)_
> and _GZipFileObject#doGetOutputStream(boolean) >_
> {_}AbstractFileObject{_}{_}#getOutputStream(boolean) >
> GZipFileObject#doGetOutputStream(boolean){_}
> This is probably due to the commit
> [https://github.com/apache/commons-vfs/commit/a1aa1de2f981f624bb1022b94ceb05aa1a09f650]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
