[GitHub] [commons-chain] dependabot[bot] closed pull request #44: Bump actions/setup-java from 3.5.1 to 3.7.0
dependabot[bot] closed pull request #44: Bump actions/setup-java from 3.5.1 to 3.7.0 URL: https://github.com/apache/commons-chain/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #44: Bump actions/setup-java from 3.5.1 to 3.7.0
dependabot[bot] commented on PR #44: URL: https://github.com/apache/commons-chain/pull/44#issuecomment-1340376634 Superseded by #45. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] opened a new pull request, #45: Bump actions/setup-java from 3.5.1 to 3.8.0
dependabot[bot] opened a new pull request, #45: URL: https://github.com/apache/commons-chain/pull/45 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.5.1 to 3.8.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's releases. v3.8.0 In scope of this release we added logic to pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/pull/395";>actions/setup-java#395) and updated https://github-redirect.dependabot.com/actions/setup-java/pull/413";>minimatch dependency. v3.6.0 In scope of this release we added https://github-redirect.dependabot.com/actions/setup-java/issues/276";>Maven Toolchains Support and https://github-redirect.dependabot.com/actions/setup-java/pull/282";>Maven Toolchains Declaration. Moreover, from this release we use os.arch to determine default architecture for runners: https://github-redirect.dependabot.com/actions/setup-java/pull/376";>actions/setup-java#376. Besides, we made such changes as: https://github-redirect.dependabot.com/actions/setup-java/pull/392";>Upgrade @actions/cache from 3.0.0 to 3.0.4 so it respects SEGMENT_DOWNLOAD_TIMEOUT_MINS https://github-redirect.dependabot.com/actions/setup-java/pull/394";>Support Gradle version catalog https://github-redirect.dependabot.com/actions/setup-java/pull/390";>Update @actions/core to 1.10.0 Commits https://github.com/actions/setup-java/commit/c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c";>c3ac5dd Revert "Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401)" (https://github-redirect.dependabot.com/actions/setup-java/issues/421";>#421) https://github.com/actions/setup-java/commit/dcd29da2fa4fe452d84ed9b6060de3d45631495d";>dcd29da Fix typo in README.md (https://github-redirect.dependabot.com/actions/setup-java/issues/419";>#419) https://github.com/actions/setup-java/commit/19eeec562b37d29a1ad055b7de9c280bd0906d8d";>19eeec5 Update to latest actions/publish-action (https://github-redirect.dependabot.com/actions/setup-java/issues/411";>#411) https://github.com/actions/setup-java/commit/bd7e5d28eb9da6196a6d6e22a67e72e775996d9d";>bd7e5d2 Update minimatch to 3.1.2 (https://github-redirect.dependabot.com/actions/setup-java/issues/413";>#413) https://github.com/actions/setup-java/commit/6cdf39a6b6d2b0dd01e76d547cb9d448ccdd4f7c";>6cdf39a Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401) https://github.com/actions/setup-java/commit/7db6b4554ccf39e07c23296b2b1ab614f2c2351c";>7db6b45 Eclipse Temurin instead of Adopt OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/398";>#398) https://github.com/actions/setup-java/commit/bf2f02c4a72c68dc76c6a3d8af0581bb9bf4abe9";>bf2f02c Pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/395";>#395) https://github.com/actions/setup-java/commit/de1bb2b0c5634f0fc4438d7aa9944e68f9bf86cc";>de1bb2b feat: support Gradle version catalog (https://github-redirect.dependabot.com/actions/setup-java/issues/394";>#394) https://github.com/actions/setup-java/commit/2c53c1a5882e4f36ba4dca1c7e1f24a62e5453e8";>2c53c1a Update actions/cache to 3.0.4 version (https://github-redirect.dependabot.com/actions/setup-java/issues/392";>#392) https://github.com/actions/setup-java/commit/3617c43588448d532250f5c331dffcca90e398f1";>3617c43 Default to runner architecture (https://github-redirect.dependabot.com/actions/setup-java/issues/376";>#376) Additional commits viewable in https://github.com/actions/setup-java/compare/v3.5.1...v3.8.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block auto
[jira] [Updated] (DBUTILS-126) Add iterable interface approach
[ https://issues.apache.org/jira/browse/DBUTILS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Franklin Hall updated DBUTILS-126: --- Assignee: Carl Franklin Hall > Add iterable interface approach > --- > > Key: DBUTILS-126 > URL: https://issues.apache.org/jira/browse/DBUTILS-126 > Project: Commons DbUtils > Issue Type: New Feature >Affects Versions: 1.5 >Reporter: Michael Osipov >Assignee: Carl Franklin Hall >Priority: Major > Attachments: DBUTILS-126.patch > > > Currently, DbUtils allows to load all data at once into memory. In many > cases, when dealing with 100 000+ records, this will cause an OOME. I have to > iterate over 100 000 lines with 10 columns and retrieve subdata which are in > turn indexed with Lucene. > Because I cannot iterate over the entire dataset without memory problems, I > have to retrieve them pagewise. (fiddling with rownums in Oracle). > An iterator interface which streams this down from the DB to the client would > solve such a problem, very much like [Spring JdbcTemplate extension that > returns iterators|https://github.com/alexkasko/springjdbc-iterable]. This > works very well in a Spring app downloading a table with two million records > directly to the HTTP client without any buffers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (DBUTILS-112) Provide DbUtils.rollbackQuietly() method
[ https://issues.apache.org/jira/browse/DBUTILS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Franklin Hall resolved DBUTILS-112. Resolution: Fixed Applied patch and built cleanly. Pushed to master. > Provide DbUtils.rollbackQuietly() method > > > Key: DBUTILS-112 > URL: https://issues.apache.org/jira/browse/DBUTILS-112 > Project: Commons DbUtils > Issue Type: Wish >Affects Versions: 1.5 >Reporter: alexander brack >Assignee: Carl Franklin Hall >Priority: Trivial > Labels: features > Fix For: 2.0 > > Attachments: DBUTILS-112.patch > > Original Estimate: 5m > Remaining Estimate: 5m > > One has to surround DbUtils.rollback(conn) method-call with try/catch wich > produces cluttered code. Connection has to remain open, that's why > DbUtils.rollbackAndCloseQuietly(conn) method is ruled out. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #89: Bump actions/setup-java from 3.6.0 to 3.8.0
dependabot[bot] opened a new pull request, #89: URL: https://github.com/apache/commons-scxml/pull/89 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.6.0 to 3.8.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's releases. v3.8.0 In scope of this release we added logic to pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/pull/395";>actions/setup-java#395) and updated https://github-redirect.dependabot.com/actions/setup-java/pull/413";>minimatch dependency. Commits https://github.com/actions/setup-java/commit/c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c";>c3ac5dd Revert "Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401)" (https://github-redirect.dependabot.com/actions/setup-java/issues/421";>#421) https://github.com/actions/setup-java/commit/dcd29da2fa4fe452d84ed9b6060de3d45631495d";>dcd29da Fix typo in README.md (https://github-redirect.dependabot.com/actions/setup-java/issues/419";>#419) https://github.com/actions/setup-java/commit/19eeec562b37d29a1ad055b7de9c280bd0906d8d";>19eeec5 Update to latest actions/publish-action (https://github-redirect.dependabot.com/actions/setup-java/issues/411";>#411) https://github.com/actions/setup-java/commit/bd7e5d28eb9da6196a6d6e22a67e72e775996d9d";>bd7e5d2 Update minimatch to 3.1.2 (https://github-redirect.dependabot.com/actions/setup-java/issues/413";>#413) https://github.com/actions/setup-java/commit/6cdf39a6b6d2b0dd01e76d547cb9d448ccdd4f7c";>6cdf39a Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401) https://github.com/actions/setup-java/commit/7db6b4554ccf39e07c23296b2b1ab614f2c2351c";>7db6b45 Eclipse Temurin instead of Adopt OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/398";>#398) https://github.com/actions/setup-java/commit/bf2f02c4a72c68dc76c6a3d8af0581bb9bf4abe9";>bf2f02c Pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/395";>#395) See full diff in https://github.com/actions/setup-java/compare/v3.6.0...v3.8.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (STATISTICS-63) Port o.a.c.math.stat.ranking to a commons-statistics-ranking module
[
https://issues.apache.org/jira/browse/STATISTICS-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644035#comment-17644035
]
Gilles Sadowski commented on STATISTICS-63:
---
Thanks for the port, refactoring, clean-up, fix and performance improvement. :-)
> Port o.a.c.math.stat.ranking to a commons-statistics-ranking module
> ---
>
> Key: STATISTICS-63
> URL: https://issues.apache.org/jira/browse/STATISTICS-63
> Project: Commons Statistics
> Issue Type: New Feature
> Components: ranking
>Affects Versions: 1.0
>Reporter: Alex Herbert
>Priority: Major
> Fix For: 1.1
>
>
> The o.a.c.math4.legacy.stat.ranking package contains:
> {noformat}
> NaNStrategy.java
> NaturalRanking.java
> RankingAlgorithm.java
> TiesStrategy.java{noformat}
> There are no dependencies on other math packages.
> The TiesStrategy enum contains a RANDOM option:
> {noformat}
> "Ties get a random integral value from among applicable ranks."{noformat}
> I would suggest this is changed to
> {noformat}
> "Ties get a randomly assigned unique value from among applicable
> ranks."{noformat}
> This is a minor change. But it allows ties to always be distinguished, which
> seems to be the purpose of a tie strategy. The current implementation in math
> just picks a random number and so ties can be resolved by assigning the same
> rank to multiple points (thus not resolving anything).
> For example:
> {noformat}
> [0, 1, 1, 1, 2]{noformat}
> Can have an output of:
> {noformat}
> [0, 1, 2, 3, 4]
> [0, 1, 1, 1, 4]
> [0, 3, 3, 3, 4]
> etc{noformat}
> The suggested change would enumerate the ranks for the ties and then shuffle
> them. All ranks would then be unique:
> {noformat}
> [0, 1, 2, 3, 4]
> [0, 1, 3, 2, 4]
> [0, 3, 2, 1, 4]
> etc{noformat}
> A second issue with the ranking package is it brings in a dependency on
> UniformRandomProvider. If you do not supply one then an instance is created
> (which may not be needed).
> Given that we now support JDK 8 I suggest the default uses an instance of
> {{{}SplittableRandom{}}}. The user can override this by supplying a source of
> random bits as a {{{}LongSupplier{}}}. This can be used as a source of
> randomness for UniformRandomProvider from RNG. This is a functional interface
> and using the long bits it can create random rank indices as required. The
> package then does not expose non-JDK interfaces in its public API.
> Currently the NaturalRanking class has 6 constructors to set combinations for
> the three properties: TiesStrategy; NaNStragtegy; and source of randomness.
> Current API:
> {noformat}
> public NaturalRanking()
> public NaturalRanking(TiesStrategy)
> public NaturalRanking(NaNStrategy)
> public NaturalRanking(NaNStrategy, TiesStrategy)
> public NaturalRanking(UniformRandomProvider)
> public NaturalRanking(NaNStrategy, UniformRandomProvider){noformat}
> The constructors that accept a TiesStrategy create a generator even though
> the TiesStrategy may not require it (i.e. is not RANDOM). The generator
> should be created on demand when ties occur in the data.
> Note: The set of constructors could be changed to a builder pattern. This
> would add builder object creation overhead for any new strategy. It also does
> not allow implicit setting of the TiesStrategy to RANDOM if a constructor
> with a source of randomness is used. An initial port can maintain the current
> 6 constructors. It can be changed before the first release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-email] garydgregory merged pull request #116: Bump actions/setup-java from 3.6.0 to 3.8.0
garydgregory merged PR #116: URL: https://github.com/apache/commons-email/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] codecov-commenter commented on pull request #116: Bump actions/setup-java from 3.6.0 to 3.8.0
codecov-commenter commented on PR #116: URL: https://github.com/apache/commons-email/pull/116#issuecomment-1339939106 # [Codecov](https://codecov.io/gh/apache/commons-email/pull/116?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#116](https://codecov.io/gh/apache/commons-email/pull/116?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a73d61a) into [master](https://codecov.io/gh/apache/commons-email/commit/676cff22653279c2e3b190dabb3c8627a8fcffaf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (676cff2) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #116 +/- ## = Coverage 65.90% 65.90% Complexity 305 305 = Files18 18 Lines 1053 1053 Branches138 138 = Hits694 694 Misses 280 280 Partials 79 79 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request, #116: Bump actions/setup-java from 3.6.0 to 3.8.0
dependabot[bot] opened a new pull request, #116: URL: https://github.com/apache/commons-email/pull/116 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.6.0 to 3.8.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's releases. v3.8.0 In scope of this release we added logic to pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/pull/395";>actions/setup-java#395) and updated https://github-redirect.dependabot.com/actions/setup-java/pull/413";>minimatch dependency. Commits https://github.com/actions/setup-java/commit/c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c";>c3ac5dd Revert "Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401)" (https://github-redirect.dependabot.com/actions/setup-java/issues/421";>#421) https://github.com/actions/setup-java/commit/dcd29da2fa4fe452d84ed9b6060de3d45631495d";>dcd29da Fix typo in README.md (https://github-redirect.dependabot.com/actions/setup-java/issues/419";>#419) https://github.com/actions/setup-java/commit/19eeec562b37d29a1ad055b7de9c280bd0906d8d";>19eeec5 Update to latest actions/publish-action (https://github-redirect.dependabot.com/actions/setup-java/issues/411";>#411) https://github.com/actions/setup-java/commit/bd7e5d28eb9da6196a6d6e22a67e72e775996d9d";>bd7e5d2 Update minimatch to 3.1.2 (https://github-redirect.dependabot.com/actions/setup-java/issues/413";>#413) https://github.com/actions/setup-java/commit/6cdf39a6b6d2b0dd01e76d547cb9d448ccdd4f7c";>6cdf39a Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401) https://github.com/actions/setup-java/commit/7db6b4554ccf39e07c23296b2b1ab614f2c2351c";>7db6b45 Eclipse Temurin instead of Adopt OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/398";>#398) https://github.com/actions/setup-java/commit/bf2f02c4a72c68dc76c6a3d8af0581bb9bf4abe9";>bf2f02c Pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/395";>#395) See full diff in https://github.com/actions/setup-java/compare/v3.6.0...v3.8.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JEXL-384) Improve control over JexlArithmetic null argument handling
[
https://issues.apache.org/jira/browse/JEXL-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated JEXL-384:
---
Fix Version/s: 3.3
> Improve control over JexlArithmetic null argument handling
> --
>
> Key: JEXL-384
> URL: https://issues.apache.org/jira/browse/JEXL-384
> Project: Commons JEXL
> Issue Type: Task
>Affects Versions: 3.3
>Reporter: Hussachai Puripunpinyo
>Assignee: Henri Biestro
>Priority: Major
> Fix For: 3.3
>
>
> https://issues.apache.org/jira/browse/JEXL-359
> {quote}A typical case is '+' for string and null where one would like to
> consider null as a valid argument even if arithmetic is strict.
> {quote}
> While the above reason is valid, the code introduced in JEXL-359 causes more
> confusion, and the behavior is now inconsistent.
> Also, I'd like to give some counter arguments about not supporting null +
> string in the strict mode. If we want to make null + string works even if
> arithmetic is strict, there will be no difference between "" + "ABC" and null
> + "ABC" because both cases yield "ABC" in both strict and non-strict mode. In
> our code base, we set the engine to be strict, so users have to be careful
> about null since it can give an undesirable result. In a non-strict mode, we
> don't have a way to distinguish whether the result is the combination of null
> or empty string and a string. Users need to explicitly check for null, but
> there will be no enforcement
> which means nobody will do that check. That's why we prefer it to be strict
> and a user has to check null before using or use some namespace functions
> that we provide where null will be explicitly handled. Otherwise, the
> exception will be thrown.
> Let me elaborate why some part of JEXL-359 causes the behavior to be
> inconsistent.
> *Strict Mode*
> {code:java}
> var i = null;
> i + 'ABC'; // This will throw an exception.
> null + 'ABC'; // This yields 'ABC' - the same as non-strict mode.
> {code}
>
> *Non Strict Mode*
> {code:java}
> var i = null;
> i + 'ABC'; // This yields 'ABC';
> null + 'ABC'; // This also yields 'ABC';
> {code}
>
> You can see that the behavior of null + 'ABC' in the strict mode is not
> consistent with the null variable.
> Also, there is a way to allow string concatenation with null using a
> namespace function in a strict mode, and I think JEXL shouldn't make an
> exception for this one particular case.
> I'd like to propose the PR with some regression tests that applies to only
> null (literal) + string case.
> [https://github.com/apache/commons-jexl/pull/136]
> *Note:* I ignored one test *testNullArgs* because the feature doesn't seem to
> be defined well. It won't work with numeric types.
> I can pass around the JexlOperator to isStrict function everywhere to address
> that, but I'm trying to refrain from changing things too much since you may
> have some ideas and my code might get in the way.
> Please let me know if I can help with that, or you can merge my PR, take part
> of it or ignore it completely :)
> My idea about fixing *testNullArgs* properly is that all toString, toDouble,
> toBigDecimal functions should take an additional argument which is
> JexlOperator where a user can override for specific operator as stated in
> testNullArgs test. If that sounds right to you, I can help creating another
> Jira and PR to tackle this. Thank you.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-fileupload] garydgregory merged pull request #182: Bump actions/setup-java from 3.6.0 to 3.8.0
garydgregory merged PR #182: URL: https://github.com/apache/commons-fileupload/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request, #182: Bump actions/setup-java from 3.6.0 to 3.8.0
dependabot[bot] opened a new pull request, #182: URL: https://github.com/apache/commons-fileupload/pull/182 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.6.0 to 3.8.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's releases. v3.8.0 In scope of this release we added logic to pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/pull/395";>actions/setup-java#395) and updated https://github-redirect.dependabot.com/actions/setup-java/pull/413";>minimatch dependency. Commits https://github.com/actions/setup-java/commit/c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c";>c3ac5dd Revert "Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401)" (https://github-redirect.dependabot.com/actions/setup-java/issues/421";>#421) https://github.com/actions/setup-java/commit/dcd29da2fa4fe452d84ed9b6060de3d45631495d";>dcd29da Fix typo in README.md (https://github-redirect.dependabot.com/actions/setup-java/issues/419";>#419) https://github.com/actions/setup-java/commit/19eeec562b37d29a1ad055b7de9c280bd0906d8d";>19eeec5 Update to latest actions/publish-action (https://github-redirect.dependabot.com/actions/setup-java/issues/411";>#411) https://github.com/actions/setup-java/commit/bd7e5d28eb9da6196a6d6e22a67e72e775996d9d";>bd7e5d2 Update minimatch to 3.1.2 (https://github-redirect.dependabot.com/actions/setup-java/issues/413";>#413) https://github.com/actions/setup-java/commit/6cdf39a6b6d2b0dd01e76d547cb9d448ccdd4f7c";>6cdf39a Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401) https://github.com/actions/setup-java/commit/7db6b4554ccf39e07c23296b2b1ab614f2c2351c";>7db6b45 Eclipse Temurin instead of Adopt OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/398";>#398) https://github.com/actions/setup-java/commit/bf2f02c4a72c68dc76c6a3d8af0581bb9bf4abe9";>bf2f02c Pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/395";>#395) See full diff in https://github.com/actions/setup-java/compare/v3.6.0...v3.8.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #251: Bump actions/setup-java from 3.6.0 to 3.8.0
kinow merged PR #251: URL: https://github.com/apache/commons-imaging/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] garydgregory merged pull request #78: Bump actions/setup-java from 3.6.0 to 3.8.0
garydgregory merged PR #78: URL: https://github.com/apache/commons-exec/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-exec] dependabot[bot] opened a new pull request, #78: Bump actions/setup-java from 3.6.0 to 3.8.0
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/commons-exec/pull/78 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.6.0 to 3.8.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's releases. v3.8.0 In scope of this release we added logic to pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/pull/395";>actions/setup-java#395) and updated https://github-redirect.dependabot.com/actions/setup-java/pull/413";>minimatch dependency. Commits https://github.com/actions/setup-java/commit/c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c";>c3ac5dd Revert "Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401)" (https://github-redirect.dependabot.com/actions/setup-java/issues/421";>#421) https://github.com/actions/setup-java/commit/dcd29da2fa4fe452d84ed9b6060de3d45631495d";>dcd29da Fix typo in README.md (https://github-redirect.dependabot.com/actions/setup-java/issues/419";>#419) https://github.com/actions/setup-java/commit/19eeec562b37d29a1ad055b7de9c280bd0906d8d";>19eeec5 Update to latest actions/publish-action (https://github-redirect.dependabot.com/actions/setup-java/issues/411";>#411) https://github.com/actions/setup-java/commit/bd7e5d28eb9da6196a6d6e22a67e72e775996d9d";>bd7e5d2 Update minimatch to 3.1.2 (https://github-redirect.dependabot.com/actions/setup-java/issues/413";>#413) https://github.com/actions/setup-java/commit/6cdf39a6b6d2b0dd01e76d547cb9d448ccdd4f7c";>6cdf39a Add support for Oracle JDK (https://github-redirect.dependabot.com/actions/setup-java/issues/401";>#401) https://github.com/actions/setup-java/commit/7db6b4554ccf39e07c23296b2b1ab614f2c2351c";>7db6b45 Eclipse Temurin instead of Adopt OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/398";>#398) https://github.com/actions/setup-java/commit/bf2f02c4a72c68dc76c6a3d8af0581bb9bf4abe9";>bf2f02c Pass the token input through on GHES for Microsoft Build of OpenJDK (https://github-redirect.dependabot.com/actions/setup-java/issues/395";>#395) See full diff in https://github.com/actions/setup-java/compare/v3.6.0...v3.8.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643956#comment-17643956 ] Dmitri Blinov commented on JEXL-389: Thank you very much for your promt fix. With modern hardware having many cores, and more to come, the problem is not that odd, IMO. I've bumped into this issue in a real life project where jexl2 is still used. Since the flaw remained unnoticed in current JEXL version, I decided may be it's worth reporting on it. > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Minor > Fix For: 3.3 > > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MATH-1361) "NaturalRankingTest" broken?
[
https://issues.apache.org/jira/browse/MATH-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643952#comment-17643952
]
Alex Herbert commented on MATH-1361:
o.a.c.math4.stats.ranking has been moved to the Commons Statistics project.
The units tests for NaturalRanking have been updated to assert that the RANDOM
strategy assigns ties randomly among the tied data.
> "NaturalRankingTest" broken?
>
>
> Key: MATH-1361
> URL: https://issues.apache.org/jira/browse/MATH-1361
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
>Reporter: Gilles Sadowski
>Priority: Major
> Labels: test
> Fix For: 4.X
>
>
> As reported on the ["dev" ML|http://markmail.org/message/2oqkvx33arjj34lz],
> the test method
> {noformat}
> testNaNsFixedTiesRandom()
> {noformat}
> reports failure for more than 96 out of 100 seed values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (STATISTICS-63) Port o.a.c.math.stat.ranking to a commons-statistics-ranking module
[
https://issues.apache.org/jira/browse/STATISTICS-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert resolved STATISTICS-63.
Fix Version/s: 1.1
Resolution: Implemented
Added in commit:
018b1a8401c6165a0b876c5814121e09ae4757e3
> Port o.a.c.math.stat.ranking to a commons-statistics-ranking module
> ---
>
> Key: STATISTICS-63
> URL: https://issues.apache.org/jira/browse/STATISTICS-63
> Project: Commons Statistics
> Issue Type: New Feature
> Components: ranking
>Affects Versions: 1.0
>Reporter: Alex Herbert
>Priority: Major
> Fix For: 1.1
>
>
> The o.a.c.math4.legacy.stat.ranking package contains:
> {noformat}
> NaNStrategy.java
> NaturalRanking.java
> RankingAlgorithm.java
> TiesStrategy.java{noformat}
> There are no dependencies on other math packages.
> The TiesStrategy enum contains a RANDOM option:
> {noformat}
> "Ties get a random integral value from among applicable ranks."{noformat}
> I would suggest this is changed to
> {noformat}
> "Ties get a randomly assigned unique value from among applicable
> ranks."{noformat}
> This is a minor change. But it allows ties to always be distinguished, which
> seems to be the purpose of a tie strategy. The current implementation in math
> just picks a random number and so ties can be resolved by assigning the same
> rank to multiple points (thus not resolving anything).
> For example:
> {noformat}
> [0, 1, 1, 1, 2]{noformat}
> Can have an output of:
> {noformat}
> [0, 1, 2, 3, 4]
> [0, 1, 1, 1, 4]
> [0, 3, 3, 3, 4]
> etc{noformat}
> The suggested change would enumerate the ranks for the ties and then shuffle
> them. All ranks would then be unique:
> {noformat}
> [0, 1, 2, 3, 4]
> [0, 1, 3, 2, 4]
> [0, 3, 2, 1, 4]
> etc{noformat}
> A second issue with the ranking package is it brings in a dependency on
> UniformRandomProvider. If you do not supply one then an instance is created
> (which may not be needed).
> Given that we now support JDK 8 I suggest the default uses an instance of
> {{{}SplittableRandom{}}}. The user can override this by supplying a source of
> random bits as a {{{}LongSupplier{}}}. This can be used as a source of
> randomness for UniformRandomProvider from RNG. This is a functional interface
> and using the long bits it can create random rank indices as required. The
> package then does not expose non-JDK interfaces in its public API.
> Currently the NaturalRanking class has 6 constructors to set combinations for
> the three properties: TiesStrategy; NaNStragtegy; and source of randomness.
> Current API:
> {noformat}
> public NaturalRanking()
> public NaturalRanking(TiesStrategy)
> public NaturalRanking(NaNStrategy)
> public NaturalRanking(NaNStrategy, TiesStrategy)
> public NaturalRanking(UniformRandomProvider)
> public NaturalRanking(NaNStrategy, UniformRandomProvider){noformat}
> The constructors that accept a TiesStrategy create a generator even though
> the TiesStrategy may not require it (i.e. is not RANDOM). The generator
> should be created on demand when ties occur in the data.
> Note: The set of constructors could be changed to a builder pattern. This
> would add builder object creation overhead for any new strategy. It also does
> not allow implicit setting of the TiesStrategy to RANDOM if a constructor
> with a source of randomness is used. An initial port can maintain the current
> 6 constructors. It can be changed before the first release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (STATISTICS-63) Port o.a.c.math.stat.ranking to a commons-statistics-ranking module
[
https://issues.apache.org/jira/browse/STATISTICS-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643943#comment-17643943
]
Alex Herbert commented on STATISTICS-63:
I have ported the math4 ranking package to a new statistics ranking module.
This only has one class NaturalRanking and 3 interfaces to define functionality.
h2. Conversion
I have made some changes to the code during the conversion.
Bug Fix: Support ranking no data. The CM version would throw a runtime
exception for an array of length 0.
Changed the RankingAlgorithm interface to implement DoubleUnaryOperator . This
changes the method name from {{rank}} to {{{}apply{}}}. It allows chaining
functions using the default method inherited from java.util.function.Function.
The RANDOM resolution of ties requires an optional source of randomness.
I changed the public API to not use UniformRandomProvider. A source of
randomness can be provided using LongSupplier for randomness. If not provided
then it will default to SplittableRandom. This minimised the public API of the
module to only require interface provided by the JDK. You can create a
NaturalRanking which uses a RNG of choice using a method reference:
{code:java}
NaturalRanking nr = new NaturalRanking(
new SplittableRandom()::nextLong);{code}
I removed all the checked Math exceptions and replaced with
IllegalArgumentException.
Changed the RANDOM tie resolution to create unique ranks. The previous
implementation created random ranks in a range and may have created more ties
in the output ranking. The RANDOM method is now similar to SEQUENTIAL but the
order for ties is shuffled.
All rankings are now stable. Repeat input of a ranking array into the
same algorithm will not change it.
Updated the test suite. Existing tests were refactored and extras added.
Added test that the RANDOM strategy is actually random.
Fixed the test for randomness that was commented out (see also MATH-1361).
Optimise code:
Use a specialized primitive IntList to avoid List.
Only build up the list of ties when at least one tie is found. For no ties then
no list is accumulated. Drop repeat use of new ArrayList<>() for list.clear().
Filter data only once for NaNs. This removed the requirement to change NaNs
later to inf, throw exceptions or track points to ignore.
Noted that NaN will naturally be put at the end by the sort. The algorithm
counts the NaNs and does not process them. Thus it does not have to maintain an
array holding all the positions of the NaNs in the original data.
h2. Benchmark
I have created a benchmark for the NaturalRank implementation. It creates data
of a given length with a fraction of the total length being assigned as ties.
The number of tied-regions can be specified. The tied region is cut up into n
random lengths using a Dirichlet distribution (see[ String cutting
(wikipedia)|https://en.wikipedia.org/wiki/Dirichlet_distribution#String_cutting]).
The data does not contain NaNs.
A test has been added to check that data created by the benchmark is ranked
exactly the same by all ranking implementations.
For a baseline the input data is copied into an array of (index, value) pairs
and sorted using the value. The rank order is assigned back to the index
corresponding to the input. This method does not resolve ties.
||length||ranking||tieFraction||ties||Score||Relative||
|1|baseline|0|20|1435940.0| |
|1|baseline|0.1|20|1405690.6| |
|1|baseline|0.5|20|1302646.1| |
|1|math3|0|20|1612933.3|1.12|
|1|math3|0.1|20|1594389.8|1.13|
|1|math3|0.5|20|1393053.9|1.07|
|1|statistics|0|20|1423274.7|0.99|
|1|statistics|0.1|20|1446174.6|1.03|
|1|statistics|0.5|20|1293842.5|0.99|
Notes:
* Arrays.sort is the bulk of the time for ranking
* Having a lot of ties improve sorting speed (i.e. the JDK sort implementation
can recognise sequences of tied data).
* The statistics implementation is close to the same speed as the baseline.
* The statistics implementation is faster than math3.
> Port o.a.c.math.stat.ranking to a commons-statistics-ranking module
> ---
>
> Key: STATISTICS-63
> URL: https://issues.apache.org/jira/browse/STATISTICS-63
> Project: Commons Statistics
> Issue Type: New Feature
> Components: ranking
>Affects Versions: 1.0
>Reporter: Alex Herbert
>Priority: Major
>
> The o.a.c.math4.legacy.stat.ranking package contains:
> {noformat}
> NaNStrategy.java
> NaturalRanking.java
> RankingAlgorithm.java
> TiesStrategy.java{noformat}
> There are no dependencies on other math packages.
> The TiesStrategy enum contains a RANDOM option:
> {noformat}
> "Ties get a random integral value from among applicable ranks."{noformat}
> I would suggest this is changed to
> {noformat}
> "Ties get a randoml
[jira] [Work logged] (COMPRESS-614) Use FileTime for time fields in SevenZipArchiveEntry
[ https://issues.apache.org/jira/browse/COMPRESS-614?focusedWorklogId=831428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831428 ] ASF GitHub Bot logged work on COMPRESS-614: --- Author: ASF GitHub Bot Created on: 06/Dec/22 13:24 Start Date: 06/Dec/22 13:24 Worklog Time Spent: 10m Work Description: andrebrait commented on PR #256: URL: https://github.com/apache/commons-compress/pull/256#issuecomment-1339387033 @garydgregory let me know if you need help on making any required changes for switching it from 1.22 to 1.23 Issue Time Tracking --- Worklog Id: (was: 831428) Time Spent: 3h 50m (was: 3h 40m) > Use FileTime for time fields in SevenZipArchiveEntry > > > Key: COMPRESS-614 > URL: https://issues.apache.org/jira/browse/COMPRESS-614 > Project: Commons Compress > Issue Type: Improvement > Components: Archivers >Affects Versions: 1.21 >Reporter: Andre Brait >Priority: Major > Labels: 7zip > Time Spent: 3h 50m > Remaining Estimate: 0h > > Instead of java.util.Date, which caps precision in milliseconds, let's move > on to using FileTime. > We can keep backwards compatibility through the getters and setters for > modification, access and creation dates. > If you're ok with it, I'll send a PR for this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-compress] andrebrait commented on pull request #256: COMPRESS-614: Use FileTime in SevenZArchiveEntry
andrebrait commented on PR #256: URL: https://github.com/apache/commons-compress/pull/256#issuecomment-1339387033 @garydgregory let me know if you need help on making any required changes for switching it from 1.22 to 1.23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] SteveOswald commented on pull request #127: Fixing proxy-problems in _parsePassiveModeReply
SteveOswald commented on PR #127: URL: https://github.com/apache/commons-net/pull/127#issuecomment-1339277659 Hi @garydgregory , we have tested it in our test environment as well as in our production environment. It works with and without proxy. Also, it does not comply with the RFC to simply have the pasvHost overwritten with the socket address every time (as is currently the case). The server specifies an address in the PASV response to connect to. This address should also be used. The only exception should be if the server sends an invalid address ala "0,0,0,0". This case is already covered in the code, so it is not necessary to always use the socket address - as is currently the case. A test case for this is factually hard, as it would require a working HTTP proxy. However, it follows from pure logic that the current behavior is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-389. Resolution: Fixed Added ant task in pom with [e3cf7b83|https://github.com/apache/commons-jexl/commit/e3cf7b83840a04920c9bd8080fab89692c4a7d19]. > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Minor > Fix For: 3.3 > > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643852#comment-17643852 ] Henri Biestro commented on JEXL-389: The JEXL engine reuses the parser so that exception creation happens only once in single threaded usage. More than one parser can be created when concurrent parsing occurs. So, for JEXL concurrent parser creation performance to be of importance in a platform, that seems like an odd scenario. In any case, even though this is very unlikely to be a concern in real life, patching the Parser.java the way SOLR-11242 does seems easy enough. > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Minor > Fix For: 3.3 > > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-389: --- Priority: Minor (was: Major) > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Minor > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-389: --- Fix Version/s: 3.3 > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Minor > Fix For: 3.3 > > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-389: --- Affects Version/s: 3.2.1 > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Affects Versions: 3.2.1 >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Minor > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JEXL-389) Improve parsing timings
[ https://issues.apache.org/jira/browse/JEXL-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-389: --- Assignee: Henri Biestro > Improve parsing timings > --- > > Key: JEXL-389 > URL: https://issues.apache.org/jira/browse/JEXL-389 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Dmitri Blinov >Assignee: Henri Biestro >Priority: Major > > There seems to be a known and old issue with javacc with respect to creation > of LookaheadSuccess exception instance inside parser class, which hits the > performance if parsing is intensively used and many Parser objects are > created. > More details and suggested fixing approach can be looked at > https://issues.apache.org/jira/browse/SOLR-11242 > I think we can adopt the fix until it will be fixed in javacc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-net] garydgregory commented on pull request #127: Fixing proxy-problems in _parsePassiveModeReply
garydgregory commented on PR #127: URL: https://github.com/apache/commons-net/pull/127#issuecomment-1339196589 Hello @SteveOswald This PR needs a test to prove the PR fixes something and to avoid regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] SteveOswald opened a new pull request, #127: Fixing proxy-problems in _parsePassiveModeReply
SteveOswald opened a new pull request, #127: URL: https://github.com/apache/commons-net/pull/127 FTPClient in passive mode didn't worked, when using a proxy, cause the FTPClient tried to open a data-connection to the proxy-host instead the real passive-host. This was caused, cause the passiveHost was ALWAYS overwritten by the socket-address (wich is the address of the proxy-host, when using a proxy). The passive-host should ALWAYS be parsed from the pasvResponse and only be overwritten, when the pasvResponse is a "look lie IP address" (0,0,0,0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #182: added signature test cases for class/method, and bad signatures
codecov-commenter commented on PR #182: URL: https://github.com/apache/commons-bcel/pull/182#issuecomment-1338978510 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/182?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#182](https://codecov.io/gh/apache/commons-bcel/pull/182?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c48b4c0) into [master](https://codecov.io/gh/apache/commons-bcel/commit/2fbcd9e275f18ea078f4fc668e2c8346e39a5afc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2fbcd9e) will **increase** coverage by `0.46%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #182 +/- ## + Coverage 61.64% 62.11% +0.46% - Complexity 3654 3684 +30 Files 363 363 Lines 1563315633 Branches 1950 1950 + Hits 9637 9710 +73 + Misses 5122 5039 -83 - Partials874 884 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...main/java/org/apache/bcel/classfile/JavaClass.java](https://codecov.io/gh/apache/commons-bcel/pull/182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0phdmFDbGFzcy5qYXZh) | `71.87% <0.00%> (+0.34%)` | :arrow_up: | | [...in/java/org/apache/bcel/classfile/AccessFlags.java](https://codecov.io/gh/apache/commons-bcel/pull/182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0FjY2Vzc0ZsYWdzLmphdmE=) | `23.07% <0.00%> (+1.53%)` | :arrow_up: | | [src/main/java/org/apache/bcel/generic/Type.java](https://codecov.io/gh/apache/commons-bcel/pull/182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvZ2VuZXJpYy9UeXBlLmphdmE=) | `71.42% <0.00%> (+6.12%)` | :arrow_up: | | [.../java/org/apache/bcel/classfile/FieldOrMethod.java](https://codecov.io/gh/apache/commons-bcel/pull/182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL0ZpZWxkT3JNZXRob2QuamF2YQ==) | `63.93% <0.00%> (+11.47%)` | :arrow_up: | | [...main/java/org/apache/bcel/classfile/Signature.java](https://codecov.io/gh/apache/commons-bcel/pull/182/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL1NpZ25hdHVyZS5qYXZh) | `81.92% <0.00%> (+66.26%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
