[GitHub] [commons-lang] GedMarc commented on pull request #299: Add module-info for Java 9
GedMarc commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-1369316687 I have all the commons libraries with module-info's for natively building artifacts https://github.com/GedMarc/GuicedEE-Services/tree/2a56ec5e79010c8214b6a398d3cf5b4e09f844ce These are always up to date and contain the required configurations for operation https://mvnrepository.com/artifact/com.guicedee.services/ - prefix "commons" e.g. https://mvnrepository.com/artifact/com.guicedee.services/commons-logging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] garydgregory merged pull request #100: Bump commons-parent from 55 to 56
garydgregory merged PR #100: URL: https://github.com/apache/commons-scxml/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #100: Bump commons-parent from 55 to 56
dependabot[bot] opened a new pull request, #100: URL: https://github.com/apache/commons-scxml/pull/100 Bumps [commons-parent](https://github.com/apache/commons-parent) from 55 to 56. Changelog Sourced from https://github.com/apache/commons-parent/blob/master/RELEASE-NOTES.txt";>commons-parent's changelog. Apache Commons Parent 56 RELEASE NOTES The Apache Commons Parent team is pleased to announce the release of Apache Commons Parent 56. The Apache Commons Parent POM provides common settings for all Apache Commons components. Version 56: Maintenance and update dependencies Changes in this version include: Fixed Bugs: o Add Privacy link to site.xml Changes: o Bump apache from 28 to 29 https://github-redirect.dependabot.com/apache/commons-parent/issues/182";>#182. Thanks to Dependabot. o Bump versions-maven-plugin from 2.13.0 to 2.14.2 https://github-redirect.dependabot.com/apache/commons-parent/issues/181";>#181, https://github-redirect.dependabot.com/apache/commons-parent/issues/187";>#187, https://github-redirect.dependabot.com/apache/commons-parent/issues/191";>#191. Thanks to Dependabot. o Bump wagon-ssh from 3.5.2 to 3.5.3 https://github-redirect.dependabot.com/apache/commons-parent/issues/190";>#190. Thanks to Dependabot. Historical list of changes: https://commons.apache.org/proper/commons-parent/changes-report.html";>https://commons.apache.org/proper/commons-parent/changes-report.html For complete information on Apache Commons Parent, including instructions on how to submit bug reports, patches, or suggestions for improvement, see the Apache Apache Commons Parent website: https://commons.apache.org/proper/commons-parent/";>https://commons.apache.org/proper/commons-parent/ Apache Commons Parent 55 RELEASE NOTES The Apache Commons Parent team is pleased to announce the release of Apache Commons Parent 55. The Apache Commons Parent POM provides common settings for all Apache Commons components. Version 55: Maintenance and update dependencies Changes in this version include: Changes: o Make CycloneDX work better with multi-module projects. Thanks to Gary Gregory. o New interface methods must be default methods to maintain BC. Thanks to Gary Gregory. o Add property commons.javadoc19.java.link. Thanks to Gary Gregory. o Bump actions/cache from 3.0.8 to 3.0.11 https://github-redirect.dependabot.com/apache/commons-parent/issues/152";>#152, https://github-redirect.dependabot.com/apache/commons-parent/issues/155";>#155, https://github-redirect.dependabot.com/apache/commons-parent/issues/160";>#160. Thanks to Dependabot. o Bump actions/checkout from 3.0.2 to 3.1.0 https://github-redirect.dependabot.com/apache/commons-parent/issues/154";>#154. Thanks to Dependabot. o Bump actions/setup-java from 3.5.1 to 3.6.0 https://github-redirect.dependabot.com/apache/commons-parent/issues/164";>#164. Thanks to Dependabot. o Bump actions/upload-artifact from 3.1.0 to 3.1.1 https://github-redirect.dependabot.com/apache/commons-parent/issues/165";>#165 Thanks to Dependabot. o Bump github/codeql-action from 2.1.27 to 2.1.35 https://github-redirect.dependabot.com/apache/commons-parent/issues/162";>#162, https://github-redirect.dependabot.com/apache/commons-parent/issues/166";>#166, https://github-redirect.dependabot.com/apache/commons-parent/issues/168";>#168, https://github-redirect.dependabot.com/apache/commons-parent/issues/178";>#178. Thanks to Dependabot. o Bump github/codeql-action from 2.1.23 to 2.1.31 https://github-redirect.dependabot.com/apache/commons-parent/issues/148";>#148, https://github-redirect.dependabot.com/apache/commons-parent/issues/150";>#150, https://github-redirect.dependabot.com/apache/commons-parent/issues/156";>#156, https://github-redirect.dependabot.com/apache/commons-parent/issues/172";>#172. Thanks to Gary Gregory, Dependabot. ... (truncated) Commits See full diff in https://github.com/apache/commons-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-en
[GitHub] [commons-lang] Sineaggi opened a new pull request, #1008: Make java.desktop module optional
Sineaggi opened a new pull request, #1008: URL: https://github.com/apache/commons-lang/pull/1008 As an alternative to https://github.com/apache/commons-lang/pull/275, this allows existing code to continue to work, while providing a migration path for other users. We can choose to either deprecate or keep the methods that take `PropertyChangeListener`s. By guarding the construction of the `PropertyChangeSupport` with a try/catch, we can continue to run when the `java.desktop` module is absent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1007: Added new examples for rightPad method
garydgregory commented on PR #1007: URL: https://github.com/apache/commons-lang/pull/1007#issuecomment-1369254980 This does not help, it just makes things bigger without helping users IMO. The additional tests don't even increase code coverage, so there is really little value in even the new assertions IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (POOL-401) GKOP invalidateObject should make capacity available to all keyed pools
[ https://issues.apache.org/jira/browse/POOL-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653706#comment-17653706 ] Phil Steitz commented on POOL-401: -- It looks to me that at least as of 2.11.1 reuseCapacity is called on each activation of invalidateObject in GKOP, so if the freed capacity should be added to the most heavily loaded pool. Could be I am missing something. A unit test showing starvation would help. > GKOP invalidateObject should make capacity available to all keyed pools > --- > > Key: POOL-401 > URL: https://issues.apache.org/jira/browse/POOL-401 > Project: Commons Pool > Issue Type: Bug >Reporter: Phil Steitz >Priority: Major > > GKOP invalidateObject currently only creates and adds objects if there are > borrowers waiting for the keyed pool that the instance being invalidated came > from. If there are no take waiters on that pool, or there is a more heavily > loaded pool, the (total) capacity should be reused in a different pool. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (POOL-407) Threads get stuck when idleObjects list is empty.
[
https://issues.apache.org/jira/browse/POOL-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653705#comment-17653705
]
Phil Steitz commented on POOL-407:
--
Thanks for reporting this with the detailed analysis. It is a liveness bug.
One option to consider for a patch would be to modify the code in borrowObject
to do what returnObject does on validation failures, which is to call
ensureIdle(1, false). Need to think carefully about the consequences of adding
this, but that is what we did to address the dual of this problem on return.
> Threads get stuck when idleObjects list is empty.
> -
>
> Key: POOL-407
> URL: https://issues.apache.org/jira/browse/POOL-407
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 2.8.1
>Reporter: Sarthak Shukla
>Priority: Major
>
> While borrowing object from pool, threads are getting stuck. I initialised
> the pool size as 1. And had 3 threads created. First thread enters
> borrowObject method, since there are no idle objects to poll from, it will
> create one object and move forward.
> {code:java}
> p = (PooledObject)this.idleObjects.pollFirst();
> if (p == null) {
> p = this.create();
> if (p != null) {
> create = true;
> }
> } {code}
> The other two threads will also follow same path and check for idle
> objects(there are none), will try to create one object but the pool size is
> set to 1. Thus, the two threads will move forward and enter
> *idleObjects.takeFirst()* function. Value of blockWhenExhausted is true and
> borrowMaxWaitMillis is -1 as we don't want timeout.
> {code:java}
> if (blockWhenExhausted) {
>if (p == null) {
> if (borrowMaxWaitMillis < 0L) {
>p = (PooledObject)this.idleObjects.takeFirst();
> } else {
>p = (PooledObject)this.idleObjects.pollFirst(borrowMaxWaitMillis,
> TimeUnit.MILLISECONDS);
> }
>}
>if (p == null) {
> throw new NoSuchElementException("Timeout waiting for idle object");
>}
> }{code}
> Now, the main thread does *this.factory.activateObject(p);* and object gets
> activated. Now, when the validation is checked *validate =
> this.factory.validateObject(p);* it comes out to be false as provider might
> have been disconnected.
> So, the object is destroyed by calling *this.destroy(p);*
> {code:java}
> private void destroy(PooledObject toDestroy) throws Exception {
> toDestroy.invalidate();
> this.idleObjects.remove(toDestroy);
> this.allObjects.remove(new
> BaseGenericObjectPool.IdentityWrapper(toDestroy.getObject()));
> try {
> this.factory.destroyObject(toDestroy);
> } finally {
> this.destroyedCount.incrementAndGet();
> this.createCount.decrementAndGet();
> }
> }{code}
> The object which was created is now destroyed and removed from idleObject and
> allObjects list. Now, the other two threads are still waiting to take object
> from idle objects list but there are no object present. Hence, the two
> threads are in wait state for infinite period and the application waits
> forever until we kill the process.
> {code:java}
> public E takeFirst() throws InterruptedException {
>this.lock.lock();
>Object var2;
>try {
> Object x;
> while((x = this.unlinkFirst()) == null) {
> this.notEmpty.await();
> }
> var2 = x;
> } finally {
> this.lock.unlock();
> }
> return var2;
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-lang] esivakumar18 opened a new pull request, #1007: Added new examples for rightPad method
esivakumar18 opened a new pull request, #1007: URL: https://github.com/apache/commons-lang/pull/1007 Added new examples for `rightPad` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (POOL-350) Add option for not executing "hasBorrowWaiters()" while returning objects
[
https://issues.apache.org/jira/browse/POOL-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653704#comment-17653704
]
Phil Steitz commented on POOL-350:
--
Any feedback on the reuseCapacityOnReturn, reuseCapacityOnMaintenance idea?
Might help in situations like the OP's. Should not be hard to implement.
> Add option for not executing "hasBorrowWaiters()" while returning objects
> -
>
> Key: POOL-350
> URL: https://issues.apache.org/jira/browse/POOL-350
> Project: Commons Pool
> Issue Type: New Feature
>Affects Versions: 2.6.0
> Environment: h5. uname -a:
> Linux VMS26239 3.10.0-229.11.1.el7.x86_64 #1 SMP Thu Aug 6 01:06:18 UTC 2015
> x86_64 x86_64 x86_64 GNU/Linux
>
> *Java version:*
> java version "1.8.0_60"
> Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
> Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode)
>
>
>Reporter: zhu chen
>Priority: Critical
> Labels: easyfix
>
> h2. Phenomena:
> I'm recently leveraging commons-pool as my Redis connection pool in my
> project, however, the pain is that when my system is dealing with over
> thousands of Redises, CPU load become such high. By checking JVM through
> JFR(FlightRecorder), it turned out the hot method was
> "{color:#FF}hasBorrowWaiters(){color}", which is invoked by
> "{color:#FF}returnObject(){color}" each time.
> That means the system will go through over *thousands*(the number will grow
> as well as my system) of keys after *each* object's *return*, what's worse,
> the program is running concurrently, which, obviously cause a huge CPU load.
>
> h2. Expect:
> I was wondering if we could add a config for optionally run this
> "hasBorrowWaiters()" each time when we return an object.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-lang] Sineaggi commented on pull request #299: Add module-info for Java 9
Sineaggi commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-1369234373 > Why the edit to change the import of PropertyChangeListener to a FQCN? If the class still has a reference to PropertyChangeListener how is it different? You're right, that change is unnecessary. I originally used the same names for the classes in `java.beans`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (POOL-372) CallStackUtils mishandles security manager check part 2
[ https://issues.apache.org/jira/browse/POOL-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653703#comment-17653703 ] Phil Steitz commented on POOL-372: -- I am not a security expert, so I can't comment on the assertion in (b) above, but at least as of 2.10, (a) does not apply. I like the idea of replacing the impl using Flight recorder though, if we can figure out a way to do it. The reason that this exists is to allow pooled objects to hold onto the stack trace leading to their creation. What is not obvious to me about how to use Flight Recorder is knowing what to capture in advance. > CallStackUtils mishandles security manager check part 2 > --- > > Key: POOL-372 > URL: https://issues.apache.org/jira/browse/POOL-372 > Project: Commons Pool > Issue Type: Bug >Reporter: Volker Kleinschmidt >Priority: Major > > This ticket is for (b). > CallStackUtils determines at initialization time whether it is allowed to > create a security manager, then sticks that info into a static variable and > never checks it again, relying on this check to later try to create a > SecurityManager for a SecurityManagerCallStack. This is doubly wrong: > a) If the code is running in a privileged context at init time, it determines > that it can create a security manager, and then later naively assumes that > henceforth all code is privileged and also can create a security manager. Of > course this is not true, otherwise one would not need a security manager in > the first place! This info can never be kept in a static variable, it's > extremely context-dependent. So this leads to AccessControlException from > invoking newCallStack() if abandoned object logging is enabled. > b) The permission to create a security manager must never be granted to any > code, unless that code has AllPermission in the first place, i.e. is already > fully privileged. This is because this permission allows circumventing the > security manager completely (simply create one that lets all checks pass). > Therefore even just checking whether you're allowed to create a secmgr is > naive - if a secmgr is installed at all you should assume that you're NOT > privileged enough to do this, simply because for sure some code that calls > your code will not be privileged enough. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (POOL-264) NullPointerException in GKOP.borrowObject()
[ https://issues.apache.org/jira/browse/POOL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed POOL-264. Resolution: Won't Fix Please port to 2.x. > NullPointerException in GKOP.borrowObject() > --- > > Key: POOL-264 > URL: https://issues.apache.org/jira/browse/POOL-264 > Project: Commons Pool > Issue Type: Bug >Affects Versions: 1.5.6, 1.5.7, 1.6 >Reporter: Leonid Meyerguz >Priority: Major > > While I cannot pin down a consistent repro, I occasionally observe a > NullPointerException at > org.apache.commons.pool.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:1126) > The pool is configured as follows: > maxActive = -1 > maxIdle = 32 > maxTotal = 32 > whenExhaustedAction = WHEN_EXHAUSTED_GROW > timeBetweenEvictionRunsMillis = 2 > minEvictableIdleTimeMillis = 6 > numTestsPerEvictionRun = -1 > The NullPointerException is thrown in the WHEN_EXHAUSTED_GROW branch of the > code. Specifically it appears that latch.getPool() returns null. > Any suggestions for a work-around would be appreciated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-lang] garydgregory commented on pull request #299: Add module-info for Java 9
garydgregory commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-1369230232 Why the edit to change the import of PropertyChangeListener to a FQCN? If the class still has a reference to PropertyChangeListener how is it different? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (POOL-264) NullPointerException in GKOP.borrowObject()
[ https://issues.apache.org/jira/browse/POOL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653699#comment-17653699 ] Phil Steitz commented on POOL-264: -- The entire setup was changed in 2.0. Unless someone wants to take up the task of creating a 1.6.x, I think we should close this as WONT_FIX. Users of 1.x versions of commons pool should upgrade to version 2+ > NullPointerException in GKOP.borrowObject() > --- > > Key: POOL-264 > URL: https://issues.apache.org/jira/browse/POOL-264 > Project: Commons Pool > Issue Type: Bug >Affects Versions: 1.5.6, 1.5.7, 1.6 >Reporter: Leonid Meyerguz >Priority: Major > > While I cannot pin down a consistent repro, I occasionally observe a > NullPointerException at > org.apache.commons.pool.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:1126) > The pool is configured as follows: > maxActive = -1 > maxIdle = 32 > maxTotal = 32 > whenExhaustedAction = WHEN_EXHAUSTED_GROW > timeBetweenEvictionRunsMillis = 2 > minEvictableIdleTimeMillis = 6 > numTestsPerEvictionRun = -1 > The NullPointerException is thrown in the WHEN_EXHAUSTED_GROW branch of the > code. Specifically it appears that latch.getPool() returns null. > Any suggestions for a work-around would be appreciated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-lang] kinow merged pull request #1006: Added empty string example for isMixedCase method.
kinow merged PR #1006: URL: https://github.com/apache/commons-lang/pull/1006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] esivakumar18 commented on pull request #1006: Added empty string example for isMixedCase method.
esivakumar18 commented on PR #1006: URL: https://github.com/apache/commons-lang/pull/1006#issuecomment-1369223570 > Thanks! Thank you @kinow for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (POOL-393) BaseGenericObjectPool.jmxRegister may cost too much time
[
https://issues.apache.org/jira/browse/POOL-393?focusedWorklogId=836456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836456
]
ASF GitHub Bot logged work on POOL-393:
---
Author: ASF GitHub Bot
Created on: 02/Jan/23 21:28
Start Date: 02/Jan/23 21:28
Worklog Time Spent: 10m
Work Description: psteitz commented on PR #199:
URL: https://github.com/apache/commons-pool/pull/199#issuecomment-1369218259
Sorry to be late responding here and great to see you working on pool,
Niall! Looks good to me. And I like it better than my previous attempt
because it keeps the sequence of identifiers contiguous. We do need to worry
about concurrent access, but the only contention issue that I can see is the if
name check succeeds for one thread and another grabs it, but the code catches
the exception that would happen in that case and increments. So should be
fine. One small nit is pls get rid of the system out in the unit test. There
is already too much spewage from [pool] unit tests (some of it my fault I am
sure). Sorry again to be slow to respond.
Issue Time Tracking
---
Worklog Id: (was: 836456)
Time Spent: 2h 40m (was: 2.5h)
> BaseGenericObjectPool.jmxRegister may cost too much time
>
>
> Key: POOL-393
> URL: https://issues.apache.org/jira/browse/POOL-393
> Project: Commons Pool
> Issue Type: Improvement
>Affects Versions: 2.4.2
>Reporter: Shichao Yuan
>Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
>
> When creating many pools, I find that it tasks too much time to register jmx.
> In the code, the ObjectName's postfix always starts with 1, so many
> InstanceAlreadyExistsExceptions may be thrown before registered successfully.
> Maybe a random number is a better choice, or a atomic long.
> {quote}private ObjectName jmxRegister(BaseObjectPoolConfig config,
> String jmxNameBase, String jmxNamePrefix) {
> ObjectName objectName = null;
> MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
> int i = 1;
> boolean registered = false;
> String base = config.getJmxNameBase();
> if (base == null)
> Unknown macro: \{ base = jmxNameBase; }
> while (!registered) {
> try {
> ObjectName objName;
> // Skip the numeric suffix for the first pool in case there is
> // only one so the names are cleaner.
> if (i == 1)
> Unknown macro: \{ objName = new ObjectName(base + jmxNamePrefix); }
> else
> Unknown macro: \{ objName = new ObjectName(base + jmxNamePrefix + i); }
> mbs.registerMBean(this, objName);
> objectName = objName;
> registered = true;
> } catch (MalformedObjectNameException e) {
> if (BaseObjectPoolConfig.DEFAULT_JMX_NAME_PREFIX.equals(
> jmxNamePrefix) && jmxNameBase.equals(base))
> Unknown macro: \{ // Shouldn't happen. Skip registration if it does.
> registered = true; }
> else
> Unknown macro: \{ // Must be an invalid name. Use the defaults instead.
> jmxNamePrefix = BaseObjectPoolConfig.DEFAULT_JMX_NAME_PREFIX; base =
> jmxNameBase; }
> } catch (InstanceAlreadyExistsException e)
> Unknown macro: \{ // Increment the index and try again i++; }
> catch (MBeanRegistrationException e)
> Unknown macro: \{ // Shouldn't happen. Skip registration if it does.
> registered = true; }
> catch (NotCompliantMBeanException e)
> }
> return objectName;
> }
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-pool] psteitz commented on pull request #199: [POOL-393] Improve BaseGenericObjectPool's JMX Register performance
psteitz commented on PR #199: URL: https://github.com/apache/commons-pool/pull/199#issuecomment-1369218259 Sorry to be late responding here and great to see you working on pool, Niall! Looks good to me. And I like it better than my previous attempt because it keeps the sequence of identifiers contiguous. We do need to worry about concurrent access, but the only contention issue that I can see is the if name check succeeds for one thread and another grabs it, but the code catches the exception that would happen in that case and increments. So should be fine. One small nit is pls get rid of the system out in the unit test. There is already too much spewage from [pool] unit tests (some of it my fault I am sure). Sorry again to be slow to respond. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] jodastephen commented on pull request #299: Add module-info for Java 9
jodastephen commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-1369206286 I have no plans to work further on this, and in my 2023 view adding `module-info.java` is a mistake for most projects, as it creates more problems than it solves. Having a module name reserved in the manifest is, of course, fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] Sineaggi commented on pull request #299: Add module-info for Java 9
Sineaggi commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-1369201547 @jodastephen Will you have any time to work on this branch and get it ready to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] Sineaggi commented on pull request #299: Add module-info for Java 9
Sineaggi commented on PR #299: URL: https://github.com/apache/commons-lang/pull/299#issuecomment-1369200406 @kinow I have an alternative branch that would allow users to continue to use `AbstractCircuitBreaker` with or without the `java.desktop` module, available here https://github.com/apache/commons-lang/compare/master...Sineaggi:commons-lang:make-java.desktop-optional. In this case we provide two ways of specifying a listener, one from `java.desktop` and on provided by apache. For users that still use the `java.beans.PropertyChangeListener`, they'll need a `requires java.desktop` in their module-info.java file, but for other users they can use the new `org.apache.commons.lang3.concurrent.StateChangeListener` without issue. I could also do some extra work to make the new classes closely mirror the ones in `java.beans`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #1006: Added empty string example for isMixedCase method.
codecov-commenter commented on PR #1006: URL: https://github.com/apache/commons-lang/pull/1006#issuecomment-1369196447 # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/1006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1006](https://codecov.io/gh/apache/commons-lang/pull/1006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7a10f9) into [master](https://codecov.io/gh/apache/commons-lang/commit/78b4f09d0b7e2b209badcc05fdeb1844a469ea68?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (78b4f09) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master#1006 +/- ## = Coverage 92.03% 92.03% Complexity 7429 7429 = Files 193 193 Lines 1567215672 Branches 2899 2899 = Hits 1442314423 Misses 676 676 Partials573 573 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/1006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ain/java/org/apache/commons/lang3/StringUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nVXRpbHMuamF2YQ==) | `98.86% <ø> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] esivakumar18 opened a new pull request, #1006: Added empty string example for isMixedCase method.
esivakumar18 opened a new pull request, #1006: URL: https://github.com/apache/commons-lang/pull/1006 Added empty string example for `isMixedCase` method. Junit test for this example is already present in `StringUtilsTest.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] garydgregory merged pull request #127: Bump easymock from 4.3 to 5.1.0
garydgregory merged PR #127: URL: https://github.com/apache/commons-email/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] esivakumar18 closed pull request #1005: formatted java.lang package.
esivakumar18 closed pull request #1005: formatted java.lang package. URL: https://github.com/apache/commons-lang/pull/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1005: formatted java.lang package.
garydgregory commented on PR #1005: URL: https://github.com/apache/commons-lang/pull/1005#issuecomment-1369177193 Correct, this is a generated file, so -1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] codecov-commenter commented on pull request #127: Bump easymock from 4.3 to 5.1.0
codecov-commenter commented on PR #127: URL: https://github.com/apache/commons-email/pull/127#issuecomment-1369175648 # [Codecov](https://codecov.io/gh/apache/commons-email/pull/127?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#127](https://codecov.io/gh/apache/commons-email/pull/127?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8083413) into [master](https://codecov.io/gh/apache/commons-email/commit/5c69161bd37daf91674d7f4bf9262c63761c289c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c69161) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #127 +/- ## = Coverage 65.90% 65.90% Complexity 305 305 = Files18 18 Lines 1053 1053 Branches138 138 = Hits694 694 Misses 280 280 Partials 79 79 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] garydgregory merged pull request #108: Bump easymock from 5.0.1 to 5.1.0
garydgregory merged PR #108: URL: https://github.com/apache/commons-ognl/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] closed pull request #111: Bump easymock from 4.3 to 5.0.1
dependabot[bot] closed pull request #111: Bump easymock from 4.3 to 5.0.1 URL: https://github.com/apache/commons-email/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #111: Bump easymock from 4.3 to 5.0.1
dependabot[bot] commented on PR #111: URL: https://github.com/apache/commons-email/pull/111#issuecomment-1369173468 Superseded by #127. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request, #127: Bump easymock from 4.3 to 5.1.0
dependabot[bot] opened a new pull request, #127: URL: https://github.com/apache/commons-email/pull/127 Bumps [easymock](https://github.com/easymock/easymock) from 4.3 to 5.1.0. Release notes Sourced from https://github.com/easymock/easymock/releases";>easymock's releases. 5.1.0 Main a performance fix caused by ByteBuddy causing OOME. Change log Typecache for create mock classes (https://github-redirect.dependabot.com/easymock/easymock/pull/353";>#353) Bump versions-maven-plugin from 2.14.1 to 2.14.2 (https://github-redirect.dependabot.com/easymock/easymock/pull/352";>#352) Bump wagon-ssh-external from 3.5.2 to 3.5.3 (https://github-redirect.dependabot.com/easymock/easymock/pull/351";>#351) Bump byte-buddy from 1.12.19 to 1.12.20 (https://github-redirect.dependabot.com/easymock/easymock/pull/350";>#350) Bump versions-maven-plugin from 2.14.0 to 2.14.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/349";>#349) Bump versions-maven-plugin from 2.13.0 to 2.14.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/348";>#348) Bump testng from 7.5 to 7.7.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/347";>#347) Bump maven-dependency-plugin from 3.3.0 to 3.4.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/345";>#345) Bump checkstyle from 10.4 to 10.5.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/344";>#344) java.lang.NullPointerException at org.easymock.internal.ClassProxyFactory.classPackage(ClassProxyFactory.java:178) (https://github-redirect.dependabot.com/easymock/easymock/issues/343";>#343) EasyMock 5.0.1 OOM on large project (https://github-redirect.dependabot.com/easymock/easymock/issues/338";>#338) Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.3.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/337";>#337) Bump checkstyle from 10.3.4 to 10.4 (https://github-redirect.dependabot.com/easymock/easymock/pull/336";>#336) Bump maven-shade-plugin from 3.4.0 to 3.4.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/335";>#335) Add cache for mocked types. (https://github-redirect.dependabot.com/easymock/easymock/pull/334";>#334) Mock serialization doesn't work (https://github-redirect.dependabot.com/easymock/easymock/issues/312";>#312) 5.0.1 Quick fix allowing package-private methods to be mocked. Change log Mocking package-private methods not working in 5.0.0 (https://github-redirect.dependabot.com/easymock/easymock/issues/331";>#331) Bump versions-maven-plugin from 2.12.0 to 2.13.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/333";>#333) Bump nokogiri from 1.13.8 to 1.13.9 in /website (https://github-redirect.dependabot.com/easymock/easymock/pull/332";>#332) Bump spotbugs from 4.7.2 to 4.7.3 (https://github-redirect.dependabot.com/easymock/easymock/pull/330";>#330) Bump maven-javadoc-plugin from 3.2.0 to 3.4.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/329";>#329) Bump nexus-staging-maven-plugin from 1.6.8 to 1.6.13 (https://github-redirect.dependabot.com/easymock/easymock/pull/328";>#328) Bump maven-compiler-plugin from 3.8.1 to 3.10.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/327";>#327) Bump animal-sniffer-maven-plugin from 1.20 to 1.22 (https://github-redirect.dependabot.com/easymock/easymock/pull/326";>#326) Bump maven-deploy-plugin from 3.0.0-M1 to 3.0.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/325";>#325) Bump maven-pmd-plugin from 3.14.0 to 3.19.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/324";>#324) Bump maven-resources-plugin from 3.2.0 to 3.3.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/323";>#323) Bump maven-site-plugin from 3.9.1 to 3.12.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/322";>#322) Bump exec-maven-plugin from 3.0.0 to 3.1.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/321";>#321) Bump maven-remote-resources-plugin from 1.7.0 to 3.0.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/319";>#319) 5.0.0 This major release announce the move from Cglib to ByteBuddy. Sadly good old Cglib can't cope with all the tricks needed to workaround JPMS and reflection limitations. It means you will most probably experience some issues until it stabilizes. The good news are that this version is working up to Java 18. Known issues: ... (truncated) Commits https://github.com/easymock/easymock/commit/f1b53a1f97cf20e90733dd1aa20b224917a16f2e";>f1b53a1 Move to version 5.1.0 https://github.com/easymock/easymock/commit/b08bff3d78c91f1e4bfc30d33a02e6d83c7f631d";>b08bff3 Test fails. Probably PowerMock do not create null packages anymore https://github.com/easymock/easymock/commit/c9e2dd1140672300139f75ec66db0fe297d1ed9d";>c9e2dd1 Make
[GitHub] [commons-lang] esivakumar18 opened a new pull request, #1005: formatted java.lang package.
esivakumar18 opened a new pull request, #1005: URL: https://github.com/apache/commons-lang/pull/1005 formatted java.lang package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] opened a new pull request, #108: Bump easymock from 5.0.1 to 5.1.0
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/commons-ognl/pull/108 Bumps [easymock](https://github.com/easymock/easymock) from 5.0.1 to 5.1.0. Release notes Sourced from https://github.com/easymock/easymock/releases";>easymock's releases. 5.1.0 Main a performance fix caused by ByteBuddy causing OOME. Change log Typecache for create mock classes (https://github-redirect.dependabot.com/easymock/easymock/pull/353";>#353) Bump versions-maven-plugin from 2.14.1 to 2.14.2 (https://github-redirect.dependabot.com/easymock/easymock/pull/352";>#352) Bump wagon-ssh-external from 3.5.2 to 3.5.3 (https://github-redirect.dependabot.com/easymock/easymock/pull/351";>#351) Bump byte-buddy from 1.12.19 to 1.12.20 (https://github-redirect.dependabot.com/easymock/easymock/pull/350";>#350) Bump versions-maven-plugin from 2.14.0 to 2.14.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/349";>#349) Bump versions-maven-plugin from 2.13.0 to 2.14.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/348";>#348) Bump testng from 7.5 to 7.7.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/347";>#347) Bump maven-dependency-plugin from 3.3.0 to 3.4.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/345";>#345) Bump checkstyle from 10.4 to 10.5.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/344";>#344) java.lang.NullPointerException at org.easymock.internal.ClassProxyFactory.classPackage(ClassProxyFactory.java:178) (https://github-redirect.dependabot.com/easymock/easymock/issues/343";>#343) EasyMock 5.0.1 OOM on large project (https://github-redirect.dependabot.com/easymock/easymock/issues/338";>#338) Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.3.0 (https://github-redirect.dependabot.com/easymock/easymock/pull/337";>#337) Bump checkstyle from 10.3.4 to 10.4 (https://github-redirect.dependabot.com/easymock/easymock/pull/336";>#336) Bump maven-shade-plugin from 3.4.0 to 3.4.1 (https://github-redirect.dependabot.com/easymock/easymock/pull/335";>#335) Add cache for mocked types. (https://github-redirect.dependabot.com/easymock/easymock/pull/334";>#334) Mock serialization doesn't work (https://github-redirect.dependabot.com/easymock/easymock/issues/312";>#312) Commits https://github.com/easymock/easymock/commit/f1b53a1f97cf20e90733dd1aa20b224917a16f2e";>f1b53a1 Move to version 5.1.0 https://github.com/easymock/easymock/commit/b08bff3d78c91f1e4bfc30d33a02e6d83c7f631d";>b08bff3 Test fails. Probably PowerMock do not create null packages anymore https://github.com/easymock/easymock/commit/c9e2dd1140672300139f75ec66db0fe297d1ed9d";>c9e2dd1 Make sure class without a package, like the ones PowerMock creates are workin... https://github.com/easymock/easymock/commit/8eaac71a8aa00075e198fbabcd8718bfc7594eee";>8eaac71 Remove unused imports https://github.com/easymock/easymock/commit/a6f7834cb3342e5c4c065e6462e408121a85adc8";>a6f7834 Update github pages https://github.com/easymock/easymock/commit/a48158b552aa350c50b7ca0e26c75507556a0760";>a48158b Ignore animal sniffer when it goes wrong https://github.com/easymock/easymock/commit/94a5d5e680618dca86e50d83fca9e450c2cd0278";>94a5d5e Rename to ClassMockingData since it represents more reality https://github.com/easymock/easymock/commit/0c2b5c21c0337f5d540bf1374b5e85257c30a622";>0c2b5c2 Mocks are now serializable https://github.com/easymock/easymock/commit/05d69946b1d19fa9a2011ea9f8a083a2316a100c";>05d6994 We need to separate handlers between mocks of the same class but not need to ... https://github.com/easymock/easymock/commit/3e0ebf515541c71909feda4ef4011dc912fe0a9a";>3e0ebf5 Attempt to use TypeCache. ClassProxyFactoryTest is failing Additional commits viewable in https://github.com/easymock/easymock/compare/easymock-5.0.1...easymock-5.1.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash an
