[GitHub] [commons-compress] codecov-commenter commented on pull request #353: Make 'ZipFile.offsetComparator' static
codecov-commenter commented on PR #353: URL: https://github.com/apache/commons-compress/pull/353#issuecomment-1382620550 # [Codecov](https://codecov.io/gh/apache/commons-compress/pull/353?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#353](https://codecov.io/gh/apache/commons-compress/pull/353?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (88285f0) into [master](https://codecov.io/gh/apache/commons-compress/commit/5569702d493cfc34ca701a9cb25cbbe41c8a7201?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5569702) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. ```diff @@Coverage Diff@@ ## master #353 +/- ## = Coverage 80.44% 80.44% - Complexity 6722 6723+1 = Files 343 343 Lines 2532525325 Branches 4107 4107 = + Hits 2037220373+1 Misses 3366 3366 + Partials 1587 1586-1 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-compress/pull/353?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...apache/commons/compress/archivers/zip/ZipFile.java](https://codecov.io/gh/apache/commons-compress/pull/353?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3ppcC9aaXBGaWxlLmphdmE=) | `78.44% <100.00%> (ø)` | | | [.../commons/compress/compressors/bzip2/BlockSort.java](https://codecov.io/gh/apache/commons-compress/pull/353?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvY29tcHJlc3NvcnMvYnppcDIvQmxvY2tTb3J0LmphdmE=) | `85.14% <0.00%> (+0.23%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-683) Thread safety issue in VFSClassLoader - NullPointerException thrown
[
https://issues.apache.org/jira/browse/VFS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676792#comment-17676792
]
Gary D. Gregory commented on VFS-683:
-
Except that there are failures in builds that seem random but must be related.
> Thread safety issue in VFSClassLoader - NullPointerException thrown
> ---
>
> Key: VFS-683
> URL: https://issues.apache.org/jira/browse/VFS-683
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Daryl Odnert
>Assignee: Gary D. Gregory
>Priority: Major
> Attachments: Main.java
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In my application, I have two instances of the {{VFSClassLoader}}, each of
> which is being used in a distinct thread. Both {{VFSClassLoader}} instances
> refer to the same compressed file resource described by a {{FileObject}} that
> is passed to the class loader's constructor. Intermittently, the application
> throws an exception with the stack trace shown below. So, there seems to be
> either a race condition in the code or an undocumented assumption here. If it
> is unsupported for two {{VFSClassLoader}} instances to refer to the same
> resource (file), then that assumption should be documented. But if that is
> not the case, then there is a race condition bug in the implementation.
> {noformat}
> 43789 WARN {} c.a.e.u.PreferredPathClassLoader - While loading class
> org.apache.hive.jdbc.HiveDatabaseMetaData, rethrowing unexpected
> java.lang.NullPointerException: Inflater has been closed
> java.lang.NullPointerException: Inflater has been closed
> at java.util.zip.Inflater.ensureOpen(Inflater.java:389)
> at java.util.zip.Inflater.inflate(Inflater.java:257)
> at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:152)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> at
> org.apache.commons.vfs2.util.MonitorInputStream.read(MonitorInputStream.java:91)
> at org.apache.commons.vfs2.FileUtil.getContent(FileUtil.java:47)
> at org.apache.commons.vfs2.impl.Resource.getBytes(Resource.java:102)
> at
> org.apache.commons.vfs2.impl.VFSClassLoader.defineClass(VFSClassLoader.java:179)
> at
> org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:150)
> at
> com.atscale.engine.utils.PreferredPathClassLoader.findClass(PreferredPathClassLoader.scala:54)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-validator] garydgregory merged pull request #114: Bump actions/cache from 3.2.2 to 3.2.3
garydgregory merged PR #114: URL: https://github.com/apache/commons-validator/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] garydgregory merged pull request #159: Bump actions/cache from 3.2.2 to 3.2.3
garydgregory merged PR #159: URL: https://github.com/apache/commons-beanutils/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] codecov-commenter commented on pull request #159: Bump actions/cache from 3.2.2 to 3.2.3
codecov-commenter commented on PR #159: URL: https://github.com/apache/commons-beanutils/pull/159#issuecomment-1382572333 # [Codecov](https://codecov.io/gh/apache/commons-beanutils/pull/159?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#159](https://codecov.io/gh/apache/commons-beanutils/pull/159?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (caf7b38) into [master](https://codecov.io/gh/apache/commons-beanutils/commit/1b251e689d18e516bbd850894166bfde23b09918?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1b251e6) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #159 +/- ## = Coverage 64.56% 64.56% Complexity 1555 1555 = Files 105 105 Lines 5794 5794 Branches 1059 1059 = Hits 3741 3741 Misses 1607 1607 Partials446 446 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] codecov-commenter commented on pull request #114: Bump actions/cache from 3.2.2 to 3.2.3
codecov-commenter commented on PR #114: URL: https://github.com/apache/commons-validator/pull/114#issuecomment-1382568229 # [Codecov](https://codecov.io/gh/apache/commons-validator/pull/114?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#114](https://codecov.io/gh/apache/commons-validator/pull/114?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ec7de42) into [master](https://codecov.io/gh/apache/commons-validator/commit/3ce032b9876178f5b3337b7376bb2fa8f40cd725?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3ce032b) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #114 +/- ## = Coverage 71.90% 71.90% Complexity 1137 1137 = Files63 63 Lines 3157 3157 Branches542 542 = Hits 2270 2270 Misses 693 693 Partials194 194 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] opened a new pull request, #159: Bump actions/cache from 3.2.2 to 3.2.3
dependabot[bot] opened a new pull request, #159: URL: https://github.com/apache/commons-beanutils/pull/159 Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.2.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.2.3 What's Changed Add Mint example by https://github.com/uhooi;>@uhooi in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Fixed broken link by https://github.com/kotewar;>@kotewar in https://github-redirect.dependabot.com/actions/cache/pull/1057;>actions/cache#1057 Add support to opt-in enable cross-os caching on windows by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1056;>actions/cache#1056 Release support for cross-os caching as opt-in feature by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1060;>actions/cache#1060 New Contributors https://github.com/uhooi;>@uhooi made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Full Changelog: https://github.com/actions/cache/compare/v3...v3.2.3;>https://github.com/actions/cache/compare/v3...v3.2.3 Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.2.2 Reverted the changes made in 3.2.1 to use gnu tar and zstd by default on windows. 3.2.3 Support cross os caching on Windows as an opt-in feature. Fix issue with symlink restoration on Windows for cross-os caches. Commits https://github.com/actions/cache/commit/58c146cc91c5b9e778e71775dfe9bf1442ad9a12;>58c146c Release support for cross-os caching as opt-in feature (https://github-redirect.dependabot.com/actions/cache/issues/1060;>#1060) https://github.com/actions/cache/commit/6fd2d4538ca777f67fccddb233cf1a8ff1339012;>6fd2d45 Add support to opt-in enable cross-os caching on windows (https://github-redirect.dependabot.com/actions/cache/issues/1056;>#1056) https://github.com/actions/cache/commit/1f414295fe1e1bab9fb9b7ef11ce3f9fe556343c;>1f41429 Fixed broken link (https://github-redirect.dependabot.com/actions/cache/issues/1057;>#1057) https://github.com/actions/cache/commit/365406cb701e1cc758077b05049298a49a8b71c2;>365406c Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/1051;>#1051 from uhooi/feature/add_mint_example https://github.com/actions/cache/commit/d6217569d58fbcf42f4bdf873fd06820f76724c2;>d621756 Update Mint example https://github.com/actions/cache/commit/84e54000da2dc6a631a786445872e84be33086ea;>84e5400 Merge remote-tracking branch 'origin/main' into feature/add_mint_example See full diff in https://github.com/actions/cache/compare/v3.2.2...v3.2.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[GitHub] [commons-validator] dependabot[bot] opened a new pull request, #114: Bump actions/cache from 3.2.2 to 3.2.3
dependabot[bot] opened a new pull request, #114: URL: https://github.com/apache/commons-validator/pull/114 Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.2.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.2.3 What's Changed Add Mint example by https://github.com/uhooi;>@uhooi in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Fixed broken link by https://github.com/kotewar;>@kotewar in https://github-redirect.dependabot.com/actions/cache/pull/1057;>actions/cache#1057 Add support to opt-in enable cross-os caching on windows by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1056;>actions/cache#1056 Release support for cross-os caching as opt-in feature by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1060;>actions/cache#1060 New Contributors https://github.com/uhooi;>@uhooi made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Full Changelog: https://github.com/actions/cache/compare/v3...v3.2.3;>https://github.com/actions/cache/compare/v3...v3.2.3 Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.2.2 Reverted the changes made in 3.2.1 to use gnu tar and zstd by default on windows. 3.2.3 Support cross os caching on Windows as an opt-in feature. Fix issue with symlink restoration on Windows for cross-os caches. Commits https://github.com/actions/cache/commit/58c146cc91c5b9e778e71775dfe9bf1442ad9a12;>58c146c Release support for cross-os caching as opt-in feature (https://github-redirect.dependabot.com/actions/cache/issues/1060;>#1060) https://github.com/actions/cache/commit/6fd2d4538ca777f67fccddb233cf1a8ff1339012;>6fd2d45 Add support to opt-in enable cross-os caching on windows (https://github-redirect.dependabot.com/actions/cache/issues/1056;>#1056) https://github.com/actions/cache/commit/1f414295fe1e1bab9fb9b7ef11ce3f9fe556343c;>1f41429 Fixed broken link (https://github-redirect.dependabot.com/actions/cache/issues/1057;>#1057) https://github.com/actions/cache/commit/365406cb701e1cc758077b05049298a49a8b71c2;>365406c Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/1051;>#1051 from uhooi/feature/add_mint_example https://github.com/actions/cache/commit/d6217569d58fbcf42f4bdf873fd06820f76724c2;>d621756 Update Mint example https://github.com/actions/cache/commit/84e54000da2dc6a631a786445872e84be33086ea;>84e5400 Merge remote-tracking branch 'origin/main' into feature/add_mint_example See full diff in https://github.com/actions/cache/compare/v3.2.2...v3.2.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[jira] [Work logged] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?focusedWorklogId=839179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839179
]
ASF GitHub Bot logged work on IMAGING-342:
--
Author: ASF GitHub Bot
Created on: 13/Jan/23 22:52
Start Date: 13/Jan/23 22:52
Worklog Time Spent: 10m
Work Description: kinow commented on PR #268:
URL: https://github.com/apache/commons-imaging/pull/268#issuecomment-1382556757
Merged!
Issue Time Tracking
---
Worklog Id: (was: 839179)
Time Spent: 0.5h (was: 20m)
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Affects Versions: 1.0-alpha2
>Reporter: Glavo
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: 1.0-alpha3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved IMAGING-342.
Resolution: Fixed
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Affects Versions: 1.0-alpha2
>Reporter: Glavo
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: 1.0-alpha3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?focusedWorklogId=839178=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839178
]
ASF GitHub Bot logged work on IMAGING-342:
--
Author: ASF GitHub Bot
Created on: 13/Jan/23 22:52
Start Date: 13/Jan/23 22:52
Worklog Time Spent: 10m
Work Description: kinow closed pull request #268: [IMAGING-342] Read PNG
metadata from iTXt chunk
URL: https://github.com/apache/commons-imaging/pull/268
Issue Time Tracking
---
Worklog Id: (was: 839178)
Time Spent: 20m (was: 10m)
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Affects Versions: 1.0-alpha2
>Reporter: Glavo
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: 1.0-alpha3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-imaging] kinow commented on pull request #268: [IMAGING-342] Read PNG metadata from iTXt chunk
kinow commented on PR #268: URL: https://github.com/apache/commons-imaging/pull/268#issuecomment-1382556757 Merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #268: [IMAGING-342] Read PNG metadata from iTXt chunk
kinow closed pull request #268: [IMAGING-342] Read PNG metadata from iTXt chunk URL: https://github.com/apache/commons-imaging/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated IMAGING-342:
---
Affects Version/s: 1.0-alpha2
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Affects Versions: 1.0-alpha2
>Reporter: Glavo
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated IMAGING-342:
---
Fix Version/s: 1.0-alpha3
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Affects Versions: 1.0-alpha2
>Reporter: Glavo
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Fix For: 1.0-alpha3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated IMAGING-342:
---
Assignee: Bruno P. Kinoshita
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Reporter: Glavo
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (IMAGING-342) Read PNG metadata from iTXt chunk
[
https://issues.apache.org/jira/browse/IMAGING-342?focusedWorklogId=839165=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839165
]
ASF GitHub Bot logged work on IMAGING-342:
--
Author: ASF GitHub Bot
Created on: 13/Jan/23 22:25
Start Date: 13/Jan/23 22:25
Worklog Time Spent: 10m
Work Description: Glavo commented on PR #268:
URL: https://github.com/apache/commons-imaging/pull/268#issuecomment-1382460788
I added a test to check whether the metadata with Unicode characters can be
correctly obtained from PNG images.
Issue Time Tracking
---
Worklog Id: (was: 839165)
Remaining Estimate: 0h
Time Spent: 10m
> Read PNG metadata from iTXt chunk
> -
>
> Key: IMAGING-342
> URL: https://issues.apache.org/jira/browse/IMAGING-342
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
>Reporter: Glavo
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In [PNG
> specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
> {{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}}
> chunks, but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}}
> chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-imaging] Glavo commented on pull request #268: [IMAGING-342] Read PNG metadata from iTXt chunk
Glavo commented on PR #268: URL: https://github.com/apache/commons-imaging/pull/268#issuecomment-1382460788 I added a test to check whether the metadata with Unicode characters can be correctly obtained from PNG images. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #354: Bump slf4j.version from 1.7.36 to 2.0.6
garydgregory commented on PR #354: URL: https://github.com/apache/commons-vfs/pull/354#issuecomment-1382454089 Close: Not now. Sorting out change near release time. Try it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #354: Bump slf4j.version from 1.7.36 to 2.0.6
dependabot[bot] commented on PR #354: URL: https://github.com/apache/commons-vfs/pull/354#issuecomment-1382454125 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #354: Bump slf4j.version from 1.7.36 to 2.0.6
garydgregory closed pull request #354: Bump slf4j.version from 1.7.36 to 2.0.6 URL: https://github.com/apache/commons-vfs/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #300: VFS-824 HttpFileSystem free Unused Resources lead to HttpClient Conn…
garydgregory commented on PR #300: URL: https://github.com/apache/commons-vfs/pull/300#issuecomment-1382453475 It's possible one of these changes is breaking the build randomly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] closed pull request #360: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] closed pull request #360: Bump checkstyle from 9.3 to 10.6.0 URL: https://github.com/apache/commons-vfs/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #360: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] commented on PR #360: URL: https://github.com/apache/commons-vfs/pull/360#issuecomment-1382451613 Looks like com.puppycrawl.tools:checkstyle is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #366: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] commented on PR #366: URL: https://github.com/apache/commons-vfs/pull/366#issuecomment-1382448208 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #366: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
garydgregory closed pull request #366: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-vfs/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #366: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
garydgregory commented on PR #366: URL: https://github.com/apache/commons-vfs/pull/366#issuecomment-1382448177 Closing: Picking up version from parent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (IMAGING-342) Read PNG metadata from iTXt chunk
Glavo created IMAGING-342:
-
Summary: Read PNG metadata from iTXt chunk
Key: IMAGING-342
URL: https://issues.apache.org/jira/browse/IMAGING-342
Project: Commons Imaging
Issue Type: Improvement
Components: Format: PNG
Reporter: Glavo
In [PNG
specification|http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.Anc-text],
{{iTXt}} chunk is semantically equivalent to the {{tEXt}} and {{zTXt}} chunks,
but {{PngImageParser::getMetadata}} does not recognize the {{iTXt}} chunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-text] dependabot[bot] closed pull request #402: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] closed pull request #402: Bump checkstyle from 9.3 to 10.6.0 URL: https://github.com/apache/commons-text/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] commented on pull request #402: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] commented on PR #402: URL: https://github.com/apache/commons-text/pull/402#issuecomment-1382439843 Looks like com.puppycrawl.tools:checkstyle is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] closed pull request #374: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] closed pull request #374: Bump checkstyle from 9.3 to 10.6.0 URL: https://github.com/apache/commons-collections/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] commented on pull request #374: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] commented on PR #374: URL: https://github.com/apache/commons-collections/pull/374#issuecomment-1382438692 Looks like com.puppycrawl.tools:checkstyle is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] closed pull request #160: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] closed pull request #160: Bump checkstyle from 9.3 to 10.6.0 URL: https://github.com/apache/commons-release-plugin/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] commented on pull request #160: Bump checkstyle from 9.3 to 10.6.0
dependabot[bot] commented on PR #160: URL: https://github.com/apache/commons-release-plugin/pull/160#issuecomment-1382433966 Looks like com.puppycrawl.tools:checkstyle is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] ivakegg commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
ivakegg commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070092818
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
+List exceptions = new ArrayList<>();
+Thread.UncaughtExceptionHandler handler = new
Thread.UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+synchronized(exceptions) {
+exceptions.add(e);
+}
+}
+};
+ThreadFactory factory = new
ThreadFactoryBuilder().setUncaughtExceptionHandler(handler).build();
+Queue rejections = new LinkedList<>();
+RejectedExecutionHandler rejectionHandler = new
RejectedExecutionHandler() {
+@Override
+public void rejectedExecution(Runnable r, ThreadPoolExecutor
executor) {
+synchronized(rejections) {
+rejections.add(r);
+}
+}
+};
+ThreadPoolExecutor executor = new ThreadPoolExecutor(THREADS, THREADS,
0, TimeUnit.SECONDS, workQueue, factory, rejectionHandler);
+executor.prestartAllCoreThreads();
+for (int i = 0; i < THREADS; i++) {
+VFSClassLoader loader = createClassLoader();
+workQueue.put(new VfsClassLoaderTests.LoadClass(loader));
+}
+while (!workQueue.isEmpty()) {
+Thread.sleep(10);
+}
+while (!rejections.isEmpty() && executor.getActiveCount() > 0) {
+List rejected = new ArrayList<>();
+synchronized(rejections) {
+rejected.addAll(rejections);
+rejections.clear();
+}
+workQueue.addAll(rejected);
+}
+executor.shutdown();
+executor.awaitTermination(30, TimeUnit.SECONDS);
+assertEquals(THREADS, executor.getCompletedTaskCount());
+if (!exceptions.isEmpty()) {
+for (Throwable t : exceptions) {
+System.out.println(t.toString());
Review Comment:
sorry, left over from testing
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
+List exceptions = new ArrayList<>();
+Thread.UncaughtExceptionHandler handler = new
Thread.UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+synchronized(exceptions) {
+exceptions.add(e);
+}
+}
+};
+ThreadFactory factory = new
ThreadFactoryBuilder().setUncaughtExceptionHandler(handler).build();
+Queue rejections = new LinkedList<>();
+RejectedExecutionHandler rejectionHandler = new
RejectedExecutionHandler() {
+@Override
+public void rejectedExecution(Runnable r, ThreadPoolExecutor
executor) {
+synchronized(rejections) {
+rejections.add(r);
+}
+}
+};
+ThreadPoolExecutor executor = new ThreadPoolExecutor(THREADS, THREADS,
0, TimeUnit.SECONDS, workQueue, factory, rejectionHandler);
+executor.prestartAllCoreThreads();
+for (int i = 0; i < THREADS; i++) {
+VFSClassLoader loader = createClassLoader();
+workQueue.put(new VfsClassLoaderTests.LoadClass(loader));
+}
+while (!workQueue.isEmpty()) {
+Thread.sleep(10);
+}
+while (!rejections.isEmpty() && executor.getActiveCount() > 0) {
+List rejected = new ArrayList<>();
+synchronized(rejections) {
+rejected.addAll(rejections);
+rejections.clear();
+}
+workQueue.addAll(rejected);
+}
+executor.shutdown();
+executor.awaitTermination(30, TimeUnit.SECONDS);
+assertEquals(THREADS, executor.getCompletedTaskCount());
+if (!exceptions.isEmpty()) {
+for (Throwable t : exceptions) {
+System.out.println(t.toString());
+t.printStackTrace(System.out);
+}
+}
+assertTrue(exceptions.size() + " threads failed",
exceptions.isEmpty());
+}
+
+private class LoadClass implements Runnable {
+private final VFSClassLoader loader;
[GitHub] [commons-vfs] ivakegg commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
ivakegg commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070092531
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -97,8 +102,10 @@ public static byte[] getContentAsByteArray(final FileObject
file) throws IOExcep
* @since 2.4
*/
public static String getContentAsString(final FileObject file, final
Charset charset) throws IOException {
-try (FileContent content = file.getContent()) {
-return content.getString(charset);
+synchronized(file.getFileSystem()) {
Review Comment:
will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] ivakegg commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
ivakegg commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070092374
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -82,8 +82,13 @@ public static AbstractFileObject getAbstractFileObject(final
FileObject fileObje
* @since 2.6.0
*/
public static byte[] getContentAsByteArray(final FileObject file) throws
IOException {
-try (FileContent content = file.getContent()) {
-return content.getByteArray();
+synchronized(file.getFileSystem()) {
Review Comment:
will do
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -82,8 +82,13 @@ public static AbstractFileObject getAbstractFileObject(final
FileObject fileObje
* @since 2.6.0
*/
public static byte[] getContentAsByteArray(final FileObject file) throws
IOException {
-try (FileContent content = file.getContent()) {
-return content.getByteArray();
+synchronized(file.getFileSystem()) {
+try (FileContent content = file.getContent()) {
+return content.getByteArray();
+} catch (NullPointerException npe) {
+System.out.println("break here");
Review Comment:
woops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070092163
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
+List exceptions = new ArrayList<>();
+Thread.UncaughtExceptionHandler handler = new
Thread.UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+synchronized(exceptions) {
+exceptions.add(e);
+}
+}
+};
+ThreadFactory factory = new
ThreadFactoryBuilder().setUncaughtExceptionHandler(handler).build();
+Queue rejections = new LinkedList<>();
+RejectedExecutionHandler rejectionHandler = new
RejectedExecutionHandler() {
+@Override
+public void rejectedExecution(Runnable r, ThreadPoolExecutor
executor) {
+synchronized(rejections) {
+rejections.add(r);
+}
+}
+};
+ThreadPoolExecutor executor = new ThreadPoolExecutor(THREADS, THREADS,
0, TimeUnit.SECONDS, workQueue, factory, rejectionHandler);
+executor.prestartAllCoreThreads();
+for (int i = 0; i < THREADS; i++) {
+VFSClassLoader loader = createClassLoader();
+workQueue.put(new VfsClassLoaderTests.LoadClass(loader));
+}
+while (!workQueue.isEmpty()) {
+Thread.sleep(10);
+}
+while (!rejections.isEmpty() && executor.getActiveCount() > 0) {
+List rejected = new ArrayList<>();
+synchronized(rejections) {
+rejected.addAll(rejections);
+rejections.clear();
+}
+workQueue.addAll(rejected);
+}
+executor.shutdown();
+executor.awaitTermination(30, TimeUnit.SECONDS);
+assertEquals(THREADS, executor.getCompletedTaskCount());
+if (!exceptions.isEmpty()) {
+for (Throwable t : exceptions) {
+System.out.println(t.toString());
Review Comment:
No console output, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070091466
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
+List exceptions = new ArrayList<>();
+Thread.UncaughtExceptionHandler handler = new
Thread.UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+synchronized(exceptions) {
+exceptions.add(e);
+}
+}
+};
+ThreadFactory factory = new
ThreadFactoryBuilder().setUncaughtExceptionHandler(handler).build();
+Queue rejections = new LinkedList<>();
+RejectedExecutionHandler rejectionHandler = new
RejectedExecutionHandler() {
+@Override
+public void rejectedExecution(Runnable r, ThreadPoolExecutor
executor) {
+synchronized(rejections) {
+rejections.add(r);
+}
+}
+};
+ThreadPoolExecutor executor = new ThreadPoolExecutor(THREADS, THREADS,
0, TimeUnit.SECONDS, workQueue, factory, rejectionHandler);
+executor.prestartAllCoreThreads();
+for (int i = 0; i < THREADS; i++) {
+VFSClassLoader loader = createClassLoader();
+workQueue.put(new VfsClassLoaderTests.LoadClass(loader));
+}
+while (!workQueue.isEmpty()) {
+Thread.sleep(10);
+}
+while (!rejections.isEmpty() && executor.getActiveCount() > 0) {
+List rejected = new ArrayList<>();
+synchronized(rejections) {
+rejected.addAll(rejections);
+rejections.clear();
+}
+workQueue.addAll(rejected);
+}
+executor.shutdown();
+executor.awaitTermination(30, TimeUnit.SECONDS);
+assertEquals(THREADS, executor.getCompletedTaskCount());
+if (!exceptions.isEmpty()) {
+for (Throwable t : exceptions) {
+System.out.println(t.toString());
+t.printStackTrace(System.out);
+}
+}
+assertTrue(exceptions.size() + " threads failed",
exceptions.isEmpty());
+}
+
+private class LoadClass implements Runnable {
+private final VFSClassLoader loader;
+public LoadClass(VFSClassLoader loader) {
+this.loader = loader;
+}
+
+@Override
+public void run() {
+try {
+final Class testClass =
loader.findClass("code.ClassToLoad");
+final Package pack = testClass.getPackage();
+assertEquals("code", pack.getName());
+verifyPackage(pack, false);
+
+final Object testObject = testClass.newInstance();
+assertEquals("**PRIVATE**", testObject.toString());
+} catch (ClassNotFoundException e) {
Review Comment:
Use muilt-catch clause (or just catch ReflectiveOperationException) and
Assert.fail()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070091466
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
+List exceptions = new ArrayList<>();
+Thread.UncaughtExceptionHandler handler = new
Thread.UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+synchronized(exceptions) {
+exceptions.add(e);
+}
+}
+};
+ThreadFactory factory = new
ThreadFactoryBuilder().setUncaughtExceptionHandler(handler).build();
+Queue rejections = new LinkedList<>();
+RejectedExecutionHandler rejectionHandler = new
RejectedExecutionHandler() {
+@Override
+public void rejectedExecution(Runnable r, ThreadPoolExecutor
executor) {
+synchronized(rejections) {
+rejections.add(r);
+}
+}
+};
+ThreadPoolExecutor executor = new ThreadPoolExecutor(THREADS, THREADS,
0, TimeUnit.SECONDS, workQueue, factory, rejectionHandler);
+executor.prestartAllCoreThreads();
+for (int i = 0; i < THREADS; i++) {
+VFSClassLoader loader = createClassLoader();
+workQueue.put(new VfsClassLoaderTests.LoadClass(loader));
+}
+while (!workQueue.isEmpty()) {
+Thread.sleep(10);
+}
+while (!rejections.isEmpty() && executor.getActiveCount() > 0) {
+List rejected = new ArrayList<>();
+synchronized(rejections) {
+rejected.addAll(rejections);
+rejections.clear();
+}
+workQueue.addAll(rejected);
+}
+executor.shutdown();
+executor.awaitTermination(30, TimeUnit.SECONDS);
+assertEquals(THREADS, executor.getCompletedTaskCount());
+if (!exceptions.isEmpty()) {
+for (Throwable t : exceptions) {
+System.out.println(t.toString());
+t.printStackTrace(System.out);
+}
+}
+assertTrue(exceptions.size() + " threads failed",
exceptions.isEmpty());
+}
+
+private class LoadClass implements Runnable {
+private final VFSClassLoader loader;
+public LoadClass(VFSClassLoader loader) {
+this.loader = loader;
+}
+
+@Override
+public void run() {
+try {
+final Class testClass =
loader.findClass("code.ClassToLoad");
+final Package pack = testClass.getPackage();
+assertEquals("code", pack.getName());
+verifyPackage(pack, false);
+
+final Object testObject = testClass.newInstance();
+assertEquals("**PRIVATE**", testObject.toString());
+} catch (ClassNotFoundException e) {
Review Comment:
Use muilt-catch clause and Assert.fail()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070090586
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -82,8 +82,13 @@ public static AbstractFileObject getAbstractFileObject(final
FileObject fileObje
* @since 2.6.0
*/
public static byte[] getContentAsByteArray(final FileObject file) throws
IOException {
-try (FileContent content = file.getContent()) {
-return content.getByteArray();
+synchronized(file.getFileSystem()) {
+try (FileContent content = file.getContent()) {
+return content.getByteArray();
+} catch (NullPointerException npe) {
+System.out.println("break here");
Review Comment:
Remove debugging code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070091033
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
Review Comment:
Use final where you can.
##
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java:
##
@@ -203,6 +214,84 @@ public void testSealing() throws Exception {
verifyPackage(pack, true);
}
+@Test
+public void testThreadSafety() throws Exception {
+final int THREADS = 20;
+BlockingQueue workQueue = new ArrayBlockingQueue<>(THREADS *
2);
+List exceptions = new ArrayList<>();
+Thread.UncaughtExceptionHandler handler = new
Thread.UncaughtExceptionHandler() {
+@Override
+public void uncaughtException(Thread t, Throwable e) {
+synchronized(exceptions) {
+exceptions.add(e);
+}
+}
+};
+ThreadFactory factory = new
ThreadFactoryBuilder().setUncaughtExceptionHandler(handler).build();
+Queue rejections = new LinkedList<>();
+RejectedExecutionHandler rejectionHandler = new
RejectedExecutionHandler() {
+@Override
+public void rejectedExecution(Runnable r, ThreadPoolExecutor
executor) {
+synchronized(rejections) {
Review Comment:
Fix formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070090699
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -97,8 +102,10 @@ public static byte[] getContentAsByteArray(final FileObject
file) throws IOExcep
* @since 2.4
*/
public static String getContentAsString(final FileObject file, final
Charset charset) throws IOException {
-try (FileContent content = file.getContent()) {
-return content.getString(charset);
+synchronized(file.getFileSystem()) {
Review Comment:
Fix formatting (see above)
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -112,8 +119,10 @@ public static String getContentAsString(final FileObject
file, final Charset cha
* @since 2.4
*/
public static String getContentAsString(final FileObject file, final
String charset) throws IOException {
-try (FileContent content = file.getContent()) {
-return content.getString(charset);
+synchronized(file.getFileSystem()) {
Review Comment:
Fix formatting (see above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #367: fixes #VFS-683: class loader thread safety
garydgregory commented on code in PR #367:
URL: https://github.com/apache/commons-vfs/pull/367#discussion_r1070090440
##
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java:
##
@@ -82,8 +82,13 @@ public static AbstractFileObject getAbstractFileObject(final
FileObject fileObje
* @since 2.6.0
*/
public static byte[] getContentAsByteArray(final FileObject file) throws
IOException {
-try (FileContent content = file.getContent()) {
-return content.getByteArray();
+synchronized(file.getFileSystem()) {
Review Comment:
Fix formatting: `synchronized(` -> `synchronized (`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow commented on pull request #167: Bump maven-pmd-plugin from 3.19.0 to 3.20.0
kinow commented on PR #167: URL: https://github.com/apache/commons-release-plugin/pull/167#issuecomment-1382404886 Huh, this PR's checks passed. But upon merging I received the notification from GitHub about errors in the build. I synced my code, and it's complaining about a missing `spotbugs` Maven target... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow commented on pull request #268: Read PNG metadata from iTXt chunk
kinow commented on PR #268: URL: https://github.com/apache/commons-imaging/pull/268#issuecomment-1382403976 I also realized it's hard to know what version of each spec we support, so here's a new one for 1.0 - https://issues.apache.org/jira/browse/IMAGING-341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (IMAGING-341) Commons Imaging must document (in code & docs) what version of each specification is supported
Bruno P. Kinoshita created IMAGING-341: -- Summary: Commons Imaging must document (in code & docs) what version of each specification is supported Key: IMAGING-341 URL: https://issues.apache.org/jira/browse/IMAGING-341 Project: Commons Imaging Issue Type: Improvement Components: Documentation Affects Versions: 1.0-alpha2 Reporter: Bruno P. Kinoshita It is useful for users and devs to know what version of a specification is supported in a parser. For example, this PR, [https://github.com/apache/commons-imaging/pull/269,] is about PNG 1.2 Specification, Version 1.5.0. But it is not easy to know what version we are currently supporting. In some cases, that help also help to decide whether we should merge or postpone pull requests, based on other features, or things missing from the spec that must be implemented. And it is obviously helpful to users of the API to know what version of the spec we support too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (VFS-683) Thread safety issue in VFSClassLoader - NullPointerException thrown
[
https://issues.apache.org/jira/browse/VFS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676766#comment-17676766
]
Ivan Bella commented on VFS-683:
I just submitted a PR that fixes this issue. Using the VFSClassLoader is not
the only way to demonstrate this particular issue. I think my solution is
relatively simple and will alleviate a good set of thread safety issues.
> Thread safety issue in VFSClassLoader - NullPointerException thrown
> ---
>
> Key: VFS-683
> URL: https://issues.apache.org/jira/browse/VFS-683
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Daryl Odnert
>Assignee: Gary D. Gregory
>Priority: Major
> Attachments: Main.java
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In my application, I have two instances of the {{VFSClassLoader}}, each of
> which is being used in a distinct thread. Both {{VFSClassLoader}} instances
> refer to the same compressed file resource described by a {{FileObject}} that
> is passed to the class loader's constructor. Intermittently, the application
> throws an exception with the stack trace shown below. So, there seems to be
> either a race condition in the code or an undocumented assumption here. If it
> is unsupported for two {{VFSClassLoader}} instances to refer to the same
> resource (file), then that assumption should be documented. But if that is
> not the case, then there is a race condition bug in the implementation.
> {noformat}
> 43789 WARN {} c.a.e.u.PreferredPathClassLoader - While loading class
> org.apache.hive.jdbc.HiveDatabaseMetaData, rethrowing unexpected
> java.lang.NullPointerException: Inflater has been closed
> java.lang.NullPointerException: Inflater has been closed
> at java.util.zip.Inflater.ensureOpen(Inflater.java:389)
> at java.util.zip.Inflater.inflate(Inflater.java:257)
> at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:152)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> at
> org.apache.commons.vfs2.util.MonitorInputStream.read(MonitorInputStream.java:91)
> at org.apache.commons.vfs2.FileUtil.getContent(FileUtil.java:47)
> at org.apache.commons.vfs2.impl.Resource.getBytes(Resource.java:102)
> at
> org.apache.commons.vfs2.impl.VFSClassLoader.defineClass(VFSClassLoader.java:179)
> at
> org.apache.commons.vfs2.impl.VFSClassLoader.findClass(VFSClassLoader.java:150)
> at
> com.atscale.engine.utils.PreferredPathClassLoader.findClass(PreferredPathClassLoader.scala:54)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-release-plugin] kinow merged pull request #167: Bump maven-pmd-plugin from 3.19.0 to 3.20.0
kinow merged PR #167: URL: https://github.com/apache/commons-release-plugin/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow merged pull request #166: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
kinow merged PR #166: URL: https://github.com/apache/commons-release-plugin/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] kinow merged pull request #130: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
kinow merged PR #130: URL: https://github.com/apache/commons-logging/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] kinow merged pull request #131: Bump maven-dependency-plugin from 3.4.0 to 3.5.0
kinow merged PR #131: URL: https://github.com/apache/commons-logging/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] kinow merged pull request #379: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
kinow merged PR #379: URL: https://github.com/apache/commons-collections/pull/379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #407: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
kinow merged PR #407: URL: https://github.com/apache/commons-text/pull/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #406: Bump actions/cache from 3.2.2 to 3.2.3
kinow merged PR #406: URL: https://github.com/apache/commons-text/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] ivakegg opened a new pull request, #367: fixes #VFS-683: class loader thread safety
ivakegg opened a new pull request, #367: URL: https://github.com/apache/commons-vfs/pull/367 * To ensure that the closing of files does not interfere with * reading the content, the FileObjectUtils read methods must * be synchronized on the underlying filesystem just like the * close AbstractFileObject close and detach methods. * Added a test case that demostrated the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] codecov-commenter commented on pull request #407: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
codecov-commenter commented on PR #407: URL: https://github.com/apache/commons-text/pull/407#issuecomment-1382333212 # [Codecov](https://codecov.io/gh/apache/commons-text/pull/407?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#407](https://codecov.io/gh/apache/commons-text/pull/407?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (025a940) into [master](https://codecov.io/gh/apache/commons-text/commit/3f97740957e3fa3923be9c9d625f890e2f219624?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3f97740) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #407 +/- ## = Coverage 97.12% 97.12% Complexity 2325 2325 = Files84 84 Lines 5770 5770 Branches935 935 = Hits 5604 5604 Misses 87 87 Partials 79 79 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] codecov-commenter commented on pull request #406: Bump actions/cache from 3.2.2 to 3.2.3
codecov-commenter commented on PR #406: URL: https://github.com/apache/commons-text/pull/406#issuecomment-1382331493 # [Codecov](https://codecov.io/gh/apache/commons-text/pull/406?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#406](https://codecov.io/gh/apache/commons-text/pull/406?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0ee3224) into [master](https://codecov.io/gh/apache/commons-text/commit/3f97740957e3fa3923be9c9d625f890e2f219624?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3f97740) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #406 +/- ## = Coverage 97.12% 97.12% Complexity 2325 2325 = Files84 84 Lines 5770 5770 Branches935 935 = Hits 5604 5604 Misses 87 87 Partials 79 79 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request, #407: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] opened a new pull request, #407: URL: https://github.com/apache/commons-text/pull/407 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.0 to 3.2.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/9f6a75976c0b4b7f5d929de92ba02577f94005cf;>9f6a759 [maven-release-plugin] prepare release maven-checkstyle-plugin-3.2.1 https://github.com/apache/maven-checkstyle-plugin/commit/932c8bcd8953e3634cf8b409e276575c0ad60d3a;>932c8bc [MCHECKSTYLE-423] Explicitly start and end tables with Doxia Sinks in report ... https://github.com/apache/maven-checkstyle-plugin/commit/746a137e5fcf7d68fa7f98c98cfa6f33a7d64e6b;>746a137 update Reproducible Builds badge link https://github.com/apache/maven-checkstyle-plugin/commit/b07adb2e51d6b016dd564893685f46b33fffe5db;>b07adb2 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-3.2.0...maven-checkstyle-plugin-3.2.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request, #406: Bump actions/cache from 3.2.2 to 3.2.3
dependabot[bot] opened a new pull request, #406: URL: https://github.com/apache/commons-text/pull/406 Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.2.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.2.3 What's Changed Add Mint example by https://github.com/uhooi;>@uhooi in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Fixed broken link by https://github.com/kotewar;>@kotewar in https://github-redirect.dependabot.com/actions/cache/pull/1057;>actions/cache#1057 Add support to opt-in enable cross-os caching on windows by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1056;>actions/cache#1056 Release support for cross-os caching as opt-in feature by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1060;>actions/cache#1060 New Contributors https://github.com/uhooi;>@uhooi made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Full Changelog: https://github.com/actions/cache/compare/v3...v3.2.3;>https://github.com/actions/cache/compare/v3...v3.2.3 Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.2.2 Reverted the changes made in 3.2.1 to use gnu tar and zstd by default on windows. 3.2.3 Support cross os caching on Windows as an opt-in feature. Fix issue with symlink restoration on Windows for cross-os caches. Commits https://github.com/actions/cache/commit/58c146cc91c5b9e778e71775dfe9bf1442ad9a12;>58c146c Release support for cross-os caching as opt-in feature (https://github-redirect.dependabot.com/actions/cache/issues/1060;>#1060) https://github.com/actions/cache/commit/6fd2d4538ca777f67fccddb233cf1a8ff1339012;>6fd2d45 Add support to opt-in enable cross-os caching on windows (https://github-redirect.dependabot.com/actions/cache/issues/1056;>#1056) https://github.com/actions/cache/commit/1f414295fe1e1bab9fb9b7ef11ce3f9fe556343c;>1f41429 Fixed broken link (https://github-redirect.dependabot.com/actions/cache/issues/1057;>#1057) https://github.com/actions/cache/commit/365406cb701e1cc758077b05049298a49a8b71c2;>365406c Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/1051;>#1051 from uhooi/feature/add_mint_example https://github.com/actions/cache/commit/d6217569d58fbcf42f4bdf873fd06820f76724c2;>d621756 Update Mint example https://github.com/actions/cache/commit/84e54000da2dc6a631a786445872e84be33086ea;>84e5400 Merge remote-tracking branch 'origin/main' into feature/add_mint_example See full diff in https://github.com/actions/cache/compare/v3.2.2...v3.2.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069961097
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
See also:
- https://en.wikipedia.org/wiki/List_of_Usenet_newsreaders
and/or
- https://en.wikipedia.org/wiki/Newsreader_(Usenet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069961097
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
See also: https://en.wikipedia.org/wiki/List_of_Usenet_newsreaders and/or
https://en.wikipedia.org/wiki/Newsreader_(Usenet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069961097
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
See also: https://en.wikipedia.org/wiki/List_of_Usenet_newsreaders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069943615
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
What about this: https://www.newsgroupreviews.com/newsgroup-readers.html,
see title? Saw it more often recently in this form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069943615
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
What about this: https://www.newsgroupreviews.com/newsgroup-readers.html,
see title? Saw it more recently in this form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1069940736 ## src/main/java/org/apache/commons/net/nntp/Threader.java: ## @@ -56,29 +55,29 @@ private void buildContainer(final Threadable threadable, final HashMap
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069940079
##
src/main/java/org/apache/commons/net/nntp/NewGroupsOrNewsQuery.java:
##
@@ -246,7 +246,7 @@ public boolean isGMT() {
*
*
*
- * @param newsgroup The newsgroup to add to the list of groups to be
checked for new news, but which should be omitted from the search for new news..
+ * @param newsgroup The newsgroup to add to the list of groups to be
checked for new news, but which should be omitted from the search for recent
news.
Review Comment:
Why "fresh" before and "recent" here? Using "recent" for both would be more
consistent IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141: URL: https://github.com/apache/commons-net/pull/141#discussion_r1069939428 ## src/main/java/org/apache/commons/net/nntp/NNTPClient.java: ## @@ -1283,7 +1283,7 @@ public boolean selectArticle(final long articleNumber, final ArticleInfo pointer /** * Same as selectArticle(articleId, (ArticleInfo) null) * - * @param articleId the article Id + * @param articleId the article's identifier Review Comment: Superfluous change IMO, this change makes the text wordier, it was clearer to me previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069937369
##
src/main/java/org/apache/commons/net/nntp/NNTPClient.java:
##
@@ -583,12 +583,12 @@ private void parseArticlePointer(final String reply,
final ArticleInfo pointer)
* due to malformed headers.
*
* You must not issue any commands to the NNTP server (i.e., call any
(other methods) until you finish writing to the returned Writer instance and
close it.
- * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore the returned Writer actually writes directly to
+ * The NNTP protocol uses the same stream for issuing commands as it does
for returning results. Therefore, the returned Writer actually writes directly
to
* the NNTP connection. After you close the writer, you can execute new
commands. If you do not follow these requirements your program will not work
* properly.
*
* Different NNTP servers will require different header formats, but you
can use the provided {@link org.apache.commons.net.nntp.SimpleNNTPHeader} class
to
- * construct the bare minimum acceptable header for most news readers. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
+ * construct the bare minimum acceptable header for most newsreaders. To
construct more complicated headers you should refer to RFC 822. When the Java
Mail
Review Comment:
"newsreaders" is not a word AFAIK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069936711
##
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java:
##
@@ -234,7 +234,7 @@ public FTPFile parseFTPEntry(final String entry) {
if (intType == null) {
file.setType(FTPFile.UNKNOWN_TYPE);
} else {
-file.setType(intType.intValue());
+file.setType(intType);
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069936269
##
src/main/java/org/apache/commons/net/imap/IMAP.java:
##
@@ -374,7 +374,7 @@ public int sendCommand(final String command, final String
args) throws IOExcepti
* @param commandID The ID (tag) of the command.
* @param command The IMAP command to send.
* @param args The command arguments.
- * @return The server reply code (either IMAPReply.OK, IMAPReply.NO or
IMAPReply.BAD).
+ * @return The server reply code (either {@code IMAPReply.OK}, {@code
IMAPReply.NO} or {@code IMAPReply.BAD}).
Review Comment:
Probably use @link for these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069935368
##
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java:
##
@@ -64,10 +64,10 @@ public class MLSxEntryParser extends FTPFileEntryParserImpl
{
private static final HashMap TYPE_TO_INT = new
HashMap<>();
static {
-TYPE_TO_INT.put("file", Integer.valueOf(FTPFile.FILE_TYPE));
Review Comment:
Roger, will undo and push once more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069934957
##
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java:
##
@@ -234,7 +234,7 @@ public FTPFile parseFTPEntry(final String entry) {
if (intType == null) {
file.setType(FTPFile.UNKNOWN_TYPE);
} else {
-file.setType(intType.intValue());
+file.setType(intType);
Review Comment:
Please leave boxing/unboxing alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069934643
##
src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java:
##
@@ -64,10 +64,10 @@ public class MLSxEntryParser extends FTPFileEntryParserImpl
{
private static final HashMap TYPE_TO_INT = new
HashMap<>();
static {
-TYPE_TO_INT.put("file", Integer.valueOf(FTPFile.FILE_TYPE));
Review Comment:
Don't change this code: leave boxing/unboxing alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on code in PR #141:
URL: https://github.com/apache/commons-net/pull/141#discussion_r1069933842
##
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##
@@ -204,9 +204,9 @@ public FTPSClient(final String protocol, final boolean
isImplicit) {
/**
* Because there are so many connect() methods, the _connectAction_()
method is provided as a means of performing some action immediately after
establishing
- * a connection, rather than reimplementing all of the connect() methods.
+ * a connection, rather than reimplementing all the connect() methods.
*
- * @throws IOException If it throw by _connectAction_.
+ * @throws IOException If it throws by _connectAction_.
Review Comment:
Err...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1382297314 @garydgregory Could you re-run CI/8/Win, pls? Sth seems weird there: ``` Error: Failures: Error:TFTPServerPathTest.testReadOnly:55 Couldn't clear output location Error: Errors: Error:TFTPServerPathTest.testWriteOutsideHome:116 � Bind Address already in use: Cannot bind ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] closed pull request #113: Bump maven-pmd-plugin from 3.19.0 to 3.20.0
dependabot[bot] closed pull request #113: Bump maven-pmd-plugin from 3.19.0 to 3.20.0 URL: https://github.com/apache/commons-ognl/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] commented on pull request #113: Bump maven-pmd-plugin from 3.19.0 to 3.20.0
dependabot[bot] commented on PR #113: URL: https://github.com/apache/commons-ognl/pull/113#issuecomment-1382292080 Looks like org.apache.maven.plugins:maven-pmd-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] closed pull request #114: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] closed pull request #114: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-ognl/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] commented on pull request #114: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] commented on PR #114: URL: https://github.com/apache/commons-ognl/pull/114#issuecomment-1382291010 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1382282454 > Look at the checks here on GitHub. What is the exact command you ran? did not expect `checkstyle:check` not be part of the regular build. solved it locally, np. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory merged pull request #201: Bump actions/cache from 3.2.2 to 3.2.3
garydgregory merged PR #201: URL: https://github.com/apache/commons-bcel/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1382278764 Look at the checks here on GitHub. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] closed pull request #202: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] closed pull request #202: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-bcel/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] commented on pull request #202: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] commented on PR #202: URL: https://github.com/apache/commons-bcel/pull/202#issuecomment-1382278454 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] garydgregory merged pull request #115: Bump actions/cache from 3.2.2 to 3.2.3
garydgregory merged PR #115: URL: https://github.com/apache/commons-rdf/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #202: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
codecov-commenter commented on PR #202: URL: https://github.com/apache/commons-bcel/pull/202#issuecomment-1382264538 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/202?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#202](https://codecov.io/gh/apache/commons-bcel/pull/202?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4b79156) into [master](https://codecov.io/gh/apache/commons-bcel/commit/9ae356502d973a3674fe65ea9bbfd50f14212bda?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9ae3565) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #202 +/- ## = Coverage 62.44% 62.44% Complexity 3719 3719 = Files 363 363 Lines 1563415634 Branches 1951 1951 = Hits 9762 9762 Misses 4985 4985 Partials887 887 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1382264353 ic, checkstyle is not enabled by default, have to run it separately. will fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] mawiesne commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
mawiesne commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1382262603 > Run a local build with 'mvn' before creating a PR. This PR breaks the build. ``` [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:29 min [INFO] Finished at: 2023-01-13T20:05:50+01:00 [INFO] ``` MacOS, OpenJDK 17.0.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] codecov-commenter commented on pull request #201: Bump actions/cache from 3.2.2 to 3.2.3
codecov-commenter commented on PR #201: URL: https://github.com/apache/commons-bcel/pull/201#issuecomment-1382259648 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/201?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#201](https://codecov.io/gh/apache/commons-bcel/pull/201?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (eb4e515) into [master](https://codecov.io/gh/apache/commons-bcel/commit/9ae356502d973a3674fe65ea9bbfd50f14212bda?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9ae3565) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #201 +/- ## = Coverage 62.44% 62.44% Complexity 3719 3719 = Files 363 363 Lines 1563415634 Branches 1951 1951 = Hits 9762 9762 Misses 4985 4985 Partials887 887 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] opened a new pull request, #114: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] opened a new pull request, #114: URL: https://github.com/apache/commons-ognl/pull/114 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.0 to 3.2.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/9f6a75976c0b4b7f5d929de92ba02577f94005cf;>9f6a759 [maven-release-plugin] prepare release maven-checkstyle-plugin-3.2.1 https://github.com/apache/maven-checkstyle-plugin/commit/932c8bcd8953e3634cf8b409e276575c0ad60d3a;>932c8bc [MCHECKSTYLE-423] Explicitly start and end tables with Doxia Sinks in report ... https://github.com/apache/maven-checkstyle-plugin/commit/746a137e5fcf7d68fa7f98c98cfa6f33a7d64e6b;>746a137 update Reproducible Builds badge link https://github.com/apache/maven-checkstyle-plugin/commit/b07adb2e51d6b016dd564893685f46b33fffe5db;>b07adb2 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-3.2.0...maven-checkstyle-plugin-3.2.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] opened a new pull request, #113: Bump maven-pmd-plugin from 3.19.0 to 3.20.0
dependabot[bot] opened a new pull request, #113: URL: https://github.com/apache/commons-ognl/pull/113 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.19.0 to 3.20.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases;>maven-pmd-plugin's releases. 3.20.0 Bug Fixes https://issues.apache.org/jira/browse/MPMD-335;>MPMD-335 - Aggregate mode doesn't use additional repositories (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/101;>#101) https://github.com/adangel;>@adangel Maintenance https://issues.apache.org/jira/browse/MPMD-361;>MPMD-361 - Explicitly start and end tables with Doxia Sinks in report renderers Dependency updates https://issues.apache.org/jira/browse/MPMD-360;>MPMD-360 - Upgrade to PMD 6.53.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/109;>#109) https://github.com/adangel;>@adangel https://issues.apache.org/jira/browse/MPMD-358;>MPMD-358 - Upgrade to PMD 6.52.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/104;>#104) https://github.com/adangel;>@adangel https://issues.apache.org/jira/browse/MPMD-357;>MPMD-357 - Upgrade to PMD 6.51.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/100;>#100) https://github.com/adangel;>@adangel Bump release-drafter/release-drafter from 5.21.0 to 5.21.1 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/99;>#99) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MPMD-356;>MPMD-356 - Upgrade to PMD 6.50.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/98;>#98) https://github.com/adangel;>@adangel Bump maven-common-artifact-filters from 3.3.1 to 3.3.2 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/95;>#95) https://github.com/dependabot;>@dependabot Bump release-drafter/release-drafter from 5.20.1 to 5.21.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/pull/93;>#93) https://github.com/dependabot;>@dependabot Commits https://github.com/apache/maven-pmd-plugin/commit/55c4d404a1109eded89ae760c92e0cad0b5be10e;>55c4d40 [maven-release-plugin] prepare release maven-pmd-plugin-3.20.0 https://github.com/apache/maven-pmd-plugin/commit/f3e188aed9812c38655b7c42ae5620f1d18705ab;>f3e188a [MPMD-361] Explicitly start and end tables with Doxia Sinks in report renderers https://github.com/apache/maven-pmd-plugin/commit/b65c7a6a7feb7ff25b6316e6aeb80114fc472648;>b65c7a6 [MPMD-360] - Upgrade to PMD 6.53.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/109;>#109) https://github.com/apache/maven-pmd-plugin/commit/3c7a47ef29d75ae5c4b0f50e7579c91ab8b9b867;>3c7a47e Remove method available from super class https://github.com/apache/maven-pmd-plugin/commit/6ee27fccaded3d5477e206f915ef1fe5370a245d;>6ee27fc [MPMD-358] - Upgrade to PMD 6.52.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/104;>#104) https://github.com/apache/maven-pmd-plugin/commit/1dcc7c168f959947af10294ec9c8a7dfd46c42e5;>1dcc7c1 Set next development version to 3.20.0-SNAPSHOT https://github.com/apache/maven-pmd-plugin/commit/255a35a9a5aee4cc5549915d55a4292eed85bb67;>255a35a (doc) Update releasenotes.md https://github.com/apache/maven-pmd-plugin/commit/cd954cc768c4bfc30440cda53c081a4640fe8548;>cd954cc [MPMD-335] - Aggregate mode doesn't use additional repositories https://github.com/apache/maven-pmd-plugin/commit/92434d0d96ebe37a5fb599fa6c3120ab5c7863f1;>92434d0 add Reproducible Builds badge https://github.com/apache/maven-pmd-plugin/commit/7b6623bb49d3bf48f5e8c6b57279bca1cc1e12ef;>7b6623b [MPMD-357] - Upgrade to PMD 6.51.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/100;>#100) Additional commits viewable in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.19.0...maven-pmd-plugin-3.20.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes
[GitHub] [commons-rdf] dependabot[bot] opened a new pull request, #116: Bump rdf4j-bom from 3.7.6 to 4.2.2
dependabot[bot] opened a new pull request, #116:
URL: https://github.com/apache/commons-rdf/pull/116
Bumps [rdf4j-bom](https://github.com/eclipse/rdf4j) from 3.7.6 to 4.2.2.
Release notes
Sourced from https://github.com/eclipse/rdf4j/releases;>rdf4j-bom's
releases.
RDF4J 4.2.2 is now available. This is a patch release fixing 3 bugs.
For more details, have a look at the https://rdf4j.org/release-notes/4.2.2;>release notes.
RDF4J 4.2.1 is now available. This is a patch release fixing 11 bugs, 3
of which are security fixes.
For more details, have a look at the https://rdf4j.org/release-notes/4.2.1;>release notes.
RDF4J 4.2.0 is a minor release introducing support for custom SPARQL
aggregate functions as well as several performance improvements and bug
fixes.
Aggregate functions
The support for custom SPARQL aggregate functions has allowed us to
implement functions for standard deviation and variance using https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/descriptive/SummaryStatistics.html;>Apache
Commons Math3.
IRI
Description
http://rdf4j.org/aggregate#stdev;>http://rdf4j.org/aggregate#stdev
Standard deviation using sampling.
http://rdf4j.org/aggregate#stdev_population;>http://rdf4j.org/aggregate#stdev_population
Standard deviation using statistical population.
http://rdf4j.org/aggregate#variance;>http://rdf4j.org/aggregate#variance
Variance using sampling.
http://rdf4j.org/aggregate#variance_population;>http://rdf4j.org/aggregate#variance_population
Variance using statistical population.
Query example
SELECT (http://rdf4j.org/aggregate#stdev;(?o) AS ?stdev)
WHERE {
?s ?p ?o .
}
Performance
More accurate query statistics for the LMDB Store drastically improves
query performance. The LMDB Store can already scale to considerably larger
datasets than the NativeStore and now also matches the performance for smaller
datasets.
Validation performance for small transactions on large databases has been
improved by batching together more operations when analyzing the changes in a
transaction.
For a complete overview, see https://github.com/eclipse/rdf4j/milestone/85?closed=1;>all issues fixed
in 4.2.0.
RDF4J 4.1.3 is a patch release that fixes 5 issues.
For a complete overview, see https://github.com/eclipse/rdf4j/milestone/87?closed=1;>all issues fixed
in 4.1.3.
Acknowledgements
This release was made possible by contributions from nguyenm100, Håvard
Ottestad, Desislava Hristova, pulquero and Wolfgang Schell.
RDF4J 4.1.2 is a patch release that fixes 6 issues.
For a complete overview, see https://github.com/eclipse/rdf4j/milestone/86?closed=1;>all issues fixed
in 4.1.2.
Acknowledgements
This release was made possible by contributions from Jerven Bolleman,
Håvard Ottestad, Wolfgang Schell and nguyenm100.
... (truncated)
Commits
https://github.com/eclipse/rdf4j/commit/3f019e3e262751eb046bbdbc751d28c90a5ea87b;>3f019e3
release 4.2.2
https://github.com/eclipse/rdf4j/commit/865e2e382eedb77b96be86011b363912401f3ccd;>865e2e3
https://github-redirect.dependabot.com/eclipse/rdf4j/issues/3781;>GH-3781
Accept only valid SPARQL prefixes (https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4291;>#4291)
https://github.com/eclipse/rdf4j/commit/5a3974c05c0ec49098df0fd4301d4f662ad10856;>5a3974c
https://github-redirect.dependabot.com/eclipse/rdf4j/issues/3781;>GH-3781
exception message changed
https://github.com/eclipse/rdf4j/commit/c9b12e54f25def13cee79b8dafdfbc23f9019141;>c9b12e5
https://github-redirect.dependabot.com/eclipse/rdf4j/issues/3781;>GH-3781
accept only valid SPARQL prefixes
https://github.com/eclipse/rdf4j/commit/d44a0f36ce2fbc8e38e3d4831ee96fb8a985008e;>d44a0f3
small tweaks to Dockerfile and build script (https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4285;>#4285)
https://github.com/eclipse/rdf4j/commit/679970777faa3693749c0b5c379a15e84d09de2b;>6799707
small tweaks to Dockerfile for better multiplatform support
https://github.com/eclipse/rdf4j/commit/352803f126fdf6b658285d8313914e8008d30b2f;>352803f
https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4237;>GH-4237
reorg and update of developer docs (https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4283;>#4283)
https://github.com/eclipse/rdf4j/commit/660de6fbbf772de84bf509fed968b7e7d2fe8f28;>660de6f
https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4248;>GH-4248
check for invalid triple context value (https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4282;>#4282)
https://github.com/eclipse/rdf4j/commit/336e00ca517f3d780e3c05540f628c2253fcf21a;>336e00c
https://github-redirect.dependabot.com/eclipse/rdf4j/issues/4279;>GH-4279
FilterOptimizer should not modify the query tree above the node it is...
[GitHub] [commons-bcel] dependabot[bot] opened a new pull request, #202: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] opened a new pull request, #202: URL: https://github.com/apache/commons-bcel/pull/202 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.0 to 3.2.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/9f6a75976c0b4b7f5d929de92ba02577f94005cf;>9f6a759 [maven-release-plugin] prepare release maven-checkstyle-plugin-3.2.1 https://github.com/apache/maven-checkstyle-plugin/commit/932c8bcd8953e3634cf8b409e276575c0ad60d3a;>932c8bc [MCHECKSTYLE-423] Explicitly start and end tables with Doxia Sinks in report ... https://github.com/apache/maven-checkstyle-plugin/commit/746a137e5fcf7d68fa7f98c98cfa6f33a7d64e6b;>746a137 update Reproducible Builds badge link https://github.com/apache/maven-checkstyle-plugin/commit/b07adb2e51d6b016dd564893685f46b33fffe5db;>b07adb2 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-3.2.0...maven-checkstyle-plugin-3.2.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] dependabot[bot] opened a new pull request, #115: Bump actions/cache from 3.2.2 to 3.2.3
dependabot[bot] opened a new pull request, #115: URL: https://github.com/apache/commons-rdf/pull/115 Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.2.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.2.3 What's Changed Add Mint example by https://github.com/uhooi;>@uhooi in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Fixed broken link by https://github.com/kotewar;>@kotewar in https://github-redirect.dependabot.com/actions/cache/pull/1057;>actions/cache#1057 Add support to opt-in enable cross-os caching on windows by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1056;>actions/cache#1056 Release support for cross-os caching as opt-in feature by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1060;>actions/cache#1060 New Contributors https://github.com/uhooi;>@uhooi made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Full Changelog: https://github.com/actions/cache/compare/v3...v3.2.3;>https://github.com/actions/cache/compare/v3...v3.2.3 Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.2.2 Reverted the changes made in 3.2.1 to use gnu tar and zstd by default on windows. 3.2.3 Support cross os caching on Windows as an opt-in feature. Fix issue with symlink restoration on Windows for cross-os caches. Commits https://github.com/actions/cache/commit/58c146cc91c5b9e778e71775dfe9bf1442ad9a12;>58c146c Release support for cross-os caching as opt-in feature (https://github-redirect.dependabot.com/actions/cache/issues/1060;>#1060) https://github.com/actions/cache/commit/6fd2d4538ca777f67fccddb233cf1a8ff1339012;>6fd2d45 Add support to opt-in enable cross-os caching on windows (https://github-redirect.dependabot.com/actions/cache/issues/1056;>#1056) https://github.com/actions/cache/commit/1f414295fe1e1bab9fb9b7ef11ce3f9fe556343c;>1f41429 Fixed broken link (https://github-redirect.dependabot.com/actions/cache/issues/1057;>#1057) https://github.com/actions/cache/commit/365406cb701e1cc758077b05049298a49a8b71c2;>365406c Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/1051;>#1051 from uhooi/feature/add_mint_example https://github.com/actions/cache/commit/d6217569d58fbcf42f4bdf873fd06820f76724c2;>d621756 Update Mint example https://github.com/actions/cache/commit/84e54000da2dc6a631a786445872e84be33086ea;>84e5400 Merge remote-tracking branch 'origin/main' into feature/add_mint_example See full diff in https://github.com/actions/cache/compare/v3.2.2...v3.2.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[GitHub] [commons-bcel] dependabot[bot] opened a new pull request, #201: Bump actions/cache from 3.2.2 to 3.2.3
dependabot[bot] opened a new pull request, #201: URL: https://github.com/apache/commons-bcel/pull/201 Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.2.3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.2.3 What's Changed Add Mint example by https://github.com/uhooi;>@uhooi in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Fixed broken link by https://github.com/kotewar;>@kotewar in https://github-redirect.dependabot.com/actions/cache/pull/1057;>actions/cache#1057 Add support to opt-in enable cross-os caching on windows by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1056;>actions/cache#1056 Release support for cross-os caching as opt-in feature by https://github.com/Phantsure;>@Phantsure in https://github-redirect.dependabot.com/actions/cache/pull/1060;>actions/cache#1060 New Contributors https://github.com/uhooi;>@uhooi made their first contribution in https://github-redirect.dependabot.com/actions/cache/pull/1051;>actions/cache#1051 Full Changelog: https://github.com/actions/cache/compare/v3...v3.2.3;>https://github.com/actions/cache/compare/v3...v3.2.3 Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. 3.2.2 Reverted the changes made in 3.2.1 to use gnu tar and zstd by default on windows. 3.2.3 Support cross os caching on Windows as an opt-in feature. Fix issue with symlink restoration on Windows for cross-os caches. Commits https://github.com/actions/cache/commit/58c146cc91c5b9e778e71775dfe9bf1442ad9a12;>58c146c Release support for cross-os caching as opt-in feature (https://github-redirect.dependabot.com/actions/cache/issues/1060;>#1060) https://github.com/actions/cache/commit/6fd2d4538ca777f67fccddb233cf1a8ff1339012;>6fd2d45 Add support to opt-in enable cross-os caching on windows (https://github-redirect.dependabot.com/actions/cache/issues/1056;>#1056) https://github.com/actions/cache/commit/1f414295fe1e1bab9fb9b7ef11ce3f9fe556343c;>1f41429 Fixed broken link (https://github-redirect.dependabot.com/actions/cache/issues/1057;>#1057) https://github.com/actions/cache/commit/365406cb701e1cc758077b05049298a49a8b71c2;>365406c Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/1051;>#1051 from uhooi/feature/add_mint_example https://github.com/actions/cache/commit/d6217569d58fbcf42f4bdf873fd06820f76724c2;>d621756 Update Mint example https://github.com/actions/cache/commit/84e54000da2dc6a631a786445872e84be33086ea;>84e5400 Merge remote-tracking branch 'origin/main' into feature/add_mint_example See full diff in https://github.com/actions/cache/compare/v3.2.2...v3.2.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[GitHub] [commons-fileupload] dependabot[bot] closed pull request #198: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] closed pull request #198: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 URL: https://github.com/apache/commons-fileupload/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #198: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1
dependabot[bot] commented on PR #198: URL: https://github.com/apache/commons-fileupload/pull/198#issuecomment-1382251405 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #141: Fixes many grammar issues and typos in JavaDoc and code comments
garydgregory commented on PR #141: URL: https://github.com/apache/commons-net/pull/141#issuecomment-1382246412 Run a local build with 'mvn' before creating a PR. The build is broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jxpath] garydgregory merged pull request #52: Bump actions/cache from 3.2.2 to 3.2.3
garydgregory merged PR #52: URL: https://github.com/apache/commons-jxpath/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
